1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
|
// Copyright 2024 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/media/webrtc/display_media_access_handler.h"
#include "base/run_loop.h"
#include "chrome/browser/content_settings/host_content_settings_map_factory.h"
#include "chrome/browser/media/webrtc/desktop_media_picker_manager.h"
#include "chrome/browser/media/webrtc/media_capture_devices_dispatcher.h"
#include "chrome/browser/media/webrtc/webrtc_browsertest_base.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/test/base/ui_test_utils.h"
#include "components/content_settings/core/browser/host_content_settings_map.h"
#include "content/public/test/browser_test.h"
#include "content/public/test/browser_test_utils.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/gfx/native_widget_types.h"
#include "ui/views/controls/webview/webview.h"
#include "ui/views/widget/widget.h"
#include "ui/views/widget/widget_delegate.h"
namespace {
class NonTabWebView : public views::WidgetDelegate, public views::WebView {
public:
NonTabWebView(content::BrowserContext* browser_context, const GURL& url) {
auto* widget = views::Widget::CreateWindowWithParent(
this, /*parent=*/gfx::NativeView());
widget->Show();
SetBrowserContext(browser_context);
LoadInitialURL(url);
content::WaitForLoadStop(GetWebContents());
}
// views::WidgetDelegate:
views::View* GetContentsView() override { return this; }
// views::WebView:
void RequestMediaAccessPermission(
content::WebContents* web_contents,
const content::MediaStreamRequest& request,
content::MediaResponseCallback callback) override {
MediaCaptureDevicesDispatcher::GetInstance()->ProcessMediaAccessRequest(
web_contents, request, std::move(callback), nullptr /* extension */);
}
bool CheckMediaAccessPermission(content::RenderFrameHost* render_frame_host,
const url::Origin& security_origin,
blink::mojom::MediaStreamType type) override {
return MediaCaptureDevicesDispatcher::GetInstance()
->CheckMediaAccessPermission(render_frame_host, security_origin, type);
}
};
} // namespace
class DisplayMediaAccessHandlerTest
: public testing::WithParamInterface<bool>,
public WebRtcTestBase,
public DesktopMediaPickerManager::DialogObserver {
public:
DisplayMediaAccessHandlerTest() = default;
~DisplayMediaAccessHandlerTest() override = default;
DisplayMediaAccessHandlerTest(const DisplayMediaAccessHandlerTest&) = delete;
DisplayMediaAccessHandlerTest& operator=(
const DisplayMediaAccessHandlerTest&) = delete;
void SetSystemAudioSetting(bool enabled) {
content::WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
HostContentSettingsMap* content_settings =
HostContentSettingsMapFactory::GetForProfile(
web_contents->GetBrowserContext());
content_settings->SetDefaultContentSetting(
ContentSettingsType::DISPLAY_MEDIA_SYSTEM_AUDIO,
enabled ? CONTENT_SETTING_ALLOW : CONTENT_SETTING_BLOCK);
}
// DesktopMediaPickerManager::DialogObserver implementation:
void OnDialogOpened(const DesktopMediaPicker::Params&) override {
dialog_opened_ = true;
if (run_loop_) {
run_loop_->Quit();
}
}
void OnDialogClosed() override {}
std::unique_ptr<base::RunLoop> run_loop_;
bool dialog_opened_ = false;
};
// Verify that the display media picker will show up by default.
IN_PROC_BROWSER_TEST_F(DisplayMediaAccessHandlerTest, ShowPickerByDefault) {
ASSERT_TRUE(embedded_test_server()->Start());
// Navigate to an empty page.
GURL url(embedded_test_server()->GetURL("/title1.html"));
EXPECT_TRUE(ui_test_utils::NavigateToURL(browser(), url));
DesktopMediaPickerManager* picker_manager = DesktopMediaPickerManager::Get();
picker_manager->AddObserver(this);
SetSystemAudioSetting(false);
content::WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
// If the video stream is requested, the picker should still show up.
run_loop_ = std::make_unique<base::RunLoop>();
EXPECT_EQ(true, content::EvalJs(web_contents->GetPrimaryMainFrame(),
R"((async () => {
navigator.mediaDevices.getDisplayMedia({
audio: true, systemAudio: 'include'});
return true;
})())"));
run_loop_->Run();
EXPECT_EQ(dialog_opened_, true);
}
// Verify that the request will be rejected when the video stream is not
// requested by default.
IN_PROC_BROWSER_TEST_F(DisplayMediaAccessHandlerTest, RejectNoVideoByDefault) {
ASSERT_TRUE(embedded_test_server()->Start());
// Navigate to an empty page.
GURL url(embedded_test_server()->GetURL("/title1.html"));
EXPECT_TRUE(ui_test_utils::NavigateToURL(browser(), url));
DesktopMediaPickerManager* picker_manager = DesktopMediaPickerManager::Get();
picker_manager->AddObserver(this);
SetSystemAudioSetting(false);
content::WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
EXPECT_THAT(content::EvalJs(web_contents->GetPrimaryMainFrame(),
R"((async () => {
return navigator.mediaDevices.getDisplayMedia({
audio: true, systemAudio: 'include', video: false});
})())")
.error,
testing::HasSubstr("Not supported"));
EXPECT_EQ(dialog_opened_, false);
}
// Verify that when `ContentSettingsType::DISPLAY_MEDIA_SYSTEM_AUDIO` is set,
// the display media selection dialog can be bypassed and the system audio track
// will be available by default.
IN_PROC_BROWSER_TEST_F(DisplayMediaAccessHandlerTest, ForceSystemAudio) {
ASSERT_TRUE(
ui_test_utils::NavigateToURL(browser(), GURL("chrome://version")));
DesktopMediaPickerManager* picker_manager = DesktopMediaPickerManager::Get();
picker_manager->AddObserver(this);
SetSystemAudioSetting(true);
content::WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
// It is expected to get a system audio track and no video track.
EXPECT_EQ(true, content::EvalJs(web_contents->GetPrimaryMainFrame(),
R"((async () => {
const mediaStream = await navigator.mediaDevices.getDisplayMedia({
audio: true, systemAudio: 'include', video: false});
return mediaStream.getAudioTracks().length == 1 &&
mediaStream.getVideoTracks().length == 0;
})())"));
EXPECT_EQ(dialog_opened_, false);
}
// Verify that `ContentSettingsType::DISPLAY_MEDIA_SYSTEM_AUDIO` does not work
// when the request is not from chrome://.
IN_PROC_BROWSER_TEST_F(DisplayMediaAccessHandlerTest,
ForceSystemAudioButWrongScheme) {
ASSERT_TRUE(embedded_test_server()->Start());
// Navigate to an empty page.
GURL url(embedded_test_server()->GetURL("/title1.html"));
EXPECT_TRUE(ui_test_utils::NavigateToURL(browser(), url));
DesktopMediaPickerManager* picker_manager = DesktopMediaPickerManager::Get();
picker_manager->AddObserver(this);
SetSystemAudioSetting(true);
content::WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
EXPECT_THAT(content::EvalJs(web_contents->GetPrimaryMainFrame(),
R"((async () => {
return navigator.mediaDevices.getDisplayMedia({
audio: true, systemAudio: 'include', video: false});
})())")
.error,
testing::HasSubstr("Not supported"));
EXPECT_EQ(dialog_opened_, false);
}
// Verify that `ContentSettingsType::DISPLAY_MEDIA_SYSTEM_AUDIO` does not work
// when the system audio is excluded and the request should be rejected.
IN_PROC_BROWSER_TEST_F(DisplayMediaAccessHandlerTest,
ForceSystemAudioButExcluded) {
ASSERT_TRUE(embedded_test_server()->Start());
// Navigate to an empty page.
GURL url(embedded_test_server()->GetURL("/title1.html"));
EXPECT_TRUE(ui_test_utils::NavigateToURL(browser(), url));
DesktopMediaPickerManager* picker_manager = DesktopMediaPickerManager::Get();
picker_manager->AddObserver(this);
SetSystemAudioSetting(true);
content::WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
EXPECT_THAT(content::EvalJs(web_contents->GetPrimaryMainFrame(),
R"((async () => {
return navigator.mediaDevices.getDisplayMedia({
audio: true, systemAudio: 'exclude', video: false});
})())")
.error,
testing::HasSubstr("Not supported"));
EXPECT_EQ(dialog_opened_, false);
}
// Verify that `ContentSettingsType::DISPLAY_MEDIA_SYSTEM_AUDIO` does not work
// when the video stream is requested and should fallback to the original
// behavior.
IN_PROC_BROWSER_TEST_F(DisplayMediaAccessHandlerTest,
ForceSystemAudioWithVideoStream) {
ASSERT_TRUE(embedded_test_server()->Start());
// Navigate to an empty page.
GURL url(embedded_test_server()->GetURL("/title1.html"));
EXPECT_TRUE(ui_test_utils::NavigateToURL(browser(), url));
DesktopMediaPickerManager* picker_manager = DesktopMediaPickerManager::Get();
picker_manager->AddObserver(this);
SetSystemAudioSetting(true);
content::WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
// If the video stream is requested, the picker should still show up.
run_loop_ = std::make_unique<base::RunLoop>();
EXPECT_EQ(true, content::EvalJs(web_contents->GetPrimaryMainFrame(),
R"((async () => {
navigator.mediaDevices.getDisplayMedia({
audio: true, systemAudio: 'include', video: true});
return true;
})())"));
run_loop_->Run();
EXPECT_EQ(dialog_opened_, true);
}
// Verify that showing media picker for a non-tab WebContents does not crash.
IN_PROC_BROWSER_TEST_F(DisplayMediaAccessHandlerTest, NonTabWebContents) {
ASSERT_TRUE(embedded_test_server()->Start());
// Creates a non-tab WebContents.
auto* webview = new NonTabWebView(
browser()->profile(), embedded_test_server()->GetURL("/title1.html"));
content::WebContents* web_contents = webview->GetWebContents();
// Media picker dialog should show as a standalone window and no crash.
DesktopMediaPickerManager* picker_manager = DesktopMediaPickerManager::Get();
picker_manager->AddObserver(this);
run_loop_ = std::make_unique<base::RunLoop>();
EXPECT_EQ(true, content::EvalJs(web_contents->GetPrimaryMainFrame(),
R"((async () => {
navigator.mediaDevices.getDisplayMedia({audio: true, video: true});
return true;
})())"));
run_loop_->Run();
EXPECT_EQ(dialog_opened_, true);
}
|
