1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319
|
// Copyright 2013 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <stddef.h>
#include <stdint.h>
#include <utility>
#include "base/files/file_path.h"
#include "base/files/file_util.h"
#include "base/files/scoped_temp_dir.h"
#include "base/functional/bind.h"
#include "base/functional/callback_helpers.h"
#include "base/location.h"
#include "base/path_service.h"
#include "base/run_loop.h"
#include "base/task/sequenced_task_runner.h"
#include "base/task/task_traits.h"
#include "base/task/thread_pool.h"
#include "build/build_config.h"
#include "chrome/browser/media_galleries/fileapi/media_file_system_backend.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "content/public/browser/browser_task_traits.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/test/browser_test.h"
#include "storage/browser/file_system/copy_or_move_file_validator.h"
#include "storage/browser/file_system/copy_or_move_hook_delegate.h"
#include "storage/browser/file_system/file_system_backend.h"
#include "storage/browser/file_system/file_system_context.h"
#include "storage/browser/file_system/file_system_operation_runner.h"
#include "storage/browser/file_system/file_system_url.h"
#include "storage/browser/file_system/isolated_context.h"
#include "storage/browser/quota/quota_manager_proxy.h"
#include "storage/browser/test/test_file_system_backend.h"
#include "storage/browser/test/test_file_system_context.h"
#include "storage/common/file_system/file_system_types.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/blink/public/common/storage_key/storage_key.h"
#include "url/gurl.h"
#include "url/origin.h"
namespace {
const char kOrigin[] = "http://foo";
const char kValidImage[] = "RIFF0\0\0\0WEBPVP8 $\0\0\0\xB2\x02\0\x9D\x01\x2A"
"\x01\0\x01\0\x2F\x9D\xCE\xE7s\xA8((((\x01\x9CK(\0"
"\x05\xCE\xB3l\0\0\xFE\xD8\x80\0\0";
const char kInvalidMediaFile[] = "Not a media file";
const int64_t kNoFileSize = -1;
void HandleCheckFileResult(int64_t expected_size,
base::OnceCallback<void(bool success)> callback,
base::File::Error result,
const base::File::Info& file_info) {
if (result == base::File::FILE_OK) {
if (!file_info.is_directory && expected_size != kNoFileSize &&
file_info.size == expected_size) {
std::move(callback).Run(true);
return;
}
}
std::move(callback).Run(expected_size == kNoFileSize);
}
base::FilePath GetMediaTestDir() {
base::FilePath test_file;
if (!base::PathService::Get(base::DIR_SRC_TEST_DATA_ROOT, &test_file)) {
return base::FilePath();
}
return test_file.AppendASCII("media").AppendASCII("test").AppendASCII("data");
}
} // namespace
class MediaFileValidatorTest : public InProcessBrowserTest {
public:
MediaFileValidatorTest() : test_file_size_(0) {}
MediaFileValidatorTest(const MediaFileValidatorTest&) = delete;
MediaFileValidatorTest& operator=(const MediaFileValidatorTest&) = delete;
~MediaFileValidatorTest() override = default;
// Write |content| into |filename| in a test file system and try to move
// it into a media file system. The result is compared to |expected_result|.
void MoveTest(const std::string& filename, const std::string& content,
bool expected_result) {
base::RunLoop run_loop;
quit_closure_ = run_loop.QuitClosure();
base::ThreadPool::PostTask(
FROM_HERE, {base::MayBlock()},
base::BindOnce(&MediaFileValidatorTest::SetupBlocking,
base::Unretained(this), filename, content,
expected_result));
run_loop.Run();
}
// Write |source| into |filename| in a test file system and try to move it
// into a media file system. The result is compared to |expected_result|.
void MoveTestFromFile(const std::string& filename,
const base::FilePath& source, bool expected_result) {
base::RunLoop run_loop;
quit_closure_ = run_loop.QuitClosure();
base::ThreadPool::PostTask(
FROM_HERE, {base::MayBlock()},
base::BindOnce(&MediaFileValidatorTest::SetupFromFileBlocking,
base::Unretained(this), filename, source,
expected_result));
run_loop.Run();
}
private:
// BrowserTestBase interface.
void PostRunTestOnMainThread() override {
// Trigger release of the FileSystemContext before the IO thread is gone,
// so it can teardown there correctly.
file_system_context_ = nullptr;
InProcessBrowserTest::PostRunTestOnMainThread();
}
// Create the test files, filesystem objects, etc.
void SetupBlocking(const std::string& filename,
const std::string& content,
bool expected_result) {
ASSERT_TRUE(base_dir_.CreateUniqueTempDir());
base::FilePath base = base_dir_.GetPath();
base::FilePath src_path = base.AppendASCII("src_fs");
ASSERT_TRUE(base::CreateDirectory(src_path));
std::vector<std::unique_ptr<storage::FileSystemBackend>>
additional_providers;
file_system_runner_ =
base::ThreadPool::CreateSequencedTaskRunner({base::MayBlock()});
additional_providers.push_back(
std::make_unique<storage::TestFileSystemBackend>(
file_system_runner_.get(), src_path));
additional_providers.push_back(
std::make_unique<MediaFileSystemBackend>(base, base::NullCallback()));
file_system_context_ =
storage::CreateFileSystemContextWithAdditionalProvidersForTesting(
content::GetIOThreadTaskRunner({}), file_system_runner_,
/*quota_manager_proxy=*/nullptr, std::move(additional_providers),
base);
move_src_ = file_system_context_->CreateCrackedFileSystemURL(
blink::StorageKey::CreateFromStringForTesting(kOrigin),
storage::kFileSystemTypeTest, base::FilePath::FromUTF8Unsafe(filename));
test_file_size_ = content.size();
base::FilePath test_file = src_path.AppendASCII(filename);
ASSERT_TRUE(base::WriteFile(test_file, content));
base::FilePath dest_path = base.AppendASCII("dest_fs");
ASSERT_TRUE(base::CreateDirectory(dest_path));
dest_fs_ =
storage::IsolatedContext::GetInstance()->RegisterFileSystemForPath(
storage::kFileSystemTypeLocalMedia, std::string(), dest_path,
nullptr);
size_t extension_index = filename.find_last_of(".");
ASSERT_NE(std::string::npos, extension_index);
std::string extension = filename.substr(extension_index);
std::string dest_root_fs_url = storage::GetIsolatedFileSystemRootURIString(
GURL(kOrigin), dest_fs_.id(), "dest_fs/");
const GURL crack_url = GURL(dest_root_fs_url + "move_dest" + extension);
move_dest_ = file_system_context_->CrackURLInFirstPartyContext(crack_url);
content::GetIOThreadTaskRunner({})->PostTask(
FROM_HERE,
base::BindOnce(
&MediaFileValidatorTest::CheckFiles, base::Unretained(this), true,
base::BindOnce(&MediaFileValidatorTest::OnTestFilesReady,
base::Unretained(this), expected_result)));
}
void SetupFromFileBlocking(const std::string& filename,
const base::FilePath& source,
bool expected_result) {
std::string content;
ASSERT_TRUE(base::ReadFileToString(source, &content));
SetupBlocking(filename, content, expected_result);
}
// Check that exactly one of |move_src_| and |move_dest_| exists.
// |src_expected| indicates which one should exist. When complete,
// |callback| is called with success/failure.
void CheckFiles(bool src_expected,
base::OnceCallback<void(bool success)> callback) {
CheckFile(move_src_, src_expected ? test_file_size_ : kNoFileSize,
base::BindOnce(&MediaFileValidatorTest::OnCheckFilesFirstResult,
base::Unretained(this), !src_expected,
std::move(callback)));
}
// Helper that checks a file has the |expected_size|, which may be
// |kNoFileSize| if the file should not exist. |callback| is called
// with success/failure.
void CheckFile(storage::FileSystemURL url,
int64_t expected_size,
base::OnceCallback<void(bool success)> callback) {
operation_runner()->GetMetadata(
url, {storage::FileSystemOperation::GetMetadataField::kSize},
base::BindOnce(&HandleCheckFileResult, expected_size,
std::move(callback)));
}
// Helper that checks the result of |move_src_| lookup and then checks
// |move_dest_| if all is as expected.
void OnCheckFilesFirstResult(bool dest_expected,
base::OnceCallback<void(bool)> callback,
bool src_result) {
EXPECT_TRUE(src_result);
if (!src_result) {
std::move(callback).Run(false);
return;
}
CheckFile(move_dest_, dest_expected ? test_file_size_ : kNoFileSize,
std::move(callback));
}
// Assert |test_files_ready| and then do the actual test of moving
// |move_src_| to |move_dest_|.
void OnTestFilesReady(bool expected_result, bool test_files_ready) {
ASSERT_TRUE(test_files_ready);
operation_runner()->Move(
move_src_, move_dest_,
storage::FileSystemOperation::CopyOrMoveOptionSet(),
storage::FileSystemOperation::ERROR_BEHAVIOR_ABORT,
std::make_unique<storage::CopyOrMoveHookDelegate>(),
base::BindOnce(&MediaFileValidatorTest::OnMoveResult,
base::Unretained(this), expected_result));
}
// Check that the move succeeded/failed based on expectation and then
// check that the right file exists.
void OnMoveResult(bool expected_result, base::File::Error result) {
if (expected_result)
EXPECT_EQ(base::File::FILE_OK, result);
else
EXPECT_EQ(base::File::FILE_ERROR_SECURITY, result);
CheckFiles(!expected_result,
base::BindOnce(&MediaFileValidatorTest::OnTestFilesCheckResult,
base::Unretained(this)));
}
// Check that the correct test file exists and then allow the main-thread
// RunLoop to quit.
void OnTestFilesCheckResult(bool result) {
EXPECT_TRUE(result);
std::move(quit_closure_).Run();
}
storage::FileSystemOperationRunner* operation_runner() {
return file_system_context_->operation_runner();
}
base::ScopedTempDir base_dir_;
scoped_refptr<storage::FileSystemContext> file_system_context_;
int test_file_size_;
storage::FileSystemURL move_src_;
storage::FileSystemURL move_dest_;
storage::IsolatedContext::ScopedFSHandle dest_fs_;
base::OnceClosure quit_closure_;
scoped_refptr<base::SequencedTaskRunner> file_system_runner_;
};
IN_PROC_BROWSER_TEST_F(MediaFileValidatorTest, UnsupportedExtension) {
MoveTest("a.txt", std::string(kValidImage, std::size(kValidImage)), false);
}
// TODO(crbug.com/40744004): Re-enable. Flaky on Linux.
#if BUILDFLAG(IS_LINUX)
#define MAYBE_ValidImage DISABLED_ValidImage
#else
#define MAYBE_ValidImage ValidImage
#endif
IN_PROC_BROWSER_TEST_F(MediaFileValidatorTest, MAYBE_ValidImage) {
MoveTest("a.webp", std::string(kValidImage, std::size(kValidImage)), true);
}
IN_PROC_BROWSER_TEST_F(MediaFileValidatorTest, InvalidImage) {
MoveTest("a.webp",
std::string(kInvalidMediaFile, std::size(kInvalidMediaFile)), false);
}
IN_PROC_BROWSER_TEST_F(MediaFileValidatorTest, InvalidAudio) {
MoveTest("a.ogg",
std::string(kInvalidMediaFile, std::size(kInvalidMediaFile)), false);
}
IN_PROC_BROWSER_TEST_F(MediaFileValidatorTest, ValidAudio) {
base::FilePath test_file = GetMediaTestDir();
ASSERT_FALSE(test_file.empty());
test_file = test_file.AppendASCII("sfx.ogg");
MoveTestFromFile("sfx.ogg", test_file, true);
}
IN_PROC_BROWSER_TEST_F(MediaFileValidatorTest, InvalidVideo) {
base::FilePath test_file = GetMediaTestDir();
ASSERT_FALSE(test_file.empty());
test_file = test_file.AppendASCII("no_streams.webm");
MoveTestFromFile("no_streams.webm", test_file, false);
}
IN_PROC_BROWSER_TEST_F(MediaFileValidatorTest, ValidVideo) {
base::FilePath test_file = GetMediaTestDir();
ASSERT_FALSE(test_file.empty());
test_file = test_file.AppendASCII("bear-320x240-multitrack.webm");
MoveTestFromFile("multitrack.webm", test_file, true);
}
|