1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507
|
// Copyright 2012 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Tests the MetricsService stat recording to make sure that the numbers are
// what we expect.
#include "components/metrics/metrics_service.h"
#include <string>
#include "base/command_line.h"
#include "base/files/file_enumerator.h"
#include "base/files/file_path.h"
#include "base/files/file_util.h"
#include "base/path_service.h"
#include "base/process/memory.h"
#include "base/test/metrics/histogram_tester.h"
#include "base/test/scoped_feature_list.h"
#include "base/test/task_environment.h"
#include "base/threading/thread_restrictions.h"
#include "build/build_config.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/metrics/chrome_metrics_service_accessor.h"
#include "chrome/browser/metrics/chrome_metrics_service_client.h"
#include "chrome/browser/metrics/chrome_metrics_services_manager_client.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/common/chrome_paths.h"
#include "chrome/common/url_constants.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/ui_test_utils.h"
#include "components/metrics/enabled_state_provider.h"
#include "components/metrics/metrics_pref_names.h"
#include "components/metrics/metrics_reporting_default_state.h"
#include "components/metrics/metrics_service.h"
#include "components/metrics/metrics_switches.h"
#include "components/metrics/persistent_histograms.h"
#include "components/metrics/stability_metrics_helper.h"
#include "components/metrics_services_manager/metrics_services_manager.h"
#include "components/prefs/json_pref_store.h"
#include "components/prefs/pref_service.h"
#include "content/public/common/content_switches.h"
#include "content/public/test/browser_test.h"
#include "content/public/test/browser_test_utils.h"
#include "net/base/filename_util.h"
#include "testing/gmock/include/gmock/gmock-matchers.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "third_party/blink/public/common/chrome_debug_urls.h"
#include "ui/base/window_open_disposition.h"
#include "url/gurl.h"
#if BUILDFLAG(IS_POSIX)
#include <sys/wait.h>
#endif
#if BUILDFLAG(IS_WIN)
#include "sandbox/win/src/sandbox_types.h"
#endif
namespace {
#if BUILDFLAG(IS_WIN)
void VerifyRendererExitCodeIsSignal(
const base::HistogramTester& histogram_tester,
int signal) {
histogram_tester.ExpectUniqueSample(
"CrashExitCodes.Renderer", std::abs(static_cast<int32_t>(signal)), 1);
}
#elif BUILDFLAG(IS_MAC) || BUILDFLAG(IS_LINUX) || BUILDFLAG(IS_CHROMEOS)
// Check CrashExitCodes.Renderer histogram for a single bucket entry and then
// verify that the bucket entry contains a signal and the signal is |signal|.
void VerifyRendererExitCodeIsSignal(
const base::HistogramTester& histogram_tester,
int signal) {
const auto buckets =
histogram_tester.GetAllSamples("CrashExitCodes.Renderer");
ASSERT_EQ(1UL, buckets.size());
EXPECT_EQ(1, buckets[0].count);
int32_t exit_code = buckets[0].min;
EXPECT_TRUE(WIFSIGNALED(exit_code));
EXPECT_EQ(signal, WTERMSIG(exit_code));
}
#endif // BUILDFLAG(IS_MAC) || BUILDFLAG(IS_LINUX) || BUILDFLAG(IS_CHROMEOS)
} // namespace
// This test class verifies that metrics reporting works correctly for various
// renderer behaviors such as page loads, recording crashed tabs, and browser
// starts. It also verifies that if a renderer process crashes, the correct exit
// code is recorded.
//
// TODO(isherman): We should also verify that
// metrics::prefs::kStabilityExitedCleanly is set correctly after each of these
// tests, but this preference isn't set until the browser exits... it's not
// clear to me how to test that.
class MetricsServiceBrowserTest : public InProcessBrowserTest {
public:
MetricsServiceBrowserTest() = default;
MetricsServiceBrowserTest(const MetricsServiceBrowserTest&) = delete;
MetricsServiceBrowserTest& operator=(const MetricsServiceBrowserTest&) =
delete;
void SetUpCommandLine(base::CommandLine* command_line) override {
// Enable the metrics service for testing (in recording-only mode).
metrics::EnableMetricsRecordingOnlyForTesting(command_line);
}
void SetUp() override {
ChromeMetricsServiceAccessor::SetMetricsAndCrashReportingForTesting(
&metrics_consent_);
InProcessBrowserTest::SetUp();
}
// Open three tabs then navigate to |crashy_url| and wait for the renderer to
// crash.
void OpenTabsAndNavigateToCrashyUrl(const std::string& crashy_url) {
// Opens three tabs.
OpenThreeTabs();
// Kill the process for one of the tabs by navigating to |crashy_url|.
content::RenderProcessHostWatcher observer(
browser()->tab_strip_model()->GetActiveWebContents(),
content::RenderProcessHostWatcher::WATCH_FOR_PROCESS_EXIT);
// Opens one tab.
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), GURL(crashy_url)));
observer.Wait();
// The MetricsService listens for the same notification, so the observer
// might finish waiting before the MetricsService has processed the
// notification. To avoid racing here, we repeatedly run the message loop.
content::RunAllPendingInMessageLoop();
}
// Open a couple of tabs of random content.
//
// Calling this method causes three page load events:
// 1. title2.html
// 2. iframe.html
// 3. title1.html (iframed by iframe.html)
void OpenThreeTabs() {
const int kBrowserTestFlags =
ui_test_utils::BROWSER_TEST_WAIT_FOR_TAB |
ui_test_utils::BROWSER_TEST_WAIT_FOR_LOAD_STOP;
base::FilePath test_directory;
ASSERT_TRUE(base::PathService::Get(chrome::DIR_TEST_DATA, &test_directory));
base::FilePath page1_path = test_directory.AppendASCII("title2.html");
ui_test_utils::NavigateToURLWithDisposition(
browser(), net::FilePathToFileURL(page1_path),
WindowOpenDisposition::NEW_FOREGROUND_TAB, kBrowserTestFlags);
base::FilePath page2_path = test_directory.AppendASCII("iframe.html");
ui_test_utils::NavigateToURLWithDisposition(
browser(), net::FilePathToFileURL(page2_path),
WindowOpenDisposition::NEW_FOREGROUND_TAB, kBrowserTestFlags);
}
private:
bool metrics_consent_ = true;
};
IN_PROC_BROWSER_TEST_F(MetricsServiceBrowserTest, CloseRenderersNormally) {
base::HistogramTester histogram_tester;
OpenThreeTabs();
// Verify that the expected stability metrics were recorded.
histogram_tester.ExpectBucketCount("Stability.Counts2",
metrics::StabilityEventType::kPageLoad, 2);
histogram_tester.ExpectBucketCount(
"Stability.Counts2", metrics::StabilityEventType::kRendererCrash, 0);
}
// Child crashes fail the process on ASan (see crbug.com/411251,
// crbug.com/368525).
// Note to sheriffs: Do not disable these tests if they starts to flake. If
// either of these tests start to fail then changes likely need to be made
// elsewhere in crash processing, metrics analysis, and dashboards. Please
// consult Stability Team before disabling.
#if defined(ADDRESS_SANITIZER)
#define MAYBE_CrashRenderers DISABLED_CrashRenderers
#define MAYBE_CheckCrashRenderers DISABLED_CheckCrashRenderers
#else
#define MAYBE_CrashRenderers CrashRenderers
#define MAYBE_CheckCrashRenderers CheckCrashRenderers
#endif
IN_PROC_BROWSER_TEST_F(MetricsServiceBrowserTest, MAYBE_CrashRenderers) {
base::HistogramTester histogram_tester;
OpenTabsAndNavigateToCrashyUrl(blink::kChromeUICrashURL);
// Verify that the expected stability metrics were recorded.
// The three tabs from OpenTabs() and the one tab to open chrome://crash/.
histogram_tester.ExpectBucketCount("Stability.Counts2",
metrics::StabilityEventType::kPageLoad, 3);
histogram_tester.ExpectBucketCount(
"Stability.Counts2", metrics::StabilityEventType::kRendererCrash, 1);
#if BUILDFLAG(IS_WIN)
// Consult Stability Team before changing this test as it's recorded to
// histograms and used for stability measurement.
VerifyRendererExitCodeIsSignal(histogram_tester, STATUS_ACCESS_VIOLATION);
#elif BUILDFLAG(IS_MAC) || BUILDFLAG(IS_LINUX) || BUILDFLAG(IS_CHROMEOS)
VerifyRendererExitCodeIsSignal(histogram_tester, SIGSEGV);
#endif
}
// Test is disabled on Windows AMR64 because
// TerminateWithHeapCorruption() isn't expected to work there.
// See: https://crbug.com/1054423
#if BUILDFLAG(IS_WIN)
// TODO(crbug.com/380550755): Unfortuntely, it's flaky on non-arm64.
// Previously, this was turned off only if defined(ARCH_CPU_ARM64).
IN_PROC_BROWSER_TEST_F(MetricsServiceBrowserTest,
DISABLED_HeapCorruptionInRenderer) {
base::HistogramTester histogram_tester;
OpenTabsAndNavigateToCrashyUrl(blink::kChromeUIHeapCorruptionCrashURL);
// Verify that the expected stability metrics were recorded.
// The three tabs from OpenTabs() and the one tab to open chrome://crash/.
histogram_tester.ExpectBucketCount("Stability.Counts2",
metrics::StabilityEventType::kPageLoad, 3);
histogram_tester.ExpectBucketCount(
"Stability.Counts2", metrics::StabilityEventType::kRendererCrash, 1);
histogram_tester.ExpectUniqueSample(
"CrashExitCodes.Renderer",
std::abs(static_cast<int32_t>(STATUS_HEAP_CORRUPTION)), 1);
LOG(INFO) << histogram_tester.GetAllHistogramsRecorded();
}
#endif // BUILDFLAG(IS_WIN)
IN_PROC_BROWSER_TEST_F(MetricsServiceBrowserTest, MAYBE_CheckCrashRenderers) {
base::HistogramTester histogram_tester;
OpenTabsAndNavigateToCrashyUrl(blink::kChromeUICheckCrashURL);
// Verify that the expected stability metrics were recorded.
// The three tabs from OpenTabs() and the one tab to open
// chrome://checkcrash/.
histogram_tester.ExpectBucketCount("Stability.Counts2",
metrics::StabilityEventType::kPageLoad, 3);
histogram_tester.ExpectBucketCount(
"Stability.Counts2", metrics::StabilityEventType::kRendererCrash, 1);
#if BUILDFLAG(IS_WIN)
// Consult Stability Team before changing this test as it's recorded to
// histograms and used for stability measurement.
VerifyRendererExitCodeIsSignal(histogram_tester, STATUS_BREAKPOINT);
#elif BUILDFLAG(IS_MAC)
VerifyRendererExitCodeIsSignal(histogram_tester, SIGTRAP);
#elif BUILDFLAG(IS_LINUX) || BUILDFLAG(IS_CHROMEOS)
#if defined(OFFICIAL_BUILD)
VerifyRendererExitCodeIsSignal(histogram_tester, SIGILL);
#else
VerifyRendererExitCodeIsSignal(histogram_tester, SIGSEGV);
#endif // defined(OFFICIAL_BUILD)
#endif
}
IN_PROC_BROWSER_TEST_F(MetricsServiceBrowserTest, CrashRenderersInRust) {
base::HistogramTester histogram_tester;
OpenTabsAndNavigateToCrashyUrl(blink::kChromeUICrashRustURL);
// Verify that the expected stability metrics were recorded.
// The three tabs from OpenTabs() and the one tab to open
// chrome://crash/rust/.
histogram_tester.ExpectBucketCount("Stability.Counts2",
metrics::StabilityEventType::kPageLoad, 3);
histogram_tester.ExpectBucketCount(
"Stability.Counts2", metrics::StabilityEventType::kRendererCrash, 1);
}
// OOM code only works on Windows.
#if BUILDFLAG(IS_WIN) && !defined(ADDRESS_SANITIZER)
IN_PROC_BROWSER_TEST_F(MetricsServiceBrowserTest, OOMRenderers) {
// Disable stack traces during this test since DbgHelp is unreliable in
// low-memory conditions (see crbug.com/692564).
base::CommandLine::ForCurrentProcess()->AppendSwitch(
switches::kDisableInProcessStackTraces);
base::HistogramTester histogram_tester;
OpenTabsAndNavigateToCrashyUrl(blink::kChromeUIMemoryExhaustURL);
// Verify that the expected stability metrics were recorded.
// The three tabs from OpenTabs() and the one tab to open
// chrome://memory-exhaust/.
histogram_tester.ExpectBucketCount("Stability.Counts2",
metrics::StabilityEventType::kPageLoad, 3);
histogram_tester.ExpectBucketCount(
"Stability.Counts2", metrics::StabilityEventType::kRendererCrash, 1);
// On 64-bit, the Job object should terminate the renderer on an OOM. However,
// if the system is low on memory already, then the allocator might just return
// a normal OOM before hitting the Job limit.
// Note: Exit codes are recorded after being passed through std::abs see
// MapCrashExitCodeForHistogram.
#if defined(ARCH_CPU_64_BITS)
const base::Bucket expected_possible_exit_codes[] = {
base::Bucket(
std::abs(static_cast<int32_t>(sandbox::SBOX_FATAL_MEMORY_EXCEEDED)),
1),
base::Bucket(std::abs(static_cast<int32_t>(base::win::kOomExceptionCode)),
1)};
#else
const base::Bucket expected_possible_exit_codes[] = {base::Bucket(
std::abs(static_cast<int32_t>(base::win::kOomExceptionCode)), 1)};
#endif
EXPECT_THAT(histogram_tester.GetAllSamples("CrashExitCodes.Renderer"),
::testing::IsSubsetOf(expected_possible_exit_codes));
}
#endif // BUILDFLAG(IS_WIN) && !defined(ADDRESS_SANITIZER)
// Base class for testing if browser-metrics files get removed or not.
// The code under tests is run before any actual test methods so the test
// conditions must be created during SetUp in order to affect said code.
class MetricsServiceBrowserFilesTest : public InProcessBrowserTest {
using super = InProcessBrowserTest;
public:
MetricsServiceBrowserFilesTest() = default;
MetricsServiceBrowserFilesTest(const MetricsServiceBrowserFilesTest&) =
delete;
MetricsServiceBrowserFilesTest& operator=(
const MetricsServiceBrowserFilesTest&) = delete;
bool SetUpUserDataDirectory() override {
if (!super::SetUpUserDataDirectory()) {
return false;
}
base::ScopedAllowBlockingForTesting allow_blocking;
base::FilePath user_dir;
CHECK(base::PathService::Get(chrome::DIR_USER_DATA, &user_dir));
// Create a local-state file with what we want the browser to use. This
// has to be done here because there is no hook between when the browser
// is initialized and the metrics-client acts on the pref values. The
// "Local State" directory is hard-coded because the FILE_LOCAL_STATE
// path is not yet defined at this point.
{
base::test::TaskEnvironment task_env;
auto state = base::MakeRefCounted<JsonPrefStore>(
user_dir.Append(FILE_PATH_LITERAL("Local State")));
state->SetValue(metrics::prefs::kMetricsDefaultOptIn,
base::Value(metrics::EnableMetricsDefault::OPT_OUT), 0);
}
// Create the upload dir. Note that ASSERT macros won't fail in SetUp,
// hence the use of CHECK.
upload_dir_ = user_dir.AppendASCII(kBrowserMetricsName);
CHECK(!base::PathExists(upload_dir_));
CHECK(base::CreateDirectory(upload_dir_));
// Create a file inside the upload dir that can be watched to see if an
// attempt was made to delete everything.
base::File upload_file(
upload_dir().AppendASCII("foo.bar"),
base::File::FLAG_CREATE_ALWAYS | base::File::FLAG_WRITE);
CHECK(upload_file.WriteAtCurrentPosAndCheck(
base::byte_span_from_cstring("foobar")));
return true;
}
void SetUp() override {
ChromeMetricsServiceAccessor::SetMetricsAndCrashReportingForTesting(
&metrics_consent_);
metrics::EnabledStateProvider::SetIgnoreForceFieldTrialsForTesting(true);
super::SetUp();
}
// Finds any non-pma files that were created as part of the test. PMA files
// may be created as part of the browser setup and cannot be deleted while
// open on all operating systems.
std::vector<base::FilePath> FindNonPMAFiles() {
base::ScopedAllowBlockingForTesting allow_blocking;
std::vector<base::FilePath> files;
if (!base::PathExists(upload_dir_)) {
return files;
}
base::FileEnumerator file_iter(upload_dir_, true,
base::FileEnumerator::FILES);
while (!file_iter.Next().empty()) {
base::FilePath name = file_iter.GetInfo().GetName();
if (name.Extension() != FILE_PATH_LITERAL(".pma")) {
files.push_back(std::move(name));
}
}
return files;
}
bool HasNonPMAFiles() {
return !FindNonPMAFiles().empty();
}
base::FilePath& upload_dir() { return upload_dir_; }
void set_metrics_consent(bool enabled) { metrics_consent_ = enabled; }
private:
bool metrics_consent_ = true;
base::FilePath upload_dir_;
};
// Specific class for testing when metrics upload is fully enabled.
class MetricsServiceBrowserDoUploadTest
: public MetricsServiceBrowserFilesTest {
public:
MetricsServiceBrowserDoUploadTest() = default;
MetricsServiceBrowserDoUploadTest(const MetricsServiceBrowserDoUploadTest&) =
delete;
MetricsServiceBrowserDoUploadTest& operator=(
const MetricsServiceBrowserDoUploadTest&) = delete;
void SetUp() override {
set_metrics_consent(true);
feature_list_.InitAndEnableFeature(
metrics::internal::kMetricsReportingFeature);
MetricsServiceBrowserFilesTest::SetUp();
}
private:
base::test::ScopedFeatureList feature_list_;
};
IN_PROC_BROWSER_TEST_F(MetricsServiceBrowserDoUploadTest, FilesRemain) {
// SetUp() has provided consent and made metrics "sampled-in" (enabled).
EXPECT_TRUE(HasNonPMAFiles());
}
// Specific class for testing when metrics upload is explicitly disabled.
class MetricsServiceBrowserNoUploadTest
: public MetricsServiceBrowserFilesTest {
public:
MetricsServiceBrowserNoUploadTest() = default;
MetricsServiceBrowserNoUploadTest(const MetricsServiceBrowserNoUploadTest&) =
delete;
MetricsServiceBrowserNoUploadTest& operator=(
const MetricsServiceBrowserNoUploadTest&) = delete;
void SetUp() override {
set_metrics_consent(false);
feature_list_.InitAndEnableFeature(
metrics::internal::kMetricsReportingFeature);
MetricsServiceBrowserFilesTest::SetUp();
}
private:
base::test::ScopedFeatureList feature_list_;
};
IN_PROC_BROWSER_TEST_F(MetricsServiceBrowserNoUploadTest, FilesRemoved) {
// SetUp() has removed consent and made metrics "sampled-in" (enabled).
auto non_pma_files = FindNonPMAFiles();
for (const auto& file : non_pma_files) {
LOG(INFO) << "Found non-PMA file:" << file;
}
EXPECT_TRUE(non_pma_files.empty());
}
// Specific class for testing when metrics upload is disabled by sampling.
class MetricsServiceBrowserSampledOutTest
: public MetricsServiceBrowserFilesTest {
public:
MetricsServiceBrowserSampledOutTest() = default;
MetricsServiceBrowserSampledOutTest(
const MetricsServiceBrowserSampledOutTest&) = delete;
MetricsServiceBrowserSampledOutTest& operator=(
const MetricsServiceBrowserSampledOutTest&) = delete;
void SetUp() override {
set_metrics_consent(true);
feature_list_.InitAndDisableFeature(
metrics::internal::kMetricsReportingFeature);
MetricsServiceBrowserFilesTest::SetUp();
}
private:
base::test::ScopedFeatureList feature_list_;
};
IN_PROC_BROWSER_TEST_F(MetricsServiceBrowserSampledOutTest, FilesRemoved) {
// SetUp() has provided consent and made metrics "sampled-out" (disabled).
auto non_pma_files = FindNonPMAFiles();
for (const auto& file : non_pma_files) {
LOG(INFO) << "Found non-PMA file:" << file;
}
EXPECT_TRUE(non_pma_files.empty());
}
|