1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
|
// Copyright 2020 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/net/stub_resolver_config_reader.h"
#include <memory>
#include "base/test/task_environment.h"
#include "base/values.h"
#include "chrome/browser/net/default_dns_over_https_config_source.h"
#include "chrome/browser/net/dns_over_https_config_source.h"
#include "chrome/browser/net/secure_dns_config.h"
#include "chrome/common/pref_names.h"
#include "chrome/test/base/scoped_testing_local_state.h"
#include "components/prefs/pref_service.h"
#include "components/prefs/testing_pref_service.h"
#include "content/public/test/browser_task_environment.h"
#include "net/dns/public/dns_over_https_config.h"
#include "net/dns/public/secure_dns_mode.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace {
constexpr char kDohConfigString[] =
"https://doh1.test https://doh2.test/query{?dns}";
const std::string kDnsOverHttpsTemplatesPrefName =
prefs::kDnsOverHttpsTemplates;
// Override the reader to mock out the ShouldDisableDohFor...() methods.
class MockedStubResolverConfigReader : public StubResolverConfigReader {
public:
explicit MockedStubResolverConfigReader(PrefService* local_state)
: StubResolverConfigReader(local_state,
false /* set_up_pref_defaults */) {}
bool ShouldDisableDohForManaged() override { return disable_for_managed_; }
bool ShouldDisableDohForParentalControls() override {
parental_controls_checked_ = true;
return disable_for_parental_controls_;
}
void set_disable_for_managed() { disable_for_managed_ = true; }
void set_disable_for_parental_controls() {
disable_for_parental_controls_ = true;
}
bool parental_controls_checked() { return parental_controls_checked_; }
private:
bool disable_for_managed_ = false;
bool disable_for_parental_controls_ = false;
bool parental_controls_checked_ = false;
};
class StubResolverConfigReaderTest : public testing::Test {
public:
StubResolverConfigReaderTest() {
StubResolverConfigReader::RegisterPrefs(local_state_.registry());
DefaultDnsOverHttpsConfigSource::RegisterPrefs(local_state_.registry());
}
protected:
content::BrowserTaskEnvironment task_environment_{
base::test::TaskEnvironment::TimeSource::MOCK_TIME};
TestingPrefServiceSimple local_state_;
std::unique_ptr<MockedStubResolverConfigReader> config_reader_ =
std::make_unique<MockedStubResolverConfigReader>(&local_state_);
const net::DnsOverHttpsConfig expected_doh_config_ =
*net::DnsOverHttpsConfig::FromString(kDohConfigString);
};
TEST_F(StubResolverConfigReaderTest, GetSecureDnsConfiguration) {
// |force_check_parental_controls_for_automatic_mode = true| is not the main
// default case, but the specific behavior involved is tested separately.
SecureDnsConfig secure_dns_config = config_reader_->GetSecureDnsConfiguration(
true /* force_check_parental_controls_for_automatic_mode */);
EXPECT_FALSE(config_reader_->GetInsecureStubResolverEnabled());
EXPECT_EQ(net::SecureDnsMode::kOff, secure_dns_config.mode());
EXPECT_THAT(secure_dns_config.doh_servers().servers(), testing::IsEmpty());
// Parental controls should not be checked when DoH otherwise disabled.
EXPECT_FALSE(config_reader_->parental_controls_checked());
}
TEST_F(StubResolverConfigReaderTest, DohEnabled) {
local_state_.SetBoolean(prefs::kBuiltInDnsClientEnabled, true);
local_state_.SetString(prefs::kDnsOverHttpsMode,
SecureDnsConfig::kModeAutomatic);
local_state_.SetString(kDnsOverHttpsTemplatesPrefName, kDohConfigString);
// |force_check_parental_controls_for_automatic_mode = true| is not the main
// default case, but the specific behavior involved is tested separately.
SecureDnsConfig secure_dns_config = config_reader_->GetSecureDnsConfiguration(
true /* force_check_parental_controls_for_automatic_mode */);
EXPECT_TRUE(config_reader_->GetInsecureStubResolverEnabled());
EXPECT_EQ(net::SecureDnsMode::kAutomatic, secure_dns_config.mode());
EXPECT_EQ(expected_doh_config_, secure_dns_config.doh_servers());
EXPECT_TRUE(config_reader_->parental_controls_checked());
}
TEST_F(StubResolverConfigReaderTest, DohEnabled_Secure) {
local_state_.SetBoolean(prefs::kBuiltInDnsClientEnabled, true);
local_state_.SetString(prefs::kDnsOverHttpsMode,
SecureDnsConfig::kModeSecure);
local_state_.SetString(kDnsOverHttpsTemplatesPrefName, kDohConfigString);
// |force_check_parental_controls_for_automatic_mode| should have no effect on
// SECURE mode, so set to false to ensure check is not deferred.
SecureDnsConfig secure_dns_config = config_reader_->GetSecureDnsConfiguration(
false /* force_check_parental_controls_for_automatic_mode */);
EXPECT_TRUE(config_reader_->GetInsecureStubResolverEnabled());
EXPECT_EQ(net::SecureDnsMode::kSecure, secure_dns_config.mode());
EXPECT_EQ(expected_doh_config_, secure_dns_config.doh_servers());
EXPECT_TRUE(config_reader_->parental_controls_checked());
}
TEST_F(StubResolverConfigReaderTest, DisabledForManaged) {
config_reader_->set_disable_for_managed();
local_state_.SetBoolean(prefs::kBuiltInDnsClientEnabled, true);
local_state_.SetString(prefs::kDnsOverHttpsMode,
SecureDnsConfig::kModeAutomatic);
local_state_.SetString(kDnsOverHttpsTemplatesPrefName, kDohConfigString);
// |force_check_parental_controls_for_automatic_mode = true| is not the main
// default case, but the specific behavior involved is tested separately.
SecureDnsConfig secure_dns_config = config_reader_->GetSecureDnsConfiguration(
true /* force_check_parental_controls_for_automatic_mode */);
EXPECT_TRUE(config_reader_->GetInsecureStubResolverEnabled());
EXPECT_EQ(net::SecureDnsMode::kOff, secure_dns_config.mode());
EXPECT_THAT(secure_dns_config.doh_servers().servers(), testing::IsEmpty());
// Parental controls should not be checked when DoH otherwise disabled.
EXPECT_FALSE(config_reader_->parental_controls_checked());
}
TEST_F(StubResolverConfigReaderTest, DisabledForManaged_Secure) {
config_reader_->set_disable_for_managed();
local_state_.SetBoolean(prefs::kBuiltInDnsClientEnabled, true);
local_state_.SetString(prefs::kDnsOverHttpsMode,
SecureDnsConfig::kModeSecure);
local_state_.SetString(kDnsOverHttpsTemplatesPrefName, kDohConfigString);
SecureDnsConfig secure_dns_config = config_reader_->GetSecureDnsConfiguration(
false /* force_check_parental_controls_for_automatic_mode */);
EXPECT_TRUE(config_reader_->GetInsecureStubResolverEnabled());
EXPECT_EQ(net::SecureDnsMode::kOff, secure_dns_config.mode());
EXPECT_THAT(secure_dns_config.doh_servers().servers(), testing::IsEmpty());
// Parental controls should not be checked when DoH otherwise disabled.
EXPECT_FALSE(config_reader_->parental_controls_checked());
}
TEST_F(StubResolverConfigReaderTest, DisabledForParentalControls) {
config_reader_->set_disable_for_parental_controls();
local_state_.SetBoolean(prefs::kBuiltInDnsClientEnabled, true);
local_state_.SetString(prefs::kDnsOverHttpsMode,
SecureDnsConfig::kModeAutomatic);
local_state_.SetString(kDnsOverHttpsTemplatesPrefName, kDohConfigString);
// |force_check_parental_controls_for_automatic_mode = true| is not the main
// default case, but the specific behavior involved is tested separately.
SecureDnsConfig secure_dns_config = config_reader_->GetSecureDnsConfiguration(
true /* force_check_parental_controls_for_automatic_mode */);
EXPECT_TRUE(config_reader_->GetInsecureStubResolverEnabled());
EXPECT_EQ(net::SecureDnsMode::kOff, secure_dns_config.mode());
EXPECT_THAT(secure_dns_config.doh_servers().servers(), testing::IsEmpty());
EXPECT_TRUE(config_reader_->parental_controls_checked());
}
TEST_F(StubResolverConfigReaderTest, DisabledForParentalControls_Secure) {
config_reader_->set_disable_for_parental_controls();
local_state_.SetBoolean(prefs::kBuiltInDnsClientEnabled, true);
local_state_.SetString(prefs::kDnsOverHttpsMode,
SecureDnsConfig::kModeSecure);
local_state_.SetString(kDnsOverHttpsTemplatesPrefName, kDohConfigString);
// |force_check_parental_controls_for_automatic_mode| should have no effect on
// SECURE mode, so set to false to ensure check is not deferred.
SecureDnsConfig secure_dns_config = config_reader_->GetSecureDnsConfiguration(
false /* force_check_parental_controls_for_automatic_mode */);
EXPECT_TRUE(config_reader_->GetInsecureStubResolverEnabled());
EXPECT_EQ(net::SecureDnsMode::kOff, secure_dns_config.mode());
EXPECT_THAT(secure_dns_config.doh_servers().servers(), testing::IsEmpty());
EXPECT_TRUE(config_reader_->parental_controls_checked());
}
TEST_F(StubResolverConfigReaderTest, DeferredParentalControlsCheck) {
config_reader_->set_disable_for_parental_controls();
local_state_.SetBoolean(prefs::kBuiltInDnsClientEnabled, true);
local_state_.SetString(prefs::kDnsOverHttpsMode,
SecureDnsConfig::kModeAutomatic);
local_state_.SetString(kDnsOverHttpsTemplatesPrefName, kDohConfigString);
SecureDnsConfig secure_dns_config = config_reader_->GetSecureDnsConfiguration(
false /* force_check_parental_controls_for_automatic_mode */);
// Parental controls check initially skipped.
EXPECT_TRUE(config_reader_->GetInsecureStubResolverEnabled());
EXPECT_EQ(net::SecureDnsMode::kAutomatic, secure_dns_config.mode());
EXPECT_EQ(expected_doh_config_, secure_dns_config.doh_servers());
EXPECT_FALSE(config_reader_->parental_controls_checked());
task_environment_.AdvanceClock(
StubResolverConfigReader::kParentalControlsCheckDelay);
task_environment_.RunUntilIdle();
EXPECT_TRUE(config_reader_->parental_controls_checked());
secure_dns_config = config_reader_->GetSecureDnsConfiguration(
false /* force_check_parental_controls_for_automatic_mode */);
EXPECT_TRUE(config_reader_->GetInsecureStubResolverEnabled());
EXPECT_EQ(net::SecureDnsMode::kOff, secure_dns_config.mode());
EXPECT_THAT(secure_dns_config.doh_servers().servers(), testing::IsEmpty());
}
TEST_F(StubResolverConfigReaderTest, DeferredParentalControlsCheck_Managed) {
config_reader_->set_disable_for_managed();
config_reader_->set_disable_for_parental_controls();
local_state_.SetBoolean(prefs::kBuiltInDnsClientEnabled, true);
local_state_.SetManagedPref(
prefs::kDnsOverHttpsMode,
std::make_unique<base::Value>(SecureDnsConfig::kModeAutomatic));
local_state_.SetManagedPref(prefs::kDnsOverHttpsTemplates,
std::make_unique<base::Value>(kDohConfigString));
SecureDnsConfig secure_dns_config = config_reader_->GetSecureDnsConfiguration(
false /* force_check_parental_controls_for_automatic_mode */);
// Parental controls check initially skipped, and managed prefs take
// precedence over disables.
EXPECT_TRUE(config_reader_->GetInsecureStubResolverEnabled());
EXPECT_EQ(net::SecureDnsMode::kAutomatic, secure_dns_config.mode());
EXPECT_EQ(expected_doh_config_, secure_dns_config.doh_servers());
EXPECT_FALSE(config_reader_->parental_controls_checked());
task_environment_.AdvanceClock(
StubResolverConfigReader::kParentalControlsCheckDelay);
task_environment_.RunUntilIdle();
EXPECT_TRUE(config_reader_->parental_controls_checked());
secure_dns_config = config_reader_->GetSecureDnsConfiguration(
false /* force_check_parental_controls_for_automatic_mode */);
// Expect DoH still enabled after parental controls check because managed
// prefs have precedence.
EXPECT_TRUE(config_reader_->GetInsecureStubResolverEnabled());
EXPECT_EQ(net::SecureDnsMode::kAutomatic, secure_dns_config.mode());
EXPECT_EQ(expected_doh_config_, secure_dns_config.doh_servers());
}
const char kMockDohTemplateForAlternativeSource[] = "https://mock-doh.com";
class MockDnsOverHttpsSource : public DnsOverHttpsConfigSource {
public:
MockDnsOverHttpsSource() : templates_(kMockDohTemplateForAlternativeSource) {}
MockDnsOverHttpsSource(const MockDnsOverHttpsSource&) = delete;
MockDnsOverHttpsSource& operator=(const MockDnsOverHttpsSource&) = delete;
~MockDnsOverHttpsSource() override = default;
std::string GetDnsOverHttpsMode() const override {
return SecureDnsConfig::kModeAutomatic;
}
std::string GetDnsOverHttpsTemplates() const override { return templates_; }
void SetDnsOverHttpsTemplates(const std::string& templates) {
templates_ = templates;
if (on_change_callback_) {
on_change_callback_.Run();
}
}
bool IsConfigManaged() const override { return true; }
void SetDohChangeCallback(base::RepeatingClosure callback) override {
on_change_callback_ = callback;
}
private:
std::string templates_;
base::RepeatingClosure on_change_callback_;
};
TEST_F(StubResolverConfigReaderTest, DohWithOverrideConfigSource) {
local_state_.SetBoolean(prefs::kBuiltInDnsClientEnabled, true);
local_state_.SetString(prefs::kDnsOverHttpsMode,
SecureDnsConfig::kModeSecure);
local_state_.SetString(kDnsOverHttpsTemplatesPrefName, kDohConfigString);
SecureDnsConfig secure_dns_config = config_reader_->GetSecureDnsConfiguration(
/*force_check_parental_controls_for_automatic_mode=*/false);
// Expect that `config_reader_` gets the DoH config from the default DoH
// config source (which monitors local_state prefs).
EXPECT_EQ(net::SecureDnsMode::kSecure, secure_dns_config.mode());
EXPECT_EQ(expected_doh_config_, secure_dns_config.doh_servers());
std::unique_ptr<MockDnsOverHttpsSource> mock_doh_source =
std::make_unique<MockDnsOverHttpsSource>();
MockDnsOverHttpsSource* mock_doh_source_ptr = mock_doh_source.get();
config_reader_->SetOverrideDnsOverHttpsConfigSource(
std::move(mock_doh_source));
secure_dns_config = config_reader_->GetSecureDnsConfiguration(
/*force_check_parental_controls_for_automatic_mode=*/false);
// Expect that `config_reader_` gets the DoH config from the override DoH
// config source.
EXPECT_EQ(net::SecureDnsMode::kAutomatic, secure_dns_config.mode());
EXPECT_EQ(*net::DnsOverHttpsConfig::FromString(
kMockDohTemplateForAlternativeSource),
secure_dns_config.doh_servers());
const char kMockDohTemplate2[] = "https://mock-doh2.com";
mock_doh_source_ptr->SetDnsOverHttpsTemplates(kMockDohTemplate2);
// Expect that `config_reader_` gets updates from the override DoH config
// source.
secure_dns_config = config_reader_->GetSecureDnsConfiguration(
false /* force_check_parental_controls_for_automatic_mode */);
EXPECT_EQ(*net::DnsOverHttpsConfig::FromString(kMockDohTemplate2),
secure_dns_config.doh_servers());
config_reader_->SetOverrideDnsOverHttpsConfigSource(nullptr);
secure_dns_config = config_reader_->GetSecureDnsConfiguration(
false /* force_check_parental_controls_for_automatic_mode */);
// Expect that configuring a null override DoH config source will reset to
// the default behaviour.
EXPECT_EQ(net::SecureDnsMode::kSecure, secure_dns_config.mode());
EXPECT_EQ(expected_doh_config_, secure_dns_config.doh_servers());
}
} // namespace
|
