1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
|
// Copyright 2017 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <map>
#include <string>
#include "base/run_loop.h"
#include "base/strings/utf_string_conversions.h"
#include "build/build_config.h"
#include "chrome/browser/ntp_tiles/chrome_most_visited_sites_factory.h"
#include "chrome/browser/profiles/profile_key.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/common/chrome_features.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/mixin_based_in_process_browser_test.h"
#include "chrome/test/base/ui_test_utils.h"
#include "chrome/test/supervised_user/supervision_mixin.h"
#include "components/history/core/browser/top_sites.h"
#include "components/ntp_tiles/most_visited_sites.h"
#include "components/ntp_tiles/ntp_tile.h"
#include "components/supervised_user/core/browser/supervised_user_utils.h"
#include "components/supervised_user/core/common/supervised_user_constants.h"
#include "content/public/test/browser_test.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "url/gurl.h"
namespace ntp_tiles {
namespace {
using testing::Contains;
using testing::Not;
using testing::UnorderedElementsAre;
const char kWebstoreUrl[] = "https://chrome.google.com/webstore?hl=en";
std::string PrintTile(const std::string& title,
const std::string& url,
TileSource source) {
return std::string("has title \"") + title + std::string("\" and url \"") +
url + std::string("\" and source ") +
testing::PrintToString(static_cast<int>(source));
}
MATCHER_P3(MatchesTile, title, url, source, PrintTile(title, url, source)) {
return arg.title == base::ASCIIToUTF16(title) && arg.url == GURL(url) &&
arg.source == source;
}
// Waits for most visited URLs to be made available.
class MostVisitedSitesWaiter : public MostVisitedSites::Observer {
public:
MostVisitedSitesWaiter() : tiles_(NTPTilesVector()) {}
// Waits until most visited URLs are available, and then returns all the
// tiles.
NTPTilesVector WaitForTiles() {
base::RunLoop run_loop;
quit_closure_ = run_loop.QuitClosure();
run_loop.Run();
return tiles_;
}
void OnURLsAvailable(
bool is_user_triggered,
const std::map<SectionType, NTPTilesVector>& sections) override {
tiles_ = sections.at(SectionType::PERSONALIZED);
if (quit_closure_) {
std::move(quit_closure_).Run();
}
}
void OnIconMadeAvailable(const GURL& site_url) override {}
private:
base::OnceClosure quit_closure_;
NTPTilesVector tiles_;
};
} // namespace
class NTPTilesTest : public InProcessBrowserTest {
public:
NTPTilesTest() = default;
protected:
void SetUpOnMainThread() override {
most_visited_sites_ =
ChromeMostVisitedSitesFactory::NewForProfile(browser()->profile());
}
void TearDownOnMainThread() override {
// Reset most_visited_sites_, otherwise there is a CHECK in callback_list.h
// because callbacks_.size() is not 0.
most_visited_sites_.reset();
}
std::unique_ptr<ntp_tiles::MostVisitedSites> most_visited_sites_;
};
class NTPTilesForSupervisedUsersTest : public MixinBasedInProcessBrowserTest {
protected:
void SetUpOnMainThread() override {
MixinBasedInProcessBrowserTest::SetUpOnMainThread();
ASSERT_TRUE(embedded_test_server()->Started());
most_visited_sites_ =
ChromeMostVisitedSitesFactory::NewForProfile(browser()->profile());
}
void TearDownOnMainThread() override {
// Reset most_visited_sites_, otherwise there is a CHECK in callback_list.h
// because callbacks_.size() is not 0.
most_visited_sites_.reset();
}
supervised_user::KidsManagementApiServerMock& kids_management_api_mock() {
return supervision_mixin_.api_mock_setup_mixin().api_mock();
}
supervised_user::SupervisionMixin supervision_mixin_{
mixin_host_,
this,
embedded_test_server(),
{
.sign_in_mode =
supervised_user::SupervisionMixin::SignInMode::kSupervised,
.embedded_test_server_options = {.resolver_rules_map_host_list =
"*.example.com"},
}};
std::unique_ptr<ntp_tiles::MostVisitedSites> most_visited_sites_;
};
// Tests that after navigating to a URL, ntp tiles will include the URL.
IN_PROC_BROWSER_TEST_F(NTPTilesTest, LoadURL) {
ASSERT_TRUE(embedded_test_server()->Start());
const GURL page_url = embedded_test_server()->GetURL("/simple.html");
ui_test_utils::NavigateToURLWithDisposition(
browser(), page_url, WindowOpenDisposition::CURRENT_TAB,
ui_test_utils::BROWSER_TEST_WAIT_FOR_LOAD_STOP);
MostVisitedSitesWaiter waiter;
// This call will call SyncWithHistory(), which means the new URL will be in
// the next set of tiles that the waiter retrieves.
most_visited_sites_->AddMostVisitedURLsObserver(&waiter, /*max_num_sites=*/8);
NTPTilesVector tiles = waiter.WaitForTiles();
EXPECT_THAT(tiles, Contains(MatchesTile("OK", page_url.spec().c_str(),
TileSource::TOP_SITES)));
}
// Tests that after navigating to a URL with a server redirect, ntp tiles will
// include the correct URL.
IN_PROC_BROWSER_TEST_F(NTPTilesTest, ServerRedirect) {
ASSERT_TRUE(embedded_test_server()->Start());
GURL final_url = embedded_test_server()->GetURL("/defaultresponse");
GURL first_url =
embedded_test_server()->GetURL("/server-redirect?" + final_url.spec());
ui_test_utils::NavigateToURLWithDisposition(
browser(), first_url, WindowOpenDisposition::CURRENT_TAB,
ui_test_utils::BROWSER_TEST_WAIT_FOR_LOAD_STOP);
MostVisitedSitesWaiter waiter;
most_visited_sites_->AddMostVisitedURLsObserver(&waiter, /*max_num_sites=*/8);
NTPTilesVector tiles = waiter.WaitForTiles();
// TopSites uses the start of the redirect chain, so verify the first URL
// is listed, but not the final URL.
EXPECT_THAT(tiles, Contains(MatchesTile("", first_url.spec().c_str(),
TileSource::TOP_SITES)));
EXPECT_THAT(tiles, Not(Contains(MatchesTile("", final_url.spec().c_str(),
TileSource::TOP_SITES))));
}
// Tests usage of MostVisitedSites mimicking Chrome Home, where an observer is
// installed early and once and navigations follow afterwards.
// Flaky on several platforms: https://crbug.com/1487047.
IN_PROC_BROWSER_TEST_F(NTPTilesTest, DISABLED_NavigateAfterSettingObserver) {
ASSERT_TRUE(embedded_test_server()->Start());
const GURL page_url = embedded_test_server()->GetURL("/simple.html");
// Register the observer before doing the navigation.
MostVisitedSitesWaiter waiter;
most_visited_sites_->AddMostVisitedURLsObserver(&waiter, /*max_num_sites=*/8);
ui_test_utils::NavigateToURLWithDisposition(
browser(), page_url, WindowOpenDisposition::CURRENT_TAB,
ui_test_utils::BROWSER_TEST_WAIT_FOR_LOAD_STOP);
most_visited_sites_->Refresh();
NTPTilesVector tiles = waiter.WaitForTiles();
EXPECT_THAT(tiles, Contains(MatchesTile("OK", page_url.spec().c_str(),
TileSource::TOP_SITES)));
}
// Tests that after navigating to a URL that is not blocked for the supervised
// user, ntp tiles will include the URL.
IN_PROC_BROWSER_TEST_F(NTPTilesForSupervisedUsersTest, LoadURL) {
const GURL page_url =
embedded_test_server()->GetURL("www.example.com", "/simple.html");
kids_management_api_mock().AllowSubsequentClassifyUrl();
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), page_url));
MostVisitedSitesWaiter waiter;
// This call will call SyncWithHistory(), which means the new URL will be in
// the next set of tiles that the waiter retrieves.
most_visited_sites_->AddMostVisitedURLsObserver(&waiter, 8);
NTPTilesVector tiles = waiter.WaitForTiles();
EXPECT_THAT(
tiles,
UnorderedElementsAre(
MatchesTile("OK", page_url.spec().c_str(), TileSource::TOP_SITES),
MatchesTile("Web Store", kWebstoreUrl, TileSource::TOP_SITES)));
}
// Tests that after navigating to a URL that is blocked for the supervised user,
// ntp tiles will not include the URL.
IN_PROC_BROWSER_TEST_F(NTPTilesForSupervisedUsersTest, DoNotLoadBlockedURL) {
const GURL page_url = embedded_test_server()->GetURL(
"www.example.com", "/supervised_user/simple.html");
kids_management_api_mock().AllowSubsequentClassifyUrl();
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), page_url));
const GURL blocked_page_url =
embedded_test_server()->GetURL("www.example.com", "/simple.html");
kids_management_api_mock().RestrictSubsequentClassifyUrl();
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), blocked_page_url));
MostVisitedSitesWaiter waiter;
// This call will call SyncWithHistory(), which means the new URL would be in
// the next set of tiles that the waiter retrieves.
most_visited_sites_->AddMostVisitedURLsObserver(&waiter, 8);
NTPTilesVector tiles = waiter.WaitForTiles();
EXPECT_THAT(tiles, UnorderedElementsAre(
MatchesTile("simple page", page_url.spec().c_str(),
TileSource::TOP_SITES),
MatchesTile("Web Store", kWebstoreUrl,
TileSource::TOP_SITES)));
}
} // namespace ntp_tiles
|
