1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
|
// Copyright 2023 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/files/file_util.h"
#include "base/path_service.h"
#include "base/strings/stringprintf.h"
#include "base/test/metrics/histogram_tester.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/ui_test_utils.h"
#include "components/metrics/content/subprocess_metrics_provider.h"
#include "components/page_load_metrics/browser/page_load_metrics_test_waiter.h"
#include "content/public/common/content_paths.h"
#include "content/public/test/browser_test.h"
#include "content/public/test/browser_test_utils.h"
#include "net/test/embedded_test_server/controllable_http_response.h"
#include "net/test/embedded_test_server/embedded_test_server.h"
class ImageLoadingUMATest : public InProcessBrowserTest {
public:
ImageLoadingUMATest() = default;
ImageLoadingUMATest(const ImageLoadingUMATest&) = delete;
ImageLoadingUMATest& operator=(const ImageLoadingUMATest&) = delete;
~ImageLoadingUMATest() override = default;
protected:
void PreRunTestOnMainThread() override {
InProcessBrowserTest::PreRunTestOnMainThread();
histogram_tester_ = std::make_unique<base::HistogramTester>();
}
void run_test(std::string html) {
const char kHtmlHttpResponseHeader[] =
"HTTP/1.1 200 OK\r\n"
"Content-Type: text/html; charset=utf-8\r\n"
"\r\n";
const char kStylesheetHttpResponseHeader[] =
"HTTP/1.1 200 OK\r\n"
"Content-Type: text/css\r\n"
"\r\n";
const char kImgHttpResponseHeader[] =
"HTTP/1.1 200 OK\r\n"
"Content-Type: image/jpg\r\n"
"\r\n";
auto html_response =
std::make_unique<net::test_server::ControllableHttpResponse>(
embedded_test_server(), "/mock_page.html",
true /*relative_url_is_prefix*/);
auto style_response =
std::make_unique<net::test_server::ControllableHttpResponse>(
embedded_test_server(), "/styles/mock.css",
false /*relative_url_is_prefix*/);
auto img_response =
std::make_unique<net::test_server::ControllableHttpResponse>(
embedded_test_server(), "/images/mock.jpg",
false /*relative_url_is_prefix*/);
ASSERT_TRUE(embedded_test_server()->Start());
// File is under content/test/data/
// It is 120x120 pixels
std::string file_contents;
{
base::ScopedAllowBlockingForTesting allow_io;
base::FilePath test_dir;
ASSERT_TRUE(base::PathService::Get(content::DIR_TEST_DATA, &test_dir));
base::FilePath file_name = test_dir.AppendASCII("single_face.jpg");
ASSERT_TRUE(base::ReadFileToString(file_name, &file_contents));
}
content::WebContents* contents = browser()->OpenURL(
content::OpenURLParams(
embedded_test_server()->GetURL("/mock_page.html"),
content::Referrer(), WindowOpenDisposition::CURRENT_TAB,
ui::PAGE_TRANSITION_TYPED, false),
/*navigation_handle_callback=*/{});
auto waiter =
std::make_unique<page_load_metrics::PageLoadMetricsTestWaiter>(
contents, "waiter");
waiter->AddPageExpectation(page_load_metrics::PageLoadMetricsTestWaiter::
TimingField::kLargestContentfulPaint);
html_response->WaitForRequest();
html_response->Send(kHtmlHttpResponseHeader);
html_response->Send(html.c_str());
html_response->Done();
img_response->WaitForRequest();
img_response->Send(kImgHttpResponseHeader);
img_response->Send(file_contents);
img_response->Done();
style_response->WaitForRequest();
// Make sure histograms were not yet reported, because rendering didn't yet
// happen.
auto entries =
histogram_tester_->GetTotalCountsForPrefix("Renderer.Images.");
EXPECT_EQ(entries.size(), 0u);
style_response->Send(kStylesheetHttpResponseHeader);
style_response->Send("");
style_response->Done();
// Wait for LCP on the browser side.
waiter->Wait();
// Navigate away to ensure page load metrics reporting.
ASSERT_TRUE(
ui_test_utils::NavigateToURL(browser(), GURL(url::kAboutBlankURL)));
// Actually fetch histogram data.
content::FetchHistogramsFromChildProcesses();
metrics::SubprocessMetricsProvider::MergeHistogramDeltasForTesting();
// Verify that we got the UMA histograms.
entries = histogram_tester_->GetTotalCountsForPrefix("Renderer.Images.");
EXPECT_NE(entries.size(), 0u);
}
std::unique_ptr<base::HistogramTester> histogram_tester_;
};
IN_PROC_BROWSER_TEST_F(ImageLoadingUMATest, NoAttributeImage) {
run_test(R"HTML(
<!doctype html>
<html>
<link href='/styles/mock.css' rel=stylesheet>
<img src='/images/mock.jpg'>
</html>
)HTML");
histogram_tester_->ExpectTotalCount("Renderer.Images.OverfetchedPixels", 0);
histogram_tester_->ExpectTotalCount("Renderer.Images.OverfetchedCappedPixels",
0);
histogram_tester_->ExpectTotalCount("Renderer.Images.SizesAttributeMiss", 0);
histogram_tester_->ExpectUniqueSample("Renderer.Images.HasOverfetchedPixels",
false, 1);
histogram_tester_->ExpectUniqueSample(
"Renderer.Images.HasOverfetchedCappedPixels", false, 1);
histogram_tester_->ExpectTotalCount("Renderer.Images.HasSizesAttributeMiss",
0);
}
IN_PROC_BROWSER_TEST_F(ImageLoadingUMATest, StyledImage) {
run_test(R"HTML(
<!doctype html>
<html>
<link href='/styles/mock.css' rel=stylesheet>
<style>
img {max-width: 100%;}
.container {width: 50px;}
</style>
<div class=container>
<img src='/images/mock.jpg'>
</div>
</html>
)HTML");
histogram_tester_->ExpectTotalCount("Renderer.Images.OverfetchedPixels", 1);
// 11900 == 120*120 - 50*50
histogram_tester_->ExpectUniqueSample("Renderer.Images.OverfetchedPixels",
11900, 1);
histogram_tester_->ExpectTotalCount("Renderer.Images.OverfetchedCappedPixels",
1);
histogram_tester_->ExpectUniqueSample(
"Renderer.Images.OverfetchedCappedPixels", 11900, 1);
histogram_tester_->ExpectTotalCount("Renderer.Images.SizesAttributeMiss", 0);
histogram_tester_->ExpectUniqueSample("Renderer.Images.HasOverfetchedPixels",
true, 1);
histogram_tester_->ExpectUniqueSample(
"Renderer.Images.HasOverfetchedCappedPixels", true, 1);
histogram_tester_->ExpectTotalCount("Renderer.Images.HasSizesAttributeMiss",
0);
}
IN_PROC_BROWSER_TEST_F(ImageLoadingUMATest, ImageWithWidthAttribute) {
run_test(R"HTML(
<!doctype html>
<html>
<link href='/styles/mock.css' rel=stylesheet>
<img src='/images/mock.jpg' width=50>
</html>
)HTML");
histogram_tester_->ExpectTotalCount("Renderer.Images.OverfetchedPixels", 1);
// 11900 == 120*120 - 50*50
histogram_tester_->ExpectUniqueSample("Renderer.Images.OverfetchedPixels",
11900, 1);
histogram_tester_->ExpectTotalCount("Renderer.Images.OverfetchedCappedPixels",
1);
histogram_tester_->ExpectUniqueSample(
"Renderer.Images.OverfetchedCappedPixels", 11900, 1);
histogram_tester_->ExpectTotalCount("Renderer.Images.SizesAttributeMiss", 0);
histogram_tester_->ExpectUniqueSample("Renderer.Images.HasOverfetchedPixels",
true, 1);
histogram_tester_->ExpectUniqueSample(
"Renderer.Images.HasOverfetchedCappedPixels", true, 1);
histogram_tester_->ExpectTotalCount("Renderer.Images.HasSizesAttributeMiss",
0);
}
// TODO(crbug.com/40916617): Flaky on linux-win-cross-rel.
#if BUILDFLAG(IS_WIN)
#define MAYBE_ImageWithCorrectSizesAttribute \
DISABLED_ImageWithCorrectSizesAttribute
#else
#define MAYBE_ImageWithCorrectSizesAttribute ImageWithCorrectSizesAttribute
#endif
IN_PROC_BROWSER_TEST_F(ImageLoadingUMATest,
MAYBE_ImageWithCorrectSizesAttribute) {
run_test(R"HTML(
<!doctype html>
<html>
<link href='/styles/mock.css' rel=stylesheet>
<img srcset='/images/mock.jpg 120w' sizes=50px>
</html>
)HTML");
histogram_tester_->ExpectTotalCount("Renderer.Images.OverfetchedPixels", 1);
// 11900 == 120*120 - 50*50
histogram_tester_->ExpectUniqueSample("Renderer.Images.OverfetchedPixels",
11900, 1);
histogram_tester_->ExpectTotalCount("Renderer.Images.OverfetchedCappedPixels",
1);
histogram_tester_->ExpectUniqueSample(
"Renderer.Images.OverfetchedCappedPixels", 11900, 1);
histogram_tester_->ExpectTotalCount("Renderer.Images.SizesAttributeMiss", 0);
histogram_tester_->ExpectUniqueSample("Renderer.Images.HasOverfetchedPixels",
true, 1);
histogram_tester_->ExpectUniqueSample(
"Renderer.Images.HasOverfetchedCappedPixels", true, 1);
histogram_tester_->ExpectTotalCount("Renderer.Images.HasSizesAttributeMiss",
1);
histogram_tester_->ExpectUniqueSample("Renderer.Images.HasSizesAttributeMiss",
false, 1);
}
IN_PROC_BROWSER_TEST_F(ImageLoadingUMATest, ImageWithIncorrectSizesAttribute) {
run_test(R"HTML(
<!doctype html>
<html>
<link href='/styles/mock.css' rel=stylesheet>
<style>
img {max-width: 100%;}
.container {width: 50px;}
</style>
<div class=container>
<img srcset='/images/mock.jpg 120w' sizes=120px>
</div>
</html>
)HTML");
histogram_tester_->ExpectTotalCount("Renderer.Images.OverfetchedPixels", 1);
// 11900 == 120*120 - 50*50
histogram_tester_->ExpectUniqueSample("Renderer.Images.OverfetchedPixels",
11900, 1);
histogram_tester_->ExpectTotalCount("Renderer.Images.OverfetchedCappedPixels",
1);
histogram_tester_->ExpectUniqueSample(
"Renderer.Images.OverfetchedCappedPixels", 11900, 1);
histogram_tester_->ExpectTotalCount("Renderer.Images.SizesAttributeMiss", 1);
// 70 = 120 - 50
histogram_tester_->ExpectUniqueSample("Renderer.Images.SizesAttributeMiss",
70, 1);
histogram_tester_->ExpectUniqueSample("Renderer.Images.HasOverfetchedPixels",
true, 1);
histogram_tester_->ExpectUniqueSample(
"Renderer.Images.HasOverfetchedCappedPixels", true, 1);
histogram_tester_->ExpectTotalCount("Renderer.Images.HasSizesAttributeMiss",
1);
histogram_tester_->ExpectUniqueSample("Renderer.Images.HasSizesAttributeMiss",
true, 1);
}
// TODO(crbug.com/40916617): Fix this test on Mac.
#if BUILDFLAG(IS_MAC)
#define MAYBE_PictureWithIncorrectSizesAttribute \
DISABLED_PictureWithIncorrectSizesAttribute
#else
#define MAYBE_PictureWithIncorrectSizesAttribute \
PictureWithIncorrectSizesAttribute
#endif
IN_PROC_BROWSER_TEST_F(ImageLoadingUMATest,
MAYBE_PictureWithIncorrectSizesAttribute) {
run_test(R"HTML(
<!doctype html>
<html>
<link href='/styles/mock.css' rel=stylesheet>
<style>
img {max-width: 100%;}
.container {width: 50px;}
</style>
<div class=container>
<picture>
<source srcset='/images/mock.jpg 120w' sizes=120px>
<img>
</picture>
</div>
</html>
)HTML");
histogram_tester_->ExpectTotalCount("Renderer.Images.OverfetchedPixels", 1);
// 11900 == 120*120 - 50*50
histogram_tester_->ExpectUniqueSample("Renderer.Images.OverfetchedPixels",
11900, 1);
histogram_tester_->ExpectTotalCount("Renderer.Images.OverfetchedCappedPixels",
1);
histogram_tester_->ExpectUniqueSample(
"Renderer.Images.OverfetchedCappedPixels", 11900, 1);
histogram_tester_->ExpectTotalCount("Renderer.Images.SizesAttributeMiss", 1);
// 70 = 120 - 50
histogram_tester_->ExpectUniqueSample("Renderer.Images.SizesAttributeMiss",
70, 1);
histogram_tester_->ExpectUniqueSample("Renderer.Images.HasOverfetchedPixels",
true, 1);
histogram_tester_->ExpectUniqueSample(
"Renderer.Images.HasOverfetchedCappedPixels", true, 1);
histogram_tester_->ExpectTotalCount("Renderer.Images.HasSizesAttributeMiss",
1);
histogram_tester_->ExpectUniqueSample("Renderer.Images.HasSizesAttributeMiss",
true, 1);
}
class ImageLoadingUMAHighDPITest : public ImageLoadingUMATest {
public:
const double kDeviceScaleFactor = 2.1;
ImageLoadingUMAHighDPITest() = default;
protected:
void SetUpCommandLine(base::CommandLine* command_line) override {
ImageLoadingUMATest::SetUpCommandLine(command_line);
command_line->AppendSwitchASCII(
switches::kForceDeviceScaleFactor,
base::StringPrintf("%f", kDeviceScaleFactor));
}
};
IN_PROC_BROWSER_TEST_F(ImageLoadingUMAHighDPITest,
PictureWithIncorrectSizesAttribute) {
run_test(R"HTML(
<!doctype html>
<html>
<link href='/styles/mock.css' rel=stylesheet>
<style>
img {max-width: 100%;}
.container {width: 50px;}
</style>
<div class=container>
<picture>
<source srcset='/images/mock.jpg 120w' sizes=120px>
<img>
</picture>
</div>
</html>
)HTML");
histogram_tester_->ExpectTotalCount("Renderer.Images.OverfetchedPixels", 1);
// 3375 == 120*120 - 50*2.1*50*2.1
histogram_tester_->ExpectUniqueSample("Renderer.Images.OverfetchedPixels",
3375, 1);
histogram_tester_->ExpectTotalCount("Renderer.Images.OverfetchedCappedPixels",
1);
// 4400 == 120*120 - 50*2*50*2
histogram_tester_->ExpectUniqueSample(
"Renderer.Images.OverfetchedCappedPixels", 4400, 1);
histogram_tester_->ExpectTotalCount("Renderer.Images.SizesAttributeMiss", 1);
// 70 = 120 - 50
histogram_tester_->ExpectUniqueSample("Renderer.Images.SizesAttributeMiss",
70, 1);
histogram_tester_->ExpectUniqueSample("Renderer.Images.HasOverfetchedPixels",
true, 1);
histogram_tester_->ExpectUniqueSample(
"Renderer.Images.HasOverfetchedCappedPixels", true, 1);
histogram_tester_->ExpectTotalCount("Renderer.Images.HasSizesAttributeMiss",
1);
histogram_tester_->ExpectUniqueSample("Renderer.Images.HasSizesAttributeMiss",
true, 1);
}
|
