1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
|
// Copyright 2017 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/permissions/crowd_deny_safe_browsing_request.h"
#include "base/memory/scoped_refptr.h"
#include "base/test/metrics/histogram_tester.h"
#include "base/test/mock_callback.h"
#include "chrome/browser/permissions/crowd_deny_fake_safe_browsing_database_manager.h"
#include "content/public/test/browser_task_environment.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "url/gurl.h"
#include "url/origin.h"
namespace {
constexpr char kTestOriginFoo[] = "https://foo.com";
constexpr char kTestOriginBar[] = "https://bar.com";
} // namespace
class CrowdDenySafeBrowsingRequestTest : public testing::Test {
public:
using Verdict = CrowdDenySafeBrowsingRequest::Verdict;
CrowdDenySafeBrowsingRequestTest()
: fake_database_manager_(
base::MakeRefCounted<CrowdDenyFakeSafeBrowsingDatabaseManager>()) {}
CrowdDenySafeBrowsingRequestTest(const CrowdDenySafeBrowsingRequestTest&) =
delete;
CrowdDenySafeBrowsingRequestTest& operator=(
const CrowdDenySafeBrowsingRequestTest&) = delete;
~CrowdDenySafeBrowsingRequestTest() override = default;
protected:
content::BrowserTaskEnvironment* task_environment() {
return &task_environment_;
}
CrowdDenyFakeSafeBrowsingDatabaseManager* fake_database_manager() {
return fake_database_manager_.get();
}
const base::Clock* test_clock() { return task_environment_.GetMockClock(); }
void StartRequestForOriginAndExpectVerdict(const url::Origin& origin,
Verdict expected_verdict) {
base::HistogramTester histogram_tester;
base::MockOnceCallback<void(Verdict)> mock_callback_receiver;
CrowdDenySafeBrowsingRequest request(fake_database_manager(), test_clock(),
origin, mock_callback_receiver.Get());
EXPECT_CALL(mock_callback_receiver, Run(expected_verdict));
task_environment()->RunUntilIdle();
histogram_tester.ExpectTotalCount(
"Permissions.CrowdDeny.SafeBrowsing.RequestDuration", 1);
histogram_tester.ExpectUniqueSample(
"Permissions.CrowdDeny.SafeBrowsing.Verdict",
static_cast<int>(expected_verdict), 1);
}
private:
content::BrowserTaskEnvironment task_environment_{
base::test::TaskEnvironment::TimeSource::MOCK_TIME};
scoped_refptr<CrowdDenyFakeSafeBrowsingDatabaseManager>
fake_database_manager_;
};
TEST_F(CrowdDenySafeBrowsingRequestTest, Acceptable_SynchronousCompletion) {
fake_database_manager()->set_simulate_synchronous_result(true);
StartRequestForOriginAndExpectVerdict(
url::Origin::Create(GURL(kTestOriginFoo)), Verdict::kAcceptable);
}
TEST_F(CrowdDenySafeBrowsingRequestTest, Acceptable_UnavailableMetaData) {
StartRequestForOriginAndExpectVerdict(
url::Origin::Create(GURL(kTestOriginFoo)), Verdict::kAcceptable);
}
TEST_F(CrowdDenySafeBrowsingRequestTest, Acceptable_UnknownAPIName) {
const GURL kTestURL(kTestOriginFoo);
safe_browsing::ThreatMetadata test_metadata;
test_metadata.api_permissions.emplace("");
test_metadata.api_permissions.emplace("Stuff");
test_metadata.api_permissions.emplace("NOTIFICATION"); // Singular.
test_metadata.api_permissions.emplace("notifications"); // Lowercase.
fake_database_manager()->SetSimulatedMetadataForUrl(kTestURL, test_metadata);
StartRequestForOriginAndExpectVerdict(url::Origin::Create(kTestURL),
Verdict::kAcceptable);
}
TEST_F(CrowdDenySafeBrowsingRequestTest, Spammy) {
const GURL kTestURL(kTestOriginFoo);
safe_browsing::ThreatMetadata test_metadata;
test_metadata.api_permissions.emplace("BANANAS");
test_metadata.api_permissions.emplace("NOTIFICATIONS");
test_metadata.api_permissions.emplace("ORANGES");
fake_database_manager()->SetSimulatedMetadataForUrl(kTestURL, test_metadata);
StartRequestForOriginAndExpectVerdict(url::Origin::Create(kTestURL),
Verdict::kUnacceptable);
StartRequestForOriginAndExpectVerdict(
url::Origin::Create(GURL(kTestOriginBar)), Verdict::kAcceptable);
}
TEST_F(CrowdDenySafeBrowsingRequestTest, Timeout) {
fake_database_manager()->set_simulate_timeout(true);
base::HistogramTester histogram_tester;
base::MockOnceCallback<void(Verdict)> mock_callback_receiver;
CrowdDenySafeBrowsingRequest request(
fake_database_manager(), test_clock(),
url::Origin::Create(GURL(kTestOriginFoo)), mock_callback_receiver.Get());
// Verify the request doesn't time out unreasonably fast.
EXPECT_CALL(mock_callback_receiver, Run(testing::_)).Times(0);
task_environment()->FastForwardBy(base::Milliseconds(100));
testing::Mock::VerifyAndClearExpectations(&mock_callback_receiver);
// But that it eventually does.
EXPECT_CALL(mock_callback_receiver, Run(Verdict::kAcceptable));
task_environment()->FastForwardUntilNoTasksRemain();
histogram_tester.ExpectUniqueSample(
"Permissions.CrowdDeny.SafeBrowsing.RequestDuration", 2000, 1);
histogram_tester.ExpectUniqueSample(
"Permissions.CrowdDeny.SafeBrowsing.Verdict",
static_cast<int>(Verdict::kAcceptable), 1);
}
TEST_F(CrowdDenySafeBrowsingRequestTest, AbandonedImmediately) {
fake_database_manager()->set_simulate_synchronous_result(true);
base::HistogramTester histogram_tester;
base::MockOnceCallback<void(Verdict)> mock_callback_receiver;
EXPECT_CALL(mock_callback_receiver, Run(testing::_)).Times(0);
{
CrowdDenySafeBrowsingRequest request(
fake_database_manager(), test_clock(),
url::Origin::Create(GURL(kTestOriginFoo)),
mock_callback_receiver.Get());
}
task_environment()->RunUntilIdle();
EXPECT_THAT(histogram_tester.GetTotalCountsForPrefix("Permissions."),
testing::IsEmpty());
}
TEST_F(CrowdDenySafeBrowsingRequestTest, AbandonedWhileCheckPending) {
fake_database_manager()->set_simulate_timeout(true);
base::HistogramTester histogram_tester;
base::MockOnceCallback<void(Verdict)> mock_callback_receiver;
EXPECT_CALL(mock_callback_receiver, Run(testing::_)).Times(0);
CrowdDenySafeBrowsingRequest request(
fake_database_manager(), test_clock(),
url::Origin::Create(GURL(kTestOriginFoo)), mock_callback_receiver.Get());
task_environment()->FastForwardBy(base::Milliseconds(100));
EXPECT_THAT(histogram_tester.GetTotalCountsForPrefix("Permissions."),
testing::IsEmpty());
}
|
