1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675
|
// Copyright 2023 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/picture_in_picture/picture_in_picture_window_manager.h"
#include <memory>
#include "base/scoped_observation.h"
#include "chrome/test/base/chrome_render_view_host_test_harness.h"
#include "content/public/browser/picture_in_picture_window_controller.h"
#include "content/public/browser/web_contents.h"
#include "content/public/test/mock_video_picture_in_picture_window_controller_impl.h"
#include "extensions/buildflags/buildflags.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/display/display.h"
#if !BUILDFLAG(IS_ANDROID)
#include "base/test/metrics/histogram_tester.h"
#include "base/test/simple_test_tick_clock.h"
#include "chrome/browser/picture_in_picture/auto_picture_in_picture_tab_helper.h"
#include "chrome/browser/picture_in_picture/picture_in_picture_window.h"
#include "chrome/browser/picture_in_picture/picture_in_picture_window_manager_uma_helper.h"
#include "chrome/browser/picture_in_picture/scoped_disallow_picture_in_picture.h"
#include "chrome/browser/picture_in_picture/scoped_tuck_picture_in_picture.h"
#include "media/base/media_switches.h"
#include "ui/views/bubble/bubble_dialog_delegate_view.h"
#include "ui/views/view.h"
#endif // !BUILDFLAG(IS_ANDROID)
namespace {
#if !BUILDFLAG(IS_ANDROID)
const char kPictureInPictureTotalTimeHistogram[] =
"Media.PictureInPicture.Window.TotalTime";
#endif // !BUILDFLAG(IS_ANDROID)
typedef base::ScopedObservation<PictureInPictureWindowManager,
PictureInPictureWindowManager::Observer>
PictureInPictureWindowManagerdObservation;
class MockPictureInPictureWindowManagerObserver
: public PictureInPictureWindowManager::Observer {
public:
MOCK_METHOD(void, OnEnterPictureInPicture, (), (override));
};
class MockPictureInPictureWindowController
: public content::PictureInPictureWindowController {
public:
MockPictureInPictureWindowController() = default;
MockPictureInPictureWindowController(
const MockPictureInPictureWindowController&) = delete;
MockPictureInPictureWindowController& operator=(
const MockPictureInPictureWindowController&) = delete;
~MockPictureInPictureWindowController() override = default;
MOCK_METHOD(void, Show, (), (override));
MOCK_METHOD(void, FocusInitiator, (), (override));
MOCK_METHOD(void, Close, (bool), (override));
MOCK_METHOD(void, CloseAndFocusInitiator, (), (override));
MOCK_METHOD(void, OnWindowDestroyed, (bool), (override));
MOCK_METHOD(content::WebContents*, GetWebContents, (), (override));
MOCK_METHOD(std::optional<gfx::Rect>, GetWindowBounds, (), (override));
MOCK_METHOD(content::WebContents*, GetChildWebContents, (), (override));
MOCK_METHOD(std::optional<url::Origin>, GetOrigin, (), (override));
};
#if !BUILDFLAG(IS_ANDROID)
class MockPictureInPictureWindow : public PictureInPictureWindow {
public:
MockPictureInPictureWindow() = default;
MockPictureInPictureWindow(const MockPictureInPictureWindow&) = delete;
MockPictureInPictureWindow& operator=(const MockPictureInPictureWindow&) =
delete;
~MockPictureInPictureWindow() override = default;
bool is_tucking() const { return is_tucking_; }
// PictureInPictureWindow:
void SetForcedTucking(bool tuck) override { is_tucking_ = tuck; }
private:
bool is_tucking_ = false;
};
#endif // !BUILDFLAG(IS_ANDROID)
class PictureInPictureWindowManagerTest
: public ChromeRenderViewHostTestHarness {
public:
void SetUp() override {
ChromeRenderViewHostTestHarness::SetUp();
SetContents(CreateTestWebContents());
child_web_contents_ = CreateTestWebContents();
auto mock_video_picture_in_picture_controller = std::make_unique<
content::MockVideoPictureInPictureWindowControllerImpl>(web_contents());
mock_video_picture_in_picture_controller_ =
mock_video_picture_in_picture_controller.get();
web_contents()->SetUserData(
mock_video_picture_in_picture_controller->UserDataKey(),
std::move(mock_video_picture_in_picture_controller));
}
void TearDown() override {
mock_video_picture_in_picture_controller_ = nullptr;
DeleteContents();
child_web_contents_.reset();
ChromeRenderViewHostTestHarness::TearDown();
}
content::WebContents* child_web_contents() const {
return child_web_contents_.get();
}
content::MockVideoPictureInPictureWindowControllerImpl*
mock_video_picture_in_picture_controller() const {
return mock_video_picture_in_picture_controller_.get();
}
#if !BUILDFLAG(IS_ANDROID)
void SetupPiPWindowManagerWithUmaHelper(
base::SimpleTestTickClock* test_clock) {
test_clock->SetNowTicks(base::TimeTicks::Now());
std::unique_ptr<PictureInPictureWindowManagerUmaHelper> test_uma_helper =
std::make_unique<PictureInPictureWindowManagerUmaHelper>();
test_uma_helper->SetClockForTest(test_clock);
PictureInPictureWindowManager* picture_in_picture_window_manager =
PictureInPictureWindowManager::GetInstance();
picture_in_picture_window_manager->set_uma_helper_for_testing(
std::move(test_uma_helper));
}
std::unique_ptr<base::HistogramSamples> GetHistogramSamplesSinceTestStart(
const std::string& name) {
return histogram_tester_.GetHistogramSamplesSinceCreation(name);
}
#endif // !BUILDFLAG(IS_ANDROID)
private:
std::unique_ptr<content::WebContents> child_web_contents_;
raw_ptr<content::MockVideoPictureInPictureWindowControllerImpl>
mock_video_picture_in_picture_controller_;
#if !BUILDFLAG(IS_ANDROID)
base::HistogramTester histogram_tester_;
#endif // !BUILDFLAG(IS_ANDROID)
};
} // namespace
TEST_F(PictureInPictureWindowManagerTest,
ExitPictureInPictureReturnsFalseWhenThereIsNoWindow) {
EXPECT_FALSE(
PictureInPictureWindowManager::GetInstance()->ExitPictureInPicture());
}
TEST_F(PictureInPictureWindowManagerTest,
ExitPictureInPictureReturnsTrueAndClosesWindow) {
MockPictureInPictureWindowController controller;
PictureInPictureWindowManager::GetInstance()
->EnterPictureInPictureWithController(&controller);
EXPECT_CALL(controller, Close(/*should_pause_video=*/false));
EXPECT_TRUE(
PictureInPictureWindowManager::GetInstance()->ExitPictureInPicture());
}
TEST_F(PictureInPictureWindowManagerTest, OnEnterVideoPictureInPicture) {
PictureInPictureWindowManager* picture_in_picture_window_manager =
PictureInPictureWindowManager::GetInstance();
EXPECT_CALL(*mock_video_picture_in_picture_controller(),
SetOnWindowCreatedNotifyObserversCallback);
picture_in_picture_window_manager->EnterVideoPictureInPicture(web_contents());
}
#if !BUILDFLAG(IS_ANDROID)
TEST_F(PictureInPictureWindowManagerTest, RespectsMinAndMaxSize) {
// The max window size should be 80% of the screen.
display::Display display(/*id=*/1, gfx::Rect(0, 0, 1000, 1000));
EXPECT_EQ(gfx::Size(800, 800),
PictureInPictureWindowManager::GetMaximumWindowSize(display));
// The initial bounds of the PiP window should respect that.
blink::mojom::PictureInPictureWindowOptions pip_options;
pip_options.width = 900;
pip_options.height = 100;
EXPECT_EQ(
gfx::Size(800, 100),
PictureInPictureWindowManager::GetInstance()
->CalculateInitialPictureInPictureWindowBounds(pip_options, display)
.size());
// Additionally, even if the given size is less than the absolute max, it
// should be forced to respect the maximum allowed area.
pip_options.width = 800;
pip_options.height = 800;
EXPECT_EQ(
gfx::Size(500, 500),
PictureInPictureWindowManager::GetInstance()
->CalculateInitialPictureInPictureWindowBounds(pip_options, display)
.size());
// Additionally, even if the given size is less than the absolute max, it
// should be forced to respect the maximum allowed area.
pip_options.width = 800;
pip_options.height = 400;
EXPECT_EQ(
gfx::Size(707, 353),
PictureInPictureWindowManager::GetInstance()
->CalculateInitialPictureInPictureWindowBounds(pip_options, display)
.size());
// If the requested width is so much larger than the height that maintaining
// the aspect ratio isn't possible within the min/max bounds, then it should
// keep the minimum height and expand the width to the maximum size.
pip_options.width = 10000;
pip_options.height = 400;
EXPECT_EQ(
gfx::Size(800, 52),
PictureInPictureWindowManager::GetInstance()
->CalculateInitialPictureInPictureWindowBounds(pip_options, display)
.size());
// If the requested height is so much larger than the width that maintaining
// the aspect ratio isn't possible within the min/max bounds, then it should
// keep the minimum width and expand the height to the maximum size.
pip_options.width = 400;
pip_options.height = 10000;
EXPECT_EQ(
gfx::Size(240, 800),
PictureInPictureWindowManager::GetInstance()
->CalculateInitialPictureInPictureWindowBounds(pip_options, display)
.size());
// The minimum size should also be respected.
pip_options.width = 100;
pip_options.height = 500;
EXPECT_EQ(
gfx::Size(240, 500),
PictureInPictureWindowManager::GetInstance()
->CalculateInitialPictureInPictureWindowBounds(pip_options, display)
.size());
}
TEST_F(PictureInPictureWindowManagerTest, OnEnterDocumentPictureInPicture) {
PictureInPictureWindowManager* picture_in_picture_window_manager =
PictureInPictureWindowManager::GetInstance();
MockPictureInPictureWindowManagerObserver observer;
PictureInPictureWindowManagerdObservation observation{&observer};
observation.Observe(picture_in_picture_window_manager);
EXPECT_CALL(observer, OnEnterPictureInPicture).Times(1);
picture_in_picture_window_manager->EnterDocumentPictureInPicture(
web_contents(), child_web_contents());
}
TEST_F(PictureInPictureWindowManagerTest, DontShowAutoPipSettingUiWithoutPip) {
PictureInPictureWindowManager* picture_in_picture_window_manager =
PictureInPictureWindowManager::GetInstance();
// There's no pip open, so expect no setting UI.
EXPECT_FALSE(picture_in_picture_window_manager->GetOverlayView(
/* anchor_view = */ nullptr, views::BubbleBorder::TOP_CENTER));
}
TEST_F(PictureInPictureWindowManagerTest,
DontShowAutoPipSettingUiForNonAutoPip) {
PictureInPictureWindowManager* picture_in_picture_window_manager =
PictureInPictureWindowManager::GetInstance();
picture_in_picture_window_manager->EnterDocumentPictureInPicture(
web_contents(), child_web_contents());
// This isn't auto-pip, so expect no overlay view.
EXPECT_FALSE(picture_in_picture_window_manager->GetOverlayView(
/* anchor_view = */ nullptr, views::BubbleBorder::TOP_CENTER));
}
TEST_F(PictureInPictureWindowManagerTest, CorrectTypesAreSupported) {
EXPECT_TRUE(
PictureInPictureWindowManager::IsSupportedForDocumentPictureInPicture(
GURL("https://foo.com")));
EXPECT_FALSE(
PictureInPictureWindowManager::IsSupportedForDocumentPictureInPicture(
GURL("http://foo.com")));
EXPECT_TRUE(
PictureInPictureWindowManager::IsSupportedForDocumentPictureInPicture(
GURL("http://localhost")));
EXPECT_TRUE(
PictureInPictureWindowManager::IsSupportedForDocumentPictureInPicture(
GURL("https://localhost")));
EXPECT_TRUE(
PictureInPictureWindowManager::IsSupportedForDocumentPictureInPicture(
GURL("file://foo/com")));
EXPECT_FALSE(
PictureInPictureWindowManager::IsSupportedForDocumentPictureInPicture(
GURL("blob://foo.com")));
EXPECT_FALSE(
PictureInPictureWindowManager::IsSupportedForDocumentPictureInPicture(
GURL("")));
EXPECT_FALSE(
PictureInPictureWindowManager::IsSupportedForDocumentPictureInPicture(
GURL("about:blank")));
#if BUILDFLAG(ENABLE_EXTENSIONS)
EXPECT_TRUE(
PictureInPictureWindowManager::IsSupportedForDocumentPictureInPicture(
GURL("chrome-extension://foocom")));
#endif // BUILDFLAG(ENABLE_EXTENSIONS)
EXPECT_TRUE(
PictureInPictureWindowManager::IsSupportedForDocumentPictureInPicture(
GURL("chrome://newtab")));
EXPECT_TRUE(
PictureInPictureWindowManager::IsSupportedForDocumentPictureInPicture(
GURL("isolated-app://asdf")));
}
TEST_F(PictureInPictureWindowManagerTest, RecordsInitialSizeHistograms) {
display::Display display(/*id=*/1, gfx::Rect(0, 0, 1000, 1000));
{
base::HistogramTester histogram_tester;
// Simulate requesting a window that is 400x500px and takes up 20% of the
// total screen area.
blink::mojom::PictureInPictureWindowOptions pip_options;
pip_options.width = 400;
pip_options.height = 500;
PictureInPictureWindowManager::GetInstance()
->CalculateInitialPictureInPictureWindowBounds(pip_options, display);
// Requested size histograms should be properly recorded.
histogram_tester.ExpectUniqueSample(
"Media.DocumentPictureInPicture.RequestedInitialWidth", 400, 1);
histogram_tester.ExpectUniqueSample(
"Media.DocumentPictureInPicture.RequestedInitialHeight", 500, 1);
histogram_tester.ExpectUniqueSample(
"Media.DocumentPictureInPicture.RequestedSizeToScreenRatio", 20, 1);
}
{
base::HistogramTester histogram_tester;
// Simulate requesting a window with zero size.
blink::mojom::PictureInPictureWindowOptions pip_options;
pip_options.width = 0;
pip_options.height = 0;
PictureInPictureWindowManager::GetInstance()
->CalculateInitialPictureInPictureWindowBounds(pip_options, display);
// Requested size histograms should be properly recorded. A size of zero
// should be recorded as 1 percent.
histogram_tester.ExpectUniqueSample(
"Media.DocumentPictureInPicture.RequestedInitialWidth", 0, 1);
histogram_tester.ExpectUniqueSample(
"Media.DocumentPictureInPicture.RequestedInitialHeight", 0, 1);
histogram_tester.ExpectUniqueSample(
"Media.DocumentPictureInPicture.RequestedSizeToScreenRatio", 1, 1);
}
{
base::HistogramTester histogram_tester;
// Simulate requesting a window with an area larger than the whole screen.
blink::mojom::PictureInPictureWindowOptions pip_options;
pip_options.width = 2000;
pip_options.height = 2000;
PictureInPictureWindowManager::GetInstance()
->CalculateInitialPictureInPictureWindowBounds(pip_options, display);
// Requested size histograms should be properly recorded. A size larger than
// the whole screen should be recorded as 100 percent.
histogram_tester.ExpectUniqueSample(
"Media.DocumentPictureInPicture.RequestedInitialWidth", 2000, 1);
histogram_tester.ExpectUniqueSample(
"Media.DocumentPictureInPicture.RequestedInitialHeight", 2000, 1);
histogram_tester.ExpectUniqueSample(
"Media.DocumentPictureInPicture.RequestedSizeToScreenRatio", 100, 1);
}
{
base::HistogramTester histogram_tester;
display::Display empty_display(/*id=*/2, gfx::Rect(0, 0, 0, 0));
// Simulate requesting a window inside an empty display.
blink::mojom::PictureInPictureWindowOptions pip_options;
pip_options.width = 1000;
pip_options.height = 1000;
PictureInPictureWindowManager::GetInstance()
->CalculateInitialPictureInPictureWindowBounds(pip_options,
empty_display);
// Requested size histograms should be properly recorded. If the display
// size is empty, then we should get a ratio of 100 percent.
histogram_tester.ExpectUniqueSample(
"Media.DocumentPictureInPicture.RequestedInitialWidth", 1000, 1);
histogram_tester.ExpectUniqueSample(
"Media.DocumentPictureInPicture.RequestedInitialHeight", 1000, 1);
histogram_tester.ExpectUniqueSample(
"Media.DocumentPictureInPicture.RequestedSizeToScreenRatio", 100, 1);
}
}
TEST_F(PictureInPictureWindowManagerTest, CanDisallowPictureInPicture) {
{
// Disallowing before opening a picture-in-picture window should close it.
ScopedDisallowPictureInPicture disallow;
PictureInPictureWindowManager::GetInstance()->EnterDocumentPictureInPicture(
web_contents(), child_web_contents());
// The close does not happen synchronously, so we run posted tasks.
EXPECT_TRUE(web_contents()->HasPictureInPictureDocument());
task_environment()->RunUntilIdle();
EXPECT_FALSE(web_contents()->HasPictureInPictureDocument());
}
{
// Disallowing after opening a picture-in-picture window should close it.
PictureInPictureWindowManager::GetInstance()->EnterDocumentPictureInPicture(
web_contents(), child_web_contents());
EXPECT_TRUE(web_contents()->HasPictureInPictureDocument());
ScopedDisallowPictureInPicture disallow;
EXPECT_FALSE(web_contents()->HasPictureInPictureDocument());
}
{
{
ScopedDisallowPictureInPicture disallow1;
{
// Multiple ScopedDisallowPictureInPicture should still block
// picture-in-picture windows.
ScopedDisallowPictureInPicture disallow2;
PictureInPictureWindowManager::GetInstance()
->EnterDocumentPictureInPicture(web_contents(),
child_web_contents());
EXPECT_TRUE(web_contents()->HasPictureInPictureDocument());
task_environment()->RunUntilIdle();
EXPECT_FALSE(web_contents()->HasPictureInPictureDocument());
}
// When one of them is destroyed but the other remains, it should still
// block picture-in-picture windows.
PictureInPictureWindowManager::GetInstance()
->EnterDocumentPictureInPicture(web_contents(), child_web_contents());
EXPECT_TRUE(web_contents()->HasPictureInPictureDocument());
task_environment()->RunUntilIdle();
EXPECT_FALSE(web_contents()->HasPictureInPictureDocument());
}
// Once both have been destroyed, picture-in-picture windows should be
// unblocked.
PictureInPictureWindowManager::GetInstance()->EnterDocumentPictureInPicture(
web_contents(), child_web_contents());
EXPECT_TRUE(web_contents()->HasPictureInPictureDocument());
task_environment()->RunUntilIdle();
EXPECT_TRUE(web_contents()->HasPictureInPictureDocument());
}
}
TEST_F(PictureInPictureWindowManagerTest,
ShouldFileDialogBlockPictureInPicture) {
PictureInPictureWindowManager::GetInstance()->EnterDocumentPictureInPicture(
web_contents(), child_web_contents());
{
base::test::ScopedFeatureList feature_list;
feature_list.InitAndEnableFeature(media::kFileDialogsBlockPictureInPicture);
// With the feature enabled, file dialogs that aren't on a document
// picture-in-picture window should block picture-in-picture windows.
EXPECT_TRUE(PictureInPictureWindowManager::GetInstance()
->ShouldFileDialogBlockPictureInPicture(web_contents()));
EXPECT_FALSE(
PictureInPictureWindowManager::GetInstance()
->ShouldFileDialogBlockPictureInPicture(child_web_contents()));
}
{
base::test::ScopedFeatureList feature_list;
feature_list.InitAndDisableFeature(
media::kFileDialogsBlockPictureInPicture);
// With the feature disabled, no file dialogs should block
// picture-in-picture windows.
EXPECT_FALSE(PictureInPictureWindowManager::GetInstance()
->ShouldFileDialogBlockPictureInPicture(web_contents()));
EXPECT_FALSE(
PictureInPictureWindowManager::GetInstance()
->ShouldFileDialogBlockPictureInPicture(child_web_contents()));
}
}
TEST_F(PictureInPictureWindowManagerTest, CanForceTuckPictureInPicture) {
{
// Force-tucking before opening a picture-in-picture window should tuck it.
auto tuck = std::make_unique<ScopedTuckPictureInPicture>();
MockPictureInPictureWindow pip_window;
PictureInPictureWindowManager::GetInstance()->OnPictureInPictureWindowShown(
&pip_window);
EXPECT_TRUE(pip_window.is_tucking());
tuck.reset();
EXPECT_FALSE(pip_window.is_tucking());
PictureInPictureWindowManager::GetInstance()
->OnPictureInPictureWindowHidden(&pip_window);
}
{
// Force-tucking after opening a picture-in-picture window should tuck it.
MockPictureInPictureWindow pip_window;
PictureInPictureWindowManager::GetInstance()->OnPictureInPictureWindowShown(
&pip_window);
EXPECT_FALSE(pip_window.is_tucking());
auto tuck = std::make_unique<ScopedTuckPictureInPicture>();
EXPECT_TRUE(pip_window.is_tucking());
tuck.reset();
EXPECT_FALSE(pip_window.is_tucking());
PictureInPictureWindowManager::GetInstance()
->OnPictureInPictureWindowHidden(&pip_window);
}
{
MockPictureInPictureWindow pip_window;
{
ScopedTuckPictureInPicture tuck1;
{
// Multiple ScopedTuckPictureInPicture should still tuck
// picture-in-picture windows.
ScopedTuckPictureInPicture tuck2;
PictureInPictureWindowManager::GetInstance()
->OnPictureInPictureWindowShown(&pip_window);
EXPECT_TRUE(pip_window.is_tucking());
}
// When one of them is destroyed but the other remains, it should still
// remain tucked.
EXPECT_TRUE(pip_window.is_tucking());
}
// Once both have been destroyed, picture-in-picture windows should be
// untucked.
EXPECT_FALSE(pip_window.is_tucking());
PictureInPictureWindowManager::GetInstance()
->OnPictureInPictureWindowHidden(&pip_window);
}
}
TEST_F(PictureInPictureWindowManagerTest,
ShouldFileDialogTuckPictureInPicture) {
PictureInPictureWindowManager::GetInstance()->EnterDocumentPictureInPicture(
web_contents(), child_web_contents());
{
base::test::ScopedFeatureList feature_list;
feature_list.InitAndEnableFeature(media::kFileDialogsTuckPictureInPicture);
// With the feature enabled, file dialogs that aren't on a document
// picture-in-picture window should tuck picture-in-picture windows.
EXPECT_TRUE(PictureInPictureWindowManager::GetInstance()
->ShouldFileDialogTuckPictureInPicture(web_contents()));
EXPECT_FALSE(
PictureInPictureWindowManager::GetInstance()
->ShouldFileDialogTuckPictureInPicture(child_web_contents()));
}
{
base::test::ScopedFeatureList feature_list;
feature_list.InitAndDisableFeature(media::kFileDialogsTuckPictureInPicture);
// With the feature disabled, no file dialogs should tuck
// picture-in-picture windows.
EXPECT_FALSE(PictureInPictureWindowManager::GetInstance()
->ShouldFileDialogTuckPictureInPicture(web_contents()));
EXPECT_FALSE(
PictureInPictureWindowManager::GetInstance()
->ShouldFileDialogTuckPictureInPicture(child_web_contents()));
}
PictureInPictureWindowManager::GetInstance()->ExitPictureInPicture();
}
TEST_F(PictureInPictureWindowManagerTest,
EnterAndCloseDocumentPip_NormalCloseDoesCommit) {
base::SimpleTestTickClock test_clock;
SetupPiPWindowManagerWithUmaHelper(&test_clock);
PictureInPictureWindowManager* picture_in_picture_window_manager =
PictureInPictureWindowManager::GetInstance();
picture_in_picture_window_manager->EnterDocumentPictureInPicture(
web_contents(), child_web_contents());
test_clock.Advance(base::Milliseconds(3000));
picture_in_picture_window_manager->ExitPictureInPicture();
std::unique_ptr<base::HistogramSamples> samples(
GetHistogramSamplesSinceTestStart(kPictureInPictureTotalTimeHistogram));
EXPECT_EQ(1, samples->TotalCount());
EXPECT_EQ(1, samples->GetCount(3000));
}
TEST_F(PictureInPictureWindowManagerTest,
EnterAndCloseVideoPip_NormalCloseDoesCommit) {
base::SimpleTestTickClock test_clock;
SetupPiPWindowManagerWithUmaHelper(&test_clock);
PictureInPictureWindowManager* picture_in_picture_window_manager =
PictureInPictureWindowManager::GetInstance();
picture_in_picture_window_manager->EnterVideoPictureInPicture(web_contents());
test_clock.Advance(base::Milliseconds(3000));
picture_in_picture_window_manager->ExitPictureInPicture();
std::unique_ptr<base::HistogramSamples> samples(
GetHistogramSamplesSinceTestStart(kPictureInPictureTotalTimeHistogram));
EXPECT_EQ(1, samples->TotalCount());
EXPECT_EQ(1, samples->GetCount(3000));
}
TEST_F(PictureInPictureWindowManagerTest,
EnterAndCloseDocumentPip_UICloseDoesCommit) {
base::SimpleTestTickClock test_clock;
SetupPiPWindowManagerWithUmaHelper(&test_clock);
PictureInPictureWindowManager* picture_in_picture_window_manager =
PictureInPictureWindowManager::GetInstance();
picture_in_picture_window_manager->EnterDocumentPictureInPicture(
web_contents(), child_web_contents());
test_clock.Advance(base::Milliseconds(3000));
picture_in_picture_window_manager->ExitPictureInPictureViaWindowUi(
PictureInPictureWindowManager::UiBehavior::kCloseWindowOnly);
std::unique_ptr<base::HistogramSamples> samples(
GetHistogramSamplesSinceTestStart(kPictureInPictureTotalTimeHistogram));
EXPECT_EQ(1, samples->TotalCount());
EXPECT_EQ(1, samples->GetCount(3000));
}
TEST_F(PictureInPictureWindowManagerTest,
EnterAndCloseVideoPip_UICloseDoesCommit) {
base::SimpleTestTickClock test_clock;
SetupPiPWindowManagerWithUmaHelper(&test_clock);
PictureInPictureWindowManager* picture_in_picture_window_manager =
PictureInPictureWindowManager::GetInstance();
picture_in_picture_window_manager->EnterVideoPictureInPicture(web_contents());
test_clock.Advance(base::Milliseconds(3000));
picture_in_picture_window_manager->ExitPictureInPictureViaWindowUi(
PictureInPictureWindowManager::UiBehavior::kCloseWindowOnly);
std::unique_ptr<base::HistogramSamples> samples(
GetHistogramSamplesSinceTestStart(kPictureInPictureTotalTimeHistogram));
EXPECT_EQ(1, samples->TotalCount());
EXPECT_EQ(1, samples->GetCount(3000));
}
#endif // !BUILDFLAG(IS_ANDROID)
|