1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
|
// Copyright 2012 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <stddef.h>
#include <algorithm>
#include <cstdlib>
#include <map>
#include <memory>
#include <sstream>
#include <string>
#include <utility>
#include <vector>
#include "base/base_paths.h"
#include "base/command_line.h"
#include "base/files/file_path.h"
#include "base/no_destructor.h"
#include "base/path_service.h"
#include "base/run_loop.h"
#include "base/threading/thread_restrictions.h"
#include "build/build_config.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/profiles/profile_manager.h"
#include "chrome/common/chrome_paths.h"
#include "chrome/test/base/chrome_test_utils.h"
#include "chrome/test/base/platform_browser_test.h"
#include "components/policy/core/browser/browser_policy_connector.h"
#include "components/policy/core/browser/policy_pref_mapping_test.h"
#include "components/policy/core/common/mock_configuration_policy_provider.h"
#include "components/policy/core/common/policy_map.h"
#include "components/prefs/pref_service.h"
#include "components/variations/variations_test_utils.h"
#include "content/public/test/browser_test.h"
#include "content/public/test/browser_test_utils.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#if BUILDFLAG(IS_CHROMEOS)
#include "ash/constants/ash_switches.h"
#include "chrome/browser/ash/profiles/profile_helper.h"
#else
#include "components/enterprise/browser/controller/fake_browser_dm_token_storage.h"
#endif // BUILDFLAG(IS_CHROMEOS)
namespace policy {
const size_t kNumChunks = 32;
namespace {
base::FilePath GetTestCaseDir() {
base::ScopedAllowBlockingForTesting allow_blocking;
base::FilePath path;
base::PathService::Get(base::DIR_SRC_TEST_DATA_ROOT, &path);
return path.Append(FILE_PATH_LITERAL("components"))
.Append(FILE_PATH_LITERAL("policy"))
.Append(FILE_PATH_LITERAL("test"))
.Append(FILE_PATH_LITERAL("data"))
.Append(FILE_PATH_LITERAL("pref_mapping"));
}
size_t GetNumChunks() {
if (base::CommandLine::ForCurrentProcess()->HasSwitch(
kPolicyToPrefMappingsFilterSwitch)) {
// Run as one chunk when test filter specified.
return 1;
}
return kNumChunks;
}
} // namespace
typedef PlatformBrowserTest PolicyPrefsTestCoverageTest;
IN_PROC_BROWSER_TEST_F(PolicyPrefsTestCoverageTest, AllPoliciesHaveATestCase) {
VerifyAllPoliciesHaveATestCase(GetTestCaseDir());
}
// Base class for tests that change policy.
class PolicyPrefsTest : public PlatformBrowserTest {
public:
PolicyPrefsTest() = default;
PolicyPrefsTest(const PolicyPrefsTest&) = delete;
PolicyPrefsTest& operator=(const PolicyPrefsTest&) = delete;
~PolicyPrefsTest() override = default;
protected:
void SetUpInProcessBrowserTestFixture() override {
// Some policies default value might depend on features, enforce use of
// field trial testing config to avoid having unexpected results based on
// new feature flags coming from the server (e.g. on Chrome-branded CI
// bots).
variations::EnableTestingConfig();
GetMockPolicyProvider()->SetDefaultReturns(
true /* is_initialization_complete_return */,
true /* is_first_policy_load_complete_return */);
BrowserPolicyConnector::SetPolicyProviderForTesting(
GetMockPolicyProvider());
#if BUILDFLAG(IS_ANDROID)
// Intentionally leak the mock provider on Android. See comment in
// GetMockPolicyProvider() for details.
::testing::Mock::AllowLeak(GetMockPolicyProvider());
#endif // BUILDFLAG(IS_ANDROID)
}
void TearDownOnMainThread() override { ClearProviderPolicy(); }
void ClearProviderPolicy() {
GetMockPolicyProvider()->UpdateChromePolicy(PolicyMap());
base::RunLoop().RunUntilIdle();
}
MockConfigurationPolicyProvider* GetMockPolicyProvider() {
#if BUILDFLAG(IS_ANDROID)
// Trying to delete the mock provider on Android leads to a cascade of
// crashes due to ChromeBrowserPolicyConnector and ProfileImpl not being
// deleted. Those crashes are caused by checks that ensure that observer
// lists of ConfigurationPolicyProvider are always empty on destruction.
// On Desktop, removal of observers from those lists is triggered by the
// destructors of the classes above, but those same destructors are never
// invoked on Android.
static base::NoDestructor<
testing::NiceMock<MockConfigurationPolicyProvider>>
provider;
return provider.get();
#else
// On non-Android platforms, the mock provider cleanup will be triggered
// by ChromeBrowserPolicyConnector and ProfileImpl destructors. Thus it's
// safe to define a provider object that is deleted on scope destruction.
return &provider_;
#endif // BUILDFLAG(IS_ANDROID)
}
#if !BUILDFLAG(IS_ANDROID)
testing::NiceMock<MockConfigurationPolicyProvider> provider_;
#endif // !BUILDFLAG(IS_ANDROID)
};
// Splits the test cases into `kNumChunks` and the testing parameter determines
// the index of the current chunk. This prevents the test from timing out when
// testing all test cases in a single browser test.
class ChunkedPolicyPrefsTest : public PolicyPrefsTest,
public ::testing::WithParamInterface<size_t> {
public:
ChunkedPolicyPrefsTest() = default;
ChunkedPolicyPrefsTest(const ChunkedPolicyPrefsTest&) = delete;
ChunkedPolicyPrefsTest& operator=(const ChunkedPolicyPrefsTest&) = delete;
~ChunkedPolicyPrefsTest() override = default;
protected:
PrefMappingChunkInfo chunk_info_{GetParam(), GetNumChunks()};
};
// Verifies that policies make their corresponding preferences become managed,
// and that the user can't override that setting.
// README SHERIFFs: This test encapsulates a whole suite of individual browser
// tests for performance reasons and therefore has an increased chance of
// failure/flakiness.
// IMPORTANT: Please add hendrich@chromium.org on any related bugs when
// disabling this test.
IN_PROC_BROWSER_TEST_P(ChunkedPolicyPrefsTest, PolicyToPrefsMapping) {
base::ScopedAllowBlockingForTesting allow_blocking;
#if !BUILDFLAG(IS_CHROMEOS)
policy::FakeBrowserDMTokenStorage storage;
policy::BrowserDMTokenStorage::SetForTesting(&storage);
#endif // !BUILDFLAG(IS_CHROMEOS)
PrefService* local_state = g_browser_process->local_state();
PrefService* user_prefs = ProfileManager::GetLastUsedProfileIfLoaded()
->GetOriginalProfile()
->GetPrefs();
VerifyPolicyToPrefMappings(GetTestCaseDir(), local_state, user_prefs,
/* signin_profile_prefs= */ nullptr,
GetMockPolicyProvider(), &chunk_info_);
}
INSTANTIATE_TEST_SUITE_P(Chunked,
ChunkedPolicyPrefsTest,
::testing::Range(/* start= */ static_cast<size_t>(0),
/* end= */ GetNumChunks()));
#if BUILDFLAG(IS_CHROMEOS)
// Class used to check policy to pref mappings for policies that are mapped into
// the sign-in profile (usually via LoginProfilePolicyProvider).
class SigninPolicyPrefsTest : public PolicyPrefsTest {
public:
SigninPolicyPrefsTest() = default;
SigninPolicyPrefsTest(const SigninPolicyPrefsTest&) = delete;
SigninPolicyPrefsTest& operator=(const SigninPolicyPrefsTest&) = delete;
~SigninPolicyPrefsTest() override = default;
protected:
void SetUpCommandLine(base::CommandLine* command_line) override {
PolicyPrefsTest::SetUpCommandLine(command_line);
command_line->AppendSwitch(ash::switches::kLoginManager);
command_line->AppendSwitch(ash::switches::kForceLoginManagerInTests);
}
};
IN_PROC_BROWSER_TEST_F(SigninPolicyPrefsTest, PolicyToPrefsMapping) {
PrefService* signin_profile_prefs =
ash::ProfileHelper::GetSigninProfile()->GetPrefs();
// Only checking signin_profile_prefs here since |local_state| is already
// checked by PolicyPrefsTest.PolicyToPrefsMapping test.
VerifyPolicyToPrefMappings(GetTestCaseDir(), /* local_state= */ nullptr,
/* user_prefs= */ nullptr, signin_profile_prefs,
GetMockPolicyProvider());
}
#endif // BUILDFLAG(IS_CHROMEOS)
// For WebUI integration tests, see cr_policy_indicator_tests.js and
// cr_policy_pref_indicator_tests.js.
} // namespace policy
|
