1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
|
// Copyright 2012 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#ifdef UNSAFE_BUFFERS_BUILD
// TODO(crbug.com/40285824): Remove this and convert code to safer constructs.
#pragma allow_unsafe_buffers
#endif
#include "chrome/browser/prefs/chrome_command_line_pref_store.h"
#include <stddef.h>
#include <array>
#include "base/command_line.h"
#include "base/memory/ref_counted.h"
#include "base/memory/scoped_refptr.h"
#include "base/strings/string_util.h"
#include "base/values.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/pref_names.h"
#include "components/language/core/browser/pref_names.h"
#include "components/proxy_config/proxy_config_dictionary.h"
#include "components/proxy_config/proxy_config_pref_names.h"
#include "content/public/common/content_switches.h"
#include "services/network/public/cpp/network_switches.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/base/ui_base_switches.h"
namespace {
const char unknown_bool[] = "unknown_switch";
const char unknown_string[] = "unknown_other_switch";
} // namespace
class TestCommandLinePrefStore : public ChromeCommandLinePrefStore {
public:
explicit TestCommandLinePrefStore(base::CommandLine* cl)
: ChromeCommandLinePrefStore(cl) {}
bool ProxySwitchesAreValid() {
return ValidateProxySwitches();
}
void VerifyProxyMode(ProxyPrefs::ProxyMode expected_mode) {
const base::Value* value = nullptr;
ASSERT_TRUE(GetValue(proxy_config::prefs::kProxy, &value));
ASSERT_TRUE(value->is_dict());
ProxyConfigDictionary dict(value->GetDict().Clone());
ProxyPrefs::ProxyMode actual_mode;
ASSERT_TRUE(dict.GetMode(&actual_mode));
EXPECT_EQ(expected_mode, actual_mode);
}
void VerifySSLCipherSuites(const char* const* ciphers,
size_t cipher_count) {
const base::Value* value = nullptr;
ASSERT_TRUE(GetValue(prefs::kCipherSuiteBlacklist, &value));
ASSERT_TRUE(value->is_list());
ASSERT_EQ(cipher_count, value->GetList().size());
for (const base::Value& cipher_string : value->GetList()) {
ASSERT_TRUE(cipher_string.is_string());
EXPECT_EQ(*ciphers++, cipher_string.GetString());
}
}
private:
~TestCommandLinePrefStore() override = default;
};
// Tests a simple string pref on the command line.
TEST(ChromeCommandLinePrefStoreTest, SimpleStringPref) {
base::CommandLine cl(base::CommandLine::NO_PROGRAM);
cl.AppendSwitchASCII(switches::kLang, "hi-MOM");
scoped_refptr<ChromeCommandLinePrefStore> store =
new ChromeCommandLinePrefStore(&cl);
const base::Value* actual = nullptr;
EXPECT_TRUE(store->GetValue(language::prefs::kApplicationLocale, &actual));
ASSERT_TRUE(actual->is_string());
EXPECT_EQ("hi-MOM", actual->GetString());
}
// Tests a simple boolean pref on the command line.
TEST(ChromeCommandLinePrefStoreTest, SimpleBooleanPref) {
base::CommandLine cl(base::CommandLine::NO_PROGRAM);
cl.AppendSwitch(switches::kNoProxyServer);
scoped_refptr<TestCommandLinePrefStore> store =
new TestCommandLinePrefStore(&cl);
store->VerifyProxyMode(ProxyPrefs::MODE_DIRECT);
}
// Tests a command line with no recognized prefs.
TEST(ChromeCommandLinePrefStoreTest, NoPrefs) {
base::CommandLine cl(base::CommandLine::NO_PROGRAM);
cl.AppendSwitch(unknown_string);
cl.AppendSwitchASCII(unknown_bool, "a value");
scoped_refptr<ChromeCommandLinePrefStore> store =
new ChromeCommandLinePrefStore(&cl);
const base::Value* actual = nullptr;
EXPECT_FALSE(store->GetValue(unknown_bool, &actual));
EXPECT_FALSE(store->GetValue(unknown_string, &actual));
}
// Tests a complex command line with multiple known and unknown switches.
TEST(ChromeCommandLinePrefStoreTest, MultipleSwitches) {
base::CommandLine cl(base::CommandLine::NO_PROGRAM);
cl.AppendSwitch(unknown_string);
cl.AppendSwitchASCII(switches::kProxyServer, "proxy");
cl.AppendSwitchASCII(switches::kProxyBypassList, "list");
cl.AppendSwitchASCII(unknown_bool, "a value");
scoped_refptr<TestCommandLinePrefStore> store =
new TestCommandLinePrefStore(&cl);
const base::Value* actual = nullptr;
EXPECT_FALSE(store->GetValue(unknown_bool, &actual));
EXPECT_FALSE(store->GetValue(unknown_string, &actual));
store->VerifyProxyMode(ProxyPrefs::MODE_FIXED_SERVERS);
const base::Value* value = nullptr;
ASSERT_TRUE(store->GetValue(proxy_config::prefs::kProxy, &value));
ASSERT_TRUE(value->is_dict());
ProxyConfigDictionary dict(value->GetDict().Clone());
std::string string_result;
ASSERT_TRUE(dict.GetProxyServer(&string_result));
EXPECT_EQ("proxy", string_result);
ASSERT_TRUE(dict.GetBypassList(&string_result));
EXPECT_EQ("list", string_result);
}
// Tests proxy switch validation.
TEST(ChromeCommandLinePrefStoreTest, ProxySwitchValidation) {
base::CommandLine cl(base::CommandLine::NO_PROGRAM);
// No switches.
scoped_refptr<TestCommandLinePrefStore> store =
new TestCommandLinePrefStore(&cl);
EXPECT_TRUE(store->ProxySwitchesAreValid());
// Only no-proxy.
cl.AppendSwitch(switches::kNoProxyServer);
scoped_refptr<TestCommandLinePrefStore> store2 =
new TestCommandLinePrefStore(&cl);
EXPECT_TRUE(store2->ProxySwitchesAreValid());
// Another proxy switch too.
cl.AppendSwitch(switches::kProxyAutoDetect);
scoped_refptr<TestCommandLinePrefStore> store3 =
new TestCommandLinePrefStore(&cl);
EXPECT_FALSE(store3->ProxySwitchesAreValid());
// All proxy switches except no-proxy.
base::CommandLine cl2(base::CommandLine::NO_PROGRAM);
cl2.AppendSwitch(switches::kProxyAutoDetect);
cl2.AppendSwitchASCII(switches::kProxyServer, "server");
cl2.AppendSwitchASCII(switches::kProxyPacUrl, "url");
cl2.AppendSwitchASCII(switches::kProxyBypassList, "list");
scoped_refptr<TestCommandLinePrefStore> store4 =
new TestCommandLinePrefStore(&cl2);
EXPECT_TRUE(store4->ProxySwitchesAreValid());
}
TEST(ChromeCommandLinePrefStoreTest, ManualProxyModeInference) {
base::CommandLine cl1(base::CommandLine::NO_PROGRAM);
cl1.AppendSwitch(unknown_string);
cl1.AppendSwitchASCII(switches::kProxyServer, "proxy");
scoped_refptr<TestCommandLinePrefStore> store1 =
new TestCommandLinePrefStore(&cl1);
store1->VerifyProxyMode(ProxyPrefs::MODE_FIXED_SERVERS);
base::CommandLine cl2(base::CommandLine::NO_PROGRAM);
cl2.AppendSwitchASCII(switches::kProxyPacUrl, "proxy");
scoped_refptr<TestCommandLinePrefStore> store2 =
new TestCommandLinePrefStore(&cl2);
store2->VerifyProxyMode(ProxyPrefs::MODE_PAC_SCRIPT);
base::CommandLine cl3(base::CommandLine::NO_PROGRAM);
cl3.AppendSwitchASCII(switches::kProxyServer, std::string());
scoped_refptr<TestCommandLinePrefStore> store3 =
new TestCommandLinePrefStore(&cl3);
store3->VerifyProxyMode(ProxyPrefs::MODE_DIRECT);
}
TEST(ChromeCommandLinePrefStoreTest, DisableSSLCipherSuites) {
base::CommandLine cl1(base::CommandLine::NO_PROGRAM);
cl1.AppendSwitchASCII(switches::kCipherSuiteBlacklist,
"0x0004,0x0005");
scoped_refptr<TestCommandLinePrefStore> store1 =
new TestCommandLinePrefStore(&cl1);
const char* const expected_ciphers1[] = {
"0x0004",
"0x0005",
};
store1->VerifySSLCipherSuites(expected_ciphers1,
std::size(expected_ciphers1));
base::CommandLine cl2(base::CommandLine::NO_PROGRAM);
cl2.AppendSwitchASCII(switches::kCipherSuiteBlacklist,
"0x0004, WHITESPACE_IGNORED TEST , 0x0005");
scoped_refptr<TestCommandLinePrefStore> store2 =
new TestCommandLinePrefStore(&cl2);
const char* const expected_ciphers2[] = {
"0x0004",
"WHITESPACE_IGNORED TEST",
"0x0005",
};
store2->VerifySSLCipherSuites(expected_ciphers2,
std::size(expected_ciphers2));
base::CommandLine cl3(base::CommandLine::NO_PROGRAM);
cl3.AppendSwitchASCII(switches::kCipherSuiteBlacklist,
"0x0004;MOAR;0x0005");
scoped_refptr<TestCommandLinePrefStore> store3 =
new TestCommandLinePrefStore(&cl3);
const char* const expected_ciphers3[] = {
"0x0004;MOAR;0x0005"
};
store3->VerifySSLCipherSuites(expected_ciphers3,
std::size(expected_ciphers3));
}
TEST(ChromeCommandLinePrefStoreTest, ExplicitlyAllowedPorts) {
base::CommandLine cl(base::CommandLine::NO_PROGRAM);
cl.AppendSwitchASCII(switches::kExplicitlyAllowedPorts,
"79,554, 6000, foo,1000000");
auto store = base::MakeRefCounted<TestCommandLinePrefStore>(&cl);
constexpr static const auto kExpectedPorts = std::to_array<int>({
79,
554,
6000,
});
const base::Value* value = nullptr;
ASSERT_TRUE(store->GetValue(prefs::kExplicitlyAllowedNetworkPorts, &value));
ASSERT_TRUE(value);
ASSERT_TRUE(value->is_list());
ASSERT_EQ(std::size(kExpectedPorts), value->GetList().size());
int i = 0;
for (const base::Value& port : value->GetList()) {
ASSERT_TRUE(port.is_int());
EXPECT_EQ(kExpectedPorts[i], port.GetInt());
++i;
}
}
TEST(ChromeCommandLinePrefStoreTest, AcceptLanguage) {
base::CommandLine cl(base::CommandLine::NO_PROGRAM);
cl.AppendSwitchASCII(switches::kAcceptLang, "de,en,fr,jp");
auto store = base::MakeRefCounted<ChromeCommandLinePrefStore>(&cl);
const base::Value* actual = nullptr;
EXPECT_TRUE(store->GetValue(language::prefs::kSelectedLanguages, &actual));
ASSERT_TRUE(actual);
ASSERT_TRUE(actual->is_string());
EXPECT_EQ("de,en,fr,jp", actual->GetString());
}
|
