1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290
|
// Copyright 2012 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/profiles/profile_list_desktop.h"
#include <memory>
#include <string>
#include <vector>
#include "base/command_line.h"
#include "base/strings/utf_string_conversions.h"
#include "build/build_config.h"
#include "chrome/browser/profiles/avatar_menu_observer.h"
#include "chrome/browser/profiles/profile_attributes_entry.h"
#include "chrome/browser/profiles/profile_attributes_init_params.h"
#include "chrome/browser/profiles/profile_attributes_storage.h"
#include "chrome/browser/profiles/profiles_state.h"
#include "chrome/browser/signin/identity_test_environment_profile_adaptor.h"
#include "chrome/grit/generated_resources.h"
#include "chrome/test/base/testing_browser_process.h"
#include "chrome/test/base/testing_profile.h"
#include "chrome/test/base/testing_profile_manager.h"
#include "components/account_id/account_id.h"
#include "components/sync_preferences/pref_service_syncable.h"
#include "content/public/test/browser_task_environment.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/base/l10n/l10n_util.h"
using base::ASCIIToUTF16;
namespace {
class MockObserver : public AvatarMenuObserver {
public:
MockObserver() : count_(0) {}
MockObserver(const MockObserver&) = delete;
MockObserver& operator=(const MockObserver&) = delete;
~MockObserver() override = default;
void OnAvatarMenuChanged(AvatarMenu* avatar_menu) override { ++count_; }
int change_count() const { return count_; }
private:
int count_;
};
class ProfileListDesktopTest : public testing::Test {
public:
ProfileListDesktopTest()
: manager_(TestingBrowserProcess::GetGlobal()) {
}
ProfileListDesktopTest(const ProfileListDesktopTest&) = delete;
ProfileListDesktopTest& operator=(const ProfileListDesktopTest&) = delete;
void SetUp() override {
ASSERT_TRUE(manager_.SetUp());
}
AvatarMenu* GetAvatarMenu() {
// Reset the MockObserver.
mock_observer_.reset(new MockObserver());
EXPECT_EQ(0, change_count());
// Reset the menu.
avatar_menu_.reset(new AvatarMenu(
manager()->profile_attributes_storage(),
mock_observer_.get(),
NULL));
avatar_menu_->RebuildMenu();
EXPECT_EQ(0, change_count());
return avatar_menu_.get();
}
TestingProfileManager* manager() { return &manager_; }
void AddOmittedProfile(const std::string& name) {
ProfileAttributesStorage* storage = manager()->profile_attributes_storage();
base::FilePath profile_path = manager()->profiles_dir().AppendASCII(name);
ProfileAttributesInitParams params;
params.profile_path = profile_path;
params.profile_name = ASCIIToUTF16(name);
params.is_ephemeral = true;
params.is_omitted = true;
storage->AddProfile(std::move(params));
}
TestingProfile* CreateTestingProfile(const std::string& profile_name) {
return manager()->CreateTestingProfile(
profile_name, IdentityTestEnvironmentProfileAdaptor::
GetIdentityTestEnvironmentFactories());
}
int change_count() const { return mock_observer_->change_count(); }
private:
content::BrowserTaskEnvironment task_environment_;
TestingProfileManager manager_;
std::unique_ptr<MockObserver> mock_observer_;
std::unique_ptr<AvatarMenu> avatar_menu_;
};
TEST_F(ProfileListDesktopTest, InitialCreation) {
CreateTestingProfile("Test 1");
CreateTestingProfile("Test 2");
AvatarMenu* menu = GetAvatarMenu();
EXPECT_EQ(0, change_count());
ASSERT_EQ(2U, menu->GetNumberOfItems());
const AvatarMenu::Item& item1 = menu->GetItemAt(0);
EXPECT_EQ(0U, item1.menu_index);
EXPECT_EQ(u"Test 1", item1.name);
const AvatarMenu::Item& item2 = menu->GetItemAt(1);
EXPECT_EQ(1U, item2.menu_index);
EXPECT_EQ(u"Test 2", item2.name);
}
TEST_F(ProfileListDesktopTest, NoOmittedProfiles) {
ProfileListDesktop profile_list_desktop(
manager()->profile_attributes_storage());
// Profiles are stored and listed alphabetically.
std::vector<std::string> profile_names = {"0 included",
"1 included",
"2 included",
"3 included"};
size_t profile_count = profile_names.size();
// Add the profiles.
for (const std::string& profile_name : profile_names)
CreateTestingProfile(profile_name);
// Rebuild avatar menu.
profile_list_desktop.RebuildMenu();
ASSERT_EQ(profile_count, profile_list_desktop.GetNumberOfItems());
// Verify contents in avatar menu.
for (size_t i = 0u; i < profile_count; ++i) {
const AvatarMenu::Item& item = profile_list_desktop.GetItemAt(i);
EXPECT_EQ(i, item.menu_index);
EXPECT_EQ(ASCIIToUTF16(profile_names[i]), item.name);
EXPECT_EQ(i,
profile_list_desktop.MenuIndexFromProfilePath(item.profile_path));
}
}
TEST_F(ProfileListDesktopTest, GuestProfile) {
ProfileListDesktop profile_list_desktop(
manager()->profile_attributes_storage());
CreateTestingProfile("Default profile");
Profile* guest_profile = manager()->CreateGuestProfile();
profile_list_desktop.RebuildMenu();
// Only the default profile is in the menu.
EXPECT_EQ(1u, profile_list_desktop.GetNumberOfItems());
EXPECT_FALSE(
profile_list_desktop.MenuIndexFromProfilePath(guest_profile->GetPath())
.has_value());
}
TEST_F(ProfileListDesktopTest, WithOmittedProfiles) {
ProfileListDesktop profile_list_desktop(
manager()->profile_attributes_storage());
// Profiles are stored and listed alphabetically.
std::vector<std::string> profile_names = {"0 omitted",
"1 included",
"2 omitted",
"3 included",
"4 included",
"5 omitted",
"6 included",
"7 omitted"};
// Add the profiles.
std::vector<size_t> included_profile_indices;
for (size_t i = 0u; i < profile_names.size(); ++i) {
if (profile_names[i].find("included") != std::string::npos) {
CreateTestingProfile(profile_names[i]);
included_profile_indices.push_back(i);
} else {
AddOmittedProfile(profile_names[i]);
}
}
// Rebuild avatar menu.
size_t included_profile_count = included_profile_indices.size();
profile_list_desktop.RebuildMenu();
ASSERT_EQ(included_profile_count, profile_list_desktop.GetNumberOfItems());
// Verify contents in avatar menu.
for (size_t i = 0u; i < included_profile_count; ++i) {
const AvatarMenu::Item& item = profile_list_desktop.GetItemAt(i);
EXPECT_EQ(i, item.menu_index);
EXPECT_EQ(ASCIIToUTF16(profile_names[included_profile_indices[i]]),
item.name);
EXPECT_EQ(i,
profile_list_desktop.MenuIndexFromProfilePath(item.profile_path));
}
}
TEST_F(ProfileListDesktopTest, ActiveItem) {
CreateTestingProfile("Default");
CreateTestingProfile("Test 2");
AvatarMenu* menu = GetAvatarMenu();
ASSERT_EQ(2u, menu->GetNumberOfItems());
// TODO(jeremy): Expand test to verify active profile index other than 0
// crbug.com/100871
ASSERT_EQ(0u, menu->GetActiveProfileIndex());
}
TEST_F(ProfileListDesktopTest, ModifyingNameResortsCorrectly) {
std::string name1("Alpha");
std::string name2("Beta");
std::string newname1("Gamma");
TestingProfile* profile1 = CreateTestingProfile(name1);
CreateTestingProfile(name2);
AvatarMenu* menu = GetAvatarMenu();
EXPECT_EQ(0, change_count());
ASSERT_EQ(2u, menu->GetNumberOfItems());
const AvatarMenu::Item& item1 = menu->GetItemAt(0u);
EXPECT_EQ(0u, item1.menu_index);
EXPECT_EQ(ASCIIToUTF16(name1), item1.name);
const AvatarMenu::Item& item2 = menu->GetItemAt(1u);
EXPECT_EQ(1u, item2.menu_index);
EXPECT_EQ(ASCIIToUTF16(name2), item2.name);
// Change the name of the first profile, and this triggers the resorting of
// the avatar menu.
ProfileAttributesEntry* entry =
manager()->profile_attributes_storage()->GetProfileAttributesWithPath(
profile1->GetPath());
ASSERT_NE(entry, nullptr);
entry->SetLocalProfileName(ASCIIToUTF16(newname1), false);
EXPECT_EQ(1, change_count());
// Now the first menu item should be named "beta", and the second be "gamma".
const AvatarMenu::Item& item1next = menu->GetItemAt(0u);
EXPECT_EQ(0u, item1next.menu_index);
EXPECT_EQ(ASCIIToUTF16(name2), item1next.name);
const AvatarMenu::Item& item2next = menu->GetItemAt(1u);
EXPECT_EQ(1u, item2next.menu_index);
EXPECT_EQ(ASCIIToUTF16(newname1), item2next.name);
}
TEST_F(ProfileListDesktopTest, ChangeOnNotify) {
CreateTestingProfile("Test 1");
CreateTestingProfile("Test 2");
AvatarMenu* menu = GetAvatarMenu();
EXPECT_EQ(0, change_count());
EXPECT_EQ(2u, menu->GetNumberOfItems());
CreateTestingProfile("Test 3");
// Three changes happened via the call to CreateTestingProfile: adding the
// profile to the attributes storage, setting the user name (which rebuilds
// the list of profiles after the name change) and changing the avatar.
// On Windows, an extra change happens to set the shortcut name for the
// profile.
EXPECT_GE(3, change_count());
ASSERT_EQ(3u, menu->GetNumberOfItems());
const AvatarMenu::Item& item1 = menu->GetItemAt(0u);
EXPECT_EQ(0u, item1.menu_index);
EXPECT_EQ(u"Test 1", item1.name);
const AvatarMenu::Item& item2 = menu->GetItemAt(1u);
EXPECT_EQ(1u, item2.menu_index);
EXPECT_EQ(u"Test 2", item2.name);
const AvatarMenu::Item& item3 = menu->GetItemAt(2u);
EXPECT_EQ(2u, item3.menu_index);
EXPECT_EQ(u"Test 3", item3.name);
}
} // namespace
|