1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582
|
// Copyright 2014 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/renderer_context_menu/spelling_menu_observer.h"
#include <memory>
#include "base/strings/utf_string_conversions.h"
#include "base/test/scoped_feature_list.h"
#include "base/values.h"
#include "build/build_config.h"
#include "chrome/app/chrome_command_ids.h"
#include "chrome/browser/renderer_context_menu/mock_render_view_context_menu.h"
#include "chrome/browser/spellchecker/spellcheck_factory.h"
#include "chrome/browser/spellchecker/spellcheck_service.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "components/prefs/pref_service.h"
#include "components/spellcheck/browser/pref_names.h"
#include "components/spellcheck/browser/spelling_service_client.h"
#include "components/spellcheck/common/spellcheck_features.h"
#include "components/spellcheck/spellcheck_buildflags.h"
#include "content/public/browser/context_menu_params.h"
#include "content/public/test/browser_test.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace {
// A test class used in this file. This test should be a browser test because it
// accesses resources.
class SpellingMenuObserverTest : public InProcessBrowserTest {
public:
SpellingMenuObserverTest();
void SetUpOnMainThread() override {
Reset(false);
#if BUILDFLAG(IS_WIN) && BUILDFLAG(USE_BROWSER_SPELLCHECKER)
base::Value::List dictionary;
dictionary.Append("en-US");
menu()->GetPrefs()->SetList(spellcheck::prefs::kSpellCheckDictionaries,
std::move(dictionary));
// Use SetTestingFactoryAndUse to force creation and initialization of
// SpellcheckService using the TestingProfile browser context.
SpellcheckServiceFactory::GetInstance()->SetTestingFactoryAndUse(
menu()->GetBrowserContext(),
base::BindRepeating(&SpellingMenuObserverTest::BuildSpellcheckService,
base::Unretained(this)));
#endif // BUILDFLAG(IS_WIN) && BUILDFLAG(USE_BROWSER_SPELLCHECKER)
}
#if BUILDFLAG(IS_WIN) && BUILDFLAG(USE_BROWSER_SPELLCHECKER)
std::unique_ptr<KeyedService> BuildSpellcheckService(
content::BrowserContext* context) {
auto spellcheck_service = std::make_unique<SpellcheckService>(context);
// Call SetLanguage to assure that the platform spellchecker is initialized.
spellcheck_platform::SetLanguage(
spellcheck_service->platform_spell_checker(), "en-US",
base::BindOnce(&SpellingMenuObserverTest::OnSetLanguageComplete,
base::Unretained(this)));
RunUntilCallbackReceived();
return spellcheck_service;
}
void OnSetLanguageComplete(bool result) {
ASSERT_TRUE(result);
callback_received_ = true;
if (quit_)
std::move(quit_).Run();
}
void OnSuggestionsComplete() {
callback_received_ = true;
if (quit_)
std::move(quit_).Run();
}
void RunUntilCallbackReceived() {
if (callback_received_)
return;
base::RunLoop run_loop;
quit_ = run_loop.QuitClosure();
run_loop.Run();
// Reset status.
callback_received_ = false;
}
#endif // BUILDFLAG(IS_WIN) && BUILDFLAG(USE_BROWSER_SPELLCHECKER)
void TearDownOnMainThread() override {
observer_.reset();
menu_.reset();
}
void Reset(bool incognito) {
observer_.reset();
menu_ = std::make_unique<MockRenderViewContextMenu>(incognito);
observer_ = std::make_unique<SpellingMenuObserver>(menu_.get());
menu_->SetObserver(observer_.get());
}
void InitMenu(const char* word, const char* suggestion) {
content::ContextMenuParams params;
params.is_editable = true;
params.misspelled_word = base::ASCIIToUTF16(word);
params.dictionary_suggestions.clear();
if (suggestion)
params.dictionary_suggestions.push_back(base::ASCIIToUTF16(suggestion));
#if BUILDFLAG(IS_WIN) && BUILDFLAG(USE_BROWSER_SPELLCHECKER)
// Expect early return if word is spelled correctly.
if (params.misspelled_word.empty())
callback_received_ = true;
observer_->RegisterSuggestionsCompleteCallbackForTesting(
base::BindOnce(&SpellingMenuObserverTest::OnSuggestionsComplete,
base::Unretained(this)));
#endif // BUILDFLAG(IS_WIN) && BUILDFLAG(USE_BROWSER_SPELLCHECKER)
observer_->InitMenu(params);
// Windows behavior needs this to be called as well to update placeholder
// menu items. Doesn't hurt for non-Windows platforms either.
observer_->OnContextMenuShown(params, gfx::Rect());
#if BUILDFLAG(IS_WIN) && BUILDFLAG(USE_BROWSER_SPELLCHECKER)
RunUntilCallbackReceived();
#endif // BUILDFLAG(IS_WIN) && BUILDFLAG(USE_BROWSER_SPELLCHECKER)
}
void ForceSuggestMode() {
menu()->GetPrefs()->SetBoolean(
spellcheck::prefs::kSpellCheckUseSpellingService, true);
// Force a non-empty and non-"en" locale so SUGGEST is available.
base::Value::List dictionary;
dictionary.Append("fr");
menu()->GetPrefs()->SetList(spellcheck::prefs::kSpellCheckDictionaries,
std::move(dictionary));
ASSERT_TRUE(SpellingServiceClient::IsAvailable(
menu()->GetBrowserContext(), SpellingServiceClient::SUGGEST));
ASSERT_FALSE(SpellingServiceClient::IsAvailable(
menu()->GetBrowserContext(), SpellingServiceClient::SPELLCHECK));
}
SpellingMenuObserverTest(const SpellingMenuObserverTest&) = delete;
SpellingMenuObserverTest& operator=(const SpellingMenuObserverTest&) = delete;
~SpellingMenuObserverTest() override;
MockRenderViewContextMenu* menu() { return menu_.get(); }
SpellingMenuObserver* observer() { return observer_.get(); }
private:
std::unique_ptr<SpellingMenuObserver> observer_;
std::unique_ptr<MockRenderViewContextMenu> menu_;
#if BUILDFLAG(IS_WIN) && BUILDFLAG(USE_BROWSER_SPELLCHECKER)
// Quits the RunLoop on receiving callbacks.
base::OnceClosure quit_;
// Flag used for early exit from RunLoop if callback already received.
bool callback_received_ = false;
base::test::ScopedFeatureList feature_list_;
#endif // BUILDFLAG(IS_WIN) && BUILDFLAG(USE_BROWSER_SPELLCHECKER)
};
#if BUILDFLAG(IS_WIN) && BUILDFLAG(USE_BROWSER_SPELLCHECKER)
SpellingMenuObserverTest::SpellingMenuObserverTest() {
feature_list_.InitWithFeatures(
/*enabled_features=*/{},
/*disabled_features=*/{spellcheck::kWinDelaySpellcheckServiceInit});
}
#else
SpellingMenuObserverTest::SpellingMenuObserverTest() = default;
#endif // BUILDFLAG(IS_WIN) && BUILDFLAG(USE_BROWSER_SPELLCHECKER)
SpellingMenuObserverTest::~SpellingMenuObserverTest() = default;
} // namespace
// Tests that right-clicking a correct word does not add any items.
IN_PROC_BROWSER_TEST_F(SpellingMenuObserverTest, InitMenuWithCorrectWord) {
InitMenu("", nullptr);
EXPECT_EQ(static_cast<size_t>(0), menu()->GetMenuSize());
}
// Tests that right-clicking a misspelled word adds two items:
// "Add to dictionary", "Use enhanced spell check".
IN_PROC_BROWSER_TEST_F(SpellingMenuObserverTest, InitMenuWithMisspelledWord) {
// Pick word that Windows platform spellcheck has no suggestions for.
InitMenu("missssspelling", nullptr);
EXPECT_EQ(2U, menu()->GetMenuSize());
// Read all the context-menu items added by this test and verify they are
// expected ones. We do not check the item titles to prevent resource changes
// from breaking this test. (I think it is not expected by those who change
// resources.)
MockRenderViewContextMenu::MockMenuItem item;
menu()->GetMenuItem(0, &item);
EXPECT_EQ(IDC_SPELLCHECK_ADD_TO_DICTIONARY, item.command_id);
EXPECT_TRUE(item.enabled);
EXPECT_FALSE(item.hidden);
menu()->GetMenuItem(1, &item);
EXPECT_EQ(IDC_CONTENT_CONTEXT_SPELLING_TOGGLE, item.command_id);
EXPECT_TRUE(item.enabled);
EXPECT_FALSE(item.checked);
EXPECT_FALSE(item.hidden);
menu()->GetMenuItem(2, &item);
}
#if BUILDFLAG(IS_WIN) && BUILDFLAG(USE_BROWSER_SPELLCHECKER)
// Tests that right-clicking a misspelled word that is identified as misspelled
// by both Hunspell and Windows platform combines their suggestions.
IN_PROC_BROWSER_TEST_F(SpellingMenuObserverTest,
WinInitMenuWithMisspelledWordCombined) {
InitMenu("mispelled", "misspelling");
EXPECT_EQ(6U, menu()->GetMenuSize());
// Read all the context-menu items added by this test and verify they are
// expected ones.
MockRenderViewContextMenu::MockMenuItem item;
// First separator.
menu()->GetMenuItem(0, &item);
EXPECT_EQ(-1, item.command_id);
EXPECT_FALSE(item.enabled);
EXPECT_FALSE(item.hidden);
// First suggestion.
menu()->GetMenuItem(1, &item);
EXPECT_EQ(IDC_SPELLCHECK_SUGGESTION_0, item.command_id);
EXPECT_TRUE(item.enabled);
EXPECT_FALSE(item.hidden);
EXPECT_EQ(u"misspelled", item.title);
// Second suggestion.
menu()->GetMenuItem(2, &item);
EXPECT_EQ(IDC_SPELLCHECK_SUGGESTION_0 + 1, item.command_id);
EXPECT_TRUE(item.enabled);
EXPECT_FALSE(item.hidden);
EXPECT_EQ(u"misspelling", item.title);
// Second separator.
menu()->GetMenuItem(3, &item);
EXPECT_EQ(-1, item.command_id);
EXPECT_FALSE(item.enabled);
EXPECT_FALSE(item.hidden);
// Add to dictionary.
menu()->GetMenuItem(4, &item);
EXPECT_EQ(IDC_SPELLCHECK_ADD_TO_DICTIONARY, item.command_id);
EXPECT_TRUE(item.enabled);
EXPECT_FALSE(item.hidden);
// Enhanced spellcheck toggle.
menu()->GetMenuItem(5, &item);
EXPECT_EQ(IDC_CONTENT_CONTEXT_SPELLING_TOGGLE, item.command_id);
EXPECT_TRUE(item.enabled);
EXPECT_FALSE(item.checked);
EXPECT_FALSE(item.hidden);
}
// Tests that right-clicking a misspelled word that is identified as misspelled
// by both Hunspell and Windows platform with the same suggestion leads to a
// single suggestion.
IN_PROC_BROWSER_TEST_F(SpellingMenuObserverTest,
WinInitMenuWithMisspelledWordNoDuplicateSuggestions) {
InitMenu("mispelled", "misspelled");
EXPECT_EQ(5U, menu()->GetMenuSize());
// Read all the context-menu items added by this test and verify they are
// expected ones.
MockRenderViewContextMenu::MockMenuItem item;
// First separator.
menu()->GetMenuItem(0, &item);
EXPECT_EQ(-1, item.command_id);
EXPECT_FALSE(item.enabled);
EXPECT_FALSE(item.hidden);
// First and only suggestion.
menu()->GetMenuItem(1, &item);
EXPECT_EQ(IDC_SPELLCHECK_SUGGESTION_0, item.command_id);
EXPECT_TRUE(item.enabled);
EXPECT_FALSE(item.hidden);
EXPECT_EQ(u"misspelled", item.title);
// Second separator.
menu()->GetMenuItem(2, &item);
EXPECT_EQ(-1, item.command_id);
EXPECT_FALSE(item.enabled);
EXPECT_FALSE(item.hidden);
// Add to dictionary.
menu()->GetMenuItem(3, &item);
EXPECT_EQ(IDC_SPELLCHECK_ADD_TO_DICTIONARY, item.command_id);
EXPECT_TRUE(item.enabled);
EXPECT_FALSE(item.hidden);
// Enhanced spellcheck toggle.
menu()->GetMenuItem(4, &item);
EXPECT_EQ(IDC_CONTENT_CONTEXT_SPELLING_TOGGLE, item.command_id);
EXPECT_TRUE(item.enabled);
EXPECT_FALSE(item.checked);
EXPECT_FALSE(item.hidden);
}
// Tests that right-clicking a misspelled word that is identified as misspelled
// by both Hunspell and Windows platform that has > 3 suggestions only displays
// 3 suggestions.
IN_PROC_BROWSER_TEST_F(SpellingMenuObserverTest,
WinInitMenuWithMisspelledWordMaxSuggestions) {
InitMenu("wtree", "wee");
EXPECT_EQ(7U, menu()->GetMenuSize());
std::set<std::u16string> suggestions(
{u"tree", u"twee", u"wee", u"ware", u"were"});
bool wee_suggested = false;
for (unsigned int i = 1; i < menu()->GetMenuSize(); i++) {
MockRenderViewContextMenu::MockMenuItem item;
menu()->GetMenuItem(i, &item);
if (!item.title.compare(u"wee")) {
wee_suggested = true;
break;
}
}
EXPECT_TRUE(wee_suggested);
// Read all the context-menu items added by this test and verify they are
// among the expected possibilities.
MockRenderViewContextMenu::MockMenuItem item;
// First separator.
menu()->GetMenuItem(0, &item);
EXPECT_EQ(-1, item.command_id);
EXPECT_FALSE(item.enabled);
EXPECT_FALSE(item.hidden);
// First suggestion.
menu()->GetMenuItem(1, &item);
EXPECT_EQ(IDC_SPELLCHECK_SUGGESTION_0, item.command_id);
EXPECT_TRUE(item.enabled);
EXPECT_FALSE(item.hidden);
EXPECT_TRUE(suggestions.contains(item.title));
// Second suggestion.
menu()->GetMenuItem(2, &item);
EXPECT_EQ(IDC_SPELLCHECK_SUGGESTION_0 + 1, item.command_id);
EXPECT_TRUE(item.enabled);
EXPECT_FALSE(item.hidden);
EXPECT_TRUE(suggestions.contains(item.title));
// Third suggestion.
menu()->GetMenuItem(3, &item);
EXPECT_EQ(IDC_SPELLCHECK_SUGGESTION_0 + 2, item.command_id);
EXPECT_TRUE(item.enabled);
EXPECT_FALSE(item.hidden);
EXPECT_TRUE(suggestions.contains(item.title));
// Second separator.
menu()->GetMenuItem(4, &item);
EXPECT_EQ(-1, item.command_id);
EXPECT_FALSE(item.enabled);
EXPECT_FALSE(item.hidden);
// Add to dictionary.
menu()->GetMenuItem(5, &item);
EXPECT_EQ(IDC_SPELLCHECK_ADD_TO_DICTIONARY, item.command_id);
EXPECT_TRUE(item.enabled);
EXPECT_FALSE(item.hidden);
// Enhanced spellcheck toggle.
menu()->GetMenuItem(6, &item);
EXPECT_EQ(IDC_CONTENT_CONTEXT_SPELLING_TOGGLE, item.command_id);
EXPECT_TRUE(item.enabled);
EXPECT_FALSE(item.checked);
EXPECT_FALSE(item.hidden);
}
#endif // BUILDFLAG(IS_WIN) && BUILDFLAG(USE_BROWSER_SPELLCHECKER)
// Tests that right-clicking a correct word when we enable spelling-service
// integration to verify an item "Use enhanced spell check" is checked. Even
// though this menu itself does not add this item, its sub-menu adds the item
// and calls SpellingMenuObserver::IsChecked() to check it.
IN_PROC_BROWSER_TEST_F(SpellingMenuObserverTest,
EnableSpellingServiceWithCorrectWord) {
menu()->GetPrefs()->SetBoolean(
spellcheck::prefs::kSpellCheckUseSpellingService, true);
InitMenu("", nullptr);
EXPECT_TRUE(
observer()->IsCommandIdChecked(IDC_CONTENT_CONTEXT_SPELLING_TOGGLE));
}
// Tests that right-clicking a misspelled word when we enable spelling-service
// integration to verify an item "Use enhanced spell check" is checked. (This
// test does not actually send JSON-RPC requests to the service because it makes
// this test flaky.)
// TODO(https://crbug.com/410751413): Deleting temporary directories using
// test_file_util is flaky on Windows.
#if BUILDFLAG(IS_WIN)
#define MAYBE_EnableSpellingService DISABLED_EnableSpellingService
#else
#define MAYBE_EnableSpellingService EnableSpellingService
#endif
IN_PROC_BROWSER_TEST_F(SpellingMenuObserverTest,
MAYBE_EnableSpellingService) {
menu()->GetPrefs()->SetBoolean(
spellcheck::prefs::kSpellCheckUseSpellingService, true);
base::Value::List dictionary;
menu()->GetPrefs()->SetList(spellcheck::prefs::kSpellCheckDictionaries,
std::move(dictionary));
// Pick word that Windows platform spellcheck has no suggestions for.
InitMenu("missssspelling", nullptr);
EXPECT_EQ(2U, menu()->GetMenuSize());
// To avoid duplicates, this test reads only the "Use enhanced spell check"
// item and verifies it is enabled and checked.
MockRenderViewContextMenu::MockMenuItem item;
menu()->GetMenuItem(1, &item);
EXPECT_EQ(IDC_CONTENT_CONTEXT_SPELLING_TOGGLE, item.command_id);
EXPECT_TRUE(item.enabled);
EXPECT_TRUE(item.checked);
EXPECT_FALSE(item.hidden);
}
// Tests that right-clicking a misspelled word when spelling-service
// integration is enabled but the browser's spell check preference is disabled
// shows the "Use enhanced spell check" as unchecked. Clicking on this item
// enables spell check on the browser.
IN_PROC_BROWSER_TEST_F(SpellingMenuObserverTest,
EnableSpellingServiceWhenSpellcheckDisabled) {
menu()->GetPrefs()->SetBoolean(spellcheck::prefs::kSpellCheckEnable, false);
menu()->GetPrefs()->SetBoolean(
spellcheck::prefs::kSpellCheckUseSpellingService, true);
MockRenderViewContextMenu::MockMenuItem item;
menu()->GetMenuItem(1, &item);
EXPECT_FALSE(item.checked);
menu()->ExecuteCommand(IDC_CONTENT_CONTEXT_SPELLING_TOGGLE, 1);
EXPECT_TRUE(
menu()->GetPrefs()->GetBoolean(spellcheck::prefs::kSpellCheckEnable));
EXPECT_TRUE(menu()->IsCommandIdChecked(IDC_CONTENT_CONTEXT_SPELLING_TOGGLE));
}
// Test that we don't show "No more suggestions from Google" if the spelling
// service is enabled and that there is only one suggestion.
IN_PROC_BROWSER_TEST_F(SpellingMenuObserverTest,
NoMoreSuggestionsNotDisplayed) {
menu()->GetPrefs()->SetBoolean(
spellcheck::prefs::kSpellCheckUseSpellingService, true);
// Force a non-empty locale so SPELLCHECK is available.
base::Value::List dictionary;
dictionary.Append("en");
menu()->GetPrefs()->SetList(spellcheck::prefs::kSpellCheckDictionaries,
std::move(dictionary));
EXPECT_TRUE(SpellingServiceClient::IsAvailable(
menu()->GetBrowserContext(), SpellingServiceClient::SPELLCHECK));
InitMenu("asdfkj", "asdf");
// The test should see a suggestion, separator, "Add to dictionary",
// "Use enhanced spell check".
// Possibly more items (not relevant here).
EXPECT_LT(3U, menu()->GetMenuSize());
MockRenderViewContextMenu::MockMenuItem item;
menu()->GetMenuItem(0, &item);
EXPECT_EQ(-1, item.command_id);
EXPECT_FALSE(item.enabled);
EXPECT_FALSE(item.hidden);
menu()->GetMenuItem(1, &item);
EXPECT_EQ(IDC_SPELLCHECK_SUGGESTION_0, item.command_id);
EXPECT_TRUE(item.enabled);
EXPECT_FALSE(item.hidden);
menu()->GetMenuItem(2, &item);
EXPECT_EQ(-1, item.command_id);
EXPECT_FALSE(item.enabled);
EXPECT_FALSE(item.hidden);
menu()->GetMenuItem(3, &item);
EXPECT_EQ(IDC_SPELLCHECK_ADD_TO_DICTIONARY, item.command_id);
EXPECT_TRUE(item.enabled);
EXPECT_FALSE(item.hidden);
menu()->GetMenuItem(4, &item);
EXPECT_EQ(IDC_CONTENT_CONTEXT_SPELLING_TOGGLE, item.command_id);
EXPECT_TRUE(item.enabled);
EXPECT_TRUE(item.checked);
EXPECT_FALSE(item.hidden);
}
// crbug.com/899935
#if BUILDFLAG(IS_WIN)
#define MAYBE_NoSpellingServiceWhenOffTheRecord \
DISABLED_NoSpellingServiceWhenOffTheRecord
#else
#define MAYBE_NoSpellingServiceWhenOffTheRecord \
NoSpellingServiceWhenOffTheRecord
#endif
// Test that "Use enhanced spell check" is grayed out when using an
// off the record profile.
// TODO(rlp): Include graying out of autocorrect in this test when autocorrect
// is functional.
IN_PROC_BROWSER_TEST_F(SpellingMenuObserverTest,
MAYBE_NoSpellingServiceWhenOffTheRecord) {
// Create a menu in an incognito profile.
Reset(true);
// This means spellchecking is allowed. Default is that the service is
// contacted but this test makes sure that if profile is incognito, that
// is not an option.
menu()->GetPrefs()->SetBoolean(
spellcheck::prefs::kSpellCheckUseSpellingService, true);
// Force a non-empty locale so SUGGEST normally would be available.
base::Value::List dictionary;
dictionary.Append("en");
menu()->GetPrefs()->SetList(spellcheck::prefs::kSpellCheckDictionaries,
std::move(dictionary));
EXPECT_FALSE(SpellingServiceClient::IsAvailable(
menu()->GetBrowserContext(), SpellingServiceClient::SUGGEST));
EXPECT_FALSE(SpellingServiceClient::IsAvailable(
menu()->GetBrowserContext(), SpellingServiceClient::SPELLCHECK));
InitMenu("sjxdjiiiiii", nullptr);
// There should not be a "No more Google suggestions" (from SpellingService)
// or a separator. The next 2 items should be "Add to Dictionary" followed
// by "Use enhanced spell check" which should be disabled.
// TODO(rlp): add autocorrect here when it is functional.
EXPECT_LT(1U, menu()->GetMenuSize());
MockRenderViewContextMenu::MockMenuItem item;
menu()->GetMenuItem(0, &item);
EXPECT_EQ(IDC_SPELLCHECK_ADD_TO_DICTIONARY, item.command_id);
EXPECT_TRUE(item.enabled);
EXPECT_FALSE(item.hidden);
menu()->GetMenuItem(1, &item);
EXPECT_EQ(IDC_CONTENT_CONTEXT_SPELLING_TOGGLE, item.command_id);
EXPECT_FALSE(item.enabled);
EXPECT_FALSE(item.hidden);
}
// crbug.com/899935
#if BUILDFLAG(IS_WIN)
#define MAYBE_SuggestionsForceTopSeparator DISABLED_SuggestionsForceTopSeparator
#else
#define MAYBE_SuggestionsForceTopSeparator SuggestionsForceTopSeparator
#endif
// Test that the menu is preceeded by a separator if there are any suggestions,
// or if the SpellingServiceClient is available
IN_PROC_BROWSER_TEST_F(SpellingMenuObserverTest,
MAYBE_SuggestionsForceTopSeparator) {
menu()->GetPrefs()->SetBoolean(
spellcheck::prefs::kSpellCheckUseSpellingService, false);
// First case: Misspelled word, no suggestions, no spellcheck service.
InitMenu("asdfkj", nullptr);
// See SpellingMenuObserverTest.InitMenuWithMisspelledWord on why 2 items.
EXPECT_EQ(2U, menu()->GetMenuSize());
MockRenderViewContextMenu::MockMenuItem item;
menu()->GetMenuItem(0, &item);
EXPECT_NE(-1, item.command_id);
// Case #2. Misspelled word, suggestions, no spellcheck service.
Reset(false);
menu()->GetPrefs()->SetBoolean(
spellcheck::prefs::kSpellCheckUseSpellingService, false);
InitMenu("asdfkj", "asdf");
// Expect at least separator and 4 default entries.
EXPECT_LT(4U, menu()->GetMenuSize());
// This test only cares that the first one is a separator.
menu()->GetMenuItem(0, &item);
EXPECT_EQ(-1, item.command_id);
// Case #3. Misspelled word, suggestion service is on.
Reset(false);
ForceSuggestMode();
InitMenu("asdfkj", nullptr);
// Should have at least 2 entries. Separator, suggestion.
EXPECT_LT(2U, menu()->GetMenuSize());
menu()->GetMenuItem(0, &item);
EXPECT_EQ(-1, item.command_id);
menu()->GetMenuItem(1, &item);
EXPECT_EQ(IDC_CONTENT_CONTEXT_SPELLING_SUGGESTION, item.command_id);
}
|