1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
|
// Copyright 2018 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/resource_coordinator/decision_details.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace resource_coordinator {
TEST(DecisionDetailsTest, DecisionDetailsReason) {
// Ensure a null constructed reason work as expected.
DecisionDetails::Reason reason;
EXPECT_FALSE(reason.IsValid());
EXPECT_FALSE(reason.IsSuccess());
EXPECT_FALSE(reason.IsFailure());
EXPECT_FALSE(reason.ToString());
// Expect that copying works.
reason = DecisionDetails::Reason(DecisionFailureReason::GLOBAL_DISALLOWLIST);
EXPECT_TRUE(reason.IsValid());
EXPECT_FALSE(reason.IsSuccess());
EXPECT_TRUE(reason.IsFailure());
EXPECT_EQ(ToString(DecisionFailureReason::GLOBAL_DISALLOWLIST),
reason.ToString());
EXPECT_EQ(DecisionFailureReason::GLOBAL_DISALLOWLIST,
reason.failure_reason());
// Ensure that the copy constructor works.
DecisionDetails::Reason reason2(reason);
EXPECT_TRUE(reason2.IsValid());
EXPECT_FALSE(reason2.IsSuccess());
EXPECT_TRUE(reason2.IsFailure());
EXPECT_EQ(ToString(DecisionFailureReason::GLOBAL_DISALLOWLIST),
reason2.ToString());
EXPECT_EQ(DecisionFailureReason::GLOBAL_DISALLOWLIST,
reason2.failure_reason());
// Also check that (in)equality operators work.
EXPECT_TRUE(reason == reason2);
EXPECT_FALSE(reason != reason2);
// Ensure failure reasons work as expected.
for (size_t i = 0; i < static_cast<size_t>(DecisionFailureReason::MAX); ++i) {
DecisionFailureReason failure_reason =
static_cast<DecisionFailureReason>(i);
reason = DecisionDetails::Reason(failure_reason);
EXPECT_TRUE(reason.IsValid());
EXPECT_FALSE(reason.IsSuccess());
EXPECT_TRUE(reason.IsFailure());
EXPECT_EQ(ToString(failure_reason), reason.ToString());
EXPECT_EQ(failure_reason, reason.failure_reason());
}
// Ensure success reasons work as expected.
for (size_t i = 0; i < static_cast<size_t>(DecisionSuccessReason::MAX); ++i) {
DecisionSuccessReason success_reason =
static_cast<DecisionSuccessReason>(i);
reason = DecisionDetails::Reason(success_reason);
EXPECT_TRUE(reason.IsValid());
EXPECT_TRUE(reason.IsSuccess());
EXPECT_FALSE(reason.IsFailure());
EXPECT_EQ(ToString(success_reason), reason.ToString());
EXPECT_EQ(success_reason, reason.success_reason());
}
}
TEST(DecisionDetailsTest, DecisionDetails) {
DecisionDetails details;
std::vector<std::string> expected_failure_strings;
expected_failure_strings.push_back(
ToString(DecisionFailureReason::GLOBAL_DISALLOWLIST));
// An empty decision is negative by default.
EXPECT_EQ(0u, details.reasons().size());
EXPECT_FALSE(details.IsPositive());
// Adding a single failure reason makes it return negative.
EXPECT_FALSE(details.AddReason(DecisionFailureReason::GLOBAL_DISALLOWLIST));
EXPECT_EQ(1u, details.reasons().size());
EXPECT_FALSE(details.IsPositive());
EXPECT_EQ(DecisionFailureReason::GLOBAL_DISALLOWLIST,
details.FailureReason());
EXPECT_EQ(DecisionDetails::Reason(DecisionFailureReason::GLOBAL_DISALLOWLIST),
details.reasons()[0]);
EXPECT_EQ(expected_failure_strings, details.GetFailureReasonStrings());
EXPECT_FALSE(details.toggled());
// Adding a second failure reason doesn't change anything, but the failure
// strings should grow.
expected_failure_strings.push_back(
ToString(DecisionFailureReason::ORIGIN_TRIAL_OPT_OUT));
EXPECT_FALSE(details.AddReason(DecisionFailureReason::ORIGIN_TRIAL_OPT_OUT));
EXPECT_EQ(2u, details.reasons().size());
EXPECT_FALSE(details.IsPositive());
EXPECT_EQ(DecisionFailureReason::GLOBAL_DISALLOWLIST,
details.FailureReason());
EXPECT_EQ(DecisionDetails::Reason(DecisionFailureReason::GLOBAL_DISALLOWLIST),
details.reasons()[0]);
EXPECT_EQ(
DecisionDetails::Reason(DecisionFailureReason::ORIGIN_TRIAL_OPT_OUT),
details.reasons()[1]);
EXPECT_EQ(expected_failure_strings, details.GetFailureReasonStrings());
EXPECT_FALSE(details.toggled());
// Adding a success reason after this should have no effect, but the decision
// chain should have toggled.
EXPECT_TRUE(details.AddReason(DecisionSuccessReason::GLOBAL_ALLOWLIST));
EXPECT_EQ(3u, details.reasons().size());
EXPECT_FALSE(details.IsPositive());
EXPECT_EQ(DecisionFailureReason::GLOBAL_DISALLOWLIST,
details.FailureReason());
EXPECT_EQ(DecisionDetails::Reason(DecisionFailureReason::GLOBAL_DISALLOWLIST),
details.reasons()[0]);
EXPECT_EQ(
DecisionDetails::Reason(DecisionFailureReason::ORIGIN_TRIAL_OPT_OUT),
details.reasons()[1]);
EXPECT_EQ(DecisionDetails::Reason(DecisionSuccessReason::GLOBAL_ALLOWLIST),
details.reasons()[2]);
EXPECT_EQ(expected_failure_strings, details.GetFailureReasonStrings());
EXPECT_TRUE(details.toggled());
// Adding yet another failure after a success should not affect the failure
// reason strings, as only failures before successes are emitted. Also, test
// the AddReason member function that accessts a Reason directly rather than
// an enum.
EXPECT_TRUE(details.AddReason(
DecisionDetails::Reason(DecisionFailureReason::HEURISTIC_AUDIO)));
EXPECT_EQ(4u, details.reasons().size());
EXPECT_FALSE(details.IsPositive());
EXPECT_EQ(DecisionFailureReason::GLOBAL_DISALLOWLIST,
details.FailureReason());
EXPECT_EQ(DecisionDetails::Reason(DecisionFailureReason::GLOBAL_DISALLOWLIST),
details.reasons()[0]);
EXPECT_EQ(
DecisionDetails::Reason(DecisionFailureReason::ORIGIN_TRIAL_OPT_OUT),
details.reasons()[1]);
EXPECT_EQ(DecisionDetails::Reason(DecisionSuccessReason::GLOBAL_ALLOWLIST),
details.reasons()[2]);
EXPECT_EQ(DecisionDetails::Reason(DecisionFailureReason::HEURISTIC_AUDIO),
details.reasons()[3]);
EXPECT_EQ(expected_failure_strings, details.GetFailureReasonStrings());
EXPECT_TRUE(details.toggled());
// Clear and go back to the initial state.
details.Clear();
EXPECT_EQ(0u, details.reasons().size());
EXPECT_FALSE(details.IsPositive());
EXPECT_FALSE(details.toggled());
// Adding a single success reason makes it return positive. There should be no
// failure reason strings.
EXPECT_FALSE(details.AddReason(DecisionSuccessReason::GLOBAL_ALLOWLIST));
EXPECT_EQ(1u, details.reasons().size());
EXPECT_TRUE(details.IsPositive());
EXPECT_EQ(DecisionSuccessReason::GLOBAL_ALLOWLIST, details.SuccessReason());
EXPECT_EQ(DecisionDetails::Reason(DecisionSuccessReason::GLOBAL_ALLOWLIST),
details.reasons()[0]);
EXPECT_TRUE(details.GetFailureReasonStrings().empty());
EXPECT_FALSE(details.toggled());
// Adding a failure reason after this should have no effect, but the toggle
// should be noted. There should still be no failure reason strings.
EXPECT_TRUE(details.AddReason(DecisionFailureReason::GLOBAL_DISALLOWLIST));
EXPECT_EQ(2u, details.reasons().size());
EXPECT_TRUE(details.IsPositive());
EXPECT_EQ(DecisionSuccessReason::GLOBAL_ALLOWLIST, details.SuccessReason());
EXPECT_EQ(DecisionDetails::Reason(DecisionSuccessReason::GLOBAL_ALLOWLIST),
details.reasons()[0]);
EXPECT_EQ(DecisionDetails::Reason(DecisionFailureReason::GLOBAL_DISALLOWLIST),
details.reasons()[1]);
EXPECT_TRUE(details.GetFailureReasonStrings().empty());
EXPECT_TRUE(details.toggled());
}
} // namespace resource_coordinator
|
