1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
|
// Copyright 2013 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/safe_browsing/download_protection/download_feedback.h"
#include <memory>
#include <utility>
#include "base/files/file_util.h"
#include "base/files/scoped_temp_dir.h"
#include "base/functional/bind.h"
#include "base/memory/ptr_util.h"
#include "base/memory/raw_ptr.h"
#include "base/run_loop.h"
#include "base/task/sequenced_task_runner.h"
#include "base/task/single_thread_task_runner.h"
#include "base/task/thread_pool.h"
#include "chrome/browser/safe_browsing/cloud_content_scanning/multipart_uploader.h"
#include "components/safe_browsing/core/common/proto/csd.pb.h"
#include "content/public/browser/browser_task_traits.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/test/browser_task_environment.h"
#include "content/public/test/test_utils.h"
#include "net/http/http_status_code.h"
#include "net/traffic_annotation/network_traffic_annotation_test_helper.h"
#include "services/network/test/test_shared_url_loader_factory.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace safe_browsing {
namespace {
class FakeUploader : public MultipartUploadRequest {
public:
FakeUploader(const GURL& base_url,
const std::string& metadata,
const base::FilePath& file_path,
uint64_t file_size,
Callback finish_callback,
const std::string& histogram_suffix,
const net::NetworkTrafficAnnotationTag& traffic_annotation);
~FakeUploader() override = default;
void Start() override { start_called_ = true; }
GURL base_url_;
std::string metadata_;
base::FilePath file_path_;
Callback finish_callback_;
bool start_called_;
};
FakeUploader::FakeUploader(
const GURL& base_url,
const std::string& metadata,
const base::FilePath& file_path,
uint64_t file_size,
Callback finish_callback,
const std::string& histogram_suffix,
const net::NetworkTrafficAnnotationTag& traffic_annotation)
: MultipartUploadRequest(/*url_loader_factory=*/nullptr,
base_url,
metadata,
file_path,
file_size,
false,
histogram_suffix,
traffic_annotation,
base::DoNothing()),
base_url_(base_url),
metadata_(metadata),
file_path_(file_path),
finish_callback_(std::move(finish_callback)),
start_called_(false) {}
class FakeUploaderFactory : public ConnectorUploadRequestFactory {
public:
std::unique_ptr<ConnectorUploadRequest> CreateStringRequest(
scoped_refptr<network::SharedURLLoaderFactory> url_loader_factory,
const GURL& base_url,
const std::string& metadata,
const std::string& data,
const std::string& histogram_suffix,
const net::NetworkTrafficAnnotationTag& traffic_annotation,
ConnectorUploadRequest::Callback callback) override;
std::unique_ptr<ConnectorUploadRequest> CreateFileRequest(
scoped_refptr<network::SharedURLLoaderFactory> url_loader_factory,
const GURL& base_url,
const std::string& metadata,
BinaryUploadService::Result get_data_result,
const base::FilePath& file_path,
uint64_t file_size,
bool is_obfuscated,
const std::string& histogram_suffix,
const net::NetworkTrafficAnnotationTag& traffic_annotation,
ConnectorUploadRequest::Callback callback) override;
std::unique_ptr<ConnectorUploadRequest> CreatePageRequest(
scoped_refptr<network::SharedURLLoaderFactory> url_loader_factory,
const GURL& base_url,
const std::string& metadata,
BinaryUploadService::Result get_data_result,
base::ReadOnlySharedMemoryRegion page_region,
const std::string& histogram_suffix,
const net::NetworkTrafficAnnotationTag& traffic_annotation,
ConnectorUploadRequest::Callback callback) override;
raw_ptr<FakeUploader, DanglingUntriaged> uploader_ = nullptr;
};
std::unique_ptr<ConnectorUploadRequest>
FakeUploaderFactory::CreateStringRequest(
scoped_refptr<network::SharedURLLoaderFactory> url_loader_factory,
const GURL& base_url,
const std::string& metadata,
const std::string& data,
const std::string& histogram_suffix,
const net::NetworkTrafficAnnotationTag& traffic_annotation,
ConnectorUploadRequest::Callback callback) {
NOTREACHED();
}
std::unique_ptr<ConnectorUploadRequest> FakeUploaderFactory::CreateFileRequest(
scoped_refptr<network::SharedURLLoaderFactory> url_loader_factory,
const GURL& base_url,
const std::string& metadata,
BinaryUploadService::Result get_data_result,
const base::FilePath& file_path,
uint64_t file_size,
bool is_obfuscated,
const std::string& histogram_suffix,
const net::NetworkTrafficAnnotationTag& traffic_annotation,
ConnectorUploadRequest::Callback callback) {
EXPECT_FALSE(uploader_);
auto uploader = std::make_unique<FakeUploader>(
base_url, metadata, file_path, file_size, std::move(callback),
histogram_suffix, traffic_annotation);
uploader_ = uploader.get();
return uploader;
}
std::unique_ptr<ConnectorUploadRequest> FakeUploaderFactory::CreatePageRequest(
scoped_refptr<network::SharedURLLoaderFactory> url_loader_factory,
const GURL& base_url,
const std::string& metadata,
BinaryUploadService::Result get_data_result,
base::ReadOnlySharedMemoryRegion page_region,
const std::string& histogram_suffix,
const net::NetworkTrafficAnnotationTag& traffic_annotation,
ConnectorUploadRequest::Callback callback) {
NOTREACHED();
}
} // namespace
class DownloadFeedbackTest : public testing::Test {
public:
DownloadFeedbackTest()
: file_task_runner_(base::ThreadPool::CreateSequencedTaskRunner(
{base::MayBlock(), base::TaskPriority::BEST_EFFORT})),
io_task_runner_(content::GetIOThreadTaskRunner({})),
feedback_finish_called_(false) {
EXPECT_NE(io_task_runner_, file_task_runner_);
shared_url_loader_factory_ =
base::MakeRefCounted<network::TestSharedURLLoaderFactory>();
}
void SetUp() override {
ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
upload_file_path_ = temp_dir_.GetPath().AppendASCII("test file");
upload_file_data_ = "data";
ASSERT_TRUE(base::WriteFile(upload_file_path_, upload_file_data_));
ConnectorUploadRequest::RegisterFactoryForTests(&uploader_factory_);
}
void TearDown() override {
ConnectorUploadRequest::RegisterFactoryForTests(nullptr);
}
FakeUploader* uploader() const { return uploader_factory_.uploader_; }
void FinishCallback() {
EXPECT_FALSE(feedback_finish_called_);
feedback_finish_called_ = true;
}
protected:
base::ScopedTempDir temp_dir_;
base::FilePath upload_file_path_;
std::string upload_file_data_;
content::BrowserTaskEnvironment task_environment_;
scoped_refptr<base::SequencedTaskRunner> file_task_runner_;
scoped_refptr<base::SingleThreadTaskRunner> io_task_runner_;
FakeUploaderFactory uploader_factory_;
scoped_refptr<network::TestSharedURLLoaderFactory> shared_url_loader_factory_;
bool feedback_finish_called_;
};
TEST_F(DownloadFeedbackTest, CompleteUpload) {
ClientDownloadReport expected_report_metadata;
auto* request = expected_report_metadata.mutable_download_request();
request->set_url("http://test");
request->set_length(upload_file_data_.size());
request->mutable_digests()->set_sha1("hi");
expected_report_metadata.mutable_download_response()->set_verdict(
ClientDownloadResponse::DANGEROUS_HOST);
std::string ping_request(
expected_report_metadata.download_request().SerializeAsString());
std::string ping_response(
expected_report_metadata.download_response().SerializeAsString());
std::unique_ptr<DownloadFeedback> feedback = DownloadFeedback::Create(
shared_url_loader_factory_, upload_file_path_, upload_file_data_.size(),
ping_request, ping_response);
EXPECT_FALSE(uploader());
feedback->Start(base::BindOnce(&DownloadFeedbackTest::FinishCallback,
base::Unretained(this)));
ASSERT_TRUE(uploader());
EXPECT_FALSE(feedback_finish_called_);
EXPECT_TRUE(uploader()->start_called_);
EXPECT_EQ(upload_file_path_, uploader()->file_path_);
EXPECT_EQ(expected_report_metadata.SerializeAsString(),
uploader()->metadata_);
EXPECT_EQ(DownloadFeedback::kSbFeedbackURL, uploader()->base_url_.spec());
EXPECT_TRUE(base::PathExists(upload_file_path_));
EXPECT_FALSE(feedback_finish_called_);
std::move(uploader()->finish_callback_)
.Run(/*success=*/true, net::HTTP_OK, "");
EXPECT_TRUE(feedback_finish_called_);
feedback.reset();
content::RunAllTasksUntilIdle();
EXPECT_FALSE(base::PathExists(upload_file_path_));
}
TEST_F(DownloadFeedbackTest, CancelUpload) {
ClientDownloadReport expected_report_metadata;
auto* request = expected_report_metadata.mutable_download_request();
request->set_url("http://test");
request->set_length(upload_file_data_.size());
request->mutable_digests()->set_sha1("hi");
expected_report_metadata.mutable_download_response()->set_verdict(
ClientDownloadResponse::DANGEROUS_HOST);
std::string ping_request(
expected_report_metadata.download_request().SerializeAsString());
std::string ping_response(
expected_report_metadata.download_response().SerializeAsString());
std::unique_ptr<DownloadFeedback> feedback = DownloadFeedback::Create(
shared_url_loader_factory_, upload_file_path_, upload_file_data_.size(),
ping_request, ping_response);
EXPECT_FALSE(uploader());
feedback->Start(base::BindOnce(&DownloadFeedbackTest::FinishCallback,
base::Unretained(this)));
ASSERT_TRUE(uploader());
EXPECT_FALSE(feedback_finish_called_);
EXPECT_TRUE(uploader()->start_called_);
EXPECT_TRUE(base::PathExists(upload_file_path_));
feedback.reset();
EXPECT_FALSE(feedback_finish_called_);
content::RunAllTasksUntilIdle();
EXPECT_FALSE(base::PathExists(upload_file_path_));
}
} // namespace safe_browsing
|
