1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
|
// Copyright 2013 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/search/search.h"
#include <stddef.h>
#include <array>
#include <map>
#include <string>
#include <utility>
#include "base/functional/bind.h"
#include "base/strings/utf_string_conversions.h"
#include "build/build_config.h"
#include "chrome/browser/search/instant_service.h"
#include "chrome/browser/search/instant_service_factory.h"
#include "chrome/browser/search_engines/template_url_service_factory.h"
#include "chrome/browser/signin/chrome_signin_client_factory.h"
#include "chrome/browser/signin/chrome_signin_client_test_util.h"
#include "chrome/browser/supervised_user/supervised_user_test_util.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/common/url_constants.h"
#include "chrome/test/base/browser_with_test_window_test.h"
#include "chrome/test/base/search_test_utils.h"
#include "chrome/test/base/testing_profile.h"
#include "components/search_engines/template_url_service.h"
#include "components/supervised_user/core/common/buildflags.h"
#include "content/public/browser/navigation_entry.h"
#include "content/public/browser/render_frame_host.h"
#include "content/public/browser/render_process_host.h"
#include "content/public/browser/render_view_host.h"
#include "content/public/browser/site_instance.h"
#include "content/public/browser/web_contents.h"
#include "content/public/test/navigation_simulator.h"
#include "content/public/test/test_utils.h"
#include "url/gurl.h"
namespace search {
bool MatchesOriginAndPath(const GURL& my_url, const GURL& other_url);
TEST(SearchURLsTest, MatchesOriginAndPath) {
EXPECT_TRUE(MatchesOriginAndPath(GURL("http://example.com/path"),
GURL("http://example.com/path?param")));
EXPECT_FALSE(MatchesOriginAndPath(GURL("http://not.example.com/path"),
GURL("http://example.com/path")));
EXPECT_TRUE(MatchesOriginAndPath(GURL("http://example.com:80/path"),
GURL("http://example.com/path")));
EXPECT_FALSE(MatchesOriginAndPath(GURL("http://example.com:8080/path"),
GURL("http://example.com/path")));
EXPECT_FALSE(MatchesOriginAndPath(GURL("ftp://example.com/path"),
GURL("http://example.com/path")));
EXPECT_FALSE(MatchesOriginAndPath(GURL("http://example.com/path"),
GURL("https://example.com/path")));
EXPECT_FALSE(MatchesOriginAndPath(GURL("https://example.com/path"),
GURL("http://example.com/path")));
EXPECT_FALSE(MatchesOriginAndPath(GURL("http://example.com/path"),
GURL("http://example.com/another-path")));
}
class SearchTest : public BrowserWithTestWindowTest {
protected:
void SetUp() override {
BrowserWithTestWindowTest::SetUp();
TemplateURLServiceFactory::GetInstance()->SetTestingFactoryAndUse(
profile(),
base::BindRepeating(&TemplateURLServiceFactory::BuildInstanceFor));
TemplateURLService* template_url_service =
TemplateURLServiceFactory::GetForProfile(profile());
search_test_utils::WaitForTemplateURLServiceToLoad(template_url_service);
SetSearchProvider(true, false);
}
virtual void SetSearchProvider(bool set_ntp_url, bool insecure_ntp_url) {
TemplateURLService* template_url_service =
TemplateURLServiceFactory::GetForProfile(profile());
TemplateURLData data;
data.SetShortName(u"foo.com");
data.SetURL("http://foo.com/url?bar={searchTerms}");
if (set_ntp_url) {
data.new_tab_url = (insecure_ntp_url ? "http" : "https") +
std::string("://foo.com/newtab");
}
data.alternate_urls.push_back("http://foo.com/alt#quux={searchTerms}");
TemplateURL* template_url =
template_url_service->Add(std::make_unique<TemplateURL>(data));
template_url_service->SetUserSelectedDefaultSearchProvider(template_url);
}
bool InInstantProcess(content::WebContents* contents) {
InstantService* instant_service =
InstantServiceFactory::GetForProfile(profile());
return instant_service->IsInstantProcess(
contents->GetPrimaryMainFrame()->GetProcess()->GetDeprecatedID());
}
// Each test case represents a navigation to |start_url| followed by a
// navigation to |end_url|. We will check whether each navigation lands in an
// Instant process, and also whether the navigation from start to end re-uses
// the same SiteInstance, RenderViewHost, etc.
// Note that we need to define this here because the flags needed to check
// content::CanSameSiteMainFrameNavigationsChangeSiteInstances() etc might not
// be set yet if we define this immediately (e.g. outside of the test class).
struct ProcessIsolationTestCase {
const char* description;
const char* start_url;
bool start_in_instant_process;
const char* end_url;
bool end_in_instant_process;
bool same_site_instance;
bool same_rvh;
bool same_process;
};
const std::array<ProcessIsolationTestCase, 5> kProcessIsolationTestCases = {{
{"Remote NTP -> SRP", "https://foo.com/newtab", true,
"https://foo.com/url", false, false, false, false},
{"Remote NTP -> Regular", "https://foo.com/newtab", true,
"https://foo.com/other", false, false, false, false},
{"SRP -> SRP", "https://foo.com/url", false, "https://foo.com/url", false,
true,
!content::WillSameSiteNavigationChangeRenderFrameHosts(
/*is_main_frame=*/true),
true},
{"SRP -> Regular", "https://foo.com/url", false, "https://foo.com/other",
false, !content::CanSameSiteMainFrameNavigationsChangeSiteInstances(),
!content::CanSameSiteMainFrameNavigationsChangeSiteInstances(), true},
{"Regular -> SRP", "https://foo.com/other", false, "https://foo.com/url",
false, !content::CanSameSiteMainFrameNavigationsChangeSiteInstances(),
!content::CanSameSiteMainFrameNavigationsChangeSiteInstances(), true},
}};
// BrowserWithTestWindowTest:
TestingProfile::TestingFactories GetTestingFactories() override {
return {TestingProfile::TestingFactory{
ChromeSigninClientFactory::GetInstance(),
base::BindRepeating(&BuildChromeSigninClientWithURLLoader,
test_url_loader_factory())}};
}
};
struct SearchTestCase {
const char* url;
bool expected_result;
const char* comment;
};
TEST_F(SearchTest, ShouldAssignURLToInstantRenderer) {
// Only remote NTPs and most-visited tiles embedded in remote NTPs should be
// assigned to Instant renderers.
const auto kTestCases = std::to_array<SearchTestCase>({
{"chrome-search://most-visited/title.html?bar=abc", true,
"Most-visited tile"},
{"https://foo.com/newtab", true, "Remote NTP"},
{"https://foo.com/instant", false, "Instant support was removed"},
{"https://foo.com/url", false, "Instant support was removed"},
{"https://foo.com/alt", false, "Instant support was removed"},
{"http://foo.com/instant", false, "Instant support was removed"},
{"https://foo.com/instant", false, "Instant support was removed"},
{"https://foo.com/", false, "Instant support was removed"},
});
for (size_t i = 0; i < std::size(kTestCases); ++i) {
const SearchTestCase& test = kTestCases[i];
EXPECT_EQ(test.expected_result,
ShouldAssignURLToInstantRenderer(GURL(test.url), profile()))
<< test.url << " " << test.comment;
}
}
TEST_F(SearchTest, ShouldUseProcessPerSiteForInstantSiteURL) {
const auto kTestCases = std::to_array<SearchTestCase>({
{"chrome-search://remote-ntp", true, "Remote NTP"},
{"invalid-scheme://online-ntp", false, "Invalid Online NTP URL"},
{"chrome-search://foo.com", false, "Search result page"},
{"https://foo.com/instant", false, ""},
{"https://foo.com/url", false, ""},
{"https://foo.com/alt", false, ""},
{"https://foo.com:80/instant", false, "HTTPS with port"},
{"http://foo.com/instant", false, "Non-HTTPS"},
{"http://foo.com:443/instant", false, "Non-HTTPS"},
{"https://foo.com/instant", false, "No search terms replacement"},
{"https://foo.com/", false, "Non-exact path"},
});
for (size_t i = 0; i < std::size(kTestCases); ++i) {
const SearchTestCase& test = kTestCases[i];
EXPECT_EQ(test.expected_result, ShouldUseProcessPerSiteForInstantSiteURL(
GURL(test.url), profile()))
<< test.url << " " << test.comment;
}
}
TEST_F(SearchTest, ProcessIsolation) {
for (size_t i = 0; i < std::size(kProcessIsolationTestCases); ++i) {
const ProcessIsolationTestCase& test = kProcessIsolationTestCases[i];
AddTab(browser(), GURL("chrome://blank"));
content::WebContents* contents =
browser()->tab_strip_model()->GetActiveWebContents();
// Navigate to start URL.
NavigateAndCommitActiveTab(GURL(test.start_url));
EXPECT_EQ(test.start_in_instant_process, InInstantProcess(contents))
<< test.description;
// Save state.
const scoped_refptr<content::SiteInstance> start_site_instance =
contents->GetSiteInstance();
const content::RenderProcessHost* start_rph =
contents->GetPrimaryMainFrame()->GetProcess();
const content::RenderViewHost* start_rvh =
contents->GetPrimaryMainFrame()->GetRenderViewHost();
// Navigate to end URL.
NavigateAndCommitActiveTab(GURL(test.end_url));
EXPECT_EQ(test.end_in_instant_process, InInstantProcess(contents))
<< test.description;
EXPECT_EQ(test.same_site_instance,
start_site_instance.get() == contents->GetSiteInstance())
<< test.description;
EXPECT_EQ(test.same_rvh,
start_rvh == contents->GetPrimaryMainFrame()->GetRenderViewHost())
<< test.description;
EXPECT_EQ(test.same_process,
start_rph == contents->GetPrimaryMainFrame()->GetProcess())
<< test.description;
}
}
TEST_F(SearchTest, ProcessIsolation_RendererInitiated) {
for (size_t i = 0; i < std::size(kProcessIsolationTestCases); ++i) {
const ProcessIsolationTestCase& test = kProcessIsolationTestCases[i];
AddTab(browser(), GURL("chrome://blank"));
content::WebContents* contents =
browser()->tab_strip_model()->GetActiveWebContents();
// Navigate to start URL.
NavigateAndCommitActiveTab(GURL(test.start_url));
EXPECT_EQ(test.start_in_instant_process, InInstantProcess(contents))
<< test.description;
// Save state.
const scoped_refptr<content::SiteInstance> start_site_instance =
contents->GetSiteInstance();
const content::RenderProcessHost* start_rph =
contents->GetPrimaryMainFrame()->GetProcess();
const content::RenderViewHost* start_rvh =
contents->GetPrimaryMainFrame()->GetRenderViewHost();
// Navigate to end URL via a renderer-initiated navigation.
content::NavigationSimulator::NavigateAndCommitFromDocument(
GURL(test.end_url), contents->GetPrimaryMainFrame());
EXPECT_EQ(test.end_in_instant_process, InInstantProcess(contents))
<< test.description;
EXPECT_EQ(test.same_site_instance,
start_site_instance.get() == contents->GetSiteInstance())
<< test.description;
EXPECT_EQ(test.same_rvh,
start_rvh == contents->GetPrimaryMainFrame()->GetRenderViewHost())
<< test.description;
EXPECT_EQ(test.same_process,
start_rph == contents->GetPrimaryMainFrame()->GetProcess())
<< test.description;
}
}
const SearchTestCase kInstantNTPTestCases[] = {
{"https://foo.com/instant", false, "Instant support was removed"},
{"https://foo.com/url", false, "Valid search URL"},
{"https://foo.com/alt", false, "Valid alternative URL"},
{"https://foo.com/url?bar=", false, "No query terms"},
{"https://foo.com/url?bar=abc", false, "Has query terms"},
{"http://foo.com/instant", false, "Insecure URL"},
{"https://foo.com/instant", false, "No search term replacement"},
{"chrome://blank/", false, "Chrome scheme"},
{"chrome-search://foo", false, "Chrome-search scheme"},
{"https://bar.com/instant", false, "Random non-search page"},
{"https://foo.com/newtab", true, "New tab URL"},
{"http://foo.com/newtab", false, "Insecure New tab URL"},
};
TEST_F(SearchTest, InstantNTPExtendedEnabled) {
AddTab(browser(), GURL("chrome://blank"));
for (const SearchTestCase& test : kInstantNTPTestCases) {
NavigateAndCommitActiveTab(GURL(test.url));
content::WebContents* contents =
browser()->tab_strip_model()->GetWebContentsAt(0);
EXPECT_EQ(test.expected_result, IsInstantNTP(contents))
<< test.url << " " << test.comment;
}
}
TEST_F(SearchTest, InstantCacheableNTPNavigationEntry) {
AddTab(browser(), GURL("chrome://blank"));
content::WebContents* contents =
browser()->tab_strip_model()->GetWebContentsAt(0);
content::NavigationController& controller = contents->GetController();
// Local NTP.
NavigateAndCommitActiveTab(GURL(chrome::kChromeUINewTabPageURL));
EXPECT_FALSE(
NavEntryIsInstantNTP(contents, controller.GetLastCommittedEntry()));
// Remote NTP.
NavigateAndCommitActiveTab(GetNewTabPageURL(profile()));
EXPECT_TRUE(NavEntryIsInstantNTP(contents,
controller.GetLastCommittedEntry()));
}
TEST_F(SearchTest, InstantCacheableNTPNavigationEntryNewProfile) {
SetSearchProvider(false, false);
AddTab(browser(), GURL(chrome::kChromeUINewTabURL));
content::WebContents* contents =
browser()->tab_strip_model()->GetWebContentsAt(0);
content::NavigationController& controller = contents->GetController();
// Test virtual url chrome://newtab for first NTP of a new profile
EXPECT_TRUE(
MatchesOriginAndPath(GURL(chrome::kChromeUINewTabPageThirdPartyURL),
controller.GetLastCommittedEntry()->GetURL()));
// The new_tab_url gets set after the first NTP is visible.
SetSearchProvider(true, false);
EXPECT_TRUE(
MatchesOriginAndPath(GURL(chrome::kChromeUINewTabPageThirdPartyURL),
controller.GetLastCommittedEntry()->GetURL()));
}
TEST_F(SearchTest, NoRewriteInIncognito) {
TestingProfile* incognito =
TestingProfile::Builder().BuildIncognito(profile());
EXPECT_EQ(GURL(), GetNewTabPageURL(incognito));
GURL new_tab_url(chrome::kChromeUINewTabURL);
EXPECT_FALSE(HandleNewTabURLRewrite(&new_tab_url, incognito));
EXPECT_EQ(GURL(chrome::kChromeUINewTabURL), new_tab_url);
}
TEST_F(SearchTest, UseLocalNTPIfNTPURLIsInsecure) {
// Set an insecure new tab page URL and verify that it's ignored.
SetSearchProvider(true, true);
EXPECT_EQ(chrome::kChromeUINewTabPageThirdPartyURL,
GetNewTabPageURL(profile()));
GURL new_tab_url(chrome::kChromeUINewTabURL);
EXPECT_TRUE(HandleNewTabURLRewrite(&new_tab_url, profile()));
EXPECT_EQ(chrome::kChromeUINewTabPageThirdPartyURL, new_tab_url);
}
TEST_F(SearchTest, UseLocalNTPIfNTPURLIsNotSet) {
// Set an insecure new tab page URL and verify that it's ignored.
SetSearchProvider(false, true);
EXPECT_EQ(chrome::kChromeUINewTabPageThirdPartyURL,
GetNewTabPageURL(profile()));
GURL new_tab_url(chrome::kChromeUINewTabURL);
EXPECT_TRUE(HandleNewTabURLRewrite(&new_tab_url, profile()));
EXPECT_EQ(chrome::kChromeUINewTabPageThirdPartyURL, new_tab_url);
}
TEST_F(SearchTest, UseLocalNTPIfNTPURLIsBlockedForSupervisedUser) {
// Enable supervision, otherwise the URL filter won't be checked.
profile()->SetIsSupervisedProfile();
// Block access to foo.com in the URL filter.
supervised_user_test_util::SetManualFilterForHost(profile(), "foo.com",
/*allowlist=*/false);
EXPECT_EQ(chrome::kChromeUINewTabPageThirdPartyURL,
GetNewTabPageURL(profile()));
GURL new_tab_url(chrome::kChromeUINewTabURL);
EXPECT_TRUE(HandleNewTabURLRewrite(&new_tab_url, profile()));
EXPECT_EQ(chrome::kChromeUINewTabPageThirdPartyURL, new_tab_url);
}
TEST_F(SearchTest, IsNTPOrRelatedURL) {
GURL invalid_url;
GURL ntp_url(chrome::kChromeUINewTabURL);
EXPECT_FALSE(IsNTPOrRelatedURL(invalid_url, profile()));
GURL remote_ntp_url(GetNewTabPageURL(profile()));
GURL remote_ntp_service_worker_url("https://foo.com/newtab-serviceworker.js");
GURL search_url_with_search_terms("https://foo.com/url?bar=abc");
GURL search_url_without_search_terms("https://foo.com/url?bar");
EXPECT_FALSE(IsNTPOrRelatedURL(ntp_url, profile()));
EXPECT_TRUE(IsNTPOrRelatedURL(remote_ntp_url, profile()));
EXPECT_TRUE(IsNTPOrRelatedURL(remote_ntp_service_worker_url, profile()));
EXPECT_FALSE(IsNTPOrRelatedURL(search_url_with_search_terms, profile()));
EXPECT_FALSE(IsNTPOrRelatedURL(search_url_without_search_terms, profile()));
EXPECT_FALSE(IsNTPOrRelatedURL(ntp_url, nullptr));
EXPECT_FALSE(IsNTPOrRelatedURL(remote_ntp_url, nullptr));
EXPECT_FALSE(IsNTPOrRelatedURL(remote_ntp_service_worker_url, nullptr));
EXPECT_FALSE(IsNTPOrRelatedURL(search_url_with_search_terms, nullptr));
EXPECT_FALSE(IsNTPOrRelatedURL(search_url_without_search_terms, nullptr));
}
// Tests whether a |url| corresponds to a New Tab page.
// See search::IsNTPURL(const GURL& url);
TEST_F(SearchTest, IsNTPURL) {
const auto kTestCases = std::to_array<SearchTestCase>({
{"chrome-search://remote-ntp", true, "Remote NTP URL"},
{"chrome://new-tab-page", true, "WebUI NTP"},
{"chrome://new-tab-page/path?params", true,
"WebUI NTP with path and params"},
{"invalid-scheme://remote-ntp", false, "Invalid Remote NTP URL"},
{"chrome-search://most-visited/", false, "Most visited URL"},
{"", false, "Invalid URL"},
});
for (size_t i = 0; i < std::size(kTestCases); ++i) {
const SearchTestCase& test = kTestCases[i];
EXPECT_EQ(test.expected_result, IsNTPURL(GURL(test.url)))
<< test.url << " " << test.comment;
}
}
// Regression test for https://crbug.com/605720: Set up a search provider backed
// by localhost on a specific port, like browsertests do. The chrome-search://
// URLs generated in this mode should not have ports.
TEST_F(SearchTest, SearchProviderWithPort) {
TemplateURLService* template_url_service =
TemplateURLServiceFactory::GetForProfile(profile());
TemplateURLData data;
data.SetShortName(u"localhost");
data.SetURL("https://[::1]:1993/url?bar={searchTerms}");
data.new_tab_url = "https://[::1]:1993/newtab";
data.alternate_urls.push_back("https://[::1]:1993/alt#quux={searchTerms}");
TemplateURL* template_url =
template_url_service->Add(std::make_unique<TemplateURL>(data));
template_url_service->SetUserSelectedDefaultSearchProvider(template_url);
EXPECT_TRUE(ShouldAssignURLToInstantRenderer(
GURL("https://[::1]:1993/newtab?lala"), profile()));
EXPECT_FALSE(ShouldAssignURLToInstantRenderer(
GURL("https://[::1]:1992/newtab?lala"), profile()));
EXPECT_EQ(GURL("chrome-search://remote-ntp/newtab?lala"),
GetEffectiveURLForInstant(GURL("https://[::1]:1993/newtab?lala"),
profile()));
EXPECT_FALSE(ShouldAssignURLToInstantRenderer(
GURL("https://[::1]:1993/unregistered-path"), profile()));
}
} // namespace search
|
