1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
|
// Copyright 2021 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/serial/serial_blocklist.h"
#include <string_view>
#include "base/test/scoped_feature_list.h"
#include "services/device/public/mojom/serial.mojom.h"
#include "testing/gtest/include/gtest/gtest.h"
class SerialBlocklistTest : public testing::Test {
public:
void SetDynamicBlocklist(std::string_view value) {
feature_list_.Reset();
std::map<std::string, std::string> parameters;
parameters[kWebSerialBlocklistAdditions.name] = std::string(value);
feature_list_.InitWithFeaturesAndParameters(
{{kWebSerialBlocklist, parameters}}, {});
SerialBlocklist::Get().ResetToDefaultValuesForTesting();
}
device::mojom::SerialPortInfoPtr CreateUsbPortInfo(uint16_t usb_vendor_id,
uint16_t usb_product_id) {
auto info = device::mojom::SerialPortInfo::New();
info->has_vendor_id = true;
info->vendor_id = usb_vendor_id;
info->has_product_id = true;
info->product_id = usb_product_id;
return info;
}
device::mojom::SerialPortInfoPtr CreateBluetoothPortInfo(
std::string bluetooth_service_class_id) {
auto info = device::mojom::SerialPortInfo::New();
info->has_vendor_id = false;
info->has_product_id = false;
info->bluetooth_service_class_id =
device::BluetoothUUID(bluetooth_service_class_id);
return info;
}
private:
void TearDown() override {
// Because SerialBlocklist is a singleton it must be cleared after tests run
// to prevent leakage between tests.
feature_list_.Reset();
SerialBlocklist::Get().ResetToDefaultValuesForTesting();
}
base::test::ScopedFeatureList feature_list_;
};
TEST_F(SerialBlocklistTest, BasicExclusions) {
SetDynamicBlocklist(
"usb:18D1:58F0,bluetooth:12345678-9ABC-DEF0-1234-56789ABCDEF0");
EXPECT_TRUE(
SerialBlocklist::Get().IsExcluded(*CreateUsbPortInfo(0x18D1, 0x58F0)));
EXPECT_TRUE(SerialBlocklist::Get().IsExcluded(
*CreateBluetoothPortInfo("12345678-9ABC-DEF0-1234-56789ABCDEF0")));
// Devices with nearby vendor and product IDs are not blocked.
EXPECT_FALSE(
SerialBlocklist::Get().IsExcluded(*CreateUsbPortInfo(0x18D1, 0x58F1)));
EXPECT_FALSE(
SerialBlocklist::Get().IsExcluded(*CreateUsbPortInfo(0x18D1, 0x58EF)));
EXPECT_FALSE(
SerialBlocklist::Get().IsExcluded(*CreateUsbPortInfo(0x18D0, 0x58F0)));
EXPECT_FALSE(
SerialBlocklist::Get().IsExcluded(*CreateUsbPortInfo(0x18D2, 0x58F0)));
EXPECT_FALSE(SerialBlocklist::Get().IsExcluded(
*CreateBluetoothPortInfo("22345678-9ABC-DEF0-1234-56789ABCDEF0")));
}
TEST_F(SerialBlocklistTest, StringsWithNoValidEntries) {
SetDynamicBlocklist("");
EXPECT_EQ(0u, SerialBlocklist::Get().GetDynamicEntryCountForTesting());
SetDynamicBlocklist("~!@#$%^&*()-_=+[]{}/*-");
EXPECT_EQ(0u, SerialBlocklist::Get().GetDynamicEntryCountForTesting());
SetDynamicBlocklist(":");
EXPECT_EQ(0u, SerialBlocklist::Get().GetDynamicEntryCountForTesting());
SetDynamicBlocklist("::");
EXPECT_EQ(0u, SerialBlocklist::Get().GetDynamicEntryCountForTesting());
SetDynamicBlocklist(",");
EXPECT_EQ(0u, SerialBlocklist::Get().GetDynamicEntryCountForTesting());
SetDynamicBlocklist(",,");
EXPECT_EQ(0u, SerialBlocklist::Get().GetDynamicEntryCountForTesting());
SetDynamicBlocklist(",::,");
EXPECT_EQ(0u, SerialBlocklist::Get().GetDynamicEntryCountForTesting());
SetDynamicBlocklist("usb:2:3");
EXPECT_EQ(0u, SerialBlocklist::Get().GetDynamicEntryCountForTesting());
SetDynamicBlocklist("usb:18D1:2");
EXPECT_EQ(0u, SerialBlocklist::Get().GetDynamicEntryCountForTesting());
SetDynamicBlocklist("usb:0000:0x00");
EXPECT_EQ(0u, SerialBlocklist::Get().GetDynamicEntryCountForTesting());
SetDynamicBlocklist("usb:0000: 0");
EXPECT_EQ(0u, SerialBlocklist::Get().GetDynamicEntryCountForTesting());
SetDynamicBlocklist("usb:000g:0000");
EXPECT_EQ(0u, SerialBlocklist::Get().GetDynamicEntryCountForTesting());
SetDynamicBlocklist("bluetooth:0000:0000");
EXPECT_EQ(0u, SerialBlocklist::Get().GetDynamicEntryCountForTesting());
SetDynamicBlocklist("☯");
EXPECT_EQ(0u, SerialBlocklist::Get().GetDynamicEntryCountForTesting());
}
TEST_F(SerialBlocklistTest, StringsWithOneValidEntry) {
SetDynamicBlocklist("usb:18D1:58F0");
EXPECT_EQ(1u, SerialBlocklist::Get().GetDynamicEntryCountForTesting());
EXPECT_TRUE(
SerialBlocklist::Get().IsExcluded(*CreateUsbPortInfo(0x18D1, 0x58F0)));
SetDynamicBlocklist(" usb:18D1:58F0 ");
EXPECT_EQ(1u, SerialBlocklist::Get().GetDynamicEntryCountForTesting());
EXPECT_TRUE(
SerialBlocklist::Get().IsExcluded(*CreateUsbPortInfo(0x18D1, 0x58F0)));
SetDynamicBlocklist(", usb:18D1:58F0, ");
EXPECT_EQ(1u, SerialBlocklist::Get().GetDynamicEntryCountForTesting());
EXPECT_TRUE(
SerialBlocklist::Get().IsExcluded(*CreateUsbPortInfo(0x18D1, 0x58F0)));
SetDynamicBlocklist("usb:18D1:58F0, bluetooth:18D1:58F1");
EXPECT_EQ(1u, SerialBlocklist::Get().GetDynamicEntryCountForTesting());
EXPECT_TRUE(
SerialBlocklist::Get().IsExcluded(*CreateUsbPortInfo(0x18D1, 0x58F0)));
}
TEST_F(SerialBlocklistTest, StaticEntries) {
EXPECT_TRUE(
SerialBlocklist::Get().IsExcluded(*CreateUsbPortInfo(0x18D1, 0x58F3)));
// Serial Port Profile is allowed.
EXPECT_FALSE(SerialBlocklist::Get().IsExcluded(
*CreateBluetoothPortInfo("00001101-0000-1000-8000-00805f9b34fb")));
// All other Bluetooth service using a standard Bluetooth UUID are blocked.
EXPECT_TRUE(SerialBlocklist::Get().IsExcluded(
*CreateBluetoothPortInfo("00001103-0000-1000-8000-00805f9b34fb")));
// Devices with nearby vendor and product IDs are not blocked.
EXPECT_FALSE(
SerialBlocklist::Get().IsExcluded(*CreateUsbPortInfo(0x18D1, 0x58F4)));
EXPECT_FALSE(
SerialBlocklist::Get().IsExcluded(*CreateUsbPortInfo(0x18D1, 0x58F2)));
EXPECT_FALSE(
SerialBlocklist::Get().IsExcluded(*CreateUsbPortInfo(0x18D0, 0x58F3)));
EXPECT_FALSE(
SerialBlocklist::Get().IsExcluded(*CreateUsbPortInfo(0x18D2, 0x58F3)));
// Non-standard Bluetooth UUIDs are fine.
EXPECT_FALSE(SerialBlocklist::Get().IsExcluded(
*CreateBluetoothPortInfo("aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa")));
}
|
