1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307
|
// Copyright 2020 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "build/build_config.h"
#include "chrome/browser/prefs/session_startup_pref.h"
#include "chrome/browser/profiles/keep_alive/profile_keep_alive_types.h"
#include "chrome/browser/profiles/keep_alive/scoped_profile_keep_alive.h"
#include "chrome/browser/sessions/session_restore_test_helper.h"
#include "chrome/browser/sessions/session_service_factory.h"
#include "chrome/browser/sessions/session_service_test_helper.h"
#include "chrome/browser/ui/browser_commands.h"
#include "chrome/browser/ui/browser_list.h"
#include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/startup/startup_tab.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/interactive_test_utils.h"
#include "chrome/test/base/ui_test_utils.h"
#include "components/keep_alive_registry/keep_alive_types.h"
#include "components/keep_alive_registry/scoped_keep_alive.h"
#include "components/sessions/content/content_test_helper.h"
#include "content/public/browser/render_widget_host_view.h"
#include "content/public/browser/web_contents.h"
#include "content/public/common/content_switches.h"
#include "content/public/test/browser_test.h"
#include "content/public/test/browser_test_utils.h"
#include "ui/views/widget/widget_interactive_uitest_utils.h"
#if BUILDFLAG(IS_CHROMEOS)
#include "ash/constants/ash_features.h"
#include "base/test/scoped_feature_list.h"
#endif // BUILDFLAG(IS_CHROMEOS)
class SessionRestoreInteractiveTest : public InProcessBrowserTest {
public:
SessionRestoreInteractiveTest() = default;
~SessionRestoreInteractiveTest() override = default;
protected:
void SetUpOnMainThread() override {
SessionStartupPref pref(SessionStartupPref::LAST);
SessionStartupPref::SetStartupPref(browser()->profile(), pref);
}
bool SetUpUserDataDirectory() override {
url1_ = ui_test_utils::GetTestUrl(
base::FilePath().AppendASCII("session_history"),
base::FilePath().AppendASCII("bot1.html"));
return InProcessBrowserTest::SetUpUserDataDirectory();
}
Browser* QuitBrowserAndRestore(Browser* browser) {
Profile* profile = browser->profile();
// Close the browser.
auto keep_alive = std::make_unique<ScopedKeepAlive>(
KeepAliveOrigin::SESSION_RESTORE, KeepAliveRestartOption::DISABLED);
auto profile_keep_alive = std::make_unique<ScopedProfileKeepAlive>(
profile, ProfileKeepAliveOrigin::kBrowserWindow);
CloseBrowserSynchronously(browser);
ui_test_utils::AllBrowserTabAddedWaiter tab_waiter;
SessionRestoreTestHelper restore_observer;
// Ensure the session service factory is started, even if it was explicitly
// shut down.
SessionServiceTestHelper helper(profile);
helper.SetForceBrowserNotAliveWithNoWindows(true);
// Create a new window, which should trigger session restore.
chrome::NewEmptyWindow(profile);
Browser* new_browser = chrome::FindBrowserWithTab(tab_waiter.Wait());
restore_observer.Wait();
WaitForTabsToLoad(new_browser);
keep_alive.reset();
profile_keep_alive.reset();
return new_browser;
}
void QuitMultiWindowBrowserAndRestore(Profile* profile,
bool wait_for_tab_loading = true) {
auto keep_alive = std::make_unique<ScopedKeepAlive>(
KeepAliveOrigin::SESSION_RESTORE, KeepAliveRestartOption::DISABLED);
auto profile_keep_alive = std::make_unique<ScopedProfileKeepAlive>(
profile, ProfileKeepAliveOrigin::kBrowserWindow);
int normal_window_counter = 0;
int minimized_window_counter = 0;
// Pretend to "close the browser."
SessionServiceFactory::ShutdownForProfile(profile);
while (Browser* browser = BrowserList::GetInstance()->GetLastActive()) {
if (browser->window()->IsMinimized()) {
minimized_window_counter++;
} else {
normal_window_counter++;
}
CloseBrowserSynchronously(browser);
}
// Now trigger a restore. We need to start up the services again
// before restoring.
SessionServiceFactory::GetForProfileForSessionRestore(profile);
SessionRestore::RestoreSession(
profile, nullptr,
SessionRestore::SYNCHRONOUS | SessionRestore::RESTORE_BROWSER, {});
for (Browser* browser : *(BrowserList::GetInstance())) {
if (wait_for_tab_loading) {
WaitForTabsToLoad(browser);
}
if (browser->window()->IsMinimized()) {
minimized_window_counter--;
} else {
normal_window_counter--;
}
}
keep_alive.reset();
profile_keep_alive.reset();
EXPECT_EQ(0, normal_window_counter);
EXPECT_EQ(0, minimized_window_counter);
}
void WaitForTabsToLoad(Browser* browser) {
for (int i = 0; i < browser->tab_strip_model()->count(); ++i) {
content::WebContents* contents =
browser->tab_strip_model()->GetWebContentsAt(i);
contents->GetController().LoadIfNecessary();
EXPECT_TRUE(content::WaitForLoadStop(contents));
}
}
GURL url1_;
};
// TODO(crbug.com/40814457): Flaky on Linux ASAN/TSAN builders.
#if BUILDFLAG(IS_LINUX) && \
(defined(ADDRESS_SANITIZER) || defined(THREAD_SANITIZER))
#define MAYBE_FocusOnLaunch DISABLED_FocusOnLaunch
#else
#define MAYBE_FocusOnLaunch FocusOnLaunch
#endif
IN_PROC_BROWSER_TEST_F(SessionRestoreInteractiveTest, MAYBE_FocusOnLaunch) {
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), url1_));
Browser* new_browser = QuitBrowserAndRestore(browser());
ASSERT_EQ(1u, BrowserList::GetInstance()->size());
ASSERT_EQ(url1_,
new_browser->tab_strip_model()->GetActiveWebContents()->GetURL());
ui_test_utils::BrowserActivationWaiter waiter(new_browser);
waiter.WaitForActivation();
// Ensure window has initial focus on launch.
EXPECT_TRUE(new_browser->tab_strip_model()
->GetActiveWebContents()
->GetRenderWidgetHostView()
->HasFocus());
}
// TODO(crbug.com/40818881): Flaky failures.
#if BUILDFLAG(IS_CHROMEOS) || BUILDFLAG(IS_LINUX) || BUILDFLAG(IS_MAC)
#define MAYBE_RestoreMinimizedWindow DISABLED_RestoreMinimizedWindow
#else
#define MAYBE_RestoreMinimizedWindow RestoreMinimizedWindow
#endif
// Verify that restoring a minimized window does not create a blank window.
// Regression test for https://crbug.com/1018885.
IN_PROC_BROWSER_TEST_F(SessionRestoreInteractiveTest,
MAYBE_RestoreMinimizedWindow) {
// Minimize the window.
views::test::PropertyWaiter minimize_waiter(
base::BindRepeating(&ui::BaseWindow::IsMinimized,
base::Unretained(browser()->window())),
true);
browser()->window()->Minimize();
EXPECT_TRUE(minimize_waiter.Wait());
// Restart and session restore the tabs.
Browser* restored = QuitBrowserAndRestore(browser());
EXPECT_EQ(1, restored->tab_strip_model()->count());
// Expect the window to be visible.
// Prior to the fix for https://crbug.com/1018885, the window was active but
// not visible.
EXPECT_TRUE(restored->window()->IsActive());
EXPECT_TRUE(restored->window()->IsVisible());
}
// Verify that in restoring a browser with a normal and minimized window twice,
// the minimized window remains minimized. Guards against a regression
// introduced in the fix for https://crbug.com/1204517. This test fails on
// Linux and Windows - see https://crbug.com/1213497.
// Also fails flakily on Mac.
IN_PROC_BROWSER_TEST_F(SessionRestoreInteractiveTest,
DISABLED_RestoreMinimizedWindowTwice) {
Profile* profile = browser()->profile();
// Create a second browser.
CreateBrowser(browser()->profile());
// Minimize the first browser window.
views::test::PropertyWaiter minimize_waiter(
base::BindRepeating(&ui::BaseWindow::IsMinimized,
base::Unretained(browser()->window())),
true);
browser()->window()->Minimize();
EXPECT_TRUE(minimize_waiter.Wait());
EXPECT_EQ(2u, BrowserList::GetInstance()->size());
// Quit and restore.
QuitMultiWindowBrowserAndRestore(profile);
// Quit and restore a second time.
QuitMultiWindowBrowserAndRestore(profile);
}
#if BUILDFLAG(IS_CHROMEOS)
class SessionRestoreAshInteractiveTest : public SessionRestoreInteractiveTest {
protected:
base::test::ScopedFeatureList scoped_feature_list_{
ash::features::kAshSessionRestoreDeferOccludedActiveTabLoad};
};
// Verify that only the visible active tab gets immediately loaded out of
// session restore.
// The test and the optimization only works for ash because the occlusion state
// is calculated synchronously and is available when `ProcessSessionWindows`
// finishes.
IN_PROC_BROWSER_TEST_F(SessionRestoreAshInteractiveTest, MultiWindowTabLoad) {
// Make WebContents respect occlusion state.
base::CommandLine* cmd = base::CommandLine::ForCurrentProcess();
cmd->RemoveSwitch(switches::kDisableBackgroundingOccludedWindowsForTesting);
Profile* profile = browser()->profile();
const gfx::Rect bounds(0, 0, 600, 400);
// Creates 2 browser windows with one fully occludes the other.
Browser* browser1 = browser();
const GURL kUrlWindow1("data:,window 1");
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser1, kUrlWindow1));
browser1->window()->SetBounds(bounds);
ui_test_utils::BrowserChangeObserver new_browser_observer(
nullptr, ui_test_utils::BrowserChangeObserver::ChangeType::kAdded);
chrome::NewWindow(browser1);
Browser* browser2 = new_browser_observer.Wait();
browser2->window()->SetBounds(bounds);
ui_test_utils::WaitUntilBrowserBecomeActive(browser2);
const GURL kUrlWindow2("data:,window 2");
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser2, kUrlWindow2));
EXPECT_EQ(
content::Visibility::OCCLUDED,
browser1->tab_strip_model()->GetActiveWebContents()->GetVisibility());
EXPECT_EQ(
content::Visibility::VISIBLE,
browser2->tab_strip_model()->GetActiveWebContents()->GetVisibility());
// Quit and restore.
QuitMultiWindowBrowserAndRestore(profile, /*wait_for_tab_loading=*/false);
// Checks that only the active tab in "window 2" starts to load immediately.
int load_count = 0;
GURL last_loading_tab_url;
for (Browser* browser : *(BrowserList::GetInstance())) {
for (int i = 0; i < browser->tab_strip_model()->count(); ++i) {
content::WebContents* contents =
browser->tab_strip_model()->GetWebContentsAt(i);
if (contents->IsLoading()) {
++load_count;
last_loading_tab_url = contents->GetLastCommittedURL();
}
}
}
EXPECT_EQ(1, load_count);
EXPECT_EQ(kUrlWindow2, last_loading_tab_url);
// Waits for "window 1" to finish load.
content::WebContents* contents_window1 = nullptr;
for (Browser* browser : *(BrowserList::GetInstance())) {
for (int i = 0; i < browser->tab_strip_model()->count(); ++i) {
content::WebContents* contents =
browser->tab_strip_model()->GetWebContentsAt(i);
if (contents->GetLastCommittedURL() == kUrlWindow1) {
contents_window1 = contents;
break;
}
}
}
EXPECT_TRUE(content::WaitForLoadStop(contents_window1));
// "window 1" should be in occluded state after load.
EXPECT_EQ(content::Visibility::OCCLUDED, contents_window1->GetVisibility());
}
#endif // BUILDFLAG(IS_CHROMEOS)
|