1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414
|
// Copyright 2012 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/spellcheck/browser/spelling_service_client.h"
#include <stddef.h>
#include <array>
#include <memory>
#include <string>
#include <vector>
#include "base/functional/bind.h"
#include "base/json/json_reader.h"
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"
#include "base/test/bind.h"
#include "base/values.h"
#include "chrome/test/base/testing_profile.h"
#include "components/prefs/pref_service.h"
#include "components/spellcheck/browser/pref_names.h"
#include "components/spellcheck/common/spellcheck_result.h"
#include "content/public/test/browser_task_environment.h"
#include "net/base/load_flags.h"
#include "net/http/http_util.h"
#include "services/network/public/cpp/shared_url_loader_factory.h"
#include "services/network/public/cpp/weak_wrapper_shared_url_loader_factory.h"
#include "services/network/public/mojom/url_response_head.mojom.h"
#include "services/network/test/test_url_loader_factory.h"
#include "services/network/test/test_utils.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace {
struct SpellingServiceTestCase {
const wchar_t* request_text;
std::string sanitized_request_text;
SpellingServiceClient::ServiceType request_type;
net::HttpStatusCode response_status;
std::string response_data;
bool success;
const char* corrected_text;
std::string language;
};
// A class derived from the SpellingServiceClient class used by the
// SpellingServiceClientTest class. This class sets the URLLoaderFactory so
// tests can control requests and responses.
class TestingSpellingServiceClient : public SpellingServiceClient {
public:
TestingSpellingServiceClient()
: success_(false),
test_shared_loader_factory_(
base::MakeRefCounted<network::WeakWrapperSharedURLLoaderFactory>(
&test_url_loader_factory_)) {
SetURLLoaderFactoryForTesting(test_shared_loader_factory_);
}
~TestingSpellingServiceClient() = default;
void SetExpectedTextCheckResult(bool success,
const std::string& sanitized_request_text,
const char* text) {
success_ = success;
sanitized_request_text_ = sanitized_request_text;
corrected_text_.assign(base::UTF8ToUTF16(text));
}
void VerifyResponse(bool success,
const std::u16string& request_text,
const std::vector<SpellCheckResult>& results) {
EXPECT_EQ(success_, success);
std::u16string text(base::UTF8ToUTF16(sanitized_request_text_));
for (auto it = results.begin(); it != results.end(); ++it) {
text.replace(it->location, it->length, it->replacements[0]);
}
EXPECT_EQ(corrected_text_, text);
}
bool ParseResponseSuccess(const std::string& data) {
std::vector<SpellCheckResult> results;
return ParseResponse(data, &results);
}
network::TestURLLoaderFactory* test_url_loader_factory() {
return &test_url_loader_factory_;
}
private:
bool success_;
std::string sanitized_request_text_;
std::u16string corrected_text_;
network::TestURLLoaderFactory test_url_loader_factory_;
scoped_refptr<network::SharedURLLoaderFactory> test_shared_loader_factory_;
};
// A test class used for testing the SpellingServiceClient class. This class
// implements a callback function used by the SpellingServiceClient class to
// monitor the class calls the callback with expected results.
class SpellingServiceClientTest
: public testing::TestWithParam<SpellingServiceTestCase> {
public:
void OnTextCheckComplete(int tag,
bool success,
const std::u16string& text,
const std::vector<SpellCheckResult>& results) {
client_.VerifyResponse(success, text, results);
}
protected:
bool GetExpectedCountry(const std::string& language, std::string* country) {
struct Countries {
const char* language;
const char* country;
};
static const auto kCountries = std::to_array<Countries>({
{"af", "ZAF"},
{"en", "USA"},
});
for (size_t i = 0; i < std::size(kCountries); ++i) {
if (!language.compare(kCountries[i].language)) {
country->assign(kCountries[i].country);
return true;
}
}
return false;
}
content::BrowserTaskEnvironment task_environment_;
TestingSpellingServiceClient client_;
TestingProfile profile_;
};
} // namespace
// Verifies that SpellingServiceClient::RequestTextCheck() creates a JSON
// request sent to the Spelling service as we expect. This test also verifies
// that it parses a JSON response from the service and calls the callback
// function. To avoid sending real requests to the service, this test uses a
// subclass of SpellingServiceClient that in turn sets the client's URL loader
// factory to a TestURLLoaderFactory. The client thinks it is issuing real
// network requests, but in fact the responses are entirely under our control
// and no network activity takes place.
// This test also uses a custom callback function that replaces all
// misspelled words with ones suggested by the service so this test can compare
// the corrected text with the expected results. (If there are not any
// misspelled words, |corrected_text| should be equal to |request_text|.)
using Redirects = std::vector<
std::pair<net::RedirectInfo, network::mojom::URLResponseHeadPtr>>;
TEST_P(SpellingServiceClientTest, RequestTextCheck) {
auto test_case = GetParam();
PrefService* pref = profile_.GetPrefs();
pref->SetBoolean(spellcheck::prefs::kSpellCheckEnable, true);
pref->SetBoolean(spellcheck::prefs::kSpellCheckUseSpellingService, true);
client_.test_url_loader_factory()->ClearResponses();
net::HttpStatusCode http_status = test_case.response_status;
auto head = network::mojom::URLResponseHead::New();
std::string headers(base::StringPrintf(
"HTTP/1.1 %d %s\nContent-type: application/json\n\n",
static_cast<int>(http_status), net::GetHttpReasonPhrase(http_status)));
head->headers = base::MakeRefCounted<net::HttpResponseHeaders>(
net::HttpUtil::AssembleRawHeaders(headers));
head->mime_type = "application/json";
network::URLLoaderCompletionStatus status;
status.decoded_body_length = test_case.response_data.size();
GURL expected_request_url = client_.BuildEndpointUrl(test_case.request_type);
client_.test_url_loader_factory()->AddResponse(
expected_request_url, std::move(head), test_case.response_data, status,
Redirects(),
network::TestURLLoaderFactory::ResponseProduceFlags::
kSendHeadersOnNetworkError);
net::HttpRequestHeaders intercepted_headers;
std::string intercepted_body;
GURL requested_url;
client_.test_url_loader_factory()->SetInterceptor(
base::BindLambdaForTesting([&](const network::ResourceRequest& request) {
intercepted_headers = request.headers;
intercepted_body = network::GetUploadData(request);
requested_url = request.url;
}));
client_.SetExpectedTextCheckResult(test_case.success,
test_case.sanitized_request_text,
test_case.corrected_text);
base::Value::List dictionary;
dictionary.Append(test_case.language);
pref->SetList(spellcheck::prefs::kSpellCheckDictionaries,
std::move(dictionary));
client_.RequestTextCheck(
&profile_, test_case.request_type,
base::WideToUTF16(test_case.request_text),
base::BindOnce(&SpellingServiceClientTest::OnTextCheckComplete,
base::Unretained(this), 0));
task_environment_.RunUntilIdle();
// Verify that the expected endpoint was hit (REST vs RPC).
ASSERT_EQ(requested_url.path(), expected_request_url.path());
// Verify the request content type was JSON. (The Spelling service returns
// an internal server error when this content type is not JSON.)
EXPECT_EQ("application/json", intercepted_headers.GetHeader(
net::HttpRequestHeaders::kContentType));
// Parse the JSON sent to the service, and verify its parameters.
std::optional<base::Value> value = base::JSONReader::Read(
intercepted_body, base::JSON_ALLOW_TRAILING_COMMAS);
ASSERT_TRUE(value);
ASSERT_TRUE(value->is_dict());
const base::Value::Dict& dict = value->GetDict();
EXPECT_FALSE(dict.FindString("method"));
EXPECT_FALSE(dict.FindString("apiVersion"));
const std::string* sanitized_text = dict.FindString("text");
EXPECT_TRUE(sanitized_text);
EXPECT_EQ(test_case.sanitized_request_text, *sanitized_text);
const std::string* language = dict.FindString("language");
EXPECT_TRUE(language);
std::string expected_language =
test_case.language.empty() ? std::string("en") : test_case.language;
EXPECT_EQ(expected_language, *language);
std::string expected_country;
ASSERT_TRUE(GetExpectedCountry(*language, &expected_country));
const std::string* country = dict.FindString("originCountry");
EXPECT_TRUE(country);
EXPECT_EQ(expected_country, *country);
}
INSTANTIATE_TEST_SUITE_P(
SpellingService,
SpellingServiceClientTest,
testing::Values(
// Test cases for the REST endpoint
SpellingServiceTestCase{
L"",
"",
SpellingServiceClient::SUGGEST,
net::HttpStatusCode(500),
"",
false,
"",
"af",
},
SpellingServiceTestCase{
L"chromebook",
"chromebook",
SpellingServiceClient::SUGGEST,
net::HttpStatusCode(200),
"{}",
true,
"chromebook",
"af",
},
SpellingServiceTestCase{
L"chrombook",
"chrombook",
SpellingServiceClient::SUGGEST,
net::HttpStatusCode(200),
"{\n"
" \"spellingCheckResponse\": {\n"
" \"misspellings\": [{\n"
" \"charStart\": 0,\n"
" \"charLength\": 9,\n"
" \"suggestions\": [{ \"suggestion\": \"chromebook\" }],\n"
" \"canAutoCorrect\": false\n"
" }]\n"
" }\n"
"}",
true,
"chromebook",
"af",
},
SpellingServiceTestCase{
L"",
"",
SpellingServiceClient::SPELLCHECK,
net::HttpStatusCode(500),
"",
false,
"",
"en",
},
SpellingServiceTestCase{
L"I have been to USA.",
"I have been to USA.",
SpellingServiceClient::SPELLCHECK,
net::HttpStatusCode(200),
"{}",
true,
"I have been to USA.",
"en",
},
SpellingServiceTestCase{
L"I have bean to USA.",
"I have bean to USA.",
SpellingServiceClient::SPELLCHECK,
net::HttpStatusCode(200),
"{\n"
" \"spellingCheckResponse\": {\n"
" \"misspellings\": [{\n"
" \"charStart\": 7,\n"
" \"charLength\": 4,\n"
" \"suggestions\": [{ \"suggestion\": \"been\" }],\n"
" \"canAutoCorrect\": false\n"
" }]\n"
" }\n"
"}",
true,
"I have been to USA.",
"en",
},
SpellingServiceTestCase{
L"I\x2019mattheIn'n'Out.",
"I'mattheIn'n'Out.",
SpellingServiceClient::SPELLCHECK,
net::HttpStatusCode(200),
"{\n"
" \"spellingCheckResponse\": {\n"
" \"misspellings\": [{\n"
" \"charStart\": 0,\n"
" \"charLength\": 16,\n"
" \"suggestions\":"
" [{ \"suggestion\": \"I'm at the In'N'Out\" }],\n"
" \"canAutoCorrect\": false\n"
" }]\n"
" }\n"
"}",
true,
"I'm at the In'N'Out.",
"en",
}));
// Verify that SpellingServiceClient::IsAvailable() returns true only when it
// can send suggest requests or spellcheck requests.
TEST_F(SpellingServiceClientTest, AvailableServices) {
const SpellingServiceClient::ServiceType kSuggest =
SpellingServiceClient::SUGGEST;
const SpellingServiceClient::ServiceType kSpellcheck =
SpellingServiceClient::SPELLCHECK;
// When a user disables spellchecking or prevent using the Spelling service,
// this function should return false both for suggestions and for spellcheck.
PrefService* pref = profile_.GetPrefs();
pref->SetBoolean(spellcheck::prefs::kSpellCheckEnable, false);
pref->SetBoolean(spellcheck::prefs::kSpellCheckUseSpellingService, false);
EXPECT_FALSE(client_.IsAvailable(&profile_, kSuggest));
EXPECT_FALSE(client_.IsAvailable(&profile_, kSpellcheck));
pref->SetBoolean(spellcheck::prefs::kSpellCheckEnable, true);
pref->SetBoolean(spellcheck::prefs::kSpellCheckUseSpellingService, true);
// For locales supported by the SpellCheck service, this function returns
// false for suggestions and true for spellcheck. (The comment in
// SpellingServiceClient::IsAvailable() describes why this function returns
// false for suggestions.) If there is no language set, then we
// do not allow any remote.
pref->SetList(spellcheck::prefs::kSpellCheckDictionaries,
base::Value::List());
EXPECT_FALSE(client_.IsAvailable(&profile_, kSuggest));
EXPECT_FALSE(client_.IsAvailable(&profile_, kSpellcheck));
constexpr static const auto kSupported = std::to_array<const char*>({
"en-AU",
"en-CA",
"en-GB",
"en-US",
"da-DK",
"es-ES",
});
// If spellcheck is allowed, then suggest is not since spellcheck is a
// superset of suggest.
for (size_t i = 0; i < std::size(kSupported); ++i) {
base::Value::List dictionary;
dictionary.Append(kSupported[i]);
pref->SetList(spellcheck::prefs::kSpellCheckDictionaries,
std::move(dictionary));
EXPECT_FALSE(client_.IsAvailable(&profile_, kSuggest));
EXPECT_TRUE(client_.IsAvailable(&profile_, kSpellcheck));
}
// This function returns true for suggestions for all and false for
// spellcheck for unsupported locales.
constexpr static const auto kUnsupported = std::to_array<const char*>({
"af-ZA", "bg-BG", "ca-ES", "cs-CZ", "de-DE", "el-GR", "et-EE", "fo-FO",
"fr-FR", "he-IL", "hi-IN", "hr-HR", "hu-HU", "id-ID", "it-IT", "lt-LT",
"lv-LV", "nb-NO", "nl-NL", "pl-PL", "pt-BR", "pt-PT", "ro-RO", "ru-RU",
"sk-SK", "sl-SI", "sh", "sr", "sv-SE", "tr-TR", "uk-UA", "vi-VN",
});
for (size_t i = 0; i < std::size(kUnsupported); ++i) {
SCOPED_TRACE(std::string("Expected language ") + kUnsupported[i]);
base::Value::List dictionary;
dictionary.Append(kUnsupported[i]);
pref->SetList(spellcheck::prefs::kSpellCheckDictionaries,
std::move(dictionary));
EXPECT_TRUE(client_.IsAvailable(&profile_, kSuggest));
EXPECT_FALSE(client_.IsAvailable(&profile_, kSpellcheck));
}
}
// Verify that an error in JSON response from spelling service will result in
// ParseResponse returning false.
TEST_F(SpellingServiceClientTest, ResponseErrorTest) {
EXPECT_TRUE(client_.ParseResponseSuccess("{\"result\": {}}"));
EXPECT_FALSE(client_.ParseResponseSuccess("{\"error\": {}}"));
}
|