1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
|
// Copyright 2016 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <string>
#include "base/command_line.h"
#include "base/memory/raw_ptr.h"
#include "base/test/metrics/histogram_tester.h"
#include "chrome/browser/ssl/chrome_security_state_tab_helper.h"
#include "chrome/test/base/chrome_render_view_host_test_harness.h"
#include "content/public/browser/navigation_entry.h"
#include "content/public/test/mock_navigation_handle.h"
#include "content/public/test/navigation_simulator.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace {
const char kFormSubmissionSecurityLevelHistogram[] =
"Security.SecurityLevel.FormSubmission";
const char kInsecureMainFrameFormSubmissionSecurityLevelHistogram[] =
"Security.SecurityLevel.InsecureMainFrameFormSubmission";
class SecurityStateTabHelperTest : public ChromeRenderViewHostTestHarness {
public:
SecurityStateTabHelperTest() = default;
SecurityStateTabHelperTest(const SecurityStateTabHelperTest&) = delete;
SecurityStateTabHelperTest& operator=(const SecurityStateTabHelperTest&) =
delete;
~SecurityStateTabHelperTest() override = default;
};
TEST_F(SecurityStateTabHelperTest, DoesNotRecreateHelper) {
ASSERT_FALSE(SecurityStateTabHelper::FromWebContents(web_contents()));
SecurityStateTabHelper::CreateForWebContents(web_contents());
SecurityStateTabHelper* helper =
SecurityStateTabHelper::FromWebContents(web_contents());
EXPECT_FALSE(helper->uses_embedder_information());
// This should be a noop.
SecurityStateTabHelper::CreateForWebContents(web_contents());
EXPECT_EQ(helper, SecurityStateTabHelper::FromWebContents(web_contents()));
}
TEST_F(SecurityStateTabHelperTest, DoesNotRecreateChromeHelper) {
ASSERT_FALSE(SecurityStateTabHelper::FromWebContents(web_contents()));
ChromeSecurityStateTabHelper::CreateForWebContents(web_contents());
SecurityStateTabHelper* helper =
SecurityStateTabHelper::FromWebContents(web_contents());
EXPECT_TRUE(helper->uses_embedder_information());
// This should be a noop.
ChromeSecurityStateTabHelper::CreateForWebContents(web_contents());
EXPECT_EQ(helper, SecurityStateTabHelper::FromWebContents(web_contents()));
}
class ChromeSecurityStateTabHelperHistogramTest
: public ChromeRenderViewHostTestHarness {
public:
ChromeSecurityStateTabHelperHistogramTest() : helper_(nullptr) {}
ChromeSecurityStateTabHelperHistogramTest(
const ChromeSecurityStateTabHelperHistogramTest&) = delete;
ChromeSecurityStateTabHelperHistogramTest& operator=(
const ChromeSecurityStateTabHelperHistogramTest&) = delete;
~ChromeSecurityStateTabHelperHistogramTest() override = default;
void SetUp() override {
ChromeRenderViewHostTestHarness::SetUp();
ChromeSecurityStateTabHelper::CreateForWebContents(web_contents());
helper_ = static_cast<ChromeSecurityStateTabHelper*>(
ChromeSecurityStateTabHelper::FromWebContents(web_contents()));
NavigateToHTTP();
}
protected:
// content::MockNavigationHandle doesn't have a test helper for setting
// whether a navigation is in the top frame, so subclass it to override
// IsInMainFrame() for testing subframe navigations.
class MockNavigationHandle : public content::MockNavigationHandle {
public:
MockNavigationHandle(const GURL& url,
content::RenderFrameHost* render_frame_host)
: content::MockNavigationHandle(url, render_frame_host) {}
bool IsInMainFrame() const override { return is_in_main_frame_; }
void set_is_in_main_frame(bool is_in_main_frame) {
is_in_main_frame_ = is_in_main_frame;
}
private:
bool is_in_main_frame_ = true;
};
void StartNavigation(bool is_form, bool is_main_frame) {
testing::NiceMock<MockNavigationHandle> handle(
GURL("http://example.test"), web_contents()->GetPrimaryMainFrame());
handle.set_is_form_submission(is_form);
handle.set_is_in_main_frame(is_main_frame);
helper_->DidStartNavigation(&handle);
handle.set_has_committed(true);
helper_->DidFinishNavigation(&handle);
}
void NavigateToHTTP() { NavigateAndCommit(GURL("http://example.test")); }
void NavigateToHTTPS() { NavigateAndCommit(GURL("https://example.test")); }
private:
raw_ptr<ChromeSecurityStateTabHelper, DanglingUntriaged> helper_;
};
TEST_F(ChromeSecurityStateTabHelperHistogramTest, FormSubmissionHistogram) {
base::HistogramTester histograms;
StartNavigation(/*is_form=*/true, /*is_main_frame=*/true);
histograms.ExpectUniqueSample(kFormSubmissionSecurityLevelHistogram,
security_state::WARNING, 1);
}
// Tests that insecure mainframe form submission histograms are recorded
// correctly.
TEST_F(ChromeSecurityStateTabHelperHistogramTest,
InsecureMainFrameFormSubmissionHistogram) {
base::HistogramTester histograms;
// Subframe submissions should not be logged.
StartNavigation(/*is_form=*/true, /*is_main_frame=*/false);
histograms.ExpectTotalCount(
kInsecureMainFrameFormSubmissionSecurityLevelHistogram, 0);
// Only form submissions from non-HTTPS pages should be logged.
StartNavigation(/*is_form=*/true, /*is_main_frame=*/true);
histograms.ExpectUniqueSample(
kInsecureMainFrameFormSubmissionSecurityLevelHistogram,
security_state::WARNING, 1);
NavigateToHTTPS();
StartNavigation(/*is_form=*/true, /*is_main_frame=*/true);
histograms.ExpectTotalCount(
kInsecureMainFrameFormSubmissionSecurityLevelHistogram, 1);
}
} // namespace
|
