1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185
|
// Copyright 2024 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/sync/chrome_sync_client.h"
#include "base/files/file_path.h"
#include "chrome/browser/sync/glue/extensions_activity_monitor.h"
#include "chrome/test/base/scoped_metrics_service_for_synthetic_trials.h"
#include "chrome/test/base/scoped_testing_local_state.h"
#include "chrome/test/base/testing_browser_process.h"
#include "components/metrics/metrics_service.h"
#include "components/sync/protocol/nigori_specifics.pb.h"
#include "components/sync/service/trusted_vault_synthetic_field_trial.h"
#include "components/sync/test/test_data_type_store_service.h"
#include "components/sync_device_info/fake_device_info_sync_service.h"
#include "components/variations/active_field_trials.h"
#include "components/variations/synthetic_trial_registry.h"
#include "components/variations/variations_test_utils.h"
#include "content/public/test/browser_task_environment.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace browser_sync {
namespace {
syncer::TrustedVaultAutoUpgradeSyntheticFieldTrialGroup BuildExperimentGroup(
int cohort,
sync_pb::TrustedVaultAutoUpgradeExperimentGroup::Type type,
int type_index) {
sync_pb::TrustedVaultAutoUpgradeExperimentGroup proto;
proto.set_cohort(cohort);
proto.set_type(type);
proto.set_type_index(type_index);
return syncer::TrustedVaultAutoUpgradeSyntheticFieldTrialGroup::FromProto(
proto);
}
class ChromeSyncClientTest : public testing::Test {
protected:
ChromeSyncClientTest() = default;
~ChromeSyncClientTest() override = default;
std::unique_ptr<ChromeSyncClient> BuildClient(
const base::FilePath& profile_base_name) {
return std::make_unique<ChromeSyncClient>(
profile_base_name,
/*pref_service=*/nullptr,
/*identity_manager=*/nullptr,
/*trusted_vault_service=*/nullptr,
/*sync_invalidations_service=*/nullptr, &device_info_sync_service_,
&data_type_store_service_,
/*supervised_user_settings_service=*/nullptr,
/*extensions_activity_monitor=*/nullptr);
}
std::vector<variations::ActiveGroupId> GetSyntheticFieldTrials() {
return metrics_service_.Get()
->GetSyntheticTrialRegistry()
->GetCurrentSyntheticFieldTrialsForTest();
}
private:
content::BrowserTaskEnvironment task_environment_;
ScopedTestingLocalState testing_local_state_{
TestingBrowserProcess::GetGlobal()};
ScopedMetricsServiceForSyntheticTrials metrics_service_{
TestingBrowserProcess::GetGlobal()};
syncer::FakeDeviceInfoSyncService device_info_sync_service_;
syncer::TestDataTypeStoreService data_type_store_service_;
};
TEST_F(ChromeSyncClientTest, ShouldRegisterSyntheticFieldTrial) {
std::unique_ptr<ChromeSyncClient> client =
BuildClient(base::FilePath(FILE_PATH_LITERAL("profile1")));
client->RegisterTrustedVaultAutoUpgradeSyntheticFieldTrial(
BuildExperimentGroup(
/*cohort=*/6,
sync_pb::TrustedVaultAutoUpgradeExperimentGroup::CONTROL,
/*type_index=*/0));
EXPECT_TRUE(ContainsTrialAndGroupName(
GetSyntheticFieldTrials(),
syncer::kTrustedVaultAutoUpgradeSyntheticFieldTrialName,
"Cohort6_Control"));
}
TEST_F(ChromeSyncClientTest,
ShouldIgnoreRepeatedRegistrationOfSameSyntheticFieldTrial) {
const base::FilePath profile_base_name(FILE_PATH_LITERAL("profile1"));
const syncer::TrustedVaultAutoUpgradeSyntheticFieldTrialGroup group =
BuildExperimentGroup(
/*cohort=*/6,
sync_pb::TrustedVaultAutoUpgradeExperimentGroup::CONTROL,
/*type_index=*/0);
std::unique_ptr<ChromeSyncClient> client1 = BuildClient(profile_base_name);
client1->RegisterTrustedVaultAutoUpgradeSyntheticFieldTrial(group);
ASSERT_TRUE(ContainsTrialAndGroupName(
GetSyntheticFieldTrials(),
syncer::kTrustedVaultAutoUpgradeSyntheticFieldTrialName,
"Cohort6_Control"));
// Note that the second instance uses the same profile name.
std::unique_ptr<ChromeSyncClient> client2 = BuildClient(profile_base_name);
client2->RegisterTrustedVaultAutoUpgradeSyntheticFieldTrial(group);
EXPECT_TRUE(ContainsTrialAndGroupName(
GetSyntheticFieldTrials(),
syncer::kTrustedVaultAutoUpgradeSyntheticFieldTrialName,
"Cohort6_Control"));
}
TEST_F(ChromeSyncClientTest,
ShouldReportSyntheticFieldTrialMultiProfileConflict) {
const syncer::TrustedVaultAutoUpgradeSyntheticFieldTrialGroup group =
BuildExperimentGroup(
/*cohort=*/6,
sync_pb::TrustedVaultAutoUpgradeExperimentGroup::CONTROL,
/*type_index=*/0);
BuildClient(base::FilePath(FILE_PATH_LITERAL("profile1")))
->RegisterTrustedVaultAutoUpgradeSyntheticFieldTrial(group);
ASSERT_TRUE(ContainsTrialAndGroupName(
GetSyntheticFieldTrials(),
syncer::kTrustedVaultAutoUpgradeSyntheticFieldTrialName,
"Cohort6_Control"));
// If a different profile gets loaded that also registers a trial, it should
// be interpreted as a conflict.
BuildClient(base::FilePath(FILE_PATH_LITERAL("profile2")))
->RegisterTrustedVaultAutoUpgradeSyntheticFieldTrial(group);
EXPECT_TRUE(ContainsTrialAndGroupName(
GetSyntheticFieldTrials(),
syncer::kTrustedVaultAutoUpgradeSyntheticFieldTrialName,
"MultiProfileConflict"));
}
TEST_F(ChromeSyncClientTest,
ShouldIgnoreSyntheticFieldTrialsOnceMultiProfileConflictDetected) {
const syncer::TrustedVaultAutoUpgradeSyntheticFieldTrialGroup group =
BuildExperimentGroup(
/*cohort=*/6,
sync_pb::TrustedVaultAutoUpgradeExperimentGroup::CONTROL,
/*type_index=*/0);
BuildClient(base::FilePath(FILE_PATH_LITERAL("profile1")))
->RegisterTrustedVaultAutoUpgradeSyntheticFieldTrial(group);
BuildClient(base::FilePath(FILE_PATH_LITERAL("profile2")))
->RegisterTrustedVaultAutoUpgradeSyntheticFieldTrial(group);
ASSERT_TRUE(ContainsTrialAndGroupName(
GetSyntheticFieldTrials(),
syncer::kTrustedVaultAutoUpgradeSyntheticFieldTrialName,
"MultiProfileConflict"));
// No matter what happens afterwards, the multi-profile conflict should remain
// unmodified.
BuildClient(base::FilePath(FILE_PATH_LITERAL("profile2")))
->RegisterTrustedVaultAutoUpgradeSyntheticFieldTrial(group);
EXPECT_TRUE(ContainsTrialAndGroupName(
GetSyntheticFieldTrials(),
syncer::kTrustedVaultAutoUpgradeSyntheticFieldTrialName,
"MultiProfileConflict"));
BuildClient(base::FilePath(FILE_PATH_LITERAL("profile1")))
->RegisterTrustedVaultAutoUpgradeSyntheticFieldTrial(group);
EXPECT_TRUE(ContainsTrialAndGroupName(
GetSyntheticFieldTrials(),
syncer::kTrustedVaultAutoUpgradeSyntheticFieldTrialName,
"MultiProfileConflict"));
BuildClient(base::FilePath(FILE_PATH_LITERAL("profile3")))
->RegisterTrustedVaultAutoUpgradeSyntheticFieldTrial(group);
EXPECT_TRUE(ContainsTrialAndGroupName(
GetSyntheticFieldTrials(),
syncer::kTrustedVaultAutoUpgradeSyntheticFieldTrialName,
"MultiProfileConflict"));
}
} // namespace
} // namespace browser_sync
|