1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
|
// Copyright 2021 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/functional/callback.h"
#include "base/memory/raw_ptr.h"
#include "base/run_loop.h"
#include "chrome/browser/sync/sessions/sync_sessions_web_contents_router.h"
#include "chrome/browser/sync/sessions/sync_sessions_web_contents_router_factory.h"
#include "chrome/browser/translate/chrome_translate_client.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_finder.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/ui_test_utils.h"
#include "components/language/core/common/language_experiments.h"
#include "components/sync_sessions/synced_tab_delegate.h"
#include "components/translate/core/browser/translate_driver.h"
#include "content/public/test/browser_test.h"
#include "content/public/test/browser_test_utils.h"
#include "content/public/test/prerender_test_util.h"
#include "net/test/embedded_test_server/embedded_test_server.h"
#include "url/gurl.h"
namespace {
class TestLocalSessionEventHandler
: public sync_sessions::LocalSessionEventHandler {
public:
void OnSessionRestoreComplete() override {}
void OnLocalTabModified(
sync_sessions::SyncedTabDelegate* modified_tab) override {
local_tab_updated_ = true;
if (quit_closure_) {
std::move(quit_closure_).Run();
}
}
void OnLocalTabClosed() override { OnLocalTabModified(nullptr); }
bool local_tab_updated() { return local_tab_updated_; }
void reset_local_tab_updated() { local_tab_updated_ = false; }
private:
base::OnceClosure quit_closure_;
bool local_tab_updated_ = false;
};
class TestTranslateDriverObserver
: public translate::TranslateDriver::LanguageDetectionObserver {
public:
void OnLanguageDetermined(
const translate::LanguageDetectionDetails& details) override {
if (interested_url_ != details.url) {
return;
}
language_determined_ = true;
if (quit_closure_) {
std::move(quit_closure_).Run();
}
}
void WaitForLanguageDetermined() {
if (language_determined_) {
return;
}
base::RunLoop run_loop;
quit_closure_ = run_loop.QuitClosure();
run_loop.Run();
}
void SetInterestedURL(const GURL& url) { interested_url_ = url; }
private:
GURL interested_url_;
base::OnceClosure quit_closure_;
bool language_determined_ = false;
};
} // namespace
class SyncSessionsRouterTabHelperBrowserTest : public InProcessBrowserTest {
public:
SyncSessionsRouterTabHelperBrowserTest()
: prerender_helper_(base::BindRepeating(
&SyncSessionsRouterTabHelperBrowserTest::web_contents,
base::Unretained(this))) {}
~SyncSessionsRouterTabHelperBrowserTest() override = default;
void SetUp() override {
prerender_helper_.RegisterServerRequestMonitor(embedded_test_server());
InProcessBrowserTest::SetUp();
}
void SetUpOnMainThread() override {
web_contents_ = browser()->tab_strip_model()->GetActiveWebContents();
ASSERT_TRUE(embedded_test_server()->Start());
}
void AddLanguageDetectionObserver(const GURL& url) {
observer_.SetInterestedURL(url);
ChromeTranslateClient* chrome_translate_client =
ChromeTranslateClient::FromWebContents(web_contents());
if (!chrome_translate_client) {
return;
}
chrome_translate_client->GetTranslateDriver()->AddLanguageDetectionObserver(
&observer_);
}
void RemoveLanguageDetectionObserver() {
observer_.SetInterestedURL(GURL());
ChromeTranslateClient* chrome_translate_client =
ChromeTranslateClient::FromWebContents(web_contents());
if (!chrome_translate_client) {
return;
}
chrome_translate_client->GetTranslateDriver()
->RemoveLanguageDetectionObserver(&observer_);
}
content::WebContents* web_contents() { return web_contents_; }
content::test::PrerenderTestHelper* prerender_helper() {
return &prerender_helper_;
}
TestLocalSessionEventHandler* GetSessionEventHandler() { return &handler; }
TestTranslateDriverObserver* GetTranslateDriverObserver() {
return &observer_;
}
protected:
private:
raw_ptr<content::WebContents, AcrossTasksDanglingUntriaged> web_contents_ =
nullptr;
content::test::PrerenderTestHelper prerender_helper_;
TestLocalSessionEventHandler handler;
TestTranslateDriverObserver observer_;
};
// Tests if SyncSessionsRouterTabHelper doesn't notify of
// SyncSessionsWebContentsRouter while a page without a title is prerendered.
IN_PROC_BROWSER_TEST_F(SyncSessionsRouterTabHelperBrowserTest,
SyncSessionRouterWithoutTitleInPrerender) {
GURL url = embedded_test_server()->GetURL("/empty.html");
// Set LanguageDetectionObserver to make sure that it starts prerendering
// after OnLanguageDetermined() on the current loading which could trigger a
// session sync.
AddLanguageDetectionObserver(url);
// Navigate to |url|.
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), url));
sync_sessions::SyncSessionsWebContentsRouterFactory::GetInstance()
->GetForProfile(browser()->profile())
->StartRoutingTo(GetSessionEventHandler());
// Wait for OnLanguageDetermined().
GetTranslateDriverObserver()->WaitForLanguageDetermined();
// Reset to test if it's updated in prerendering.
GetSessionEventHandler()->reset_local_tab_updated();
// Prerender a page. It uses a page that doesn't have a title to avoid getting
// OnLocalTabModified() by SyncSessionsRouterTabHelper::TitleWasSet(). Except
// it, SyncSessionsRouterTabHelper doesn't trigger OnLocalTabModified() on
// prerendering.
GURL prerender_url = embedded_test_server()->GetURL("/title1.html");
content::FrameTreeNodeId prerender_id =
prerender_helper()->AddPrerender(prerender_url);
content::test::PrerenderHostObserver host_observer(*web_contents(),
prerender_id);
// Make sure that OnLocalTabModified() is not called.
EXPECT_FALSE(GetSessionEventHandler()->local_tab_updated());
// Navigate the primary page to the URL.
prerender_helper()->NavigatePrimaryPage(prerender_url);
// Make sure that once the prerendered page is activated,
// OnLocalTabModified() is called.
EXPECT_TRUE(GetSessionEventHandler()->local_tab_updated());
// Clear LanguageDetectionObserver.
RemoveLanguageDetectionObserver();
// Stop Routing.
sync_sessions::SyncSessionsWebContentsRouterFactory::GetInstance()
->GetForProfile(browser()->profile())
->Stop();
// Make sure that the prerender was activated when the main frame was
// navigated to the prerender_url.
ASSERT_TRUE(host_observer.was_activated());
}
|
