1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373
|
// Copyright 2012 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <memory>
#include <vector>
#include "base/containers/circular_deque.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/sync/test/integration/bookmarks_helper.h"
#include "chrome/browser/sync/test/integration/migration_waiter.h"
#include "chrome/browser/sync/test/integration/migration_watcher.h"
#include "chrome/browser/sync/test/integration/preferences_helper.h"
#include "chrome/browser/sync/test/integration/sync_test.h"
#include "chrome/common/pref_names.h"
#include "components/sync/base/features.h"
#include "components/sync/service/sync_service_impl.h"
#include "content/public/test/browser_test.h"
using bookmarks_helper::AddURL;
using bookmarks_helper::IndexedURL;
using bookmarks_helper::IndexedURLTitle;
using preferences_helper::BooleanPrefMatches;
using preferences_helper::ChangeBooleanPref;
namespace {
// Utility functions to make a data type set out of a small number of
// data types.
// TODO(crbug.com/40911681): MakeSet() seems pretty redundant, can be replaced
// with its body.
syncer::DataTypeSet MakeSet(syncer::DataType type) {
return {type};
}
syncer::DataTypeSet MakeSet(syncer::DataType type1, syncer::DataType type2) {
return {type1, type2};
}
// An ordered list of data types sets to migrate. Used by
// RunMigrationTest().
using MigrationList = base::circular_deque<syncer::DataTypeSet>;
// Utility functions to make a MigrationList out of a small number of
// data types / data type sets.
MigrationList MakeList(syncer::DataTypeSet data_types) {
return MigrationList(1, data_types);
}
MigrationList MakeList(syncer::DataTypeSet data_types1,
syncer::DataTypeSet data_types2) {
MigrationList migration_list;
migration_list.push_back(data_types1);
migration_list.push_back(data_types2);
return migration_list;
}
MigrationList MakeList(syncer::DataType type) {
return MakeList(MakeSet(type));
}
MigrationList MakeList(syncer::DataType type1, syncer::DataType type2) {
return MakeList(MakeSet(type1), MakeSet(type2));
}
class MigrationTest : public SyncTest {
public:
explicit MigrationTest(TestType test_type) : SyncTest(test_type) {}
MigrationTest(const MigrationTest&) = delete;
MigrationTest& operator=(const MigrationTest&) = delete;
~MigrationTest() override = default;
enum TriggerMethod { MODIFY_PREF, MODIFY_BOOKMARK, TRIGGER_REFRESH };
// Initialize all MigrationWatchers. This helps ensure that all migration
// events are captured, even if they were to occur before a test calls
// AwaitMigration for a specific profile.
void Initialize() {
for (int i = 0; i < num_clients(); ++i) {
migration_watchers_.push_back(
std::make_unique<MigrationWatcher>(GetClient(i)));
}
}
syncer::DataTypeSet GetPreferredDataTypes() {
// SyncServiceImpl must already have been created before we can call
// GetPreferredDataTypes().
DCHECK(GetSyncService(0));
syncer::DataTypeSet preferred_data_types =
GetSyncService(0)->GetPreferredDataTypes();
// Make sure all clients have the same preferred data types.
for (int i = 1; i < num_clients(); ++i) {
const syncer::DataTypeSet other_preferred_data_types =
GetSyncService(i)->GetPreferredDataTypes();
EXPECT_EQ(other_preferred_data_types, preferred_data_types);
}
preferred_data_types.RetainAll(syncer::ProtocolTypes());
// Supervised user data types will be "unready" during this test, so we
// should not request that they be migrated.
preferred_data_types.Remove(syncer::SUPERVISED_USER_SETTINGS);
// Autofill wallet and plus address will be unready during this test, so we
// should not request that it be migrated.
preferred_data_types.RemoveAll(
{syncer::AUTOFILL_WALLET_DATA, syncer::AUTOFILL_WALLET_METADATA,
syncer::AUTOFILL_WALLET_OFFER, syncer::PLUS_ADDRESS,
syncer::PLUS_ADDRESS_SETTING});
// ARC package will be unready during this test, so we should not request
// that it be migrated.
preferred_data_types.Remove(syncer::ARC_PACKAGE);
// Doesn't make sense to migrate commit only types.
preferred_data_types.RemoveAll(syncer::CommitOnlyTypes());
return preferred_data_types;
}
// Returns a MigrationList with every enabled data type in its own
// set.
MigrationList GetPreferredDataTypesList() {
MigrationList migration_list;
const syncer::DataTypeSet preferred_data_types = GetPreferredDataTypes();
for (syncer::DataType type : preferred_data_types) {
migration_list.push_back(MakeSet(type));
}
return migration_list;
}
// Trigger a migration for the given types with the given method.
void TriggerMigration(syncer::DataTypeSet data_types,
TriggerMethod trigger_method) {
switch (trigger_method) {
case MODIFY_PREF:
// Unlike MODIFY_BOOKMARK, MODIFY_PREF doesn't cause a
// notification to happen (since model association on a
// boolean pref clobbers the local value), so it doesn't work
// for anything but single-client tests.
ASSERT_EQ(1, num_clients());
ChangeBooleanPref(0, prefs::kShowHomeButton);
break;
case MODIFY_BOOKMARK:
ASSERT_TRUE(AddURL(0, IndexedURLTitle(0), GURL(IndexedURL(0))));
break;
case TRIGGER_REFRESH:
TriggerSyncForDataTypes(/*index=*/0, data_types);
break;
default:
ADD_FAILURE();
}
}
// Block until all clients have completed migration for the given
// types.
void AwaitMigration(syncer::DataTypeSet migrate_types) {
for (int i = 0; i < num_clients(); ++i) {
ASSERT_TRUE(
MigrationWaiter(migrate_types, migration_watchers_[i].get()).Wait());
}
}
// Makes sure migration works with the given migration list and
// trigger method.
void RunMigrationTest(const MigrationList& migration_list,
TriggerMethod trigger_method) {
// Make sure migration hasn't been triggered prematurely.
for (int i = 0; i < num_clients(); ++i) {
ASSERT_TRUE(migration_watchers_[i]->GetMigratedTypes().empty());
}
// Phase 1: Trigger the migrations on the server.
for (const syncer::DataTypeSet& data_types : migration_list) {
TriggerMigrationDoneError(data_types);
}
// Phase 2: Trigger each migration individually and wait for it to
// complete. (Multiple migrations may be handled by each
// migration cycle, but there's no guarantee of that, so we have
// to trigger each migration individually.)
for (const syncer::DataTypeSet& data_types : migration_list) {
TriggerMigration(data_types, trigger_method);
AwaitMigration(data_types);
}
// Phase 3: Wait for all clients to catch up.
ASSERT_TRUE(AwaitQuiescence());
}
private:
// Used to keep track of the migration progress for each sync client.
std::vector<std::unique_ptr<MigrationWatcher>> migration_watchers_;
};
class MigrationSingleClientTest : public MigrationTest {
public:
MigrationSingleClientTest() : MigrationTest(SINGLE_CLIENT) {}
MigrationSingleClientTest(const MigrationSingleClientTest&) = delete;
MigrationSingleClientTest& operator=(const MigrationSingleClientTest&) =
delete;
~MigrationSingleClientTest() override = default;
void RunSingleClientMigrationTest(const MigrationList& migration_list,
TriggerMethod trigger_method) {
ASSERT_TRUE(SetupSync());
Initialize();
RunMigrationTest(migration_list, trigger_method);
}
};
// The simplest possible migration tests -- a single data type.
IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest, PrefsOnlyModifyPref) {
RunSingleClientMigrationTest(MakeList(syncer::PREFERENCES), MODIFY_PREF);
}
IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest, PrefsOnlyModifyBookmark) {
RunSingleClientMigrationTest(MakeList(syncer::PREFERENCES), MODIFY_BOOKMARK);
}
IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest, PrefsOnlyTriggerRefresh) {
RunSingleClientMigrationTest(MakeList(syncer::PREFERENCES), TRIGGER_REFRESH);
}
// Nigori is handled specially, so we test that separately.
IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest, NigoriOnly) {
RunSingleClientMigrationTest(MakeList(syncer::PREFERENCES), TRIGGER_REFRESH);
}
// A little more complicated -- two data types.
IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest, BookmarksPrefsIndividually) {
RunSingleClientMigrationTest(MakeList(syncer::BOOKMARKS, syncer::PREFERENCES),
MODIFY_PREF);
}
IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest, BookmarksPrefsBoth) {
RunSingleClientMigrationTest(
MakeList(MakeSet(syncer::BOOKMARKS, syncer::PREFERENCES)),
MODIFY_BOOKMARK);
}
// Two data types with one being nigori.
IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest, PrefsNigoriIndividiaully) {
RunSingleClientMigrationTest(MakeList(syncer::PREFERENCES, syncer::NIGORI),
TRIGGER_REFRESH);
}
IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest, PrefsNigoriBoth) {
RunSingleClientMigrationTest(
MakeList(MakeSet(syncer::PREFERENCES, syncer::NIGORI)), MODIFY_PREF);
}
// The whole shebang -- all data types.
IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest, AllTypesIndividually) {
ASSERT_TRUE(SetupClients());
RunSingleClientMigrationTest(GetPreferredDataTypesList(), MODIFY_BOOKMARK);
}
IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest,
AllTypesIndividuallyTriggerRefresh) {
ASSERT_TRUE(SetupClients());
RunSingleClientMigrationTest(GetPreferredDataTypesList(), TRIGGER_REFRESH);
}
IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest, AllTypesAtOnce) {
ASSERT_TRUE(SetupClients());
RunSingleClientMigrationTest(MakeList(GetPreferredDataTypes()), MODIFY_PREF);
}
IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest,
AllTypesAtOnceTriggerRefresh) {
ASSERT_TRUE(SetupClients());
RunSingleClientMigrationTest(MakeList(GetPreferredDataTypes()),
TRIGGER_REFRESH);
}
// All data types plus nigori.
IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest,
AllTypesWithNigoriIndividually) {
ASSERT_TRUE(SetupClients());
MigrationList migration_list = GetPreferredDataTypesList();
migration_list.push_front(MakeSet(syncer::NIGORI));
RunSingleClientMigrationTest(migration_list, MODIFY_BOOKMARK);
}
IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest, AllTypesWithNigoriAtOnce) {
ASSERT_TRUE(SetupClients());
syncer::DataTypeSet all_types = GetPreferredDataTypes();
all_types.Put(syncer::NIGORI);
RunSingleClientMigrationTest(MakeList(all_types), MODIFY_PREF);
}
class MigrationTwoClientTest : public MigrationTest {
public:
MigrationTwoClientTest() : MigrationTest(TWO_CLIENT) {}
MigrationTwoClientTest(const MigrationTwoClientTest&) = delete;
MigrationTwoClientTest& operator=(const MigrationTwoClientTest&) = delete;
~MigrationTwoClientTest() override = default;
// Helper function that verifies that preferences sync still works.
void VerifyPrefSync() {
ASSERT_TRUE(BooleanPrefMatches(prefs::kShowHomeButton));
ChangeBooleanPref(0, prefs::kShowHomeButton);
ASSERT_TRUE(BooleanPrefMatchChecker(prefs::kShowHomeButton).Wait());
}
void RunTwoClientMigrationTest(const MigrationList& migration_list,
TriggerMethod trigger_method) {
ASSERT_TRUE(SetupSync());
Initialize();
// Make sure pref sync works before running the migration test.
VerifyPrefSync();
RunMigrationTest(migration_list, trigger_method);
// Make sure pref sync still works after running the migration
// test.
VerifyPrefSync();
}
};
// Easiest possible test of migration errors: triggers a server
// migration on one datatype, then modifies some other datatype.
IN_PROC_BROWSER_TEST_F(MigrationTwoClientTest, MigratePrefsThenModifyBookmark) {
RunTwoClientMigrationTest(MakeList(syncer::PREFERENCES), MODIFY_BOOKMARK);
}
// Triggers a server migration on two datatypes, then makes a local
// modification to one of them.
IN_PROC_BROWSER_TEST_F(MigrationTwoClientTest,
MigratePrefsAndBookmarksThenModifyBookmark) {
RunTwoClientMigrationTest(MakeList(syncer::PREFERENCES, syncer::BOOKMARKS),
MODIFY_BOOKMARK);
}
// Migrate every datatype in sequence; the catch being that the server
// will only tell the client about the migrations one at a time.
IN_PROC_BROWSER_TEST_F(MigrationTwoClientTest, MigrationHellWithoutNigori) {
ASSERT_TRUE(SetupClients());
MigrationList migration_list = GetPreferredDataTypesList();
// Let the first nudge be a datatype that's neither prefs nor bookmarks.
migration_list.push_front(MakeSet(syncer::THEMES));
ASSERT_EQ(MakeSet(syncer::NIGORI), migration_list.back());
migration_list.pop_back();
RunTwoClientMigrationTest(migration_list, MODIFY_BOOKMARK);
}
IN_PROC_BROWSER_TEST_F(MigrationTwoClientTest, MigrationHellWithNigori) {
ASSERT_TRUE(SetupClients());
MigrationList migration_list = GetPreferredDataTypesList();
// Let the first nudge be a datatype that's neither prefs nor bookmarks.
migration_list.push_front(MakeSet(syncer::THEMES));
ASSERT_EQ(MakeSet(syncer::NIGORI), migration_list.back());
RunTwoClientMigrationTest(migration_list, MODIFY_BOOKMARK);
}
} // namespace
|