1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134
|
// Copyright 2020 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <memory>
#include <string>
#include "base/files/file_util.h"
#include "base/json/json_reader.h"
#include "base/memory/raw_ptr.h"
#include "base/path_service.h"
#include "base/run_loop.h"
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"
#include "base/test/metrics/histogram_tester.h"
#include "base/test/scoped_feature_list.h"
#include "base/test/with_feature_override.h"
#include "build/build_config.h"
#include "chrome/browser/affiliations/affiliation_service_factory.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/browsing_data/chrome_browsing_data_remover_constants.h"
#include "chrome/browser/password_manager/account_password_store_factory.h"
#include "chrome/browser/password_manager/password_manager_test_base.h"
#include "chrome/browser/password_manager/passwords_navigation_observer.h"
#include "chrome/browser/password_manager/profile_password_store_factory.h"
#include "chrome/browser/signin/identity_manager_factory.h"
#include "chrome/browser/sync/test/integration/passwords_helper.h"
#include "chrome/browser/sync/test/integration/secondary_account_helper.h"
#include "chrome/browser/sync/test/integration/single_client_status_change_checker.h"
#include "chrome/browser/sync/test/integration/status_change_checker.h"
#include "chrome/browser/sync/test/integration/sync_service_impl_harness.h"
#include "chrome/browser/sync/test/integration/sync_test.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/passwords/manage_passwords_ui_controller.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/common/chrome_constants.h"
#include "chrome/common/chrome_paths.h"
#include "chrome/common/pref_names.h"
#include "chrome/test/base/ui_test_utils.h"
#include "components/password_manager/core/browser/features/password_features.h"
#include "components/password_manager/core/browser/features/password_manager_features_util.h"
#include "components/password_manager/core/browser/password_form.h"
#include "components/password_manager/core/browser/password_manager_test_utils.h"
#include "components/password_manager/core/browser/password_store/password_store_interface.h"
#include "components/password_manager/core/browser/password_store/password_store_results_observer.h"
#include "components/password_manager/core/browser/password_sync_util.h"
#include "components/password_manager/core/browser/ui/saved_passwords_presenter.h"
#include "components/password_manager/core/common/password_manager_features.h"
#include "components/password_manager/core/common/password_manager_pref_names.h"
#include "components/policy/core/browser/browser_policy_connector.h"
#include "components/policy/core/common/mock_configuration_policy_provider.h"
#include "components/policy/core/common/policy_map.h"
#include "components/policy/core/common/policy_types.h"
#include "components/policy/policy_constants.h"
#include "components/prefs/pref_service.h"
#include "components/signin/public/base/signin_switches.h"
#include "components/signin/public/identity_manager/account_info.h"
#include "components/signin/public/identity_manager/identity_test_utils.h"
#include "components/sync/base/data_type.h"
#include "components/sync/base/pref_names.h"
#include "components/sync/base/user_selectable_type.h"
#include "components/sync/service/sync_service.h"
#include "components/sync/service/sync_service_impl.h"
#include "components/sync/service/sync_user_settings.h"
#include "components/sync/test/fake_server_nigori_helper.h"
#include "content/public/browser/browser_context.h"
#include "content/public/browser/browsing_data_remover.h"
#include "content/public/test/browser_test.h"
#include "content/public/test/browsing_data_remover_test_util.h"
#include "content/public/test/content_mock_cert_verifier.h"
#include "google_apis/gaia/gaia_switches.h"
#include "google_apis/gaia/gaia_urls.h"
#include "net/dns/mock_host_resolver.h"
#include "net/http/http_status_code.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace {
using testing::ElementsAre;
using testing::IsEmpty;
using testing::NiceMock;
using testing::UnorderedElementsAre;
MATCHER_P2(MatchesLogin, username, password, "") {
return arg->username_value == base::UTF8ToUTF16(username) &&
arg->password_value == base::UTF8ToUTF16(password);
}
MATCHER_P3(MatchesLoginAndRealm, username, password, signon_realm, "") {
return arg->username_value == base::UTF8ToUTF16(username) &&
arg->password_value == base::UTF8ToUTF16(password) &&
arg->signon_realm == signon_realm;
}
const char kExampleHostname[] = "www.example.com";
const char kExamplePslHostname[] = "psl.example.com";
// Waits for SavedPasswordsPresenter to have a certain number of
// credentials.
class SavedPasswordsPresenterWaiter
: public StatusChangeChecker,
public password_manager::SavedPasswordsPresenter::Observer {
public:
SavedPasswordsPresenterWaiter(
password_manager::SavedPasswordsPresenter* presenter,
size_t n_passwords)
: presenter_(presenter), n_passwords_(n_passwords) {
presenter_->AddObserver(this);
}
~SavedPasswordsPresenterWaiter() override {
presenter_->RemoveObserver(this);
}
private:
bool IsExitConditionSatisfied(std::ostream* os) override {
*os << "Waiting for the SavedPasswordsPresenter to have " << n_passwords_
<< " passwords";
return presenter_->GetSavedCredentials().size() == n_passwords_;
}
void OnSavedPasswordsChanged(
const password_manager::PasswordStoreChangeList& changes) override {
CheckExitCondition();
}
const raw_ptr<password_manager::SavedPasswordsPresenter> presenter_;
const size_t n_passwords_;
};
class SyncActiveWithoutPasswordsChecker
: public SingleClientStatusChangeChecker {
public:
explicit SyncActiveWithoutPasswordsChecker(syncer::SyncServiceImpl* service)
: SingleClientStatusChangeChecker(service) {}
~SyncActiveWithoutPasswordsChecker() override = default;
// StatusChangeChecker implementation.
bool IsExitConditionSatisfied(std::ostream* os) override {
// DEVICE_INFO is another arbitrary type supported for signed-in users,
// just so we rule out no type at all is active.
return !service()->GetActiveDataTypes().Has(syncer::PASSWORDS) &&
service()->GetActiveDataTypes().Has(syncer::DEVICE_INFO);
}
};
// Note: This helper applies to ChromeOS too, but is currently unused there. So
// define it out to prevent a compile error due to the unused function.
#if !BUILDFLAG(IS_CHROMEOS)
content::WebContents* GetNewTab(Browser* browser) {
ui_test_utils::NavigateToURLWithDisposition(
browser, GURL("data:text/html"),
WindowOpenDisposition::NEW_FOREGROUND_TAB,
ui_test_utils::BROWSER_TEST_WAIT_FOR_TAB);
return browser->tab_strip_model()->GetActiveWebContents();
}
#endif // !BUILDFLAG(IS_CHROMEOS)
// This test fixture is similar to SingleClientPasswordsSyncTest, but it also
// sets up all the necessary test hooks etc for PasswordManager code (like
// PasswordManagerBrowserTestBase), to allow for integration tests covering
// both Sync and the PasswordManager.
class PasswordManagerSyncTest : public SyncTest {
public:
PasswordManagerSyncTest() : SyncTest(SINGLE_CLIENT) {
// Note: Enabling kFillOnAccountSelect effectively *disables* autofilling on
// page load. This is important because if a password is autofilled, then
// all Javascript changes to it are discarded, and thus any tests that cover
// updating a password become flaky.
feature_list_.InitWithFeatures(
/*enabled_features=*/{password_manager::features::kFillOnAccountSelect},
/*disabled_features=*/{});
}
~PasswordManagerSyncTest() override = default;
void SetUp() override {
// Setup HTTPS server serving files from standard test directory.
// This needs to happen here (really early) because the test server must
// already be running in SetUpCommandLine();
static constexpr base::FilePath::CharType kDocRoot[] =
FILE_PATH_LITERAL("chrome/test/data");
https_test_server()->ServeFilesFromSourceDirectory(
base::FilePath(kDocRoot));
ASSERT_TRUE(https_test_server()->Start());
SyncTest::SetUp();
}
void SetUpCommandLine(base::CommandLine* command_line) override {
SyncTest::SetUpCommandLine(command_line);
// Make sure that fake Gaia pages served by the test server match the Gaia
// URL (as specified by GaiaUrls::gaia_url()). Note that even though the
// hostname is the same, it's necessary to override the port to the one used
// by the test server.
command_line->AppendSwitchASCII(
switches::kGaiaUrl,
https_test_server()->GetURL("accounts.google.com", "/").spec());
mock_cert_verifier_.SetUpCommandLine(command_line);
}
void SetUpInProcessBrowserTestFixture() override {
SyncTest::SetUpInProcessBrowserTestFixture();
test_signin_client_subscription_ =
secondary_account_helper::SetUpSigninClient(&test_url_loader_factory_);
mock_cert_verifier_.SetUpInProcessBrowserTestFixture();
}
void TearDownInProcessBrowserTestFixture() override {
mock_cert_verifier_.TearDownInProcessBrowserTestFixture();
}
void SetUpOnMainThread() override {
SyncTest::SetUpOnMainThread();
ASSERT_TRUE(embedded_test_server()->Start());
host_resolver()->AddRule("*", "127.0.0.1");
// Whitelist all certs for the HTTPS server.
scoped_refptr<net::X509Certificate> cert =
https_test_server()->GetCertificate();
net::CertVerifyResult verify_result;
verify_result.cert_status = 0;
verify_result.verified_cert = cert;
mock_cert_verifier_.mock_cert_verifier()->AddResultForCert(
cert.get(), verify_result, net::OK);
fake_server::SetKeystoreNigoriInFakeServer(GetFakeServer());
}
void TearDownOnMainThread() override {
ASSERT_TRUE(https_test_server()->ShutdownAndWaitUntilComplete());
ASSERT_TRUE(embedded_test_server()->ShutdownAndWaitUntilComplete());
SyncTest::TearDownOnMainThread();
}
// Also stores the AccountInfo for the signed-in account in
// Implicit browser signin, disables passwords account storage by default.
void SignIn(SyncTestAccount account = SyncTestAccount::kDefaultAccount,
bool explicit_signin = true) {
if (explicit_signin) {
ASSERT_TRUE(GetClient(0)->SignInPrimaryAccount(account));
} else {
// Setup Sync for an unconsented account (i.e. in transport mode).
secondary_account_helper::ImplicitSignInUnconsentedAccount(
GetProfile(0), &test_url_loader_factory_,
GetClient(0)->GetEmailForAccount(account));
}
ASSERT_TRUE(GetClient(0)->AwaitSyncTransportActive());
ASSERT_FALSE(GetSyncService(0)->IsSyncFeatureEnabled());
}
void SetupSyncTransportWithPasswordAccountStorage(
bool explicit_signin = true) {
SignIn(SyncTestAccount::kDefaultAccount, explicit_signin);
if (!explicit_signin) {
// Enable the account-scoped password storage, and wait for it to become
// active.
GetSyncService(0)->GetUserSettings()->SetSelectedType(
syncer::UserSelectableType::kPasswords, true);
}
PasswordSyncActiveChecker(GetSyncService(0)).Wait();
ASSERT_TRUE(GetSyncService(0)->GetActiveDataTypes().Has(syncer::PASSWORDS));
}
// Should only be called after SetupSyncTransportWithPasswordAccountStorage().
void SignOut() {
secondary_account_helper::SignOut(GetProfile(0), &test_url_loader_factory_);
}
GURL GetWWWOrigin() {
return embedded_test_server()->GetURL(kExampleHostname, "/");
}
GURL GetPSLOrigin() {
return embedded_test_server()->GetURL(kExamplePslHostname, "/");
}
GURL GetHttpsOrigin(const std::string& hostname) {
return https_test_server()->GetURL(hostname, "/");
}
// Returns a credential for the origin returned by GetWWWOrigin().
password_manager::PasswordForm CreateTestPasswordForm(
const std::string& username,
const std::string& password) {
return CreateTestPasswordForm(username, password, GetWWWOrigin());
}
password_manager::PasswordForm CreateTestPasswordForm(
const std::string& username,
const std::string& password,
const GURL& origin) {
password_manager::PasswordForm form;
form.signon_realm = origin.spec();
form.url = origin;
form.username_value = base::UTF8ToUTF16(username);
form.password_value = base::UTF8ToUTF16(password);
form.date_created = base::Time::Now();
return form;
}
// Returns a credential for the origin returned by GetPSLOrigin().
password_manager::PasswordForm CreateTestPSLPasswordForm(
const std::string& username,
const std::string& password) {
return CreateTestPasswordForm(username, password, GetPSLOrigin());
}
// Adds a credential to the Sync fake server for the origin returned by
// GetWWWOrigin().
void AddCredentialToFakeServer(const std::string& username,
const std::string& password) {
AddCredentialToFakeServer(CreateTestPasswordForm(username, password));
}
// Adds a credential to the Sync fake server.
void AddCredentialToFakeServer(const password_manager::PasswordForm& form) {
passwords_helper::InjectKeystoreEncryptedServerPassword(form,
GetFakeServer());
}
// Adds a credential to the local store for the origin returned by
// GetWWWOrigin().
void AddLocalCredential(const std::string& username,
const std::string& password) {
AddLocalCredential(CreateTestPasswordForm(username, password));
}
// Adds a credential to the local store.
void AddLocalCredential(const password_manager::PasswordForm& form) {
scoped_refptr<password_manager::PasswordStoreInterface> password_store =
passwords_helper::GetProfilePasswordStoreInterface(0);
password_store->AddLogin(form);
// Do a roundtrip to the DB thread, to make sure the new password is stored
// before doing anything else that might depend on it.
GetAllLoginsFromProfilePasswordStore();
}
// Synchronously reads all credentials from the profile password store and
// returns them.
std::vector<std::unique_ptr<password_manager::PasswordForm>>
GetAllLoginsFromProfilePasswordStore() {
scoped_refptr<password_manager::PasswordStoreInterface> password_store =
passwords_helper::GetProfilePasswordStoreInterface(0);
password_manager::PasswordStoreResultsObserver syncer;
password_store->GetAllLoginsWithAffiliationAndBrandingInformation(
syncer.GetWeakPtr());
return syncer.WaitForResults();
}
// Synchronously reads all credentials from the account password store and
// returns them.
std::vector<std::unique_ptr<password_manager::PasswordForm>>
GetAllLoginsFromAccountPasswordStore() {
scoped_refptr<password_manager::PasswordStoreInterface> password_store =
passwords_helper::GetAccountPasswordStoreInterface(0);
password_manager::PasswordStoreResultsObserver syncer;
password_store->GetAllLoginsWithAffiliationAndBrandingInformation(
syncer.GetWeakPtr());
return syncer.WaitForResults();
}
void NavigateToFile(content::WebContents* web_contents,
const std::string& hostname,
const std::string& path) {
NavigateToFileImpl(web_contents,
embedded_test_server()->GetURL(hostname, path));
}
void NavigateToFileHttps(content::WebContents* web_contents,
const std::string& hostname,
const std::string& path) {
NavigateToFileImpl(web_contents,
https_test_server()->GetURL(hostname, path));
}
void FillAndSubmitPasswordForm(content::WebContents* web_contents,
const std::string& username,
const std::string& password) {
PasswordsNavigationObserver observer(web_contents);
std::string fill_and_submit = base::StringPrintf(
"document.getElementById('username_field').value = '%s';"
"document.getElementById('password_field').value = '%s';"
"document.getElementById('input_submit_button').click()",
username.c_str(), password.c_str());
ASSERT_TRUE(content::ExecJs(web_contents, fill_and_submit));
ASSERT_TRUE(observer.Wait());
}
net::EmbeddedTestServer* https_test_server() { return &https_test_server_; }
private:
void NavigateToFileImpl(content::WebContents* web_contents, const GURL& url) {
ASSERT_EQ(web_contents,
GetBrowser(0)->tab_strip_model()->GetActiveWebContents());
PasswordsNavigationObserver observer(web_contents);
ASSERT_TRUE(ui_test_utils::NavigateToURL(GetBrowser(0), url));
ASSERT_TRUE(observer.Wait());
// After navigation, the password manager retrieves any matching credentials
// from the store(s). So before doing anything else (like filling and
// submitting a form), do a roundtrip to the stores to make sure the
// credentials have finished loading.
GetAllLoginsFromProfilePasswordStore();
GetAllLoginsFromAccountPasswordStore();
}
base::test::ScopedFeatureList feature_list_;
base::CallbackListSubscription test_signin_client_subscription_;
// A test server instance that runs on HTTPS (as opposed to the default
// |embedded_test_server()|). This is necessary to simulate Gaia pages, which
// must be on a secure (cryptographic) scheme.
net::EmbeddedTestServer https_test_server_{
net::EmbeddedTestServer::TYPE_HTTPS};
content::ContentMockCertVerifier mock_cert_verifier_;
};
#if !BUILDFLAG(IS_CHROMEOS)
IN_PROC_BROWSER_TEST_F(PasswordManagerSyncTest, UpdateInProfileStore) {
ASSERT_TRUE(SetupClients());
AddLocalCredential("user", "localpass");
SetupSyncTransportWithPasswordAccountStorage();
content::WebContents* web_contents = GetNewTab(GetBrowser(0));
// Go to a form and submit a different password.
NavigateToFile(web_contents, kExampleHostname,
"/password/simple_password.html");
FillAndSubmitPasswordForm(web_contents, "user", "newpass");
// There should be an update bubble; accept it.
BubbleObserver bubble_observer(web_contents);
ASSERT_TRUE(bubble_observer.IsUpdatePromptShownAutomatically());
bubble_observer.AcceptUpdatePrompt();
// The updated password should be in the profile store, while the account
// store should still be empty.
EXPECT_THAT(GetAllLoginsFromProfilePasswordStore(),
ElementsAre(MatchesLogin("user", "newpass")));
EXPECT_THAT(GetAllLoginsFromAccountPasswordStore(), IsEmpty());
}
IN_PROC_BROWSER_TEST_F(PasswordManagerSyncTest, UpdateInAccountStore) {
ASSERT_TRUE(SetupClients());
AddCredentialToFakeServer("user", "accountpass");
SetupSyncTransportWithPasswordAccountStorage();
content::WebContents* web_contents = GetNewTab(GetBrowser(0));
// Go to a form and submit a different password.
NavigateToFile(web_contents, kExampleHostname,
"/password/simple_password.html");
FillAndSubmitPasswordForm(web_contents, "user", "newpass");
// There should be an update bubble; accept it.
BubbleObserver bubble_observer(web_contents);
ASSERT_TRUE(bubble_observer.IsUpdatePromptShownAutomatically());
bubble_observer.AcceptUpdatePrompt();
// The updated password should be in the account store, while the profile
// store should still be empty.
EXPECT_THAT(GetAllLoginsFromAccountPasswordStore(),
ElementsAre(MatchesLogin("user", "newpass")));
EXPECT_THAT(GetAllLoginsFromProfilePasswordStore(), IsEmpty());
}
IN_PROC_BROWSER_TEST_F(PasswordManagerSyncTest,
UpdateMatchingCredentialInBothStores) {
ASSERT_TRUE(SetupClients());
AddCredentialToFakeServer("user", "pass");
AddLocalCredential("user", "pass");
SetupSyncTransportWithPasswordAccountStorage();
content::WebContents* web_contents = GetNewTab(GetBrowser(0));
// Go to a form and submit a different password.
NavigateToFile(web_contents, kExampleHostname,
"/password/simple_password.html");
FillAndSubmitPasswordForm(web_contents, "user", "newpass");
// There should be an update bubble; accept it.
BubbleObserver bubble_observer(web_contents);
// TODO(crbug.com/40121096): Remove this temporary logging once the test
// flakiness is diagnosed.
if (!bubble_observer.IsUpdatePromptShownAutomatically()) {
LOG(ERROR) << "ManagePasswordsUIController state: "
<< ManagePasswordsUIController::FromWebContents(web_contents)
->GetState();
}
ASSERT_TRUE(bubble_observer.IsUpdatePromptShownAutomatically());
bubble_observer.AcceptUpdatePrompt();
// The updated password should be in both stores.
EXPECT_THAT(GetAllLoginsFromAccountPasswordStore(),
ElementsAre(MatchesLogin("user", "newpass")));
EXPECT_THAT(GetAllLoginsFromProfilePasswordStore(),
ElementsAre(MatchesLogin("user", "newpass")));
}
IN_PROC_BROWSER_TEST_F(PasswordManagerSyncTest,
UpdateMismatchingCredentialInBothStores) {
ASSERT_TRUE(SetupClients());
AddCredentialToFakeServer("user", "accountpass");
AddLocalCredential("user", "localpass");
SetupSyncTransportWithPasswordAccountStorage();
content::WebContents* web_contents = GetNewTab(GetBrowser(0));
// Go to a form and submit a different password.
NavigateToFile(web_contents, kExampleHostname,
"/password/simple_password.html");
FillAndSubmitPasswordForm(web_contents, "user", "newpass");
// There should be an update bubble; accept it.
BubbleObserver bubble_observer(web_contents);
// TODO(crbug.com/40121096): Remove this temporary logging once the test
// flakiness is diagnosed.
if (!bubble_observer.IsUpdatePromptShownAutomatically()) {
LOG(ERROR) << "ManagePasswordsUIController state: "
<< ManagePasswordsUIController::FromWebContents(web_contents)
->GetState();
}
ASSERT_TRUE(bubble_observer.IsUpdatePromptShownAutomatically());
bubble_observer.AcceptUpdatePrompt();
// The updated password should be in both stores.
EXPECT_THAT(GetAllLoginsFromAccountPasswordStore(),
ElementsAre(MatchesLogin("user", "newpass")));
EXPECT_THAT(GetAllLoginsFromProfilePasswordStore(),
ElementsAre(MatchesLogin("user", "newpass")));
}
// Tests that if credentials for the same username, but with different passwords
// exist in the two stores, and one of them is used to successfully log in, the
// other one is silently updated to match.
IN_PROC_BROWSER_TEST_F(PasswordManagerSyncTest,
AutoUpdateFromAccountToProfileOnSuccessfulUse) {
ASSERT_TRUE(SetupClients());
// Add credentials for the same username, but with different passwords, to the
// two stores.
AddCredentialToFakeServer("user", "accountpass");
AddLocalCredential("user", "localpass");
SetupSyncTransportWithPasswordAccountStorage();
// Now we have credentials for the same user, but with different passwords, in
// the two stores.
ASSERT_THAT(GetAllLoginsFromProfilePasswordStore(),
ElementsAre(MatchesLogin("user", "localpass")));
ASSERT_THAT(GetAllLoginsFromAccountPasswordStore(),
ElementsAre(MatchesLogin("user", "accountpass")));
content::WebContents* web_contents = GetNewTab(GetBrowser(0));
// Go to a form and submit the version of the credentials from the profile
// store.
NavigateToFile(web_contents, kExampleHostname,
"/password/simple_password.html");
FillAndSubmitPasswordForm(web_contents, "user", "localpass");
// Now the credential should of course still be in the profile store...
ASSERT_THAT(GetAllLoginsFromProfilePasswordStore(),
ElementsAre(MatchesLogin("user", "localpass")));
// ...but also the one in the account store should have been silently updated
// to match.
EXPECT_THAT(GetAllLoginsFromAccountPasswordStore(),
ElementsAre(MatchesLogin("user", "localpass")));
}
// Tests that if credentials for the same username, but with different passwords
// exist in the two stores, and one of them is used to successfully log in, the
// other one is silently updated to match.
IN_PROC_BROWSER_TEST_F(PasswordManagerSyncTest,
AutoUpdateFromProfileToAccountOnSuccessfulUse) {
ASSERT_TRUE(SetupClients());
// Add credentials for the same username, but with different passwords, to the
// two stores.
AddCredentialToFakeServer("user", "accountpass");
AddLocalCredential("user", "localpass");
SetupSyncTransportWithPasswordAccountStorage();
// Now we have credentials for the same user, but with different passwords, in
// the two stores.
ASSERT_THAT(GetAllLoginsFromProfilePasswordStore(),
ElementsAre(MatchesLogin("user", "localpass")));
ASSERT_THAT(GetAllLoginsFromAccountPasswordStore(),
ElementsAre(MatchesLogin("user", "accountpass")));
content::WebContents* web_contents = GetNewTab(GetBrowser(0));
// Go to a form and submit the version of the credentials from the account
// store.
NavigateToFile(web_contents, kExampleHostname,
"/password/simple_password.html");
FillAndSubmitPasswordForm(web_contents, "user", "accountpass");
// Now the credential should of course still be in the account store...
ASSERT_THAT(GetAllLoginsFromAccountPasswordStore(),
ElementsAre(MatchesLogin("user", "accountpass")));
// ...but also the one in the profile store should have been updated to match.
EXPECT_THAT(GetAllLoginsFromProfilePasswordStore(),
ElementsAre(MatchesLogin("user", "accountpass")));
}
IN_PROC_BROWSER_TEST_F(PasswordManagerSyncTest,
AutoUpdatePSLMatchInAccountStoreOnSuccessfulUse) {
ASSERT_TRUE(SetupClients());
// Add the same credential to both stores, but the account one is a PSL match
// (i.e. it's stored for psl.example.com instead of www.example.com).
AddCredentialToFakeServer(CreateTestPSLPasswordForm("user", "pass"));
AddLocalCredential(CreateTestPasswordForm("user", "pass"));
SetupSyncTransportWithPasswordAccountStorage();
content::WebContents* web_contents = GetNewTab(GetBrowser(0));
// Go to a form (on www.) and submit it with the saved credentials.
NavigateToFile(web_contents, kExampleHostname,
"/password/simple_password.html");
FillAndSubmitPasswordForm(web_contents, "user", "pass");
// Now the PSL-matched credential should have been automatically saved for
// www. as well (in the account store).
EXPECT_THAT(GetAllLoginsFromAccountPasswordStore(),
UnorderedElementsAre(
MatchesLoginAndRealm("user", "pass", GetWWWOrigin()),
MatchesLoginAndRealm("user", "pass", GetPSLOrigin())));
// In the profile store, there was already a credential for www. so nothing
// should have changed.
ASSERT_THAT(GetAllLoginsFromProfilePasswordStore(),
ElementsAre(MatchesLogin("user", "pass")));
}
IN_PROC_BROWSER_TEST_F(PasswordManagerSyncTest,
AutoUpdatePSLMatchInProfileStoreOnSuccessfulUse) {
ASSERT_TRUE(SetupClients());
// Add the same credential to both stores, but the local one is a PSL match
// (i.e. it's stored for psl.example.com instead of www.example.com).
AddCredentialToFakeServer(CreateTestPasswordForm("user", "pass"));
AddLocalCredential(CreateTestPSLPasswordForm("user", "pass"));
SetupSyncTransportWithPasswordAccountStorage();
content::WebContents* web_contents = GetNewTab(GetBrowser(0));
// Go to a form (on www.) and submit it with the saved credentials.
NavigateToFile(web_contents, kExampleHostname,
"/password/simple_password.html");
FillAndSubmitPasswordForm(web_contents, "user", "pass");
// Now the PSL-matched credential should have been automatically saved for
// www. as well (in the profile store).
EXPECT_THAT(GetAllLoginsFromProfilePasswordStore(),
UnorderedElementsAre(
MatchesLoginAndRealm("user", "pass", GetWWWOrigin()),
MatchesLoginAndRealm("user", "pass", GetPSLOrigin())));
// In the account store, there was already a credential for www. so nothing
// should have changed.
ASSERT_THAT(GetAllLoginsFromAccountPasswordStore(),
ElementsAre(MatchesLogin("user", "pass")));
}
IN_PROC_BROWSER_TEST_F(PasswordManagerSyncTest,
AutoUpdatePSLMatchInBothStoresOnSuccessfulUse) {
ASSERT_TRUE(SetupClients());
// Add the same PSL-matched credential to both stores (i.e. it's stored for
// psl.example.com instead of www.example.com).
AddCredentialToFakeServer(CreateTestPSLPasswordForm("user", "pass"));
AddLocalCredential(CreateTestPSLPasswordForm("user", "pass"));
SetupSyncTransportWithPasswordAccountStorage();
content::WebContents* web_contents = GetNewTab(GetBrowser(0));
// Go to a form (on www.) and submit it with the saved credentials.
NavigateToFile(web_contents, kExampleHostname,
"/password/simple_password.html");
FillAndSubmitPasswordForm(web_contents, "user", "pass");
// Now the PSL-matched credential should have been automatically saved for
// www. as well, in both stores.
EXPECT_THAT(GetAllLoginsFromAccountPasswordStore(),
UnorderedElementsAre(
MatchesLoginAndRealm("user", "pass", GetWWWOrigin()),
MatchesLoginAndRealm("user", "pass", GetPSLOrigin())));
EXPECT_THAT(GetAllLoginsFromProfilePasswordStore(),
UnorderedElementsAre(
MatchesLoginAndRealm("user", "pass", GetWWWOrigin()),
MatchesLoginAndRealm("user", "pass", GetPSLOrigin())));
}
IN_PROC_BROWSER_TEST_F(PasswordManagerSyncTest,
DontOfferToSavePrimaryAccountCredential) {
ASSERT_TRUE(SetupClients());
SetupSyncTransportWithPasswordAccountStorage();
content::WebContents* web_contents = GetNewTab(GetBrowser(0));
// Navigate to a Gaia signin form and submit a credential for the primary
// account.
NavigateToFileHttps(web_contents, "accounts.google.com",
"/password/simple_password.html");
FillAndSubmitPasswordForm(
web_contents,
GetClient(0)->GetEmailForAccount(SyncTestAccount::kDefaultAccount),
"pass");
// Since the submitted credential is for the primary account, Chrome should
// not offer to save it.
BubbleObserver bubble_observer(web_contents);
EXPECT_FALSE(bubble_observer.IsSavePromptAvailable());
}
IN_PROC_BROWSER_TEST_F(PasswordManagerSyncTest,
OfferToSaveNonPrimaryAccountCredential) {
// Disable signin interception, because it suppresses the password bubble.
// See PasswordManagerBrowserTestWithSigninInterception for tests with
// interception enabled.
g_browser_process->local_state()->SetBoolean(prefs::kBrowserAddPersonEnabled,
false);
ASSERT_TRUE(SetupClients());
SetupSyncTransportWithPasswordAccountStorage();
content::WebContents* web_contents = GetNewTab(GetBrowser(0));
// Navigate to a Gaia signin form and submit a credential for an account that
// is *not* the primary one.
NavigateToFileHttps(web_contents, "accounts.google.com",
"/password/simple_password.html");
// The call ensures that the form wasn't submitted too quickly before the
// password store returned something. Otherwise, the password prompt won't be
// shown.
GetAllLoginsFromProfilePasswordStore();
GetAllLoginsFromAccountPasswordStore();
FillAndSubmitPasswordForm(web_contents, "different-user@gmail.com", "pass");
// Since the submitted credential is *not* for the primary account, Chrome
// should offer to save it normally.
BubbleObserver bubble_observer(web_contents);
bubble_observer.WaitForAutomaticSavePrompt();
}
IN_PROC_BROWSER_TEST_F(PasswordManagerSyncTest,
OfferToUpdatePrimaryAccountCredential) {
ASSERT_TRUE(SetupClients());
// The password for the primary account is already saved.
AddLocalCredential(CreateTestPasswordForm(
GetClient(0)->GetEmailForAccount(SyncTestAccount::kDefaultAccount),
"pass", GetHttpsOrigin("accounts.google.com")));
SetupSyncTransportWithPasswordAccountStorage();
content::WebContents* web_contents = GetNewTab(GetBrowser(0));
// Navigate to a Gaia signin form and submit a new password for the primary
// account.
NavigateToFileHttps(web_contents, "accounts.google.com",
"/password/simple_password.html");
// The call ensures that the form wasn't submitted too quickly before the
// password store returned something. Otherwise, the password prompt won't be
// shown.
GetAllLoginsFromProfilePasswordStore();
GetAllLoginsFromAccountPasswordStore();
FillAndSubmitPasswordForm(
web_contents,
GetClient(0)->GetEmailForAccount(SyncTestAccount::kDefaultAccount),
"newpass");
// Since (an outdated version of) the credential is already saved, Chrome
// should offer to update it, even though it otherwise does *not* offer to
// save this credential.
BubbleObserver bubble_observer(web_contents);
bubble_observer.WaitForAutomaticUpdatePrompt();
}
IN_PROC_BROWSER_TEST_F(PasswordManagerSyncTest,
SignOutWithUnsyncedPasswordsOpensBubble) {
ASSERT_TRUE(SetupClients());
content::WebContents* web_contents = GetNewTab(GetBrowser(0));
SetupSyncTransportWithPasswordAccountStorage();
// Force credentials saved to the account to be unsynced.
GetFakeServer()->SetHttpError(net::HTTP_BAD_REQUEST);
NavigateToFile(web_contents, kExampleHostname,
"/password/password_form.html");
FillAndSubmitPasswordForm(web_contents, "accountuser", "accountpass");
// Save the password in the account store.
BubbleObserver bubble_observer(web_contents);
bubble_observer.AcceptSavePrompt();
std::vector<std::unique_ptr<password_manager::PasswordForm>>
account_credentials = GetAllLoginsFromAccountPasswordStore();
ASSERT_THAT(account_credentials,
ElementsAre(MatchesLogin("accountuser", "accountpass")));
SignOut();
bubble_observer.WaitForSaveUnsyncedCredentialsPrompt();
}
#if BUILDFLAG(ENABLE_DICE_SUPPORT)
// TODO(b/327118794): Delete this test once implicit signin no longer exists.
IN_PROC_BROWSER_TEST_F(PasswordManagerSyncTest, EnabledSettingSurvivesSignout) {
ASSERT_TRUE(SetupClients());
SignIn(SyncTestAccount::kDefaultAccount, /*explicit_signin=*/false);
ASSERT_FALSE(GetSyncService(0)->GetActiveDataTypes().Has(syncer::PASSWORDS));
GetSyncService(0)->GetUserSettings()->SetSelectedType(
syncer::UserSelectableType::kPasswords, true);
PasswordSyncActiveChecker(GetSyncService(0)).Wait();
SignOut();
PasswordSyncInactiveChecker(GetSyncService(0)).Wait();
// The enabling should be remembered.
SignIn(SyncTestAccount::kDefaultAccount, /*explicit_signin=*/false);
PasswordSyncActiveChecker(GetSyncService(0)).Wait();
}
IN_PROC_BROWSER_TEST_F(PasswordManagerSyncTest,
DisabledSettingSurvivesSignout) {
ASSERT_TRUE(SetupClients());
SignIn();
ASSERT_TRUE(GetSyncService(0)->GetActiveDataTypes().Has(syncer::PASSWORDS));
GetSyncService(0)->GetUserSettings()->SetSelectedType(
syncer::UserSelectableType::kPasswords, false);
PasswordSyncInactiveChecker(GetSyncService(0)).Wait();
SignOut();
// The disabling should be remembered.
SignIn();
PasswordSyncInactiveChecker(GetSyncService(0)).Wait();
}
IN_PROC_BROWSER_TEST_F(PasswordManagerSyncTest,
KeepnAccountStorageEnabledSettingOnlyForUsers) {
ASSERT_TRUE(SetupClients());
SignIn(SyncTestAccount::kConsumerAccount1, /*explicit_signin=*/false);
GetSyncService(0)->GetUserSettings()->SetSelectedType(
syncer::UserSelectableType::kPasswords, true);
const GaiaId first_gaia_id = GetSyncService(0)->GetAccountInfo().gaia;
SignOut();
SignIn(SyncTestAccount::kConsumerAccount2, /*explicit_signin=*/false);
GetSyncService(0)->GetUserSettings()->SetSelectedType(
syncer::UserSelectableType::kPasswords, true);
SignOut();
GetSyncService(0)->GetUserSettings()->KeepAccountSettingsPrefsOnlyForUsers(
{first_gaia_id});
SignIn(SyncTestAccount::kConsumerAccount1, /*explicit_signin=*/false);
EXPECT_TRUE(password_manager::features_util::IsAccountStorageEnabled(
GetProfile(0)->GetPrefs(), GetSyncService(0)));
SignOut();
SignIn(SyncTestAccount::kConsumerAccount2, /*explicit_signin=*/false);
EXPECT_FALSE(password_manager::features_util::IsAccountStorageEnabled(
GetProfile(0)->GetPrefs(), GetSyncService(0)));
}
IN_PROC_BROWSER_TEST_F(PasswordManagerSyncTest,
KeepAccountStorageDisabledSettingOnlyForUsers) {
ASSERT_TRUE(SetupClients());
SignIn(SyncTestAccount::kConsumerAccount1);
GetSyncService(0)->GetUserSettings()->SetSelectedType(
syncer::UserSelectableType::kPasswords, false);
const GaiaId first_gaia_id = GetSyncService(0)->GetAccountInfo().gaia;
SignOut();
SignIn(SyncTestAccount::kConsumerAccount2);
GetSyncService(0)->GetUserSettings()->SetSelectedType(
syncer::UserSelectableType::kPasswords, false);
SignOut();
GetSyncService(0)->GetUserSettings()->KeepAccountSettingsPrefsOnlyForUsers(
{first_gaia_id});
SignIn(SyncTestAccount::kConsumerAccount1);
EXPECT_FALSE(password_manager::features_util::IsAccountStorageEnabled(
GetProfile(0)->GetPrefs(), GetSyncService(0)));
SignOut();
SignIn(SyncTestAccount::kConsumerAccount2);
EXPECT_TRUE(password_manager::features_util::IsAccountStorageEnabled(
GetProfile(0)->GetPrefs(), GetSyncService(0)));
}
#endif // BUILDFLAG(ENABLE_DICE_SUPPORT)
// This test verifies that if such users delete passwords along with cookies,
// the password deletions are uploaded before the server connection is cut.
IN_PROC_BROWSER_TEST_F(PasswordManagerSyncTest,
PasswordDeletionsPropagateToServer) {
ASSERT_TRUE(SetupClients());
// Add credential to server.
AddCredentialToFakeServer(CreateTestPasswordForm("user", "pass"));
// Do implicit sign-in, so account storage is off by default.
SetupSyncTransportWithPasswordAccountStorage(/*explicit_signin=*/false);
password_manager::PasswordStoreInterface* account_store =
passwords_helper::GetAccountPasswordStoreInterface(0);
// Make sure the password show up in the account store and on the server.
ASSERT_EQ(passwords_helper::GetAllLogins(account_store).size(), 1u);
ASSERT_EQ(fake_server_->GetSyncEntitiesByDataType(syncer::PASSWORDS).size(),
1u);
EXPECT_TRUE(password_manager::features_util::IsAccountStorageEnabled(
GetProfile(0)->GetPrefs(), GetSyncService(0)));
// Clear cookies and account passwords.
content::BrowsingDataRemover* remover =
GetProfile(0)->GetBrowsingDataRemover();
content::BrowsingDataRemoverCompletionObserver observer(remover);
remover->RemoveAndReply(
base::Time(), base::Time::Max(),
chrome_browsing_data_remover::DATA_TYPE_SITE_DATA |
chrome_browsing_data_remover::DATA_TYPE_ACCOUNT_PASSWORDS,
content::BrowsingDataRemover::ORIGIN_TYPE_UNPROTECTED_WEB, &observer);
observer.BlockUntilCompletion();
// Now passwords should be removed from the client and server.
EXPECT_EQ(passwords_helper::GetAllLogins(account_store).size(), 0u);
EXPECT_EQ(fake_server_->GetSyncEntitiesByDataType(syncer::PASSWORDS).size(),
0u);
// Account storage is still enabled (because the user is still signed in).
EXPECT_TRUE(password_manager::features_util::IsAccountStorageEnabled(
GetProfile(0)->GetPrefs(), GetSyncService(0)));
// The preference is reset as the account is removed from Chrome.
SignOut();
EXPECT_FALSE(password_manager::features_util::IsAccountStorageEnabled(
GetProfile(0)->GetPrefs(), GetSyncService(0)));
}
// TODO(b/327118794): Delete this test once implicit signin no longer exists.
IN_PROC_BROWSER_TEST_F(PasswordManagerSyncTest,
PRE_ClearAccountStoreOnStartup) {
ASSERT_TRUE(SetupClients());
// Add a credential to the server.
AddCredentialToFakeServer(
CreateTestPasswordForm("accountuser", "accountpass"));
SetupSyncTransportWithPasswordAccountStorage(/*explicit_signin=*/false);
// Also add a credential to the profile store.
AddLocalCredential("localuser", "localpass");
ASSERT_THAT(GetAllLoginsFromProfilePasswordStore(),
ElementsAre(MatchesLogin("localuser", "localpass")));
ASSERT_THAT(GetAllLoginsFromAccountPasswordStore(),
ElementsAre(MatchesLogin("accountuser", "accountpass")));
}
// TODO(b/327118794): Delete this test once implicit signin no longer exists.
IN_PROC_BROWSER_TEST_F(PasswordManagerSyncTest, ClearAccountStoreOnStartup) {
// Before setting up the client (aka profile), manually set account storage to
// off in the profile's prefs file. This simulates the case where the user
// disabled account storage, but the account store was not cleared correctly,
// e.g. due to a poorly-timed crash.
base::FilePath user_data_dir;
base::PathService::Get(chrome::DIR_USER_DATA, &user_data_dir);
base::FilePath profile_path = user_data_dir.Append(GetProfileBaseName(0));
base::FilePath json_path = profile_path.Append(chrome::kPreferencesFilename);
{
base::ScopedAllowBlockingForTesting allow_blocking;
std::string json;
ASSERT_TRUE(base::ReadFileToString(json_path, &json));
std::optional<base::Value> prefs = base::JSONReader::Read(json);
ASSERT_TRUE(prefs.has_value());
ASSERT_TRUE(prefs->is_dict());
ASSERT_TRUE(prefs->GetDict().RemoveByDottedPath(
syncer::prefs::internal::kSelectedTypesPerAccount));
ASSERT_TRUE(base::JSONWriter::Write(*prefs, &json));
ASSERT_TRUE(base::WriteFile(json_path, json));
}
ASSERT_TRUE(SetupClients());
ASSERT_TRUE(GetClient(0)->AwaitSyncTransportActive());
// Since we mangled the prefs file, account storage should be disabled.
ASSERT_FALSE(password_manager::features_util::IsAccountStorageEnabled(
GetProfile(0)->GetPrefs(), GetSyncService(0)));
ASSERT_FALSE(GetSyncService(0)->GetActiveDataTypes().Has(syncer::PASSWORDS));
// The account-scoped store should have been cleared during startup, and the
// credential added by the PRE_ test should be gone.
EXPECT_THAT(GetAllLoginsFromAccountPasswordStore(), IsEmpty());
// Just as a sanity check: The credential in the profile-scoped store should
// still be there.
ASSERT_THAT(GetAllLoginsFromProfilePasswordStore(),
ElementsAre(MatchesLogin("localuser", "localpass")));
}
#endif // !BUILDFLAG(IS_CHROMEOS)
IN_PROC_BROWSER_TEST_F(PasswordManagerSyncTest, SyncUtilApis) {
ASSERT_TRUE(SetupSync());
EXPECT_TRUE(
password_manager::sync_util::IsSyncFeatureEnabledIncludingPasswords(
GetSyncService(0)));
EXPECT_TRUE(
password_manager::sync_util::IsSyncFeatureActiveIncludingPasswords(
GetSyncService(0)));
EXPECT_EQ(password_manager::sync_util::
GetAccountEmailIfSyncFeatureEnabledIncludingPasswords(
GetSyncService(0)),
GetClient(0)->GetEmailForAccount(SyncTestAccount::kDefaultAccount));
EXPECT_EQ(
password_manager::sync_util::GetPasswordSyncState(GetSyncService(0)),
password_manager::sync_util::SyncState::kActiveWithNormalEncryption);
// Enter a persistent auth error state.
GetClient(0)->EnterSyncPausedStateForPrimaryAccount();
// Passwords are not sync-ing actively while sync is paused (any persistent
// auth error).
EXPECT_FALSE(
password_manager::sync_util::IsSyncFeatureActiveIncludingPasswords(
GetSyncService(0)));
EXPECT_EQ(
password_manager::sync_util::GetPasswordSyncState(GetSyncService(0)),
password_manager::sync_util::SyncState::kNotActive);
// In the current implementation, the APIs below treat sync as enabled/active
// even while paused.
EXPECT_TRUE(
password_manager::sync_util::IsSyncFeatureEnabledIncludingPasswords(
GetSyncService(0)));
EXPECT_EQ(password_manager::sync_util::
GetAccountEmailIfSyncFeatureEnabledIncludingPasswords(
GetSyncService(0)),
GetClient(0)->GetEmailForAccount(SyncTestAccount::kDefaultAccount));
}
#if !BUILDFLAG(IS_CHROMEOS)
class PasswordManagerSyncTestWithPolicy : public PasswordManagerSyncTest {
public:
void SetUpInProcessBrowserTestFixture() override {
PasswordManagerSyncTest::SetUpInProcessBrowserTestFixture();
policy_provider_.SetDefaultReturns(
/*is_initialization_complete_return=*/true,
/*is_first_policy_load_complete_return=*/true);
policy::BrowserPolicyConnector::SetPolicyProviderForTesting(
&policy_provider_);
}
NiceMock<policy::MockConfigurationPolicyProvider>* policy_provider() {
return &policy_provider_;
}
private:
NiceMock<policy::MockConfigurationPolicyProvider> policy_provider_;
};
IN_PROC_BROWSER_TEST_F(PasswordManagerSyncTestWithPolicy,
SyncTypesListDisabled) {
ASSERT_TRUE(SetupClients());
SetupSyncTransportWithPasswordAccountStorage();
// Disable passwords via the kSyncTypesListDisabled policy.
base::Value::List disabled_types;
disabled_types.Append("passwords");
policy::PolicyMap policies;
policies.Set(policy::key::kSyncTypesListDisabled,
policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,
policy::POLICY_SOURCE_CLOUD,
base::Value(std::move(disabled_types)), nullptr);
policy_provider()->UpdateChromePolicy(policies);
SyncActiveWithoutPasswordsChecker(GetSyncService(0)).Wait();
}
IN_PROC_BROWSER_TEST_F(PasswordManagerSyncTest,
WipingAccountStoreUpdatesSavedPasswordsPresenter) {
// Set up one credential in the account store and one presenter.
ASSERT_TRUE(SetupClients());
AddCredentialToFakeServer("user", "pass");
SetupSyncTransportWithPasswordAccountStorage();
ASSERT_EQ(GetAllLoginsFromAccountPasswordStore().size(), 1u);
password_manager::SavedPasswordsPresenter presenter(
AffiliationServiceFactory::GetForProfile(GetProfile(0)),
ProfilePasswordStoreFactory::GetForProfile(
GetProfile(0), ServiceAccessType::EXPLICIT_ACCESS),
AccountPasswordStoreFactory::GetForProfile(
GetProfile(0), ServiceAccessType::EXPLICIT_ACCESS));
presenter.Init();
{
SavedPasswordsPresenterWaiter waiter(&presenter, 1);
waiter.Wait();
}
GetSyncService(0)->GetUserSettings()->SetSelectedType(
syncer::UserSelectableType::kPasswords, false);
{
SavedPasswordsPresenterWaiter waiter(&presenter, 0);
waiter.Wait();
}
}
#endif // !BUILDFLAG(IS_CHROMEOS)
} // namespace
|