1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894 1895 1896 1897 1898 1899 1900 1901 1902 1903 1904 1905 1906 1907 1908 1909 1910 1911 1912 1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931 1932 1933 1934 1935 1936 1937 1938 1939 1940 1941 1942 1943 1944 1945 1946 1947 1948 1949 1950 1951 1952 1953 1954 1955 1956 1957 1958 1959 1960 1961 1962 1963 1964 1965 1966 1967 1968 1969 1970 1971 1972 1973 1974 1975 1976 1977 1978 1979 1980 1981 1982 1983 1984 1985 1986 1987 1988 1989 1990 1991 1992 1993 1994 1995 1996 1997 1998 1999 2000 2001 2002 2003 2004 2005 2006 2007 2008 2009 2010 2011 2012 2013 2014 2015 2016 2017 2018 2019 2020 2021 2022 2023 2024 2025 2026 2027 2028 2029 2030 2031 2032 2033 2034 2035 2036 2037 2038 2039 2040 2041 2042 2043 2044 2045 2046 2047 2048 2049 2050 2051 2052 2053 2054 2055 2056 2057 2058 2059 2060 2061 2062 2063 2064 2065 2066 2067 2068 2069 2070 2071 2072 2073 2074 2075 2076 2077 2078 2079 2080 2081 2082 2083 2084 2085 2086 2087 2088 2089 2090 2091 2092 2093 2094 2095 2096 2097 2098 2099 2100 2101 2102 2103 2104 2105 2106 2107 2108 2109 2110 2111 2112 2113 2114 2115 2116 2117 2118 2119 2120 2121 2122 2123 2124 2125 2126 2127 2128 2129 2130 2131 2132 2133 2134 2135 2136 2137 2138 2139 2140 2141 2142 2143 2144 2145 2146 2147 2148 2149 2150 2151 2152 2153 2154 2155 2156 2157 2158 2159 2160 2161 2162 2163 2164 2165 2166 2167 2168 2169 2170 2171 2172 2173 2174 2175 2176 2177 2178 2179 2180 2181 2182 2183 2184 2185 2186 2187 2188 2189 2190 2191 2192 2193 2194 2195 2196 2197 2198 2199 2200 2201 2202 2203 2204 2205 2206 2207 2208 2209 2210 2211 2212 2213 2214 2215 2216 2217 2218 2219 2220 2221 2222 2223 2224 2225 2226 2227 2228 2229 2230 2231 2232 2233 2234 2235 2236 2237 2238 2239 2240 2241 2242 2243 2244 2245 2246 2247 2248 2249 2250 2251 2252 2253 2254 2255 2256 2257 2258 2259 2260 2261 2262 2263 2264 2265 2266 2267 2268 2269 2270 2271 2272 2273 2274 2275 2276 2277 2278 2279 2280 2281 2282 2283 2284 2285 2286 2287 2288 2289 2290 2291 2292 2293 2294 2295 2296 2297 2298 2299 2300 2301 2302 2303 2304 2305 2306 2307 2308 2309 2310 2311 2312 2313 2314 2315 2316 2317 2318 2319 2320 2321 2322 2323 2324 2325 2326 2327 2328 2329 2330 2331 2332 2333 2334 2335 2336 2337 2338 2339 2340 2341 2342 2343 2344 2345 2346 2347 2348 2349 2350 2351 2352 2353 2354 2355 2356 2357 2358 2359 2360 2361 2362 2363 2364 2365 2366 2367 2368 2369 2370 2371 2372 2373 2374 2375 2376 2377 2378 2379 2380 2381 2382 2383 2384 2385 2386 2387 2388 2389 2390 2391 2392 2393 2394 2395 2396 2397 2398 2399 2400 2401 2402 2403 2404 2405 2406 2407 2408 2409 2410 2411 2412 2413 2414 2415 2416 2417 2418 2419 2420 2421 2422 2423 2424 2425 2426 2427 2428 2429 2430 2431 2432 2433 2434 2435 2436 2437 2438 2439 2440 2441 2442 2443 2444 2445 2446 2447 2448 2449 2450 2451 2452 2453 2454 2455 2456 2457 2458 2459 2460 2461 2462 2463 2464 2465 2466 2467 2468 2469 2470 2471 2472 2473 2474 2475 2476 2477 2478 2479 2480 2481 2482 2483 2484 2485 2486 2487 2488 2489 2490 2491 2492 2493 2494 2495 2496 2497 2498 2499 2500 2501 2502 2503 2504 2505 2506 2507 2508 2509 2510 2511 2512 2513 2514 2515 2516 2517 2518 2519 2520 2521 2522 2523 2524 2525 2526 2527 2528 2529 2530 2531 2532 2533 2534 2535 2536 2537 2538 2539 2540 2541 2542 2543 2544 2545 2546 2547 2548 2549 2550 2551 2552 2553 2554 2555 2556 2557 2558 2559 2560 2561 2562 2563 2564 2565 2566 2567 2568 2569 2570 2571 2572 2573 2574 2575 2576 2577 2578 2579 2580 2581 2582 2583 2584 2585 2586 2587 2588 2589 2590 2591 2592 2593 2594 2595 2596 2597 2598 2599 2600 2601 2602 2603 2604 2605 2606 2607 2608 2609 2610 2611 2612 2613 2614 2615 2616 2617 2618 2619 2620 2621 2622 2623 2624 2625 2626 2627 2628 2629 2630 2631 2632 2633 2634 2635 2636 2637 2638 2639 2640 2641 2642 2643 2644 2645 2646 2647 2648 2649 2650 2651 2652 2653 2654 2655 2656 2657 2658 2659 2660 2661 2662 2663 2664 2665 2666 2667 2668 2669 2670 2671 2672 2673 2674 2675 2676 2677 2678 2679 2680 2681 2682 2683 2684 2685 2686 2687 2688 2689 2690 2691 2692 2693 2694 2695 2696 2697 2698 2699 2700 2701 2702 2703 2704 2705 2706 2707 2708 2709 2710 2711 2712 2713 2714 2715 2716 2717 2718 2719 2720 2721 2722 2723 2724 2725 2726 2727 2728 2729 2730 2731 2732 2733 2734 2735 2736 2737 2738 2739 2740 2741 2742 2743 2744 2745 2746 2747 2748 2749 2750 2751 2752 2753 2754 2755 2756 2757 2758 2759 2760 2761 2762 2763 2764 2765 2766 2767 2768 2769 2770 2771 2772 2773 2774 2775 2776 2777 2778 2779 2780 2781 2782 2783 2784 2785 2786 2787 2788 2789 2790 2791 2792 2793 2794 2795 2796 2797 2798 2799 2800 2801 2802 2803 2804 2805 2806 2807 2808 2809 2810 2811 2812 2813 2814 2815 2816 2817 2818 2819 2820 2821 2822 2823 2824 2825 2826 2827 2828 2829 2830 2831 2832 2833 2834 2835 2836 2837 2838 2839 2840 2841 2842 2843 2844 2845 2846 2847 2848 2849 2850 2851 2852 2853 2854 2855 2856 2857 2858 2859 2860 2861 2862 2863 2864 2865 2866 2867 2868 2869 2870 2871 2872 2873 2874 2875 2876 2877 2878 2879 2880 2881 2882 2883 2884 2885 2886 2887 2888 2889 2890 2891 2892 2893 2894 2895 2896 2897 2898 2899 2900 2901 2902 2903 2904 2905 2906 2907 2908 2909 2910 2911 2912 2913 2914 2915 2916 2917 2918 2919 2920 2921 2922 2923 2924 2925 2926 2927 2928 2929 2930 2931 2932 2933 2934 2935 2936 2937 2938 2939 2940 2941 2942 2943 2944 2945 2946 2947 2948 2949 2950 2951 2952 2953 2954 2955 2956 2957 2958 2959 2960 2961 2962 2963 2964 2965 2966 2967 2968 2969 2970 2971 2972 2973 2974 2975 2976 2977 2978 2979 2980 2981 2982 2983 2984 2985 2986 2987 2988 2989 2990 2991 2992 2993 2994 2995 2996 2997 2998 2999 3000 3001 3002 3003 3004 3005 3006 3007 3008 3009 3010 3011 3012 3013 3014 3015 3016 3017 3018 3019 3020 3021 3022 3023 3024 3025 3026 3027 3028 3029 3030 3031 3032 3033 3034 3035 3036 3037 3038 3039 3040 3041 3042 3043 3044 3045 3046 3047 3048 3049 3050 3051 3052 3053 3054 3055 3056 3057 3058 3059 3060 3061 3062 3063 3064 3065 3066 3067 3068 3069 3070 3071 3072 3073 3074 3075 3076 3077 3078 3079 3080 3081 3082 3083 3084 3085 3086 3087 3088 3089 3090 3091 3092 3093 3094 3095 3096 3097 3098 3099 3100 3101 3102 3103 3104 3105 3106 3107 3108 3109 3110 3111 3112 3113 3114 3115 3116 3117 3118 3119 3120 3121 3122 3123 3124 3125 3126 3127 3128 3129 3130 3131 3132 3133 3134 3135 3136 3137 3138 3139 3140 3141 3142 3143 3144 3145 3146 3147 3148 3149 3150 3151 3152 3153 3154 3155 3156 3157 3158 3159 3160 3161 3162 3163 3164 3165 3166 3167 3168 3169 3170 3171 3172 3173 3174 3175 3176 3177 3178 3179 3180 3181 3182 3183 3184 3185 3186 3187 3188 3189 3190 3191 3192 3193 3194 3195 3196 3197 3198 3199 3200 3201 3202 3203 3204 3205 3206 3207 3208 3209 3210 3211 3212 3213 3214 3215 3216 3217 3218 3219 3220 3221 3222 3223 3224 3225 3226 3227 3228 3229 3230 3231 3232 3233 3234 3235 3236 3237 3238 3239 3240 3241 3242 3243 3244 3245 3246 3247 3248 3249 3250 3251 3252 3253 3254 3255
|
// Copyright 2012 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <memory>
#include <utility>
#include "base/functional/bind.h"
#include "base/hash/hash.h"
#include "base/memory/ref_counted_memory.h"
#include "base/metrics/statistics_recorder.h"
#include "base/strings/string_util.h"
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"
#include "base/test/metrics/histogram_tester.h"
#include "base/test/scoped_feature_list.h"
#include "base/time/time.h"
#include "base/uuid.h"
#include "build/build_config.h"
#include "build/buildflag.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/sync/account_bookmark_sync_service_factory.h"
#include "chrome/browser/sync/device_info_sync_service_factory.h"
#include "chrome/browser/sync/local_or_syncable_bookmark_sync_service_factory.h"
#include "chrome/browser/sync/sync_invalidations_service_factory.h"
#include "chrome/browser/sync/test/integration/bookmarks_helper.h"
#include "chrome/browser/sync/test/integration/committed_all_nudged_changes_checker.h"
#include "chrome/browser/sync/test/integration/single_client_status_change_checker.h"
#include "chrome/browser/sync/test/integration/sync_service_impl_harness.h"
#include "chrome/browser/sync/test/integration/sync_test.h"
#include "chrome/browser/sync/test/integration/updated_progress_marker_checker.h"
#include "components/bookmarks/browser/bookmark_model.h"
#include "components/bookmarks/browser/bookmark_node.h"
#include "components/bookmarks/browser/url_and_title.h"
#include "components/bookmarks/common/bookmark_metrics.h"
#include "components/bookmarks/test/test_matchers.h"
#include "components/browser_sync/browser_sync_switches.h"
#include "components/keyed_service/content/browser_context_dependency_manager.h"
#include "components/keyed_service/core/keyed_service.h"
#include "components/signin/public/base/signin_prefs.h"
#include "components/signin/public/base/signin_switches.h"
#include "components/sync/base/client_tag_hash.h"
#include "components/sync/base/command_line_switches.h"
#include "components/sync/base/data_type.h"
#include "components/sync/base/features.h"
#include "components/sync/engine/bookmark_update_preprocessing.h"
#include "components/sync/engine/cycle/entity_change_metric_recording.h"
#include "components/sync/engine/loopback_server/loopback_server_entity.h"
#include "components/sync/invalidations/interested_data_types_handler.h"
#include "components/sync/invalidations/sync_invalidations_service.h"
#include "components/sync/protocol/bookmark_specifics.pb.h"
#include "components/sync/protocol/entity_specifics.pb.h"
#include "components/sync/protocol/sync_entity.pb.h"
#include "components/sync/service/sync_service_impl.h"
#include "components/sync/service/sync_user_settings.h"
#include "components/sync/test/bookmark_entity_builder.h"
#include "components/sync/test/entity_builder_factory.h"
#include "components/sync/test/fake_server.h"
#include "components/sync/test/fake_server_http_post_provider.h"
#include "components/sync/test/fake_server_verifier.h"
#include "components/sync/test/test_matchers.h"
#include "components/sync_bookmarks/bookmark_sync_service.h"
#include "components/sync_bookmarks/switches.h"
#include "components/sync_device_info/fake_device_info_sync_service.h"
#include "components/undo/bookmark_undo_service.h"
#include "components/version_info/version_info.h"
#include "content/public/test/browser_test.h"
#include "content/public/test/test_launcher.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/base/resource/resource_scale_factor.h"
namespace {
using bookmarks::BookmarkModel;
using bookmarks::BookmarkNode;
using bookmarks::test::IsFolder;
using bookmarks::test::IsUrlBookmark;
using bookmarks_helper::AddFolder;
using bookmarks_helper::AddURL;
using bookmarks_helper::BookmarkFaviconLoadedChecker;
using bookmarks_helper::BookmarkModelMatchesFakeServerChecker;
using bookmarks_helper::BookmarksTitleChecker;
using bookmarks_helper::BookmarksUrlChecker;
using bookmarks_helper::BookmarksUuidChecker;
using bookmarks_helper::CheckHasNoFavicon;
using bookmarks_helper::ContainsBookmarkNodeWithUuid;
using bookmarks_helper::CountBookmarksWithTitlesMatching;
using bookmarks_helper::CountBookmarksWithUrlsMatching;
using bookmarks_helper::CountFoldersWithTitlesMatching;
using bookmarks_helper::Create1xFaviconFromPNGFile;
using bookmarks_helper::CreateFavicon;
using bookmarks_helper::GetBookmarkBarNode;
using bookmarks_helper::GetBookmarkModel;
using bookmarks_helper::GetBookmarkUndoService;
using bookmarks_helper::GetOtherNode;
using bookmarks_helper::GetUniqueNodeByURL;
using bookmarks_helper::Move;
using bookmarks_helper::Remove;
using bookmarks_helper::SetFavicon;
using bookmarks_helper::SetTitle;
using BookmarkGeneration =
fake_server::BookmarkEntityBuilder::BookmarkGeneration;
using syncer::MatchesDeletionOrigin;
using syncer::MatchesLocalDataDescription;
using syncer::MatchesLocalDataItemModel;
using testing::_;
using testing::AllOf;
using testing::Contains;
using testing::Each;
using testing::ElementsAre;
using testing::Eq;
using testing::IsEmpty;
using testing::IsNull;
using testing::Not;
using testing::NotNull;
using testing::Pointee;
using testing::SizeIs;
// All tests in this file utilize a single profile.
// TODO(pvalenzuela): Standardize this pattern by moving this constant to
// SyncTest and using it in all single client tests.
constexpr int kSingleProfileIndex = 0;
#if !BUILDFLAG(IS_ANDROID)
// An arbitrary GUID, to be used for injecting the same bookmark entity to the
// fake server across PRE_MyTest and MyTest.
constexpr char kBookmarkGuid[] = "e397ed62-9532-4dbf-ae55-200236eba15c";
#endif // !BUILDFLAG(IS_ANDROID)
// A title and a URL which are used across PRE_MyTest and MyTest.
constexpr char16_t kBookmarkTitle[] = u"Title";
constexpr char kBookmarkPageUrl[] = "http://www.foo.com/";
#if !BUILDFLAG(IS_ANDROID) && !BUILDFLAG(IS_CHROMEOS)
constexpr char kPreviouslySyncingGaiaIdMetricName[] =
"Sync.BookmarkModelMerger.PreviouslySyncingGaiaId";
#endif // !BUILDFLAG(IS_ANDROID) && !BUILDFLAG(IS_CHROMEOS)
MATCHER(HasUniquePosition, "") {
return arg.specifics().bookmark().has_unique_position();
}
// Fake device info sync service that does the necessary setup to be used in a
// SyncTest. It basically disables DEVICE_INFO commits.
class FakeDeviceInfoSyncServiceWithInvalidations
: public syncer::FakeDeviceInfoSyncService,
public syncer::InterestedDataTypesHandler {
public:
explicit FakeDeviceInfoSyncServiceWithInvalidations(
syncer::SyncInvalidationsService* sync_invalidations_service)
: syncer::FakeDeviceInfoSyncService(/*skip_engine_connection=*/true),
sync_invalidations_service_(sync_invalidations_service) {
sync_invalidations_service_->SetInterestedDataTypesHandler(this);
}
~FakeDeviceInfoSyncServiceWithInvalidations() override {
sync_invalidations_service_->SetInterestedDataTypesHandler(nullptr);
}
// InterestedDataTypesHandler implementation.
void OnInterestedDataTypesChanged() override {}
void SetCommittedAdditionalInterestedDataTypesCallback(
base::RepeatingCallback<void(const syncer::DataTypeSet&)> callback)
override {}
private:
const raw_ptr<syncer::SyncInvalidationsService> sync_invalidations_service_;
};
std::unique_ptr<KeyedService> BuildFakeDeviceInfoSyncService(
content::BrowserContext* context) {
return std::make_unique<FakeDeviceInfoSyncServiceWithInvalidations>(
SyncInvalidationsServiceFactory::GetForProfile(
Profile::FromBrowserContext(context)));
}
// Waits until the tasks posted by the error handler have been processed.
class BookmarksDataTypeErrorChecker : public SingleClientStatusChangeChecker {
public:
using SingleClientStatusChangeChecker::SingleClientStatusChangeChecker;
bool IsExitConditionSatisfied(std::ostream* os) override {
*os << "Waiting for Bookmarks data type error.";
return service()->HasAnyModelErrorForTest({syncer::BOOKMARKS});
}
};
class SingleClientBookmarksSyncTest : public SyncTest {
public:
SingleClientBookmarksSyncTest() : SyncTest(SINGLE_CLIENT) {}
SingleClientBookmarksSyncTest(const SingleClientBookmarksSyncTest&) = delete;
SingleClientBookmarksSyncTest& operator=(
const SingleClientBookmarksSyncTest&) = delete;
~SingleClientBookmarksSyncTest() override = default;
};
class SingleClientBookmarksSyncTestWithEnabledReuploadBookmarks
: public SyncTest {
public:
SingleClientBookmarksSyncTestWithEnabledReuploadBookmarks()
: SyncTest(SINGLE_CLIENT) {
features_override_.InitAndEnableFeature(switches::kSyncReuploadBookmarks);
}
private:
base::test::ScopedFeatureList features_override_;
};
class SingleClientBookmarksSyncTestWithDisabledReuploadBookmarks
: public SyncTest {
public:
SingleClientBookmarksSyncTestWithDisabledReuploadBookmarks()
: SyncTest(SINGLE_CLIENT) {
features_override_.InitAndDisableFeature(switches::kSyncReuploadBookmarks);
}
private:
base::test::ScopedFeatureList features_override_;
};
class SingleClientBookmarksSyncTestWithEnabledReuploadPreexistingBookmarks
: public SingleClientBookmarksSyncTest {
public:
SingleClientBookmarksSyncTestWithEnabledReuploadPreexistingBookmarks() {
features_override_.InitWithFeatureState(switches::kSyncReuploadBookmarks,
!content::IsPreTest());
}
private:
base::test::ScopedFeatureList features_override_;
};
class SingleClientBookmarksSyncTestWithEnabledClientTagHashMigration
: public SyncTest {
public:
SingleClientBookmarksSyncTestWithEnabledClientTagHashMigration()
: SyncTest(SINGLE_CLIENT) {
features_override_.InitAndEnableFeature(
switches::kSyncMigrateBookmarksWithoutClientTagHash);
}
private:
base::test::ScopedFeatureList features_override_;
};
class SingleClientBookmarksThrottlingSyncTest : public SyncTest {
public:
SingleClientBookmarksThrottlingSyncTest() : SyncTest(SINGLE_CLIENT) {}
void SetUpInProcessBrowserTestFixture() override {
SyncTest::SetUpInProcessBrowserTestFixture();
create_services_subscription_ =
BrowserContextDependencyManager::GetInstance()
->RegisterCreateServicesCallbackForTesting(
base::BindRepeating(&SingleClientBookmarksThrottlingSyncTest::
OnWillCreateBrowserContextServices,
base::Unretained(this)));
}
void OnWillCreateBrowserContextServices(content::BrowserContext* context) {
// Fake DeviceInfoSyncService with its fake bridge for device info to make
// sure there are no device info commits interfering with the extended nudge
// delay.
DeviceInfoSyncServiceFactory::GetInstance()->SetTestingFactory(
context, base::BindRepeating(&BuildFakeDeviceInfoSyncService));
}
// Rarely, self notification for nigori interferes with the
// DepleteQuotaAndRecover test causing the tested commit to happen too early.
bool TestUsesSelfNotifications() override { return false; }
void SetupBookmarksSync() {
// Only enable bookmarks so that sync is not nudged by another data type
// (with a shorter delay).
ASSERT_TRUE(GetClient(0)->SetupSyncWithCustomSettings(
base::BindOnce([](syncer::SyncUserSettings* user_settings) {
user_settings->SetSelectedTypes(
false, {syncer::UserSelectableType::kBookmarks});
#if BUILDFLAG(IS_CHROMEOS)
user_settings->SetSelectedOsTypes(false, {});
#else // BUILDFLAG(IS_CHROMEOS)
user_settings->SetInitialSyncFeatureSetupComplete(
syncer::SyncFirstSetupCompleteSource::ADVANCED_FLOW_CONFIRM);
#endif // BUILDFLAG(IS_CHROMEOS)
})));
}
private:
base::CallbackListSubscription create_services_subscription_;
};
IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest, Sanity) {
ASSERT_TRUE(SetupClients());
// Starting state:
// other_node
// -> top
// -> tier1_a
// -> http://mail.google.com "tier1_a_url0"
// -> http://www.pandora.com "tier1_a_url1"
// -> http://www.facebook.com "tier1_a_url2"
// -> tier1_b
// -> http://www.nhl.com "tier1_b_url0"
const BookmarkNode* other_node = GetOtherNode(kSingleProfileIndex);
const BookmarkNode* top =
AddFolder(kSingleProfileIndex, other_node, 0, u"top");
const BookmarkNode* tier1_a =
AddFolder(kSingleProfileIndex, top, 0, u"tier1_a");
const BookmarkNode* tier1_b =
AddFolder(kSingleProfileIndex, top, 1, u"tier1_b");
const BookmarkNode* tier1_a_url0 =
AddURL(kSingleProfileIndex, tier1_a, 0, u"tier1_a_url0",
GURL("http://mail.google.com"));
const BookmarkNode* tier1_a_url1 =
AddURL(kSingleProfileIndex, tier1_a, 1, u"tier1_a_url1",
GURL("http://www.pandora.com"));
const BookmarkNode* tier1_a_url2 =
AddURL(kSingleProfileIndex, tier1_a, 2, u"tier1_a_url2",
GURL("http://www.facebook.com"));
const BookmarkNode* tier1_b_url0 =
AddURL(kSingleProfileIndex, tier1_b, 0, u"tier1_b_url0",
GURL("http://www.nhl.com"));
// Setup sync, wait for its completion, and make sure changes were synced.
ASSERT_TRUE(SetupSync());
ASSERT_TRUE(BookmarkModelMatchesFakeServerChecker(
kSingleProfileIndex, GetSyncService(kSingleProfileIndex),
GetFakeServer())
.Wait());
EXPECT_THAT(
other_node->children(),
ElementsAre(IsFolder(
u"top",
ElementsAre(
IsFolder(
u"tier1_a",
ElementsAre(IsUrlBookmark(u"tier1_a_url0",
GURL("http://mail.google.com")),
IsUrlBookmark(u"tier1_a_url1",
GURL("http://www.pandora.com")),
IsUrlBookmark(u"tier1_a_url2",
GURL("http://www.facebook.com")))),
IsFolder(u"tier1_b",
ElementsAre(IsUrlBookmark(
u"tier1_b_url0", GURL("http://www.nhl.com"))))))));
// Ultimately we want to end up with the following model; but this test is
// more about the journey than the destination.
//
// bookmark_bar
// -> CNN (www.cnn.com)
// -> tier1_a
// -> tier1_a_url2 (www.facebook.com)
// -> tier1_a_url1 (www.pandora.com)
// -> Porsche (www.porsche.com)
// -> Bank of America (www.bankofamerica.com)
// -> Wikipedia
// other_node
// -> top
// -> tier1_b
// -> Wired News (www.wired.com)
// -> tier2_b
// -> tier1_b_url0
// -> tier3_b
// -> Toronto Maple Leafs (mapleleafs.nhl.com)
// -> Wynn (www.wynnlasvegas.com)
// -> tier1_a_url0
const BookmarkNode* bar = GetBookmarkBarNode(kSingleProfileIndex);
const BookmarkNode* cnn =
AddURL(kSingleProfileIndex, bar, 0, u"CNN", GURL("http://www.cnn.com"));
ASSERT_NE(nullptr, cnn);
Move(kSingleProfileIndex, tier1_a, bar, 1);
// Wait for the bookmark position change to sync.
ASSERT_TRUE(BookmarkModelMatchesFakeServerChecker(
kSingleProfileIndex, GetSyncService(kSingleProfileIndex),
GetFakeServer())
.Wait());
EXPECT_THAT(bar->children(),
ElementsAre(IsUrlBookmark(u"CNN", GURL("http://www.cnn.com")),
IsFolder(u"tier1_a")));
EXPECT_THAT(top->children(), ElementsAre(IsFolder(u"tier1_b")));
const BookmarkNode* porsche = AddURL(kSingleProfileIndex, bar, 2, u"Porsche",
GURL("http://www.porsche.com"));
// Rearrange stuff in tier1_a.
ASSERT_EQ(tier1_a, tier1_a_url2->parent());
ASSERT_EQ(tier1_a, tier1_a_url1->parent());
Move(kSingleProfileIndex, tier1_a_url2, tier1_a, 0);
Move(kSingleProfileIndex, tier1_a_url1, tier1_a, 2);
// Wait for the rearranged hierarchy to sync.
ASSERT_TRUE(BookmarkModelMatchesFakeServerChecker(
kSingleProfileIndex, GetSyncService(kSingleProfileIndex),
GetFakeServer())
.Wait());
EXPECT_THAT(
bar->children(),
ElementsAre(
IsUrlBookmark(u"CNN", GURL("http://www.cnn.com")),
IsFolder(u"tier1_a",
ElementsAre(IsUrlBookmark(u"tier1_a_url2",
GURL("http://www.facebook.com")),
IsUrlBookmark(u"tier1_a_url0",
GURL("http://mail.google.com")),
IsUrlBookmark(u"tier1_a_url1",
GURL("http://www.pandora.com")))),
IsUrlBookmark(u"Porsche", GURL("http://www.porsche.com"))));
ASSERT_EQ(1u, tier1_a_url0->parent()->GetIndexOf(tier1_a_url0));
Move(kSingleProfileIndex, tier1_a_url0, bar, bar->children().size());
const BookmarkNode* boa =
AddURL(kSingleProfileIndex, bar, bar->children().size(),
u"Bank of America", GURL("https://www.bankofamerica.com"));
ASSERT_NE(nullptr, boa);
Move(kSingleProfileIndex, tier1_a_url0, top, top->children().size());
const BookmarkNode* bubble =
AddURL(kSingleProfileIndex, bar, bar->children().size(), u"Wikipedia",
GURL("http://wikipedia.org"));
ASSERT_NE(nullptr, bubble);
const BookmarkNode* wired = AddURL(kSingleProfileIndex, bar, 2, u"Wired News",
GURL("http://www.wired.com"));
const BookmarkNode* tier2_b =
AddFolder(kSingleProfileIndex, tier1_b, 0, u"tier2_b");
Move(kSingleProfileIndex, tier1_b_url0, tier2_b, 0);
Move(kSingleProfileIndex, porsche, bar, 0);
SetTitle(kSingleProfileIndex, wired, u"News Wired");
SetTitle(kSingleProfileIndex, porsche, u"ICanHazPorsche?");
// Wait for the title change to sync.
ASSERT_TRUE(BookmarkModelMatchesFakeServerChecker(
kSingleProfileIndex, GetSyncService(kSingleProfileIndex),
GetFakeServer())
.Wait());
EXPECT_THAT(
bar->children(),
ElementsAre(
IsUrlBookmark(u"ICanHazPorsche?", GURL("http://www.porsche.com")),
IsUrlBookmark(u"CNN", GURL("http://www.cnn.com")),
IsFolder(u"tier1_a"),
IsUrlBookmark(u"News Wired", GURL("http://www.wired.com")),
IsUrlBookmark(u"Bank of America",
GURL("https://www.bankofamerica.com")),
IsUrlBookmark(u"Wikipedia", GURL("http://wikipedia.org"))));
EXPECT_THAT(
tier1_a->children(),
ElementsAre(
IsUrlBookmark(u"tier1_a_url2", GURL("http://www.facebook.com")),
IsUrlBookmark(u"tier1_a_url1", GURL("http://www.pandora.com"))));
EXPECT_THAT(
top->children(),
ElementsAre(
IsFolder(u"tier1_b",
ElementsAre(IsFolder(
u"tier2_b",
ElementsAre(IsUrlBookmark(
u"tier1_b_url0", GURL("http://www.nhl.com")))))),
IsUrlBookmark(u"tier1_a_url0", GURL("http://mail.google.com"))));
ASSERT_EQ(tier1_a_url0->id(), top->children().back()->id());
Remove(kSingleProfileIndex, top, top->children().size() - 1);
Move(kSingleProfileIndex, wired, tier1_b, 0);
Move(kSingleProfileIndex, porsche, bar, 3);
const BookmarkNode* tier3_b =
AddFolder(kSingleProfileIndex, tier2_b, 1, u"tier3_b");
const BookmarkNode* leafs =
AddURL(kSingleProfileIndex, tier1_a, 0, u"Toronto Maple Leafs",
GURL("http://mapleleafs.nhl.com"));
const BookmarkNode* wynn = AddURL(kSingleProfileIndex, bar, 1, u"Wynn",
GURL("http://www.wynnlasvegas.com"));
Move(kSingleProfileIndex, wynn, tier3_b, 0);
Move(kSingleProfileIndex, leafs, tier3_b, 0);
// Wait for newly added bookmarks to sync.
ASSERT_TRUE(BookmarkModelMatchesFakeServerChecker(
kSingleProfileIndex, GetSyncService(kSingleProfileIndex),
GetFakeServer())
.Wait());
EXPECT_THAT(
bar->children(),
ElementsAre(
IsUrlBookmark(u"CNN", GURL("http://www.cnn.com")),
IsFolder(u"tier1_a",
ElementsAre(IsUrlBookmark(u"tier1_a_url2",
GURL("http://www.facebook.com")),
IsUrlBookmark(u"tier1_a_url1",
GURL("http://www.pandora.com")))),
IsUrlBookmark(u"ICanHazPorsche?", GURL("http://www.porsche.com")),
IsUrlBookmark(u"Bank of America",
GURL("https://www.bankofamerica.com")),
IsUrlBookmark(u"Wikipedia", GURL("http://wikipedia.org"))));
EXPECT_THAT(
top->children(),
ElementsAre(IsFolder(
u"tier1_b",
ElementsAre(
IsUrlBookmark(u"News Wired", GURL("http://www.wired.com")),
IsFolder(
u"tier2_b",
ElementsAre(
IsUrlBookmark(u"tier1_b_url0",
GURL("http://www.nhl.com")),
IsFolder(
u"tier3_b",
ElementsAre(
IsUrlBookmark(u"Toronto Maple Leafs",
GURL("http://mapleleafs.nhl.com")),
IsUrlBookmark(
u"Wynn",
GURL("http://www.wynnlasvegas.com"))))))))));
}
IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest, CommitLocalCreations) {
ASSERT_TRUE(SetupClients());
// Starting state:
// other_node
// -> top
// -> tier1_a
// -> http://mail.google.com "tier1_a_url0"
// -> http://www.pandora.com "tier1_a_url1"
// -> http://www.facebook.com "tier1_a_url2"
// -> tier1_b
// -> http://www.nhl.com "tier1_b_url0"
const BookmarkNode* other_node = GetOtherNode(kSingleProfileIndex);
const BookmarkNode* top =
AddFolder(kSingleProfileIndex, other_node, 0, u"top");
const BookmarkNode* tier1_a =
AddFolder(kSingleProfileIndex, top, 0, u"tier1_a");
const BookmarkNode* tier1_b =
AddFolder(kSingleProfileIndex, top, 1, u"tier1_b");
const BookmarkNode* tier1_a_url0 =
AddURL(kSingleProfileIndex, tier1_a, 0, u"tier1_a_url0",
GURL("http://mail.google.com"));
const BookmarkNode* tier1_a_url1 =
AddURL(kSingleProfileIndex, tier1_a, 1, u"tier1_a_url1",
GURL("http://www.pandora.com"));
const BookmarkNode* tier1_a_url2 =
AddURL(kSingleProfileIndex, tier1_a, 2, u"tier1_a_url2",
GURL("http://www.facebook.com"));
const BookmarkNode* tier1_b_url0 =
AddURL(kSingleProfileIndex, tier1_b, 0, u"tier1_b_url0",
GURL("http://www.nhl.com"));
EXPECT_TRUE(tier1_a_url0);
EXPECT_TRUE(tier1_a_url1);
EXPECT_TRUE(tier1_a_url2);
EXPECT_TRUE(tier1_b_url0);
// Setup sync, wait for its completion, and make sure changes were synced.
ASSERT_TRUE(SetupSync());
EXPECT_TRUE(BookmarkModelMatchesFakeServerChecker(
kSingleProfileIndex, GetSyncService(kSingleProfileIndex),
GetFakeServer())
.Wait());
EXPECT_THAT(
other_node->children(),
ElementsAre(IsFolder(
u"top",
ElementsAre(
IsFolder(
u"tier1_a",
ElementsAre(
IsUrlBookmark(u"tier1_a_url0", "http://mail.google.com/"),
IsUrlBookmark(u"tier1_a_url1", "http://www.pandora.com/"),
IsUrlBookmark(u"tier1_a_url2",
"http://www.facebook.com/"))),
IsFolder(u"tier1_b",
ElementsAre(IsUrlBookmark(u"tier1_b_url0",
"http://www.nhl.com/")))))));
}
IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest, InjectedBookmark) {
std::u16string title = u"Montreal Canadiens";
fake_server::EntityBuilderFactory entity_builder_factory;
fake_server::BookmarkEntityBuilder bookmark_builder =
entity_builder_factory.NewBookmarkEntityBuilder(title);
fake_server_->InjectEntity(
bookmark_builder.BuildBookmark(GURL("http://canadiens.nhl.com")));
ASSERT_TRUE(SetupSync());
EXPECT_EQ(1u, CountBookmarksWithTitlesMatching(kSingleProfileIndex, title));
}
IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest,
DownloadTwoPre2015BookmarksWithSameItemId) {
const std::u16string title1 = u"Title1";
const std::u16string title2 = u"Title2";
fake_server::EntityBuilderFactory entity_builder_factory1;
fake_server::EntityBuilderFactory entity_builder_factory2;
// Mimic the creation of two bookmarks from two different devices, with the
// same client item ID.
fake_server::BookmarkEntityBuilder bookmark_builder1 =
entity_builder_factory1.NewBookmarkEntityBuilder(title1)
.SetOriginatorClientItemId("1");
fake_server::BookmarkEntityBuilder bookmark_builder2 =
entity_builder_factory2.NewBookmarkEntityBuilder(title2)
.SetOriginatorClientItemId("1");
fake_server_->InjectEntity(
bookmark_builder1
.SetGeneration(BookmarkGeneration::kWithoutTitleInSpecifics)
.BuildBookmark(GURL("http://page1.com")));
fake_server_->InjectEntity(
bookmark_builder2
.SetGeneration(BookmarkGeneration::kWithoutTitleInSpecifics)
.BuildBookmark(GURL("http://page2.com")));
ASSERT_TRUE(SetupSync());
EXPECT_EQ(1u, CountBookmarksWithTitlesMatching(kSingleProfileIndex, title1));
EXPECT_EQ(1u, CountBookmarksWithTitlesMatching(kSingleProfileIndex, title2));
}
IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest,
DownloadLegacyUppercaseGuid2016BookmarksAndCommit) {
const base::Uuid uuid = base::Uuid::GenerateRandomV4();
const std::string uppercase_uuid_str =
base::ToUpperASCII(uuid.AsLowercaseString());
const std::u16string title1 = u"Title1";
const std::u16string title2 = u"Title2";
fake_server::EntityBuilderFactory entity_builder_factory;
// Bookmarks created around 2016, between [M44..M52) use an uppercase UUID as
// originator client item ID.
fake_server::BookmarkEntityBuilder bookmark_builder =
entity_builder_factory.NewBookmarkEntityBuilder(title1)
.SetOriginatorClientItemId(uppercase_uuid_str);
fake_server_->InjectEntity(
bookmark_builder
.SetGeneration(BookmarkGeneration::kWithoutTitleInSpecifics)
.BuildBookmark(GURL("http://page1.com")));
ASSERT_TRUE(SetupSync());
ASSERT_EQ(1u, CountBookmarksWithTitlesMatching(kSingleProfileIndex, title1));
// The UUID should have been canonicalized (lowercased) in BookmarkModel.
EXPECT_TRUE(ContainsBookmarkNodeWithUuid(kSingleProfileIndex, uuid));
// Changing the title should populate the server-side UUID in specifics in
// lowercase form.
ASSERT_EQ(1u, GetBookmarkBarNode(0)->children().size());
ASSERT_EQ(title1, GetBookmarkBarNode(0)->children()[0]->GetTitle());
SetTitle(kSingleProfileIndex, GetBookmarkBarNode(0)->children().front().get(),
title2);
ASSERT_TRUE(BookmarkModelMatchesFakeServerChecker(
kSingleProfileIndex, GetSyncService(kSingleProfileIndex),
GetFakeServer())
.Wait());
// Verify the UUID that was committed to the server.
std::vector<sync_pb::SyncEntity> server_bookmarks =
GetFakeServer()->GetSyncEntitiesByDataType(syncer::BOOKMARKS);
ASSERT_EQ(1u, server_bookmarks.size());
ASSERT_EQ(title2, base::UTF8ToUTF16(server_bookmarks[0]
.specifics()
.bookmark()
.legacy_canonicalized_title()));
EXPECT_EQ(uuid.AsLowercaseString(),
server_bookmarks[0].specifics().bookmark().guid());
}
IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest,
DownloadModernBookmarkCollidingPre2015BookmarkId) {
const std::u16string title1 = u"Title1";
const std::u16string title2 = u"Title2";
const std::string kOriginalOriginatorClientItemId = "1";
fake_server::EntityBuilderFactory entity_builder_factory1;
fake_server::EntityBuilderFactory entity_builder_factory2;
// One pre-2015 bookmark, nothing special here.
fake_server::BookmarkEntityBuilder bookmark_builder1 =
entity_builder_factory1.NewBookmarkEntityBuilder(title1)
.SetOriginatorClientItemId(kOriginalOriginatorClientItemId);
// A second bookmark, possibly uploaded by a buggy client, happens to use an
// originator client item ID that collides with the UUID that would have been
// inferred for the original pre-2015 bookmark.
fake_server::BookmarkEntityBuilder bookmark_builder2 =
entity_builder_factory2.NewBookmarkEntityBuilder(title2);
bookmark_builder2.SetOriginatorClientItemId(
syncer::InferGuidForLegacyBookmarkForTesting(
entity_builder_factory1.cache_guid(),
kOriginalOriginatorClientItemId));
fake_server_->InjectEntity(
bookmark_builder1
.SetGeneration(BookmarkGeneration::kWithoutTitleInSpecifics)
.BuildBookmark(GURL("http://page1.com")));
fake_server_->InjectEntity(
bookmark_builder2
.SetGeneration(BookmarkGeneration::kWithoutTitleInSpecifics)
.BuildBookmark(GURL("http://page2.com")));
ASSERT_TRUE(SetupSync());
const BookmarkNode* bookmark_bar_node =
GetBookmarkBarNode(kSingleProfileIndex);
// Check only number of bookmarks since any of them may be removed as
// duplicate.
EXPECT_EQ(1u, bookmark_bar_node->children().size());
}
// Test that a client doesn't mutate the favicon data in the process
// of storing the favicon data from sync to the database or in the process
// of requesting data from the database for sync.
IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest,
SetFaviconHiDPIDifferentCodec) {
// Set the supported scale factors to 1x and 2x such that
// BookmarkModel::GetFavicon() requests both 1x and 2x.
// 1x -> for sync, 2x -> for the UI.
ui::SetSupportedResourceScaleFactors({ui::k100Percent, ui::k200Percent});
ASSERT_TRUE(SetupSync());
const GURL page_url("http://www.google.com");
const GURL icon_url("http://www.google.com/favicon.ico");
const BookmarkNode* bookmark =
AddURL(kSingleProfileIndex, u"title", page_url);
// Simulate receiving a favicon from sync encoded by a different PNG encoder
// than the one native to the OS. This tests the PNG data is not decoded to
// SkBitmap (or any other image format) then encoded back to PNG on the path
// between sync and the database.
gfx::Image original_favicon =
Create1xFaviconFromPNGFile("favicon_cocoa_png_codec.png");
ASSERT_FALSE(original_favicon.IsEmpty());
SetFavicon(kSingleProfileIndex, bookmark, icon_url, original_favicon,
bookmarks_helper::FROM_SYNC);
ASSERT_TRUE(
UpdatedProgressMarkerChecker(GetSyncService(kSingleProfileIndex)).Wait());
scoped_refptr<base::RefCountedMemory> original_favicon_bytes =
original_favicon.As1xPNGBytes();
gfx::Image final_favicon =
GetBookmarkModel(kSingleProfileIndex)->GetFavicon(bookmark);
scoped_refptr<base::RefCountedMemory> final_favicon_bytes =
final_favicon.As1xPNGBytes();
// Check that the data was not mutated from the original.
EXPECT_TRUE(original_favicon_bytes.get());
EXPECT_TRUE(original_favicon_bytes->Equals(final_favicon_bytes));
}
// Test that a client deletes favicons from sync when they have been removed
// from the local database.
IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest, DeleteFaviconFromSync) {
ASSERT_TRUE(SetupSync());
const GURL page_url("http://www.google.com");
const GURL icon_url("http://www.google.com/favicon.ico");
const BookmarkNode* bookmark =
AddURL(kSingleProfileIndex, u"title", page_url);
SetFavicon(0, bookmark, icon_url, CreateFavicon(SK_ColorWHITE),
bookmarks_helper::FROM_UI);
ASSERT_TRUE(
UpdatedProgressMarkerChecker(GetSyncService(kSingleProfileIndex)).Wait());
// Simulate receiving a favicon deletion from sync.
DeleteFaviconMappings(kSingleProfileIndex, bookmark,
bookmarks_helper::FROM_SYNC);
ASSERT_TRUE(
UpdatedProgressMarkerChecker(GetSyncService(kSingleProfileIndex)).Wait());
ASSERT_THAT(GetBookmarkBarNode(kSingleProfileIndex)->children(),
ElementsAre(IsUrlBookmark(u"title", page_url)));
CheckHasNoFavicon(kSingleProfileIndex, page_url);
EXPECT_TRUE(
GetBookmarkModel(kSingleProfileIndex)->GetFavicon(bookmark).IsEmpty());
}
IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest, OneFolderRemovedEvent) {
ASSERT_TRUE(SetupClients());
// Starting state:
// other_node
// -> folder0
// -> http://yahoo.com
// -> http://www.cnn.com
// bookmark_bar
const BookmarkNode* folder0 = AddFolder(
kSingleProfileIndex, GetOtherNode(kSingleProfileIndex), 0, u"folder0");
ASSERT_TRUE(AddURL(kSingleProfileIndex, folder0, 0, u"Yahoo",
GURL("http://www.yahoo.com")));
ASSERT_TRUE(AddURL(kSingleProfileIndex, GetOtherNode(kSingleProfileIndex), 1,
u"CNN", GURL("http://www.cnn.com")));
// Set up sync, wait for its completion and verify that changes propagated.
ASSERT_TRUE(SetupSync());
ASSERT_EQ(2u, GetOtherNode(kSingleProfileIndex)->children().size());
ASSERT_EQ(0u, GetBookmarkBarNode(kSingleProfileIndex)->children().size());
// Remove one folder and wait for sync completion.
const base::Location kDeletionLocation = FROM_HERE;
GetBookmarkModel(kSingleProfileIndex)
->Remove(folder0, bookmarks::metrics::BookmarkEditSource::kOther,
kDeletionLocation);
ASSERT_TRUE(BookmarkModelMatchesFakeServerChecker(
kSingleProfileIndex, GetSyncService(kSingleProfileIndex),
GetFakeServer())
.Wait());
EXPECT_EQ(1u, GetOtherNode(kSingleProfileIndex)->children().size());
EXPECT_EQ(0u, GetBookmarkBarNode(kSingleProfileIndex)->children().size());
// The folder contained one bookmark inside, so two deletions should have been
// recorded.
EXPECT_THAT(
GetFakeServer()->GetCommittedDeletionOrigins(syncer::DataType::BOOKMARKS),
AllOf(SizeIs(2),
Each(MatchesDeletionOrigin(version_info::GetVersionNumber(),
kDeletionLocation))));
}
IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest,
BookmarkAllNodesRemovedEvent) {
ASSERT_TRUE(SetupClients());
// Starting state:
// other_node
// -> folder0
// -> tier1_a
// -> http://mail.google.com
// -> http://www.google.com
// -> http://news.google.com
// -> http://yahoo.com
// -> http://www.cnn.com
// bookmark_bar
// -> empty_folder
// -> folder1
// -> http://yahoo.com
// -> http://gmail.com
const BookmarkNode* folder0 = AddFolder(
kSingleProfileIndex, GetOtherNode(kSingleProfileIndex), 0, u"folder0");
const BookmarkNode* tier1_a =
AddFolder(kSingleProfileIndex, folder0, 0, u"tier1_a");
ASSERT_TRUE(AddURL(kSingleProfileIndex, folder0, 1, u"News",
GURL("http://news.google.com")));
ASSERT_TRUE(AddURL(kSingleProfileIndex, folder0, 2, u"Yahoo",
GURL("http://www.yahoo.com")));
ASSERT_TRUE(AddURL(kSingleProfileIndex, tier1_a, 0, u"Gmai",
GURL("http://mail.google.com")));
ASSERT_TRUE(AddURL(kSingleProfileIndex, tier1_a, 1, u"Google",
GURL("http://www.google.com")));
ASSERT_TRUE(AddURL(kSingleProfileIndex, GetOtherNode(kSingleProfileIndex), 1,
u"CNN", GURL("http://www.cnn.com")));
ASSERT_TRUE(AddFolder(kSingleProfileIndex,
GetBookmarkBarNode(kSingleProfileIndex), 0,
u"empty_folder"));
const BookmarkNode* folder1 =
AddFolder(kSingleProfileIndex, GetBookmarkBarNode(kSingleProfileIndex), 1,
u"folder1");
ASSERT_TRUE(AddURL(kSingleProfileIndex, folder1, 0, u"Yahoo",
GURL("http://www.yahoo.com")));
ASSERT_TRUE(AddURL(kSingleProfileIndex, GetBookmarkBarNode(0), 2, u"Gmail",
GURL("http://gmail.com")));
// Set up sync, wait for its completion and verify that changes propagated.
ASSERT_TRUE(SetupSync());
ASSERT_EQ(2u, GetOtherNode(kSingleProfileIndex)->children().size());
ASSERT_EQ(3u, GetBookmarkBarNode(kSingleProfileIndex)->children().size());
// Remove all bookmarks and wait for sync completion.
const base::Location kDeletionLocation = FROM_HERE;
GetBookmarkModel(kSingleProfileIndex)
->RemoveAllUserBookmarks(kDeletionLocation);
ASSERT_TRUE(BookmarkModelMatchesFakeServerChecker(
kSingleProfileIndex, GetSyncService(kSingleProfileIndex),
GetFakeServer())
.Wait());
EXPECT_THAT(
GetFakeServer()->GetCommittedDeletionOrigins(syncer::DataType::BOOKMARKS),
AllOf(SizeIs(11),
Each(MatchesDeletionOrigin(version_info::GetVersionNumber(),
kDeletionLocation))));
// Verify other node has no children now.
EXPECT_TRUE(GetOtherNode(kSingleProfileIndex)->children().empty());
EXPECT_TRUE(GetBookmarkBarNode(kSingleProfileIndex)->children().empty());
}
IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest, DownloadDeletedBookmark) {
std::u16string title = u"Patrick Star";
fake_server::EntityBuilderFactory entity_builder_factory;
fake_server::BookmarkEntityBuilder bookmark_builder =
entity_builder_factory.NewBookmarkEntityBuilder(title);
fake_server_->InjectEntity(bookmark_builder.BuildBookmark(
GURL("http://en.wikipedia.org/wiki/Patrick_Star")));
ASSERT_TRUE(SetupSync());
ASSERT_EQ(1u, CountBookmarksWithTitlesMatching(kSingleProfileIndex, title));
std::vector<sync_pb::SyncEntity> server_bookmarks =
GetFakeServer()->GetSyncEntitiesByDataType(syncer::BOOKMARKS);
ASSERT_EQ(1ul, server_bookmarks.size());
std::string entity_id = server_bookmarks[0].id_string();
std::unique_ptr<syncer::LoopbackServerEntity> tombstone(
syncer::PersistentTombstoneEntity::CreateNew(entity_id, std::string()));
GetFakeServer()->InjectEntity(std::move(tombstone));
const int kExpectedCountAfterDeletion = 0;
ASSERT_TRUE(BookmarksTitleChecker(kSingleProfileIndex, title,
kExpectedCountAfterDeletion)
.Wait());
}
IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest,
DownloadModifiedBookmark) {
std::u16string title = u"Syrup";
GURL original_url = GURL("https://en.wikipedia.org/?title=Maple_syrup");
GURL updated_url = GURL("https://en.wikipedia.org/wiki/Xylem");
fake_server::EntityBuilderFactory entity_builder_factory;
fake_server::BookmarkEntityBuilder bookmark_builder =
entity_builder_factory.NewBookmarkEntityBuilder(title);
fake_server_->InjectEntity(bookmark_builder.BuildBookmark(original_url));
ASSERT_TRUE(SetupSync());
ASSERT_EQ(1u, CountBookmarksWithTitlesMatching(kSingleProfileIndex, title));
ASSERT_EQ(1u,
CountBookmarksWithUrlsMatching(kSingleProfileIndex, original_url));
ASSERT_EQ(0u,
CountBookmarksWithUrlsMatching(kSingleProfileIndex, updated_url));
std::vector<sync_pb::SyncEntity> server_bookmarks =
GetFakeServer()->GetSyncEntitiesByDataType(syncer::BOOKMARKS);
ASSERT_EQ(1ul, server_bookmarks.size());
std::string entity_id = server_bookmarks[0].id_string();
sync_pb::EntitySpecifics specifics = server_bookmarks[0].specifics();
sync_pb::BookmarkSpecifics* bookmark_specifics = specifics.mutable_bookmark();
bookmark_specifics->set_url(updated_url.spec());
ASSERT_TRUE(GetFakeServer()->ModifyEntitySpecifics(entity_id, specifics));
ASSERT_TRUE(BookmarksUrlChecker(kSingleProfileIndex, updated_url, 1).Wait());
ASSERT_EQ(0u,
CountBookmarksWithUrlsMatching(kSingleProfileIndex, original_url));
ASSERT_EQ(1u, CountBookmarksWithTitlesMatching(kSingleProfileIndex, title));
}
IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest, DownloadBookmarkFolder) {
const std::u16string title = u"Title1";
fake_server::EntityBuilderFactory entity_builder_factory;
fake_server::BookmarkEntityBuilder bookmark_builder =
entity_builder_factory.NewBookmarkEntityBuilder(title);
fake_server_->InjectEntity(bookmark_builder.BuildFolder());
ASSERT_TRUE(SetupClients());
ASSERT_EQ(0u, CountFoldersWithTitlesMatching(kSingleProfileIndex, title));
ASSERT_TRUE(SetupSync());
ASSERT_EQ(1u, CountFoldersWithTitlesMatching(kSingleProfileIndex, title));
}
IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest,
DownloadLegacyBookmarkFolder) {
const std::u16string title = u"Title1";
fake_server::EntityBuilderFactory entity_builder_factory;
fake_server::BookmarkEntityBuilder bookmark_builder =
entity_builder_factory.NewBookmarkEntityBuilder(title);
fake_server_->InjectEntity(
bookmark_builder
.SetGeneration(BookmarkGeneration::kWithoutTitleInSpecifics)
.BuildFolder());
ASSERT_TRUE(SetupClients());
ASSERT_EQ(0u, CountFoldersWithTitlesMatching(kSingleProfileIndex, title));
ASSERT_TRUE(SetupSync());
ASSERT_EQ(1u, CountFoldersWithTitlesMatching(kSingleProfileIndex, title));
}
// Legacy bookmark clients append a blank space to empty titles, ".", ".." tiles
// before committing them because historically they were illegal server titles.
// This test makes sure that this functionality is implemented for backward
// compatibility with legacy clients.
IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest,
ShouldCommitBookmarksWithIllegalServerNames) {
ASSERT_TRUE(SetupSync());
const std::vector<std::u16string> illegal_titles = {u"", u".", u".."};
// Create 3 bookmarks under the bookmark bar with illegal titles.
for (const std::u16string& illegal_title : illegal_titles) {
ASSERT_TRUE(AddURL(kSingleProfileIndex, illegal_title,
GURL("http://www.google.com")));
}
// Wait till all entities are committed.
ASSERT_TRUE(BookmarkModelMatchesFakeServerChecker(
kSingleProfileIndex, GetSyncService(kSingleProfileIndex),
GetFakeServer())
.Wait());
// Collect the titles committed on the server.
std::vector<sync_pb::SyncEntity> entities =
fake_server_->GetSyncEntitiesByDataType(syncer::BOOKMARKS);
std::vector<std::string> committed_titles;
for (const sync_pb::SyncEntity& entity : entities) {
committed_titles.push_back(
entity.specifics().bookmark().legacy_canonicalized_title());
}
// A space should have been appended to each illegal title before committing.
EXPECT_THAT(committed_titles,
testing::UnorderedElementsAre(" ", ". ", ".. "));
}
// This test the opposite functionality in the test above. Legacy bookmark
// clients omit a blank space from blank space title, ". ", ".. " tiles upon
// receiving the remote updates. An extra space has been appended during a
// commit because historically they were considered illegal server titles. This
// test makes sure that this functionality is implemented for backward
// compatibility with legacy clients.
IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest,
ShouldCreateLocalBookmarksWithIllegalServerNames) {
const std::vector<std::u16string> illegal_titles = {u"", u".", u".."};
// Create 3 bookmarks on the server under BookmarkBar with illegal server
// titles with a blank space appended to simulate a commit from a legacy
// client.
fake_server::EntityBuilderFactory entity_builder_factory;
for (const std::u16string& illegal_title : illegal_titles) {
fake_server::BookmarkEntityBuilder bookmark_builder =
entity_builder_factory.NewBookmarkEntityBuilder(illegal_title + u" ");
fake_server_->InjectEntity(
bookmark_builder
.SetGeneration(BookmarkGeneration::kValidGuidAndLegacyTitle)
.BuildBookmark(GURL("http://www.google.com")));
}
ASSERT_TRUE(SetupSync());
// There should be bookmark with illegal title (without the appended space).
for (const std::u16string& illegal_title : illegal_titles) {
EXPECT_EQ(1u, CountBookmarksWithTitlesMatching(kSingleProfileIndex,
illegal_title));
}
}
// Legacy bookmark clients append a blank space to empty titles. This tests that
// this is respected when merging local and remote hierarchies.
IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest,
ShouldTruncateBlanksWhenMatchingTitles) {
const std::u16string remote_blank_title = u" ";
const std::u16string local_empty_title;
// Create a folder on the server under BookmarkBar with a title with a blank
// space.
fake_server::EntityBuilderFactory entity_builder_factory;
fake_server::BookmarkEntityBuilder bookmark_builder =
entity_builder_factory.NewBookmarkEntityBuilder(remote_blank_title);
fake_server_->InjectEntity(
bookmark_builder
.SetGeneration(BookmarkGeneration::kValidGuidAndLegacyTitle)
.BuildFolder());
ASSERT_TRUE(SetupClients());
// Create a folder on the client under BookmarkBar with an empty title.
const BookmarkNode* node =
AddFolder(kSingleProfileIndex, GetBookmarkBarNode(kSingleProfileIndex), 0,
local_empty_title);
ASSERT_TRUE(node);
ASSERT_EQ(1u, CountFoldersWithTitlesMatching(kSingleProfileIndex,
local_empty_title));
ASSERT_TRUE(SetupSync());
// There should be only one bookmark on the client. The remote node should
// have been merged with the local node and either the local or remote titles
// is picked.
EXPECT_EQ(1u, CountFoldersWithTitlesMatching(kSingleProfileIndex,
local_empty_title) +
CountFoldersWithTitlesMatching(kSingleProfileIndex,
remote_blank_title));
}
// Legacy bookmark clients truncate long titles up to 255 bytes. This tests that
// this is respected when merging local and remote hierarchies.
IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest,
ShouldTruncateLongTitles) {
const std::u16string remote_truncated_title =
u"abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrs"
u"t"
"uvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMN"
"OPQRSTUVWXYZabcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZabcdefgh"
"ijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTU";
const std::u16string local_full_title =
u"abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrs"
u"t"
"uvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMN"
"OPQRSTUVWXYZabcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZabcdefgh"
"ijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyzAB"
"CDEFGHIJKLMNOPQRSTUVWXYZ";
// Create a folder on the server under BookmarkBar with a truncated title.
fake_server::EntityBuilderFactory entity_builder_factory;
fake_server::BookmarkEntityBuilder bookmark_builder =
entity_builder_factory.NewBookmarkEntityBuilder(remote_truncated_title);
fake_server_->InjectEntity(bookmark_builder.BuildFolder());
ASSERT_TRUE(SetupClients());
// Create a folder on the client under BookmarkBar with a long title.
const BookmarkNode* node =
AddFolder(kSingleProfileIndex, GetBookmarkBarNode(kSingleProfileIndex), 0,
local_full_title);
ASSERT_TRUE(node);
ASSERT_EQ(1u, CountFoldersWithTitlesMatching(kSingleProfileIndex,
local_full_title));
ASSERT_TRUE(SetupSync());
// There should be only one bookmark on the client. The remote node should
// have been merged with the local node and either the local or remote title
// is picked.
EXPECT_EQ(1u, CountFoldersWithTitlesMatching(kSingleProfileIndex,
local_full_title) +
CountFoldersWithTitlesMatching(kSingleProfileIndex,
remote_truncated_title));
}
IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest,
DownloadBookmarkFoldersWithPositions) {
const std::u16string title0 = u"Folder left";
const std::u16string title1 = u"Folder middle";
const std::u16string title2 = u"Folder right";
fake_server::EntityBuilderFactory entity_builder_factory;
fake_server::BookmarkEntityBuilder bookmark0_builder =
entity_builder_factory.NewBookmarkEntityBuilder(title0);
bookmark0_builder.SetIndex(0);
fake_server::BookmarkEntityBuilder bookmark1_builder =
entity_builder_factory.NewBookmarkEntityBuilder(title1);
bookmark1_builder.SetIndex(1);
fake_server::BookmarkEntityBuilder bookmark2_builder =
entity_builder_factory.NewBookmarkEntityBuilder(title2);
bookmark2_builder.SetIndex(2);
fake_server_->InjectEntity(bookmark0_builder.BuildFolder());
fake_server_->InjectEntity(bookmark2_builder.BuildFolder());
fake_server_->InjectEntity(bookmark1_builder.BuildFolder());
ASSERT_TRUE(SetupSync());
EXPECT_EQ(1u, CountFoldersWithTitlesMatching(kSingleProfileIndex, title0));
EXPECT_EQ(1u, CountFoldersWithTitlesMatching(kSingleProfileIndex, title1));
EXPECT_EQ(1u, CountFoldersWithTitlesMatching(kSingleProfileIndex, title2));
const BookmarkNode* bar = GetBookmarkBarNode(kSingleProfileIndex);
ASSERT_EQ(3u, bar->children().size());
EXPECT_EQ(title0, bar->children()[0]->GetTitle());
EXPECT_EQ(title1, bar->children()[1]->GetTitle());
EXPECT_EQ(title2, bar->children()[2]->GetTitle());
}
IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest, E2E_ONLY(SanitySetup)) {
ASSERT_TRUE(ResetSyncForPrimaryAccount());
ASSERT_TRUE(SetupSync());
}
IN_PROC_BROWSER_TEST_F(
SingleClientBookmarksSyncTest,
RemoveRightAfterAddShouldNotSendCommitRequestsOrTombstones) {
base::HistogramTester histogram_tester;
ASSERT_TRUE(SetupSync());
// Add a folder and directly remove it.
ASSERT_NE(nullptr,
AddFolder(kSingleProfileIndex,
/*parent=*/GetBookmarkBarNode(kSingleProfileIndex),
/*index=*/0, u"folder name"));
Remove(kSingleProfileIndex,
/*parent=*/GetBookmarkBarNode(kSingleProfileIndex), 0);
// Add another bookmark to make sure a full sync cycle completion.
ASSERT_NE(nullptr, AddURL(kSingleProfileIndex,
/*parent=*/GetOtherNode(kSingleProfileIndex),
/*index=*/0, u"title", GURL("http://www.url.com")));
ASSERT_TRUE(BookmarkModelMatchesFakeServerChecker(
kSingleProfileIndex, GetSyncService(kSingleProfileIndex),
GetFakeServer())
.Wait());
// There should have been one creation and no deletions.
EXPECT_EQ(1, histogram_tester.GetBucketCount(
"Sync.DataTypeEntityChange.BOOKMARK",
syncer::DataTypeEntityChange::kLocalCreation));
EXPECT_EQ(0, histogram_tester.GetBucketCount(
"Sync.DataTypeEntityChange.BOOKMARK",
syncer::DataTypeEntityChange::kLocalDeletion));
}
// Android doesn't currently support PRE_ tests, see crbug.com/1117345.
#if !BUILDFLAG(IS_ANDROID)
IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest,
PRE_PersistProgressMarkerOnRestart) {
const std::u16string title = u"Title1";
fake_server::EntityBuilderFactory entity_builder_factory;
fake_server::BookmarkEntityBuilder bookmark_builder =
entity_builder_factory.NewBookmarkEntityBuilder(
title, base::Uuid::ParseLowercase(kBookmarkGuid));
bookmark_builder.SetId(
syncer::LoopbackServerEntity::CreateId(syncer::BOOKMARKS, kBookmarkGuid));
fake_server_->InjectEntity(bookmark_builder.BuildFolder());
base::HistogramTester histogram_tester;
ASSERT_TRUE(SetupSync());
ASSERT_EQ(1u, GetBookmarkBarNode(kSingleProfileIndex)->children().size());
EXPECT_NE(0, histogram_tester.GetBucketCount(
"Sync.DataTypeEntityChange.BOOKMARK",
syncer::DataTypeEntityChange::kRemoteInitialUpdate));
}
IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest,
PersistProgressMarkerOnRestart) {
const std::u16string title = u"Title1";
fake_server::EntityBuilderFactory entity_builder_factory;
fake_server::BookmarkEntityBuilder bookmark_builder =
entity_builder_factory.NewBookmarkEntityBuilder(
title, base::Uuid::ParseLowercase(kBookmarkGuid));
bookmark_builder.SetId(
syncer::LoopbackServerEntity::CreateId(syncer::BOOKMARKS, kBookmarkGuid));
fake_server_->InjectEntity(bookmark_builder.BuildFolder());
base::HistogramTester histogram_tester;
ASSERT_TRUE(SetupClients());
ASSERT_EQ(1u, GetBookmarkBarNode(kSingleProfileIndex)->children().size());
ASSERT_TRUE(GetClient(kSingleProfileIndex)->AwaitSyncSetupCompletion());
// After restart, the last sync cycle snapshot should be empty.
// Once a sync request happened (e.g. by a poll), that snapshot is populated.
// We use the following checker to simply wait for an non-empty snapshot.
GetSyncService(0)->TriggerRefresh({syncer::BOOKMARKS});
EXPECT_TRUE(UpdatedProgressMarkerChecker(GetSyncService(0)).Wait());
ASSERT_EQ(1u, GetBookmarkBarNode(kSingleProfileIndex)->children().size());
EXPECT_EQ(0, histogram_tester.GetBucketCount(
"Sync.DataTypeEntityChange.BOOKMARK",
syncer::DataTypeEntityChange::kRemoteInitialUpdate));
}
#endif // !BUILDFLAG(IS_ANDROID)
IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest,
ApplyRemoteCreationWithValidUuid) {
// Start syncing.
ASSERT_TRUE(SetupSync());
ASSERT_EQ(0u, GetBookmarkBarNode(kSingleProfileIndex)->children().size());
// Create a bookmark folder with a valid UUID.
fake_server::EntityBuilderFactory entity_builder_factory;
fake_server::BookmarkEntityBuilder bookmark_builder =
entity_builder_factory.NewBookmarkEntityBuilder("Title1");
// Issue remote creation with a valid UUID.
base::HistogramTester histogram_tester;
std::unique_ptr<syncer::LoopbackServerEntity> folder =
bookmark_builder.BuildFolder();
const base::Uuid uuid = base::Uuid::ParseCaseInsensitive(
folder.get()->GetSpecifics().bookmark().guid());
ASSERT_TRUE(uuid.is_valid());
ASSERT_FALSE(ContainsBookmarkNodeWithUuid(kSingleProfileIndex, uuid));
fake_server_->InjectEntity(std::move(folder));
// A folder should have been added with the corresponding UUID.
EXPECT_TRUE(BookmarksUuidChecker(kSingleProfileIndex, uuid).Wait());
EXPECT_EQ(1u, GetBookmarkBarNode(kSingleProfileIndex)->children().size());
EXPECT_EQ(
uuid,
GetBookmarkBarNode(kSingleProfileIndex)->children()[0].get()->uuid());
EXPECT_EQ(1, histogram_tester.GetBucketCount("Sync.BookmarkGUIDSource2",
/*kSpecifics=*/0));
EXPECT_NE(0U,
histogram_tester
.GetAllSamples(
"Sync.NonReflectionUpdateFreshnessPossiblySkewed2.BOOKMARK")
.size());
}
IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest,
ApplyRemoteCreationWithoutValidGUID) {
// Start syncing.
ASSERT_TRUE(SetupSync());
ASSERT_EQ(0u, GetBookmarkBarNode(kSingleProfileIndex)->children().size());
const base::Uuid originator_client_item_id = base::Uuid::GenerateRandomV4();
ASSERT_FALSE(ContainsBookmarkNodeWithUuid(kSingleProfileIndex,
originator_client_item_id));
fake_server::EntityBuilderFactory entity_builder_factory;
fake_server::BookmarkEntityBuilder bookmark_builder =
entity_builder_factory.NewBookmarkEntityBuilder(
u"Title1", originator_client_item_id);
// Issue remote creation without a valid GUID but with a valid
// originator_client_item_id.
base::HistogramTester histogram_tester;
std::unique_ptr<syncer::LoopbackServerEntity> folder =
bookmark_builder
.SetGeneration(BookmarkGeneration::kWithoutTitleInSpecifics)
.BuildFolder();
ASSERT_TRUE(folder.get()->GetSpecifics().bookmark().guid().empty());
fake_server_->InjectEntity(std::move(folder));
// A bookmark folder should have been added with the originator_client_item_id
// as the GUID.
EXPECT_TRUE(
BookmarksUuidChecker(kSingleProfileIndex, originator_client_item_id)
.Wait());
EXPECT_EQ(1u, GetBookmarkBarNode(kSingleProfileIndex)->children().size());
EXPECT_EQ(
originator_client_item_id,
GetBookmarkBarNode(kSingleProfileIndex)->children()[0].get()->uuid());
EXPECT_EQ(1, histogram_tester.GetBucketCount("Sync.BookmarkGUIDSource2",
/*kValidOCII=*/1));
}
IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest,
ApplyRemoteCreationWithoutValidGUIDOrOCII) {
// Start syncing.
ASSERT_TRUE(SetupSync());
ASSERT_EQ(0u, GetBookmarkBarNode(kSingleProfileIndex)->children().size());
GURL url = GURL("http://foo.com");
const std::string originator_client_item_id = "INVALID OCII";
fake_server::EntityBuilderFactory entity_builder_factory;
fake_server::BookmarkEntityBuilder bookmark_builder =
entity_builder_factory.NewBookmarkEntityBuilder("Title1");
bookmark_builder.SetOriginatorClientItemId(originator_client_item_id);
// Issue remote creation without a valid GUID or a valid
// originator_client_item_id.
base::HistogramTester histogram_tester;
std::unique_ptr<syncer::LoopbackServerEntity> bookmark =
bookmark_builder
.SetGeneration(BookmarkGeneration::kWithoutTitleInSpecifics)
.BuildBookmark(url);
ASSERT_TRUE(bookmark.get()->GetSpecifics().bookmark().guid().empty());
fake_server_->InjectEntity(std::move(bookmark));
// A bookmark should have been added with a newly assigned valid GUID.
EXPECT_TRUE(BookmarksUrlChecker(kSingleProfileIndex, url, 1).Wait());
EXPECT_EQ(1u, GetBookmarkBarNode(kSingleProfileIndex)->children().size());
EXPECT_FALSE(ContainsBookmarkNodeWithUuid(
kSingleProfileIndex,
base::Uuid::ParseCaseInsensitive(originator_client_item_id)));
EXPECT_EQ(1, histogram_tester.GetBucketCount("Sync.BookmarkGUIDSource2",
/*kInferred=*/3));
}
IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest,
MergeRemoteCreationWithValidUuid) {
const GURL url = GURL("http://www.foo.com");
fake_server::EntityBuilderFactory entity_builder_factory;
fake_server::BookmarkEntityBuilder bookmark_builder =
entity_builder_factory.NewBookmarkEntityBuilder("Title1");
// Create bookmark in server with a valid UUID.
std::unique_ptr<syncer::LoopbackServerEntity> bookmark =
bookmark_builder
.SetGeneration(BookmarkGeneration::kHierarchyFieldsInSpecifics)
.BuildBookmark(url);
const base::Uuid uuid = base::Uuid::ParseCaseInsensitive(
bookmark.get()->GetSpecifics().bookmark().guid());
ASSERT_TRUE(uuid.is_valid());
fake_server_->InjectEntity(std::move(bookmark));
// Start syncing.
base::HistogramTester histogram_tester;
ASSERT_TRUE(SetupClients());
ASSERT_EQ(0u, GetBookmarkBarNode(kSingleProfileIndex)->children().size());
ASSERT_TRUE(SetupSync());
// A bookmark should have been added with the corresponding UUID.
EXPECT_TRUE(BookmarksUrlChecker(kSingleProfileIndex, url, 1).Wait());
EXPECT_EQ(1u, GetBookmarkBarNode(kSingleProfileIndex)->children().size());
EXPECT_TRUE(ContainsBookmarkNodeWithUuid(kSingleProfileIndex, uuid));
EXPECT_EQ(1, histogram_tester.GetBucketCount("Sync.BookmarkGUIDSource2",
/*kSpecifics=*/0));
EXPECT_EQ(0, histogram_tester.GetBucketCount("Sync.BookmarkGUIDSource2",
/*kValidOCII=*/1));
EXPECT_EQ(0, histogram_tester.GetBucketCount("Sync.BookmarkGUIDSource2",
/*kLeftEmpty=*/2));
EXPECT_EQ(0, histogram_tester.GetBucketCount("Sync.BookmarkGUIDSource2",
/*kInferred=*/3));
}
IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest,
ShouldStartTrackingRestoredBookmark) {
ASSERT_TRUE(SetupSync());
BookmarkModel* bookmark_model = GetBookmarkModel(kSingleProfileIndex);
const BookmarkNode* bookmark_bar_node =
GetBookmarkBarNode(kSingleProfileIndex);
// First add a new bookmark.
const std::u16string title = u"Title";
const BookmarkNode* node =
bookmark_model->AddFolder(bookmark_bar_node, /*index=*/0, title);
ASSERT_TRUE(BookmarkModelMatchesFakeServerChecker(
kSingleProfileIndex, GetSyncService(kSingleProfileIndex),
GetFakeServer())
.Wait());
const std::vector<sync_pb::SyncEntity> server_bookmarks_before =
fake_server_->GetSyncEntitiesByDataType(syncer::BOOKMARKS);
ASSERT_EQ(1u, server_bookmarks_before.size());
// Remove the node and undo the action.
bookmark_model->Remove(node, bookmarks::metrics::BookmarkEditSource::kOther,
FROM_HERE);
BookmarkUndoService* undo_service =
GetBookmarkUndoService(kSingleProfileIndex);
undo_service->undo_manager()->Undo();
// Do not use BookmarkModelMatchesFakeServerChecker because the structure and
// bookmarks actually don't change. The only change is the version of the
// entity.
ASSERT_TRUE(
UpdatedProgressMarkerChecker(GetSyncService(kSingleProfileIndex)).Wait());
// Check that the bookmark was committed again.
const std::vector<sync_pb::SyncEntity> server_bookmarks_after =
fake_server_->GetSyncEntitiesByDataType(syncer::BOOKMARKS);
ASSERT_EQ(1u, server_bookmarks_after.size());
EXPECT_GT(server_bookmarks_after.front().version(),
server_bookmarks_before.front().version());
EXPECT_EQ(server_bookmarks_after.front().id_string(),
server_bookmarks_before.front().id_string());
}
IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest,
MergeRemoteCreationWithoutValidGUID) {
const GURL url = GURL("http://www.foo.com");
const base::Uuid originator_client_item_id = base::Uuid::GenerateRandomV4();
fake_server::EntityBuilderFactory entity_builder_factory;
fake_server::BookmarkEntityBuilder bookmark_builder =
entity_builder_factory.NewBookmarkEntityBuilder(
u"Title1", originator_client_item_id);
// Create bookmark in server without a valid GUID but with a valid
// originator_client_item_id.
std::unique_ptr<syncer::LoopbackServerEntity> bookmark =
bookmark_builder
.SetGeneration(BookmarkGeneration::kWithoutTitleInSpecifics)
.BuildBookmark(url);
ASSERT_TRUE(bookmark.get()->GetSpecifics().bookmark().guid().empty());
fake_server_->InjectEntity(std::move(bookmark));
// Start syncing.
base::HistogramTester histogram_tester;
ASSERT_TRUE(SetupClients());
ASSERT_EQ(0u, GetBookmarkBarNode(kSingleProfileIndex)->children().size());
ASSERT_TRUE(SetupSync());
// A bookmark should have been added with the originator_client_item_id as the
// GUID.
EXPECT_TRUE(BookmarksUrlChecker(kSingleProfileIndex, url, 1).Wait());
EXPECT_EQ(1u, GetBookmarkBarNode(kSingleProfileIndex)->children().size());
EXPECT_TRUE(ContainsBookmarkNodeWithUuid(kSingleProfileIndex,
originator_client_item_id));
// Do not check for kSpecifics bucket because it may be 0 or 1. It depends on
// reupload of bookmark (legacy bookmark will be reuploaded and may return
// from the server again with valid GUID in specifics).
EXPECT_EQ(1, histogram_tester.GetBucketCount("Sync.BookmarkGUIDSource2",
/*kValidOCII=*/1));
EXPECT_EQ(0, histogram_tester.GetBucketCount("Sync.BookmarkGUIDSource2",
/*kLeftEmpty=*/2));
EXPECT_EQ(0, histogram_tester.GetBucketCount("Sync.BookmarkGUIDSource2",
/*kInferred=*/3));
}
IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest,
MergeRemoteCreationWithoutValidGUIDOrOCII) {
const GURL url = GURL("http://www.foo.com");
const std::string originator_client_item_id = "INVALID OCII";
fake_server::EntityBuilderFactory entity_builder_factory;
fake_server::BookmarkEntityBuilder bookmark_builder =
entity_builder_factory.NewBookmarkEntityBuilder("Title1");
bookmark_builder.SetOriginatorClientItemId(originator_client_item_id);
// Create bookmark in server without a valid GUID and without a valid
// originator_client_item_id.
std::unique_ptr<syncer::LoopbackServerEntity> bookmark =
bookmark_builder
.SetGeneration(BookmarkGeneration::kWithoutTitleInSpecifics)
.BuildBookmark(url);
ASSERT_TRUE(bookmark.get()->GetSpecifics().bookmark().guid().empty());
fake_server_->InjectEntity(std::move(bookmark));
// Start syncing.
base::HistogramTester histogram_tester;
ASSERT_TRUE(SetupClients());
ASSERT_EQ(0u, GetBookmarkBarNode(kSingleProfileIndex)->children().size());
ASSERT_TRUE(SetupSync());
// A bookmark should have been added with a newly assigned valid GUID.
EXPECT_TRUE(BookmarksUrlChecker(kSingleProfileIndex, url, 1).Wait());
EXPECT_EQ(1u, GetBookmarkBarNode(kSingleProfileIndex)->children().size());
EXPECT_FALSE(ContainsBookmarkNodeWithUuid(
kSingleProfileIndex,
base::Uuid::ParseCaseInsensitive(originator_client_item_id)));
// Do not check for kSpecifics bucket because it may be 0 or 1. It depends on
// reupload of bookmark (legacy bookmark will be reuploaded and may return
// from the server again with valid GUID in specifics).
EXPECT_EQ(0, histogram_tester.GetBucketCount("Sync.BookmarkGUIDSource2",
/*kValidOCII=*/1));
EXPECT_EQ(0, histogram_tester.GetBucketCount("Sync.BookmarkGUIDSource2",
/*kLeftEmpty=*/2));
EXPECT_EQ(1, histogram_tester.GetBucketCount("Sync.BookmarkGUIDSource2",
/*kInferred=*/3));
}
IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest,
MergeRemoteUpdateWithValidGUID) {
ASSERT_TRUE(SetupClients());
// Create a local bookmark folder.
const std::u16string title = u"Title1";
const BookmarkNode* local_folder = AddFolder(
kSingleProfileIndex, GetBookmarkBarNode(kSingleProfileIndex), 0, title);
const base::Uuid old_uuid = local_folder->uuid();
SCOPED_TRACE(std::string("old_uuid=") + old_uuid.AsLowercaseString());
ASSERT_TRUE(local_folder);
ASSERT_TRUE(BookmarksUuidChecker(kSingleProfileIndex, old_uuid).Wait());
ASSERT_EQ(1u, CountFoldersWithTitlesMatching(kSingleProfileIndex, title));
// Create an equivalent remote folder.
fake_server::EntityBuilderFactory entity_builder_factory;
fake_server::BookmarkEntityBuilder bookmark_builder =
entity_builder_factory.NewBookmarkEntityBuilder(title);
std::unique_ptr<syncer::LoopbackServerEntity> remote_folder =
bookmark_builder.BuildFolder();
const base::Uuid new_uuid = base::Uuid::ParseCaseInsensitive(
remote_folder->GetSpecifics().bookmark().guid());
fake_server_->InjectEntity(std::move(remote_folder));
// Start syncing.
ASSERT_EQ(1u, GetBookmarkBarNode(kSingleProfileIndex)->children().size());
ASSERT_TRUE(SetupSync());
// The folder UUID should have been updated with the corresponding value.
EXPECT_TRUE(BookmarksUuidChecker(kSingleProfileIndex, new_uuid).Wait());
EXPECT_FALSE(ContainsBookmarkNodeWithUuid(kSingleProfileIndex, old_uuid));
EXPECT_EQ(1u, GetBookmarkBarNode(kSingleProfileIndex)->children().size());
}
IN_PROC_BROWSER_TEST_F(
SingleClientBookmarksSyncTest,
ShouldReportErrorIfIncrementalLocalCreationCrossesMaxCountLimit) {
ASSERT_TRUE(SetupClients());
// Set a limit of 4 bookmarks. This is to avoid erroring out when the fake
// server sends an update of size 4.
LocalOrSyncableBookmarkSyncServiceFactory::GetForProfile(
GetProfile(kSingleProfileIndex))
->SetBookmarksLimitForTesting(4);
ASSERT_TRUE(SetupSync());
ASSERT_FALSE(GetClient(kSingleProfileIndex)
->service()
->HasAnyModelErrorForTest({syncer::BOOKMARKS}));
// Add 2 new bookmarks to exceed the limit.
const BookmarkNode* bookmark_bar_node =
GetBookmarkBarNode(kSingleProfileIndex);
const std::u16string kTitle1 = u"title1";
const std::string kUrl1 = "http://www.url1.com";
ASSERT_TRUE(AddURL(kSingleProfileIndex,
/*parent=*/bookmark_bar_node, /*index=*/0, kTitle1,
GURL(kUrl1)));
const std::u16string kTitle2 = u"title2";
const std::string kUrl2 = "http://www.url2.com";
ASSERT_TRUE(AddURL(kSingleProfileIndex,
/*parent=*/bookmark_bar_node, /*index=*/1, kTitle2,
GURL(kUrl2)));
// Creation of 2 local bookmarks should exceed the limit of 4.
EXPECT_TRUE(
BookmarksDataTypeErrorChecker(GetClient(kSingleProfileIndex)->service())
.Wait());
// Bookmarks should be in an error state. Thus excluding it from the
// CheckForDataTypeFailures() check.
ExcludeDataTypesFromCheckForDataTypeFailures({syncer::BOOKMARKS});
}
IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest,
ShouldReportErrorIfBookmarksCountExceedsLimitOnStartup) {
ASSERT_TRUE(SetupClients());
// Set a limit of 4 bookmarks. This is to avoid erroring out when the fake
// server sends an update of size 4.
LocalOrSyncableBookmarkSyncServiceFactory::GetForProfile(
GetProfile(kSingleProfileIndex))
->SetBookmarksLimitForTesting(4);
// Add 2 new bookmarks to exceed the limit.
const BookmarkNode* bookmark_bar_node =
GetBookmarkBarNode(kSingleProfileIndex);
const std::u16string kTitle1 = u"title1";
const std::string kUrl1 = "http://www.url1.com";
ASSERT_TRUE(AddURL(kSingleProfileIndex,
/*parent=*/bookmark_bar_node, /*index=*/0, kTitle1,
GURL(kUrl1)));
const std::u16string kTitle2 = u"title2";
const std::string kUrl2 = "http://www.url2.com";
ASSERT_TRUE(AddURL(kSingleProfileIndex,
/*parent=*/bookmark_bar_node, /*index=*/1, kTitle2,
GURL(kUrl2)));
ASSERT_FALSE(GetClient(kSingleProfileIndex)
->service()
->HasAnyModelErrorForTest({syncer::BOOKMARKS}));
ASSERT_TRUE(SetupSync());
// We now have 5 local bookmarks(3 permanent + 2 added), which exceeds our
// limit of 4 bookmarks.
EXPECT_TRUE(
BookmarksDataTypeErrorChecker(GetClient(kSingleProfileIndex)->service())
.Wait());
// Bookmarks should be in an error state. Thus excluding it from the
// CheckForDataTypeFailures() check.
ExcludeDataTypesFromCheckForDataTypeFailures({syncer::BOOKMARKS});
}
IN_PROC_BROWSER_TEST_F(
SingleClientBookmarksSyncTest,
ShouldReportErrorIfBookmarksCountExceedsLimitAfterInitialUpdate) {
// Create a bookmark on the server under BookmarkBar with a truncated title.
const std::u16string kTitle1 = u"title1";
const std::string kUrl1 = "http://www.url1.com";
fake_server::EntityBuilderFactory entity_builder_factory;
fake_server::BookmarkEntityBuilder bookmark_builder =
entity_builder_factory.NewBookmarkEntityBuilder(kTitle1);
fake_server_->InjectEntity(bookmark_builder.BuildBookmark(GURL(kUrl1)));
ASSERT_TRUE(SetupClients());
// Set a limit of 5 bookmarks. This is to avoid erroring out when the fake
// server sends an update of size 5.
LocalOrSyncableBookmarkSyncServiceFactory::GetForProfile(
GetProfile(kSingleProfileIndex))
->SetBookmarksLimitForTesting(5);
// Set up 2 preexisting local bookmark under other node.
const BookmarkNode* other_node = GetOtherNode(kSingleProfileIndex);
const std::u16string kTitle2 = u"title2";
const std::string kUrl2 = "http://www.url2.com";
ASSERT_TRUE(AddURL(kSingleProfileIndex,
/*parent=*/other_node, /*index=*/0, kTitle2, GURL(kUrl2)));
const std::u16string kTitle3 = u"title3";
const std::string kUrl3 = "http://www.url3.com";
ASSERT_TRUE(AddURL(kSingleProfileIndex,
/*parent=*/other_node, /*index=*/0, kTitle3, GURL(kUrl3)));
ASSERT_FALSE(GetClient(kSingleProfileIndex)
->service()
->HasAnyModelErrorForTest({syncer::BOOKMARKS}));
ASSERT_TRUE(SetupSync());
// We should now have 6 local bookmarks, (3 permanent + 2 locally added + 1
// from remote), which exceeeds our limit of 5 bookmarks.
EXPECT_TRUE(
BookmarksDataTypeErrorChecker(GetClient(kSingleProfileIndex)->service())
.Wait());
// Note that remote bookmarks being added, even though we error out, is the
// current behaviour and is not a requirement.
EXPECT_THAT(GetBookmarkBarNode(kSingleProfileIndex)->children(),
ElementsAre(IsUrlBookmark(kTitle1, GURL(kUrl1))));
// Bookmarks should be in an error state. Thus excluding it from the
// CheckForDataTypeFailures() check.
ExcludeDataTypesFromCheckForDataTypeFailures({syncer::BOOKMARKS});
}
IN_PROC_BROWSER_TEST_F(
SingleClientBookmarksSyncTest,
ShouldReportErrorIfBookmarksCountExceedsLimitAfterIncrementalUpdate) {
ASSERT_TRUE(SetupClients());
// Set a limit of 4 bookmarks. This is to avoid erroring out when the fake
// server sends an update of size 4.
LocalOrSyncableBookmarkSyncServiceFactory::GetForProfile(
GetProfile(kSingleProfileIndex))
->SetBookmarksLimitForTesting(4);
// Set up a preexisting local bookmark under other node.
const BookmarkNode* other_node = GetOtherNode(kSingleProfileIndex);
const std::u16string kTitle1 = u"title1";
const std::string kUrl1 = "http://www.url1.com";
ASSERT_TRUE(AddURL(kSingleProfileIndex,
/*parent=*/other_node, /*index=*/0, kTitle1, GURL(kUrl1)));
ASSERT_FALSE(GetClient(kSingleProfileIndex)
->service()
->HasAnyModelErrorForTest({syncer::BOOKMARKS}));
ASSERT_TRUE(SetupSync());
// Create a bookmark on the server under BookmarkBar.
const std::u16string kTitle2 = u"title2";
const std::string kUrl2 = "http://www.url2.com";
fake_server::EntityBuilderFactory entity_builder_factory;
fake_server::BookmarkEntityBuilder bookmark_builder =
entity_builder_factory.NewBookmarkEntityBuilder(kTitle2);
fake_server_->InjectEntity(bookmark_builder.BuildBookmark(GURL(kUrl2)));
EXPECT_TRUE(
BookmarksDataTypeErrorChecker(GetClient(kSingleProfileIndex)->service())
.Wait());
// Note that remote bookmarks being added, even though we error out, is the
// current behaviour and is not a requirement.
EXPECT_THAT(GetBookmarkBarNode(kSingleProfileIndex)->children(),
ElementsAre(IsUrlBookmark(kTitle2, GURL(kUrl2))));
// Bookmarks should be in an error state. Thus excluding it from the
// CheckForDataTypeFailures() check.
ExcludeDataTypesFromCheckForDataTypeFailures({syncer::BOOKMARKS});
}
IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest,
ShouldReportErrorIfInitialUpdatesCrossMaxCountLimit) {
// Create two bookmarks on the server under BookmarkBar with a truncated
// title.
fake_server::EntityBuilderFactory entity_builder_factory;
const std::u16string kTitle1 = u"title1";
const std::string kUrl1 = "http://www.url1.com";
fake_server_->InjectEntity(
entity_builder_factory.NewBookmarkEntityBuilder(kTitle1).BuildBookmark(
GURL(kUrl1)));
const std::u16string kTitle2 = u"title2";
const std::string kUrl2 = "http://www.url2.com";
fake_server_->InjectEntity(
entity_builder_factory.NewBookmarkEntityBuilder(kTitle2).BuildBookmark(
GURL(kUrl2)));
ASSERT_TRUE(SetupClients());
// Set a limit of 4 bookmarks. This should result in an error when we get an
// update of size 5.
LocalOrSyncableBookmarkSyncServiceFactory::GetForProfile(
GetProfile(kSingleProfileIndex))
->SetBookmarksLimitForTesting(4);
ASSERT_FALSE(GetClient(kSingleProfileIndex)
->service()
->HasAnyModelErrorForTest({syncer::BOOKMARKS}));
ASSERT_TRUE(SetupSync());
// Update of size 5 exceeds the limit.
EXPECT_TRUE(
BookmarksDataTypeErrorChecker(GetClient(kSingleProfileIndex)->service())
.Wait());
EXPECT_TRUE(GetBookmarkBarNode(kSingleProfileIndex)->children().empty());
// Bookmarks should be in an error state. Thus excluding it from the
// CheckForDataTypeFailures() check.
ExcludeDataTypesFromCheckForDataTypeFailures({syncer::BOOKMARKS});
}
// Android doesn't currently support PRE_ tests, see crbug.com/40200835 or
// crbug.com/40145099.
#if !BUILDFLAG(IS_ANDROID)
IN_PROC_BROWSER_TEST_F(
SingleClientBookmarksSyncTestWithDisabledReuploadBookmarks,
PRE_ShouldNotReploadUponFaviconLoad) {
fake_server::EntityBuilderFactory entity_builder_factory;
fake_server::BookmarkEntityBuilder bookmark_builder =
entity_builder_factory.NewBookmarkEntityBuilder("Foo Title");
// Create a legacy bookmark on the server (no |type|, |unique_position| fields
// populated). The fact that it's a legacy bookmark means any locally-produced
// specifics would be different for this bookmark (new fields like |type|
// would be populated).
std::unique_ptr<syncer::LoopbackServerEntity> bookmark =
bookmark_builder.SetGeneration(BookmarkGeneration::kValidGuidAndFullTitle)
.BuildBookmark(GURL(kBookmarkPageUrl));
fake_server_->InjectEntity(std::move(bookmark));
// Start syncing.
ASSERT_TRUE(SetupSync());
ASSERT_TRUE(
BookmarksUrlChecker(kSingleProfileIndex, GURL(kBookmarkPageUrl), 1)
.Wait());
}
IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest,
PRE_ShouldUploadUnsyncedEntityAfterRestart) {
ASSERT_TRUE(SetupSync());
const std::u16string title = u"Title";
const std::u16string new_title = u"New Title";
const GURL icon_url("http://www.google.com/favicon.ico");
const BookmarkNode* bookmark =
AddURL(kSingleProfileIndex, title, GURL(kBookmarkPageUrl));
SetFavicon(0, bookmark, icon_url, CreateFavicon(SK_ColorWHITE),
bookmarks_helper::FROM_UI);
ASSERT_TRUE(BookmarkFaviconLoadedChecker(0, GURL(kBookmarkPageUrl)).Wait());
ASSERT_TRUE(
UpdatedProgressMarkerChecker(GetSyncService(kSingleProfileIndex)).Wait());
ASSERT_TRUE(bookmarks_helper::ServerBookmarksEqualityChecker(
{{title, GURL(kBookmarkPageUrl)}},
/*cryptographer=*/nullptr)
.Wait());
// Mimic the user being offline (until the next restart), to make sure the
// entity is unsync-ed upon browser startup (next test).
fake_server::FakeServerHttpPostProvider::DisableNetwork();
SetTitle(kSingleProfileIndex, bookmark, new_title);
}
IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest,
ShouldUploadUnsyncedEntityAfterRestart) {
const std::u16string title = u"Title";
const std::u16string new_title = u"New Title";
const GURL url = GURL(kBookmarkPageUrl);
// Ensure that the server bookmark has the old title.
const std::vector<sync_pb::SyncEntity> server_bookmarks_before =
GetFakeServer()->GetSyncEntitiesByDataType(syncer::BOOKMARKS);
ASSERT_EQ(1u, server_bookmarks_before.size());
ASSERT_EQ(base::UTF16ToUTF8(title), server_bookmarks_before.front()
.specifics()
.bookmark()
.legacy_canonicalized_title());
// Ensure that local bookmark has the new title.
ASSERT_TRUE(SetupClients());
const BookmarkNode* node =
bookmarks_helper::GetUniqueNodeByURL(kSingleProfileIndex, url);
ASSERT_EQ(1u,
CountBookmarksWithTitlesMatching(kSingleProfileIndex, new_title));
// Ensure that there is a favicon on the server and local node haven't started
// loading of favicon.
ASSERT_TRUE(
server_bookmarks_before.front().specifics().bookmark().has_favicon());
ASSERT_FALSE(node->is_favicon_loading());
ASSERT_FALSE(node->is_favicon_loaded());
// Ensure that the new title eventually makes it to the server.
ASSERT_TRUE(bookmarks_helper::ServerBookmarksEqualityChecker(
{{new_title, url}},
/*cryptographer=*/nullptr)
.Wait());
// Last commit should initiate favicon loading.
ASSERT_TRUE(BookmarkFaviconLoadedChecker(kSingleProfileIndex, url).Wait());
ASSERT_TRUE(
UpdatedProgressMarkerChecker(GetSyncService(kSingleProfileIndex)).Wait());
const std::vector<sync_pb::SyncEntity> server_bookmarks =
GetFakeServer()->GetSyncEntitiesByDataType(syncer::BOOKMARKS);
ASSERT_EQ(1u, server_bookmarks.size());
// Once loaded, the favicon must be uploaded to the server.
EXPECT_TRUE(server_bookmarks.front().specifics().bookmark().has_favicon());
}
IN_PROC_BROWSER_TEST_F(
SingleClientBookmarksSyncTestWithDisabledReuploadBookmarks,
ShouldNotReploadUponFaviconLoad) {
const GURL url = GURL("http://www.foo.com");
base::HistogramTester histogram_tester;
ASSERT_TRUE(SetupClients());
ASSERT_TRUE(GetClient(kSingleProfileIndex)->AwaitEngineInitialization());
// Make sure the favicon gets loaded.
const BookmarkNode* bookmark_node =
GetUniqueNodeByURL(kSingleProfileIndex, url);
ASSERT_NE(nullptr, bookmark_node);
GetBookmarkModel(kSingleProfileIndex)->GetFavicon(bookmark_node);
ASSERT_TRUE(BookmarkFaviconLoadedChecker(kSingleProfileIndex, url).Wait());
// Make sure all local commits make it to the server.
ASSERT_TRUE(
CommittedAllNudgedChangesChecker(GetSyncService(kSingleProfileIndex))
.Wait());
// Verify that the bookmark hasn't been uploaded (no local updates issued). No
// commits are expected despite the fact that the server-side bookmark is a
// legacy bookmark without the most recent fields (e.g. GUID), because loading
// favicons should not lead to commits unless the favicon itself changed.
EXPECT_EQ(0, histogram_tester.GetBucketCount(
"Sync.DataTypeEntityChange.BOOKMARK",
syncer::DataTypeEntityChange::kLocalUpdate));
}
#endif // !BUILDFLAG(IS_ANDROID)
IN_PROC_BROWSER_TEST_F(
SingleClientBookmarksSyncTestWithEnabledReuploadBookmarks,
ShouldReuploadBookmarkAfterInitialMerge) {
ASSERT_TRUE(SetupClients());
const std::u16string title = u"Title";
fake_server::EntityBuilderFactory entity_builder_factory;
fake_server::BookmarkEntityBuilder bookmark_builder =
entity_builder_factory.NewBookmarkEntityBuilder(title);
std::unique_ptr<syncer::LoopbackServerEntity> remote_folder =
bookmark_builder
.SetGeneration(BookmarkGeneration::kValidGuidAndLegacyTitle)
.BuildFolder();
ASSERT_FALSE(remote_folder->GetSpecifics().bookmark().has_unique_position());
fake_server_->InjectEntity(std::move(remote_folder));
ASSERT_TRUE(SetupSync());
ASSERT_TRUE(bookmarks_helper::ServerBookmarksEqualityChecker(
{{title, /*url=*/GURL()}},
/*cryptographer=*/nullptr)
.Wait());
}
// Android doesn't currently support PRE_ tests, see crbug.com/1117345.
#if !BUILDFLAG(IS_ANDROID)
// Initiate reupload after restart when the feature toggle has been just enabled
// (before restart the entity is in synced state).
IN_PROC_BROWSER_TEST_F(
SingleClientBookmarksSyncTestWithEnabledReuploadPreexistingBookmarks,
PRE_ShouldReuploadForOldClients) {
ASSERT_TRUE(SetupSync());
// Make an incremental remote creation of bookmark without |unique_position|.
fake_server::EntityBuilderFactory entity_builder_factory;
fake_server::BookmarkEntityBuilder bookmark_builder =
entity_builder_factory.NewBookmarkEntityBuilder(kBookmarkTitle);
std::unique_ptr<syncer::LoopbackServerEntity> remote_folder =
bookmark_builder.SetGeneration(BookmarkGeneration::kValidGuidAndFullTitle)
.BuildBookmark(GURL(kBookmarkPageUrl));
fake_server_->InjectEntity(std::move(remote_folder));
ASSERT_TRUE(BookmarksTitleChecker(kSingleProfileIndex, kBookmarkTitle,
/*expected_count=*/1)
.Wait());
}
IN_PROC_BROWSER_TEST_F(
SingleClientBookmarksSyncTestWithEnabledReuploadPreexistingBookmarks,
ShouldReuploadForOldClients) {
// This test checks that the legacy bookmark which was stored locally will
// imply reupload to the server when reupload feature is enabled.
ASSERT_EQ(
1u, GetFakeServer()->GetSyncEntitiesByDataType(syncer::BOOKMARKS).size());
ASSERT_FALSE(GetFakeServer()
->GetSyncEntitiesByDataType(syncer::BOOKMARKS)
.front()
.specifics()
.bookmark()
.has_unique_position());
// |parent_guid| is used by BookmarkModelMatchesFakeServerChecker. It was
// introduced with |unique_position| and both fields should be reuploaded
// simultaneously.
ASSERT_FALSE(GetFakeServer()
->GetSyncEntitiesByDataType(syncer::BOOKMARKS)
.front()
.specifics()
.bookmark()
.has_parent_guid());
ASSERT_TRUE(SetupClients());
ASSERT_TRUE(GetClient(kSingleProfileIndex)->AwaitEngineInitialization());
ASSERT_TRUE(GetClient(kSingleProfileIndex)->AwaitSyncSetupCompletion());
// Run a sync cycle to trigger bookmarks reupload on browser startup. This is
// required since bookmarks get reuploaded only after the latest changes are
// downloaded to avoid uploading outdated data.
GetSyncService(kSingleProfileIndex)->TriggerRefresh({syncer::BOOKMARKS});
// Bookmark favicon will be loaded if there are local changes.
ASSERT_TRUE(
BookmarkFaviconLoadedChecker(kSingleProfileIndex, GURL(kBookmarkPageUrl))
.Wait());
EXPECT_TRUE(BookmarkModelMatchesFakeServerChecker(
kSingleProfileIndex, GetSyncService(kSingleProfileIndex),
GetFakeServer())
.Wait());
EXPECT_TRUE(GetFakeServer()
->GetSyncEntitiesByDataType(syncer::BOOKMARKS)
.front()
.specifics()
.bookmark()
.has_unique_position());
EXPECT_TRUE(GetFakeServer()
->GetSyncEntitiesByDataType(syncer::BOOKMARKS)
.front()
.specifics()
.bookmark()
.has_parent_guid());
}
#endif // !BUILDFLAG(IS_ANDROID)
IN_PROC_BROWSER_TEST_F(
SingleClientBookmarksSyncTestWithEnabledReuploadBookmarks,
ShouldReuploadBookmarkWithFaviconOnInitialMerge) {
const GURL kIconUrl("http://www.google.com/favicon.ico");
// Create a bookmark on the server which has a favicon and doesn't have GUID.
fake_server::EntityBuilderFactory entity_builder_factory;
fake_server::BookmarkEntityBuilder bookmark_builder =
entity_builder_factory.NewBookmarkEntityBuilder(kBookmarkTitle);
bookmark_builder.SetFavicon(CreateFavicon(SK_ColorRED), kIconUrl);
std::unique_ptr<syncer::LoopbackServerEntity> bookmark_entity =
bookmark_builder
.SetGeneration(BookmarkGeneration::kWithoutTitleInSpecifics)
.BuildBookmark(GURL(kBookmarkPageUrl));
ASSERT_FALSE(bookmark_entity->GetSpecifics().bookmark().has_guid());
fake_server_->InjectEntity(std::move(bookmark_entity));
base::HistogramTester histogram_tester;
ASSERT_TRUE(SetupSync());
ASSERT_TRUE(
BookmarkFaviconLoadedChecker(kSingleProfileIndex, GURL(kBookmarkPageUrl))
.Wait());
const bookmarks::BookmarkNode* bookmark =
bookmarks_helper::GetUniqueNodeByURL(kSingleProfileIndex,
GURL(kBookmarkPageUrl));
ASSERT_THAT(bookmark, NotNull());
const gfx::Image& favicon =
GetBookmarkModel(kSingleProfileIndex)->GetFavicon(bookmark);
ASSERT_FALSE(favicon.IsEmpty());
ASSERT_THAT(bookmark->icon_url(), Pointee(Eq(kIconUrl)));
// BookmarkModelMatchesFakeServerChecker uses GUIDs to verify if the local
// model matches the server bookmarks which verifies that the bookmark has
// been reuploaded.
ASSERT_TRUE(BookmarkModelMatchesFakeServerChecker(
kSingleProfileIndex, GetSyncService(kSingleProfileIndex),
GetFakeServer())
.Wait());
const std::vector<sync_pb::SyncEntity> server_bookmarks =
GetFakeServer()->GetSyncEntitiesByDataType(syncer::BOOKMARKS);
ASSERT_THAT(server_bookmarks, SizeIs(1));
EXPECT_TRUE(server_bookmarks.front().specifics().bookmark().has_guid());
EXPECT_EQ(
1, histogram_tester.GetBucketCount("Sync.DataTypeEntityChange.BOOKMARK",
/*LOCAL_UPDATE*/ 2));
EXPECT_EQ(1, histogram_tester.GetBucketCount(
"Sync.BookmarkEntityReuploadNeeded.OnInitialMerge", true));
}
IN_PROC_BROWSER_TEST_F(
SingleClientBookmarksSyncTestWithEnabledReuploadBookmarks,
ShouldReuploadUniquePositionOnIncrementalChange) {
ASSERT_TRUE(SetupSync());
// Make an incremental remote creation of bookmark.
fake_server::EntityBuilderFactory entity_builder_factory;
fake_server::BookmarkEntityBuilder bookmark_builder =
entity_builder_factory.NewBookmarkEntityBuilder(kBookmarkTitle);
std::unique_ptr<syncer::LoopbackServerEntity> remote_folder =
bookmark_builder.SetGeneration(BookmarkGeneration::kValidGuidAndFullTitle)
.BuildBookmark(GURL(kBookmarkPageUrl));
fake_server_->InjectEntity(std::move(remote_folder));
// Download entities from the fake server.
ASSERT_TRUE(BookmarksTitleChecker(kSingleProfileIndex, kBookmarkTitle,
/*expected_count=*/1)
.Wait());
// The bookmark should be unsynced at this point, but the data type is not
// nudged for commit. Verify that the next sync cycle doesn't commit the
// bookmark which should be reuploaded.
const std::u16string kTitle2 = u"Title 2";
const GURL kBookmarkPageUrl2("http://url2.com");
fake_server_->InjectEntity(
entity_builder_factory.NewBookmarkEntityBuilder(kTitle2)
.SetGeneration(BookmarkGeneration::kValidGuidAndFullTitle)
.BuildBookmark(kBookmarkPageUrl2));
ASSERT_TRUE(
BookmarksTitleChecker(kSingleProfileIndex, kTitle2, /*expected_count=*/1)
.Wait());
// Check that unique_position was not uploaded to the server yet.
EXPECT_THAT(GetFakeServer()->GetSyncEntitiesByDataType(syncer::BOOKMARKS),
Contains(Not(HasUniquePosition())).Times(2));
// Add another folder to initiate commit to the server.
AddFolder(kSingleProfileIndex, u"Folder 2");
ASSERT_TRUE(BookmarkModelMatchesFakeServerChecker(
kSingleProfileIndex, GetSyncService(kSingleProfileIndex),
GetFakeServer())
.Wait());
// All elements must have unique_position now.
EXPECT_THAT(GetFakeServer()->GetSyncEntitiesByDataType(syncer::BOOKMARKS),
Contains(HasUniquePosition()).Times(3));
}
IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest,
CommitLocalCreationWithClientTag) {
ASSERT_TRUE(SetupSync());
const std::u16string kTitle = u"Title";
const BookmarkNode* folder = AddFolder(
kSingleProfileIndex, GetOtherNode(kSingleProfileIndex), 0, kTitle);
// Wait until the local bookmark gets committed.
ASSERT_TRUE(bookmarks_helper::ServerBookmarksEqualityChecker(
{{kTitle, /*url=*/GURL()}},
/*cryptographer=*/nullptr)
.Wait());
// Verify the client tag hash was committed to the server.
std::vector<sync_pb::SyncEntity> server_bookmarks =
GetFakeServer()->GetSyncEntitiesByDataType(syncer::BOOKMARKS);
ASSERT_EQ(1u, server_bookmarks.size());
EXPECT_EQ(server_bookmarks[0].client_tag_hash(),
syncer::ClientTagHash::FromUnhashed(
syncer::BOOKMARKS, folder->uuid().AsLowercaseString())
.value());
}
IN_PROC_BROWSER_TEST_F(SingleClientBookmarksThrottlingSyncTest, DepleteQuota) {
ASSERT_TRUE(SetupClients());
// Setup custom quota params: to effectively never refill.
sync_pb::ClientCommand client_command;
client_command.set_extension_types_max_tokens(3);
client_command.set_extension_types_refill_interval_seconds(10000);
GetFakeServer()->SetClientCommand(client_command);
// Add enough bookmarks to deplete quota in the initial cycle.
const BookmarkNode* folder = GetOtherNode(kSingleProfileIndex);
// The quota is fully depleted in 3 messages. As the default number of
// entities per message on the client is 25, that requires 25*2+1 entities.
for (int i = 0; i < (25 * 2 + 1); i++) {
AddURL(kSingleProfileIndex, folder, 0,
base::ASCIIToUTF16(base::StringPrintf("url %u", i)),
GURL(base::StringPrintf("http://mail.google.com/%u", i)));
}
base::HistogramTester histogram_tester;
SetupBookmarksSync();
// All bookmarks get committed in the commit cycle but the quota gets
// depleted.
ASSERT_TRUE(BookmarkModelMatchesFakeServerChecker(
kSingleProfileIndex, GetSyncService(kSingleProfileIndex),
GetFakeServer())
.Wait());
EXPECT_EQ(1, histogram_tester.GetBucketCount(
"Sync.DataTypeCommitMessageHasDepletedQuota",
DataTypeHistogramValue(syncer::BOOKMARKS)));
// Recovering from depleted quota is tested by another test.
}
IN_PROC_BROWSER_TEST_F(SingleClientBookmarksThrottlingSyncTest,
DepletedQuotaDoesNotStopCommitCycle) {
ASSERT_TRUE(SetupClients());
// Setup custom quota params: to effectively never refill.
sync_pb::ClientCommand client_command;
client_command.set_extension_types_max_tokens(3);
client_command.set_extension_types_refill_interval_seconds(10000);
GetFakeServer()->SetClientCommand(client_command);
// Add enough bookmarks to deplete quota in the initial cycle.
const BookmarkNode* folder = GetOtherNode(kSingleProfileIndex);
// The quota is fully depleted in 3 messages. As the default number of
// entities per message on the client is 25, that requires 25*2+1 entities.
// If the browser commits 100 more entities, this means 4 more commits hit
// quota depletion.
for (int i = 0; i < (25 * 2 + 101); i++) {
AddURL(kSingleProfileIndex, folder, 0,
base::ASCIIToUTF16(base::StringPrintf("url %u", i)),
GURL(base::StringPrintf("http://mail.google.com/%u", i)));
}
base::HistogramTester histogram_tester;
SetupBookmarksSync();
// All bookmarks get committed in the commit cycle despite the quota gets
// depleted long before all is committed.
ASSERT_TRUE(BookmarkModelMatchesFakeServerChecker(
kSingleProfileIndex, GetSyncService(kSingleProfileIndex),
GetFakeServer())
.Wait());
EXPECT_EQ(4 + 1, histogram_tester.GetBucketCount(
"Sync.DataTypeCommitMessageHasDepletedQuota",
DataTypeHistogramValue(syncer::BOOKMARKS)));
}
IN_PROC_BROWSER_TEST_F(SingleClientBookmarksThrottlingSyncTest,
DoNotDepleteQuota) {
ASSERT_TRUE(SetupClients());
// Setup custom quota params: to effectively never refill.
sync_pb::ClientCommand client_command;
client_command.set_extension_types_max_tokens(4);
client_command.set_extension_types_refill_interval_seconds(10000);
GetFakeServer()->SetClientCommand(client_command);
// Add not enough bookmarks to deplete quota in the initial cycle.
const BookmarkNode* folder = GetOtherNode(kSingleProfileIndex);
// The quota is still not fully depleted after 3 messages. As the default
// number of entities per message on the client is 25, sending 2 messages
// requires 25+1 entities. One extra message is sent later.
for (int i = 0; i < (25 + 1); i++) {
AddURL(kSingleProfileIndex, folder, 0,
base::ASCIIToUTF16(base::StringPrintf("url %u", i)),
GURL(base::StringPrintf("http://mail.google.com/%u", i)));
}
SetupBookmarksSync();
ASSERT_TRUE(BookmarkModelMatchesFakeServerChecker(
kSingleProfileIndex, GetSyncService(kSingleProfileIndex),
GetFakeServer())
.Wait());
base::HistogramTester histogram_tester;
// Adding another entity does again trigger an update (normal nudge delay).
std::u16string client_title = u"Foo";
AddFolder(kSingleProfileIndex, GetOtherNode(kSingleProfileIndex), 0,
client_title);
ASSERT_TRUE(BookmarkModelMatchesFakeServerChecker(
kSingleProfileIndex, GetSyncService(kSingleProfileIndex),
GetFakeServer())
.Wait());
// There is no record in the depleted quota histogram.
histogram_tester.ExpectTotalCount(
"Sync.DataTypeCommitMessageHasDepletedQuota", 0);
histogram_tester.ExpectTotalCount("Sync.DataTypeCommitWithDepletedQuota", 0);
}
IN_PROC_BROWSER_TEST_F(SingleClientBookmarksThrottlingSyncTest,
DepleteQuotaAndRecover) {
ASSERT_TRUE(SetupClients());
// Setup custom quota params: to effectively never refill, and custom nudge
// delay of only 2 seconds.
sync_pb::ClientCommand client_command;
client_command.set_extension_types_max_tokens(3);
client_command.set_extension_types_refill_interval_seconds(10000);
client_command.set_extension_types_depleted_quota_nudge_delay_seconds(2);
GetFakeServer()->SetClientCommand(client_command);
// Add enough bookmarks to deplete quota in the initial cycle.
const BookmarkNode* folder = GetOtherNode(kSingleProfileIndex);
// The quota is fully depleted in 3 messages. As the default number of
// entities per message on the client is 25, that requires 25*2+1 entities.
for (int i = 0; i < (25 * 2 + 1); i++) {
AddURL(kSingleProfileIndex, folder, 0,
base::ASCIIToUTF16(base::StringPrintf("url %u", i)),
GURL(base::StringPrintf("http://mail.google.com/%u", i)));
}
{
base::HistogramTester histogram_tester;
SetupBookmarksSync();
ASSERT_TRUE(BookmarkModelMatchesFakeServerChecker(
kSingleProfileIndex, GetSyncService(kSingleProfileIndex),
GetFakeServer())
.Wait());
// The quota should *just* be depleted now.
EXPECT_EQ(1, histogram_tester.GetBucketCount(
"Sync.DataTypeCommitMessageHasDepletedQuota",
DataTypeHistogramValue(syncer::BOOKMARKS)));
}
// Need to send another bookmark in the next cycle. As the current cycle
// determines the next nudge delay. Thus, only now the next commit is
// scheduled in 3s from now.
AddFolder(kSingleProfileIndex, GetOtherNode(kSingleProfileIndex), 0, u"Foo");
ASSERT_TRUE(BookmarkModelMatchesFakeServerChecker(
kSingleProfileIndex, GetSyncService(kSingleProfileIndex),
GetFakeServer())
.Wait());
{
base::HistogramTester histogram_tester;
// Adding another bookmark does not trigger an immediate commit: The
// bookmarks data type is out of quota, so gets a long nudge delay.
base::TimeTicks time = base::TimeTicks::Now();
AddFolder(kSingleProfileIndex, GetOtherNode(kSingleProfileIndex), 0,
u"Bar");
// Since the extra nudge delay is only two seconds, it still manages to
// commit before test timeout.
ASSERT_TRUE(BookmarkModelMatchesFakeServerChecker(
kSingleProfileIndex, GetSyncService(kSingleProfileIndex),
GetFakeServer())
.Wait());
// Check that it takes at least one second, that should be robust enough to
// not flake.
EXPECT_GT(base::TimeTicks::Now() - time, base::Seconds(1));
EXPECT_EQ(1, histogram_tester.GetBucketCount(
"Sync.DataTypeCommitMessageHasDepletedQuota",
DataTypeHistogramValue(syncer::BOOKMARKS)));
EXPECT_GT(histogram_tester.GetBucketCount(
"Sync.DataTypeCommitWithDepletedQuota",
DataTypeHistogramValue(syncer::BOOKMARKS)),
0);
}
}
// On ChromeOS, Sync-the-feature gets started automatically once a primary
// account is signed in and the transport mode is not a thing.
#if !BUILDFLAG(IS_CHROMEOS)
class SingleClientBookmarksWithAccountStorageSyncTest
: public SingleClientBookmarksSyncTest {
public:
SingleClientBookmarksWithAccountStorageSyncTest() = default;
SingleClientBookmarksWithAccountStorageSyncTest(
const SingleClientBookmarksWithAccountStorageSyncTest&) = delete;
SingleClientBookmarksWithAccountStorageSyncTest& operator=(
const SingleClientBookmarksWithAccountStorageSyncTest&) = delete;
~SingleClientBookmarksWithAccountStorageSyncTest() override = default;
private:
base::test::ScopedFeatureList features_override_{
switches::kSyncEnableBookmarksInTransportMode};
};
IN_PROC_BROWSER_TEST_F(SingleClientBookmarksWithAccountStorageSyncTest,
ShouldDownloadDataUponSigninAndClearUponSignout) {
const std::u16string kLocalOnlyTitle = u"Local Only";
const std::u16string kAccountOnlyTitle = u"Account Only";
fake_server::EntityBuilderFactory entity_builder_factory;
fake_server::BookmarkEntityBuilder bookmark_builder =
entity_builder_factory.NewBookmarkEntityBuilder(kAccountOnlyTitle);
fake_server_->InjectEntity(bookmark_builder.BuildFolder());
ASSERT_TRUE(SetupClients());
BookmarkModel* model = GetBookmarkModel(kSingleProfileIndex);
// Create a local bookmark folder while the user is signed out.
model->AddFolder(/*parent=*/model->bookmark_bar_node(), /*index=*/0,
kLocalOnlyTitle);
ASSERT_THAT(model->bookmark_bar_node()->children(),
ElementsAre(IsFolder(kLocalOnlyTitle)));
ASSERT_THAT(model->account_bookmark_bar_node(), IsNull());
// Setup a primary account, but don't actually enable Sync-the-feature (so
// that Sync will start in transport mode).
ASSERT_TRUE(GetClient(kSingleProfileIndex)->SignInPrimaryAccount());
// Note: Depending on the state of feature flags (specifically
// kReplaceSyncPromosWithSignInPromos), Bookmarks may or may not be considered
// selected by default.
GetSyncService(kSingleProfileIndex)
->GetUserSettings()
->SetSelectedType(syncer::UserSelectableType::kBookmarks, true);
ASSERT_TRUE(GetClient(kSingleProfileIndex)->AwaitSyncTransportActive());
ASSERT_FALSE(GetSyncService(kSingleProfileIndex)->IsSyncFeatureEnabled());
ASSERT_TRUE(GetSyncService(kSingleProfileIndex)
->GetUserSettings()
->GetSelectedTypes()
.Has(syncer::UserSelectableType::kBookmarks));
ASSERT_TRUE(GetSyncService(kSingleProfileIndex)
->GetActiveDataTypes()
.Has(syncer::BOOKMARKS));
EXPECT_THAT(model->bookmark_bar_node()->children(),
ElementsAre(IsFolder(kLocalOnlyTitle)));
ASSERT_THAT(model->account_bookmark_bar_node(), NotNull());
EXPECT_THAT(model->account_bookmark_bar_node()->children(),
ElementsAre(IsFolder(kAccountOnlyTitle)));
// Sign out again.
GetClient(kSingleProfileIndex)->SignOutPrimaryAccount();
ASSERT_FALSE(GetSyncService(kSingleProfileIndex)
->GetActiveDataTypes()
.Has(syncer::BOOKMARKS));
EXPECT_THAT(model->bookmark_bar_node()->children(),
ElementsAre(IsFolder(kLocalOnlyTitle)));
EXPECT_THAT(model->account_bookmark_bar_node(), IsNull());
}
IN_PROC_BROWSER_TEST_F(SingleClientBookmarksWithAccountStorageSyncTest,
ShouldHandleMovesAcrossStorageBoundaries) {
const std::u16string kInitiallyLocalTitle = u"Initially Local";
const std::u16string kInitiallyAccountTitle = u"Initially Account";
const std::u16string kInitiallyLocalNestedBookmarkTitle =
u"Initially Local Nested";
const GURL kInitiallyLocalNestedBookmarkUrl("https://test.com");
fake_server::EntityBuilderFactory entity_builder_factory;
fake_server::BookmarkEntityBuilder bookmark_builder =
entity_builder_factory.NewBookmarkEntityBuilder(kInitiallyAccountTitle);
fake_server_->InjectEntity(bookmark_builder.BuildFolder());
ASSERT_TRUE(SetupClients());
BookmarkModel* model = GetBookmarkModel(kSingleProfileIndex);
{
const BookmarkNode* folder =
model->AddFolder(/*parent=*/model->bookmark_bar_node(), /*index=*/0,
kInitiallyLocalTitle);
model->AddURL(/*parent=*/folder, /*index=*/0,
kInitiallyLocalNestedBookmarkTitle,
kInitiallyLocalNestedBookmarkUrl);
}
// Setup a primary account, but don't actually enable Sync-the-feature (so
// that Sync will start in transport mode).
ASSERT_TRUE(GetClient(kSingleProfileIndex)->SignInPrimaryAccount());
// Note: Depending on the state of feature flags (specifically
// kReplaceSyncPromosWithSignInPromos), Bookmarks may or may not be considered
// selected by default.
GetSyncService(kSingleProfileIndex)
->GetUserSettings()
->SetSelectedType(syncer::UserSelectableType::kBookmarks, true);
ASSERT_TRUE(GetClient(kSingleProfileIndex)->AwaitSyncTransportActive());
ASSERT_FALSE(GetSyncService(kSingleProfileIndex)->IsSyncFeatureEnabled());
ASSERT_TRUE(GetSyncService(kSingleProfileIndex)
->GetUserSettings()
->GetSelectedTypes()
.Has(syncer::UserSelectableType::kBookmarks));
ASSERT_TRUE(GetSyncService(kSingleProfileIndex)
->GetActiveDataTypes()
.Has(syncer::BOOKMARKS));
ASSERT_THAT(model->bookmark_bar_node()->children(),
ElementsAre(IsFolder(kInitiallyLocalTitle)));
ASSERT_THAT(model->account_bookmark_bar_node(), NotNull());
ASSERT_THAT(model->account_bookmark_bar_node()->children(),
ElementsAre(IsFolder(kInitiallyAccountTitle)));
// Move the account folder to local only.
model->Move(model->account_bookmark_bar_node()->children().front().get(),
model->bookmark_bar_node(),
/*index=*/1);
EXPECT_TRUE(bookmarks_helper::ServerBookmarksEqualityChecker(
{}, /*cryptographer=*/nullptr)
.Wait());
EXPECT_THAT(model->account_bookmark_bar_node()->children(), IsEmpty());
EXPECT_THAT(model->bookmark_bar_node()->children(),
ElementsAre(IsFolder(kInitiallyLocalTitle),
IsFolder(kInitiallyAccountTitle)));
// Move one local folder with a child bookmark to the account.
model->Move(model->bookmark_bar_node()->children().front().get(),
model->account_bookmark_bar_node(),
/*index=*/0);
EXPECT_TRUE(bookmarks_helper::ServerBookmarksEqualityChecker(
{{kInitiallyLocalTitle, GURL()},
{kInitiallyLocalNestedBookmarkTitle,
kInitiallyLocalNestedBookmarkUrl}},
/*cryptographer=*/nullptr)
.Wait());
EXPECT_THAT(model->account_bookmark_bar_node()->children(),
ElementsAre(IsFolder(kInitiallyLocalTitle)));
EXPECT_THAT(model->bookmark_bar_node()->children(),
ElementsAre(IsFolder(kInitiallyAccountTitle)));
}
IN_PROC_BROWSER_TEST_F(SingleClientBookmarksWithAccountStorageSyncTest,
ShouldReturnLocalDataDescriptions) {
ASSERT_TRUE(SetupClients());
BookmarkModel* model = GetBookmarkModel(kSingleProfileIndex);
// Create the following structure while the user is signed out:
// bookmark_bar
// l1_folder
// l2_folder
// l3_url
// l2_url
// l1_url
const bookmarks::BookmarkNode* l1_folder = model->AddFolder(
/*parent=*/model->bookmark_bar_node(), /*index=*/0, u"l1_folder");
const bookmarks::BookmarkNode* l2_folder =
model->AddFolder(/*parent=*/l1_folder, /*index=*/0, u"l2_folder");
model->AddURL(/*parent=*/l2_folder, /*index=*/0, u"l3_url",
GURL("http://l3.com/"));
model->AddURL(/*parent=*/l1_folder, /*index=*/1, u"l2_url",
GURL("http://l2.com/"));
const bookmarks::BookmarkNode* l1_bookmark =
model->AddURL(/*parent=*/model->bookmark_bar_node(),
/*index=*/1, u"l1_url", GURL("http://l1.com/"));
// Setup a primary account, but don't actually enable Sync-the-feature (so
// that Sync will start in transport mode).
ASSERT_TRUE(GetClient(kSingleProfileIndex)->SignInPrimaryAccount());
// Note: Depending on the state of feature flags (specifically
// kReplaceSyncPromosWithSignInPromos), Bookmarks may or may not be considered
// selected by default.
GetSyncService(kSingleProfileIndex)
->GetUserSettings()
->SetSelectedType(syncer::UserSelectableType::kBookmarks, true);
ASSERT_TRUE(GetClient(kSingleProfileIndex)->AwaitSyncTransportActive());
ASSERT_FALSE(GetSyncService(kSingleProfileIndex)->IsSyncFeatureEnabled());
ASSERT_TRUE(GetSyncService(kSingleProfileIndex)
->GetUserSettings()
->GetSelectedTypes()
.Has(syncer::UserSelectableType::kBookmarks));
ASSERT_TRUE(GetSyncService(kSingleProfileIndex)
->GetActiveDataTypes()
.Has(syncer::BOOKMARKS));
ASSERT_THAT(
model->bookmark_bar_node()->children(),
ElementsAre(
IsFolder(
u"l1_folder",
ElementsAre(IsFolder(u"l2_folder",
ElementsAre(IsUrlBookmark(
u"l3_url", GURL("http://l3.com/")))),
IsUrlBookmark(u"l2_url", GURL("http://l2.com/")))),
IsUrlBookmark(u"l1_url", GURL("http://l1.com/"))));
EXPECT_THAT(
GetClient(kSingleProfileIndex)
->GetLocalDataDescriptionAndWait(syncer::BOOKMARKS),
MatchesLocalDataDescription(
syncer::DataType::BOOKMARKS,
// The full list includes only the top-level items. The bookmark count
// includes the URLs in the subtree (but not the folder).
ElementsAre(
MatchesLocalDataItemModel(
l1_folder->id(), syncer::LocalDataItemModel::FolderIcon(),
"l1_folder", _),
MatchesLocalDataItemModel(l1_bookmark->id(),
syncer::LocalDataItemModel::PageUrlIcon(
GURL("http://l1.com/")),
/*title=*/"l1_url",
/*subtitle=*/IsEmpty())),
/*item_count=*/3u,
/*domains=*/ElementsAre("l1.com", "l2.com", "l3.com"),
/*domain_count=*/3u));
}
IN_PROC_BROWSER_TEST_F(SingleClientBookmarksWithAccountStorageSyncTest,
ShouldBatchUploadAllEntries) {
const std::u16string kTitle1 = u"Title1";
const GURL kUrl1("http://url1.com/");
const std::u16string kTitle2 = u"Title2";
const GURL kUrl2("http://url2.com/");
ASSERT_TRUE(SetupClients());
BookmarkModel* model = GetBookmarkModel(kSingleProfileIndex);
model->AddURL(/*parent=*/model->bookmark_bar_node(),
/*index=*/0, kTitle1, kUrl1);
model->AddURL(/*parent=*/model->bookmark_bar_node(),
/*index=*/1, kTitle2, kUrl2);
ASSERT_THAT(model->account_bookmark_bar_node(), IsNull());
// Setup a primary account, but don't actually enable Sync-the-feature (so
// that Sync will start in transport mode).
ASSERT_TRUE(GetClient(kSingleProfileIndex)->SignInPrimaryAccount());
// Note: Depending on the state of feature flags (specifically
// kReplaceSyncPromosWithSignInPromos), Bookmarks may or may not be considered
// selected by default.
GetSyncService(kSingleProfileIndex)
->GetUserSettings()
->SetSelectedType(syncer::UserSelectableType::kBookmarks, true);
ASSERT_TRUE(GetClient(kSingleProfileIndex)->AwaitSyncTransportActive());
ASSERT_FALSE(GetSyncService(kSingleProfileIndex)->IsSyncFeatureEnabled());
ASSERT_TRUE(GetSyncService(kSingleProfileIndex)
->GetUserSettings()
->GetSelectedTypes()
.Has(syncer::UserSelectableType::kBookmarks));
ASSERT_TRUE(GetSyncService(kSingleProfileIndex)
->GetActiveDataTypes()
.Has(syncer::BOOKMARKS));
ASSERT_THAT(model->bookmark_bar_node()->children(),
ElementsAre(IsUrlBookmark(kTitle1, kUrl1),
IsUrlBookmark(kTitle2, kUrl2)));
ASSERT_THAT(model->account_bookmark_bar_node(), NotNull());
ASSERT_THAT(GetFakeServer()->GetSyncEntitiesByDataType(syncer::BOOKMARKS),
IsEmpty());
GetSyncService(kSingleProfileIndex)
->TriggerLocalDataMigration({syncer::BOOKMARKS});
EXPECT_TRUE(bookmarks_helper::ServerBookmarksEqualityChecker(
{{kTitle1, kUrl1}, {kTitle2, kUrl2}},
/*cryptographer=*/nullptr)
.Wait());
EXPECT_THAT(model->account_bookmark_bar_node()->children(),
ElementsAre(IsUrlBookmark(kTitle1, kUrl1),
IsUrlBookmark(kTitle2, kUrl2)));
EXPECT_THAT(model->bookmark_bar_node()->children(), IsEmpty());
}
IN_PROC_BROWSER_TEST_F(SingleClientBookmarksWithAccountStorageSyncTest,
ShouldBatchUploadSomeEntries) {
const std::u16string kTitle1 = u"Title1";
const GURL kUrl1("http://url1.com/");
const std::u16string kTitle2 = u"Title2";
const GURL kUrl2("http://url2.com/");
ASSERT_TRUE(SetupClients());
BookmarkModel* model = GetBookmarkModel(kSingleProfileIndex);
const bookmarks::BookmarkNode* bookmark1 =
model->AddURL(/*parent=*/model->bookmark_bar_node(),
/*index=*/0, kTitle1, kUrl1);
model->AddURL(/*parent=*/model->bookmark_bar_node(),
/*index=*/1, kTitle2, kUrl2);
ASSERT_THAT(model->account_bookmark_bar_node(), IsNull());
// Setup a primary account, but don't actually enable Sync-the-feature (so
// that Sync will start in transport mode).
ASSERT_TRUE(GetClient(kSingleProfileIndex)->SignInPrimaryAccount());
// Note: Depending on the state of feature flags (specifically
// kReplaceSyncPromosWithSignInPromos), Bookmarks may or may not be considered
// selected by default.
GetSyncService(kSingleProfileIndex)
->GetUserSettings()
->SetSelectedType(syncer::UserSelectableType::kBookmarks, true);
ASSERT_TRUE(GetClient(kSingleProfileIndex)->AwaitSyncTransportActive());
ASSERT_FALSE(GetSyncService(kSingleProfileIndex)->IsSyncFeatureEnabled());
ASSERT_TRUE(GetSyncService(kSingleProfileIndex)
->GetUserSettings()
->GetSelectedTypes()
.Has(syncer::UserSelectableType::kBookmarks));
ASSERT_TRUE(GetSyncService(kSingleProfileIndex)
->GetActiveDataTypes()
.Has(syncer::BOOKMARKS));
ASSERT_THAT(model->bookmark_bar_node()->children(),
ElementsAre(IsUrlBookmark(kTitle1, kUrl1),
IsUrlBookmark(kTitle2, kUrl2)));
ASSERT_THAT(model->account_bookmark_bar_node(), NotNull());
ASSERT_THAT(GetFakeServer()->GetSyncEntitiesByDataType(syncer::BOOKMARKS),
IsEmpty());
GetSyncService(kSingleProfileIndex)
->TriggerLocalDataMigrationForItems(
{{syncer::BOOKMARKS, {bookmark1->id()}}});
EXPECT_TRUE(bookmarks_helper::ServerBookmarksEqualityChecker(
{{kTitle1, kUrl1}},
/*cryptographer=*/nullptr)
.Wait());
EXPECT_THAT(model->account_bookmark_bar_node()->children(),
ElementsAre(IsUrlBookmark(kTitle1, kUrl1)));
EXPECT_THAT(model->bookmark_bar_node()->children(),
ElementsAre(IsUrlBookmark(kTitle2, kUrl2)));
}
// Regression test for crbug.com/329278277: turning sync-the-feature on, then
// off, and later signing in with account bookmarks enabled should lead to all
// bookmarks being duplicated (local bookmarks and account bookmarks). The user
// needs to take explicit action (e.g. exercise batch upload flow) to clean up
// these duplicates (but this part is not covered in the test).
IN_PROC_BROWSER_TEST_F(
SingleClientBookmarksWithAccountStorageSyncTest,
ShouldExposeDuplicatedBookmarksAfterTurningSyncOffAndSignIn) {
const std::u16string kTitle1 = u"Title 1";
const std::u16string kTitle2 = u"Title 2";
ASSERT_TRUE(SetupClients());
BookmarkModel* model = GetBookmarkModel(kSingleProfileIndex);
// Create two local folders while the user is signed out and sync is off.
AddFolder(kSingleProfileIndex, /*parent=*/model->bookmark_bar_node(),
/*index=*/0, kTitle1);
AddFolder(kSingleProfileIndex, /*parent=*/model->bookmark_bar_node(),
/*index=*/1, kTitle2);
ASSERT_TRUE(SetupSync());
ASSERT_TRUE(bookmarks_helper::ServerBookmarksEqualityChecker(
{{kTitle1, /*url=*/GURL()}, {kTitle2, /*url=*/GURL()}},
/*cryptographer=*/nullptr)
.Wait());
ASSERT_THAT(model->account_bookmark_bar_node(), IsNull());
// Turn Sync off by removing the primary account.
GetClient(0)->SignOutPrimaryAccount();
ASSERT_THAT(model->bookmark_bar_node()->children(),
ElementsAre(IsFolder(kTitle1), IsFolder(kTitle2)));
// Sign in again, but don't actually enable Sync-the-feature (so that Sync
// will start in transport mode).
ASSERT_TRUE(GetClient(kSingleProfileIndex)->SignInPrimaryAccount());
// Note: Depending on the state of feature flags (specifically
// kReplaceSyncPromosWithSignInPromos), Bookmarks may or may not be considered
// selected by default.
GetSyncService(kSingleProfileIndex)
->GetUserSettings()
->SetSelectedType(syncer::UserSelectableType::kBookmarks, true);
ASSERT_TRUE(GetClient(kSingleProfileIndex)->AwaitSyncTransportActive());
ASSERT_FALSE(GetSyncService(kSingleProfileIndex)->IsSyncFeatureEnabled());
ASSERT_TRUE(GetSyncService(kSingleProfileIndex)
->GetUserSettings()
->GetSelectedTypes()
.Has(syncer::UserSelectableType::kBookmarks));
ASSERT_TRUE(GetSyncService(kSingleProfileIndex)
->GetActiveDataTypes()
.Has(syncer::BOOKMARKS));
ASSERT_THAT(model->account_bookmark_bar_node(), NotNull());
// The folders should now be duplicated in local and account bookmarks.
EXPECT_THAT(model->bookmark_bar_node()->children(),
ElementsAre(IsFolder(kTitle1), IsFolder(kTitle2)));
EXPECT_THAT(model->account_bookmark_bar_node()->children(),
ElementsAre(IsFolder(kTitle1), IsFolder(kTitle2)));
// Move one folder individually from local to account, involving a UUID
// collision.
ASSERT_EQ(2u, model->bookmark_bar_node()->children().size());
ASSERT_EQ(model->bookmark_bar_node()->children()[0]->uuid(),
model->account_bookmark_bar_node()->children()[0]->uuid());
model->Move(model->bookmark_bar_node()->children()[0].get(),
/*new_parent=*/model->account_bookmark_bar_node(),
/*index=*/model->account_bookmark_bar_node()->children().size());
EXPECT_THAT(
model->account_bookmark_bar_node()->children(),
ElementsAre(IsFolder(kTitle1), IsFolder(kTitle2), IsFolder(kTitle1)));
// Move one folder individually from account to local, involving a UUID
// collision.
ASSERT_EQ(1u, model->bookmark_bar_node()->children().size());
ASSERT_EQ(model->bookmark_bar_node()->children()[0]->uuid(),
model->account_bookmark_bar_node()->children()[1]->uuid());
model->Move(model->account_bookmark_bar_node()->children()[1].get(),
/*new_parent=*/model->bookmark_bar_node(),
/*index=*/model->bookmark_bar_node()->children().size());
}
// Android doesn't currently support PRE_ tests, see crbug.com/1117345.
#if !BUILDFLAG(IS_ANDROID)
IN_PROC_BROWSER_TEST_F(SingleClientBookmarksWithAccountStorageSyncTest,
PRE_PersistAccountBookmarksAcrossRestarts) {
const std::u16string kInitiallyLocalTitle = u"Initially Local";
const std::u16string kInitiallyAccountTitle = u"Initially Account";
fake_server::EntityBuilderFactory entity_builder_factory;
fake_server::BookmarkEntityBuilder bookmark_builder =
entity_builder_factory.NewBookmarkEntityBuilder(kInitiallyAccountTitle);
fake_server_->InjectEntity(bookmark_builder.BuildFolder());
ASSERT_TRUE(SetupClients());
BookmarkModel* model = GetBookmarkModel(kSingleProfileIndex);
model->AddFolder(/*parent=*/model->bookmark_bar_node(), /*index=*/0,
kInitiallyLocalTitle);
// Setup a primary account, but don't actually enable Sync-the-feature (so
// that Sync will start in transport mode).
ASSERT_TRUE(GetClient(kSingleProfileIndex)->SignInPrimaryAccount());
// Note: Depending on the state of feature flags (specifically
// kReplaceSyncPromosWithSignInPromos), Bookmarks may or may not be considered
// selected by default.
GetSyncService(kSingleProfileIndex)
->GetUserSettings()
->SetSelectedType(syncer::UserSelectableType::kBookmarks, true);
ASSERT_TRUE(GetClient(kSingleProfileIndex)->AwaitSyncTransportActive());
ASSERT_FALSE(GetSyncService(kSingleProfileIndex)->IsSyncFeatureEnabled());
ASSERT_TRUE(GetSyncService(kSingleProfileIndex)
->GetUserSettings()
->GetSelectedTypes()
.Has(syncer::UserSelectableType::kBookmarks));
ASSERT_TRUE(GetSyncService(kSingleProfileIndex)
->GetActiveDataTypes()
.Has(syncer::BOOKMARKS));
ASSERT_THAT(model->bookmark_bar_node()->children(),
ElementsAre(IsFolder(kInitiallyLocalTitle)));
ASSERT_THAT(model->account_bookmark_bar_node(), NotNull());
ASSERT_THAT(model->account_bookmark_bar_node()->children(),
ElementsAre(IsFolder(kInitiallyAccountTitle)));
}
IN_PROC_BROWSER_TEST_F(SingleClientBookmarksWithAccountStorageSyncTest,
PersistAccountBookmarksAcrossRestarts) {
// Same values as in the PRE_ test.
const std::u16string kInitiallyLocalTitle = u"Initially Local";
const std::u16string kInitiallyAccountTitle = u"Initially Account";
// Mimic the user being offline to verify that account bookmarks are loaded
// from disk instead of being redownloaded.
fake_server::FakeServerHttpPostProvider::DisableNetwork();
ASSERT_TRUE(SetupClients());
ASSERT_TRUE(GetClient(kSingleProfileIndex)->AwaitEngineInitialization());
ASSERT_FALSE(GetSyncService(kSingleProfileIndex)->IsSyncFeatureEnabled());
ASSERT_TRUE(GetSyncService(kSingleProfileIndex)
->GetUserSettings()
->GetSelectedTypes()
.Has(syncer::UserSelectableType::kBookmarks));
BookmarkModel* model = GetBookmarkModel(kSingleProfileIndex);
// Local bookmarks should continue to exist (sanity-checking fixture).
ASSERT_THAT(model->bookmark_bar_node()->children(),
ElementsAre(IsFolder(kInitiallyLocalTitle)));
// Account bookmarks should continue existing even while offline.
ASSERT_THAT(model->account_bookmark_bar_node(), NotNull());
EXPECT_THAT(model->account_bookmark_bar_node()->children(),
ElementsAre(IsFolder(kInitiallyAccountTitle)));
}
IN_PROC_BROWSER_TEST_F(SingleClientBookmarksWithAccountStorageSyncTest,
PRE_ShouldPersistIfInitialUpdatesCrossMaxCountLimit) {
// Create two bookmarks on the server under BookmarkBar with a truncated
// title.
fake_server::EntityBuilderFactory entity_builder_factory;
const std::u16string kTitle1 = u"title1";
const std::string kUrl1 = "http://www.url1.com";
fake_server_->InjectEntity(
entity_builder_factory.NewBookmarkEntityBuilder(kTitle1).BuildBookmark(
GURL(kUrl1)));
const std::u16string kTitle2 = u"title2";
const std::string kUrl2 = "http://www.url2.com";
fake_server_->InjectEntity(
entity_builder_factory.NewBookmarkEntityBuilder(kTitle2).BuildBookmark(
GURL(kUrl2)));
ASSERT_TRUE(SetupClients());
// Set a limit of 4 bookmarks. This should result in an error when we get an
// update of size 5.
AccountBookmarkSyncServiceFactory::GetForProfile(
GetProfile(kSingleProfileIndex))
->SetBookmarksLimitForTesting(4);
// Setup a primary account, but don't actually enable Sync-the-feature (so
// that Sync will start in transport mode).
ASSERT_TRUE(GetClient(kSingleProfileIndex)->SignInPrimaryAccount());
// Note: Depending on the state of feature flags (specifically
// kReplaceSyncPromosWithSignInPromos), Bookmarks may or may not be considered
// selected by default.
GetSyncService(kSingleProfileIndex)
->GetUserSettings()
->SetSelectedType(syncer::UserSelectableType::kBookmarks, true);
// Update of size 5 exceeds the limit.
EXPECT_TRUE(
BookmarksDataTypeErrorChecker(GetClient(kSingleProfileIndex)->service())
.Wait());
BookmarkModel* model = GetBookmarkModel(kSingleProfileIndex);
EXPECT_THAT(model->account_bookmark_bar_node(), IsNull());
EXPECT_THAT(model->account_other_node(), IsNull());
EXPECT_THAT(model->account_mobile_node(), IsNull());
// Bookmarks should be in an error state. Thus excluding it from the
// CheckForDataTypeFailures() check.
ExcludeDataTypesFromCheckForDataTypeFailures({syncer::BOOKMARKS});
}
IN_PROC_BROWSER_TEST_F(SingleClientBookmarksWithAccountStorageSyncTest,
ShouldPersistIfInitialUpdatesCrossMaxCountLimit) {
ASSERT_TRUE(SetupClients());
ASSERT_TRUE(GetClient(kSingleProfileIndex)->AwaitEngineInitialization());
// The fact that too many bookmarks were downloaded should have been persisted
// and hence remembered now. Note that this test doesn't override
// SetBookmarksLimitForTesting(), so the error must have been detected in
// the PRE_ test.
EXPECT_TRUE(
BookmarksDataTypeErrorChecker(GetClient(kSingleProfileIndex)->service())
.Wait());
// Account permanent nodes should remain absent.
BookmarkModel* model = GetBookmarkModel(kSingleProfileIndex);
EXPECT_THAT(model->account_bookmark_bar_node(), IsNull());
EXPECT_THAT(model->account_other_node(), IsNull());
EXPECT_THAT(model->account_mobile_node(), IsNull());
// Bookmarks should be in an error state. Thus excluding it from the
// CheckForDataTypeFailures() check.
ExcludeDataTypesFromCheckForDataTypeFailures({syncer::BOOKMARKS});
}
IN_PROC_BROWSER_TEST_F(
SingleClientBookmarksSyncTest,
PRE_ShouldAllowRecoverIflLocalBookmarksDeletedBelowMaxCountLimit) {
ASSERT_TRUE(SetupClients());
LocalOrSyncableBookmarkSyncServiceFactory::GetForProfile(
GetProfile(kSingleProfileIndex))
->SetBookmarksLimitForTesting(4);
ASSERT_TRUE(SetupSync());
ASSERT_FALSE(GetClient(kSingleProfileIndex)
->service()
->HasAnyModelErrorForTest({syncer::BOOKMARKS}));
// Add 2 new bookmarks to exceed the limit.
const BookmarkNode* bookmark_bar_node =
GetBookmarkBarNode(kSingleProfileIndex);
ASSERT_TRUE(AddURL(kSingleProfileIndex,
/*parent=*/bookmark_bar_node, /*index=*/0, u"title0",
GURL("http://www.url0.com")));
ASSERT_TRUE(AddURL(kSingleProfileIndex,
/*parent=*/bookmark_bar_node, /*index=*/1, u"title1",
GURL("http://www.url1.com")));
EXPECT_TRUE(
BookmarksDataTypeErrorChecker(GetClient(kSingleProfileIndex)->service())
.Wait());
// Delete one bookmark to bring the count below the limit.
Remove(kSingleProfileIndex, bookmark_bar_node, /*index=*/0);
// Bookmarks should be in an error state. Thus excluding it from the
// CheckForDataTypeFailures() check.
ExcludeDataTypesFromCheckForDataTypeFailures({syncer::BOOKMARKS});
}
IN_PROC_BROWSER_TEST_F(
SingleClientBookmarksSyncTest,
ShouldAllowRecoverIflLocalBookmarksDeletedBelowMaxCountLimit) {
ASSERT_TRUE(SetupClients());
LocalOrSyncableBookmarkSyncServiceFactory::GetForProfile(
GetProfile(kSingleProfileIndex))
->SetBookmarksLimitForTesting(4);
ASSERT_TRUE(SetupSync());
EXPECT_TRUE(GetSyncService(kSingleProfileIndex)
->GetActiveDataTypes()
.Has(syncer::BOOKMARKS));
EXPECT_FALSE(GetClient(kSingleProfileIndex)
->service()
->HasAnyModelErrorForTest({syncer::BOOKMARKS}));
}
#endif // !BUILDFLAG(IS_ANDROID)
// Android doesn't currently support PRE_ tests, see crbug.com/40200835 or
// crbug.com/40145099.
#if !BUILDFLAG(IS_ANDROID)
class SingleClientBookmarksSyncTestWithEnabledMigrateSyncingUserToSignedIn
: public SingleClientBookmarksWithAccountStorageSyncTest {
protected:
SingleClientBookmarksSyncTestWithEnabledMigrateSyncingUserToSignedIn() {
if (content::IsPreTest()) {
features_override_.InitAndDisableFeature(
switches::kMigrateSyncingUserToSignedIn);
} else {
features_override_.InitWithFeatures(
/*enabled_features=*/{syncer::kReplaceSyncPromosWithSignInPromos,
switches::kMigrateSyncingUserToSignedIn,
switches::kSyncEnableBookmarksInTransportMode},
/*disabled_features=*/{});
}
}
const std::u16string kTestTitle = u"Test Title";
private:
base::test::ScopedFeatureList features_override_;
};
IN_PROC_BROWSER_TEST_F(
SingleClientBookmarksSyncTestWithEnabledMigrateSyncingUserToSignedIn,
PRE_SyncToSigninMigration) {
ASSERT_TRUE(SetupClients());
AddFolder(kSingleProfileIndex, kTestTitle);
// Setup sync, wait for its completion, and make sure changes were synced.
ASSERT_TRUE(SetupSync());
ASSERT_TRUE(BookmarkModelMatchesFakeServerChecker(
kSingleProfileIndex, GetSyncService(kSingleProfileIndex),
GetFakeServer())
.Wait());
// Enable account storage for bookmarks.
SigninPrefs prefs(*GetProfile(kSingleProfileIndex)->GetPrefs());
const GaiaId gaia_id =
GetSyncService(kSingleProfileIndex)->GetSyncAccountInfoForPrefs().gaia;
prefs.SetBookmarksExplicitBrowserSignin(gaia_id, true);
ASSERT_TRUE(prefs.GetBookmarksExplicitBrowserSignin(gaia_id));
BookmarkModel* model = GetBookmarkModel(kSingleProfileIndex);
ASSERT_THAT(model->bookmark_bar_node()->children(),
ElementsAre(IsFolder(kTestTitle)));
// Sync-the-feature is on, so account bookmarks should not exist.
ASSERT_THAT(model->account_bookmark_bar_node(), IsNull());
}
IN_PROC_BROWSER_TEST_F(
SingleClientBookmarksSyncTestWithEnabledMigrateSyncingUserToSignedIn,
SyncToSigninMigration) {
// Mimic the user being offline to verify that account bookmarks are loaded
// from disk instead of being redownloaded.
fake_server::FakeServerHttpPostProvider::DisableNetwork();
ASSERT_TRUE(SetupClients());
ASSERT_TRUE(GetClient(kSingleProfileIndex)->AwaitEngineInitialization());
ASSERT_FALSE(GetSyncService(kSingleProfileIndex)->IsSyncFeatureEnabled());
ASSERT_TRUE(GetSyncService(kSingleProfileIndex)
->GetUserSettings()
->GetSelectedTypes()
.Has(syncer::UserSelectableType::kBookmarks));
BookmarkModel* model = GetBookmarkModel(kSingleProfileIndex);
// Local bookmarks should be empty.
ASSERT_THAT(model->bookmark_bar_node()->children(), IsEmpty());
// Account bookmarks should continue existing even while offline.
ASSERT_THAT(model->account_bookmark_bar_node(), NotNull());
EXPECT_THAT(model->account_bookmark_bar_node()->children(),
ElementsAre(IsFolder(kTestTitle)));
}
#endif // !BUILDFLAG(IS_ANDROID)
#endif // !BUILDFLAG(IS_CHROMEOS)
IN_PROC_BROWSER_TEST_F(
SingleClientBookmarksSyncTestWithEnabledClientTagHashMigration,
MigratePreExistingBookmarks) {
const base::Uuid kOriginalFolder1Uuid = base::Uuid::GenerateRandomV4();
const base::Uuid kOriginalFolder2Uuid = base::Uuid::GenerateRandomV4();
ASSERT_TRUE(SetupClients());
fake_server::EntityBuilderFactory entity_builder_factory;
fake_server_->InjectEntity(
entity_builder_factory
.NewBookmarkEntityBuilder("Folder1", kOriginalFolder1Uuid)
.SetIndex(0)
.BuildFolder());
fake_server_->InjectEntity(
entity_builder_factory
.NewBookmarkEntityBuilder("Folder2", kOriginalFolder2Uuid)
.SetIndex(1)
.EnableClientTagHash()
.BuildFolder());
fake_server_->InjectEntity(
entity_builder_factory.NewBookmarkEntityBuilder("Url1")
.SetParentGuid(kOriginalFolder1Uuid)
.SetIndex(0)
.BuildBookmark(GURL("http://url1.com")));
fake_server_->InjectEntity(
entity_builder_factory.NewBookmarkEntityBuilder("Url2")
.SetParentGuid(kOriginalFolder1Uuid)
.SetIndex(1)
.BuildBookmark(GURL("http://url2.com")));
fake_server_->InjectEntity(
entity_builder_factory.NewBookmarkEntityBuilder("Url3")
.SetParentGuid(kOriginalFolder1Uuid)
.SetIndex(2)
.EnableClientTagHash()
.BuildBookmark(GURL("http://url3.com")));
fake_server_->InjectEntity(
entity_builder_factory.NewBookmarkEntityBuilder("Url4")
.SetParentGuid(kOriginalFolder2Uuid)
.SetIndex(0)
.BuildBookmark(GURL("http://url4.com")));
fake_server_->InjectEntity(
entity_builder_factory.NewBookmarkEntityBuilder("Url5")
.SetParentGuid(kOriginalFolder2Uuid)
.SetIndex(1)
.BuildBookmark(GURL("http://url5.com")));
fake_server_->InjectEntity(
entity_builder_factory.NewBookmarkEntityBuilder("Url6")
.SetParentGuid(kOriginalFolder2Uuid)
.SetIndex(2)
.EnableClientTagHash()
.BuildBookmark(GURL("http://url6.com")));
ASSERT_EQ(
8u, GetFakeServer()->GetSyncEntitiesByDataType(syncer::BOOKMARKS).size());
ASSERT_TRUE(SetupSync());
ASSERT_THAT(
GetBookmarkBarNode(kSingleProfileIndex)->children(),
ElementsAre(
IsFolder(
u"Folder1",
ElementsAre(IsUrlBookmark(u"Url1", GURL("http://url1.com")),
IsUrlBookmark(u"Url2", GURL("http://url2.com")),
IsUrlBookmark(u"Url3", GURL("http://url3.com")))),
IsFolder(
u"Folder2",
ElementsAre(IsUrlBookmark(u"Url4", GURL("http://url4.com")),
IsUrlBookmark(u"Url5", GURL("http://url5.com")),
IsUrlBookmark(u"Url6", GURL("http://url6.com"))))));
const std::vector<sync_pb::SyncEntity> server_bookmarks =
GetFakeServer()->GetSyncEntitiesByDataType(syncer::BOOKMARKS);
EXPECT_EQ(8u, server_bookmarks.size());
for (const sync_pb::SyncEntity& entity : server_bookmarks) {
// All entities should have adopted a client tag hash.
EXPECT_TRUE(entity.has_client_tag_hash())
<< "for title " << entity.specifics().bookmark().full_title();
}
}
#if !BUILDFLAG(IS_ANDROID) && !BUILDFLAG(IS_CHROMEOS)
IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest, PRE_ComparisonMetrics) {
base::HistogramTester histogram_tester;
ASSERT_TRUE(SetupClients());
// Create one URL bookmark under Bookmarks Bar to deal with non-empty
// datasets.
ASSERT_TRUE(AddURL(kSingleProfileIndex,
GetBookmarkBarNode(kSingleProfileIndex), 0, u"Url1",
GURL("http://www.url1.com")));
ASSERT_TRUE(SetupSync(SyncTestAccount::kConsumerAccount1));
histogram_tester.ExpectUniqueSample(
kPreviouslySyncingGaiaIdMetricName,
/*sample=*/2 /*kSyncFeatureNeverPreviouslyTurnedOn*/,
/*expected_bucket_count=*/1);
// Turn Sync off by removing the primary account.
GetClient(kSingleProfileIndex)->SignOutPrimaryAccount();
// Create a second bookmark, this time under Other Bookmarks.
ASSERT_TRUE(AddURL(kSingleProfileIndex, GetOtherNode(kSingleProfileIndex), 0,
u"Url2", GURL("http://www.url2.com")));
// Turn Sync on with the same account.
ASSERT_TRUE(SetupSync(SyncTestAccount::kConsumerAccount1));
histogram_tester.ExpectBucketCount(
kPreviouslySyncingGaiaIdMetricName,
/*sample=*/3 /*kCurrentGaiaIdMatchesPreviousWithSyncFeatureOn*/,
/*expected_bucket_count=*/1);
// Sanity-check the existence of a few comparison metrics.
histogram_tester.ExpectUniqueSample(
"Sync.BookmarkModelMerger.Comparison.MatchesPreviousGaiaId."
"ConsideringAllBookmarks.ByUrl",
/*sample=*/4 /*kAccountDataIsStrictSubsetOfLocalData*/,
/*expected_bucket_count=*/1);
histogram_tester.ExpectUniqueSample(
"Sync.BookmarkModelMerger.Comparison.MatchesPreviousGaiaId."
"ConsideringAllBookmarks.ByUrlAndUuid",
/*sample=*/4 /*kAccountDataIsStrictSubsetOfLocalData*/,
/*expected_bucket_count=*/1);
histogram_tester.ExpectUniqueSample(
"Sync.BookmarkModelMerger.Comparison.MatchesPreviousGaiaId."
"UnderBookmarksBar.ByUrlAndUuid",
/*sample=*/3 /*kExactMatchNonEmpty*/,
/*expected_bucket_count=*/1);
histogram_tester.ExpectUniqueSample(
"Sync.BookmarkModelMerger.Comparison.MatchesPreviousGaiaId."
"ConsideringAllBookmarks.ByUrlAndUuid.Between1And19LocalUrlBookmarks",
/*sample=*/4 /*kAccountDataIsStrictSubsetOfLocalData*/,
/*expected_bucket_count=*/1);
histogram_tester.ExpectUniqueSample(
"Sync.BookmarkModelMerger.Comparison2.MatchesPreviousGaiaId."
"ConsideringAllBookmarks.ByUrl",
/*sample=*/8 /*kIntersectionBetween50And90Percent*/,
/*expected_bucket_count=*/1);
histogram_tester.ExpectUniqueSample(
"Sync.BookmarkModelMerger.Comparison2.MatchesPreviousGaiaId."
"ConsideringAllBookmarks.ByUrlAndUuid",
/*sample=*/8 /*kIntersectionBetween50And90Percent*/,
/*expected_bucket_count=*/1);
histogram_tester.ExpectUniqueSample(
"Sync.BookmarkModelMerger.Comparison2.MatchesPreviousGaiaId."
"UnderBookmarksBar.ByUrlAndUuid",
/*sample=*/3 /*kExactMatchNonEmpty*/,
/*expected_bucket_count=*/1);
histogram_tester.ExpectUniqueSample(
"Sync.BookmarkModelMerger.Comparison2.MatchesPreviousGaiaId."
"ConsideringAllBookmarks.ByUrlAndUuid.Between1And19LocalUrlBookmarks",
/*sample=*/8 /*kIntersectionBetween50And90Percent*/,
/*expected_bucket_count=*/1);
// Enable Sync with a different account.
GetClient(kSingleProfileIndex)->SignOutPrimaryAccount();
ASSERT_TRUE(GetClient(kSingleProfileIndex)
->SetupSync(SyncTestAccount::kConsumerAccount2));
histogram_tester.ExpectBucketCount(
kPreviouslySyncingGaiaIdMetricName,
/*sample=*/4 /*kCurrentGaiaIdDiffersPreviousWithSyncFeatureOn*/,
/*expected_bucket_count=*/1);
}
IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest, ComparisonMetrics) {
base::HistogramTester histogram_tester;
ASSERT_TRUE(SetupClients());
ASSERT_TRUE(GetClient(kSingleProfileIndex)->AwaitSyncSetupCompletion());
histogram_tester.ExpectTotalCount(kPreviouslySyncingGaiaIdMetricName, 0);
// Turn off bookmark sync specifically and turn it back on.
GetSyncService(kSingleProfileIndex)
->GetUserSettings()
->SetSelectedTypes(/*sync_everything=*/false, /*types=*/{});
ASSERT_TRUE(GetClient(kSingleProfileIndex)->AwaitSyncTransportActive());
GetSyncService(kSingleProfileIndex)
->GetUserSettings()
->SetSelectedTypes(/*sync_everything=*/false,
/*types=*/{syncer::UserSelectableType::kBookmarks});
ASSERT_TRUE(GetClient(kSingleProfileIndex)->AwaitSyncTransportActive());
// No metric should be recorded, because this sync the feature was already on
// and toggling bookmark sync off and on shouldn't pollute metrics.
histogram_tester.ExpectTotalCount(kPreviouslySyncingGaiaIdMetricName, 0);
// Turn Sync off and on with the same account. Note that `kConsumerAccount2`
// needs to be specified again because it doesn't automatically carry over
// from the PRE_ test.
GetClient(kSingleProfileIndex)->SignOutPrimaryAccount();
ASSERT_TRUE(SetupSync(SyncTestAccount::kConsumerAccount2));
// The histogram should be recorded once again.
histogram_tester.ExpectBucketCount(
kPreviouslySyncingGaiaIdMetricName,
/*sample=*/3 /*kCurrentGaiaIdMatchesPreviousWithSyncFeatureOn*/,
/*expected_bucket_count=*/1);
}
#endif // !BUILDFLAG(IS_ANDROID) && !BUILDFLAG(IS_CHROMEOS)
} // namespace
|