1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634
|
// Copyright 2019 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <string>
#include "base/strings/stringprintf.h"
#include "base/test/bind.h"
#include "build/build_config.h"
#include "chrome/browser/metrics/chrome_metrics_service_accessor.h"
#include "chrome/browser/sync/device_info_sync_service_factory.h"
#include "chrome/browser/sync/test/integration/bookmarks_helper.h"
#include "chrome/browser/sync/test/integration/device_info_helper.h"
#include "chrome/browser/sync/test/integration/sync_service_impl_harness.h"
#include "chrome/browser/sync/test/integration/sync_test.h"
#include "components/sync/base/data_type.h"
#include "components/sync/base/time.h"
#include "components/sync/protocol/device_info_specifics.pb.h"
#include "components/sync/protocol/entity_specifics.pb.h"
#include "components/sync/protocol/sync.pb.h"
#include "components/sync/protocol/sync_entity.pb.h"
#include "components/sync/protocol/sync_enums.pb.h"
#include "components/sync/test/fake_server.h"
#include "components/sync/test/fake_server_http_post_provider.h"
#include "components/sync_device_info/device_info.h"
#include "components/sync_device_info/device_info_sync_service.h"
#include "components/sync_device_info/device_info_tracker.h"
#include "components/sync_device_info/device_info_util.h"
#include "content/public/test/browser_test.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "url/gurl.h"
namespace {
using device_info_helper::HasCacheGuid;
using device_info_helper::HasSharingFields;
using syncer::DataType;
using syncer::DataTypeSet;
using testing::AllOf;
using testing::Contains;
using testing::ElementsAre;
using testing::IsEmpty;
using testing::IsSupersetOf;
using testing::Not;
using testing::UnorderedElementsAre;
MATCHER(HasFullHardwareClass, "") {
return !arg.specifics().device_info().full_hardware_class().empty();
}
MATCHER(IsFullHardwareClassEmpty, "") {
return arg.specifics().device_info().full_hardware_class().empty();
}
MATCHER_P(ModelEntryHasCacheGuid, expected_cache_guid, "") {
return arg->guid() == expected_cache_guid;
}
MATCHER_P(HasInterestedDataType, expected_data_type, "") {
for (int32_t interested_data_type_id : arg.specifics()
.device_info()
.invalidation_fields()
.interested_data_type_ids()) {
if (interested_data_type_id ==
syncer::GetSpecificsFieldNumberFromDataType(expected_data_type)) {
return true;
}
}
return false;
}
std::string CacheGuidForSuffix(int suffix) {
return base::StringPrintf("cache guid %d", suffix);
}
std::string ClientNameForSuffix(int suffix) {
return base::StringPrintf("client name %d", suffix);
}
std::string SyncUserAgentForSuffix(int suffix) {
return base::StringPrintf("sync user agent %d", suffix);
}
std::string ChromeVersionForSuffix(int suffix) {
return base::StringPrintf("chrome version %d", suffix);
}
std::string SigninScopedDeviceIdForSuffix(int suffix) {
return base::StringPrintf("signin scoped device id %d", suffix);
}
DataTypeSet DefaultInterestedDataTypes() {
return Difference(syncer::ProtocolTypes(), syncer::CommitOnlyTypes());
}
sync_pb::DeviceInfoSpecifics CreateSpecifics(
int suffix,
const std::string& fcm_registration_token,
const DataTypeSet& interested_data_types) {
sync_pb::DeviceInfoSpecifics specifics;
specifics.set_cache_guid(CacheGuidForSuffix(suffix));
specifics.set_client_name(ClientNameForSuffix(suffix));
specifics.set_device_type(sync_pb::SyncEnums_DeviceType_TYPE_LINUX);
specifics.set_sync_user_agent(SyncUserAgentForSuffix(suffix));
specifics.set_chrome_version(ChromeVersionForSuffix(suffix));
specifics.set_signin_scoped_device_id(SigninScopedDeviceIdForSuffix(suffix));
specifics.set_last_updated_timestamp(
syncer::TimeToProtoTime(base::Time::Now()));
auto& mutable_interested_data_type_ids =
*specifics.mutable_invalidation_fields()
->mutable_interested_data_type_ids();
for (DataType type : interested_data_types) {
mutable_interested_data_type_ids.Add(
syncer::GetSpecificsFieldNumberFromDataType(type));
}
if (!fcm_registration_token.empty()) {
specifics.mutable_invalidation_fields()->set_instance_id_token(
fcm_registration_token);
}
return specifics;
}
// Creates specifics for a client without sync standalone invalidations.
sync_pb::DeviceInfoSpecifics CreateSpecifics(int suffix) {
return CreateSpecifics(suffix, /*fcm_registration_token=*/"",
DefaultInterestedDataTypes());
}
// Waits for a DeviceInfo entity to be committed to the fake server (regardless
// whether the commit succeeds or not). Note that it doesn't handle disabled
// network case.
class DeviceInfoCommitChecker : public SingleClientStatusChangeChecker {
// SingleClientStatusChangeChecker is used instead of
// FakeServerMatchStatusChecker because current checker is used when there is
// an HTTP error on the fake server.
public:
DeviceInfoCommitChecker(syncer::SyncServiceImpl* service,
fake_server::FakeServer* fake_server)
: SingleClientStatusChangeChecker(service), fake_server_(fake_server) {}
// StatusChangeChecker overrides.
bool IsExitConditionSatisfied(std::ostream* os) override {
*os << "Waiting for DeviceInfo to be committed.";
sync_pb::ClientToServerMessage message;
fake_server_->GetLastCommitMessage(&message);
for (const sync_pb::SyncEntity& entity : message.commit().entries()) {
if (entity.specifics().has_device_info()) {
return true;
}
}
return false;
}
private:
const raw_ptr<fake_server::FakeServer> fake_server_;
};
class SingleClientDeviceInfoSyncTest : public SyncTest {
public:
SingleClientDeviceInfoSyncTest() : SyncTest(SINGLE_CLIENT) {}
SingleClientDeviceInfoSyncTest(const SingleClientDeviceInfoSyncTest&) =
delete;
SingleClientDeviceInfoSyncTest& operator=(
const SingleClientDeviceInfoSyncTest&) = delete;
~SingleClientDeviceInfoSyncTest() override = default;
std::string GetLocalCacheGuid() const {
return GetCacheGuid(/*profile_index=*/0);
}
syncer::DeviceInfoTracker* GetDeviceInfoTracker() {
return DeviceInfoSyncServiceFactory::GetForProfile(GetProfile(0))
->GetDeviceInfoTracker();
}
// Injects a test DeviceInfo entity to the fake server with disabled sync
// standalone invalidations, given |suffix|.
void InjectDeviceInfoEntityToServer(int suffix) {
InjectDeviceInfoSpecificsToServer(CreateSpecifics(suffix));
}
// Injects an arbitrary test DeviceInfo entity to the fake server.
void InjectDeviceInfoSpecificsToServer(
const sync_pb::DeviceInfoSpecifics& device_info_specifics) {
sync_pb::EntitySpecifics specifics;
*specifics.mutable_device_info() = device_info_specifics;
GetFakeServer()->InjectEntity(
syncer::PersistentUniqueClientEntity::CreateFromSpecificsForTesting(
/*non_unique_name=*/"",
/*client_tag=*/
syncer::DeviceInfoUtil::SpecificsToTag(specifics.device_info()),
specifics,
/*creation_time=*/0, /*last_modified_time=*/0));
}
};
#if BUILDFLAG(IS_CHROMEOS)
IN_PROC_BROWSER_TEST_F(SingleClientDeviceInfoSyncTest,
UmaEnabledSetFullHardwareClass) {
bool uma_enabled = true;
ChromeMetricsServiceAccessor::SetMetricsAndCrashReportingForTesting(
&uma_enabled);
ASSERT_TRUE(SetupSync());
EXPECT_THAT(fake_server_->GetSyncEntitiesByDataType(syncer::DEVICE_INFO),
Contains(HasFullHardwareClass()));
ChromeMetricsServiceAccessor::SetMetricsAndCrashReportingForTesting(nullptr);
}
IN_PROC_BROWSER_TEST_F(SingleClientDeviceInfoSyncTest,
UmaDisabledFullHardwareClassEmpty) {
bool uma_enabled = false;
ChromeMetricsServiceAccessor::SetMetricsAndCrashReportingForTesting(
&uma_enabled);
ASSERT_TRUE(SetupSync());
EXPECT_THAT(fake_server_->GetSyncEntitiesByDataType(syncer::DEVICE_INFO),
Contains(IsFullHardwareClassEmpty()));
ChromeMetricsServiceAccessor::SetMetricsAndCrashReportingForTesting(nullptr);
}
#else
IN_PROC_BROWSER_TEST_F(SingleClientDeviceInfoSyncTest,
UmaEnabledFullHardwareClassOnNonChromeOS) {
bool uma_enabled = true;
ChromeMetricsServiceAccessor::SetMetricsAndCrashReportingForTesting(
&uma_enabled);
ASSERT_TRUE(SetupSync());
EXPECT_THAT(fake_server_->GetSyncEntitiesByDataType(syncer::DEVICE_INFO),
Contains(IsFullHardwareClassEmpty()));
ChromeMetricsServiceAccessor::SetMetricsAndCrashReportingForTesting(nullptr);
}
#endif // BUILDFLAG(IS_CHROMEOS)
IN_PROC_BROWSER_TEST_F(SingleClientDeviceInfoSyncTest, CommitLocalDevice) {
ASSERT_TRUE(SetupSync());
// The local device should eventually be committed to the server.
EXPECT_TRUE(ServerDeviceInfoMatchChecker(
ElementsAre(HasCacheGuid(GetLocalCacheGuid())))
.Wait());
}
IN_PROC_BROWSER_TEST_F(SingleClientDeviceInfoSyncTest, DownloadRemoteDevices) {
InjectDeviceInfoEntityToServer(/*suffix=*/1);
InjectDeviceInfoEntityToServer(/*suffix=*/2);
ASSERT_TRUE(SetupSync());
// The local device may or may not already be committed at this point.
ASSERT_THAT(fake_server_->GetSyncEntitiesByDataType(syncer::DEVICE_INFO),
IsSupersetOf({HasCacheGuid(CacheGuidForSuffix(1)),
HasCacheGuid(CacheGuidForSuffix(2))}));
EXPECT_THAT(
GetDeviceInfoTracker()->GetAllDeviceInfo(),
UnorderedElementsAre(ModelEntryHasCacheGuid(GetLocalCacheGuid()),
ModelEntryHasCacheGuid(CacheGuidForSuffix(1)),
ModelEntryHasCacheGuid(CacheGuidForSuffix(2))));
}
IN_PROC_BROWSER_TEST_F(SingleClientDeviceInfoSyncTest,
DownloadRemoteDeviceWithoutChromeVersion) {
sync_pb::DeviceInfoSpecifics device_info_specifics =
CreateSpecifics(/*suffix=*/1);
device_info_specifics.clear_chrome_version();
InjectDeviceInfoSpecificsToServer(device_info_specifics);
ASSERT_TRUE(SetupSync());
// Devices without a chrome_version correspond to non-Chromium-based clients
// and should be excluded.
EXPECT_THAT(
GetDeviceInfoTracker()->GetAllChromeDeviceInfo(),
UnorderedElementsAre(ModelEntryHasCacheGuid(GetLocalCacheGuid())));
EXPECT_THAT(
GetDeviceInfoTracker()->GetAllDeviceInfo(),
UnorderedElementsAre(ModelEntryHasCacheGuid(GetLocalCacheGuid()),
ModelEntryHasCacheGuid(CacheGuidForSuffix(1))));
}
IN_PROC_BROWSER_TEST_F(SingleClientDeviceInfoSyncTest,
DownloadRemoteDeviceWithNewVersionFieldOnly) {
sync_pb::DeviceInfoSpecifics device_info_specifics =
CreateSpecifics(/*suffix=*/1);
device_info_specifics.clear_chrome_version();
device_info_specifics.mutable_chrome_version_info()->set_version_number(
"someversion");
InjectDeviceInfoSpecificsToServer(device_info_specifics);
ASSERT_TRUE(SetupSync());
// Devices without a chrome_version correspond to non-Chromium-based clients
// and should be excluded.
EXPECT_THAT(
GetDeviceInfoTracker()->GetAllDeviceInfo(),
UnorderedElementsAre(ModelEntryHasCacheGuid(GetLocalCacheGuid()),
ModelEntryHasCacheGuid(CacheGuidForSuffix(1))));
}
// On ChromeOS, Sync-the-feature gets started automatically once a primary
// account is signed in and transport mode is not a thing.
#if !BUILDFLAG(IS_CHROMEOS)
// TODO(crbug.com/40756482): Flaky on Android.
#if BUILDFLAG(IS_ANDROID)
#define MAYBE_CommitLocalDevice_TransportOnly \
DISABLED_CommitLocalDevice_TransportOnly
#else
#define MAYBE_CommitLocalDevice_TransportOnly CommitLocalDevice_TransportOnly
#endif // BUILDFLAG(IS_ANDROID)
IN_PROC_BROWSER_TEST_F(SingleClientDeviceInfoSyncTest,
MAYBE_CommitLocalDevice_TransportOnly) {
ASSERT_TRUE(SetupClients());
// Setup a primary account, but don't actually enable Sync-the-feature (so
// that Sync will start in transport mode).
ASSERT_TRUE(GetClient(0)->SignInPrimaryAccount());
ASSERT_TRUE(GetClient(0)->AwaitSyncTransportActive());
ASSERT_FALSE(GetSyncService(0)->IsSyncFeatureEnabled());
ASSERT_TRUE(GetSyncService(0)->GetActiveDataTypes().Has(syncer::DEVICE_INFO));
// The local device should eventually be committed to the server.
EXPECT_TRUE(ServerDeviceInfoMatchChecker(
ElementsAre(HasCacheGuid(GetLocalCacheGuid())))
.Wait());
}
// TODO(crbug.com/40756482): Flaky on Android.
#if BUILDFLAG(IS_ANDROID)
#define MAYBE_DownloadRemoteDevices_TransportOnly \
DISABLED_DownloadRemoteDevices_TransportOnly
#else
#define MAYBE_DownloadRemoteDevices_TransportOnly \
DownloadRemoteDevices_TransportOnly
#endif // BUILDFLAG(IS_ANDROID)
IN_PROC_BROWSER_TEST_F(SingleClientDeviceInfoSyncTest,
MAYBE_DownloadRemoteDevices_TransportOnly) {
InjectDeviceInfoEntityToServer(/*suffix=*/1);
InjectDeviceInfoEntityToServer(/*suffix=*/2);
ASSERT_TRUE(SetupClients());
// Setup a primary account, but don't actually enable Sync-the-feature (so
// that Sync will start in transport mode).
ASSERT_TRUE(GetClient(0)->SignInPrimaryAccount());
ASSERT_TRUE(GetClient(0)->AwaitSyncTransportActive());
ASSERT_FALSE(GetSyncService(0)->IsSyncFeatureEnabled());
ASSERT_TRUE(GetSyncService(0)->GetActiveDataTypes().Has(syncer::DEVICE_INFO));
EXPECT_THAT(fake_server_->GetSyncEntitiesByDataType(syncer::DEVICE_INFO),
IsSupersetOf({HasCacheGuid(CacheGuidForSuffix(1)),
HasCacheGuid(CacheGuidForSuffix(2))}));
}
#endif // !BUILDFLAG(IS_CHROMEOS)
IN_PROC_BROWSER_TEST_F(SingleClientDeviceInfoSyncTest,
ShouldSetTheOnlyClientFlag) {
ASSERT_TRUE(SetupSync());
const std::vector<sync_pb::SyncEntity> entities_before =
fake_server_->GetSyncEntitiesByDataType(syncer::DEVICE_INFO);
// Single client flag could be dropped due to a DeviceInfo update in the last
// GetUpdates request. The next sync cycle may download the latest committed
// DeviceInfo reflection and drop optimization flags. Hence, make it sure that
// there are at least 2 sync cycles and check the second one only.
bookmarks_helper::AddURL(/*profile=*/0, u"Title", GURL("http://foo.com"));
ASSERT_TRUE(bookmarks_helper::BookmarkModelMatchesFakeServerChecker(
/*profile=*/0, GetSyncService(0), GetFakeServer())
.Wait());
// Perform the second sync cycle.
bookmarks_helper::AddURL(/*profile=*/0, u"Title", GURL("http://foo.com"));
ASSERT_TRUE(bookmarks_helper::BookmarkModelMatchesFakeServerChecker(
/*profile=*/0, GetSyncService(0), GetFakeServer())
.Wait());
// Double check that DeviceInfo hasn't been committed during the test. It may
// happen if there are any DeviceInfo fields are initialized asynchronously.
const std::vector<sync_pb::SyncEntity> entities_after =
fake_server_->GetSyncEntitiesByDataType(syncer::DEVICE_INFO);
ASSERT_EQ(1U, entities_before.size());
ASSERT_EQ(1U, entities_after.size());
ASSERT_EQ(entities_before.front().mtime(), entities_after.front().mtime());
sync_pb::ClientToServerMessage message;
GetFakeServer()->GetLastCommitMessage(&message);
EXPECT_TRUE(message.commit().config_params().single_client());
EXPECT_TRUE(message.commit()
.config_params()
.single_client_with_standalone_invalidations());
}
IN_PROC_BROWSER_TEST_F(
SingleClientDeviceInfoSyncTest,
ShouldSetTheOnlyClientFlagForStandaloneInvalidationsOnly) {
// A client without standalone invalidations shouldn't affect |single_client|
// flag.
InjectDeviceInfoEntityToServer(/*suffix=*/1);
ASSERT_TRUE(SetupSync());
// Single client flag could be dropped due to a DeviceInfo update in the last
// GetUpdates request. The next sync cycle may download the latest committed
// DeviceInfo reflection and drop optimization flags. Hence, make it sure that
// there are at least 2 sync cycles and check the second one only.
bookmarks_helper::AddURL(/*profile=*/0, u"Title", GURL("http://foo.com"));
ASSERT_TRUE(bookmarks_helper::BookmarkModelMatchesFakeServerChecker(
/*profile=*/0, GetSyncService(0), GetFakeServer())
.Wait());
// Perform the second sync cycle.
bookmarks_helper::AddURL(/*profile=*/0, u"Title", GURL("http://foo.com"));
ASSERT_TRUE(bookmarks_helper::BookmarkModelMatchesFakeServerChecker(
/*profile=*/0, GetSyncService(0), GetFakeServer())
.Wait());
sync_pb::ClientToServerMessage message;
GetFakeServer()->GetLastCommitMessage(&message);
EXPECT_FALSE(message.commit().config_params().single_client());
EXPECT_TRUE(message.commit()
.config_params()
.single_client_with_standalone_invalidations());
}
IN_PROC_BROWSER_TEST_F(SingleClientDeviceInfoSyncTest,
ShouldSetTheOnlyClientFlagForDataType) {
// There is a remote client which is not interested in BOOKMARKS.
const DataTypeSet remote_interested_data_types =
Difference(DefaultInterestedDataTypes(), {syncer::BOOKMARKS});
InjectDeviceInfoSpecificsToServer(CreateSpecifics(
/*suffix=*/1, "fcm_token_1", remote_interested_data_types));
ASSERT_TRUE(SetupSync());
// Single client flag could be dropped due to a DeviceInfo update in the last
// GetUpdates request. The next sync cycle may download the latest committed
// DeviceInfo reflection and drop optimization flags. Hence, make it sure that
// there are at least 2 sync cycles and check the second one only.
bookmarks_helper::AddURL(/*profile=*/0, u"Title", GURL("http://foo.com"));
ASSERT_TRUE(bookmarks_helper::BookmarkModelMatchesFakeServerChecker(
/*profile=*/0, GetSyncService(0), GetFakeServer())
.Wait());
// Perform the second sync cycle.
bookmarks_helper::AddURL(/*profile=*/0, u"Title", GURL("http://foo.com"));
ASSERT_TRUE(bookmarks_helper::BookmarkModelMatchesFakeServerChecker(
/*profile=*/0, GetSyncService(0), GetFakeServer())
.Wait());
sync_pb::ClientToServerMessage message;
GetFakeServer()->GetLastCommitMessage(&message);
// Even though there is another active client, that client is not interested
// in the just-committed bookmark, so for the purpose of this commit, the
// committing client is the "single" one.
EXPECT_TRUE(message.commit().config_params().single_client());
EXPECT_TRUE(message.commit()
.config_params()
.single_client_with_standalone_invalidations());
}
IN_PROC_BROWSER_TEST_F(SingleClientDeviceInfoSyncTest,
ShouldNotProvideTheOnlyClientFlag) {
InjectDeviceInfoSpecificsToServer(CreateSpecifics(
/*suffix=*/1, "fcm_token_1", DefaultInterestedDataTypes()));
ASSERT_TRUE(SetupSync());
// Verify that both DeviceInfos are present on the server.
ASSERT_THAT(GetFakeServer()->GetSyncEntitiesByDataType(syncer::DEVICE_INFO),
UnorderedElementsAre(HasCacheGuid(GetLocalCacheGuid()),
HasCacheGuid(CacheGuidForSuffix(1))));
// Download all the updates from the server to prevent DeviceInfo update while
// committing.
GetSyncService(0)->TriggerRefresh({syncer::DEVICE_INFO});
// Everything's ready to verify that the next commit request contains
// single_client which is false. Commit a bookmark to trigger a commit
// request.
bookmarks_helper::AddURL(/*profile=*/0, u"Title", GURL("http://foo.com"));
ASSERT_TRUE(bookmarks_helper::BookmarkModelMatchesFakeServerChecker(
/*profile=*/0, GetSyncService(0), GetFakeServer())
.Wait());
sync_pb::ClientToServerMessage message;
GetFakeServer()->GetLastCommitMessage(&message);
EXPECT_FALSE(message.commit().config_params().single_client());
EXPECT_FALSE(message.commit()
.config_params()
.single_client_with_standalone_invalidations());
}
// This test verifies that single_client optimization flag is not set after
// DeviceInfo has been received (even within the same sync cycle).
IN_PROC_BROWSER_TEST_F(SingleClientDeviceInfoSyncTest,
ShouldNotPopulateTheOnlyClientWhenDeviceInfoUpdated) {
ASSERT_TRUE(SetupSync());
const std::vector<sync_pb::SyncEntity> server_device_infos =
GetFakeServer()->GetSyncEntitiesByDataType(syncer::DEVICE_INFO);
ASSERT_THAT(server_device_infos,
ElementsAre(HasCacheGuid(GetLocalCacheGuid())));
// Simulate going offline to have both downloading and committing updates in
// the same sync cycle.
fake_server::FakeServerHttpPostProvider::DisableNetwork();
// Add a DeviceInfo tombstone to cause a commit request (removing local
// DeviceInfo will cause its reupload).
GetFakeServer()->InjectEntity(
syncer::PersistentTombstoneEntity::CreateFromEntity(
server_device_infos.front()));
// Simulate DeviceInfo update from a new remote client.
InjectDeviceInfoEntityToServer(/*suffix=*/1);
// Simulate going online. This starts a new sync cycle with both GetUpdates
// and Commit requests.
fake_server::FakeServerHttpPostProvider::EnableNetwork();
// Waiting for a local DeviceInfo reupload.
ASSERT_TRUE(ServerDeviceInfoMatchChecker(
UnorderedElementsAre(HasCacheGuid(GetLocalCacheGuid()),
HasCacheGuid(CacheGuidForSuffix(1))))
.Wait());
sync_pb::ClientToServerMessage message;
GetFakeServer()->GetLastCommitMessage(&message);
// Verify that all the optimization flags are omitted.
EXPECT_FALSE(message.commit().config_params().single_client());
EXPECT_FALSE(message.commit()
.config_params()
.single_client_with_standalone_invalidations());
EXPECT_THAT(message.commit()
.config_params()
.fcm_registration_tokens_for_interested_clients(),
IsEmpty());
}
IN_PROC_BROWSER_TEST_F(SingleClientDeviceInfoSyncTest,
ShouldReuploadLocalDeviceIfRemovedFromServer) {
ASSERT_TRUE(SetupSync());
const std::vector<sync_pb::SyncEntity> server_device_infos =
GetFakeServer()->GetSyncEntitiesByDataType(syncer::DEVICE_INFO);
ASSERT_THAT(server_device_infos, Contains(HasCacheGuid(GetLocalCacheGuid())));
GetFakeServer()->InjectEntity(
syncer::PersistentTombstoneEntity::CreateFromEntity(
server_device_infos.front()));
// On receiving the tombstone, the client should reupload its own device info.
EXPECT_TRUE(ServerDeviceInfoMatchChecker(
ElementsAre(HasCacheGuid(GetLocalCacheGuid())))
.Wait());
}
IN_PROC_BROWSER_TEST_F(SingleClientDeviceInfoSyncTest,
ShouldRetryDeviceInfoCommitOnAuthError) {
ASSERT_TRUE(SetupSync());
GetFakeServer()->SetHttpError(net::HTTP_UNAUTHORIZED);
// Disable another data type to trigger a commit of a new DeviceInfo entity.
// Create a checker to catch a commit request before disabling the data type.
DeviceInfoCommitChecker device_info_committer_checker(GetSyncService(0),
GetFakeServer());
ASSERT_TRUE(
GetClient(0)->DisableSyncForType(syncer::UserSelectableType::kBookmarks));
ASSERT_TRUE(device_info_committer_checker.Wait());
GetFakeServer()->ClearHttpError();
// Wait for the DeviceInfo to be committed to the fake server again.
EXPECT_TRUE(ServerDeviceInfoMatchChecker(
ElementsAre(Not(HasInterestedDataType(syncer::BOOKMARKS))))
.Wait());
}
// PRE_* tests aren't supported on Android browser tests.
#if !BUILDFLAG(IS_ANDROID)
IN_PROC_BROWSER_TEST_F(SingleClientDeviceInfoSyncTest,
PRE_ShouldNotSendDeviceInfoAfterBrowserRestart) {
ASSERT_TRUE(SetupSync());
}
IN_PROC_BROWSER_TEST_F(SingleClientDeviceInfoSyncTest,
ShouldNotSendDeviceInfoAfterBrowserRestart) {
const std::vector<sync_pb::SyncEntity> entities_before =
fake_server_->GetSyncEntitiesByDataType(syncer::DEVICE_INFO);
ASSERT_TRUE(SetupClients());
ASSERT_TRUE(GetClient(0)->AwaitEngineInitialization());
ASSERT_TRUE(GetClient(0)->AwaitSyncSetupCompletion());
ASSERT_TRUE(GetClient(0)->AwaitInvalidationsStatus(/*expected_status=*/true));
bool has_local_changes = false;
base::RunLoop run_loop;
GetSyncService(0)->HasUnsyncedItemsForTest(
base::BindLambdaForTesting([&has_local_changes, &run_loop](bool result) {
has_local_changes = result;
run_loop.Quit();
}));
run_loop.Run();
const std::vector<sync_pb::SyncEntity> entities_after =
fake_server_->GetSyncEntitiesByDataType(syncer::DEVICE_INFO);
ASSERT_EQ(1U, entities_before.size());
ASSERT_EQ(1U, entities_after.size());
// Check that there are no local changes and nothing has been committed to the
// server.
EXPECT_FALSE(has_local_changes);
EXPECT_EQ(entities_before.front().mtime(), entities_after.front().mtime());
}
#endif // !BUILDFLAG(IS_ANDROID)
} // namespace
|