1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452
|
// Copyright 2012 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <stddef.h>
#include <memory>
#include <utility>
#include "base/functional/bind.h"
#include "base/strings/utf_string_conversions.h"
#include "base/test/metrics/histogram_tester.h"
#include "chrome/browser/extensions/extension_sync_data.h"
#include "chrome/browser/extensions/extension_sync_service.h"
#include "chrome/browser/extensions/launch_util.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/sync/test/integration/apps_helper.h"
#include "chrome/browser/sync/test/integration/apps_sync_test_base.h"
#include "chrome/browser/sync/test/integration/sync_app_helper.h"
#include "chrome/browser/sync/test/integration/sync_datatype_helper.h"
#include "chrome/browser/sync/test/integration/sync_integration_test_util.h"
#include "chrome/browser/sync/test/integration/sync_test.h"
#include "chrome/browser/web_applications/mojom/user_display_mode.mojom.h"
#include "chrome/browser/web_applications/preinstalled_web_apps/preinstalled_web_apps.h"
#include "chrome/browser/web_applications/web_app_helpers.h"
#include "chrome/browser/web_applications/web_app_install_info.h"
#include "chrome/common/extensions/manifest_handlers/app_launch_info.h"
#include "components/sync/base/features.h"
#include "components/sync/model/string_ordinal.h"
#include "components/sync/service/sync_service_impl.h"
#include "content/public/test/browser_test.h"
#include "content/public/test/test_utils.h"
#include "extensions/browser/app_sorting.h"
#include "extensions/browser/extension_prefs.h"
#include "extensions/browser/extension_registry.h"
#include "extensions/browser/extension_system.h"
#include "extensions/browser/launch_util.h"
#include "extensions/browser/test_extension_registry_observer.h"
#include "extensions/common/constants.h"
using apps_helper::AllProfilesHaveSameApps;
using apps_helper::DisableApp;
using apps_helper::EnableApp;
using apps_helper::GetAppLaunchOrdinalForApp;
using apps_helper::IncognitoDisableApp;
using apps_helper::IncognitoEnableApp;
using apps_helper::InstallHostedApp;
using apps_helper::InstallPlatformApp;
using apps_helper::SetAppLaunchOrdinalForApp;
using apps_helper::SetPageOrdinalForApp;
using apps_helper::UninstallApp;
namespace {
extensions::ExtensionRegistry* GetExtensionRegistry(Profile* profile) {
return extensions::ExtensionRegistry::Get(profile);
}
} // namespace
class TwoClientExtensionAppsSyncTest : public AppsSyncTestBase {
public:
TwoClientExtensionAppsSyncTest() : AppsSyncTestBase(TWO_CLIENT) {}
TwoClientExtensionAppsSyncTest(const TwoClientExtensionAppsSyncTest&) =
delete;
TwoClientExtensionAppsSyncTest& operator=(
const TwoClientExtensionAppsSyncTest&) = delete;
~TwoClientExtensionAppsSyncTest() override = default;
};
IN_PROC_BROWSER_TEST_F(TwoClientExtensionAppsSyncTest,
E2E_ENABLED(StartWithNoApps)) {
ASSERT_TRUE(ResetSyncForPrimaryAccount());
ASSERT_TRUE(SetupSync());
ASSERT_TRUE(AppsMatchChecker().Wait());
}
IN_PROC_BROWSER_TEST_F(TwoClientExtensionAppsSyncTest,
E2E_ENABLED(StartWithSameApps)) {
ASSERT_TRUE(ResetSyncForPrimaryAccount());
ASSERT_TRUE(SetupClients());
const int kNumApps = 5;
for (int i = 0; i < kNumApps; ++i) {
InstallHostedApp(GetProfile(0), i);
InstallHostedApp(GetProfile(1), i);
}
ASSERT_TRUE(SetupSync());
ASSERT_TRUE(AppsMatchChecker().Wait());
}
// Install some apps on both clients, some on only one client, some on only the
// other, and sync. Both clients should end up with all apps, and the app and
// page ordinals should be identical.
IN_PROC_BROWSER_TEST_F(TwoClientExtensionAppsSyncTest, StartWithDifferentApps) {
ASSERT_TRUE(SetupClients());
int i = 0;
const int kNumCommonApps = 5;
for (int j = 0; j < kNumCommonApps; ++i, ++j) {
InstallHostedApp(GetProfile(0), i);
InstallHostedApp(GetProfile(1), i);
}
const int kNumProfile0Apps = 10;
for (int j = 0; j < kNumProfile0Apps; ++i, ++j) {
InstallHostedApp(GetProfile(0), i);
}
const int kNumProfile1Apps = 10;
for (int j = 0; j < kNumProfile1Apps; ++i, ++j) {
InstallHostedApp(GetProfile(1), i);
}
const int kNumPlatformApps = 5;
for (int j = 0; j < kNumPlatformApps; ++i, ++j) {
InstallPlatformApp(GetProfile(1), i);
}
ASSERT_TRUE(SetupSync());
ASSERT_TRUE(AppsMatchChecker().Wait());
}
// Install some apps on both clients, then sync. Then install some apps on only
// one client, some on only the other, and then sync again. Both clients should
// end up with all apps, and the app and page ordinals should be identical.
IN_PROC_BROWSER_TEST_F(TwoClientExtensionAppsSyncTest,
E2E_ENABLED(InstallDifferentApps)) {
ASSERT_TRUE(ResetSyncForPrimaryAccount());
ASSERT_TRUE(SetupClients());
int i = 0;
const int kNumCommonApps = 5;
for (int j = 0; j < kNumCommonApps; ++i, ++j) {
InstallHostedApp(GetProfile(0), i);
InstallHostedApp(GetProfile(1), i);
}
ASSERT_TRUE(SetupSync());
const int kNumProfile0Apps = 10;
for (int j = 0; j < kNumProfile0Apps; ++i, ++j) {
InstallHostedApp(GetProfile(0), i);
}
const int kNumProfile1Apps = 10;
for (int j = 0; j < kNumProfile1Apps; ++i, ++j) {
InstallHostedApp(GetProfile(1), i);
}
ASSERT_TRUE(AppsMatchChecker().Wait());
}
IN_PROC_BROWSER_TEST_F(TwoClientExtensionAppsSyncTest, E2E_ENABLED(Add)) {
ASSERT_TRUE(ResetSyncForPrimaryAccount());
ASSERT_TRUE(SetupSync());
ASSERT_TRUE(AppsMatchChecker().Wait());
InstallHostedApp(GetProfile(0), 0);
ASSERT_TRUE(AppsMatchChecker().Wait());
}
IN_PROC_BROWSER_TEST_F(TwoClientExtensionAppsSyncTest, E2E_ENABLED(Uninstall)) {
ASSERT_TRUE(ResetSyncForPrimaryAccount());
ASSERT_TRUE(SetupSync());
ASSERT_TRUE(AppsMatchChecker().Wait());
InstallHostedApp(GetProfile(0), 0);
ASSERT_TRUE(AppsMatchChecker().Wait());
UninstallApp(GetProfile(0), 0);
ASSERT_TRUE(AppsMatchChecker().Wait());
}
// Install an app on one client, then sync. Then uninstall the app on the first
// client and sync again. Now install a new app on the first client and sync.
// Both client should only have the second app, with identical app and page
// ordinals.
IN_PROC_BROWSER_TEST_F(TwoClientExtensionAppsSyncTest,
E2E_ENABLED(UninstallThenInstall)) {
ASSERT_TRUE(ResetSyncForPrimaryAccount());
ASSERT_TRUE(SetupSync());
ASSERT_TRUE(AppsMatchChecker().Wait());
InstallHostedApp(GetProfile(0), 0);
ASSERT_TRUE(AppsMatchChecker().Wait());
UninstallApp(GetProfile(0), 0);
ASSERT_TRUE(AppsMatchChecker().Wait());
InstallHostedApp(GetProfile(0), 1);
ASSERT_TRUE(AppsMatchChecker().Wait());
}
IN_PROC_BROWSER_TEST_F(TwoClientExtensionAppsSyncTest, E2E_ENABLED(Merge)) {
ASSERT_TRUE(ResetSyncForPrimaryAccount());
ASSERT_TRUE(SetupSync());
ASSERT_TRUE(AppsMatchChecker().Wait());
InstallHostedApp(GetProfile(0), 0);
ASSERT_TRUE(AppsMatchChecker().Wait());
UninstallApp(GetProfile(0), 0);
InstallHostedApp(GetProfile(0), 1);
InstallHostedApp(GetProfile(0), 2);
InstallHostedApp(GetProfile(1), 2);
InstallHostedApp(GetProfile(1), 3);
ASSERT_TRUE(AppsMatchChecker().Wait());
}
IN_PROC_BROWSER_TEST_F(TwoClientExtensionAppsSyncTest,
E2E_ENABLED(UpdateEnableDisableApp)) {
ASSERT_TRUE(ResetSyncForPrimaryAccount());
ASSERT_TRUE(SetupSync());
ASSERT_TRUE(AppsMatchChecker().Wait());
InstallHostedApp(GetProfile(0), 0);
ASSERT_TRUE(AppsMatchChecker().Wait());
DisableApp(GetProfile(0), 0);
ASSERT_TRUE(AppsMatchChecker().Wait());
EnableApp(GetProfile(1), 0);
ASSERT_TRUE(AppsMatchChecker().Wait());
}
IN_PROC_BROWSER_TEST_F(TwoClientExtensionAppsSyncTest,
E2E_ENABLED(UpdateIncognitoEnableDisable)) {
ASSERT_TRUE(ResetSyncForPrimaryAccount());
ASSERT_TRUE(SetupSync());
ASSERT_TRUE(AppsMatchChecker().Wait());
InstallHostedApp(GetProfile(0), 0);
ASSERT_TRUE(AppsMatchChecker().Wait());
IncognitoEnableApp(GetProfile(0), 0);
ASSERT_TRUE(AppsMatchChecker().Wait());
IncognitoDisableApp(GetProfile(1), 0);
ASSERT_TRUE(AppsMatchChecker().Wait());
}
// Install the same app on both clients, then sync. Change the page ordinal on
// one client and sync. Both clients should have the updated page ordinal for
// the app.
IN_PROC_BROWSER_TEST_F(TwoClientExtensionAppsSyncTest,
E2E_ENABLED(UpdatePageOrdinal)) {
ASSERT_TRUE(ResetSyncForPrimaryAccount());
ASSERT_TRUE(SetupSync());
ASSERT_TRUE(AppsMatchChecker().Wait());
syncer::StringOrdinal initial_page =
syncer::StringOrdinal::CreateInitialOrdinal();
InstallHostedApp(GetProfile(0), 0);
ASSERT_TRUE(AppsMatchChecker().Wait());
syncer::StringOrdinal second_page = initial_page.CreateAfter();
SetPageOrdinalForApp(GetProfile(0), 0, second_page);
ASSERT_TRUE(AppsMatchChecker().Wait());
}
// Install the same app on both clients, then sync. Change the app launch
// ordinal on one client and sync. Both clients should have the updated app
// launch ordinal for the app.
IN_PROC_BROWSER_TEST_F(TwoClientExtensionAppsSyncTest,
E2E_ENABLED(UpdateAppLaunchOrdinal)) {
ASSERT_TRUE(ResetSyncForPrimaryAccount());
ASSERT_TRUE(SetupSync());
ASSERT_TRUE(AppsMatchChecker().Wait());
InstallHostedApp(GetProfile(0), 0);
ASSERT_TRUE(AppsMatchChecker().Wait());
syncer::StringOrdinal initial_position =
GetAppLaunchOrdinalForApp(GetProfile(0), 0);
syncer::StringOrdinal second_position = initial_position.CreateAfter();
SetAppLaunchOrdinalForApp(GetProfile(0), 0, second_position);
ASSERT_TRUE(AppsMatchChecker().Wait());
}
// Adjust the CWS location within a page on the first client and sync. Adjust
// which page the CWS appears on and sync. Both clients should have the same
// page and app launch ordinal values for the CWS.
IN_PROC_BROWSER_TEST_F(TwoClientExtensionAppsSyncTest,
E2E_ENABLED(UpdateCWSOrdinals)) {
ASSERT_TRUE(ResetSyncForPrimaryAccount());
ASSERT_TRUE(SetupSync());
ASSERT_TRUE(AppsMatchChecker().Wait());
// Change the app launch ordinal.
syncer::StringOrdinal cws_app_launch_ordinal =
extensions::ExtensionSystem::Get(GetProfile(0))
->app_sorting()
->GetAppLaunchOrdinal(extensions::kWebStoreAppId);
extensions::ExtensionSystem::Get(GetProfile(0))
->app_sorting()
->SetAppLaunchOrdinal(extensions::kWebStoreAppId,
cws_app_launch_ordinal.CreateAfter());
ASSERT_TRUE(AppsMatchChecker().Wait());
// Change the page ordinal.
syncer::StringOrdinal cws_page_ordinal =
extensions::ExtensionSystem::Get(GetProfile(1))
->app_sorting()
->GetPageOrdinal(extensions::kWebStoreAppId);
extensions::ExtensionSystem::Get(GetProfile(1))
->app_sorting()
->SetPageOrdinal(extensions::kWebStoreAppId,
cws_page_ordinal.CreateAfter());
ASSERT_TRUE(AppsMatchChecker().Wait());
}
// Adjust the launch type on the first client and sync. Both clients should
// have the same launch type values for the CWS.
IN_PROC_BROWSER_TEST_F(TwoClientExtensionAppsSyncTest,
E2E_ENABLED(UpdateLaunchType)) {
ASSERT_TRUE(ResetSyncForPrimaryAccount());
ASSERT_TRUE(SetupSync());
ASSERT_TRUE(AppsMatchChecker().Wait());
// Change the launch type to window.
extensions::SetLaunchType(GetProfile(1), extensions::kWebStoreAppId,
extensions::LAUNCH_TYPE_WINDOW);
ASSERT_TRUE(AppsMatchChecker().Wait());
ASSERT_EQ(extensions::GetLaunchTypePrefValue(
extensions::ExtensionPrefs::Get(GetProfile(0)),
extensions::kWebStoreAppId),
extensions::LAUNCH_TYPE_WINDOW);
// Change the launch type to regular tab.
extensions::SetLaunchType(GetProfile(1), extensions::kWebStoreAppId,
extensions::LAUNCH_TYPE_REGULAR);
ASSERT_TRUE(AppsMatchChecker().Wait());
ASSERT_EQ(extensions::GetLaunchTypePrefValue(
extensions::ExtensionPrefs::Get(GetProfile(0)),
extensions::kWebStoreAppId),
extensions::LAUNCH_TYPE_REGULAR);
}
IN_PROC_BROWSER_TEST_F(TwoClientExtensionAppsSyncTest, UnexpectedLaunchType) {
ASSERT_TRUE(SetupSync());
// Wait until sync settles before we override the apps below.
ASSERT_TRUE(AwaitQuiescence());
ASSERT_TRUE(AllProfilesHaveSameApps());
extensions::SetLaunchType(GetProfile(1), extensions::kWebStoreAppId,
extensions::LAUNCH_TYPE_REGULAR);
ASSERT_TRUE(AppsMatchChecker().Wait());
const extensions::Extension* extension =
GetExtensionRegistry(GetProfile(1))
->GetExtensionById(extensions::kWebStoreAppId,
extensions::ExtensionRegistry::EVERYTHING);
ASSERT_TRUE(extension);
ExtensionSyncService* extension_sync_service =
ExtensionSyncService::Get(GetProfile(1));
extensions::ExtensionSyncData original_data(
extension_sync_service->CreateSyncData(*extension));
// Create an invalid launch type and ensure it doesn't get down-synced. This
// simulates the case of a future launch type being added which old versions
// don't yet understand.
extensions::ExtensionSyncData invalid_launch_type_data(
*extension, original_data.enabled(), original_data.disable_reasons(),
original_data.incognito_enabled(), original_data.remote_install(),
original_data.update_url(), original_data.app_launch_ordinal(),
original_data.page_ordinal(), extensions::NUM_LAUNCH_TYPES);
extension_sync_service->ApplySyncData(invalid_launch_type_data);
// The launch type should remain the same.
ASSERT_TRUE(AppsMatchChecker().Wait());
}
namespace {
constexpr char kHostedAppId0[] = "afbaddhaooeepnpckmnneeficocjkjlg";
constexpr char kHostedAppId1[] = "gommgmjfjblhnpfknedcgjfphgkfcpip";
} // namespace
IN_PROC_BROWSER_TEST_F(TwoClientExtensionAppsSyncTest,
DefaultWebAppMigratedChromeAppSyncBlocked) {
base::HistogramTester histogram_tester;
// Inject web app migration for kHostedApp0.
web_app::ScopedTestingPreinstalledAppData preinstalled_app_data;
{
const GURL kStartUrl = GURL("https://www.example.com/start_url");
const webapps::AppId kWebAppId =
web_app::GenerateAppId(std::nullopt, kStartUrl);
web_app::ExternalInstallOptions options(
GURL("https://www.example.com/install_url"),
web_app::mojom::UserDisplayMode::kStandalone,
web_app::ExternalInstallSource::kExternalDefault);
options.user_type_allowlist = {"unmanaged"};
options.uninstall_and_replace = {kHostedAppId0};
options.only_use_app_info_factory = true;
options.app_info_factory = base::BindRepeating(
[](GURL start_url) {
auto info = web_app::WebAppInstallInfo::CreateWithStartUrlForTesting(
start_url);
info->title = u"Test app";
return info;
},
kStartUrl);
options.expected_app_id = kWebAppId;
preinstalled_app_data.apps = {std::move(options)};
}
// Profiles must be created after test migration config is set.
ASSERT_TRUE(SetupSync());
// Add kHostedApp0 to sync profile and let it sync across.
ASSERT_EQ(InstallHostedApp(GetProfile(0), 0), kHostedAppId0);
ASSERT_TRUE(AwaitQuiescence());
// kHostedApp0 should be blocked by the web app migration config.
histogram_tester.ExpectUniqueSample(
"Extensions.SyncBlockedByDefaultWebAppMigration", true, 1);
// Add kHostedApp1 and let it sync install. This should give kHostedApp0
// enough time to install in case it wasn't actually blocked. This is
// technically racy as the installs could complete in any order but it's
// unlikely given the headstart kHostedApp0 got.
ASSERT_EQ(InstallHostedApp(GetProfile(0), 1), kHostedAppId1);
struct HostedApp1Installed : public AppsStatusChangeChecker {
bool IsExitConditionSatisfied(std::ostream* os) override {
return GetExtensionRegistry(sync_datatype_helper::test()->GetProfile(1))
->enabled_extensions()
.Contains(kHostedAppId1);
}
};
ASSERT_TRUE(HostedApp1Installed().Wait());
EXPECT_FALSE(GetExtensionRegistry(GetProfile(1))
->enabled_extensions()
.Contains(kHostedAppId0));
}
// TODO(akalin): Add tests exercising:
// - Offline installation/uninstallation behavior
// - App-specific properties
|