1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398
|
// Copyright 2012 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/search_engines/template_url_service_factory.h"
#include "chrome/browser/sync/test/integration/search_engines_helper.h"
#include "chrome/browser/sync/test/integration/sync_datatype_helper.h"
#include "chrome/browser/sync/test/integration/sync_service_impl_harness.h"
#include "chrome/browser/sync/test/integration/sync_test.h"
#include "chrome/browser/sync/test/integration/updated_progress_marker_checker.h"
#include "chrome/test/base/search_test_utils.h"
#include "components/search_engines/search_engines_switches.h"
#include "components/search_engines/template_url.h"
#include "components/search_engines/template_url_service.h"
#include "components/signin/public/base/signin_switches.h"
#include "content/public/test/browser_test.h"
namespace {
using search_engines_helper::AddSearchEngine;
using search_engines_helper::AllServicesMatch;
using search_engines_helper::ChangeDefaultSearchProvider;
using search_engines_helper::DeleteSearchEngine;
using search_engines_helper::EditSearchEngine;
using search_engines_helper::GetDefaultSearchEngineKeyword;
using search_engines_helper::GetServiceForBrowserContext;
using search_engines_helper::GetVerifierService;
using search_engines_helper::HasSearchEngine;
using search_engines_helper::HasSearchEngineChecker;
using search_engines_helper::SearchEnginesMatchChecker;
using search_engines_helper::ServiceMatchesVerifier;
using search_engines_helper::TemplateURLBuilder;
class TwoClientSearchEnginesSyncTest : public SyncTest {
public:
TwoClientSearchEnginesSyncTest() : SyncTest(TWO_CLIENT) {
// The search engine pref will stop being synced when the
// `kSearchEngineChoiceTrigger` feature is enabled.
feature_list_.InitAndDisableFeature(switches::kSearchEngineChoiceTrigger);
}
~TwoClientSearchEnginesSyncTest() override = default;
bool SetupClients() override {
if (!SyncTest::SetupClients()) {
return false;
}
// In most cases this codepath should have exactly two clients, but there is
// an exception for E2E tests, where ResetSyncForPrimaryAccount()
// temporarily sets up one only.
for (int i = 0; i < num_clients(); ++i) {
search_test_utils::WaitForTemplateURLServiceToLoad(
TemplateURLServiceFactory::GetForProfile(GetProfile(i)));
}
return true;
}
private:
base::test::ScopedFeatureList feature_list_;
};
class TwoClientSearchEnginesSyncTestWithVerifier
: public TwoClientSearchEnginesSyncTest {
public:
TwoClientSearchEnginesSyncTestWithVerifier() = default;
~TwoClientSearchEnginesSyncTestWithVerifier() override = default;
bool UseVerifier() override {
// TODO(crbug.com/40724973): rewrite test to not use verifier.
return true;
}
bool SetupClients() override {
if (!TwoClientSearchEnginesSyncTest::SetupClients()) {
return false;
}
search_test_utils::WaitForTemplateURLServiceToLoad(
TemplateURLServiceFactory::GetForProfile(verifier()));
return true;
}
};
IN_PROC_BROWSER_TEST_F(TwoClientSearchEnginesSyncTest, E2E_ENABLED(Add)) {
ASSERT_TRUE(ResetSyncForPrimaryAccount());
ASSERT_TRUE(SetupSync());
// TODO(crbug.com/41453418): Ideally we could immediately assert
// AllServicesMatch(), but that's not possible today without introducing
// flakiness due to random GUIDs in prepopulated engines.
ASSERT_TRUE(SearchEnginesMatchChecker().Wait());
const std::string kKeyword = "test0";
AddSearchEngine(/*profile_index=*/0, kKeyword);
ASSERT_TRUE(HasSearchEngine(/*profile_index=*/0, kKeyword));
ASSERT_TRUE(SearchEnginesMatchChecker().Wait());
ASSERT_TRUE(HasSearchEngine(/*profile_index=*/1, kKeyword));
}
IN_PROC_BROWSER_TEST_F(TwoClientSearchEnginesSyncTest, E2E_ENABLED(Delete)) {
ASSERT_TRUE(ResetSyncForPrimaryAccount());
ASSERT_TRUE(SetupSync());
// TODO(crbug.com/41453418): Ideally we could immediately assert
// AllServicesMatch(), but that's not possible today without introducing
// flakiness due to random GUIDs in prepopulated engines.
ASSERT_TRUE(SearchEnginesMatchChecker().Wait());
const std::string kKeyword = "test0";
AddSearchEngine(/*profile_index=*/0, kKeyword);
ASSERT_TRUE(HasSearchEngine(/*profile_index=*/0, kKeyword));
ASSERT_TRUE(SearchEnginesMatchChecker().Wait());
ASSERT_TRUE(HasSearchEngine(/*profile_index=*/1, kKeyword));
DeleteSearchEngine(/*profile_index=*/0, kKeyword);
ASSERT_TRUE(SearchEnginesMatchChecker().Wait());
ASSERT_FALSE(HasSearchEngine(/*profile_index=*/1, kKeyword));
}
IN_PROC_BROWSER_TEST_F(TwoClientSearchEnginesSyncTest,
E2E_ENABLED(AddMultiple)) {
ASSERT_TRUE(ResetSyncForPrimaryAccount());
ASSERT_TRUE(SetupSync());
// TODO(crbug.com/41453418): Ideally we could immediately assert
// AllServicesMatch(), but that's not possible today without introducing
// flakiness due to random GUIDs in prepopulated engines.
ASSERT_TRUE(SearchEnginesMatchChecker().Wait());
// Add a few entries.
AddSearchEngine(/*profile_index=*/0, "test0");
AddSearchEngine(/*profile_index=*/0, "test1");
AddSearchEngine(/*profile_index=*/0, "test2");
ASSERT_TRUE(SearchEnginesMatchChecker().Wait());
}
IN_PROC_BROWSER_TEST_F(TwoClientSearchEnginesSyncTestWithVerifier, Duplicates) {
ASSERT_TRUE(SetupSync());
// TODO(crbug.com/41453418): Ideally we could immediately assert
// AllServicesMatch(), but that's not possible today without introducing
// flakiness due to random GUIDs in prepopulated engines.
ASSERT_TRUE(SearchEnginesMatchChecker().Wait());
// Add two entries with the same Name and URL (but different keywords). Note
// that we have to change the GUID of the duplicate.
TemplateURLBuilder builder("test0");
GetServiceForBrowserContext(0)->Add(builder.Build());
GetVerifierService()->Add(builder.Build());
builder.data()->SetKeyword(u"test1");
builder.data()->sync_guid = "newguid";
GetServiceForBrowserContext(0)->Add(builder.Build());
GetVerifierService()->Add(builder.Build());
ASSERT_TRUE(SearchEnginesMatchChecker().Wait());
}
IN_PROC_BROWSER_TEST_F(TwoClientSearchEnginesSyncTest,
E2E_ENABLED(UpdateKeyword)) {
ASSERT_TRUE(ResetSyncForPrimaryAccount());
ASSERT_TRUE(SetupSync());
// TODO(crbug.com/41453418): Ideally we could immediately assert
// AllServicesMatch(), but that's not possible today without introducing
// flakiness due to random GUIDs in prepopulated engines.
ASSERT_TRUE(SearchEnginesMatchChecker().Wait());
AddSearchEngine(/*profile_index=*/0, "test0");
// Change the keyword.
ASSERT_TRUE(SearchEnginesMatchChecker().Wait());
EditSearchEngine(/*profile_index=*/0, /*keyword=*/"test0", u"test0",
/*new_keyword=*/"newkeyword", "http://www.test0.com/");
ASSERT_TRUE(SearchEnginesMatchChecker().Wait());
}
IN_PROC_BROWSER_TEST_F(TwoClientSearchEnginesSyncTest, E2E_ENABLED(UpdateUrl)) {
ASSERT_TRUE(ResetSyncForPrimaryAccount());
ASSERT_TRUE(SetupSync());
// TODO(crbug.com/41453418): Ideally we could immediately assert
// AllServicesMatch(), but that's not possible today without introducing
// flakiness due to random GUIDs in prepopulated engines.
ASSERT_TRUE(SearchEnginesMatchChecker().Wait());
AddSearchEngine(/*profile_index=*/0, "test0");
ASSERT_TRUE(SearchEnginesMatchChecker().Wait());
// Change the URL.
EditSearchEngine(/*profile_index=*/0, /*keyword=*/"test0", u"test0",
/*new_keyword=*/"test0", "http://www.wikipedia.org/q=%s");
ASSERT_TRUE(SearchEnginesMatchChecker().Wait());
}
IN_PROC_BROWSER_TEST_F(TwoClientSearchEnginesSyncTest,
E2E_ENABLED(UpdateName)) {
ASSERT_TRUE(ResetSyncForPrimaryAccount());
ASSERT_TRUE(SetupSync());
// TODO(crbug.com/41453418): Ideally we could immediately assert
// AllServicesMatch(), but that's not possible today without introducing
// flakiness due to random GUIDs in prepopulated engines.
ASSERT_TRUE(SearchEnginesMatchChecker().Wait());
AddSearchEngine(/*profile_index=*/0, "test0");
ASSERT_TRUE(SearchEnginesMatchChecker().Wait());
// Change the short name.
EditSearchEngine(/*profile_index=*/0, "test0", u"New Name", "test0",
"http://www.test0.com/");
ASSERT_TRUE(SearchEnginesMatchChecker().Wait());
}
IN_PROC_BROWSER_TEST_F(TwoClientSearchEnginesSyncTest, ConflictKeyword) {
ASSERT_TRUE(SetupSync());
// TODO(crbug.com/41453418): Ideally we could immediately assert
// AllServicesMatch(), but that's not possible today without introducing
// flakiness due to random GUIDs in prepopulated engines.
ASSERT_TRUE(SearchEnginesMatchChecker().Wait());
// Add a different search engine to each client, but make their keywords
// conflict.
AddSearchEngine(/*profile_index=*/0, "test0");
AddSearchEngine(/*profile_index=*/1, "test1");
TemplateURLService* service = GetServiceForBrowserContext(1);
TemplateURL* turl = service->GetTemplateURLForKeyword(u"test1");
EXPECT_TRUE(turl);
service->ResetTemplateURL(turl, turl->short_name(), u"test0", turl->url());
ASSERT_TRUE(AwaitQuiescence());
ASSERT_TRUE(AllServicesMatch());
}
IN_PROC_BROWSER_TEST_F(TwoClientSearchEnginesSyncTest, MergeMultiple) {
ASSERT_TRUE(SetupSync());
// TODO(crbug.com/41453418): Ideally we could immediately assert
// AllServicesMatch(), but that's not possible today without introducing
// flakiness due to random GUIDs in prepopulated engines.
ASSERT_TRUE(SearchEnginesMatchChecker().Wait());
// Set up some different search engines on each client, with some interesting
// conflicts. client0: { SE0, SE1, SE2 }
AddSearchEngine(/*profile_index=*/0, "test0");
AddSearchEngine(/*profile_index=*/0, "test1");
AddSearchEngine(/*profile_index=*/0, "test2");
// client1: { SE0, SE2, SE3, SE0 + different URL }
AddSearchEngine(/*profile_index=*/1, "test0");
AddSearchEngine(/*profile_index=*/1, "test2");
AddSearchEngine(/*profile_index=*/1, "test3");
TemplateURLBuilder builder("test0");
builder.data()->SetKeyword(u"somethingelse.com");
builder.data()->SetURL("http://www.somethingelse.com/");
builder.data()->sync_guid = "somethingelse";
GetServiceForBrowserContext(1)->Add(builder.Build());
ASSERT_TRUE(AwaitQuiescence());
ASSERT_TRUE(AllServicesMatch());
}
IN_PROC_BROWSER_TEST_F(TwoClientSearchEnginesSyncTestWithVerifier,
DisableSync) {
ASSERT_TRUE(SetupSync());
// TODO(crbug.com/41453418): Ideally we could immediately assert
// AllServicesMatch(), but that's not possible today without introducing
// flakiness due to random GUIDs in prepopulated engines.
ASSERT_TRUE(SearchEnginesMatchChecker().Wait());
ASSERT_TRUE(GetClient(1)->DisableSyncForAllDatatypes());
AddSearchEngine(/*profile_index=*/0, "test0");
ASSERT_TRUE(UpdatedProgressMarkerChecker(GetSyncService(0)).Wait());
ASSERT_TRUE(ServiceMatchesVerifier(0));
ASSERT_FALSE(ServiceMatchesVerifier(1));
ASSERT_TRUE(GetClient(1)->EnableSyncForRegisteredDatatypes());
ASSERT_TRUE(AwaitQuiescence());
ASSERT_TRUE(AllServicesMatch());
}
IN_PROC_BROWSER_TEST_F(TwoClientSearchEnginesSyncTest,
E2E_ENABLED(SyncDefault)) {
ASSERT_TRUE(ResetSyncForPrimaryAccount());
ASSERT_TRUE(SetupSync());
// TODO(crbug.com/41453418): Ideally we could immediately assert
// AllServicesMatch(), but that's not possible today without introducing
// flakiness due to random GUIDs in prepopulated engines.
ASSERT_TRUE(SearchEnginesMatchChecker().Wait());
AddSearchEngine(/*profile_index=*/0, "test0");
ASSERT_TRUE(SearchEnginesMatchChecker().Wait());
// Change the default to the new search engine, sync, and ensure that it
// changed in the second client. AllServicesMatch does a default search
// provider check.
ChangeDefaultSearchProvider(/*profile_index=*/0, "test0");
ASSERT_TRUE(SearchEnginesMatchChecker().Wait());
}
// Ensure that we can change the search engine and immediately delete it
// without putting the clients out of sync.
IN_PROC_BROWSER_TEST_F(TwoClientSearchEnginesSyncTest,
E2E_ENABLED(DeleteSyncedDefault)) {
ASSERT_TRUE(ResetSyncForPrimaryAccount());
ASSERT_TRUE(SetupSync());
// TODO(crbug.com/41453418): Ideally we could immediately assert
// AllServicesMatch(), but that's not possible today without introducing
// flakiness due to random GUIDs in prepopulated engines.
ASSERT_TRUE(SearchEnginesMatchChecker().Wait());
AddSearchEngine(/*profile_index=*/0, "test0");
AddSearchEngine(/*profile_index=*/0, "test1");
ASSERT_TRUE(SearchEnginesMatchChecker().Wait());
ChangeDefaultSearchProvider(/*profile_index=*/0, "test0");
ASSERT_TRUE(SearchEnginesMatchChecker().Wait());
// Change the default on the first client and delete the old default.
ChangeDefaultSearchProvider(/*profile_index=*/0, "test1");
DeleteSearchEngine(/*profile_index=*/0, "test0");
ASSERT_TRUE(SearchEnginesMatchChecker().Wait());
}
// Same as above that forces the deletion to propagate faster than the
// preference, which is complex to deal with for the receiving client (deletion
// of the default search engine), and currently leads to search engines with
// underscores being created. This is achieved in the test by throttling
// PREFERENCES in FakeServer, which prevents the sync-ing of the default search
// engine change.
IN_PROC_BROWSER_TEST_F(TwoClientSearchEnginesSyncTest,
DeleteSyncedDefaultWithoutPrefSync) {
ASSERT_TRUE(SetupClients());
AddSearchEngine(/*profile_index=*/0, "test0");
AddSearchEngine(/*profile_index=*/0, "test1");
AddSearchEngine(/*profile_index=*/1, "test0");
AddSearchEngine(/*profile_index=*/1, "test1");
ASSERT_TRUE(SetupSync());
ChangeDefaultSearchProvider(/*profile_index=*/0, "test0");
ASSERT_TRUE(SearchEnginesMatchChecker().Wait());
// Throttle PREFERENCES to block any commits to them, which in this case
// prevents the default search engine selection from sync-ing.
GetFakeServer()->SetThrottledTypes({syncer::PREFERENCES});
// Rule out search engines with underscores existing at this point.
ASSERT_TRUE(HasSearchEngine(
/*profile_index=*/0, "test0"));
ASSERT_FALSE(HasSearchEngine(
/*profile_index=*/0, "test0_"));
ASSERT_TRUE(HasSearchEngine(
/*profile_index=*/1, "test0"));
ASSERT_FALSE(HasSearchEngine(
/*profile_index=*/1, "test0_"));
// Change the default on the first client (profile index 0) and delete the old
// default.
ChangeDefaultSearchProvider(/*profile_index=*/0, "test1");
DeleteSearchEngine(/*profile_index=*/0, "test0");
// The test needs to wait until the second client (profile index 1) receives
// the deletion. In order to do so, use the first client (profile index 0) to
// create a third search engine (test2) and wait until it gets sync-ed to the
// second client (profile index 1).
AddSearchEngine(/*profile_index=*/0, "test2");
ASSERT_TRUE(HasSearchEngineChecker(/*profile_index=*/1, "test2").Wait());
// In the receiving end (profile index 1), the deletion cannot be honored
// since it's the default search provider. Expect that it's preserved.
EXPECT_TRUE(HasSearchEngine(
/*profile_index=*/1, "test0"));
EXPECT_EQ(GetDefaultSearchEngineKeyword(/*profile_index=*/1), "test0");
// The search engine that cannot be deleted should not immediately sync back
// to profile index 0. Eventually, it likely will during reconciliation on
// sync startup, but not immediately. This is unfortunate, but less bad than
// sending an immediate undelete or creating an underscore duplicate.
// https://crbug.com/1022775
//
// To test this, we create yet another engine (test3) that we wait to be
// synced from profile index 1 to profile index 0. Then we verify that "test0"
// or "test0_" was not also synced back. (We used to create a duplicate
// underscored engine, so we verify we don't do that anymore.)
AddSearchEngine(/*profile_index=*/1, "test3");
ASSERT_TRUE(HasSearchEngineChecker(/*profile_index=*/0, "test3").Wait());
EXPECT_FALSE(HasSearchEngine(
/*profile_index=*/0, "test0"));
EXPECT_FALSE(HasSearchEngine(
/*profile_index=*/0, "test0_"));
}
} // namespace
|