1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
|
// Copyright 2024 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "utils.h"
#include <string>
#include "chrome/browser/global_features.h"
#include "chrome/test/base/testing_browser_process.h"
#include "components/application_locale_storage/application_locale_storage.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/display/test/test_screen.h"
using display::test::TestScreen;
using ::testing::TestWithParam;
using ::testing::ValuesIn;
namespace chromeos::editor_menu {
namespace {
constexpr int kEditorMenuHeightForTestDip = 180;
constexpr int kSmallGapForTestDip = 5;
struct GetEditorMenuBoundsTestParams {
gfx::Point cursor_point;
gfx::Rect anchor_view_bounds;
gfx::Rect editor_menu_bounds;
};
std::vector<GetEditorMenuBoundsTestParams> get_editor_menu_bounds_test_cases = {
// When:
// - Context menu covers left half of the screen.
// - Cursor point is on the right side of context menu (vertically middle).
// Then:
// - Editor menu appears on the right bottom side of cursor point.
// - Also it's moved vertically closer to cursor point.
{
.cursor_point = gfx::Point(
/*x=*/TestScreen::kDefaultScreenBounds.width() / 2 +
kSmallGapForTestDip,
/*y=*/TestScreen::kDefaultScreenBounds.height() / 2),
.anchor_view_bounds =
{
gfx::Point(
/*x=*/0,
/*y=*/0),
gfx::Size(
/*width=*/TestScreen::kDefaultScreenBounds.width() / 2,
/*height=*/TestScreen::kDefaultScreenBounds.height()),
},
.editor_menu_bounds =
{
gfx::Point(
/*x=*/TestScreen::kDefaultScreenBounds.width() / 2 +
kEditorMenuMarginDip,
/*y=*/TestScreen::kDefaultScreenBounds.height() / 2 +
kEditorMenuMarginDip),
gfx::Size(
/*width=*/kEditorMenuMinWidthDip,
/*height=*/kEditorMenuHeightForTestDip),
},
},
// When:
// - Context menu covers right half of the screen.
// - Cursor point is on left side of context menu (verticlly middle).
// Then:
// - Editor menu appears on the left bottom side of cursor point.
// - Also it's moved vertically closer to cursor point.
{
.cursor_point = gfx::Point(
/*x=*/TestScreen::kDefaultScreenBounds.width() / 2 -
kSmallGapForTestDip,
/*y=*/TestScreen::kDefaultScreenBounds.height() / 2),
.anchor_view_bounds =
{
gfx::Point(
/*x=*/TestScreen::kDefaultScreenBounds.width() / 2,
/*y=*/0),
gfx::Size(
/*width=*/TestScreen::kDefaultScreenBounds.width() / 2,
/*height=*/TestScreen::kDefaultScreenBounds.height()),
},
.editor_menu_bounds =
{gfx::Point(
/*x=*/TestScreen::kDefaultScreenBounds.width() / 2 -
kEditorMenuMarginDip - kEditorMenuMinWidthDip,
/*y=*/TestScreen::kDefaultScreenBounds.height() / 2 +
kEditorMenuMarginDip),
gfx::Size(
/*width=*/kEditorMenuMinWidthDip,
/*height=*/kEditorMenuHeightForTestDip)},
},
// When:
// - Context menu leaves enough space on every side.
// - Cursor point is above context menu.
// Then:
// - Editor menu appears above context menu.
{
.cursor_point = gfx::Point(
/*x=*/TestScreen::kDefaultScreenBounds.width() / 2,
/*y=*/0),
.anchor_view_bounds =
{
gfx::Point(
/*x=*/kEditorMenuMinWidthDip + kEditorMenuMarginDip,
/*y=*/kEditorMenuHeightForTestDip + kEditorMenuMarginDip),
gfx::Size(
/*width=*/TestScreen::kDefaultScreenBounds.width() / 2 -
kEditorMenuMinWidthDip - kEditorMenuMarginDip,
/*height=*/TestScreen::kDefaultScreenBounds.height() -
kEditorMenuHeightForTestDip * 2 -
kEditorMenuMarginDip * 2),
},
.editor_menu_bounds =
{
gfx::Point(
/*x=*/kEditorMenuMinWidthDip + kEditorMenuMarginDip,
/*y=*/0),
gfx::Size(
/*width=*/kEditorMenuMinWidthDip,
/*height=*/kEditorMenuHeightForTestDip),
},
},
// When:
// - Context menu leaves enough space on every side.
// - Cursor point is below context menu.
// Then:
// - Editor menu appears below context menu.
{
.cursor_point = gfx::Point(
/*x=*/TestScreen::kDefaultScreenBounds.width() / 2,
/*y=*/TestScreen::kDefaultScreenBounds.height()),
.anchor_view_bounds =
{
gfx::Point(
/*x=*/kEditorMenuMinWidthDip + kEditorMenuMarginDip,
/*y=*/kEditorMenuHeightForTestDip + kEditorMenuMarginDip),
gfx::Size(
/*width=*/TestScreen::kDefaultScreenBounds.width() / 2 -
kEditorMenuMinWidthDip - kEditorMenuMarginDip,
/*height=*/TestScreen::kDefaultScreenBounds.height() -
kEditorMenuHeightForTestDip * 2 -
kEditorMenuMarginDip * 2),
},
.editor_menu_bounds =
{
gfx::Point(
/*x=*/kEditorMenuMinWidthDip + kEditorMenuMarginDip,
/*y=*/TestScreen::kDefaultScreenBounds.height() -
kEditorMenuHeightForTestDip),
gfx::Size(
/*width=*/kEditorMenuMinWidthDip,
/*height=*/kEditorMenuHeightForTestDip),
},
},
// When:
// - Context menu covers left half of the screen.
// - Cursor point is on top left corner of the screen.
// Then:
// - Editor menu appears top right side of context menu.
// - Editor menu aligns top edge with context menu.
{
.cursor_point = gfx::Point(
/*x=*/0,
/*y=*/0),
.anchor_view_bounds =
{
gfx::Point(
/*x=*/0,
/*y=*/0),
gfx::Size(
/*width=*/TestScreen::kDefaultScreenBounds.width() / 2,
/*height=*/TestScreen::kDefaultScreenBounds.height()),
},
.editor_menu_bounds =
{gfx::Point(
/*x=*/TestScreen::kDefaultScreenBounds.width() / 2 +
kEditorMenuMarginDip,
/*y=*/0),
gfx::Size(
/*width=*/kEditorMenuMinWidthDip,
/*height=*/kEditorMenuHeightForTestDip)},
},
// When:
// - Context menu covers left half of the screen.
// - Cursor point is on bottom left corner of the screen.
// Then:
// - Editor menu appears bottom right side of context menu.
// - Editor menu aligns bottom edge with context menu.
{
.cursor_point = gfx::Point(
/*x=*/0,
/*y=*/TestScreen::kDefaultScreenBounds.height()),
.anchor_view_bounds =
{
gfx::Point(
/*x=*/0,
/*y=*/0),
gfx::Size(
/*width=*/TestScreen::kDefaultScreenBounds.width() / 2,
/*height=*/TestScreen::kDefaultScreenBounds.height()),
},
.editor_menu_bounds =
{gfx::Point(
/*x=*/TestScreen::kDefaultScreenBounds.width() / 2 +
kEditorMenuMarginDip,
/*y=*/TestScreen::kDefaultScreenBounds.height() -
kEditorMenuHeightForTestDip),
gfx::Size(
/*width=*/kEditorMenuMinWidthDip,
/*height=*/kEditorMenuHeightForTestDip)},
},
// When:
// - Context menu covers right half of the screen.
// - Cursor point is on top right corner of the screen.
// Then:
// - Editor menu appears top left side of context menu.
// - Editor menu aligns top edge with context menu.
{
.cursor_point = gfx::Point(
/*x=*/TestScreen::kDefaultScreenBounds.width(),
/*y=*/0),
.anchor_view_bounds =
{
gfx::Point(
/*x=*/TestScreen::kDefaultScreenBounds.width() / 2,
/*y=*/0),
gfx::Size(
/*width=*/TestScreen::kDefaultScreenBounds.width() / 2,
/*height=*/TestScreen::kDefaultScreenBounds.height()),
},
.editor_menu_bounds =
{gfx::Point(
/*x=*/TestScreen::kDefaultScreenBounds.width() / 2 -
kEditorMenuMarginDip - kEditorMenuMinWidthDip,
/*y=*/0),
gfx::Size(
/*width=*/kEditorMenuMinWidthDip,
/*height=*/kEditorMenuHeightForTestDip)},
},
// When:
// - Context menu covers right half of the screen.
// - Cursor point is top bottom right corner of the screen.
// Then:
// - Editor menu appears bottom left side of context menu.
// - Editor menu aligns bottom edge with context menu.
{
.cursor_point = gfx::Point(
/*x=*/TestScreen::kDefaultScreenBounds.width(),
/*y=*/TestScreen::kDefaultScreenBounds.height()),
.anchor_view_bounds =
{
gfx::Point(
/*x=*/TestScreen::kDefaultScreenBounds.width() / 2,
/*y=*/0),
gfx::Size(
/*width=*/TestScreen::kDefaultScreenBounds.width() / 2,
/*height=*/TestScreen::kDefaultScreenBounds.height()),
},
.editor_menu_bounds =
{gfx::Point(
/*x=*/TestScreen::kDefaultScreenBounds.width() / 2 -
kEditorMenuMarginDip - kEditorMenuMinWidthDip,
/*y=*/TestScreen::kDefaultScreenBounds.height() -
kEditorMenuHeightForTestDip),
gfx::Size(
/*width=*/kEditorMenuMinWidthDip,
/*height=*/kEditorMenuHeightForTestDip)},
},
};
class MockView : public views::View {
public:
gfx::Size CalculatePreferredSize(
const views::SizeBounds& available_size) const override {
return gfx::Size(kEditorMenuMinWidthDip, kEditorMenuHeightForTestDip);
}
};
class GetEditorMenuBoundsTest
: public TestWithParam<GetEditorMenuBoundsTestParams> {
protected:
std::unique_ptr<MockView> target_ = std::make_unique<MockView>();
TestScreen test_screen_{/*create_display=*/true, /*register_screen=*/true};
};
TEST_P(GetEditorMenuBoundsTest, Verify) {
test_screen_.set_cursor_screen_point(GetParam().cursor_point);
const std::string& locale = TestingBrowserProcess::GetGlobal()
->GetFeatures()
->application_locale_storage()
->Get();
const gfx::Rect editor_menu_bounds =
chromeos::editor_menu::GetEditorMenuBounds(GetParam().anchor_view_bounds,
target_.get(), locale);
EXPECT_EQ(editor_menu_bounds.x(), GetParam().editor_menu_bounds.x());
EXPECT_EQ(editor_menu_bounds.y(), GetParam().editor_menu_bounds.y());
EXPECT_EQ(editor_menu_bounds.width(), GetParam().editor_menu_bounds.width());
EXPECT_EQ(editor_menu_bounds.height(),
GetParam().editor_menu_bounds.height());
}
INSTANTIATE_TEST_SUITE_P(GetEditorMenuBoundsTestAll,
GetEditorMenuBoundsTest,
ValuesIn(get_editor_menu_bounds_test_cases));
} // namespace
} // namespace chromeos::editor_menu
|
