1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384
|
// Copyright 2021 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <string>
#include "ash/constants/ash_features.h"
#include "ash/webui/projector_app/public/cpp/projector_app_constants.h"
#include "ash/webui/system_apps/public/system_web_app_type.h"
#include "base/auto_reset.h"
#include "base/memory/scoped_refptr.h"
#include "base/test/metrics/histogram_tester.h"
#include "base/test/scoped_feature_list.h"
#include "base/test/test_mock_time_task_runner.h"
#include "base/time/tick_clock.h"
#include "base/time/time.h"
#include "chrome/browser/apps/app_service/metrics/app_service_metrics.h"
#include "chrome/browser/apps/link_capturing/chromeos_link_capturing_delegate.h"
#include "chrome/browser/apps/link_capturing/chromeos_reimpl_navigation_capturing_throttle.h"
#include "chrome/browser/apps/link_capturing/link_capturing_feature_test_support.h"
#include "chrome/browser/ash/system_web_apps/system_web_app_manager.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/global_features.h"
#include "chrome/browser/ui/ash/system_web_apps/system_web_app_ui_utils.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_list.h"
#include "chrome/browser/ui/browser_list_observer.h"
#include "chrome/browser/ui/browser_navigator.h"
#include "chrome/browser/ui/browser_navigator_params.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/common/chrome_features.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/ui_test_utils.h"
#include "components/application_locale_storage/application_locale_storage.h"
#include "content/public/browser/navigation_entry.h"
#include "content/public/common/page_type.h"
#include "content/public/test/browser_test.h"
#include "content/public/test/browser_test_utils.h"
#include "content/public/test/test_navigation_observer.h"
#include "ui/base/page_transition_types.h"
#include "ui/base/window_open_disposition.h"
#include "url/gurl.h"
namespace ash {
namespace {
constexpr char kFilePath[] = "xyz";
constexpr char kStartTime[] = "21 Jan 2022 10:00:00 GMT";
} // namespace
// Summary of expected behavior on ChromeOS:
// _____________________________|_SWA_launches_|_URL_redirection
// screencast.apps.chrome | Yes | Yes
// projector.apps.chrome | Yes | Yes (online only)
// chrome://projector/app/ | Yes | No
// chrome-untrusted://projector | No | No
class ProjectorNavigationThrottleTest : public InProcessBrowserTest {
public:
ProjectorNavigationThrottleTest() = default;
~ProjectorNavigationThrottleTest() override = default;
void SetUpOnMainThread() override {
InProcessBrowserTest::SetUpOnMainThread();
SystemWebAppManager::GetForTest(profile())->InstallSystemAppsForTesting();
base::Time start_time;
ASSERT_TRUE(base::Time::FromUTCString(kStartTime, &start_time));
task_runner_ = base::MakeRefCounted<base::TestMockTimeTaskRunner>();
base::TimeDelta forward_by = start_time - task_runner_->Now();
EXPECT_LT(base::TimeDelta(), forward_by);
task_runner_->AdvanceMockTickClock(forward_by);
}
void SetUpMockClock(bool use_v2) {
if (use_v2) {
clock_reset_ = std::make_unique<base::AutoReset<const base::TickClock*>>(
apps::ChromeOsReimplNavigationCapturingThrottle::SetClockForTesting(
task_runner_->GetMockTickClock()));
} else {
clock_reset_ = std::make_unique<base::AutoReset<const base::TickClock*>>(
apps::ChromeOsLinkCapturingDelegate::SetClockForTesting(
task_runner_->GetMockTickClock()));
}
}
protected:
Profile* profile() { return browser()->profile(); }
scoped_refptr<base::TestMockTimeTaskRunner> task_runner_;
private:
std::unique_ptr<base::AutoReset<const base::TickClock*>> clock_reset_;
base::OnceClosure on_browser_removed_callback_;
};
using LinkCapturingFeatureVersion = apps::test::LinkCapturingFeatureVersion;
using ProjectorAppNavigationParams =
std::tuple<LinkCapturingFeatureVersion, bool, std::string>;
class ProjectorNavigationCapturingParameterizedTest
: public ProjectorNavigationThrottleTest,
public testing::WithParamInterface<ProjectorAppNavigationParams> {
public:
ProjectorNavigationCapturingParameterizedTest() {
scoped_feature_list_.InitWithFeaturesAndParameters(
apps::test::GetFeaturesToEnableLinkCapturingUX(feature_version()), {});
}
LinkCapturingFeatureVersion feature_version() const {
return std::get<LinkCapturingFeatureVersion>(GetParam());
}
bool navigate_from_link() const { return std::get<bool>(GetParam()); }
std::string url_params() const { return std::get<std::string>(GetParam()); }
private:
base::test::ScopedFeatureList scoped_feature_list_;
};
// Verifies that navigating to
// https://screencast.apps.chrome/xyz?resourceKey=abc redirects to
// chrome://projector/app/xyz?timestamp=[timestamp]&resourceKey=abc and launches
// the SWA.
IN_PROC_BROWSER_TEST_P(ProjectorNavigationCapturingParameterizedTest,
NavigationRedirects) {
SetUpMockClock(feature_version() ==
LinkCapturingFeatureVersion::kV2DefaultOff);
base::HistogramTester histogram_tester;
std::string url = kChromeUIUntrustedProjectorPwaUrl;
url += "/";
url += kFilePath;
if (!url_params().empty()) {
url += "?" + url_params();
}
GURL gurl(url);
// Prior to navigation, there is only one browser available.
EXPECT_EQ(BrowserList::GetInstance()->size(), 1u);
// We have to listen for both the browser being removed AND the new browser
// being added.
ui_test_utils::BrowserChangeObserver removed_observer(
nullptr, ui_test_utils::BrowserChangeObserver::ChangeType::kRemoved);
ui_test_utils::BrowserChangeObserver added_observer(
nullptr, ui_test_utils::BrowserChangeObserver::ChangeType::kAdded);
if (navigate_from_link()) {
// Simulate the user clicking a link.
NavigateParams params(browser(), gurl,
ui::PageTransition::PAGE_TRANSITION_LINK);
Navigate(¶ms);
} else {
// Simulate the user typing the url into the omnibox.
ui_test_utils::NavigateToURLWithDisposition(
browser(), gurl, WindowOpenDisposition::CURRENT_TAB,
ui_test_utils::BrowserTestWaitFlags::BROWSER_TEST_WAIT_FOR_BROWSER);
}
removed_observer.Wait();
added_observer.Wait();
// During the navigation, we closed the previous browser to prevent dangling
// about:blank pages and opened a new app browser for the Projector SWA.
// There is still only one browser available.
EXPECT_EQ(BrowserList::GetInstance()->size(), 1u);
// Select the first available browser, which should be the SWA.
SelectFirstBrowser();
Browser* app_browser =
FindSystemWebAppBrowser(profile(), SystemWebAppType::PROJECTOR);
// Projector SWA is now open.
ASSERT_TRUE(app_browser);
content::WebContents* tab =
app_browser->tab_strip_model()->GetActiveWebContents();
ASSERT_TRUE(tab);
EXPECT_EQ(tab->GetController().GetVisibleEntry()->GetPageType(),
content::PAGE_TYPE_NORMAL);
// Construct the new redirected URL.
std::string expected_url = kChromeUIUntrustedProjectorUrl;
expected_url += kFilePath;
// The timestamp corresponds to 21 Jan 2022 10:00:00 GMT in microseconds since
// Unix epoch (Jan 1 1970).
expected_url += "?timestamp=1642759200000000%20bogo-microseconds";
if (!url_params().empty()) {
expected_url += "&" + url_params();
}
EXPECT_EQ(tab->GetVisibleURL().spec(), expected_url);
std::string histogram_name = navigate_from_link()
? "Apps.DefaultAppLaunch.FromLink"
: "Apps.DefaultAppLaunch.FromOmnibox";
histogram_tester.ExpectUniqueSample(
histogram_name,
/*sample=*/apps::DefaultAppName::kProjector, /*count=*/1);
}
INSTANTIATE_TEST_SUITE_P(
,
ProjectorNavigationCapturingParameterizedTest,
::testing::Combine(
/*link_capturing_feature_version=*/::testing::Values(
LinkCapturingFeatureVersion::kV1DefaultOff,
LinkCapturingFeatureVersion::kV2DefaultOff),
/*navigate_from_link=*/testing::Bool(),
/*url_params=*/
::testing::Values("resourceKey=abc", "resourceKey=abc&xyz=123", "")),
[](const testing::TestParamInfo<ProjectorAppNavigationParams>& info) {
std::string test_name;
test_name.append(apps::test::ToString(
std::get<LinkCapturingFeatureVersion>(info.param)));
test_name.append("_");
test_name.append(std::get<bool>(info.param) ? "navigate_from_link"
: "navigate_from_omnibox");
test_name.append("_");
// The query params have "=" in them which is not considered a valid param
// name during generation of test names.
std::string test_query = std::get<std::string>(info.param);
if (test_query == "resourceKey=abc") {
test_name.append("url");
} else if (test_query == "resourceKey=abc&xyz=123") {
test_name.append("url_params");
} else {
test_name.append("basic");
}
return test_name;
});
// Verifies that opening a redirect link from an app such as gchat does not
// leave a blank tab behind. Prevents a regression to b/211788287.
class ProjectorNavigationThrottleRedirectionParameterized
: public ProjectorNavigationThrottleTest,
public testing::WithParamInterface<LinkCapturingFeatureVersion> {
public:
ProjectorNavigationThrottleRedirectionParameterized() {
scoped_feature_list_.InitWithFeaturesAndParameters(
apps::test::GetFeaturesToEnableLinkCapturingUX(GetParam()), {});
}
private:
base::test::ScopedFeatureList scoped_feature_list_;
};
IN_PROC_BROWSER_TEST_P(ProjectorNavigationThrottleRedirectionParameterized,
NoBlankTab) {
SetUpMockClock(GetParam() == LinkCapturingFeatureVersion::kV2DefaultOff);
// Prior to navigation, there is only one browser available.
EXPECT_EQ(BrowserList::GetInstance()->size(), 1u);
// Suppose the user clicks a link like https://screencast.apps.chrome in
// gchat. The redirect URL actually looks like the below.
ASSERT_TRUE(ui_test_utils::NavigateToURL(
browser(),
GURL(
"https://www.google.com/url?q=https://"
"screencast.apps.chrome&sa=D&source=hangouts&ust=1642759200000000")));
// We wait for both the old browser to close and the new app browser to open.
ui_test_utils::BrowserChangeObserver removed_observer(
nullptr, ui_test_utils::BrowserChangeObserver::ChangeType::kRemoved);
ui_test_utils::BrowserChangeObserver added_observer(
nullptr, ui_test_utils::BrowserChangeObserver::ChangeType::kAdded);
// The Google servers would redirect to the URL in the ?q= query parameter.
// Simulate this behavior in this test without actually pinging the Google
// servers to prevent flakiness.
ui_test_utils::NavigateToURLWithDisposition(
browser(), GURL(kChromeUIUntrustedProjectorPwaUrl),
WindowOpenDisposition::CURRENT_TAB,
ui_test_utils::BrowserTestWaitFlags::BROWSER_TEST_WAIT_FOR_BROWSER);
removed_observer.Wait();
added_observer.Wait();
// During the navigation, we closed the previous browser to prevent dangling
// blank redirect pages and opened a new app browser for the Projector SWA.
// There is still only one browser available.
EXPECT_EQ(BrowserList::GetInstance()->size(), 1u);
// Select the first available browser, which should be the SWA.
SelectFirstBrowser();
Browser* app_browser =
FindSystemWebAppBrowser(profile(), SystemWebAppType::PROJECTOR);
// Projector SWA is now open.
ASSERT_TRUE(app_browser);
content::WebContents* tab =
app_browser->tab_strip_model()->GetActiveWebContents();
ASSERT_TRUE(tab);
EXPECT_EQ(tab->GetController().GetVisibleEntry()->GetPageType(),
content::PAGE_TYPE_NORMAL);
std::string expected_url = kChromeUIUntrustedProjectorUrl;
expected_url += "?timestamp=1642759200000000%20bogo-microseconds";
EXPECT_EQ(tab->GetVisibleURL().spec(), expected_url);
}
// Verifies that navigating to chrome-untrusted://projector/app/ does not
// redirect but launches the SWA.
IN_PROC_BROWSER_TEST_P(ProjectorNavigationThrottleRedirectionParameterized,
TrustedNoRedirect) {
GURL untrusted_url(kChromeUIUntrustedProjectorUrl);
ui_test_utils::NavigateToURLWithDisposition(
browser(), untrusted_url, WindowOpenDisposition::NEW_WINDOW,
ui_test_utils::BrowserTestWaitFlags::BROWSER_TEST_WAIT_FOR_BROWSER);
Browser* app_browser =
FindSystemWebAppBrowser(profile(), SystemWebAppType::PROJECTOR);
// Projector SWA is now open.
ASSERT_TRUE(app_browser);
content::WebContents* tab =
app_browser->tab_strip_model()->GetActiveWebContents();
ASSERT_TRUE(tab);
EXPECT_EQ(tab->GetController().GetVisibleEntry()->GetPageType(),
content::PAGE_TYPE_NORMAL);
// URL remains unchanged.
EXPECT_EQ(tab->GetVisibleURL(), untrusted_url);
}
INSTANTIATE_TEST_SUITE_P(
,
ProjectorNavigationThrottleRedirectionParameterized,
::testing::Values(LinkCapturingFeatureVersion::kV1DefaultOff,
LinkCapturingFeatureVersion::kV2DefaultOff),
[](const testing::TestParamInfo<LinkCapturingFeatureVersion>& info) {
return apps::test::ToString(info.param);
});
// Verifies that navigating to chrome-untrusted://projector-annotator does not
// lead to a crash. Prevents a regression to b/229124074.
IN_PROC_BROWSER_TEST_F(ProjectorNavigationThrottleTest,
UntrustedAnnotatorNavigationDoesNotCrash) {
GURL untrusted_annotator_url(kChromeUIUntrustedAnnotatorUrl);
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), untrusted_annotator_url));
content::WebContents* tab =
browser()->tab_strip_model()->GetActiveWebContents();
ASSERT_TRUE(tab);
EXPECT_EQ(tab->GetVisibleURL(), untrusted_annotator_url);
}
class ProjectorNavigationThrottleLocaleTest
: public ProjectorNavigationThrottleTest,
public testing::WithParamInterface<std::string> {
protected:
std::string locale() const { return GetParam(); }
};
// Verifies that the Projector app can detect locale changes.
IN_PROC_BROWSER_TEST_P(ProjectorNavigationThrottleLocaleTest,
UntrustedNavigationLocaleDetection) {
g_browser_process->GetFeatures()->application_locale_storage()->Set(locale());
GURL untrusted_url(kChromeUIUntrustedProjectorUrl);
content::TestNavigationObserver navigation_observer(untrusted_url);
navigation_observer.StartWatchingNewWebContents();
LaunchSystemWebAppAsync(profile(), SystemWebAppType::PROJECTOR);
navigation_observer.Wait();
Browser* app_browser =
FindSystemWebAppBrowser(profile(), SystemWebAppType::PROJECTOR);
content::WebContents* tab =
app_browser->tab_strip_model()->GetActiveWebContents();
ASSERT_TRUE(tab);
EXPECT_TRUE(WaitForLoadStop(tab));
EXPECT_EQ(tab->GetController().GetVisibleEntry()->GetPageType(),
content::PAGE_TYPE_NORMAL);
// Verify the document language.
EXPECT_EQ(content::EvalJs(tab, "document.documentElement.lang"), locale());
}
INSTANTIATE_TEST_SUITE_P(,
ProjectorNavigationThrottleLocaleTest,
/*locale=*/testing::Values("en-US", "zh-CN"));
} // namespace ash
|