1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861
|
// Copyright 2016 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#ifdef UNSAFE_BUFFERS_BUILD
// TODO(crbug.com/40285824): Remove this and convert code to safer constructs.
#pragma allow_unsafe_buffers
#endif
#include <memory>
#include <string>
#include <tuple>
#include <vector>
#include "ash/public/cpp/shelf_item_delegate.h"
#include "ash/public/cpp/shelf_model.h"
#include "ash/shelf/shelf.h"
#include "ash/shelf/shelf_app_button.h"
#include "ash/shelf/shelf_view_test_api.h"
#include "ash/shell.h"
#include "ash/system/status_area_widget_test_helper.h"
#include "base/functional/callback_helpers.h"
#include "base/run_loop.h"
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"
#include "base/task/thread_pool/thread_pool_instance.h"
#include "chrome/browser/ash/app_list/app_list_client_impl.h"
#include "chrome/browser/ash/app_list/app_list_controller_delegate.h"
#include "chrome/browser/ash/app_list/app_list_syncable_service.h"
#include "chrome/browser/ash/app_list/app_list_syncable_service_factory.h"
#include "chrome/browser/ash/app_list/arc/arc_app_list_prefs.h"
#include "chrome/browser/ash/app_list/arc/arc_app_utils.h"
#include "chrome/browser/ash/arc/arc_util.h"
#include "chrome/browser/ash/arc/session/arc_service_launcher.h"
#include "chrome/browser/ash/arc/session/arc_session_manager.h"
#include "chrome/browser/extensions/extension_browsertest.h"
#include "chrome/browser/ui/ash/shelf/arc_app_shelf_id.h"
#include "chrome/browser/ui/ash/shelf/chrome_shelf_controller.h"
#include "chrome/browser/ui/ash/shelf/chrome_shelf_controller_test_util.h"
#include "chrome/browser/ui/ash/shelf/chrome_shelf_controller_util.h"
#include "chrome/browser/ui/ash/shelf/shelf_spinner_controller.h"
#include "chromeos/ash/experiences/arc/metrics/arc_metrics_constants.h"
#include "chromeos/ash/experiences/arc/session/arc_bridge_service.h"
#include "chromeos/ash/experiences/arc/session/arc_service_manager.h"
#include "chromeos/ash/experiences/arc/test/arc_util_test_support.h"
#include "chromeos/ash/experiences/arc/test/fake_app_instance.h"
#include "components/exo/shell_surface.h"
#include "components/exo/shell_surface_util.h"
#include "components/exo/test/shell_surface_builder.h"
#include "components/exo/wm_helper.h"
#include "content/public/test/browser_test.h"
#include "content/public/test/browser_test_utils.h"
#include "ui/display/types/display_constants.h"
#include "ui/events/event_constants.h"
#include "ui/events/test/event_generator.h"
#include "ui/events/types/event_type.h"
#include "ui/views/animation/ink_drop.h"
namespace mojo {
template <>
struct TypeConverter<arc::mojom::AppInfoPtr, arc::mojom::AppInfo> {
static arc::mojom::AppInfoPtr Convert(const arc::mojom::AppInfo& app_info) {
return app_info.Clone();
}
};
template <>
struct TypeConverter<arc::mojom::ArcPackageInfoPtr,
arc::mojom::ArcPackageInfo> {
static arc::mojom::ArcPackageInfoPtr Convert(
const arc::mojom::ArcPackageInfo& package_info) {
return package_info.Clone();
}
};
template <>
struct TypeConverter<arc::mojom::ShortcutInfoPtr, arc::mojom::ShortcutInfo> {
static arc::mojom::ShortcutInfoPtr Convert(
const arc::mojom::ShortcutInfo& shortcut_info) {
return shortcut_info.Clone();
}
};
} // namespace mojo
namespace {
constexpr char kTestAppName[] = "Test ARC App";
constexpr char16_t kTestAppName16[] = u"Test ARC App";
constexpr char kTestAppName2[] = "Test ARC App 2";
constexpr char kTestShortcutName[] = "Test Shortcut";
constexpr char kTestShortcutName2[] = "Test Shortcut 2";
constexpr char kTestAppPackage[] = "test.arc.app.package";
constexpr char kTestAppActivity[] = "test.arc.app.package.activity";
constexpr char kTestAppActivity2[] = "test.arc.gitapp.package.activity2";
constexpr char kTestShelfGroup[] = "shelf_group";
constexpr char kTestShelfGroup2[] = "shelf_group_2";
constexpr char kTestShelfGroup3[] = "shelf_group_3";
constexpr char kTestLogicalWindow[] = "logical_window1";
constexpr char kTestLogicalWindow2[] = "logical_window2";
constexpr char kTestWindowTitle[] = "window1";
constexpr char16_t kTestWindowTitle16[] = u"window1";
constexpr char kTestWindowTitle2[] = "window2";
constexpr char16_t kTestWindowTitle216[] = u"window2";
constexpr char kTestWindowTitle3[] = "window3";
constexpr char16_t kTestWindowTitle316[] = u"window3";
constexpr int kAppAnimatedThresholdMs = 100;
constexpr int kGeneratedIconSize = 32;
std::string GetTestApp1Id(const std::string& package_name) {
return ArcAppListPrefs::GetAppId(package_name, kTestAppActivity);
}
std::string GetTestApp2Id(const std::string& package_name) {
return ArcAppListPrefs::GetAppId(package_name, kTestAppActivity2);
}
std::vector<arc::mojom::AppInfoPtr> GetTestAppsList(
const std::string& package_name,
bool multi_app) {
std::vector<arc::mojom::AppInfoPtr> apps;
arc::mojom::AppInfoPtr app(arc::mojom::AppInfo::New());
app->name = kTestAppName;
app->package_name = package_name;
app->activity = kTestAppActivity;
app->sticky = false;
apps.push_back(std::move(app));
if (multi_app) {
app = arc::mojom::AppInfo::New();
app->name = kTestAppName2;
app->package_name = package_name;
app->activity = kTestAppActivity2;
app->sticky = false;
apps.push_back(std::move(app));
}
return apps;
}
class AppAnimatedWaiter {
public:
explicit AppAnimatedWaiter(const std::string& app_id) : app_id_(app_id) {}
void Wait() {
const base::TimeDelta threshold =
base::Milliseconds(kAppAnimatedThresholdMs);
ShelfSpinnerController* controller =
ChromeShelfController::instance()->GetShelfSpinnerController();
while (controller->GetActiveTime(app_id_) < threshold) {
base::RunLoop().RunUntilIdle();
}
}
private:
const std::string app_id_;
};
enum TestAction {
TEST_ACTION_START, // Start app on app appears.
TEST_ACTION_EXIT, // Exit Chrome during animation.
TEST_ACTION_CLOSE, // Close item during animation.
};
// Test parameters include TestAction and pin/unpin state.
typedef std::tuple<TestAction, bool> TestParameter;
TestParameter build_test_parameter[] = {
TestParameter(TEST_ACTION_START, false),
TestParameter(TEST_ACTION_EXIT, false),
TestParameter(TEST_ACTION_CLOSE, false),
TestParameter(TEST_ACTION_START, true),
};
std::string CreateIntentUriWithShelfGroup(const std::string& shelf_group_id) {
return base::StringPrintf("#Intent;S.org.chromium.arc.shelf_group_id=%s;end",
shelf_group_id.c_str());
}
std::string CreateIntentUriWithShelfGroupAndLogicalWindow(
const std::string& shelf_group_id,
const std::string& logical_window_id) {
return base::StringPrintf(
"#Intent;S.org.chromium.arc.logical_window_id=%s;"
"S.org.chromium.arc.shelf_group_id=%s;end",
logical_window_id.c_str(), shelf_group_id.c_str());
}
ash::ShelfItemDelegate::AppMenuItems GetAppMenuItems(
ash::ShelfItemDelegate* delegate,
int event_flags) {
return delegate->GetAppMenuItems(event_flags, base::NullCallback());
}
} // namespace
class ArcAppShelfBrowserTest : public extensions::ExtensionBrowserTest {
public:
ArcAppShelfBrowserTest() = default;
ArcAppShelfBrowserTest(const ArcAppShelfBrowserTest&) = delete;
ArcAppShelfBrowserTest& operator=(const ArcAppShelfBrowserTest&) = delete;
~ArcAppShelfBrowserTest() override = default;
protected:
// content::BrowserTestBase:
void SetUpCommandLine(base::CommandLine* command_line) override {
extensions::ExtensionBrowserTest::SetUpCommandLine(command_line);
arc::SetArcAvailableCommandLineForTesting(command_line);
}
void SetUpInProcessBrowserTestFixture() override {
extensions::ExtensionBrowserTest::SetUpInProcessBrowserTestFixture();
arc::ArcSessionManager::SetUiEnabledForTesting(false);
}
void SetUpOnMainThread() override {
arc::SetArcPlayStoreEnabledForProfile(profile(), true);
// This ensures app_prefs()->GetApp() below never returns nullptr.
base::RunLoop run_loop;
app_prefs()->SetDefaultAppsReadyCallback(run_loop.QuitClosure());
run_loop.Run();
// Allows creation of windows.
wm_helper_ = std::make_unique<exo::WMHelper>();
}
void TearDownOnMainThread() override { wm_helper_.reset(); }
void InstallTestApps(const std::string& package_name, bool multi_app) {
app_host()->OnAppListRefreshed(GetTestAppsList(package_name, multi_app));
std::unique_ptr<ArcAppListPrefs::AppInfo> app_info =
app_prefs()->GetApp(GetTestApp1Id(package_name));
ASSERT_TRUE(app_info);
EXPECT_TRUE(app_info->ready);
if (multi_app) {
std::unique_ptr<ArcAppListPrefs::AppInfo> app_info2 =
app_prefs()->GetApp(GetTestApp2Id(package_name));
ASSERT_TRUE(app_info2);
EXPECT_TRUE(app_info2->ready);
}
}
std::string InstallShortcut(const std::string& name,
const std::string& shelf_group) {
arc::mojom::ShortcutInfo shortcut;
shortcut.name = name;
shortcut.package_name = kTestAppPackage;
shortcut.intent_uri = CreateIntentUriWithShelfGroup(shelf_group);
std::string shortcut_id =
ArcAppListPrefs::GetAppId(shortcut.package_name, shortcut.intent_uri);
app_host()->OnInstallShortcut(arc::mojom::ShortcutInfo::From(shortcut));
base::RunLoop().RunUntilIdle();
std::unique_ptr<ArcAppListPrefs::AppInfo> shortcut_info =
app_prefs()->GetApp(shortcut_id);
CHECK(shortcut_info);
EXPECT_TRUE(shortcut_info->shortcut);
EXPECT_EQ(kTestAppPackage, shortcut_info->package_name);
EXPECT_EQ(shortcut.intent_uri, shortcut_info->intent_uri);
return shortcut_id;
}
void SendPackageAdded(const std::string& package_name, bool package_synced) {
arc::mojom::ArcPackageInfo package_info;
package_info.package_name = package_name;
package_info.package_version = 1;
package_info.last_backup_android_id = 1;
package_info.last_backup_time = 1;
package_info.sync = package_synced;
app_host()->OnPackageAdded(arc::mojom::ArcPackageInfo::From(package_info));
base::RunLoop().RunUntilIdle();
}
void SendPackageUpdated(const std::string& package_name, bool multi_app) {
app_host()->OnPackageAppListRefreshed(
package_name, GetTestAppsList(package_name, multi_app));
// Ensure async callbacks from the resulting observer calls are run.
base::RunLoop().RunUntilIdle();
}
void SendPackageRemoved(const std::string& package_name) {
app_host()->OnPackageRemoved(package_name);
// Ensure async callbacks from the resulting observer calls are run.
base::RunLoop().RunUntilIdle();
}
void SendInstallationStarted(const std::string& package_name) {
app_host()->OnInstallationStarted(package_name);
base::RunLoop().RunUntilIdle();
}
void SendInstallationFinished(const std::string& package_name, bool success) {
arc::mojom::InstallationResult result;
result.package_name = package_name;
result.success = success;
app_host()->OnInstallationFinished(
arc::mojom::InstallationResultPtr(result.Clone()));
base::RunLoop().RunUntilIdle();
}
void StartInstance() {
if (!arc_session_manager()->profile()) {
// This situation happens when StartInstance() is called after
// StopInstance().
// TODO(hidehiko): The emulation is not implemented correctly. Fix it.
arc_session_manager()->SetProfile(profile());
arc::ArcServiceLauncher::Get()->OnPrimaryUserProfilePrepared(profile());
}
app_instance_ = std::make_unique<arc::FakeAppInstance>(app_host());
arc_brige_service()->app()->SetInstance(app_instance_.get());
}
void StopInstance() {
if (app_instance_) {
arc_brige_service()->app()->CloseInstance(app_instance_.get());
}
arc_session_manager()->Shutdown();
}
ash::ShelfItemDelegate* GetShelfItemDelegate(const std::string& id) {
auto* model = ChromeShelfController::instance()->shelf_model();
return model->GetShelfItemDelegate(ash::ShelfID(id));
}
void WaitForDecompressTask() {
base::ThreadPoolInstance::Get()->FlushForTesting();
base::RunLoop().RunUntilIdle();
}
ArcAppListPrefs* app_prefs() { return ArcAppListPrefs::Get(profile()); }
// Returns as AppHost interface in order to access to private implementation
// of the interface.
arc::mojom::AppHost* app_host() { return app_prefs(); }
// Returns as AppInstance observer interface in order to access to private
// implementation of the interface.
arc::ConnectionObserver<arc::mojom::AppInstance>* app_connection_observer() {
return app_prefs();
}
arc::ArcSessionManager* arc_session_manager() {
return arc::ArcSessionManager::Get();
}
arc::ArcBridgeService* arc_brige_service() {
return arc::ArcServiceManager::Get()->arc_bridge_service();
}
arc::FakeAppInstance* arc_instance() { return app_instance_.get(); }
private:
std::unique_ptr<arc::FakeAppInstance> app_instance_;
std::unique_ptr<exo::WMHelper> wm_helper_;
};
class ArcAppDeferredShelfBrowserTest : public ArcAppShelfBrowserTest {
public:
ArcAppDeferredShelfBrowserTest() = default;
ArcAppDeferredShelfBrowserTest(const ArcAppDeferredShelfBrowserTest&) =
delete;
ArcAppDeferredShelfBrowserTest& operator=(
const ArcAppDeferredShelfBrowserTest&) = delete;
~ArcAppDeferredShelfBrowserTest() override = default;
};
IN_PROC_BROWSER_TEST_F(ArcAppDeferredShelfBrowserTest,
StartAppDeferredFromShelfButton) {
StartInstance();
InstallTestApps(kTestAppPackage, false);
SendPackageAdded(kTestAppPackage, false);
// Restart ARC and ARC apps are in disabled state.
StopInstance();
StartInstance();
ChromeShelfController* const controller = ChromeShelfController::instance();
const std::string app_id = GetTestApp1Id(kTestAppPackage);
PinAppWithIDToShelf(app_id);
aura::Window* const root_window = ash::Shell::GetPrimaryRootWindow();
ash::ShelfViewTestAPI test_api(
ash::Shelf::ForWindow(root_window)->GetShelfViewForTesting());
// In this test, we need the shelf button's bounds. The scrollable shelf
// is notified of the added shelf button and layouts its child views
// during the bounds animation. So wait for the bounds animation to finish
// then get the final bounds of the shelf button.
test_api.RunMessageLoopUntilAnimationsDone();
ash::StatusAreaWidgetTestHelper::WaitForAnimationEnd(
ash::Shelf::ForWindow(root_window)->GetStatusAreaWidget());
const int item_index =
controller->shelf_model()->ItemIndexByID(ash::ShelfID(app_id));
ASSERT_GE(item_index, 0);
ash::ShelfAppButton* const button = test_api.GetButton(item_index);
ASSERT_TRUE(button);
views::InkDrop* const ink_drop = button->GetInkDropForTesting();
ASSERT_TRUE(ink_drop);
EXPECT_EQ(views::InkDropState::HIDDEN, ink_drop->GetTargetInkDropState());
ui::test::EventGenerator event_generator(root_window);
event_generator.MoveMouseTo(button->GetBoundsInScreen().CenterPoint());
base::RunLoop().RunUntilIdle();
event_generator.ClickLeftButton();
EXPECT_EQ(views::InkDropState::ACTION_TRIGGERED,
ink_drop->GetTargetInkDropState());
}
class ArcAppDeferredShelfWithParamsBrowserTest
: public ArcAppDeferredShelfBrowserTest,
public testing::WithParamInterface<TestParameter> {
public:
ArcAppDeferredShelfWithParamsBrowserTest() = default;
ArcAppDeferredShelfWithParamsBrowserTest(
const ArcAppDeferredShelfWithParamsBrowserTest&) = delete;
ArcAppDeferredShelfWithParamsBrowserTest& operator=(
const ArcAppDeferredShelfWithParamsBrowserTest&) = delete;
~ArcAppDeferredShelfWithParamsBrowserTest() override = default;
protected:
bool is_pinned() const { return std::get<1>(GetParam()); }
TestAction test_action() const { return std::get<0>(GetParam()); }
};
// This tests simulates normal workflow for starting ARC app in deferred mode.
IN_PROC_BROWSER_TEST_P(ArcAppDeferredShelfWithParamsBrowserTest,
StartAppDeferred) {
// Install app to remember existing apps.
StartInstance();
InstallTestApps(kTestAppPackage, false);
SendPackageAdded(kTestAppPackage, false);
ChromeShelfController* controller = ChromeShelfController::instance();
const std::string app_id = GetTestApp1Id(kTestAppPackage);
const ash::ShelfID shelf_id(app_id);
if (is_pinned()) {
PinAppWithIDToShelf(app_id);
const ash::ShelfItem* item = controller->GetItem(shelf_id);
EXPECT_EQ(kTestAppName16, item->title);
} else {
EXPECT_FALSE(controller->GetItem(shelf_id));
}
StopInstance();
std::unique_ptr<ArcAppListPrefs::AppInfo> app_info =
app_prefs()->GetApp(app_id);
EXPECT_FALSE(app_info);
// Restart instance. App should be taken from prefs but its state is non-ready
// currently.
StartInstance();
app_info = app_prefs()->GetApp(app_id);
ASSERT_TRUE(app_info);
EXPECT_FALSE(app_info->ready);
EXPECT_EQ(is_pinned(), controller->GetItem(shelf_id) != nullptr);
// Launching non-ready ARC app creates item on shelf and spinning animation.
if (is_pinned()) {
EXPECT_EQ(
ash::SHELF_ACTION_NEW_WINDOW_CREATED,
SelectShelfItem(shelf_id, ui::EventType::kMousePressed,
display::kInvalidDisplayId, ash::LAUNCH_FROM_SHELF));
} else {
arc::LaunchApp(profile(), app_id, ui::EF_LEFT_MOUSE_BUTTON,
arc::UserInteractionType::NOT_USER_INITIATED);
}
const ash::ShelfItem* item = controller->GetItem(shelf_id);
EXPECT_EQ(kTestAppName16, item->title);
AppAnimatedWaiter(app_id).Wait();
switch (test_action()) {
case TEST_ACTION_START:
// Now simulates that ARC is started and app list is refreshed. This
// should stop animation and delete icon from the shelf.
InstallTestApps(kTestAppPackage, false);
SendPackageAdded(kTestAppPackage, false);
EXPECT_TRUE(controller->GetShelfSpinnerController()
->GetActiveTime(app_id)
.is_zero());
EXPECT_EQ(is_pinned(), controller->GetItem(shelf_id) != nullptr);
break;
case TEST_ACTION_EXIT:
// Just exit Chrome.
break;
case TEST_ACTION_CLOSE: {
// Close item during animation.
ash::ShelfItemDelegate* delegate = GetShelfItemDelegate(app_id);
ASSERT_TRUE(delegate);
delegate->Close();
EXPECT_TRUE(controller->GetShelfSpinnerController()
->GetActiveTime(app_id)
.is_zero());
EXPECT_EQ(is_pinned(), controller->GetItem(shelf_id) != nullptr);
break;
}
}
}
INSTANTIATE_TEST_SUITE_P(ArcAppDeferredShelfWithParamsBrowserTestInstance,
ArcAppDeferredShelfWithParamsBrowserTest,
::testing::ValuesIn(build_test_parameter));
// This tests validates pin state on package update and remove.
IN_PROC_BROWSER_TEST_F(ArcAppShelfBrowserTest, PinOnPackageUpdateAndRemove) {
StartInstance();
// Make use app list sync service is started. Normally it is started when
// sycing is initialized.
app_list::AppListSyncableServiceFactory::GetForProfile(profile())
->GetModelUpdater();
InstallTestApps(kTestAppPackage, true);
SendPackageAdded(kTestAppPackage, false);
const ash::ShelfID shelf_id1(GetTestApp1Id(kTestAppPackage));
const ash::ShelfID shelf_id2(GetTestApp2Id(kTestAppPackage));
ChromeShelfController* controller = ChromeShelfController::instance();
PinAppWithIDToShelf(shelf_id1.app_id);
PinAppWithIDToShelf(shelf_id2.app_id);
EXPECT_TRUE(controller->GetItem(shelf_id1));
EXPECT_TRUE(controller->GetItem(shelf_id2));
// Package contains only one app. App list is not shown for updated package.
SendPackageUpdated(kTestAppPackage, false);
// Second pin should gone.
EXPECT_TRUE(controller->GetItem(shelf_id1));
EXPECT_FALSE(controller->GetItem(shelf_id2));
// Package contains two apps. App list is not shown for updated package.
SendPackageUpdated(kTestAppPackage, true);
// Second pin should not appear.
EXPECT_TRUE(controller->GetItem(shelf_id1));
EXPECT_FALSE(controller->GetItem(shelf_id2));
// Package removed.
SendPackageRemoved(kTestAppPackage);
// No pin is expected.
EXPECT_FALSE(controller->GetItem(shelf_id1));
EXPECT_FALSE(controller->GetItem(shelf_id2));
}
// Test AppListControllerDelegate::IsAppOpen for ARC apps.
IN_PROC_BROWSER_TEST_F(ArcAppShelfBrowserTest, IsAppOpen) {
StartInstance();
InstallTestApps(kTestAppPackage, false);
SendPackageAdded(kTestAppPackage, true);
const std::string app_id = GetTestApp1Id(kTestAppPackage);
AppListClientImpl* client = AppListClientImpl::GetInstance();
AppListControllerDelegate* delegate = client;
EXPECT_FALSE(delegate->IsAppOpen(app_id));
arc::LaunchApp(profile(), app_id, ui::EF_LEFT_MOUSE_BUTTON,
arc::UserInteractionType::NOT_USER_INITIATED);
EXPECT_FALSE(delegate->IsAppOpen(app_id));
// Simulate task creation so the app is marked as running/open.
std::unique_ptr<ArcAppListPrefs::AppInfo> info = app_prefs()->GetApp(app_id);
app_host()->OnTaskCreated(0, info->package_name, info->activity, info->name,
info->intent_uri, 0 /* session_id */);
EXPECT_TRUE(delegate->IsAppOpen(app_id));
}
// Test Shelf Groups
IN_PROC_BROWSER_TEST_F(ArcAppShelfBrowserTest, ShelfGroup) {
StartInstance();
InstallTestApps(kTestAppPackage, false);
SendPackageAdded(kTestAppPackage, true);
const std::string shorcut_id1 =
InstallShortcut(kTestShortcutName, kTestShelfGroup);
const std::string shorcut_id2 =
InstallShortcut(kTestShortcutName2, kTestShelfGroup2);
const std::string app_id = GetTestApp1Id(kTestAppPackage);
std::unique_ptr<ArcAppListPrefs::AppInfo> info = app_prefs()->GetApp(app_id);
ASSERT_TRUE(info);
const std::string shelf_id1 =
arc::ArcAppShelfId(kTestShelfGroup, app_id).ToString();
const std::string shelf_id2 =
arc::ArcAppShelfId(kTestShelfGroup2, app_id).ToString();
const std::string shelf_id3 =
arc::ArcAppShelfId(kTestShelfGroup3, app_id).ToString();
// 1 task for group 1
app_host()->OnTaskCreated(1, info->package_name, info->activity, info->name,
CreateIntentUriWithShelfGroup(kTestShelfGroup),
0 /* session_id */);
ash::ShelfItemDelegate* delegate1 = GetShelfItemDelegate(shelf_id1);
ASSERT_TRUE(delegate1);
// 2 tasks for group 2
app_host()->OnTaskCreated(2, info->package_name, info->activity, info->name,
CreateIntentUriWithShelfGroup(kTestShelfGroup2),
0 /* session_id */);
ash::ShelfItemDelegate* delegate2 = GetShelfItemDelegate(shelf_id2);
ASSERT_TRUE(delegate2);
ASSERT_NE(delegate1, delegate2);
app_host()->OnTaskCreated(3, info->package_name, info->activity, info->name,
CreateIntentUriWithShelfGroup(kTestShelfGroup2),
0 /* session_id */);
ASSERT_EQ(delegate2, GetShelfItemDelegate(shelf_id2));
// 2 tasks for group 3 which does not have shortcut.
app_host()->OnTaskCreated(4, info->package_name, info->activity, info->name,
CreateIntentUriWithShelfGroup(kTestShelfGroup3),
0 /* session_id */);
ash::ShelfItemDelegate* delegate3 = GetShelfItemDelegate(shelf_id3);
ASSERT_TRUE(delegate3);
ASSERT_NE(delegate1, delegate3);
ASSERT_NE(delegate2, delegate3);
app_host()->OnTaskCreated(5, info->package_name, info->activity, info->name,
CreateIntentUriWithShelfGroup(kTestShelfGroup3),
0 /* session_id */);
ASSERT_EQ(delegate3, GetShelfItemDelegate(shelf_id3));
ChromeShelfController* controller = ChromeShelfController::instance();
const ash::ShelfItem* item1 = controller->GetItem(ash::ShelfID(shelf_id1));
ASSERT_TRUE(item1);
// The shelf group item's title should be the title of the referenced ARC app.
EXPECT_EQ(kTestAppName16, item1->title);
// Destroy task #0, this kills shelf group 1
app_host()->OnTaskDestroyed(1);
EXPECT_FALSE(GetShelfItemDelegate(shelf_id1));
// Destroy task #1, shelf group 2 is still alive
app_host()->OnTaskDestroyed(2);
EXPECT_EQ(delegate2, GetShelfItemDelegate(shelf_id2));
// Destroy task #2, this kills shelf group 2
app_host()->OnTaskDestroyed(3);
EXPECT_FALSE(GetShelfItemDelegate(shelf_id2));
// Disable ARC, this removes app and as result kills shelf group 3.
arc::SetArcPlayStoreEnabledForProfile(profile(), false);
// Wait for the asynchronous ArcAppListPrefs::RemoveAllAppsAndPackages to be
// called.
base::RunLoop run_loop;
app_prefs()->SetRemoveAllCallbackForTesting(run_loop.QuitClosure());
run_loop.Run();
EXPECT_FALSE(GetShelfItemDelegate(shelf_id3));
}
// Test Logical Windows: Among a group of windows that have the same group ID
// and logical window ID, only one should be represented in the shelf at any
// time. If that window is closed, a different window of the logical window
// should be shown instead.
IN_PROC_BROWSER_TEST_F(ArcAppShelfBrowserTest, LogicalWindow) {
StartInstance();
InstallTestApps(kTestAppPackage, false);
SendPackageAdded(kTestAppPackage, true);
const std::string app_id = GetTestApp1Id(kTestAppPackage);
std::unique_ptr<ArcAppListPrefs::AppInfo> info = app_prefs()->GetApp(app_id);
ASSERT_TRUE(info);
const std::string shelf_id1 =
arc::ArcAppShelfId(kTestShelfGroup, app_id).ToString();
const std::string shelf_id2 =
arc::ArcAppShelfId(kTestShelfGroup2, app_id).ToString();
// We will use the following 7 windows. Index 0 is skipped because task_ids
// start at 1.
const char* kTestWindowTitles[8] = {"",
kTestWindowTitle,
kTestWindowTitle2,
kTestWindowTitle,
kTestWindowTitle2,
kTestWindowTitle3,
kTestWindowTitle,
kTestWindowTitle2};
const char* kTestShelfGroups[8] = {"",
kTestShelfGroup,
kTestShelfGroup,
kTestShelfGroup,
kTestShelfGroup,
kTestShelfGroup,
kTestShelfGroup2,
kTestShelfGroup2};
const char* kTestLogicalWindows[8] = {"",
kTestLogicalWindow,
kTestLogicalWindow,
kTestLogicalWindow2,
kTestLogicalWindow2,
kTestLogicalWindow2,
kTestLogicalWindow,
kTestLogicalWindow};
// Create windows that will be associated with the tasks. Without this,
// GetAppMenuItems() will only return an empty list.
std::vector<std::unique_ptr<exo::ClientControlledShellSurface>> test_windows;
for (int task_id = 1; task_id <= 7; task_id++) {
test_windows.push_back(exo::test::ShellSurfaceBuilder({640, 480})
.SetCentered()
.BuildClientControlledShellSurface());
aura::Window* aura_window =
test_windows[task_id - 1]->GetWidget()->GetNativeWindow();
ASSERT_TRUE(aura_window);
exo::SetShellApplicationId(
aura_window, base::StringPrintf("org.chromium.arc.%d", task_id));
}
// Group 1 with two logical windows: one with 2, and one with 3 tasks.
// First logical window
app_host()->OnTaskCreated(1, info->package_name, info->activity, info->name,
CreateIntentUriWithShelfGroupAndLogicalWindow(
kTestShelfGroups[1], kTestLogicalWindows[1]),
0 /* session_id */);
arc_instance()->set_icon_response_type(
arc::FakeAppInstance::IconResponseType::ICON_RESPONSE_SEND_EMPTY);
app_host()->OnTaskDescriptionChanged(
1, kTestWindowTitles[1],
arc_instance()->GenerateIconResponse(kGeneratedIconSize,
false /* app_icon */),
0, 0);
WaitForDecompressTask();
ash::ShelfItemDelegate* delegate1 = GetShelfItemDelegate(shelf_id1);
ASSERT_TRUE(delegate1);
ASSERT_EQ(1u, GetAppMenuItems(delegate1, 0).size());
ASSERT_EQ(kTestWindowTitle16, GetAppMenuItems(delegate1, 0)[0].title);
app_host()->OnTaskCreated(2, info->package_name, info->activity, info->name,
CreateIntentUriWithShelfGroupAndLogicalWindow(
kTestShelfGroups[2], kTestLogicalWindows[2]),
0 /* session_id */);
app_host()->OnTaskDescriptionChanged(
2, kTestWindowTitles[2],
arc_instance()->GenerateIconResponse(kGeneratedIconSize,
false /* app_icon */),
0, 0);
WaitForDecompressTask();
ASSERT_EQ(delegate1, GetShelfItemDelegate(shelf_id1));
ASSERT_EQ(1u, GetAppMenuItems(delegate1, 0).size());
ASSERT_EQ(kTestWindowTitle16, GetAppMenuItems(delegate1, 0)[0].title);
// Second logical window
for (int task_id = 3; task_id <= 5; task_id++) {
app_host()->OnTaskCreated(
task_id, info->package_name, info->activity, info->name,
CreateIntentUriWithShelfGroupAndLogicalWindow(
kTestShelfGroups[task_id], kTestLogicalWindows[task_id]),
0 /* session_id */);
app_host()->OnTaskDescriptionChanged(
task_id, kTestWindowTitles[task_id],
arc_instance()->GenerateIconResponse(kGeneratedIconSize,
false /* app_icon */),
0, 0);
}
WaitForDecompressTask();
ASSERT_EQ(delegate1, GetShelfItemDelegate(shelf_id1));
ASSERT_EQ(2u, GetAppMenuItems(delegate1, 0).size());
ASSERT_EQ(kTestWindowTitle16, GetAppMenuItems(delegate1, 0)[1].title);
// Group 2 with one logical window out of 2 tasks. Same logical window id as
// tasks 1 and 2, but different group.
app_host()->OnTaskCreated(6, info->package_name, info->activity, info->name,
CreateIntentUriWithShelfGroupAndLogicalWindow(
kTestShelfGroups[6], kTestLogicalWindows[6]),
0 /* session_id */);
app_host()->OnTaskDescriptionChanged(
6, kTestWindowTitles[6],
arc_instance()->GenerateIconResponse(kGeneratedIconSize,
false /* app_icon */),
0, 0);
ash::ShelfItemDelegate* delegate2 = GetShelfItemDelegate(shelf_id2);
WaitForDecompressTask();
ASSERT_TRUE(delegate2);
ASSERT_NE(delegate1, delegate2);
ASSERT_EQ(1u, GetAppMenuItems(delegate2, 0).size());
ASSERT_EQ(kTestWindowTitle16, GetAppMenuItems(delegate2, 0)[0].title);
app_host()->OnTaskCreated(7, info->package_name, info->activity, info->name,
CreateIntentUriWithShelfGroupAndLogicalWindow(
kTestShelfGroups[7], kTestLogicalWindows[7]),
0 /* session_id */);
app_host()->OnTaskDescriptionChanged(
7, kTestWindowTitles[7],
arc_instance()->GenerateIconResponse(kGeneratedIconSize,
false /* app_icon */),
0, 0);
WaitForDecompressTask();
ASSERT_EQ(delegate2, GetShelfItemDelegate(shelf_id2));
ASSERT_EQ(1u, GetAppMenuItems(delegate2, 0).size());
ASSERT_EQ(kTestWindowTitle16, GetAppMenuItems(delegate2, 0)[0].title);
// Group 1 should be unchanged.
ASSERT_EQ(2u, GetAppMenuItems(delegate1, 0).size());
ASSERT_EQ(kTestWindowTitle16, GetAppMenuItems(delegate1, 0)[0].title);
ASSERT_EQ(kTestWindowTitle16, GetAppMenuItems(delegate1, 0)[1].title);
// Start closing, and see if the other parts of the logical windows show up.
// Group 1:
// Task 1 closes, task 2 should become visible:
app_host()->OnTaskDestroyed(1);
ASSERT_EQ(2u, GetAppMenuItems(delegate1, 0).size());
ASSERT_EQ(kTestWindowTitle216, GetAppMenuItems(delegate1, 0)[0].title);
ASSERT_EQ(kTestWindowTitle16, GetAppMenuItems(delegate1, 0)[1].title);
// Task 4 is hidden, so should not change its entry's title.
app_host()->OnTaskDestroyed(4);
ASSERT_EQ(2u, GetAppMenuItems(delegate1, 0).size());
ASSERT_EQ(kTestWindowTitle216, GetAppMenuItems(delegate1, 0)[0].title);
ASSERT_EQ(kTestWindowTitle16, GetAppMenuItems(delegate1, 0)[1].title);
// Task 3 closes, leaving only task 5 of this entry. This swaps the two
// entries.
app_host()->OnTaskDestroyed(3);
ASSERT_EQ(2u, GetAppMenuItems(delegate1, 0).size());
ASSERT_EQ(kTestWindowTitle316, GetAppMenuItems(delegate1, 0)[0].title);
ASSERT_EQ(kTestWindowTitle216, GetAppMenuItems(delegate1, 0)[1].title);
// Task 5 closes, close this entry fully.
app_host()->OnTaskDestroyed(5);
ASSERT_EQ(1u, GetAppMenuItems(delegate1, 0).size());
ASSERT_EQ(kTestWindowTitle216, GetAppMenuItems(delegate1, 0)[0].title);
// Task 2 closes, the full shelf group is closed now.
ASSERT_EQ(delegate1, GetShelfItemDelegate(shelf_id1));
app_host()->OnTaskDestroyed(2);
EXPECT_FALSE(GetShelfItemDelegate(shelf_id1));
// Group 2:
ASSERT_EQ(delegate2, GetShelfItemDelegate(shelf_id2));
ASSERT_EQ(1u, GetAppMenuItems(delegate2, 0).size());
// Task 7 is hidden, so should not change the entry:
app_host()->OnTaskDestroyed(7);
ASSERT_EQ(1u, GetAppMenuItems(delegate2, 0).size());
ASSERT_EQ(kTestWindowTitle16, GetAppMenuItems(delegate2, 0)[0].title);
// Task 6 is the last task, close group:
app_host()->OnTaskDestroyed(6);
EXPECT_FALSE(GetShelfItemDelegate(shelf_id2));
}
|