1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
|
// Copyright 2023 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ui/autofill/address_editor_controller.h"
#include <algorithm>
#include <memory>
#include "base/callback_list.h"
#include "base/test/mock_callback.h"
#include "chrome/test/base/browser_with_test_window_test.h"
#include "components/autofill/core/browser/data_manager/test_personal_data_manager.h"
#include "components/autofill/core/browser/test_utils/autofill_test_utils.h"
#include "components/autofill/core/browser/ui/country_combobox_model.h"
#include "components/autofill/core/common/autofill_prefs.h"
#include "components/prefs/pref_registry_simple.h"
#include "components/prefs/testing_pref_service.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace autofill {
using ::testing::InSequence;
using ::testing::NiceMock;
using ::testing::Return;
using ::testing::ReturnRef;
// TODO(crbug.com/40277889): write more unit tests for AddressEditorController.
class AddressEditorControllerTest : public testing::Test {
public:
AddressEditorControllerTest() = default;
void SetUp() override {
pref_service_.registry()->RegisterBooleanPref(
prefs::kAutofillProfileEnabled, true);
pref_service_.registry()->RegisterBooleanPref(
prefs::kAutofillCreditCardEnabled, true);
pdm_.SetPrefService(&pref_service_);
pdm_.test_address_data_manager().SetDefaultCountryCode(
AddressCountryCode("US"));
}
protected:
void CreateController(bool is_validatable) {
controller_ = std::make_unique<AddressEditorController>(profile_, &pdm_,
is_validatable);
}
TestingPrefServiceSimple pref_service_;
TestPersonalDataManager pdm_;
AutofillProfile profile_ = test::GetFullProfile();
std::unique_ptr<AddressEditorController> controller_;
};
TEST_F(AddressEditorControllerTest, SmokeTest) {
CreateController(/*is_validatable=*/false);
EXPECT_FALSE(controller_->is_validatable());
EXPECT_FALSE(controller_->is_valid().has_value());
controller_->SetIsValid(/*is_valid=*/false);
EXPECT_TRUE(controller_->is_valid().has_value());
EXPECT_FALSE(*controller_->is_valid());
}
TEST_F(AddressEditorControllerTest, FieldValidation) {
CreateController(/*is_validatable=*/true);
EXPECT_TRUE(controller_->IsValid({autofill::PHONE_HOME_WHOLE_NUMBER, u"",
EditorField::LengthHint::HINT_SHORT, false,
EditorField::ControlType::TEXTFIELD_NUMBER},
u""))
<< "Non-validatable field should always be valid.";
EXPECT_FALSE(
controller_->IsValid({autofill::PHONE_HOME_WHOLE_NUMBER, u"",
EditorField::LengthHint::HINT_SHORT, true,
EditorField::ControlType::TEXTFIELD_NUMBER},
u""))
<< "Empty value for validatable field is considered invalid.";
EXPECT_FALSE(
controller_->IsValid({autofill::PHONE_HOME_WHOLE_NUMBER, u" ",
EditorField::LengthHint::HINT_SHORT, true,
EditorField::ControlType::TEXTFIELD_NUMBER},
u""))
<< "Whitespaces should be trimmed and the field is considered invalid.";
EXPECT_TRUE(controller_->IsValid({autofill::PHONE_HOME_WHOLE_NUMBER, u"",
EditorField::LengthHint::HINT_SHORT, true,
EditorField::ControlType::TEXTFIELD_NUMBER},
u"abc"))
<< "Non-empty string is considered valid";
}
TEST_F(AddressEditorControllerTest, ValidityChanges) {
CreateController(/*is_validatable=*/true);
base::MockRepeatingCallback<void(bool)> on_validity_changed;
InSequence seq;
EXPECT_CALL(on_validity_changed, Run(false));
EXPECT_CALL(on_validity_changed, Run(true));
base::CallbackListSubscription subscription =
controller_->AddIsValidChangedCallback(on_validity_changed.Get());
controller_->SetIsValid(/*is_valid=*/false);
controller_->SetIsValid(/*is_valid=*/true);
}
TEST_F(AddressEditorControllerTest, ValidityRemainsSame) {
CreateController(/*is_validatable=*/true);
base::MockRepeatingCallback<void(bool)> on_validity_changed;
InSequence seq;
EXPECT_CALL(on_validity_changed, Run).Times(1);
base::CallbackListSubscription subscription =
controller_->AddIsValidChangedCallback(on_validity_changed.Get());
controller_->SetIsValid(/*is_valid=*/true);
controller_->SetIsValid(/*is_valid=*/true);
}
TEST_F(AddressEditorControllerTest, GetCountryComboboxModel) {
CreateController(/*is_validatable=*/false);
EXPECT_GT(controller_->GetCountryComboboxModel().GetItemCount(), 0ul);
// `country` is null when it represents a separator. There must be exactly 1
// separator in the country list.
EXPECT_EQ(
std::ranges::count_if(controller_->GetCountryComboboxModel().countries(),
[](const auto& country) { return !country; }),
1l);
}
TEST_F(AddressEditorControllerTest, SetProfileInfo) {
CreateController(/*is_validatable=*/false);
for (const auto& type_value_pair :
std::vector<std::pair<FieldType, std::u16string>>{
{ADDRESS_HOME_COUNTRY, u"Germany"},
{NAME_FULL, u"John Doe"},
{ADDRESS_HOME_STREET_ADDRESS, u"Lake St. 123"},
{PHONE_HOME_WHOLE_NUMBER, u"+11111111111"},
{EMAIL_ADDRESS, u"example@gmail.com"}}) {
controller_->SetProfileInfo(type_value_pair.first, type_value_pair.second);
EXPECT_EQ(controller_->GetProfileInfo(type_value_pair.first),
type_value_pair.second);
}
// First and last names must be reset, see crbug.com/1496322.
EXPECT_EQ(controller_->GetProfileInfo(NAME_FIRST), u"");
EXPECT_EQ(controller_->GetProfileInfo(NAME_LAST), u"");
}
TEST_F(AddressEditorControllerTest, StaticEditorFields) {
CreateController(/*is_validatable=*/false);
// Country, phone number and email address fields are added unconditionally
// to the set of editor fields.
for (auto type : std::vector<FieldType>{
ADDRESS_HOME_COUNTRY, PHONE_HOME_WHOLE_NUMBER, EMAIL_ADDRESS}) {
EXPECT_EQ(std::ranges::count_if(
controller_->editor_fields(),
[type](auto field) { return field.type == type; }),
1);
}
}
TEST_F(AddressEditorControllerTest, UpdateEditorFields) {
CreateController(/*is_validatable=*/false);
size_t us_fields_size = controller_->editor_fields().size();
controller_->UpdateEditorFields("BR");
// Verify that the number of fields shown for the Brazil is greater than
// number of fields for the US address.
EXPECT_GT(controller_->editor_fields().size(), us_fields_size);
}
} // namespace autofill
|
