1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
|
// Copyright 2013 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/bookmarks/bookmark_model_factory.h"
#include "chrome/browser/ui/bookmarks/bookmark_utils.h"
#include "chrome/browser/ui/bookmarks/bookmark_utils_desktop.h"
#include "chrome/common/url_constants.h"
#include "chrome/test/base/browser_with_test_window_test.h"
#include "components/bookmarks/browser/bookmark_utils.h"
#include "components/bookmarks/test/bookmark_test_helpers.h"
#include "components/dom_distiller/core/url_constants.h"
#include "components/dom_distiller/core/url_utils.h"
#include "content/public/browser/navigation_entry.h"
#include "content/public/browser/web_contents.h"
class BookmarkTest : public BrowserWithTestWindowTest {
public:
TestingProfile::TestingFactories GetTestingFactories() override {
return {TestingProfile::TestingFactory{
BookmarkModelFactory::GetInstance(),
BookmarkModelFactory::GetDefaultFactory()}};
}
};
TEST_F(BookmarkTest, NonEmptyBookmarkBarShownOnNTP) {
bookmarks::BookmarkModel* bookmark_model =
BookmarkModelFactory::GetForBrowserContext(profile());
bookmarks::test::WaitForBookmarkModelToLoad(bookmark_model);
bookmarks::AddIfNotBookmarked(bookmark_model, GURL("https://www.test.com"),
std::u16string());
AddTab(browser(), GURL(chrome::kChromeUINewTabURL));
EXPECT_EQ(BookmarkBar::SHOW, browser()->bookmark_bar_state());
}
TEST_F(BookmarkTest, EmptyBookmarkBarNotShownOnNTP) {
bookmarks::BookmarkModel* bookmark_model =
BookmarkModelFactory::GetForBrowserContext(profile());
bookmarks::test::WaitForBookmarkModelToLoad(bookmark_model);
AddTab(browser(), GURL(chrome::kChromeUINewTabURL));
EXPECT_EQ(BookmarkBar::HIDDEN, browser()->bookmark_bar_state());
}
// Verify that the bookmark bar is hidden on custom NTP pages.
TEST_F(BookmarkTest, BookmarkBarOnCustomNTP) {
// Create a empty commited web contents.
std::unique_ptr<content::WebContents> web_contents =
content::WebContents::Create(
content::WebContents::CreateParams(browser()->profile()));
web_contents->GetController().LoadURL(
GURL(url::kAboutBlankURL), content::Referrer(), ui::PAGE_TRANSITION_LINK,
std::string());
// Give it a NTP virtual URL.
content::NavigationController* controller = &web_contents->GetController();
content::NavigationEntry* entry = controller->GetVisibleEntry();
entry->SetVirtualURL(GURL(chrome::kChromeUINewTabURL));
// Verify that the bookmark bar is hidden.
EXPECT_EQ(BookmarkBar::HIDDEN, browser()->bookmark_bar_state());
browser()->tab_strip_model()->AppendWebContents(std::move(web_contents),
true);
EXPECT_EQ(BookmarkBar::HIDDEN, browser()->bookmark_bar_state());
}
TEST_F(BookmarkTest, BookmarkReaderModePageActuallyBookmarksOriginal) {
GURL original("https://www.example.com/article.html");
GURL distilled = dom_distiller::url_utils::GetDistillerViewUrlFromUrl(
dom_distiller::kDomDistillerScheme, original, "Article title");
std::unique_ptr<content::WebContents> web_contents =
content::WebContents::Create(
content::WebContents::CreateParams(browser()->profile()));
web_contents->GetController().LoadURL(
distilled, content::Referrer(), ui::PAGE_TRANSITION_LINK, std::string());
// The URL to bookmark and the title of the page should be based on the
// original page.
GURL bookmarked_url;
std::u16string bookmarked_title;
bool r = chrome::GetURLAndTitleToBookmark(web_contents.get(), &bookmarked_url,
&bookmarked_title);
ASSERT_TRUE(r);
EXPECT_EQ(original, bookmarked_url);
EXPECT_EQ(u"Article title", bookmarked_title);
}
TEST_F(BookmarkTest, NoTabsInGroups) {
BookmarkEditor::EditDetails details =
BookmarkEditor::EditDetails::AddFolder(nullptr, 10);
std::vector<std::pair<GURL, std::u16string>> tab_entries;
auto test_url =
std::make_pair(GURL("https://www.example.com/article.html"), u"");
base::flat_map<int, bookmarks::TabGroupData> groups_by_index;
for (int i = 0; i < 6; i++) {
tab_entries.push_back(test_url);
groups_by_index.emplace(i, std::make_pair(std::nullopt, u""));
}
bookmarks::GetURLsAndFoldersForTabEntries(&(details.bookmark_data.children),
tab_entries, groups_by_index);
EXPECT_EQ(details.bookmark_data.children.size(), 6u);
for (auto child : details.bookmark_data.children) {
EXPECT_EQ(child.url.has_value(), true);
}
}
TEST_F(BookmarkTest, AllTabsInOneGroup) {
BookmarkEditor::EditDetails details =
BookmarkEditor::EditDetails::AddFolder(nullptr, 10);
tab_groups::TabGroupId group_id = tab_groups::TabGroupId::GenerateNew();
std::vector<std::pair<GURL, std::u16string>> tab_entries;
auto test_url =
std::make_pair(GURL("https://www.example.com/article.html"), u"");
base::flat_map<int, bookmarks::TabGroupData> groups_by_index;
for (int i = 0; i < 6; i++) {
tab_entries.push_back(test_url);
groups_by_index.emplace(i,
std::make_pair(std::make_optional(group_id), u""));
}
bookmarks::GetURLsAndFoldersForTabEntries(&(details.bookmark_data.children),
tab_entries, groups_by_index);
EXPECT_EQ(details.bookmark_data.children.size(), 1u);
EXPECT_EQ(details.bookmark_data.children.begin()->url.has_value(), false);
EXPECT_EQ(details.bookmark_data.children.begin()->children.size(), 6u);
}
TEST_F(BookmarkTest, AllTabsInMultipleGroups) {
BookmarkEditor::EditDetails details =
BookmarkEditor::EditDetails::AddFolder(nullptr, 10);
std::vector<std::pair<GURL, std::u16string>> tab_entries;
auto test_url =
std::make_pair(GURL("https://www.example.com/article.html"), u"");
base::flat_map<int, bookmarks::TabGroupData> groups_by_index;
for (int i = 0; i < 6; i++) {
tab_entries.push_back(test_url);
groups_by_index.emplace(
i, std::make_pair(
std::make_optional(tab_groups::TabGroupId::GenerateNew()), u""));
}
bookmarks::GetURLsAndFoldersForTabEntries(&(details.bookmark_data.children),
tab_entries, groups_by_index);
EXPECT_EQ(details.bookmark_data.children.size(), 6u);
for (auto child : details.bookmark_data.children) {
EXPECT_EQ(child.url.has_value(), false);
EXPECT_EQ(child.children.size(), 1u);
}
}
TEST_F(BookmarkTest, SomeTabsInOneGroup) {
BookmarkEditor::EditDetails details =
BookmarkEditor::EditDetails::AddFolder(nullptr, 10);
tab_groups::TabGroupId group_id = tab_groups::TabGroupId::GenerateNew();
std::vector<std::pair<GURL, std::u16string>> tab_entries;
auto test_url =
std::make_pair(GURL("https://www.example.com/article.html"), u"");
base::flat_map<int, bookmarks::TabGroupData> groups_by_index;
for (int i = 0; i < 6; i++) {
tab_entries.push_back(test_url);
groups_by_index.emplace(
i, std::make_pair(
i >= 1 && i <= 3 ? std::make_optional(group_id) : std::nullopt,
u""));
}
bookmarks::GetURLsAndFoldersForTabEntries(&(details.bookmark_data.children),
tab_entries, groups_by_index);
EXPECT_EQ(details.bookmark_data.children.size(), 4u);
for (size_t i = 0; i < details.bookmark_data.children.size(); i++) {
auto child = details.bookmark_data.children.at(i);
if (i == 1) {
EXPECT_EQ(child.url.has_value(), false);
EXPECT_EQ(child.children.size(), 3u);
} else {
EXPECT_EQ(child.url.has_value(), true);
}
}
}
TEST_F(BookmarkTest, SomeTabsInMultipleGroups) {
BookmarkEditor::EditDetails details =
BookmarkEditor::EditDetails::AddFolder(nullptr, 10);
std::vector<std::pair<GURL, std::u16string>> tab_entries;
auto test_url =
std::make_pair(GURL("https://www.example.com/article.html"), u"");
base::flat_map<int, bookmarks::TabGroupData> groups_by_index;
for (int i = 0; i < 6; i++) {
tab_entries.push_back(test_url);
groups_by_index.emplace(
i, std::make_pair(
i % 2 == 0
? std::make_optional(tab_groups::TabGroupId::GenerateNew())
: std::nullopt,
u""));
}
bookmarks::GetURLsAndFoldersForTabEntries(&(details.bookmark_data.children),
tab_entries, groups_by_index);
EXPECT_EQ(details.bookmark_data.children.size(), 6u);
for (size_t i = 0; i < details.bookmark_data.children.size(); i++) {
auto child = details.bookmark_data.children.at(i);
if (i % 2 == 0) {
EXPECT_EQ(child.url.has_value(), false);
EXPECT_EQ(child.children.size(), 1u);
} else {
EXPECT_EQ(child.url.has_value(), true);
}
}
}
|
