1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
|
// Copyright 2012 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ui/bookmarks/recently_used_folders_combo_model.h"
#include <memory>
#include "base/strings/utf_string_conversions.h"
#include "components/bookmarks/browser/bookmark_model.h"
#include "components/bookmarks/common/bookmark_metrics.h"
#include "components/bookmarks/test/bookmark_test_helpers.h"
#include "components/bookmarks/test/test_bookmark_client.h"
#include "content/public/test/browser_task_environment.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/base/models/combobox_model_observer.h"
using bookmarks::BookmarkModel;
using bookmarks::BookmarkNode;
using bookmarks::TestBookmarkClient;
// Implementation of ComboboxModelObserver that records when
// OnComboboxModelChanged() is invoked.
class TestComboboxModelObserver : public ui::ComboboxModelObserver {
public:
TestComboboxModelObserver() = default;
TestComboboxModelObserver(const TestComboboxModelObserver&) = delete;
TestComboboxModelObserver& operator=(const TestComboboxModelObserver&) =
delete;
~TestComboboxModelObserver() override = default;
// Returns whether the model changed and clears changed state.
bool GetAndClearChanged() {
const bool changed = changed_;
changed_ = false;
return changed;
}
// ui::ComboboxModelObserver:
void OnComboboxModelChanged(ui::ComboboxModel* model) override {
changed_ = true;
}
void OnComboboxModelDestroying(ui::ComboboxModel* model) override {}
private:
bool changed_ = false;
};
class RecentlyUsedFoldersComboModelTest : public testing::Test {
public:
RecentlyUsedFoldersComboModelTest() = default;
RecentlyUsedFoldersComboModelTest(const RecentlyUsedFoldersComboModelTest&) =
delete;
RecentlyUsedFoldersComboModelTest& operator=(
const RecentlyUsedFoldersComboModelTest&) = delete;
private:
content::BrowserTaskEnvironment task_environment_;
};
// Verifies there are no duplicate nodes in the model.
TEST_F(RecentlyUsedFoldersComboModelTest, NoDups) {
std::unique_ptr<BookmarkModel> bookmark_model(
TestBookmarkClient::CreateModel());
const BookmarkNode* new_node = bookmark_model->AddURL(
bookmark_model->bookmark_bar_node(), 0, u"a", GURL("http://a"));
RecentlyUsedFoldersComboModel model(bookmark_model.get(), new_node);
std::set<std::u16string> items;
for (size_t i = 0; i < model.GetItemCount(); ++i) {
if (!model.IsItemSeparatorAt(i)) {
EXPECT_EQ(0u, items.count(model.GetItemAt(i)));
}
}
}
// Verifies that observers are notified on changes.
TEST_F(RecentlyUsedFoldersComboModelTest, NotifyObserver) {
std::unique_ptr<BookmarkModel> bookmark_model(
TestBookmarkClient::CreateModel());
const BookmarkNode* folder =
bookmark_model->AddFolder(bookmark_model->bookmark_bar_node(), 0, u"a");
const BookmarkNode* sub_folder = bookmark_model->AddFolder(folder, 0, u"b");
const BookmarkNode* new_node =
bookmark_model->AddURL(sub_folder, 0, u"a", GURL("http://a"));
RecentlyUsedFoldersComboModel model(bookmark_model.get(), new_node);
TestComboboxModelObserver observer;
model.AddObserver(&observer);
const size_t initial_count = model.GetItemCount();
// Remove a folder, it should remove an item from the model too.
bookmark_model->Remove(
sub_folder, bookmarks::metrics::BookmarkEditSource::kOther, FROM_HERE);
EXPECT_TRUE(observer.GetAndClearChanged());
const size_t updated_count = model.GetItemCount();
EXPECT_LT(updated_count, initial_count);
// Remove all, which should remove a folder too.
bookmark_model->RemoveAllUserBookmarks(FROM_HERE);
EXPECT_TRUE(observer.GetAndClearChanged());
EXPECT_LT(model.GetItemCount(), updated_count);
model.RemoveObserver(&observer);
}
|
