1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
|
// Copyright 2013 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ui/browser_instant_controller.h"
#include <stddef.h>
#include <array>
#include <vector>
#include "base/gtest_prod_util.h"
#include "base/memory/raw_ptr.h"
#include "base/memory/raw_ref.h"
#include "base/metrics/field_trial.h"
#include "base/run_loop.h"
#include "chrome/browser/search/instant_service.h"
#include "chrome/browser/search/instant_unittest_base.h"
#include "chrome/browser/search/search.h"
#include "chrome/browser/signin/chrome_signin_client_factory.h"
#include "chrome/browser/signin/chrome_signin_client_test_util.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/common/url_constants.h"
#include "chrome/test/base/testing_profile.h"
#include "content/public/browser/navigation_handle.h"
#include "content/public/browser/reload_type.h"
#include "content/public/browser/render_frame_host.h"
#include "content/public/browser/render_process_host.h"
#include "content/public/browser/web_contents.h"
#include "content/public/browser/web_contents_observer.h"
#include "content/public/test/browser_test_utils.h"
namespace chrome {
namespace {
class BrowserInstantControllerTest : public InstantUnitTestBase {
protected:
friend class FakeWebContentsObserver;
// BrowserWithTestWindowTest:
TestingProfile::TestingFactories GetTestingFactories() override {
return {TestingProfile::TestingFactory{
ChromeSigninClientFactory::GetInstance(),
base::BindRepeating(&BuildChromeSigninClientWithURLLoader,
test_url_loader_factory())}};
}
};
struct TabReloadTestCase {
const char* description;
const char* start_url;
bool start_in_instant_process;
bool end_in_ntp;
};
// Test cases for when Google is the initial, but not final provider.
const auto kTabReloadTestCasesFinalProviderNotGoogle =
std::to_array<TabReloadTestCase>({
{"NTP", chrome::kChromeUINewTabPageURL, false, true},
{"Remote SERP", "https://www.google.com/url?bar=search+terms", false,
false},
{"Other NTP", "https://bar.com/newtab", false, false},
});
class FakeWebContentsObserver : public content::WebContentsObserver {
public:
explicit FakeWebContentsObserver(content::WebContents* contents)
: WebContentsObserver(contents),
contents_(contents),
did_start_observer_(contents),
url_(contents->GetURL()) {}
void DidStartNavigation(content::NavigationHandle* navigation) override {
if (navigation->GetReloadType() == content::ReloadType::NONE) {
return;
}
if (*url_ == navigation->GetURL()) {
num_reloads_++;
}
current_url_ = navigation->GetURL();
}
const GURL& url() const { return *url_; }
const GURL& current_url() const { return contents_->GetURL(); }
int num_reloads() const { return num_reloads_; }
bool can_go_back() const { return contents_->GetController().CanGoBack(); }
void WaitForNavigationStart() { did_start_observer_.Wait(); }
protected:
friend class BrowserInstantControllerTest;
FRIEND_TEST_ALL_PREFIXES(BrowserInstantControllerTest,
DefaultSearchProviderChanged);
FRIEND_TEST_ALL_PREFIXES(BrowserInstantControllerTest, GoogleBaseURLUpdated);
private:
raw_ptr<content::WebContents> contents_;
content::DidStartNavigationObserver did_start_observer_;
const raw_ref<const GURL> url_;
GURL current_url_;
int num_reloads_ = 0;
};
TEST_F(BrowserInstantControllerTest, DefaultSearchProviderChanged) {
size_t num_tests = std::size(kTabReloadTestCasesFinalProviderNotGoogle);
std::vector<std::unique_ptr<FakeWebContentsObserver>> observers;
for (size_t i = 0; i < num_tests; ++i) {
const TabReloadTestCase& test =
kTabReloadTestCasesFinalProviderNotGoogle[i];
AddTab(browser(), GURL(test.start_url));
content::WebContents* contents =
browser()->tab_strip_model()->GetActiveWebContents();
// Validate initial instant state.
EXPECT_EQ(
test.start_in_instant_process,
instant_service_->IsInstantProcess(
contents->GetPrimaryMainFrame()->GetProcess()->GetDeprecatedID()))
<< test.description;
// Setup an observer to verify reload or absence thereof.
observers.push_back(std::make_unique<FakeWebContentsObserver>(contents));
}
SetUserSelectedDefaultSearchProvider("https://bar.com/");
for (size_t i = 0; i < num_tests; ++i) {
FakeWebContentsObserver* observer = observers[i].get();
const TabReloadTestCase& test =
kTabReloadTestCasesFinalProviderNotGoogle[i];
// Ensure only the expected tabs(contents) reloaded.
// RunUntilIdle() ensures that tasks posted by TabReloader::Reload run.
base::RunLoop().RunUntilIdle();
if (observer->web_contents()->IsLoading()) {
// Ensure that we get DidStartNavigation, which can be dispatched
// asynchronously.
observer->WaitForNavigationStart();
}
if (test.end_in_ntp) {
EXPECT_EQ(GURL(chrome::kChromeUINewTabURL), observer->current_url())
<< test.description;
}
}
}
} // namespace
} // namespace chrome
|
