1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
|
// Copyright 2018 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#import "chrome/browser/ui/cocoa/main_menu_builder.h"
#include "base/strings/utf_string_conversions.h"
#include "chrome/app/chrome_command_ids.h"
#include "chrome/grit/branded_strings.h"
#include "chrome/grit/generated_resources.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "testing/gtest_mac.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/base/l10n/l10n_util_mac.h"
namespace {
using chrome::internal::MenuItemBuilder;
TEST(MainMenuBuilderTest, Separator) {
NSMenuItem* item = MenuItemBuilder().is_separator().Build();
EXPECT_TRUE([item isSeparatorItem]);
EXPECT_EQ(0, [item tag]);
}
TEST(MainMenuBuilderTest, SeparatorWithTag) {
NSMenuItem* item = MenuItemBuilder().is_separator().tag(999).Build();
EXPECT_TRUE([item isSeparatorItem]);
EXPECT_EQ(999, [item tag]);
}
TEST(MainMenuBuilderTest, CommandId) {
NSMenuItem* item =
MenuItemBuilder(IDS_NEW_TAB).command_id(IDC_NEW_TAB).Build();
EXPECT_EQ(@selector(commandDispatch:), [item action]);
EXPECT_FALSE([item target]);
EXPECT_NSEQ(l10n_util::GetNSStringWithFixup(IDS_NEW_TAB), [item title]);
EXPECT_EQ(IDC_NEW_TAB, [item tag]);
EXPECT_NSEQ(@"t", [item keyEquivalent]);
EXPECT_EQ(NSEventModifierFlagCommand, [item keyEquivalentModifierMask]);
}
TEST(MainMenuBuilderTest, CustomTargetAction) {
NSObject* target = [[NSObject alloc] init];
NSMenuItem* item = MenuItemBuilder(IDS_PREFERENCES)
.target(target)
.action(@selector(fooBar:))
.Build();
EXPECT_NSEQ(l10n_util::GetNSStringWithFixup(IDS_PREFERENCES), [item title]);
EXPECT_EQ(target, [item target]);
EXPECT_EQ(@selector(fooBar:), [item action]);
EXPECT_EQ(0, [item tag]);
}
TEST(MainMenuBuilderTest, Submenu) {
NSMenuItem* item =
MenuItemBuilder(IDS_EDIT)
.tag(123)
.submenu({
MenuItemBuilder(IDS_CUT).tag(456).action(@selector(first:)),
MenuItemBuilder(IDS_COPY).tag(789).action(@selector(second:)),
})
.Build();
EXPECT_EQ(123, [item tag]);
EXPECT_NSEQ(l10n_util::GetNSStringWithFixup(IDS_EDIT), [item title]);
// These are hooked up by AppKit's -setSubmenu:.
EXPECT_EQ([item submenu], [item target]);
EXPECT_EQ(@selector(submenuAction:), [item action]);
NSMenu* submenu = [item submenu];
EXPECT_TRUE(submenu);
ASSERT_EQ(2u, [submenu numberOfItems]);
NSMenuItem* subitem = [submenu itemAtIndex:0];
EXPECT_EQ(456, [subitem tag]);
EXPECT_EQ(@selector(first:), [subitem action]);
EXPECT_NSEQ(l10n_util::GetNSStringWithFixup(IDS_CUT), [subitem title]);
subitem = [submenu itemAtIndex:1];
EXPECT_EQ(789, [subitem tag]);
EXPECT_EQ(@selector(second:), [subitem action]);
EXPECT_NSEQ(l10n_util::GetNSStringWithFixup(IDS_COPY), [subitem title]);
}
TEST(MainMenuBuilderTest, StringId) {
NSMenuItem* item = MenuItemBuilder(IDS_NEW_TAB_MAC).Build();
EXPECT_NSEQ(l10n_util::GetNSStringWithFixup(IDS_NEW_TAB_MAC), [item title]);
}
TEST(MainMenuBuilderTest, StringIdWithArg) {
std::u16string product_name(u"MyAppIsTotallyAwesome");
NSMenuItem* item =
MenuItemBuilder(IDS_ABOUT_MAC).string_format_1(product_name).Build();
EXPECT_NSEQ(l10n_util::GetNSStringF(IDS_ABOUT_MAC, product_name),
[item title]);
}
TEST(MainMenuBuilderTest, Disabled) {
NSMenuItem* item = MenuItemBuilder(IDS_NEW_TAB_MAC).remove_if(true).Build();
EXPECT_EQ(nil, item);
item = MenuItemBuilder(IDS_NEW_TAB_MAC).remove_if(false).Build();
EXPECT_NSEQ(l10n_util::GetNSStringWithFixup(IDS_NEW_TAB_MAC), [item title]);
}
TEST(MainMenuBuilderTest, Hidden) {
NSMenuItem* item = MenuItemBuilder(IDS_NEW_TAB_MAC).set_hidden(true).Build();
EXPECT_EQ(true, [item isHidden]);
}
TEST(MainMenuBuilderTest, CloseWindowKeyEquivalentApp) {
// Close Window shortcut for browser mode.
NSMenu* mainMenu = chrome::BuildMainMenu(nil, nil, u"", /* is_pwa */ false);
// First comes the App menu, then the File menu.
const int kFileMenuItemIndex = 1;
NSMenuItem* fileMenuItem = [mainMenu itemArray][kFileMenuItemIndex];
NSMenuItem* closeWindowMenuItem =
[[fileMenuItem submenu] itemWithTag:IDC_CLOSE_WINDOW];
EXPECT_TRUE([@"W" isEqualToString:closeWindowMenuItem.keyEquivalent]);
// Close Window shortcut for PWAs.
mainMenu = chrome::BuildMainMenu(nil, nil, u"", /* is_pwa */ true);
fileMenuItem = [mainMenu itemArray][kFileMenuItemIndex];
closeWindowMenuItem = [[fileMenuItem submenu] itemWithTag:IDC_CLOSE_WINDOW];
EXPECT_TRUE([@"w" isEqualToString:closeWindowMenuItem.keyEquivalent]);
}
} // namespace
|
