1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470
|
// Copyright 2023 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ui/extensions/controlled_home_bubble_delegate.h"
#include "base/containers/contains.h"
#include "base/memory/raw_ptr.h"
#include "base/strings/utf_string_conversions.h"
#include "base/test/bind.h"
#include "base/values.h"
#include "build/build_config.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/extension_util.h"
#include "chrome/browser/extensions/extension_web_ui_override_registrar.h"
#include "chrome/browser/extensions/permissions/permissions_updater.h"
#include "chrome/browser/extensions/test_extension_system.h"
#include "chrome/browser/profiles/keep_alive/profile_keep_alive_types.h"
#include "chrome/browser/profiles/keep_alive/scoped_profile_keep_alive.h"
#include "chrome/test/base/browser_with_test_window_test.h"
#include "chrome/test/base/testing_profile.h"
#include "components/proxy_config/proxy_config_pref_names.h"
#include "content/public/browser/storage_partition.h"
#include "extensions/browser/extension_prefs.h"
#include "extensions/browser/extension_registrar.h"
#include "extensions/browser/extension_registry.h"
#include "extensions/browser/extension_system.h"
#include "extensions/common/extension.h"
#include "extensions/common/extension_builder.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace {
std::unique_ptr<KeyedService> BuildOverrideRegistrar(
content::BrowserContext* context) {
return std::make_unique<extensions::ExtensionWebUIOverrideRegistrar>(context);
}
} // namespace
class ControlledHomeBubbleDelegateTest : public BrowserWithTestWindowTest {
public:
ControlledHomeBubbleDelegateTest() = default;
~ControlledHomeBubbleDelegateTest() override = default;
// Loads an extension that overrides the home page of a user.
scoped_refptr<const extensions::Extension> LoadExtensionOverridingHome(
const std::string& name = "extension",
extensions::mojom::ManifestLocation location =
extensions::mojom::ManifestLocation::kInternal) {
scoped_refptr<const extensions::Extension> extension =
extensions::ExtensionBuilder(name)
.SetManifestVersion(3)
.SetLocation(location)
.SetManifestKey(
"chrome_settings_overrides",
base::Value::Dict().Set("homepage", "http://www.google.com"))
.Build();
extensions::PermissionsUpdater(profile()).GrantActivePermissions(
extension.get());
extension_registrar()->AddExtension(extension);
return extension;
}
// Returns true if the extension is enabled.
bool IsExtensionEnabled(const extensions::ExtensionId& id) {
return extension_registry_->enabled_extensions().GetByID(id);
}
// Returns true if the extension is disabled and has the specified
// `disable_reason`.
bool IsExtensionDisabled(
const extensions::ExtensionId& id,
extensions::disable_reason::DisableReason disable_reason) {
return extension_registry_->disabled_extensions().GetByID(id) &&
extension_prefs_->HasOnlyDisableReason(id, disable_reason);
}
// Returns true if the extension has been acknowledged by the user.
bool IsExtensionAcknowledged(const extensions::ExtensionId& id) {
bool was_acknowledged = false;
return extension_prefs_->ReadPrefAsBoolean(
id, ControlledHomeBubbleDelegate::kAcknowledgedPreference,
&was_acknowledged) &&
was_acknowledged;
}
// Acknowledges the extension in preferences.
void AcknowledgeExtension(const extensions::ExtensionId& id) {
extension_prefs_->UpdateExtensionPref(
id, ControlledHomeBubbleDelegate::kAcknowledgedPreference,
base::Value(true));
}
extensions::ExtensionRegistrar* extension_registrar() {
return extension_registrar_.get();
}
private:
void SetUp() override {
BrowserWithTestWindowTest::SetUp();
// Prevent the Profile from getting deleted before TearDown() is complete,
// since WaitForStorageCleanup() relies on an active Profile. See the
// DestroyProfileOnBrowserClose flag.
profile_keep_alive_ = std::make_unique<ScopedProfileKeepAlive>(
profile(), ProfileKeepAliveOrigin::kBrowserWindow);
// The two lines of magical incantation required to get the extension
// service to work inside a unit test and access the extension prefs.
static_cast<extensions::TestExtensionSystem*>(
extensions::ExtensionSystem::Get(profile()))
->CreateExtensionService(base::CommandLine::ForCurrentProcess(),
base::FilePath(), false);
// Set up the rest of the necessary systems.
extensions::ExtensionSystem::Get(profile())->extension_service()->Init();
extensions::ExtensionWebUIOverrideRegistrar::GetFactoryInstance()
->SetTestingFactory(profile(),
base::BindRepeating(&BuildOverrideRegistrar));
extensions::ExtensionWebUIOverrideRegistrar::GetFactoryInstance()->Get(
profile());
extension_prefs_ = extensions::ExtensionPrefs::Get(profile());
extension_registrar_ = extensions::ExtensionRegistrar::Get(profile());
extension_registry_ = extensions::ExtensionRegistry::Get(profile());
}
void TearDown() override {
extension_prefs_ = nullptr;
extension_registrar_ = nullptr;
extension_registry_ = nullptr;
WaitForStorageCleanup();
// Clean up global state for the delegates. Since profiles are stored in
// global variables, they can be shared between tests and cause
// unpredictable behavior.
ControlledHomeBubbleDelegate::ClearProfileSetForTesting();
profile_keep_alive_.reset();
BrowserWithTestWindowTest::TearDown();
}
void WaitForStorageCleanup() {
content::StoragePartition* partition =
profile()->GetDefaultStoragePartition();
if (partition) {
partition->WaitForDeletionTasksForTesting();
}
}
base::AutoReset<bool> ignore_learn_more_{
ControlledHomeBubbleDelegate::IgnoreLearnMoreForTesting()};
raw_ptr<extensions::ExtensionPrefs> extension_prefs_;
raw_ptr<extensions::ExtensionRegistrar> extension_registrar_;
raw_ptr<extensions::ExtensionRegistry> extension_registry_;
std::unique_ptr<base::CommandLine> command_line_;
std::unique_ptr<ScopedProfileKeepAlive> profile_keep_alive_;
};
// Though the test harness should compile on all platforms, the behavior for
// extensions to override the home page is limited to mac and windows.
#if BUILDFLAG(IS_WIN) || BUILDFLAG(IS_MAC)
TEST_F(ControlledHomeBubbleDelegateTest, ClickingExecuteDisablesTheExtension) {
scoped_refptr<const extensions::Extension> extension =
LoadExtensionOverridingHome();
ASSERT_TRUE(extension);
ASSERT_TRUE(browser());
ASSERT_TRUE(profile());
auto bubble_delegate =
std::make_unique<ControlledHomeBubbleDelegate>(browser());
EXPECT_TRUE(bubble_delegate->ShouldShow());
EXPECT_EQ(extension, bubble_delegate->extension_for_testing());
bool did_close_programmatically = false;
auto close_callback = base::BindLambdaForTesting(
[&did_close_programmatically]() { did_close_programmatically = true; });
bubble_delegate->PendingShow();
bubble_delegate->OnBubbleShown(std::move(close_callback));
EXPECT_FALSE(did_close_programmatically);
bubble_delegate->OnBubbleClosed(
ToolbarActionsBarBubbleDelegate::CLOSE_EXECUTE);
EXPECT_TRUE(IsExtensionDisabled(
extension->id(), extensions::disable_reason::DISABLE_USER_ACTION));
// Since the extension was disabled, it shouldn't be acknowledged in
// preferences.
EXPECT_FALSE(IsExtensionAcknowledged(extension->id()));
}
TEST_F(ControlledHomeBubbleDelegateTest,
ClickingDismissAcknowledgesTheExtension) {
scoped_refptr<const extensions::Extension> extension =
LoadExtensionOverridingHome();
ASSERT_TRUE(extension);
auto bubble_delegate =
std::make_unique<ControlledHomeBubbleDelegate>(browser());
EXPECT_TRUE(bubble_delegate->ShouldShow());
EXPECT_EQ(extension, bubble_delegate->extension_for_testing());
bool did_close_programmatically = false;
auto close_callback = base::BindLambdaForTesting(
[&did_close_programmatically]() { did_close_programmatically = true; });
bubble_delegate->PendingShow();
bubble_delegate->OnBubbleShown(std::move(close_callback));
EXPECT_FALSE(did_close_programmatically);
bubble_delegate->OnBubbleClosed(
ToolbarActionsBarBubbleDelegate::CLOSE_DISMISS_USER_ACTION);
// The extension should remain enabled and be acknowledged.
EXPECT_TRUE(IsExtensionEnabled(extension->id()));
EXPECT_TRUE(IsExtensionAcknowledged(extension->id()));
}
TEST_F(ControlledHomeBubbleDelegateTest,
DismissByDeactivationDoesNotDisableOrAcknowledge) {
scoped_refptr<const extensions::Extension> extension =
LoadExtensionOverridingHome();
ASSERT_TRUE(extension);
{
auto bubble_delegate =
std::make_unique<ControlledHomeBubbleDelegate>(browser());
EXPECT_TRUE(bubble_delegate->ShouldShow());
EXPECT_EQ(extension, bubble_delegate->extension_for_testing());
bool did_close_programmatically = false;
auto close_callback = base::BindLambdaForTesting(
[&did_close_programmatically]() { did_close_programmatically = true; });
bubble_delegate->PendingShow();
bubble_delegate->OnBubbleShown(std::move(close_callback));
EXPECT_FALSE(did_close_programmatically);
bubble_delegate->OnBubbleClosed(
ToolbarActionsBarBubbleDelegate::CLOSE_DISMISS_DEACTIVATION);
}
// The extension should remain enabled but *shouldn't* be acknowledged.
EXPECT_TRUE(IsExtensionEnabled(extension->id()));
EXPECT_FALSE(IsExtensionAcknowledged(extension->id()));
{
auto bubble_delegate =
std::make_unique<ControlledHomeBubbleDelegate>(browser());
// Even though the extension hasn't been acknowledged, we shouldn't show the
// bubble twice in the same session.
EXPECT_FALSE(bubble_delegate->ShouldShow());
}
}
TEST_F(ControlledHomeBubbleDelegateTest,
ClickingLearnMoreAcknowledgesTheExtension) {
scoped_refptr<const extensions::Extension> extension =
LoadExtensionOverridingHome();
ASSERT_TRUE(extension);
auto bubble_delegate =
std::make_unique<ControlledHomeBubbleDelegate>(browser());
EXPECT_TRUE(bubble_delegate->ShouldShow());
EXPECT_EQ(extension, bubble_delegate->extension_for_testing());
bool did_close_programmatically = false;
auto close_callback = base::BindLambdaForTesting(
[&did_close_programmatically]() { did_close_programmatically = true; });
bubble_delegate->PendingShow();
bubble_delegate->OnBubbleShown(std::move(close_callback));
EXPECT_FALSE(did_close_programmatically);
bubble_delegate->OnBubbleClosed(
ToolbarActionsBarBubbleDelegate::CLOSE_LEARN_MORE);
EXPECT_TRUE(IsExtensionEnabled(extension->id()));
EXPECT_TRUE(IsExtensionAcknowledged(extension->id()));
}
TEST_F(ControlledHomeBubbleDelegateTest, DisablingTheExtensionClosesTheBubble) {
scoped_refptr<const extensions::Extension> extension =
LoadExtensionOverridingHome();
ASSERT_TRUE(extension);
auto bubble_delegate =
std::make_unique<ControlledHomeBubbleDelegate>(browser());
EXPECT_TRUE(bubble_delegate->ShouldShow());
EXPECT_EQ(extension, bubble_delegate->extension_for_testing());
bool did_close_programmatically = false;
auto close_callback = base::BindLambdaForTesting(
[&did_close_programmatically]() { did_close_programmatically = true; });
bubble_delegate->PendingShow();
bubble_delegate->OnBubbleShown(std::move(close_callback));
extension_registrar()->DisableExtension(
extension->id(), {extensions::disable_reason::DISABLE_USER_ACTION});
// The bubble should close as part of the extension being unloaded.
EXPECT_TRUE(did_close_programmatically);
// And it should remain unacknowledged.
EXPECT_FALSE(IsExtensionAcknowledged(extension->id()));
}
TEST_F(ControlledHomeBubbleDelegateTest,
BubbleShouldntShowIfExtensionAcknowledged) {
scoped_refptr<const extensions::Extension> extension =
LoadExtensionOverridingHome();
ASSERT_TRUE(extension);
AcknowledgeExtension(extension->id());
auto bubble_delegate =
std::make_unique<ControlledHomeBubbleDelegate>(browser());
EXPECT_FALSE(bubble_delegate->ShouldShow());
}
TEST_F(ControlledHomeBubbleDelegateTest, LongExtensionNameIsTruncated) {
const std::u16string long_name =
u"This extension name should be longer than our truncation threshold "
"to test that the bubble can handle long names";
const std::u16string truncated_name =
extensions::util::GetFixupExtensionNameForUIDisplay(long_name);
ASSERT_LT(truncated_name.size(), long_name.size());
scoped_refptr<const extensions::Extension> extension =
LoadExtensionOverridingHome(base::UTF16ToUTF8(long_name));
ASSERT_TRUE(extension);
auto bubble_delegate =
std::make_unique<ControlledHomeBubbleDelegate>(browser());
EXPECT_TRUE(bubble_delegate->ShouldShow());
// Extension name is only shown if the dialog is not anchored to an action.
std::u16string bubble_text =
bubble_delegate->GetBodyText(/*anchored_to_action=*/false);
EXPECT_FALSE(base::Contains(bubble_text, long_name));
EXPECT_TRUE(base::Contains(bubble_text, truncated_name));
}
TEST_F(ControlledHomeBubbleDelegateTest,
ExecutingOnOneExtensionDoesntAffectAnotherExtension) {
scoped_refptr<const extensions::Extension> extension1 =
LoadExtensionOverridingHome("ext1");
scoped_refptr<const extensions::Extension> extension2 =
LoadExtensionOverridingHome("ext2");
ASSERT_TRUE(extension1);
ASSERT_TRUE(extension2);
{
auto bubble_delegate =
std::make_unique<ControlledHomeBubbleDelegate>(browser());
EXPECT_TRUE(bubble_delegate->ShouldShow());
// The most-recently-installed extension should control the home page
// (`extension2`).
EXPECT_EQ(extension2, bubble_delegate->extension_for_testing());
bool did_close_programmatically = false;
auto close_callback = base::BindLambdaForTesting(
[&did_close_programmatically]() { did_close_programmatically = true; });
bubble_delegate->PendingShow();
bubble_delegate->OnBubbleShown(std::move(close_callback));
// Close the bubble with the "execute" action.
bubble_delegate->OnBubbleClosed(
ToolbarActionsBarBubbleDelegate::CLOSE_EXECUTE);
EXPECT_TRUE(IsExtensionDisabled(
extension2->id(), extensions::disable_reason::DISABLE_USER_ACTION));
EXPECT_TRUE(IsExtensionEnabled(extension1->id()));
EXPECT_FALSE(IsExtensionAcknowledged(extension2->id()));
EXPECT_FALSE(IsExtensionAcknowledged(extension1->id()));
}
{
auto bubble_delegate =
std::make_unique<ControlledHomeBubbleDelegate>(browser());
// Since `extension2` was removed, we shouldn't have acknowledged either
// extension and we can re-show the bubble if the homepage is controlled
// by another extension.
EXPECT_TRUE(bubble_delegate->ShouldShow());
EXPECT_EQ(extension1, bubble_delegate->extension_for_testing());
}
}
TEST_F(ControlledHomeBubbleDelegateTest,
AcknowledgingOneExtensionDoesntAffectAnother) {
scoped_refptr<const extensions::Extension> extension1 =
LoadExtensionOverridingHome("ext1");
scoped_refptr<const extensions::Extension> extension2 =
LoadExtensionOverridingHome("ext2");
ASSERT_TRUE(extension1);
ASSERT_TRUE(extension2);
{
auto bubble_delegate =
std::make_unique<ControlledHomeBubbleDelegate>(browser());
EXPECT_TRUE(bubble_delegate->ShouldShow());
EXPECT_EQ(extension2, bubble_delegate->extension_for_testing());
bool did_close_programmatically = false;
auto close_callback = base::BindLambdaForTesting(
[&did_close_programmatically]() { did_close_programmatically = true; });
bubble_delegate->PendingShow();
bubble_delegate->OnBubbleShown(std::move(close_callback));
// Dismiss the bubble; this acknowledges the extension.
bubble_delegate->OnBubbleClosed(
ToolbarActionsBarBubbleDelegate::CLOSE_DISMISS_USER_ACTION);
EXPECT_TRUE(IsExtensionEnabled(extension2->id()));
EXPECT_TRUE(IsExtensionAcknowledged(extension2->id()));
EXPECT_TRUE(IsExtensionEnabled(extension1->id()));
EXPECT_FALSE(IsExtensionAcknowledged(extension1->id()));
}
{
// The bubble shouldn't want to show (the extension that controls the home
// page was acknowledged).
auto bubble_delegate =
std::make_unique<ControlledHomeBubbleDelegate>(browser());
EXPECT_FALSE(bubble_delegate->ShouldShow());
}
// Disable the extension that was acknowledged.
extension_registrar()->DisableExtension(
extension2->id(), {extensions::disable_reason::DISABLE_USER_ACTION});
{
auto bubble_delegate =
std::make_unique<ControlledHomeBubbleDelegate>(browser());
// Now a new extension controls the home page, so we should re-show the
// bubble.
EXPECT_TRUE(bubble_delegate->ShouldShow());
EXPECT_EQ(extension1, bubble_delegate->extension_for_testing());
}
}
TEST_F(ControlledHomeBubbleDelegateTest,
PolicyExtensionsRequirePolicyIndicators) {
scoped_refptr<const extensions::Extension> extension =
LoadExtensionOverridingHome(
"ext", extensions::mojom::ManifestLocation::kExternalPolicy);
ASSERT_TRUE(extension);
auto bubble_delegate =
std::make_unique<ControlledHomeBubbleDelegate>(browser());
// We still show the bubble for policy-installed extensions, but it should
// have a policy decoration.
EXPECT_TRUE(bubble_delegate->ShouldShow());
EXPECT_EQ(u"", bubble_delegate->GetActionButtonText());
std::unique_ptr<ToolbarActionsBarBubbleDelegate::ExtraViewInfo> extra_view =
bubble_delegate->GetExtraViewInfo();
// Note: Mac vs Win message styling.
EXPECT_TRUE(extra_view->text == u"Installed by your administrator" ||
extra_view->text == u"Installed by Your Administrator");
EXPECT_FALSE(extra_view->is_learn_more);
}
#endif
|