1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
|
// Copyright 2012 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ui/global_error/global_error_service.h"
#include <memory>
#include "base/memory/ptr_util.h"
#include "base/strings/utf_string_conversions.h"
#include "build/build_config.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/global_error/global_error.h"
#include "chrome/browser/ui/global_error/global_error_bubble_view_base.h"
#include "chrome/browser/ui/global_error/global_error_service_factory.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "content/public/test/browser_test.h"
#include "content/public/test/test_utils.h"
namespace {
// An error that has a bubble view.
class BubbleViewError final : public GlobalErrorWithStandardBubble {
public:
BubbleViewError() = default;
BubbleViewError(const BubbleViewError&) = delete;
BubbleViewError& operator=(const BubbleViewError&) = delete;
int bubble_view_close_count() { return bubble_view_close_count_; }
bool HasMenuItem() override { return false; }
int MenuItemCommandID() override {
ADD_FAILURE();
return 0;
}
std::u16string MenuItemLabel() override {
ADD_FAILURE();
return std::u16string();
}
void ExecuteMenuItem(Browser* browser) override { ADD_FAILURE(); }
bool HasBubbleView() override { return true; }
std::u16string GetBubbleViewTitle() override { return std::u16string(); }
std::vector<std::u16string> GetBubbleViewMessages() override {
return std::vector<std::u16string>();
}
std::u16string GetBubbleViewAcceptButtonLabel() override { return u"OK"; }
std::u16string GetBubbleViewCancelButtonLabel() override { return u"Cancel"; }
void OnBubbleViewDidClose(Browser* browser) override {
EXPECT_TRUE(browser);
++bubble_view_close_count_;
}
void BubbleViewAcceptButtonPressed(Browser* browser) override {}
void BubbleViewCancelButtonPressed(Browser* browser) override {}
base::WeakPtr<GlobalErrorWithStandardBubble> AsWeakPtr() override {
return weak_ptr_factory_.GetWeakPtr();
}
private:
int bubble_view_close_count_ = 0;
base::WeakPtrFactory<BubbleViewError> weak_ptr_factory_{this};
};
} // namespace
class GlobalErrorServiceBrowserTest : public InProcessBrowserTest {};
// Test that showing a error with a bubble view works.
IN_PROC_BROWSER_TEST_F(GlobalErrorServiceBrowserTest, ShowBubbleView) {
// This will be deleted by the GlobalErrorService.
BubbleViewError* error = new BubbleViewError;
GlobalErrorService* service =
GlobalErrorServiceFactory::GetForProfile(browser()->profile());
service->AddGlobalError(base::WrapUnique(error));
EXPECT_EQ(error, service->GetFirstGlobalErrorWithBubbleView());
EXPECT_FALSE(error->HasShownBubbleView());
EXPECT_EQ(0, error->bubble_view_close_count());
// Creating a second browser window should show the bubble view.
CreateBrowser(browser()->profile());
EXPECT_EQ(nullptr, service->GetFirstGlobalErrorWithBubbleView());
EXPECT_TRUE(error->HasShownBubbleView());
EXPECT_EQ(0, error->bubble_view_close_count());
}
// Test that GlobalErrorBubbleViewBase::CloseBubbleView correctly closes the
// bubble view.
IN_PROC_BROWSER_TEST_F(GlobalErrorServiceBrowserTest, CloseBubbleView) {
// This will be deleted by the GlobalErrorService.
BubbleViewError* error = new BubbleViewError;
GlobalErrorService* service =
GlobalErrorServiceFactory::GetForProfile(browser()->profile());
service->AddGlobalError(base::WrapUnique(error));
EXPECT_EQ(error, service->GetFirstGlobalErrorWithBubbleView());
EXPECT_FALSE(error->HasShownBubbleView());
EXPECT_EQ(0, error->bubble_view_close_count());
// Creating a second browser window should show the bubble view.
CreateBrowser(browser()->profile());
EXPECT_EQ(nullptr, service->GetFirstGlobalErrorWithBubbleView());
EXPECT_TRUE(error->HasShownBubbleView());
EXPECT_EQ(0, error->bubble_view_close_count());
// Explicitly close the bubble view.
EXPECT_TRUE(error->GetBubbleView());
error->GetBubbleView()->CloseBubbleView();
content::RunAllPendingInMessageLoop();
EXPECT_EQ(1, error->bubble_view_close_count());
}
// Test that bubble is silently dismissed if it is showing when the GlobalError
// instance is removed from the profile.
//
// This uses the deprecated "unowned" API to the GlobalErrorService to maintain
// coverage. When those calls are eventually removed (http://crbug.com/673578)
// these uses should be switched to the non-deprecated API.
IN_PROC_BROWSER_TEST_F(GlobalErrorServiceBrowserTest,
BubbleViewDismissedOnRemove) {
std::unique_ptr<BubbleViewError> error(new BubbleViewError);
GlobalErrorService* service =
GlobalErrorServiceFactory::GetForProfile(browser()->profile());
service->AddUnownedGlobalError(error.get());
EXPECT_EQ(error.get(), service->GetFirstGlobalErrorWithBubbleView());
error->ShowBubbleView(browser());
content::RunAllPendingInMessageLoop();
EXPECT_TRUE(error->HasShownBubbleView());
EXPECT_EQ(0, error->bubble_view_close_count());
// Removing |error| from profile should dismiss the bubble view without
// calling |error->BubbleViewDidClose|.
service->RemoveUnownedGlobalError(error.get());
content::RunAllPendingInMessageLoop();
EXPECT_EQ(1, error->bubble_view_close_count());
}
|
