1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
|
// Copyright 2022 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ui/intent_picker_tab_helper.h"
#include "base/memory/raw_ptr.h"
#include "base/test/metrics/histogram_tester.h"
#include "base/test/scoped_feature_list.h"
#include "chrome/browser/apps/intent_helper/intent_chip_display_prefs.h"
#include "chrome/browser/apps/link_capturing/intent_picker_info.h"
#include "chrome/browser/apps/link_capturing/link_capturing_feature_test_support.h"
#include "chrome/test/base/chrome_render_view_host_test_harness.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/base/models/image_model.h"
#if BUILDFLAG(IS_CHROMEOS)
#include "chrome/browser/apps/link_capturing/metrics/intent_handling_metrics.h"
#endif // #if BUILDFLAG(IS_CHROMEOS)
class IntentPickerTabHelperTest : public ChromeRenderViewHostTestHarness,
public testing::WithParamInterface<
apps::test::LinkCapturingFeatureVersion> {
public:
IntentPickerTabHelperTest() {
scoped_feature_list_.InitWithFeaturesAndParameters(
apps::test::GetFeaturesToEnableLinkCapturingUX(GetParam()), {});
}
void SetUp() override {
ChromeRenderViewHostTestHarness::SetUp();
IntentPickerTabHelper::CreateForWebContents(web_contents());
helper_ = IntentPickerTabHelper::FromWebContents(web_contents());
}
IntentPickerTabHelper* helper() { return helper_; }
std::vector<apps::IntentPickerAppInfo> CreateTestAppList() {
return {
{apps::PickerEntryType::kWeb, ui::ImageModel(), "app_id", "Test app"}};
}
private:
raw_ptr<IntentPickerTabHelper, DanglingUntriaged> helper_;
base::test::ScopedFeatureList scoped_feature_list_;
};
TEST_P(IntentPickerTabHelperTest, ShowOrHideIcon) {
IntentPickerTabHelper::ShowOrHideIcon(web_contents(),
/*should_show_icon=*/true);
ASSERT_TRUE(helper()->should_show_icon());
IntentPickerTabHelper::ShowOrHideIcon(web_contents(),
/*should_show_icon=*/false);
ASSERT_FALSE(helper()->should_show_icon());
}
TEST_P(IntentPickerTabHelperTest, ShowIconForApps) {
NavigateAndCommit(GURL("https://www.google.com"));
helper()->MaybeShowIconForApps(CreateTestAppList());
ASSERT_TRUE(helper()->should_show_icon());
}
TEST_P(IntentPickerTabHelperTest, ShowIconForApps_ExpandedChip) {
const GURL kTestUrl = GURL("https://www.google.com");
NavigateAndCommit(kTestUrl);
helper()->MaybeShowIconForApps(CreateTestAppList());
ASSERT_TRUE(helper()->ShouldShowExpandedChip());
}
TEST_P(IntentPickerTabHelperTest, ShowIconForApps_CollapsedChip) {
const GURL kTestUrl = GURL("https://www.google.com");
// Simulate having seen the chip for this URL several times before, so that it
// appears collapsed.
for (int i = 0; i < 3; i++) {
IntentChipDisplayPrefs::GetChipStateAndIncrementCounter(profile(),
kTestUrl);
}
NavigateAndCommit(kTestUrl);
helper()->MaybeShowIconForApps(CreateTestAppList());
ASSERT_TRUE(helper()->should_show_icon());
ASSERT_FALSE(helper()->ShouldShowExpandedChip());
}
TEST_P(IntentPickerTabHelperTest, ShowIntentIcon_ResetsExpandedState) {
const GURL kTestUrl = GURL("https://www.google.com");
NavigateAndCommit(kTestUrl);
helper()->MaybeShowIconForApps(CreateTestAppList());
EXPECT_TRUE(helper()->should_show_icon());
EXPECT_TRUE(helper()->ShouldShowExpandedChip());
// Explicitly showing the icon should reset any app-based customizations.
IntentPickerTabHelper::ShowOrHideIcon(web_contents(),
/*should_show_icon=*/true);
ASSERT_FALSE(helper()->ShouldShowExpandedChip());
}
#if BUILDFLAG(IS_CHROMEOS)
TEST_P(IntentPickerTabHelperTest, LinkCapturing_EntryPointShown) {
base::HistogramTester histogram_tester;
NavigateAndCommit(GURL("https://www.google.com"));
// Create empty app list which ensures the intent picker icon is hidden.
helper()->MaybeShowIconForApps({});
histogram_tester.ExpectBucketCount("ChromeOS.Intents.IntentPickerIconEvent",
apps::IntentPickerIconEvent::kIconShown,
0);
// None of the histograms should be incremented.
histogram_tester.ExpectBucketCount(
"ChromeOS.Intents.LinkCapturingEvent2.WebApp",
apps::IntentHandlingMetrics::LinkCapturingEvent::kEntryPointShown, 0);
histogram_tester.ExpectBucketCount(
"ChromeOS.Intents.LinkCapturingEvent2.ArcApp",
apps::IntentHandlingMetrics::LinkCapturingEvent::kEntryPointShown, 0);
histogram_tester.ExpectBucketCount(
"ChromeOS.Intents.LinkCapturingEvent2",
apps::IntentHandlingMetrics::LinkCapturingEvent::kEntryPointShown, 0);
// Create app list with both a web and an ARC app, and show the intent picker
// icon.
{
std::vector<apps::IntentPickerAppInfo> apps_list;
apps_list = {
{apps::PickerEntryType::kWeb, ui::ImageModel(), "app_id", "Test app"},
{apps::PickerEntryType::kArc, ui::ImageModel(), "app_id", "Test app"}};
helper()->MaybeShowIconForApps(std::move(apps_list));
}
histogram_tester.ExpectBucketCount("ChromeOS.Intents.IntentPickerIconEvent",
apps::IntentPickerIconEvent::kIconShown,
1);
// All of the histograms should be incremented.
histogram_tester.ExpectBucketCount(
"ChromeOS.Intents.LinkCapturingEvent2.WebApp",
apps::IntentHandlingMetrics::LinkCapturingEvent::kEntryPointShown, 1);
histogram_tester.ExpectBucketCount(
"ChromeOS.Intents.LinkCapturingEvent2.ArcApp",
apps::IntentHandlingMetrics::LinkCapturingEvent::kEntryPointShown, 1);
histogram_tester.ExpectBucketCount(
"ChromeOS.Intents.LinkCapturingEvent2",
apps::IntentHandlingMetrics::LinkCapturingEvent::kEntryPointShown, 1);
// Hide the intent picker icon.
helper()->MaybeShowIconForApps({});
// Create app list with only a web app and show the intent picker icon.
{
std::vector<apps::IntentPickerAppInfo> apps_list;
apps_list = {
{apps::PickerEntryType::kWeb, ui::ImageModel(), "app_id", "Test app"}};
helper()->MaybeShowIconForApps(std::move(apps_list));
}
histogram_tester.ExpectBucketCount("ChromeOS.Intents.IntentPickerIconEvent",
apps::IntentPickerIconEvent::kIconShown,
2);
// Only the web app and general histograms should be incremented.
histogram_tester.ExpectBucketCount(
"ChromeOS.Intents.LinkCapturingEvent2.WebApp",
apps::IntentHandlingMetrics::LinkCapturingEvent::kEntryPointShown, 2);
histogram_tester.ExpectBucketCount(
"ChromeOS.Intents.LinkCapturingEvent2.ArcApp",
apps::IntentHandlingMetrics::LinkCapturingEvent::kEntryPointShown, 1);
histogram_tester.ExpectBucketCount(
"ChromeOS.Intents.LinkCapturingEvent2",
apps::IntentHandlingMetrics::LinkCapturingEvent::kEntryPointShown, 2);
// Hide the intent picker icon.
helper()->MaybeShowIconForApps({});
// Create app list with only an ARC app and show the intent picker icon.
{
std::vector<apps::IntentPickerAppInfo> apps_list;
apps_list = {
{apps::PickerEntryType::kArc, ui::ImageModel(), "app_id", "Test app"}};
helper()->MaybeShowIconForApps(std::move(apps_list));
}
histogram_tester.ExpectBucketCount("ChromeOS.Intents.IntentPickerIconEvent",
apps::IntentPickerIconEvent::kIconShown,
3);
// Only the ARC app and general histograms should be incremented.
histogram_tester.ExpectBucketCount(
"ChromeOS.Intents.LinkCapturingEvent2.WebApp",
apps::IntentHandlingMetrics::LinkCapturingEvent::kEntryPointShown, 2);
histogram_tester.ExpectBucketCount(
"ChromeOS.Intents.LinkCapturingEvent2.ArcApp",
apps::IntentHandlingMetrics::LinkCapturingEvent::kEntryPointShown, 2);
histogram_tester.ExpectBucketCount(
"ChromeOS.Intents.LinkCapturingEvent2",
apps::IntentHandlingMetrics::LinkCapturingEvent::kEntryPointShown, 3);
// Hide the intent picker icon.
helper()->MaybeShowIconForApps({});
// Create app list with non-ARC and non-web types and show the intent picker
// icon.
{
std::vector<apps::IntentPickerAppInfo> apps_list;
apps_list = {{apps::PickerEntryType::kMacOs, ui::ImageModel(), "app_id",
"Test app"}};
helper()->MaybeShowIconForApps(std::move(apps_list));
}
histogram_tester.ExpectBucketCount("ChromeOS.Intents.IntentPickerIconEvent",
apps::IntentPickerIconEvent::kIconShown,
4);
// Only the general histogram should be incremented.
histogram_tester.ExpectBucketCount(
"ChromeOS.Intents.LinkCapturingEvent2.WebApp",
apps::IntentHandlingMetrics::LinkCapturingEvent::kEntryPointShown, 2);
histogram_tester.ExpectBucketCount(
"ChromeOS.Intents.LinkCapturingEvent2.ArcApp",
apps::IntentHandlingMetrics::LinkCapturingEvent::kEntryPointShown, 2);
histogram_tester.ExpectBucketCount(
"ChromeOS.Intents.LinkCapturingEvent2",
apps::IntentHandlingMetrics::LinkCapturingEvent::kEntryPointShown, 4);
}
#else
TEST_P(IntentPickerTabHelperTest, IconShownMetricsTriggered) {
base::HistogramTester histogram_tester;
NavigateAndCommit(GURL("https://www.google.com"));
// Create empty app list which ensures the intent picker icon is hidden.
helper()->MaybeShowIconForApps({});
histogram_tester.ExpectBucketCount(
"Webapp.Site.Intents.IntentPickerIconEvent",
apps::IntentPickerIconEvent::kIconShown, 0);
}
#endif // #if BUILDFLAG(IS_CHROMEOS)
INSTANTIATE_TEST_SUITE_P(
All,
IntentPickerTabHelperTest,
#if BUILDFLAG(IS_CHROMEOS)
testing::Values(apps::test::LinkCapturingFeatureVersion::kV1DefaultOff,
apps::test::LinkCapturingFeatureVersion::kV2DefaultOff)
#else
testing::Values(apps::test::LinkCapturingFeatureVersion::kV2DefaultOff,
apps::test::LinkCapturingFeatureVersion::kV2DefaultOn)
#endif // BUILDFLAG(IS_CHROMEOS)
,
apps::test::LinkCapturingVersionToString);
|
