1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
|
// Copyright 2019 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ui/passwords/credential_leak_dialog_controller_impl.h"
#include <memory>
#include "base/test/metrics/histogram_tester.h"
#include "base/test/scoped_feature_list.h"
#include "base/test/task_environment.h"
#include "chrome/browser/ui/passwords/password_dialog_prompts.h"
#include "chrome/browser/ui/passwords/passwords_leak_dialog_delegate_mock.h"
#include "components/password_manager/core/browser/leak_detection_dialog_utils.h"
#include "components/password_manager/core/browser/password_manager_metrics_util.h"
#include "components/password_manager/core/common/password_manager_features.h"
#include "components/ukm/test_ukm_recorder.h"
#include "services/metrics/public/cpp/ukm_builders.h"
#include "services/metrics/public/cpp/ukm_source_id.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "url/gurl.h"
namespace views {
class Widget;
}
namespace {
constexpr ukm::SourceId kTestSourceId = 0x1234;
using password_manager::CreateLeakType;
using password_manager::HasChangePasswordUrl;
using password_manager::IsReused;
using password_manager::IsSaved;
using password_manager::IsSyncing;
using password_manager::metrics_util::LeakDialogDismissalReason;
using password_manager::metrics_util::LeakDialogMetricsRecorder;
using password_manager::metrics_util::LeakDialogType;
using testing::StrictMock;
using UkmEntry = ukm::builders::PasswordManager_LeakWarningDialog;
class MockCredentialLeakPrompt : public CredentialLeakPrompt {
public:
MockCredentialLeakPrompt() = default;
MockCredentialLeakPrompt(const MockCredentialLeakPrompt&) = delete;
MockCredentialLeakPrompt& operator=(const MockCredentialLeakPrompt&) = delete;
MOCK_METHOD(void, ShowCredentialLeakPrompt, (), (override));
MOCK_METHOD(views::Widget*, GetWidgetForTesting, (), (override));
};
class CredentialLeakDialogControllerTest : public testing::Test {
public:
void SetUpController(password_manager::CredentialLeakType leak_type) {
auto recorder = std::make_unique<LeakDialogMetricsRecorder>(
kTestSourceId, password_manager::GetLeakDialogType(leak_type));
// Set sampling rate to 100% for UKM metrics.
recorder->SetSamplingRateForTesting(1.0);
controller_ = std::make_unique<CredentialLeakDialogControllerImpl>(
&ui_controller_mock_, leak_type, std::move(recorder));
}
std::unique_ptr<StrictMock<MockCredentialLeakPrompt>> SetupLeakPrompt() {
return std::make_unique<StrictMock<MockCredentialLeakPrompt>>();
}
base::HistogramTester& histogram_tester() { return histogram_tester_; }
PasswordsLeakDialogDelegateMock& ui_controller_mock() {
return ui_controller_mock_;
}
ukm::TestAutoSetUkmRecorder& test_ukm_recorder() {
return test_ukm_recorder_;
}
CredentialLeakDialogControllerImpl& controller() { return *controller_; }
private:
base::test::TaskEnvironment task_environment_;
base::HistogramTester histogram_tester_;
ukm::TestAutoSetUkmRecorder test_ukm_recorder_;
StrictMock<PasswordsLeakDialogDelegateMock> ui_controller_mock_;
std::unique_ptr<CredentialLeakDialogControllerImpl> controller_;
};
void CheckUkmMetricsExpectations(
ukm::TestAutoSetUkmRecorder& recorder,
LeakDialogType expected_dialog_type,
LeakDialogDismissalReason expected_dismissal_reason) {
const auto& entries = recorder.GetEntriesByName(UkmEntry::kEntryName);
EXPECT_EQ(1u, entries.size());
for (const ukm::mojom::UkmEntry* entry : entries) {
EXPECT_EQ(kTestSourceId, entry->source_id);
recorder.ExpectEntryMetric(entry,
UkmEntry::kPasswordLeakDetectionDialogTypeName,
static_cast<int64_t>(expected_dialog_type));
recorder.ExpectEntryMetric(
entry, UkmEntry::kPasswordLeakDetectionDialogDismissalReasonName,
static_cast<int64_t>(expected_dismissal_reason));
}
}
TEST_F(CredentialLeakDialogControllerTest, CredentialLeakDialogClose) {
SetUpController(
CreateLeakType(IsSaved(false), IsReused(false), IsSyncing(false)));
auto leak_prompt = SetupLeakPrompt();
EXPECT_CALL(*leak_prompt, ShowCredentialLeakPrompt());
controller().ShowCredentialLeakPrompt(std::move(leak_prompt));
EXPECT_CALL(ui_controller_mock(), OnLeakDialogHidden());
controller().OnCloseDialog();
histogram_tester().ExpectUniqueSample(
"PasswordManager.LeakDetection.DialogDismissalReason",
LeakDialogDismissalReason::kNoDirectInteraction, 1);
histogram_tester().ExpectUniqueSample(
"PasswordManager.LeakDetection.DialogDismissalReason.Change",
LeakDialogDismissalReason::kNoDirectInteraction, 1);
CheckUkmMetricsExpectations(test_ukm_recorder(), LeakDialogType::kChange,
LeakDialogDismissalReason::kNoDirectInteraction);
}
TEST_F(CredentialLeakDialogControllerTest, CredentialLeakDialogOk) {
SetUpController(
CreateLeakType(IsSaved(true), IsReused(false), IsSyncing(false)));
auto leak_prompt = SetupLeakPrompt();
EXPECT_CALL(*leak_prompt, ShowCredentialLeakPrompt());
controller().ShowCredentialLeakPrompt(std::move(leak_prompt));
EXPECT_CALL(ui_controller_mock(), OnLeakDialogHidden());
controller().OnAcceptDialog();
histogram_tester().ExpectUniqueSample(
"PasswordManager.LeakDetection.DialogDismissalReason",
LeakDialogDismissalReason::kClickedOk, 1);
histogram_tester().ExpectUniqueSample(
"PasswordManager.LeakDetection.DialogDismissalReason.Change",
LeakDialogDismissalReason::kClickedOk, 1);
CheckUkmMetricsExpectations(test_ukm_recorder(), LeakDialogType::kChange,
LeakDialogDismissalReason::kClickedOk);
}
TEST_F(CredentialLeakDialogControllerTest, CredentialLeakDialogCancel) {
SetUpController(
CreateLeakType(IsSaved(false), IsReused(true), IsSyncing(true)));
auto leak_prompt = SetupLeakPrompt();
EXPECT_CALL(*leak_prompt, ShowCredentialLeakPrompt());
controller().ShowCredentialLeakPrompt(std::move(leak_prompt));
EXPECT_CALL(ui_controller_mock(), OnLeakDialogHidden());
controller().OnCancelDialog();
histogram_tester().ExpectUniqueSample(
"PasswordManager.LeakDetection.DialogDismissalReason",
LeakDialogDismissalReason::kClickedClose, 1);
histogram_tester().ExpectUniqueSample(
"PasswordManager.LeakDetection.DialogDismissalReason.CheckupAndChange",
LeakDialogDismissalReason::kClickedClose, 1);
CheckUkmMetricsExpectations(test_ukm_recorder(),
LeakDialogType::kCheckupAndChange,
LeakDialogDismissalReason::kClickedClose);
}
TEST_F(CredentialLeakDialogControllerTest, CredentialLeakDialogCheckPasswords) {
SetUpController(
CreateLeakType(IsSaved(true), IsReused(true), IsSyncing(true)));
auto leak_prompt = SetupLeakPrompt();
EXPECT_CALL(*leak_prompt, ShowCredentialLeakPrompt());
controller().ShowCredentialLeakPrompt(std::move(leak_prompt));
EXPECT_CALL(
ui_controller_mock(),
NavigateToPasswordCheckup(
password_manager::PasswordCheckReferrer::kPasswordBreachDialog));
EXPECT_CALL(ui_controller_mock(), OnLeakDialogHidden());
controller().OnAcceptDialog();
histogram_tester().ExpectUniqueSample(
"PasswordManager.LeakDetection.DialogDismissalReason",
LeakDialogDismissalReason::kClickedCheckPasswords, 1);
histogram_tester().ExpectUniqueSample(
"PasswordManager.LeakDetection.DialogDismissalReason.Checkup",
LeakDialogDismissalReason::kClickedCheckPasswords, 1);
CheckUkmMetricsExpectations(
test_ukm_recorder(), LeakDialogType::kCheckup,
LeakDialogDismissalReason::kClickedCheckPasswords);
}
} // namespace
|
