1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442
|
// Copyright 2023 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ui/safety_hub/menu_notification_service.h"
#include <ctime>
#include <memory>
#include <optional>
#include <string>
#include "base/time/time.h"
#include "base/values.h"
#include "chrome/app/chrome_command_ids.h"
#include "chrome/browser/content_settings/host_content_settings_map_factory.h"
#include "chrome/browser/password_manager/password_manager_test_util.h"
#include "chrome/browser/permissions/notifications_engagement_service_factory.h"
#include "chrome/browser/ui/safety_hub/menu_notification.h"
#include "chrome/browser/ui/safety_hub/menu_notification_service_factory.h"
#include "chrome/browser/ui/safety_hub/notification_permission_review_service_factory.h"
#include "chrome/browser/ui/safety_hub/revoked_permissions_service_factory.h"
#include "chrome/browser/ui/safety_hub/safety_hub_constants.h"
#include "chrome/browser/ui/safety_hub/safety_hub_prefs.h"
#include "chrome/browser/ui/safety_hub/safety_hub_test_util.h"
#include "chrome/common/chrome_features.h"
#include "chrome/common/pref_names.h"
#include "chrome/grit/generated_resources.h"
#include "chrome/test/base/chrome_render_view_host_test_harness.h"
#include "components/content_settings/core/browser/host_content_settings_map.h"
#include "components/permissions/constants.h"
#include "components/permissions/pref_names.h"
#include "components/safe_browsing/core/common/features.h"
#include "components/safe_browsing/core/common/safe_browsing_prefs.h"
#include "components/sync_preferences/testing_pref_service_syncable.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/base/l10n/l10n_util.h"
#if !BUILDFLAG(IS_ANDROID)
#include "chrome/browser/extensions/cws_info_service_factory.h"
#include "chrome/browser/password_manager/password_manager_test_util.h"
#include "chrome/browser/ui/safety_hub/password_status_check_service.h"
#include "chrome/browser/ui/safety_hub/password_status_check_service_factory.h"
#include "chrome/browser/ui/safety_hub/safety_hub_hats_service.h"
#include "chrome/browser/ui/safety_hub/safety_hub_hats_service_factory.h"
#include "components/password_manager/core/browser/password_store/test_password_store.h"
#endif // BUILDFLAG(IS_ANDROID)
using ::testing::_;
class SafetyHubMenuNotificationServiceTest
: public ChromeRenderViewHostTestHarness {
public:
SafetyHubMenuNotificationServiceTest()
: ChromeRenderViewHostTestHarness(
base::test::TaskEnvironment::TimeSource::MOCK_TIME) {}
void SetUp() override {
ChromeRenderViewHostTestHarness::SetUp();
feature_list_.InitWithFeatures(
{
features::kSafetyHub,
#if BUILDFLAG(IS_ANDROID)
features::kSafetyHubFollowup,
#endif // BUILDFLAG(IS_ANDROID)
},
{});
prefs()->SetBoolean(
safety_hub_prefs::kUnusedSitePermissionsRevocationEnabled, true);
safety_hub_test_util::CreateRevokedPermissionsService(profile());
safety_hub_test_util::CreateNotificationPermissionsReviewService(profile());
}
void TearDown() override {
// Wait till all ongoing tasks to be finalized to let password manager
// enough time to complete password checks.
RunUntilIdle();
ChromeRenderViewHostTestHarness::TearDown();
}
// TODO(crbug.com/40267370): Replace this with password_service specific
// RunUntilIdle.
void RunUntilIdle() { task_environment()->RunUntilIdle(); }
protected:
void CreateMockNotificationPermissionEntry() {
const GURL url = GURL("https://example.com:443");
hcsm()->SetContentSettingDefaultScope(
url, GURL(), ContentSettingsType::NOTIFICATIONS, CONTENT_SETTING_ALLOW);
auto* notifications_engagement_service =
NotificationsEngagementServiceFactory::GetForProfile(profile());
// For simplicity, not setting an engagement score as that implies a NONE
// engagement level, and will mark the site for review of notification
// permissions.
notifications_engagement_service->RecordNotificationDisplayed(url, 7);
safety_hub_test_util::UpdateSafetyHubServiceAsync(
notification_permissions_service());
}
void CreateMockUnusedSitePermissionsEntry(const std::string url) {
// Revoke permission and update the unused site permission service.
auto dict = base::Value::Dict().Set(
permissions::kRevokedKey,
base::Value::List().Append(
RevokedPermissionsService::ConvertContentSettingsTypeToKey(
ContentSettingsType::GEOLOCATION)));
hcsm()->SetWebsiteSettingDefaultScope(
GURL(url), GURL(url),
ContentSettingsType::REVOKED_UNUSED_SITE_PERMISSIONS,
base::Value(dict.Clone()));
safety_hub_test_util::UpdateSafetyHubServiceAsync(
revoked_permissions_service());
}
void ShowNotificationEnoughTimes(
int remainingImpressionCount =
kSafetyHubMenuNotificationMinImpressionCount) {
std::optional<MenuNotificationEntry> notification;
AdvanceClockBy(base::Days(90));
for (int i = 0; i < remainingImpressionCount; ++i) {
notification = menu_notification_service()->GetNotificationToShow();
EXPECT_TRUE(notification.has_value());
}
AdvanceClockBy(kSafetyHubMenuNotificationMinNotificationDuration);
notification = menu_notification_service()->GetNotificationToShow();
EXPECT_FALSE(notification.has_value());
}
RevokedPermissionsService* revoked_permissions_service() {
return RevokedPermissionsServiceFactory::GetForProfile(profile());
}
NotificationPermissionsReviewService* notification_permissions_service() {
return NotificationPermissionsReviewServiceFactory::GetForProfile(
profile());
}
SafetyHubMenuNotificationService* menu_notification_service() {
return SafetyHubMenuNotificationServiceFactory::GetForProfile(profile());
}
sync_preferences::TestingPrefServiceSyncable* prefs() {
return profile()->GetTestingPrefService();
}
HostContentSettingsMap* hcsm() {
return HostContentSettingsMapFactory::GetForProfile(profile());
}
// Using |AdvanceClockBy| when the timers are not required to execute.
void AdvanceClockBy(base::TimeDelta delta) {
task_environment()->AdvanceClock(delta);
}
void ExpectPluralString(int string_id,
int count,
std::u16string notification_string) {
EXPECT_EQ(l10n_util::GetPluralStringFUTF16(string_id, count),
notification_string);
}
private:
base::test::ScopedFeatureList feature_list_;
};
TEST_F(SafetyHubMenuNotificationServiceTest, GetNotificationToShowNoResult) {
std::optional<MenuNotificationEntry> notification =
menu_notification_service()->GetNotificationToShow();
EXPECT_FALSE(notification.has_value());
}
TEST_F(SafetyHubMenuNotificationServiceTest, SingleNotificationToShow) {
CreateMockUnusedSitePermissionsEntry("https://example1.com:443");
// The notification to show should be the unused site permissions one with
// one revoked permission. The relevant command should be to open Safety Hub.
std::optional<MenuNotificationEntry> notification =
menu_notification_service()->GetNotificationToShow();
EXPECT_TRUE(notification.has_value());
ExpectPluralString(
IDS_SETTINGS_SAFETY_HUB_REVOKED_PERMISSIONS_MENU_NOTIFICATION, 1,
notification.value().label);
EXPECT_EQ(IDC_OPEN_SAFETY_HUB, notification.value().command);
}
TEST_F(SafetyHubMenuNotificationServiceTest, TwoNotificationsIncremental) {
// Create a mock notification for example1.com, and show it sufficiently.
CreateMockUnusedSitePermissionsEntry("https://example1.com:443");
std::optional<MenuNotificationEntry> notification;
for (int i = 0; i < kSafetyHubMenuNotificationMinImpressionCount; ++i) {
notification = menu_notification_service()->GetNotificationToShow();
EXPECT_TRUE(notification.has_value());
ExpectPluralString(
IDS_SETTINGS_SAFETY_HUB_REVOKED_PERMISSIONS_MENU_NOTIFICATION, 1,
notification->label);
}
AdvanceClockBy(kSafetyHubMenuNotificationMinNotificationDuration);
// The notification has been shown sufficiently, so shouldn't be shown again.
notification = menu_notification_service()->GetNotificationToShow();
EXPECT_FALSE(notification.has_value());
// Even after the interval has passed, no notification should be shown.
const base::TimeDelta kNotificationIntervalUnusedSitePermissions =
base::Days(10);
AdvanceClockBy(kNotificationIntervalUnusedSitePermissions);
// The notification has been shown sufficiently, so shouldn't be shown again.
notification = menu_notification_service()->GetNotificationToShow();
EXPECT_FALSE(notification.has_value());
// Create a mock notification for the same example1.com, and a new one for
// example2.com. Because of this new one, there now should be a new
// notification.
CreateMockUnusedSitePermissionsEntry("https://example1.com:443");
CreateMockUnusedSitePermissionsEntry("https://example2.com:443");
notification = menu_notification_service()->GetNotificationToShow();
EXPECT_TRUE(notification.has_value());
}
TEST_F(SafetyHubMenuNotificationServiceTest, TwoNotificationsSequentially) {
// Creating a mock result, which should result in a notification to be
// available.
CreateMockUnusedSitePermissionsEntry("https://example1.com:443");
// Show the notification sufficient days and times.
std::optional<MenuNotificationEntry> notification;
for (int i = 0; i < kSafetyHubMenuNotificationMinImpressionCount; ++i) {
notification = menu_notification_service()->GetNotificationToShow();
EXPECT_TRUE(notification.has_value());
ExpectPluralString(
IDS_SETTINGS_SAFETY_HUB_REVOKED_PERMISSIONS_MENU_NOTIFICATION, 1,
notification->label);
}
AdvanceClockBy(kSafetyHubMenuNotificationMinNotificationDuration);
// The notification has been shown sufficiently, so shouldn't be shown again.
notification = menu_notification_service()->GetNotificationToShow();
EXPECT_FALSE(notification.has_value());
CreateMockNotificationPermissionEntry();
notification = menu_notification_service()->GetNotificationToShow();
EXPECT_TRUE(notification.has_value());
}
TEST_F(SafetyHubMenuNotificationServiceTest, TwoNotificationsNoOverride) {
// Creating a mock result, which should result in a notification to be
// available.
CreateMockUnusedSitePermissionsEntry("https://example1.com:443");
// Show the notification once.
std::optional<MenuNotificationEntry> notification;
notification = menu_notification_service()->GetNotificationToShow();
EXPECT_TRUE(notification.has_value());
ExpectPluralString(
IDS_SETTINGS_SAFETY_HUB_REVOKED_PERMISSIONS_MENU_NOTIFICATION, 1,
notification->label);
// Creating a notification permission shouldn't cause the active notification
// to be overridden.
CreateMockNotificationPermissionEntry();
notification = menu_notification_service()->GetNotificationToShow();
EXPECT_TRUE(notification.has_value());
ExpectPluralString(
IDS_SETTINGS_SAFETY_HUB_REVOKED_PERMISSIONS_MENU_NOTIFICATION, 1,
notification->label);
// Showing the notification sufficient days and times.
for (int i = 0; i < kSafetyHubMenuNotificationMinImpressionCount - 2; ++i) {
notification = menu_notification_service()->GetNotificationToShow();
EXPECT_TRUE(notification.has_value());
ExpectPluralString(
IDS_SETTINGS_SAFETY_HUB_REVOKED_PERMISSIONS_MENU_NOTIFICATION, 1,
notification->label);
}
AdvanceClockBy(kSafetyHubMenuNotificationMinNotificationDuration);
// After the unused site permissions notification has been shown sufficient
// times, the notification permission review notification should be shown.
notification = menu_notification_service()->GetNotificationToShow();
EXPECT_TRUE(notification.has_value());
ExpectPluralString(
IDS_SETTINGS_SAFETY_HUB_REVIEW_NOTIFICATION_PERMISSIONS_MENU_NOTIFICATION,
1, notification->label);
// Showing the new notification enough times and days.
for (int i = 0; i < kSafetyHubMenuNotificationMinImpressionCount - 1; ++i) {
notification = menu_notification_service()->GetNotificationToShow();
EXPECT_TRUE(notification.has_value());
ExpectPluralString(
IDS_SETTINGS_SAFETY_HUB_REVIEW_NOTIFICATION_PERMISSIONS_MENU_NOTIFICATION,
1, notification->label);
}
AdvanceClockBy(kSafetyHubMenuNotificationMinNotificationDuration);
// Both notifications have been shown sufficiently, so no new notification
// should be shown.
notification = menu_notification_service()->GetNotificationToShow();
EXPECT_FALSE(notification.has_value());
}
TEST_F(SafetyHubMenuNotificationServiceTest, SafeBrowsingOverride) {
// Create a notification for a module that has low priority notifications.
CreateMockUnusedSitePermissionsEntry("https://example1.com:443");
std::optional<MenuNotificationEntry> notification;
notification = menu_notification_service()->GetNotificationToShow();
EXPECT_TRUE(notification.has_value());
ExpectPluralString(
IDS_SETTINGS_SAFETY_HUB_REVOKED_PERMISSIONS_MENU_NOTIFICATION, 1,
notification->label);
// Disable safe browsing, which generates a medium-priority Safe Browsing
// notification that should override the low priority notification.
prefs()->SetBoolean(prefs::kSafeBrowsingEnabled, false);
AdvanceClockBy(base::Days(1));
notification = menu_notification_service()->GetNotificationToShow();
EXPECT_TRUE(notification.has_value());
EXPECT_EQ(l10n_util::GetStringUTF16(
IDS_SETTINGS_SAFETY_HUB_SAFE_BROWSING_MENU_NOTIFICATION),
notification.value().label);
// Re-enabling Safe Browsing should clear the notification. Because the unused
// site permission notification was dismissed, it will not be shown either.
prefs()->SetBoolean(prefs::kSafeBrowsingEnabled, true);
notification = menu_notification_service()->GetNotificationToShow();
EXPECT_FALSE(notification.has_value());
}
TEST_F(SafetyHubMenuNotificationServiceTest, SafeBrowsingTriggerLogic) {
std::optional<MenuNotificationEntry> notification;
// Disabling Safe Browsing should only trigger a menu notification after one
// day.
prefs()->SetBoolean(prefs::kSafeBrowsingEnabled, false);
notification = menu_notification_service()->GetNotificationToShow();
EXPECT_FALSE(notification.has_value());
AdvanceClockBy(base::Hours(12));
notification = menu_notification_service()->GetNotificationToShow();
EXPECT_FALSE(notification.has_value());
AdvanceClockBy(base::Hours(12));
notification = menu_notification_service()->GetNotificationToShow();
EXPECT_TRUE(notification.has_value());
// A notification for Safe Browsing should only be shown three times in total.
ShowNotificationEnoughTimes(kSafetyHubMenuNotificationMinImpressionCount - 1);
AdvanceClockBy(base::Days(90));
ShowNotificationEnoughTimes();
AdvanceClockBy(base::Days(90));
ShowNotificationEnoughTimes();
AdvanceClockBy(base::Days(90));
notification = menu_notification_service()->GetNotificationToShow();
EXPECT_FALSE(notification.has_value());
// When the user toggles the SB prefs, the notification can be shown again,
// after one day.
prefs()->SetBoolean(prefs::kSafeBrowsingEnabled, true);
prefs()->SetBoolean(prefs::kSafeBrowsingEnabled, false);
AdvanceClockBy(base::Days(1));
notification = menu_notification_service()->GetNotificationToShow();
EXPECT_TRUE(notification.has_value());
}
#if BUILDFLAG(IS_ANDROID)
TEST_F(SafetyHubMenuNotificationServiceTest, PasswordOverride) {
std::optional<MenuNotificationEntry> notification;
// Show Safe Browsing notification.
prefs()->SetBoolean(prefs::kSafeBrowsingEnabled, false);
notification = menu_notification_service()->GetNotificationToShow();
AdvanceClockBy(base::Days(1));
notification = menu_notification_service()->GetNotificationToShow();
EXPECT_TRUE(notification.has_value());
// A leaked password warning should override the Safe Browsing notification.
prefs()->SetInteger(prefs::kBreachedCredentialsCount, 1);
notification = menu_notification_service()->GetNotificationToShow();
EXPECT_TRUE(notification.has_value());
ExpectPluralString(
IDS_SETTINGS_SAFETY_HUB_COMPROMISED_PASSWORDS_MENU_NOTIFICATION, 1,
notification.value().label);
// Fixing the leaked password will clear notification. Because the safe
// browsing notification was dismissed, it will not be shown either.
prefs()->SetInteger(prefs::kBreachedCredentialsCount, 0);
notification = menu_notification_service()->GetNotificationToShow();
EXPECT_FALSE(notification.has_value());
}
TEST_F(SafetyHubMenuNotificationServiceTest, PasswordTrigger) {
// If the leaked password count is not yet fetched or the user is signed out,
// no notification should be displayed.
std::optional<MenuNotificationEntry> notification;
prefs()->SetInteger(prefs::kBreachedCredentialsCount, -1);
notification = menu_notification_service()->GetNotificationToShow();
EXPECT_FALSE(notification.has_value());
// A leaked password warning should create a password notification.
prefs()->SetInteger(prefs::kBreachedCredentialsCount, 2);
notification = menu_notification_service()->GetNotificationToShow();
EXPECT_TRUE(notification.has_value());
ExpectPluralString(
IDS_SETTINGS_SAFETY_HUB_COMPROMISED_PASSWORDS_MENU_NOTIFICATION, 2,
notification.value().label);
// The notification should no longer appear after it has been dismissed.
menu_notification_service()->DismissActiveNotificationOfModule(
safety_hub::SafetyHubModuleType::PASSWORDS);
notification = menu_notification_service()->GetNotificationToShow();
EXPECT_FALSE(notification.has_value());
// A leaked password count of lower value should NOT create a new password
// notification.
prefs()->SetInteger(prefs::kBreachedCredentialsCount, 1);
notification = menu_notification_service()->GetNotificationToShow();
EXPECT_FALSE(notification.has_value());
// A leaked password count of higher value should create a new password
// notification.
prefs()->SetInteger(prefs::kBreachedCredentialsCount, 3);
notification = menu_notification_service()->GetNotificationToShow();
EXPECT_TRUE(notification.has_value());
ExpectPluralString(
IDS_SETTINGS_SAFETY_HUB_COMPROMISED_PASSWORDS_MENU_NOTIFICATION, 3,
notification.value().label);
// Fixing the leaked passwords should clear notification.
prefs()->SetInteger(prefs::kBreachedCredentialsCount, 0);
notification = menu_notification_service()->GetNotificationToShow();
EXPECT_FALSE(notification.has_value());
}
#endif
TEST_F(SafetyHubMenuNotificationServiceTest, DismissNotifications) {
// Generate a mock notification for unused site permissions.
CreateMockUnusedSitePermissionsEntry("https://example1.com:443");
std::optional<MenuNotificationEntry> notification =
menu_notification_service()->GetNotificationToShow();
EXPECT_TRUE(notification.has_value());
ExpectPluralString(
IDS_SETTINGS_SAFETY_HUB_REVOKED_PERMISSIONS_MENU_NOTIFICATION, 1,
notification.value().label);
// When all notifications are dismissed, there should be no more notification
// but the last shown notification remains the same.
menu_notification_service()->DismissActiveNotification();
EXPECT_FALSE(
menu_notification_service()->GetNotificationToShow().has_value());
}
|