1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403
|
// Copyright 2019 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ui/tab_sharing/tab_sharing_infobar_delegate.h"
#include <tuple>
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/ui/tab_sharing/tab_sharing_ui.h"
#include "chrome/grit/generated_resources.h"
#include "chrome/test/base/browser_with_test_window_test.h"
#include "components/infobars/content/content_infobar_manager.h"
#include "components/infobars/core/infobar.h"
#include "components/url_formatter/elide_url.h"
#include "components/vector_icons/vector_icons.h"
#include "content/public/common/content_features.h"
#include "media/capture/capture_switches.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/gfx/vector_icon_types.h"
namespace {
using TabRole = ::TabSharingInfoBarDelegate::TabRole;
using ::content::GlobalRenderFrameHostId;
using ::vector_icons::kScreenShareIcon;
using ::vector_icons::kScreenShareOldIcon;
const std::u16string kSharedTabName = u"example.com";
const std::u16string kAppName = u"sharing.com";
const std::u16string kSinkName = u"Living Room TV";
const std::u16string kCapturedUrl = u"https://captured.chromium.org/";
const std::u16string kCapturingUrl = u"https://capturing.chromium.org/";
class MockTabSharingUIViews : public TabSharingUI {
public:
MockTabSharingUIViews() = default;
MOCK_METHOD(void, StartSharing, (infobars::InfoBar * infobar));
MOCK_METHOD(void, StopSharing, ());
gfx::NativeViewId OnStarted(
base::OnceClosure stop_callback,
content::MediaStreamUI::SourceCallback source_callback,
const std::vector<content::DesktopMediaID>& media_ids) override {
return 0;
}
void OnRegionCaptureRectChanged(
const std::optional<gfx::Rect>& region_capture_rect) override {}
};
} // namespace
class TabSharingInfoBarDelegateTest
: public BrowserWithTestWindowTest,
public ::testing::WithParamInterface<std::tuple<bool, bool>> {
public:
struct Preferences {
GlobalRenderFrameHostId shared_tab_id;
GlobalRenderFrameHostId capturer_id;
std::u16string shared_tab_name;
std::u16string capturer_name;
TabRole role;
bool can_share_instead;
int tab_index = 0;
GlobalRenderFrameHostId focus_target;
TabSharingInfoBarDelegate::TabShareType capture_type =
TabSharingInfoBarDelegate::TabShareType::CAPTURE;
};
TabSharingInfoBarDelegateTest()
: captured_surface_control_active_(std::get<0>(GetParam())),
enable_tab_capture_infobar_links_(std::get<1>(GetParam())) {
scoped_feature_list_.InitWithFeatureState(
features::kTabCaptureInfobarLinks, enable_tab_capture_infobar_links_);
}
infobars::InfoBar* CreateInfobar(const Preferences& prefs) {
content::WebContents* const web_contents =
browser()->tab_strip_model()->GetWebContentsAt(prefs.tab_index);
return TabSharingInfoBarDelegate::Create(
infobars::ContentInfoBarManager::FromWebContents(web_contents), nullptr,
prefs.shared_tab_id, prefs.capturer_id, prefs.shared_tab_name,
prefs.capturer_name, web_contents, prefs.role,
prefs.can_share_instead
? TabSharingInfoBarDelegate::ButtonState::ENABLED
: TabSharingInfoBarDelegate::ButtonState::NOT_SHOWN,
prefs.focus_target, captured_surface_control_active_,
tab_sharing_mock_ui(), prefs.capture_type);
}
TabSharingInfoBarDelegate* CreateDelegate(const Preferences& prefs) {
infobars::InfoBar* infobar = CreateInfobar(prefs);
return static_cast<TabSharingInfoBarDelegate*>(infobar->delegate());
}
content::WebContents* GetWebContents(int tab) {
return browser()->tab_strip_model()->GetWebContentsAt(tab);
}
GlobalRenderFrameHostId GetGlobalId(int tab) {
auto* const main_frame = GetWebContents(tab)->GetPrimaryMainFrame();
return main_frame ? main_frame->GetGlobalId() : GlobalRenderFrameHostId();
}
std::u16string GetExpectedSwitchToMessageForTargetTab(int tab) {
return l10n_util::GetStringFUTF16(
IDS_TAB_SHARING_INFOBAR_SWITCH_TO_BUTTON,
url_formatter::FormatOriginForSecurityDisplay(
GetWebContents(tab)
->GetPrimaryMainFrame()
->GetLastCommittedOrigin(),
url_formatter::SchemeDisplay::OMIT_HTTP_AND_HTTPS));
}
MockTabSharingUIViews* tab_sharing_mock_ui() { return &mock_ui; }
protected:
const bool captured_surface_control_active_;
const bool enable_tab_capture_infobar_links_;
private:
base::test::ScopedFeatureList scoped_feature_list_;
MockTabSharingUIViews mock_ui;
};
INSTANTIATE_TEST_SUITE_P(
,
TabSharingInfoBarDelegateTest,
::testing::Combine(/*captured_surface_control_active=*/::testing::Bool(),
/*enable_tab_capture_infobar_links=*/::testing::Bool()));
TEST_P(TabSharingInfoBarDelegateTest, StartSharingOnCancel) {
AddTab(browser(), GURL("about:blank"));
infobars::InfoBar* const infobar =
CreateInfobar({.shared_tab_name = kSharedTabName,
.capturer_name = kAppName,
.role = TabRole::kOtherTab,
.can_share_instead = true});
TabSharingInfoBarDelegate* delegate =
static_cast<TabSharingInfoBarDelegate*>(infobar->delegate());
EXPECT_CALL(*tab_sharing_mock_ui(), StartSharing(infobar)).Times(1);
delegate->ShareThisTabInstead();
}
TEST_P(TabSharingInfoBarDelegateTest, StopSharingOnAccept) {
AddTab(browser(), GURL("about:blank"));
TabSharingInfoBarDelegate* const delegate =
CreateDelegate({.shared_tab_name = kSharedTabName,
.capturer_name = kAppName,
.role = TabRole::kOtherTab,
.can_share_instead = true});
EXPECT_CALL(*tab_sharing_mock_ui(), StopSharing).Times(1);
delegate->Stop();
}
// Test that the infobar on the capturing tab has the correct layout:
// "|icon| Sharing this tab to |app| [Switch to captured]"
// If Captured Surface Control is active, the CSC indicator
// should also be visible.
TEST_P(TabSharingInfoBarDelegateTest, InfobarOnCapturingTab) {
AddTab(browser(), GURL(kCapturedUrl)); // index = 0.
AddTab(browser(), GURL(kCapturingUrl)); // index = 1.
TabSharingInfoBarDelegate* const delegate =
CreateDelegate({.shared_tab_name = std::u16string(),
.capturer_name = kAppName,
.role = TabRole::kCapturingTab,
.can_share_instead = false,
.tab_index = 1,
.focus_target = GlobalRenderFrameHostId{GetGlobalId(0)}});
EXPECT_STREQ(delegate->GetVectorIcon().name, enable_tab_capture_infobar_links_
? kScreenShareIcon.name
: kScreenShareOldIcon.name);
const int expected_buttons =
TabSharingInfoBarDelegate::kStop | TabSharingInfoBarDelegate::kQuickNav |
(captured_surface_control_active_
? TabSharingInfoBarDelegate::kCapturedSurfaceControlIndicator
: 0);
EXPECT_EQ(delegate->GetButtons(), expected_buttons);
EXPECT_EQ(delegate->GetButtonLabel(TabSharingInfoBarDelegate::kStop),
l10n_util::GetStringUTF16(IDS_TAB_SHARING_INFOBAR_STOP_BUTTON));
EXPECT_EQ(delegate->GetButtonLabel(TabSharingInfoBarDelegate::kQuickNav),
GetExpectedSwitchToMessageForTargetTab(0));
EXPECT_FALSE(delegate->IsCloseable());
if (captured_surface_control_active_) {
EXPECT_EQ(
delegate->GetButtonLabel(
TabSharingInfoBarDelegate::kCapturedSurfaceControlIndicator),
l10n_util::GetStringUTF16(
IDS_TAB_SHARING_INFOBAR_CAPTURED_SURFACE_CONTROL_PERMISSION_BUTTON));
}
}
// Test that the infobar on the shared tab has the correct layout:
// "|icon| Sharing this tab to |app| [Switch to capturer]"
TEST_P(TabSharingInfoBarDelegateTest, InfobarOnCapturedTab) {
AddTab(browser(), GURL("about:blank")); // Captured; index = 0.
AddTab(browser(), GURL("about:blank")); // Capturing; index = 1.
TabSharingInfoBarDelegate* const delegate =
CreateDelegate({.shared_tab_name = std::u16string(),
.capturer_name = kAppName,
.role = TabRole::kCapturedTab,
.can_share_instead = false,
.tab_index = 0,
.focus_target = GlobalRenderFrameHostId{GetGlobalId(1)}});
EXPECT_STREQ(delegate->GetVectorIcon().name, enable_tab_capture_infobar_links_
? kScreenShareIcon.name
: kScreenShareOldIcon.name);
EXPECT_EQ(delegate->GetButtons(), TabSharingInfoBarDelegate::kStop |
TabSharingInfoBarDelegate::kQuickNav);
EXPECT_EQ(delegate->GetButtonLabel(TabSharingInfoBarDelegate::kStop),
l10n_util::GetStringUTF16(IDS_TAB_SHARING_INFOBAR_STOP_BUTTON));
EXPECT_EQ(delegate->GetButtonLabel(TabSharingInfoBarDelegate::kQuickNav),
GetExpectedSwitchToMessageForTargetTab(0));
EXPECT_FALSE(delegate->IsCloseable());
}
// Test that the infobar on another not share tab has the correct layout:
// |icon| Sharing |shared_tab| to |app| [Stop sharing] [Share this tab instead]
TEST_P(TabSharingInfoBarDelegateTest, InfobarOnNotSharedTab) {
AddTab(browser(), GURL("about:blank"));
TabSharingInfoBarDelegate* const delegate =
CreateDelegate({.shared_tab_name = kSharedTabName,
.capturer_name = kAppName,
.role = TabRole::kOtherTab,
.can_share_instead = true});
EXPECT_STREQ(delegate->GetVectorIcon().name, enable_tab_capture_infobar_links_
? kScreenShareIcon.name
: kScreenShareOldIcon.name);
EXPECT_EQ(delegate->GetButtons(),
TabSharingInfoBarDelegate::kStop |
TabSharingInfoBarDelegate::kShareThisTabInstead);
EXPECT_EQ(delegate->GetButtonLabel(TabSharingInfoBarDelegate::kStop),
l10n_util::GetStringUTF16(IDS_TAB_SHARING_INFOBAR_STOP_BUTTON));
EXPECT_EQ(
delegate->GetButtonLabel(TabSharingInfoBarDelegate::kShareThisTabInstead),
l10n_util::GetStringUTF16(IDS_TAB_SHARING_INFOBAR_SHARE_BUTTON));
EXPECT_FALSE(delegate->IsCloseable());
}
// Test that when dynamic surface switching is not allowed, the infobar only
// has one button (the "Stop" button) on both shared and not shared tabs.
TEST_P(TabSharingInfoBarDelegateTest, InfobarWhenSharingNotAllowed) {
// Create infobar for shared tab.
AddTab(browser(), GURL("about:blank"));
TabSharingInfoBarDelegate* const delegate_shared_tab =
CreateDelegate({.shared_tab_name = std::u16string(),
.capturer_name = kAppName,
.role = TabRole::kCapturedTab,
.can_share_instead = false,
.tab_index = 0});
EXPECT_EQ(delegate_shared_tab->GetButtons(),
TabSharingInfoBarDelegate::kStop);
// Create infobar for another not shared tab.
AddTab(browser(), GURL("about:blank"));
TabSharingInfoBarDelegate* const delegate =
CreateDelegate({.shared_tab_name = kSharedTabName,
.capturer_name = kAppName,
.role = TabRole::kOtherTab,
.can_share_instead = false,
.tab_index = 1});
EXPECT_EQ(delegate->GetButtons(), TabSharingInfoBarDelegate::kStop);
}
// Test that if the app preferred self-capture, but the user either chose
// another tab, or chose the current tab but then switched to sharing another,
// then the infobar has the correct layout:
// |icon| Sharing |shared_tab| to |app| [Stop] [STTI] [Qick-nav]
// (Where STTI = share-this-tab-instead, and quick-nav changes the focused tab.)
TEST_P(TabSharingInfoBarDelegateTest,
InfobarOnCapturingTabIfCapturedAnotherTabButSelfCapturePreferred) {
AddTab(browser(), GURL("about:blank")); // Captured; index = 0.
AddTab(browser(), GURL("about:blank")); // Capturing; index = 1.
// The key part of this test, is that both `can_share_instead` as well as
// `focus_target` are set.
TabSharingInfoBarDelegate* const delegate =
CreateDelegate({.shared_tab_name = std::u16string(),
.capturer_name = kAppName,
.role = TabRole::kCapturedTab,
.can_share_instead = true,
.tab_index = 0,
.focus_target = GlobalRenderFrameHostId{GetGlobalId(1)}});
EXPECT_STREQ(delegate->GetVectorIcon().name, enable_tab_capture_infobar_links_
? kScreenShareIcon.name
: kScreenShareOldIcon.name);
// Correct number of buttons.
EXPECT_EQ(delegate->GetButtons(),
TabSharingInfoBarDelegate::kStop |
TabSharingInfoBarDelegate::kShareThisTabInstead |
TabSharingInfoBarDelegate::kQuickNav);
// Validate the [Stop] button.
EXPECT_EQ(delegate->GetButtonLabel(TabSharingInfoBarDelegate::kStop),
l10n_util::GetStringUTF16(IDS_TAB_SHARING_INFOBAR_STOP_BUTTON));
// Validate the [Share this tab instead] button.
EXPECT_EQ(
delegate->GetButtonLabel(TabSharingInfoBarDelegate::kShareThisTabInstead),
l10n_util::GetStringUTF16(IDS_TAB_SHARING_INFOBAR_SHARE_BUTTON));
// Validate the [Quick-nav] button.
EXPECT_EQ(delegate->GetButtonLabel(TabSharingInfoBarDelegate::kQuickNav),
GetExpectedSwitchToMessageForTargetTab(0));
EXPECT_FALSE(delegate->IsCloseable());
}
// Test that multiple infobars can be created on the same tab.
TEST_P(TabSharingInfoBarDelegateTest, MultipleInfobarsOnSameTab) {
AddTab(browser(), GURL("about:blank"));
infobars::ContentInfoBarManager* infobar_manager =
infobars::ContentInfoBarManager::FromWebContents(
browser()->tab_strip_model()->GetWebContentsAt(0));
EXPECT_EQ(infobar_manager->infobars().size(), 0u);
CreateInfobar({.shared_tab_name = kSharedTabName,
.capturer_name = kAppName,
.role = TabRole::kOtherTab,
.can_share_instead = true});
EXPECT_EQ(infobar_manager->infobars().size(), 1u);
CreateInfobar({.shared_tab_name = kSharedTabName,
.capturer_name = kAppName,
.role = TabRole::kOtherTab,
.can_share_instead = true});
EXPECT_EQ(infobar_manager->infobars().size(), 2u);
}
TEST_P(TabSharingInfoBarDelegateTest, InfobarNotDismissedOnNavigation) {
AddTab(browser(), GURL("http://foo"));
content::WebContents* web_contents =
browser()->tab_strip_model()->GetWebContentsAt(0);
infobars::ContentInfoBarManager* infobar_manager =
infobars::ContentInfoBarManager::FromWebContents(web_contents);
CreateInfobar({.shared_tab_name = kSharedTabName,
.capturer_name = kAppName,
.role = TabRole::kOtherTab,
.can_share_instead = true});
EXPECT_EQ(infobar_manager->infobars().size(), 1u);
NavigateAndCommit(web_contents, GURL("http://bar"));
EXPECT_EQ(infobar_manager->infobars().size(), 1u);
}
// Test that the infobar on another not cast tab has the correct layout:
// "|icon| Casting |tab_being_cast| to |sink| [Stop casting] [Cast this tab
// instead]"
TEST_P(TabSharingInfoBarDelegateTest, InfobarOnNotCastTab) {
AddTab(browser(), GURL("about:blank"));
Preferences preferences = {
.shared_tab_name = kSharedTabName,
.capturer_name = kSinkName,
.role = TabRole::kOtherTab,
.can_share_instead = true,
.capture_type = TabSharingInfoBarDelegate::TabShareType::CAST};
TabSharingInfoBarDelegate* const delegate = CreateDelegate(preferences);
EXPECT_STREQ(delegate->GetVectorIcon().name, enable_tab_capture_infobar_links_
? kScreenShareIcon.name
: kScreenShareOldIcon.name);
EXPECT_EQ(delegate->GetButtons(),
TabSharingInfoBarDelegate::kStop |
TabSharingInfoBarDelegate::kShareThisTabInstead);
EXPECT_EQ(delegate->GetButtonLabel(TabSharingInfoBarDelegate::kStop),
l10n_util::GetStringUTF16(IDS_TAB_CASTING_INFOBAR_STOP_BUTTON));
EXPECT_EQ(
delegate->GetButtonLabel(TabSharingInfoBarDelegate::kShareThisTabInstead),
l10n_util::GetStringUTF16(IDS_TAB_CASTING_INFOBAR_CAST_BUTTON));
EXPECT_FALSE(delegate->IsCloseable());
}
// Test that the infobar on the tab being cast has the correct layout:
// "|icon| Casting this tab to |sink| [Stop casting]"
TEST_P(TabSharingInfoBarDelegateTest, InfobarOnCastTab) {
AddTab(browser(), GURL("about:blank"));
Preferences preferences = {
.shared_tab_name = std::u16string(),
.capturer_name = kSinkName,
.role = TabRole::kCapturedTab,
.can_share_instead = false,
.capture_type = TabSharingInfoBarDelegate::TabShareType::CAST};
TabSharingInfoBarDelegate* const delegate = CreateDelegate(preferences);
EXPECT_STREQ(delegate->GetVectorIcon().name, enable_tab_capture_infobar_links_
? kScreenShareIcon.name
: kScreenShareOldIcon.name);
EXPECT_EQ(delegate->GetButtons(), TabSharingInfoBarDelegate::kStop);
EXPECT_EQ(delegate->GetButtonLabel(TabSharingInfoBarDelegate::kStop),
l10n_util::GetStringUTF16(IDS_TAB_CASTING_INFOBAR_STOP_BUTTON));
EXPECT_FALSE(delegate->IsCloseable());
}
// TODO(crbug.com/324468211): Add unit tests for CSC. (After completing the
// CL-chain and ensuring that the button is only shown after the first CSC API
// is invoked.)
|