1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437
|
// Copyright 2020 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ui/tabs/existing_window_sub_menu_model.h"
#include <memory>
#include <string>
#include <utility>
#include <vector>
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
#include "build/build_config.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_commands.h"
#include "chrome/browser/ui/browser_list.h"
#include "chrome/browser/ui/browser_tabstrip.h"
#include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/browser_window/public/browser_window_features.h"
#include "chrome/browser/ui/tabs/tab_menu_model_delegate.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/ui_test_utils.h"
#include "content/public/browser/web_contents.h"
#include "content/public/test/browser_test.h"
#include "ui/gfx/text_elider.h"
#if BUILDFLAG(IS_CHROMEOS)
#include "ash/public/cpp/autotest_desks_api.h"
#include "base/containers/span.h"
#include "chrome/browser/ui/tabs/existing_window_sub_menu_model_chromeos.h"
#endif
namespace {
class ExistingWindowSubMenuModelTest : public InProcessBrowserTest {
public:
ExistingWindowSubMenuModelTest() = default;
Profile* profile() { return browser()->profile(); }
protected:
Browser* CreateTestBrowser(bool incognito, bool popup) {
Profile* profile = incognito ? browser()->profile()->GetPrimaryOTRProfile(
/*create_if_needed=*/true)
: browser()->profile();
Browser::Type type = popup ? Browser::TYPE_POPUP : Browser::TYPE_NORMAL;
Browser* browser =
Browser::Create(Browser::CreateParams(type, profile, true));
BrowserList::SetLastActive(browser);
// Self deleting.
return browser;
}
#if BUILDFLAG(IS_CHROMEOS)
Browser* CreateTestBrowserOnWorkspace(std::string desk_index) {
Browser::CreateParams params(Browser::TYPE_NORMAL, browser()->profile(),
true);
params.initial_workspace = desk_index;
Browser* browser = Browser::Create(params);
BrowserList::SetLastActive(browser);
return browser;
}
#endif
void AddTabWithTitle(Browser* browser, std::string title) {
chrome::AddTabAt(browser, GURL("about:blank"), /*index=*/-1,
/*foreground=*/true);
content::WebContents* contents =
browser->tab_strip_model()->GetActiveWebContents();
contents->UpdateTitleForEntry(contents->GetController().GetActiveEntry(),
base::ASCIIToUTF16(title));
}
void CheckBrowserTitle(const std::u16string& title,
const std::string& expected_title,
const int expected_num_tabs) {
const std::u16string expected_title16 = base::ASCIIToUTF16(expected_title);
// Check the suffix, which should always show if there are multiple tabs.
if (expected_num_tabs > 1) {
std::ostringstream oss;
oss << " and " << expected_num_tabs - 1;
oss << ((expected_num_tabs == 2) ? " other tab" : " other tabs");
const std::u16string expected_suffix16 = base::ASCIIToUTF16(oss.str());
// Not case sensitive, since MacOS uses title case.
EXPECT_TRUE(base::EndsWith(title, expected_suffix16,
base::CompareCase::INSENSITIVE_ASCII));
}
// Either the title contains the whole tab title, or it was elided.
if (!base::StartsWith(title, expected_title16,
base::CompareCase::SENSITIVE)) {
// Check that the title before being elided matches the tab title.
std::vector<std::u16string> tokens =
SplitString(title, gfx::kEllipsisUTF16, base::KEEP_WHITESPACE,
base::SPLIT_WANT_NONEMPTY);
EXPECT_TRUE(base::StartsWith(expected_title16, tokens[0],
base::CompareCase::SENSITIVE));
// Title should always have at least a few characters.
EXPECT_GE(tokens[0].size(), 3u);
}
}
};
// Ensure that the move to existing window menu only appears when another window
// of the current profile exists.
IN_PROC_BROWSER_TEST_F(ExistingWindowSubMenuModelTest, ShouldShowSubmenu) {
// Shouldn't show menu for one window.
ASSERT_FALSE(ExistingWindowSubMenuModel::ShouldShowSubmenu(profile()));
// Add another browser, and make sure we do show the menu now.
Browser* browser_2(CreateTestBrowser(false, false));
ASSERT_TRUE(ExistingWindowSubMenuModel::ShouldShowSubmenu(profile()));
// Close the window, so the menu does not show anymore.
CloseBrowserSynchronously(browser_2);
ASSERT_FALSE(ExistingWindowSubMenuModel::ShouldShowSubmenu(profile()));
}
// Ensure we only show the menu on incognito when at least one other incognito
// window exists.
IN_PROC_BROWSER_TEST_F(ExistingWindowSubMenuModelTest,
ShouldShowSubmenuIncognito) {
// Shouldn't show menu for one window.
ASSERT_FALSE(ExistingWindowSubMenuModel::ShouldShowSubmenu(profile()));
ASSERT_FALSE(ExistingWindowSubMenuModel::ShouldShowSubmenu(
browser()->profile()->GetPrimaryOTRProfile(/*create_if_needed=*/true)));
// Create an incognito browser. We shouldn't show the menu, because we only
// move tabs between windows of the same profile.
Browser* incognito_browser_1(CreateTestBrowser(true, false));
ASSERT_FALSE(ExistingWindowSubMenuModel::ShouldShowSubmenu(profile()));
ASSERT_FALSE(ExistingWindowSubMenuModel::ShouldShowSubmenu(
incognito_browser_1->profile()->GetPrimaryOTRProfile(
/*create_if_needed=*/true)));
// Add another incognito browser, and make sure we do show the menu now.
Browser* incognito_browser_2(CreateTestBrowser(true, false));
ASSERT_FALSE(ExistingWindowSubMenuModel::ShouldShowSubmenu(profile()));
ASSERT_TRUE(ExistingWindowSubMenuModel::ShouldShowSubmenu(
incognito_browser_2->profile()->GetPrimaryOTRProfile(
/*create_if_needed=*/true)));
}
// Ensure we don't show the menu on a popup window.
IN_PROC_BROWSER_TEST_F(ExistingWindowSubMenuModelTest, ShouldShowSubmenuPopup) {
// Popup windows aren't counted when determining whether to show the menu.
Browser* browser_2(CreateTestBrowser(false, true));
ASSERT_FALSE(
ExistingWindowSubMenuModel::ShouldShowSubmenu(browser_2->profile()));
// Add another tabbed window, make sure the menu shows.
Browser* browser_3(CreateTestBrowser(false, false));
ASSERT_TRUE(
ExistingWindowSubMenuModel::ShouldShowSubmenu(browser_3->profile()));
}
// Validate that windows appear in MRU order and with the expected labels.
IN_PROC_BROWSER_TEST_F(ExistingWindowSubMenuModelTest, BuildSubmenuOrder) {
// Add some browsers.
BrowserList::SetLastActive(browser());
Browser* browser_2(CreateTestBrowser(false, false));
Browser* browser_3(CreateTestBrowser(false, false));
Browser* browser_4(CreateTestBrowser(false, false));
// Add tabs.
constexpr char kLongTabTitleExample[] =
"Lorem ipsum dolor sit amet, consectetuer adipiscing elit. Maecenas "
"porttitor congue massa. Fusce posuere, magna sed pulvinar ultricies,"
"purus lectus malesuada libero, sit amet commodo magna eros quis urna.";
AddTabWithTitle(browser(), "Browser 1");
AddTabWithTitle(browser_2, kLongTabTitleExample);
AddTabWithTitle(browser_3, "Browser 3 Tab 1");
AddTabWithTitle(browser_3, "Browser 3 Tab 2");
AddTabWithTitle(browser_4, "Browser 4 Tab 1");
AddTabWithTitle(browser_4, "Browser 4 Tab 2");
AddTabWithTitle(browser_4, kLongTabTitleExample);
// Create menu from browser 1.
auto menu1 = ExistingWindowSubMenuModel::Create(
nullptr, browser()->GetFeatures().tab_menu_model_delegate(),
browser()->tab_strip_model(), 0);
ASSERT_EQ(5u, menu1->GetItemCount());
CheckBrowserTitle(menu1->GetLabelAt(2), kLongTabTitleExample, 3);
CheckBrowserTitle(menu1->GetLabelAt(3), "Browser 3 Tab 2", 2);
CheckBrowserTitle(menu1->GetLabelAt(4), kLongTabTitleExample, 1);
// Create menu from browser 2.
auto menu2 = ExistingWindowSubMenuModel::Create(
nullptr, browser_2->GetFeatures().tab_menu_model_delegate(),
browser_2->tab_strip_model(), 0);
ASSERT_EQ(5u, menu2->GetItemCount());
CheckBrowserTitle(menu2->GetLabelAt(2), kLongTabTitleExample, 3);
CheckBrowserTitle(menu2->GetLabelAt(3), "Browser 3 Tab 2", 2);
CheckBrowserTitle(menu2->GetLabelAt(4), "Browser 1", 1);
// Rearrange the MRU and re-test.
BrowserList::SetLastActive(browser());
BrowserList::SetLastActive(browser_2);
auto menu3 = ExistingWindowSubMenuModel::Create(
nullptr, browser_3->GetFeatures().tab_menu_model_delegate(),
browser_3->tab_strip_model(), 0);
ASSERT_EQ(5u, menu3->GetItemCount());
CheckBrowserTitle(menu3->GetLabelAt(2), kLongTabTitleExample, 1);
CheckBrowserTitle(menu3->GetLabelAt(3), "Browser 1", 1);
CheckBrowserTitle(menu3->GetLabelAt(4), kLongTabTitleExample, 3);
// Clean up.
CloseBrowserSynchronously(browser_2);
CloseBrowserSynchronously(browser_3);
CloseBrowserSynchronously(browser_4);
}
// Ensure that normal browsers and incognito browsers have their own lists.
IN_PROC_BROWSER_TEST_F(ExistingWindowSubMenuModelTest, BuildSubmenuIncognito) {
// Add some browsers.
BrowserList::SetLastActive(browser());
Browser* browser_2(CreateTestBrowser(false, false));
Browser* browser_3(CreateTestBrowser(false, false));
Browser* incognito_browser_1(CreateTestBrowser(true, false));
Browser* incognito_browser_2(CreateTestBrowser(true, false));
AddTabWithTitle(browser(), "Browser 1");
AddTabWithTitle(browser_2, "Browser 2");
AddTabWithTitle(browser_3, "Browser 3");
AddTabWithTitle(incognito_browser_1, "Incognito Browser 1");
AddTabWithTitle(incognito_browser_2, "Incognito Browser 2");
const std::u16string kBrowser2ExpectedTitle = u"Browser 2";
const std::u16string kBrowser3ExpectedTitle = u"Browser 3";
const std::u16string kIncognitoBrowser2ExpectedTitle = u"Incognito Browser 2";
// Test that a non-incognito browser only shows non-incognito windows.
auto menu = ExistingWindowSubMenuModel::Create(
nullptr, browser()->GetFeatures().tab_menu_model_delegate(),
browser()->tab_strip_model(), 0);
ASSERT_EQ(4u, menu->GetItemCount());
ASSERT_EQ(kBrowser3ExpectedTitle, menu->GetLabelAt(2));
ASSERT_EQ(kBrowser2ExpectedTitle, menu->GetLabelAt(3));
// Test that a incognito browser only shows incognito windows.
auto menu_incognito = ExistingWindowSubMenuModel::Create(
nullptr, incognito_browser_1->GetFeatures().tab_menu_model_delegate(),
incognito_browser_1->tab_strip_model(), 0);
ASSERT_EQ(3u, menu_incognito->GetItemCount());
ASSERT_EQ(kIncognitoBrowser2ExpectedTitle, menu_incognito->GetLabelAt(2));
// Clean up.
CloseBrowserSynchronously(browser_2);
CloseBrowserSynchronously(browser_3);
CloseBrowserSynchronously(incognito_browser_1);
CloseBrowserSynchronously(incognito_browser_2);
}
// Ensure that popups don't appear in the list of existing windows.
IN_PROC_BROWSER_TEST_F(ExistingWindowSubMenuModelTest, BuildSubmenuPopups) {
// Add some browsers.
BrowserList::SetLastActive(browser());
Browser* browser_2(CreateTestBrowser(false, false));
Browser* browser_3(CreateTestBrowser(false, false));
Browser* popup_browser_1(CreateTestBrowser(false, true));
Browser* popup_browser_2(CreateTestBrowser(false, true));
AddTabWithTitle(browser(), "Browser 1");
AddTabWithTitle(browser_2, "Browser 2");
AddTabWithTitle(browser_3, "Browser 3");
const std::u16string kBrowser2ExpectedTitle = u"Browser 2";
const std::u16string kBrowser3ExpectedTitle = u"Browser 3";
// Test that popups do not show.
auto menu = ExistingWindowSubMenuModel::Create(
nullptr, browser()->GetFeatures().tab_menu_model_delegate(),
browser()->tab_strip_model(), 0);
ASSERT_EQ(4u, menu->GetItemCount());
ASSERT_EQ(kBrowser3ExpectedTitle, menu->GetLabelAt(2));
ASSERT_EQ(kBrowser2ExpectedTitle, menu->GetLabelAt(3));
// Clean up.
CloseBrowserSynchronously(browser_2);
CloseBrowserSynchronously(browser_3);
CloseBrowserSynchronously(popup_browser_1);
CloseBrowserSynchronously(popup_browser_2);
}
#if BUILDFLAG(IS_CHROMEOS)
// Ensure that when there are multiple desks the browsers are grouped by which
// desk they belong to.
IN_PROC_BROWSER_TEST_F(ExistingWindowSubMenuModelTest,
BuildSubmenuGroupedByDesks) {
const std::string kBrowser2TabTitle("Browser 2 Tab 1");
const std::string kBrowser3TabTitle("Browser 3 Tab 1");
const std::string kBrowser4TabTitle("Browser 4 Tab 1");
const std::string kBrowser5TabTitle("Browser 5 Tab 1");
const std::string kBrowser6TabTitle("Browser 6 Tab 1");
const std::string kBrowser7TabTitle("Browser 7 Tab 1");
// Create 4 desks so we have 5 in total.
ash::AutotestDesksApi().CreateNewDesk();
ash::AutotestDesksApi().CreateNewDesk();
ash::AutotestDesksApi().CreateNewDesk();
ash::AutotestDesksApi().CreateNewDesk();
// Add some browsers and put them in each desk.
BrowserList::SetLastActive(browser());
Browser* browser_2(CreateTestBrowserOnWorkspace("0"));
Browser* browser_3(CreateTestBrowserOnWorkspace("1"));
Browser* browser_4(CreateTestBrowserOnWorkspace("1"));
Browser* browser_5(CreateTestBrowserOnWorkspace("2"));
Browser* browser_6(CreateTestBrowserOnWorkspace("2"));
Browser* browser_7(CreateTestBrowserOnWorkspace("3"));
// Add tabs.
AddTabWithTitle(browser_2, kBrowser2TabTitle);
AddTabWithTitle(browser_3, kBrowser3TabTitle);
AddTabWithTitle(browser_4, kBrowser4TabTitle);
AddTabWithTitle(browser_5, kBrowser5TabTitle);
AddTabWithTitle(browser_6, kBrowser6TabTitle);
AddTabWithTitle(browser_7, kBrowser7TabTitle);
// Scramble their MRU order by activating them. The MRU order should be:
// [b7, b5, b4, b2, b3, b6] (left-most is MRU).
BrowserList::SetLastActive(browser_6);
BrowserList::SetLastActive(browser_3);
BrowserList::SetLastActive(browser_2);
BrowserList::SetLastActive(browser_4);
BrowserList::SetLastActive(browser_5);
BrowserList::SetLastActive(browser_7);
const std::initializer_list<Browser* const> expected_mru_order{
browser_7, browser_5, browser_4, browser_2, browser_3, browser_6};
// `initializer_list` (instead of `array`) is necessary to construct a dynamic
// span which can be compared to `vector`.
const auto mru_ordered_windows = browser()
->GetFeatures()
.tab_menu_model_delegate()
->GetOtherBrowserWindows(
/*is_app=*/false);
ASSERT_EQ(6u, mru_ordered_windows.size());
ASSERT_EQ(mru_ordered_windows, base::span{expected_mru_order});
// Create the menu from browser 1. The labels should be grouped by desk and
// respect MRU order within each desk grouping. Also a label shouldn't be made
// for the 5th desk since no browsers are in it.
auto menu1 = ExistingWindowSubMenuModel::Create(
nullptr, browser()->GetFeatures().tab_menu_model_delegate(),
browser()->tab_strip_model(), 0);
ASSERT_EQ(15u, menu1->GetItemCount());
EXPECT_EQ(u"Desk 1 (Current)", menu1->GetLabelAt(2));
CheckBrowserTitle(menu1->GetLabelAt(3), kBrowser2TabTitle, 1);
EXPECT_EQ(ui::SPACING_SEPARATOR, menu1->GetSeparatorTypeAt(4));
EXPECT_EQ(u"Desk 2", menu1->GetLabelAt(5));
CheckBrowserTitle(menu1->GetLabelAt(6), kBrowser4TabTitle, 1);
CheckBrowserTitle(menu1->GetLabelAt(7), kBrowser3TabTitle, 1);
EXPECT_EQ(ui::SPACING_SEPARATOR, menu1->GetSeparatorTypeAt(8));
EXPECT_EQ(u"Desk 3", menu1->GetLabelAt(9));
CheckBrowserTitle(menu1->GetLabelAt(10), kBrowser5TabTitle, 1);
CheckBrowserTitle(menu1->GetLabelAt(11), kBrowser6TabTitle, 1);
EXPECT_EQ(ui::SPACING_SEPARATOR, menu1->GetSeparatorTypeAt(12));
EXPECT_EQ(u"Desk 4", menu1->GetLabelAt(13));
CheckBrowserTitle(menu1->GetLabelAt(14), kBrowser7TabTitle, 1);
// Clean up.
CloseBrowserSynchronously(browser_2);
CloseBrowserSynchronously(browser_3);
CloseBrowserSynchronously(browser_4);
CloseBrowserSynchronously(browser_5);
CloseBrowserSynchronously(browser_6);
CloseBrowserSynchronously(browser_7);
}
// Tests out that executing the commands in the submenu grouped by desks work
// properly.
IN_PROC_BROWSER_TEST_F(ExistingWindowSubMenuModelTest,
EnsureGroupedByDesksCommands) {
// Create 2 desks so we have 3 in total.
ash::AutotestDesksApi().CreateNewDesk();
ash::AutotestDesksApi().CreateNewDesk();
// Add some browsers and put them in desks.
Browser* browser_2(CreateTestBrowserOnWorkspace("0"));
Browser* browser_3(CreateTestBrowserOnWorkspace("1"));
Browser* browser_4(CreateTestBrowserOnWorkspace("1"));
Browser* browser_5(CreateTestBrowserOnWorkspace("2"));
// Scramble the MRU order by activating them. The MRU order should be:
// [b4, b2, b3, b5] (left-most is MRU).
BrowserList::SetLastActive(browser_5);
BrowserList::SetLastActive(browser_3);
BrowserList::SetLastActive(browser_2);
BrowserList::SetLastActive(browser_4);
const std::initializer_list<Browser* const> expected_mru_order{
browser_4, browser_2, browser_3, browser_5};
// `initializer_list` (instead of `array`) is necessary to construct a dynamic
// span which can be compared to `vector`.
const auto mru_ordered_windows = browser()
->GetFeatures()
.tab_menu_model_delegate()
->GetOtherBrowserWindows(
/*is_app=*/false);
ASSERT_EQ(4u, mru_ordered_windows.size());
ASSERT_EQ(mru_ordered_windows, base::span{expected_mru_order});
// Create the menu from browser 1 and ensure that the command indexes properly
// map to their browser indices.
auto menu1 = ExistingWindowSubMenuModel::Create(
nullptr, browser()->GetFeatures().tab_menu_model_delegate(),
browser()->tab_strip_model(), 0);
const auto& command_id_to_target_index =
static_cast<chromeos::ExistingWindowSubMenuModelChromeOS*>(menu1.get())
->command_id_to_target_index_for_testing();
// A vector of the expected mappings. The first element of each pair is the
// commdand id. The second element of each pair is the browser index.
const std::vector<std::pair<int, int>> kExpectedMappings{
{1002, 1}, {1003, 0}, {1004, 2}, {1005, 3}};
for (const auto& pair : kExpectedMappings) {
EXPECT_EQ(pair.second,
static_cast<int>(command_id_to_target_index.at(pair.first)));
}
// Clean up.
CloseBrowserSynchronously(browser_2);
CloseBrowserSynchronously(browser_3);
CloseBrowserSynchronously(browser_4);
CloseBrowserSynchronously(browser_5);
}
#endif
} // namespace
|