1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667
|
// Copyright 2012 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ui/toolbar/app_menu_model.h"
#include <algorithm>
#include <vector>
#include "base/command_line.h"
#include "base/functional/callback.h"
#include "base/memory/ptr_util.h"
#include "base/test/scoped_feature_list.h"
#include "build/branding_buildflags.h"
#include "build/build_config.h"
#include "chrome/app/chrome_command_ids.h"
#include "chrome/browser/defaults.h"
#include "chrome/browser/password_manager/password_manager_test_util.h"
#include "chrome/browser/prefs/browser_prefs.h"
#include "chrome/browser/signin/identity_manager_factory.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/global_error/global_error.h"
#include "chrome/browser/ui/global_error/global_error_service.h"
#include "chrome/browser/ui/global_error/global_error_service_factory.h"
#include "chrome/browser/ui/hats/hats_service_factory.h"
#include "chrome/browser/ui/hats/mock_hats_service.h"
#include "chrome/browser/ui/safety_hub/menu_notification_service_factory.h"
#include "chrome/browser/ui/safety_hub/password_status_check_service.h"
#include "chrome/browser/ui/safety_hub/password_status_check_service_factory.h"
#include "chrome/browser/ui/safety_hub/safety_hub_test_util.h"
#include "chrome/browser/ui/startup/default_browser_prompt/default_browser_prompt_manager.h"
#include "chrome/browser/ui/tabs/organization/tab_organization_utils.h"
#include "chrome/browser/ui/tabs/recent_tabs_sub_menu_model.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/browser/ui/toolbar/app_menu_icon_controller.h"
#include "chrome/browser/ui/ui_features.h"
#include "chrome/browser/upgrade_detector/upgrade_detector.h"
#include "chrome/common/chrome_features.h"
#include "chrome/grit/generated_resources.h"
#include "chrome/test/base/browser_with_test_window_test.h"
#include "chrome/test/base/menu_model_test.h"
#include "chrome/test/base/testing_browser_process.h"
#include "chrome/test/base/testing_profile.h"
#include "components/optimization_guide/core/model_execution/model_execution_features.h"
#include "components/optimization_guide/core/optimization_guide_features.h"
#include "components/password_manager/core/browser/password_store/test_password_store.h"
#include "components/signin/public/base/consent_level.h"
#include "components/signin/public/identity_manager/identity_test_utils.h"
#include "components/sync_preferences/testing_pref_service_syncable.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/base/ui_base_features.h"
#include "ui/gfx/color_palette.h"
#if BUILDFLAG(IS_CHROMEOS)
#include "chrome/browser/policy/system_features_disable_list_policy_handler.h"
#include "components/policy/core/common/policy_pref_names.h"
#endif // BUILDFLAG(IS_CHROMEOS)
using ::testing::_;
namespace {
// Error class has a menu item.
class MenuError : public GlobalError {
public:
explicit MenuError(int command_id) : command_id_(command_id) {}
MenuError(const MenuError&) = delete;
MenuError& operator=(const MenuError&) = delete;
int execute_count() { return execute_count_; }
bool HasMenuItem() override { return true; }
int MenuItemCommandID() override { return command_id_; }
std::u16string MenuItemLabel() override { return std::u16string(); }
void ExecuteMenuItem(Browser* browser) override { execute_count_++; }
bool HasBubbleView() override { return false; }
bool HasShownBubbleView() override { return false; }
void ShowBubbleView(Browser* browser) override { ADD_FAILURE(); }
GlobalErrorBubbleViewBase* GetBubbleView() override { return nullptr; }
private:
int command_id_;
int execute_count_ = 0;
};
class FakeIconDelegate : public AppMenuIconController::Delegate {
public:
FakeIconDelegate() = default;
// AppMenuIconController::Delegate:
void UpdateTypeAndSeverity(
AppMenuIconController::TypeAndSeverity type_and_severity) override {}
};
} // namespace
class AppMenuModelTest : public BrowserWithTestWindowTest,
public ui::AcceleratorProvider {
public:
AppMenuModelTest() = default;
void SetUp() override {
BrowserWithTestWindowTest::SetUp();
safety_hub_test_util::CreateRevokedPermissionsService(browser()->profile());
safety_hub_test_util::CreateNotificationPermissionsReviewService(
browser()->profile());
}
AppMenuModelTest(const AppMenuModelTest&) = delete;
AppMenuModelTest& operator=(const AppMenuModelTest&) = delete;
~AppMenuModelTest() override = default;
// Don't handle accelerators.
bool GetAcceleratorForCommandId(int command_id,
ui::Accelerator* accelerator) const override {
return false;
}
protected:
base::test::ScopedFeatureList feature_list_;
};
// Copies parts of MenuModelTest::Delegate and combines them with the
// AppMenuModel since AppMenuModel is now a SimpleMenuModel::Delegate and
// not derived from SimpleMenuModel.
class TestAppMenuModel : public AppMenuModel {
public:
TestAppMenuModel(ui::AcceleratorProvider* provider,
Browser* browser,
AppMenuIconController* app_menu_icon_controller)
: AppMenuModel(provider, browser, app_menu_icon_controller) {}
// Testing overrides to ui::SimpleMenuModel::Delegate:
bool IsCommandIdChecked(int command_id) const override {
bool val = AppMenuModel::IsCommandIdChecked(command_id);
if (val) {
checked_count_++;
}
return val;
}
bool IsCommandIdEnabled(int command_id) const override {
++enable_count_;
return true;
}
void ExecuteCommand(int command_id, int event_flags) override {
++execute_count_;
}
int execute_count_ = 0;
mutable int checked_count_ = 0;
mutable int enable_count_ = 0;
};
class TestLogMetricsAppMenuModel : public AppMenuModel {
public:
TestLogMetricsAppMenuModel(ui::AcceleratorProvider* provider,
Browser* browser)
: AppMenuModel(provider, browser) {}
void LogMenuAction(AppMenuAction action_id) override { log_metrics_count_++; }
int log_metrics_count_ = 0;
};
TEST_F(AppMenuModelTest, Basics) {
// Simulate that an update is available to ensure that the menu includes the
// upgrade item for platforms that support it.
UpgradeDetector* detector = UpgradeDetector::GetInstance();
detector->set_upgrade_notification_stage(
UpgradeDetector::UPGRADE_ANNOYANCE_LOW);
detector->NotifyUpgrade();
EXPECT_TRUE(detector->notify_upgrade());
FakeIconDelegate fake_delegate;
AppMenuIconController app_menu_icon_controller(browser()->profile(),
&fake_delegate);
TestAppMenuModel model(this, browser(), &app_menu_icon_controller);
model.Init();
size_t item_count = model.GetItemCount();
// Verify it has items. The number varies by platform, so we don't check
// the exact number.
EXPECT_GT(item_count, 10u);
// Verify that the upgrade item is visible if supported.
EXPECT_EQ(browser_defaults::kShowUpgradeMenuItem,
model.GetIndexOfCommandId(IDC_UPGRADE_DIALOG).has_value());
// Execute a couple of the items and make sure it gets back to our delegate.
// We can't use CountEnabledExecutable() here because the encoding menu's
// delegate is internal, it doesn't use the one we pass in.
// Note: the second item in the menu may be a separator if the browser
// supports showing upgrade status in the app menu.
size_t item_index = 1;
if (model.GetTypeAt(item_index) == ui::MenuModel::TYPE_SEPARATOR) {
++item_index;
}
model.ActivatedAt(item_index);
EXPECT_TRUE(model.IsEnabledAt(item_index));
// Make sure to use the index that is not separator in all configurations.
model.ActivatedAt(item_count - 1);
EXPECT_TRUE(model.IsEnabledAt(item_count - 1));
EXPECT_EQ(model.execute_count_, 2);
EXPECT_EQ(model.enable_count_, 2);
model.execute_count_ = 0;
model.enable_count_ = 0;
// Choose something from the bookmark submenu and make sure it makes it back
// to the delegate as well.
size_t bookmarks_model_index =
model.GetIndexOfCommandId(IDC_BOOKMARKS_MENU).value();
EXPECT_GT(bookmarks_model_index, 0u);
ui::MenuModel* bookmarks_model =
model.GetSubmenuModelAt(bookmarks_model_index);
EXPECT_TRUE(bookmarks_model);
// The bookmarks model may be empty until we tell it we're going to show it.
bookmarks_model->MenuWillShow();
EXPECT_GT(bookmarks_model->GetItemCount(), 1u);
// Bookmark manager item.
bookmarks_model->ActivatedAt(4);
EXPECT_TRUE(bookmarks_model->IsEnabledAt(4));
EXPECT_EQ(model.execute_count_, 1);
EXPECT_EQ(model.enable_count_, 1);
}
// Tests global error menu items in the app menu.
TEST_F(AppMenuModelTest, GlobalError) {
// Make sure services required for tests are initialized.
GlobalErrorService* service =
GlobalErrorServiceFactory::GetForProfile(browser()->profile());
const int command1 = 1234567;
MenuError* error1 = new MenuError(command1);
service->AddGlobalError(base::WrapUnique(error1));
const int command2 = 1234568;
MenuError* error2 = new MenuError(command2);
service->AddGlobalError(base::WrapUnique(error2));
AppMenuModel model(this, browser());
model.Init();
std::optional<size_t> index1 = model.GetIndexOfCommandId(command1);
ASSERT_TRUE(index1.has_value());
std::optional<size_t> index2 = model.GetIndexOfCommandId(command2);
ASSERT_TRUE(index2.has_value());
EXPECT_TRUE(model.IsEnabledAt(index1.value()));
EXPECT_EQ(0, error1->execute_count());
model.ActivatedAt(index1.value());
EXPECT_EQ(1, error1->execute_count());
EXPECT_TRUE(model.IsEnabledAt(index2.value()));
EXPECT_EQ(0, error2->execute_count());
model.ActivatedAt(index2.value());
EXPECT_EQ(1, error1->execute_count());
}
#if BUILDFLAG(IS_WIN) || BUILDFLAG(IS_MAC) || BUILDFLAG(IS_LINUX)
TEST_F(AppMenuModelTest, DefaultBrowserPrompt) {
DefaultBrowserPromptManager::GetInstance()->MaybeShowPrompt();
FakeIconDelegate fake_delegate;
AppMenuIconController app_menu_icon_controller(browser()->profile(),
&fake_delegate);
TestAppMenuModel model(this, browser(), &app_menu_icon_controller);
model.Init();
EXPECT_TRUE(
model.GetIndexOfCommandId(IDC_SET_BROWSER_AS_DEFAULT).has_value());
size_t default_prompt_index =
model.GetIndexOfCommandId(IDC_SET_BROWSER_AS_DEFAULT).value();
EXPECT_TRUE(model.IsEnabledAt(default_prompt_index));
}
#endif // BUILDFLAG(IS_WIN) || BUILDFLAG(IS_MAC) || BUILDFLAG(IS_LINUX)
TEST_F(AppMenuModelTest, PerformanceItem) {
AppMenuModel model(this, browser());
model.Init();
ToolsMenuModel toolModel(&model, browser());
ASSERT_TRUE(toolModel.GetIndexOfCommandId(IDC_PERFORMANCE));
size_t performance_index =
toolModel.GetIndexOfCommandId(IDC_PERFORMANCE).value();
EXPECT_TRUE(toolModel.IsEnabledAt(performance_index));
}
TEST_F(AppMenuModelTest, CustomizeChromeItem) {
AppMenuModel model(this, browser());
model.Init();
ToolsMenuModel tool_model(&model, browser());
ASSERT_TRUE(
tool_model.GetIndexOfCommandId(IDC_SHOW_CUSTOMIZE_CHROME_SIDE_PANEL));
size_t customize_chrome_index =
tool_model.GetIndexOfCommandId(IDC_SHOW_CUSTOMIZE_CHROME_SIDE_PANEL)
.value();
EXPECT_TRUE(tool_model.IsEnabledAt(customize_chrome_index));
}
TEST_F(AppMenuModelTest, CustomizeChromeLogMetrics) {
TestLogMetricsAppMenuModel model(this, browser());
model.Init();
model.ExecuteCommand(IDC_SHOW_CUSTOMIZE_CHROME_SIDE_PANEL, 0);
EXPECT_EQ(1, model.log_metrics_count_);
}
TEST_F(AppMenuModelTest, OrganizeTabsItem) {
feature_list_.Reset();
feature_list_.InitWithFeatures(
{features::kTabOrganization, features::kTabOrganizationAppMenuItem}, {});
TabOrganizationUtils::GetInstance()->SetIgnoreOptGuideForTesting(true);
AppMenuModel model(this, browser());
model.Init();
ToolsMenuModel toolModel(&model, browser());
size_t organize_tabs_index =
toolModel.GetIndexOfCommandId(IDC_ORGANIZE_TABS).value();
EXPECT_TRUE(toolModel.IsEnabledAt(organize_tabs_index));
}
TEST_F(AppMenuModelTest, DeclutterTabsItem) {
feature_list_.Reset();
feature_list_.InitAndEnableFeature(features::kTabstripDeclutter);
TabOrganizationUtils::GetInstance()->SetIgnoreOptGuideForTesting(true);
TestLogMetricsAppMenuModel model(this, browser());
model.Init();
ToolsMenuModel toolModel(&model, browser());
size_t declutter_tabs_index =
toolModel.GetIndexOfCommandId(IDC_DECLUTTER_TABS).value();
EXPECT_TRUE(toolModel.IsEnabledAt(declutter_tabs_index));
model.ExecuteCommand(IDC_DECLUTTER_TABS, 0);
EXPECT_EQ(1, model.log_metrics_count_);
}
#if BUILDFLAG(ENABLE_GLIC)
TEST_F(AppMenuModelTest, GlicItem) {
feature_list_.Reset();
feature_list_.InitWithFeatures(
{features::kGlic, features::kTabstripComboButton, features::kGlicRollout},
{});
TestLogMetricsAppMenuModel model(this, browser());
model.Init();
model.ExecuteCommand(IDC_OPEN_GLIC, 0);
EXPECT_EQ(1, model.log_metrics_count_);
}
#endif
TEST_F(AppMenuModelTest, ModelHasIcons) {
// Skip the items that are either not supposed to have an icon, or are not
// ready to be tested. Remove items once they're ready for testing.
static const std::vector<int> skip_commands = {
IDC_RECENT_TABS_NO_DEVICE_TABS, IDC_ABOUT,
RecentTabsSubMenuModel::GetDisabledRecentlyClosedHeaderCommandId(),
IDC_EXTENSIONS_SUBMENU_VISIT_CHROME_WEB_STORE, IDC_TAKE_SCREENSHOT};
AppMenuModel model(this, browser());
model.Init();
const auto check_for_icons = [](std::u16string menu_name,
ui::MenuModel* model) -> void {
auto check_for_icons_impl = [](std::u16string menu_name,
ui::MenuModel* model,
auto& check_for_icons_ref) -> void {
// Except where noted by the above vector, all menu items in CR2023 must
// have icons.
for (size_t i = 0; i < model->GetItemCount(); ++i) {
auto menu_type = model->GetTypeAt(i);
if (menu_type != ui::MenuModel::TYPE_ACTIONABLE_SUBMENU &&
menu_type != ui::MenuModel::TYPE_SUBMENU &&
std::find(skip_commands.cbegin(), skip_commands.cend(),
model->GetCommandIdAt(i)) != skip_commands.cend()) {
continue;
}
if (menu_type != ui::MenuModel::TYPE_SEPARATOR &&
menu_type != ui::MenuModel::TYPE_TITLE) {
EXPECT_TRUE(!model->GetIconAt(i).IsEmpty())
<< "\"" << menu_name << "\" menu item \"" << model->GetLabelAt(i)
<< "\" is missing the icon!";
}
if ((menu_type == ui::MenuModel::TYPE_SUBMENU ||
menu_type == ui::MenuModel::TYPE_ACTIONABLE_SUBMENU) &&
std::find(skip_commands.cbegin(), skip_commands.cend(),
model->GetCommandIdAt(i)) == skip_commands.cend()) {
check_for_icons_ref(model->GetLabelAt(i), model->GetSubmenuModelAt(i),
check_for_icons_ref);
}
}
};
check_for_icons_impl(menu_name, model, check_for_icons_impl);
};
check_for_icons(u"<Root Menu>", &model);
}
class ExtensionsMenuModelTest : public AppMenuModelTest,
public testing::WithParamInterface<bool> {
public:
ExtensionsMenuModelTest() = default;
~ExtensionsMenuModelTest() override = default;
void SetUp() override {
if (GetParam()) {
scoped_feature_list_.InitAndEnableFeature(
features::kExtensionsCollapseMainMenu);
} else {
scoped_feature_list_.InitAndDisableFeature(
features::kExtensionsCollapseMainMenu);
}
AppMenuModelTest::SetUp();
}
private:
base::test::ScopedFeatureList scoped_feature_list_;
};
INSTANTIATE_TEST_SUITE_P(,
ExtensionsMenuModelTest,
testing::Bool(),
[](const testing::TestParamInfo<bool>& param) {
return param.param ? "Collapse" : "DoNotCollapse";
});
// Tests that extensions sub menu (when enabled) generates the correct elements
// or does not generate its elements when disabled.
TEST_P(ExtensionsMenuModelTest, ExtensionsMenu) {
AppMenuModel model(this, browser());
model.Init();
if (GetParam()) {
const auto index = model.GetIndexOfCommandId(IDC_FIND_EXTENSIONS);
ASSERT_TRUE(index.has_value());
EXPECT_EQ(nullptr, model.GetSubmenuModelAt(*index));
} else {
ASSERT_TRUE(model.GetIndexOfCommandId(IDC_EXTENSIONS_SUBMENU));
ui::MenuModel* extensions_submenu = model.GetSubmenuModelAt(
model.GetIndexOfCommandId(IDC_EXTENSIONS_SUBMENU).value());
ASSERT_NE(extensions_submenu, nullptr);
ASSERT_EQ(2ul, extensions_submenu->GetItemCount());
EXPECT_EQ(IDC_EXTENSIONS_SUBMENU_MANAGE_EXTENSIONS,
extensions_submenu->GetCommandIdAt(0));
EXPECT_EQ(IDC_EXTENSIONS_SUBMENU_VISIT_CHROME_WEB_STORE,
extensions_submenu->GetCommandIdAt(1));
}
}
// Profile row does not show on ChromeOS.
#if !BUILDFLAG(IS_CHROMEOS)
class TestAppMenuModelMetricsTest : public AppMenuModelTest,
public testing::WithParamInterface<int> {
public:
TestAppMenuModelMetricsTest() = default;
};
TEST_P(TestAppMenuModelMetricsTest, LogProfileMenuMetrics) {
int command_id = GetParam();
TestLogMetricsAppMenuModel model(this, browser());
model.Init();
model.ExecuteCommand(command_id, 0);
EXPECT_EQ(1, model.log_metrics_count_);
}
INSTANTIATE_TEST_SUITE_P(
All,
TestAppMenuModelMetricsTest,
testing::Values(IDC_MANAGE_GOOGLE_ACCOUNT,
IDC_CLOSE_PROFILE,
IDC_CUSTOMIZE_CHROME,
IDC_SHOW_SIGNIN_WHEN_PAUSED,
IDC_SHOW_SYNC_SETTINGS,
IDC_TURN_ON_SYNC,
IDC_OPEN_GUEST_PROFILE,
IDC_ADD_NEW_PROFILE,
IDC_MANAGE_CHROME_PROFILES,
IDC_READING_LIST_MENU_ADD_TAB,
IDC_READING_LIST_MENU_SHOW_UI,
IDC_SHOW_PASSWORD_MANAGER,
IDC_SHOW_PAYMENT_METHODS,
IDC_SHOW_ADDRESSES,
AppMenuModel::kMinOtherProfileCommandId));
TEST_F(AppMenuModelTest, ProfileSyncOnTest) {
signin::IdentityManager* identity_manager =
IdentityManagerFactory::GetForProfile(browser()->profile());
signin::MakePrimaryAccountAvailable(identity_manager, "user@example.com",
signin::ConsentLevel::kSync);
signin::SetRefreshTokenForPrimaryAccount(identity_manager);
AppMenuModel model(this, browser());
model.Init();
const size_t profile_menu_index =
model.GetIndexOfCommandId(IDC_PROFILE_MENU_IN_APP_MENU).value();
ui::SimpleMenuModel* profile_menu = static_cast<ui::SimpleMenuModel*>(
model.GetSubmenuModelAt(profile_menu_index));
const size_t sync_settings_index =
profile_menu->GetIndexOfCommandId(IDC_SHOW_SYNC_SETTINGS).value();
EXPECT_TRUE(profile_menu->IsEnabledAt(sync_settings_index));
}
#endif
#if BUILDFLAG(IS_CHROMEOS)
// Tests settings menu items is disabled in the app menu when
// kSystemFeaturesDisableList is set.
TEST_F(AppMenuModelTest, DisableSettingsItem) {
AppMenuModel model(this, browser());
model.Init();
const size_t options_index = model.GetIndexOfCommandId(IDC_OPTIONS).value();
EXPECT_TRUE(model.IsEnabledAt(options_index));
#if BUILDFLAG(GOOGLE_CHROME_BRANDING)
const size_t help_menu_index =
model.GetIndexOfCommandId(IDC_HELP_MENU).value();
ui::SimpleMenuModel* help_menu = static_cast<ui::SimpleMenuModel*>(
model.GetSubmenuModelAt(help_menu_index));
const size_t about_index = help_menu->GetIndexOfCommandId(IDC_ABOUT).value();
EXPECT_TRUE(help_menu->IsEnabledAt(about_index));
#else
const size_t about_index = model.GetIndexOfCommandId(IDC_ABOUT).value();
EXPECT_TRUE(model.IsEnabledAt(about_index));
#endif // BUILDFLAG(GOOGLE_CHROME_BRANDING)
{
ScopedListPrefUpdate update(
TestingBrowserProcess::GetGlobal()->local_state(),
policy::policy_prefs::kSystemFeaturesDisableList);
update->Append(static_cast<int>(policy::SystemFeature::kBrowserSettings));
}
EXPECT_FALSE(model.IsEnabledAt(options_index));
#if BUILDFLAG(GOOGLE_CHROME_BRANDING)
EXPECT_FALSE(help_menu->IsEnabledAt(about_index));
#else
EXPECT_FALSE(model.IsEnabledAt(about_index));
#endif // BUILDFLAG(GOOGLE_CHROME_BRANDING)
{
ScopedListPrefUpdate update(
TestingBrowserProcess::GetGlobal()->local_state(),
policy::policy_prefs::kSystemFeaturesDisableList);
update->clear();
}
EXPECT_TRUE(model.IsEnabledAt(options_index));
#if BUILDFLAG(GOOGLE_CHROME_BRANDING)
EXPECT_TRUE(help_menu->IsEnabledAt(about_index));
#else
EXPECT_TRUE(model.IsEnabledAt(about_index));
#endif // BUILDFLAG(GOOGLE_CHROME_BRANDING)
}
#endif // BUILDFLAG(IS_CHROMEOS)
class TestAppMenuModelSafetyHubTest : public AppMenuModelTest {
public:
TestAppMenuModelSafetyHubTest() {
feature_list_.InitWithFeatures(
/*enabled_features=*/{features::kSafetyHub,
features::kSafetyHubHaTSOneOffSurvey},
/*disabled_features=*/{});
}
void SetUp() override {
AppMenuModelTest::SetUp();
password_store_ = CreateAndUseTestPasswordStore(profile());
// Let PasswordStatusCheckService run until it fetches the latest data.
PasswordStatusCheckService* password_service =
safety_hub_test_util::CreateAndUsePasswordStatusService(profile());
safety_hub_test_util::UpdatePasswordCheckServiceAsync(password_service);
EXPECT_EQ(password_service->compromised_credential_count(), 0UL);
// mock_hats_service_ should return true for CanShowAnySurvey on each test
// running for desktop, since hats service is called in
// SafetyHubMenuNotificationService ctor.
mock_hats_service_ = static_cast<MockHatsService*>(
HatsServiceFactory::GetInstance()->SetTestingFactoryAndUse(
profile(), base::BindRepeating(&BuildMockHatsService)));
EXPECT_CALL(*mock_hats_service(), CanShowAnySurvey(_))
.WillRepeatedly(testing::Return(true));
}
void TearDown() override {
mock_hats_service_ = nullptr;
AppMenuModelTest::TearDown();
}
MockHatsService* mock_hats_service() { return mock_hats_service_; }
protected:
base::test::ScopedFeatureList feature_list_;
scoped_refptr<password_manager::TestPasswordStore> password_store_;
raw_ptr<MockHatsService> mock_hats_service_;
};
TEST_F(TestAppMenuModelSafetyHubTest, SafetyHubMenuNotification) {
// When there is no issue identified by Safety Hub, there shouldn't be an
// entry in the AppMenu either.
AppMenuModel model(this, browser());
model.Init();
EXPECT_FALSE(model.GetIndexOfCommandId(IDC_OPEN_SAFETY_HUB).has_value());
safety_hub_test_util::GenerateSafetyHubMenuNotification(profile());
AppMenuModel new_model(this, browser());
new_model.Init();
// The notification should be shown with the correct label and command.
EXPECT_TRUE(new_model.GetIndexOfCommandId(IDC_OPEN_SAFETY_HUB).has_value());
const size_t menu_index =
new_model.GetIndexOfCommandId(IDC_OPEN_SAFETY_HUB).value();
new_model.ActivatedAt(menu_index);
EXPECT_TRUE(new_model.IsEnabledAt(menu_index));
EXPECT_FALSE(new_model.GetLabelAt(menu_index).empty());
}
TEST_F(TestAppMenuModelSafetyHubTest, HaTSControlTrigger) {
EXPECT_CALL(*mock_hats_service(),
LaunchSurvey(kHatsSurveyTriggerSafetyHubOneOffExperimentControl,
_, _, _, _, _, _))
.Times(1);
// Attempting to show the safety hub item in the app menu should trigger the
// control experiment.
AppMenuModel model(this, browser());
model.Init();
// Generate a menu notification that has been shown. After a notification is
// shown, the control survey should not be shown.
safety_hub_test_util::GenerateSafetyHubMenuNotification(profile());
SafetyHubMenuNotificationServiceFactory::GetForProfile(profile())
->GetNotificationToShow();
AppMenuModel new_model(this, browser());
new_model.Init();
}
class TabSearchMenuModelTest : public AppMenuModelTest {
public:
TabSearchMenuModelTest() = default;
~TabSearchMenuModelTest() override = default;
void SetUp() override {
scoped_feature_list_.InitWithFeaturesAndParameters(
/*enabled_features=*/
{{features::kTabstripComboButton,
{{"tab_search_toolbar_button", "true"}}}},
/*disabled_features=*/{});
AppMenuModelTest::SetUp();
}
private:
base::test::ScopedFeatureList scoped_feature_list_;
};
TEST_F(TabSearchMenuModelTest, TabSearchItem) {
AppMenuModel model(this, browser());
model.Init();
ToolsMenuModel toolModel(&model, browser());
size_t tab_search_index =
toolModel.GetIndexOfCommandId(IDC_TAB_SEARCH).value();
EXPECT_TRUE(toolModel.IsEnabledAt(tab_search_index));
}
|