1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
|
// Copyright 2012 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/constrained_window/constrained_window_views.h"
#include <memory>
#include "build/build_config.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_commands.h"
#include "chrome/browser/ui/tabs/tab_model.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/browser/ui/views/tab_modal_confirm_dialog_views.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/interactive_test_utils.h"
#include "chrome/test/base/ui_test_utils.h"
#include "components/web_modal/web_contents_modal_dialog_host.h"
#include "components/web_modal/web_contents_modal_dialog_manager.h"
#include "components/web_modal/web_contents_modal_dialog_manager_delegate.h"
#include "content/public/browser/web_contents.h"
#include "content/public/test/browser_test.h"
#include "content/public/test/browser_test_utils.h"
#include "ui/base/accelerators/accelerator.h"
#include "ui/base/mojom/ui_base_types.mojom-shared.h"
#include "ui/views/accessibility/view_accessibility.h"
#include "ui/views/focus/focus_manager.h"
#include "ui/views/test/widget_test.h"
#include "ui/views/view_tracker.h"
#include "ui/views/widget/widget.h"
class ConstrainedWindowTestDialog : public views::DialogDelegateView {
public:
ConstrainedWindowTestDialog() {
SetFocusBehavior(FocusBehavior::ALWAYS);
SetModalType(ui::mojom::ModalType::kChild);
// Dialogs that take focus must have a name and role to pass accessibility
// checks.
GetViewAccessibility().SetRole(ax::mojom::Role::kDialog);
GetViewAccessibility().SetName("Test dialog",
ax::mojom::NameFrom::kAttribute);
}
ConstrainedWindowTestDialog(const ConstrainedWindowTestDialog&) = delete;
ConstrainedWindowTestDialog& operator=(const ConstrainedWindowTestDialog&) =
delete;
~ConstrainedWindowTestDialog() override = default;
views::View* GetInitiallyFocusedView() override { return this; }
};
namespace {
// A helper function to create and show a web contents modal dialog.
ConstrainedWindowTestDialog* ShowModalDialog(
content::WebContents* web_contents) {
auto dialog = std::make_unique<ConstrainedWindowTestDialog>();
ConstrainedWindowTestDialog* dialog_ptr = dialog.get();
constrained_window::ShowWebModalDialogViews(dialog.release(), web_contents);
return dialog_ptr;
}
class ConstrainedWindowViewTest : public InProcessBrowserTest {
public:
ConstrainedWindowViewTest() = default;
ConstrainedWindowViewTest(const ConstrainedWindowViewTest&) = delete;
ConstrainedWindowViewTest& operator=(const ConstrainedWindowViewTest&) =
delete;
~ConstrainedWindowViewTest() override = default;
void CreateNewTabAndLayout(Browser* browser) {
chrome::NewTab(browser);
// Layout can trigger changes in web content visibility which in turn
// affects the visibility of tab modal dialogs.
RunScheduledLayouts();
}
void CloseTabAndLayout(Browser* browser) {
chrome::CloseTab(browser);
// Layout can trigger changes in web content visibility which in turn
// affects the visibility of tab modal dialogs.
RunScheduledLayouts();
}
};
} // namespace
#if BUILDFLAG(IS_MAC) || BUILDFLAG(IS_LINUX)
// Unexpected multiple focus managers on MacViews: http://crbug.com/824551
// TODO(crbug.com/41481774): Enable for Linux after resolving failure.
#define MAYBE_FocusTest DISABLED_FocusTest
#else
#define MAYBE_FocusTest FocusTest
#endif
// Tests the intial focus of tab-modal dialogs, the restoration of focus to the
// browser when they close, and that queued dialogs don't register themselves as
// accelerator targets until they are displayed.
IN_PROC_BROWSER_TEST_F(ConstrainedWindowViewTest, MAYBE_FocusTest) {
content::WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
EXPECT_TRUE(ui_test_utils::IsViewFocused(browser(), VIEW_ID_OMNIBOX));
ConstrainedWindowTestDialog* const dialog1 = ShowModalDialog(web_contents);
views::ViewTracker tracker1(dialog1);
EXPECT_EQ(dialog1, tracker1.view());
// |dialog1| should be active and focused.
EXPECT_TRUE(dialog1->GetWidget()->IsVisible());
views::FocusManager* focus_manager = dialog1->GetWidget()->GetFocusManager();
EXPECT_EQ(dialog1->GetContentsView(), focus_manager->GetFocusedView());
// Create a second dialog. This will also be modal to |web_contents|, but will
// remain hidden since the |dialog1| is still showing.
ConstrainedWindowTestDialog* const dialog2 = ShowModalDialog(web_contents);
views::ViewTracker tracker2(dialog2);
EXPECT_EQ(dialog2, tracker2.view());
EXPECT_FALSE(dialog2->GetWidget()->IsVisible());
EXPECT_TRUE(dialog1->GetWidget()->IsVisible());
EXPECT_EQ(focus_manager, dialog2->GetWidget()->GetFocusManager());
EXPECT_FALSE(ui_test_utils::IsViewFocused(browser(), VIEW_ID_OMNIBOX));
EXPECT_EQ(dialog1->GetContentsView(), focus_manager->GetFocusedView());
// Pressing return should close |dialog1|.
EXPECT_TRUE(focus_manager->ProcessAccelerator(
ui::Accelerator(ui::VKEY_RETURN, ui::EF_NONE)));
content::RunAllPendingInMessageLoop();
EXPECT_EQ(nullptr, tracker1.view());
// |dialog2| should be visible and focused.
EXPECT_TRUE(dialog2->GetWidget()->IsVisible());
EXPECT_FALSE(ui_test_utils::IsViewFocused(browser(), VIEW_ID_OMNIBOX));
EXPECT_EQ(dialog2->GetContentsView(), focus_manager->GetFocusedView());
// Creating a new tab should take focus away from the other tab's dialog.
const int tab_with_dialog = browser()->tab_strip_model()->active_index();
CreateNewTabAndLayout(browser());
EXPECT_TRUE(ui_test_utils::IsViewFocused(browser(), VIEW_ID_OMNIBOX));
EXPECT_NE(dialog2->GetContentsView(), focus_manager->GetFocusedView());
// Activating the previous tab should bring focus to the dialog.
browser()->tab_strip_model()->ActivateTabAt(tab_with_dialog);
EXPECT_FALSE(ui_test_utils::IsViewFocused(browser(), VIEW_ID_OMNIBOX));
EXPECT_EQ(dialog2->GetContentsView(), focus_manager->GetFocusedView());
// Pressing enter again should close |dialog2|.
EXPECT_TRUE(focus_manager->ProcessAccelerator(
ui::Accelerator(ui::VKEY_RETURN, ui::EF_NONE)));
content::RunAllPendingInMessageLoop();
EXPECT_EQ(nullptr, tracker2.view());
EXPECT_TRUE(ui_test_utils::IsViewFocused(browser(), VIEW_ID_TAB_CONTAINER));
}
// Tests that the tab-modal window is closed properly when its tab is closed.
IN_PROC_BROWSER_TEST_F(ConstrainedWindowViewTest, TabCloseTest) {
ConstrainedWindowTestDialog* const dialog =
ShowModalDialog(browser()->tab_strip_model()->GetActiveWebContents());
views::ViewTracker tracker(dialog);
EXPECT_EQ(dialog, tracker.view());
EXPECT_TRUE(dialog->GetWidget()->IsVisible());
views::test::WidgetDestroyedWaiter widget_destroyed_waiter(
dialog->GetWidget());
CloseTabAndLayout(browser());
widget_destroyed_waiter.Wait();
EXPECT_EQ(nullptr, tracker.view());
}
// Tests that the tab-modal window is hidden when an other tab is selected and
// shown when its tab is selected again.
// Flaky on ASAN builds (https://crbug.com/997634)
// Flaky on Mac (https://crbug.com/1385896)
// Fails on Linux (https://crbug.com/1509135)
#if defined(ADDRESS_SANITIZER) || BUILDFLAG(IS_MAC) || BUILDFLAG(IS_LINUX)
#define MAYBE_TabSwitchTest DISABLED_TabSwitchTest
#else
#define MAYBE_TabSwitchTest TabSwitchTest
#endif
IN_PROC_BROWSER_TEST_F(ConstrainedWindowViewTest, MAYBE_TabSwitchTest) {
ConstrainedWindowTestDialog* const dialog =
ShowModalDialog(browser()->tab_strip_model()->GetActiveWebContents());
views::ViewTracker tracker(dialog);
EXPECT_EQ(dialog, tracker.view());
EXPECT_TRUE(dialog->GetWidget()->IsVisible());
// Open a new tab. The tab-modal window should hide itself.
CreateNewTabAndLayout(browser());
EXPECT_FALSE(dialog->GetWidget()->IsVisible());
// Close the new tab. The tab-modal window should show itself again.
CloseTabAndLayout(browser());
EXPECT_TRUE(dialog->GetWidget()->IsVisible());
// Close the original tab.
views::test::WidgetDestroyedWaiter widget_destroyed_waiter(
dialog->GetWidget());
CloseTabAndLayout(browser());
widget_destroyed_waiter.Wait();
EXPECT_EQ(nullptr, tracker.view());
}
// Tests that tab-modal dialogs follow tabs dragged between browser windows.
// TODO(crbug.com/40847696): On Mac, animations cause this test to be flaky.
#if BUILDFLAG(IS_MAC)
#define MAYBE_TabMoveTest DISABLED_TabMoveTest
#else
#define MAYBE_TabMoveTest TabMoveTest
#endif
IN_PROC_BROWSER_TEST_F(ConstrainedWindowViewTest, MAYBE_TabMoveTest) {
content::WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
ConstrainedWindowTestDialog* const dialog = ShowModalDialog(web_contents);
views::ViewTracker tracker(dialog);
EXPECT_EQ(dialog, tracker.view());
dialog->GetWidget()->SetVisibilityChangedAnimationsEnabled(false);
EXPECT_TRUE(dialog->GetWidget()->IsVisible());
// Move the tab to a second browser window; but first create another tab.
// That prevents the first browser window from closing when its tab is moved.
CreateNewTabAndLayout(browser());
std::unique_ptr<tabs::TabModel> detached_tab =
browser()->tab_strip_model()->DetachTabAtForInsertion(
browser()->tab_strip_model()->GetIndexOfWebContents(web_contents));
Browser* browser2 = CreateBrowser(browser()->profile());
browser2->tab_strip_model()->AppendTab(std::move(detached_tab), true);
EXPECT_TRUE(dialog->GetWidget()->IsVisible());
// Close the original hosting browser window, this should close the dialog.
// TODO(crbug.com/353174863): Update this test to instead close the browser
// currently hosting the dialog (browser2) once web modal dialogs are updated
// to allow reparenting to follow their associated WebContents.
views::test::WidgetDestroyedWaiter destroyed_waiter(dialog->GetWidget());
chrome::CloseWindow(browser());
destroyed_waiter.Wait();
EXPECT_EQ(nullptr, tracker.view());
}
// Tests that the dialog closes when the escape key is pressed.
IN_PROC_BROWSER_TEST_F(ConstrainedWindowViewTest, ClosesOnEscape) {
ConstrainedWindowTestDialog* const dialog =
ShowModalDialog(browser()->tab_strip_model()->GetActiveWebContents());
views::ViewTracker tracker(dialog);
EXPECT_EQ(dialog, tracker.view());
// On Mac, animations cause this test to be flaky.
dialog->GetWidget()->SetVisibilityChangedAnimationsEnabled(false);
EXPECT_TRUE(dialog->GetWidget()->IsVisible());
EXPECT_TRUE(ui_test_utils::SendKeyPressSync(browser(), ui::VKEY_ESCAPE, false,
false, false, false));
content::RunAllPendingInMessageLoop();
EXPECT_EQ(nullptr, tracker.view());
}
|
