1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
|
// Copyright 2023 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ui/views/dark_mode_manager_linux.h"
#include "base/memory/raw_ptr.h"
#include "base/test/scoped_feature_list.h"
#include "chrome/browser/ui/ui_features.h"
#include "dbus/mock_bus.h"
#include "dbus/mock_object_proxy.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/linux/fake_linux_ui.h"
#include "ui/native_theme/native_theme.h"
namespace ui {
namespace {
class MockLinuxUi : public FakeLinuxUi {
public:
MOCK_METHOD(ui::NativeTheme*, GetNativeTheme, (), (const override));
MOCK_METHOD(void, SetDarkTheme, (bool dark), (override));
MOCK_METHOD(void, SetAccentColor, (std::optional<SkColor> color), (override));
};
class MockNativeTheme : public NativeTheme {
public:
MockNativeTheme() : NativeTheme(false) {}
~MockNativeTheme() override = default;
void SetUseDarkColors(bool use_dark_colors) {
set_use_dark_colors(use_dark_colors);
set_preferred_color_scheme(use_dark_colors
? NativeTheme::PreferredColorScheme::kDark
: NativeTheme::PreferredColorScheme::kLight);
NotifyOnNativeThemeUpdated();
}
// Mock some pure-virtual methods even though they're not used.
MOCK_METHOD(gfx::Size,
GetPartSize,
(Part part, State state, const ExtraParams& extra),
(const override));
MOCK_METHOD(void,
Paint,
(cc::PaintCanvas * canvas,
const ui::ColorProvider* color_provider,
Part part,
State state,
const gfx::Rect& rect,
const ExtraParams& extra,
ColorScheme color_scheme,
bool in_forced_colors,
const std::optional<SkColor>& accent_color),
(const override));
MOCK_METHOD(bool, SupportsNinePatch, (Part part), (const override));
MOCK_METHOD(gfx::Size, GetNinePatchCanvasSize, (Part part), (const override));
MOCK_METHOD(gfx::Rect, GetNinePatchAperture, (Part part), (const override));
};
ACTION_P2(RegisterSignalCallback, signal_callback, connected_callback) {
*signal_callback = arg2;
*connected_callback = std::move(*arg3);
}
ACTION_P(MethodCallback,
color_scheme_response_callback,
color_scheme_error_callback) {
*color_scheme_response_callback = std::move(*arg2);
*color_scheme_error_callback = std::move(*arg3);
}
// Matches a method call to the specified dbus target.
MATCHER_P2(Calls, interface, member, "") {
return arg->GetInterface() == interface && arg->GetMember() == member;
}
} // namespace
using testing::_;
using testing::ByMove;
using testing::Return;
using testing::StrictMock;
class DarkModeManagerLinuxTest : public testing::Test {
public:
~DarkModeManagerLinuxTest() override = default;
protected:
bool ManagerPrefersDarkTheme() const { return manager_->prefer_dark_theme(); }
dbus::ObjectProxy::SignalCallback& setting_changed_callback() {
return setting_changed_callback_;
}
dbus::ObjectProxy::OnConnectedCallback& signal_connected_callback() {
return signal_connected_callback_;
}
dbus::MockObjectProxy::ResponseCallback& color_scheme_response_callback() {
return color_scheme_response_callback_;
}
dbus::MockObjectProxy::ErrorCallback& color_scheme_error_callback() {
return color_scheme_error_callback_;
}
dbus::MockObjectProxy::ResponseCallback& accent_color_response_callback() {
return accent_color_response_callback_;
}
dbus::MockObjectProxy::ErrorCallback& accent_color_error_callback() {
return accent_color_error_callback_;
}
MockNativeTheme* mock_native_theme() { return mock_native_theme_.get(); }
MockLinuxUi* mock_linux_ui() { return mock_linux_ui_.get(); }
private:
void SetUp() override {
mock_bus_ = base::MakeRefCounted<dbus::MockBus>(dbus::Bus::Options());
mock_portal_proxy_ =
base::MakeRefCounted<StrictMock<dbus::MockObjectProxy>>(
mock_bus_.get(), DarkModeManagerLinux::kFreedesktopSettingsService,
dbus::ObjectPath(
DarkModeManagerLinux::kFreedesktopSettingsObjectPath));
EXPECT_CALL(*mock_bus_,
GetObjectProxy(
DarkModeManagerLinux::kFreedesktopSettingsService,
dbus::ObjectPath(
DarkModeManagerLinux::kFreedesktopSettingsObjectPath)))
.WillOnce(Return(mock_portal_proxy_.get()));
EXPECT_CALL(
*mock_portal_proxy_,
DoConnectToSignal(DarkModeManagerLinux::kFreedesktopSettingsInterface,
DarkModeManagerLinux::kSettingChangedSignal, _, _))
.WillOnce(RegisterSignalCallback(&setting_changed_callback_,
&signal_connected_callback_));
EXPECT_CALL(*mock_portal_proxy_,
DoCallMethodWithErrorCallback(
Calls(DarkModeManagerLinux::kFreedesktopSettingsInterface,
DarkModeManagerLinux::kReadMethod),
_, _, _))
.WillOnce(MethodCallback(&color_scheme_response_callback_,
&color_scheme_error_callback_))
.WillOnce(MethodCallback(&accent_color_response_callback_,
&accent_color_error_callback_));
mock_linux_ui_ = std::make_unique<MockLinuxUi>();
linux_ui_themes_ = std::vector<raw_ptr<LinuxUiTheme, VectorExperimental>>{
mock_linux_ui_.get()};
mock_native_theme_ = std::make_unique<MockNativeTheme>();
EXPECT_CALL(*mock_linux_ui_, GetNativeTheme())
.WillOnce(Return(mock_native_theme_.get()));
enable_portal_accent_color_.InitAndEnableFeature(
features::kUsePortalAccentColor);
manager_ = std::make_unique<DarkModeManagerLinux>(
mock_bus_, mock_linux_ui_.get(), &linux_ui_themes_,
std::vector<raw_ptr<NativeTheme, VectorExperimental>>{
mock_native_theme_.get()});
EXPECT_FALSE(manager_->prefer_dark_theme());
EXPECT_FALSE(mock_native_theme_->ShouldUseDarkColors());
EXPECT_EQ(mock_native_theme_->GetPreferredColorScheme(),
NativeTheme::PreferredColorScheme::kLight);
}
void TearDown() override { manager_.reset(); }
std::unique_ptr<MockLinuxUi> mock_linux_ui_;
std::vector<raw_ptr<LinuxUiTheme, VectorExperimental>> linux_ui_themes_;
std::unique_ptr<MockNativeTheme> mock_native_theme_;
scoped_refptr<dbus::MockBus> mock_bus_;
scoped_refptr<dbus::MockObjectProxy> mock_portal_proxy_;
dbus::ObjectProxy::SignalCallback setting_changed_callback_;
dbus::ObjectProxy::OnConnectedCallback signal_connected_callback_;
dbus::MockObjectProxy::ResponseCallback color_scheme_response_callback_;
dbus::MockObjectProxy::ErrorCallback color_scheme_error_callback_;
dbus::MockObjectProxy::ResponseCallback accent_color_response_callback_;
dbus::MockObjectProxy::ErrorCallback accent_color_error_callback_;
base::test::ScopedFeatureList enable_portal_accent_color_;
std::unique_ptr<DarkModeManagerLinux> manager_;
};
TEST_F(DarkModeManagerLinuxTest, UseNativeThemeSetting) {
// Set the native theme preference before the async DBus calls complete.
mock_native_theme()->SetUseDarkColors(true);
EXPECT_TRUE(ManagerPrefersDarkTheme());
mock_native_theme()->SetUseDarkColors(false);
EXPECT_FALSE(ManagerPrefersDarkTheme());
// Let the manager know the DBus method call and signal connection failed.
dbus::MethodCall method_call(
DarkModeManagerLinux::kFreedesktopSettingsInterface,
DarkModeManagerLinux::kReadMethod);
method_call.SetSerial(123);
auto error = dbus::ErrorResponse::FromMethodCall(
&method_call, "org.freedesktop.DBus.Error.Failed", "");
std::move(color_scheme_error_callback()).Run(error.get());
std::move(signal_connected_callback())
.Run(DarkModeManagerLinux::kFreedesktopSettingsInterface,
DarkModeManagerLinux::kSettingChangedSignal, false);
// The native theme preference should still toggle the manager preference.
mock_native_theme()->SetUseDarkColors(true);
EXPECT_TRUE(ManagerPrefersDarkTheme());
mock_native_theme()->SetUseDarkColors(false);
EXPECT_FALSE(ManagerPrefersDarkTheme());
}
TEST_F(DarkModeManagerLinuxTest, UsePortalSetting) {
// Let the manager know the DBus method call and signal connection succeeded.
dbus::MethodCall method_call(
DarkModeManagerLinux::kFreedesktopSettingsInterface,
DarkModeManagerLinux::kReadMethod);
method_call.SetSerial(123);
auto response = dbus::Response::FromMethodCall(&method_call);
dbus::MessageWriter writer(response.get());
dbus::MessageWriter variant_writer(nullptr);
writer.OpenVariant("v", &variant_writer);
variant_writer.AppendVariantOfUint32(
DarkModeManagerLinux::kFreedesktopColorSchemeDark);
writer.CloseContainer(&variant_writer);
EXPECT_CALL(*mock_linux_ui(), SetDarkTheme(true));
std::move(color_scheme_response_callback()).Run(response.get());
EXPECT_TRUE(ManagerPrefersDarkTheme());
EXPECT_TRUE(mock_native_theme()->ShouldUseDarkColors());
EXPECT_EQ(mock_native_theme()->GetPreferredColorScheme(),
NativeTheme::PreferredColorScheme::kDark);
// Changes in the portal preference should be processed by the manager and the
// native theme should be updated.
dbus::Signal signal(DarkModeManagerLinux::kFreedesktopSettingsInterface,
DarkModeManagerLinux::kSettingChangedSignal);
dbus::MessageWriter signal_writer(&signal);
signal_writer.AppendString(DarkModeManagerLinux::kSettingsNamespace);
signal_writer.AppendString(DarkModeManagerLinux::kColorSchemeKey);
signal_writer.AppendVariantOfUint32(0);
EXPECT_CALL(*mock_linux_ui(), SetDarkTheme(false));
std::move(setting_changed_callback()).Run(&signal);
EXPECT_FALSE(ManagerPrefersDarkTheme());
EXPECT_FALSE(mock_native_theme()->ShouldUseDarkColors());
EXPECT_EQ(mock_native_theme()->GetPreferredColorScheme(),
NativeTheme::PreferredColorScheme::kLight);
// The native theme preference should have no effect when the portal
// preference is being used.
mock_native_theme()->SetUseDarkColors(true);
EXPECT_FALSE(ManagerPrefersDarkTheme());
mock_native_theme()->SetUseDarkColors(false);
EXPECT_FALSE(ManagerPrefersDarkTheme());
}
TEST_F(DarkModeManagerLinuxTest, UsePortalAccentColor) {
// Let the manager know the DBus method call and signal connection succeeded.
dbus::MethodCall method_call(
DarkModeManagerLinux::kFreedesktopSettingsInterface,
DarkModeManagerLinux::kReadMethod);
method_call.SetSerial(123);
auto response = dbus::Response::FromMethodCall(&method_call);
dbus::MessageWriter writer(response.get());
dbus::MessageWriter outer_variant_writer(nullptr);
writer.OpenVariant("v", &outer_variant_writer);
dbus::MessageWriter inner_variant_writer(nullptr);
outer_variant_writer.OpenVariant("(ddd)", &inner_variant_writer);
dbus::MessageWriter struct1_writer(nullptr);
inner_variant_writer.OpenStruct(&struct1_writer);
struct1_writer.AppendDouble(0.0);
struct1_writer.AppendDouble(0.5);
struct1_writer.AppendDouble(1.0);
inner_variant_writer.CloseContainer(&struct1_writer);
outer_variant_writer.CloseContainer(&inner_variant_writer);
writer.CloseContainer(&outer_variant_writer);
std::optional<SkColor> expected_color = SkColorSetRGB(0, 127, 255);
EXPECT_CALL(*mock_linux_ui(), SetAccentColor(expected_color));
std::move(accent_color_response_callback()).Run(response.get());
// Changes in the portal accent color should be processed by the manager and
// the native theme should be updated.
dbus::Signal signal(DarkModeManagerLinux::kFreedesktopSettingsInterface,
DarkModeManagerLinux::kSettingChangedSignal);
dbus::MessageWriter signal_writer(&signal);
signal_writer.AppendString(DarkModeManagerLinux::kSettingsNamespace);
signal_writer.AppendString(DarkModeManagerLinux::kAccentColorKey);
dbus::MessageWriter variant_writer(nullptr);
signal_writer.OpenVariant("(ddd)", &variant_writer);
dbus::MessageWriter struct2_writer(nullptr);
variant_writer.OpenStruct(&struct2_writer);
struct2_writer.AppendDouble(0.0);
struct2_writer.AppendDouble(0.5);
struct2_writer.AppendDouble(1.0);
variant_writer.CloseContainer(&struct2_writer);
signal_writer.CloseContainer(&variant_writer);
EXPECT_CALL(*mock_linux_ui(), SetAccentColor(expected_color));
std::move(setting_changed_callback()).Run(&signal);
}
} // namespace ui
|
