1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
|
// Copyright 2023 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <string>
#include "base/test/metrics/user_action_tester.h"
#include "base/test/scoped_feature_list.h"
#include "base/test/test_future.h"
#include "chrome/browser/apps/link_capturing/link_capturing_feature_test_support.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_commands.h"
#include "chrome/browser/ui/browser_finder.h"
#include "chrome/browser/ui/intent_picker_tab_helper.h"
#include "chrome/browser/ui/ui_features.h"
#include "chrome/browser/ui/views/frame/browser_view.h"
#include "chrome/browser/ui/views/web_apps/web_app_link_capturing_test_utils.h"
#include "chrome/browser/ui/web_applications/app_browser_controller.h"
#include "chrome/browser/ui/web_applications/test/web_app_browsertest_util.h"
#include "chrome/browser/ui/web_applications/test/web_app_navigation_browsertest.h"
#include "chrome/browser/web_applications/test/web_app_icon_test_utils.h"
#include "chrome/browser/web_applications/web_app_pref_guardrails.h"
#include "chrome/browser/web_applications/web_app_ui_manager.h"
#include "chrome/test/base/ui_test_utils.h"
#include "chrome/test/user_education/interactive_feature_promo_test.h"
#include "components/user_education/views/help_bubble_factory_views.h"
#include "components/user_education/views/help_bubble_view.h"
#include "content/public/browser/web_contents.h"
#include "content/public/test/browser_test.h"
#include "content/public/test/browser_test_utils.h"
#include "net/dns/mock_host_resolver.h"
#include "net/test/embedded_test_server/embedded_test_server.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/events/event.h"
#include "ui/events/types/event_type.h"
#include "ui/gfx/geometry/point.h"
#include "ui/views/interaction/element_tracker_views.h"
#include "ui/views/interaction/interaction_test_util_views.h"
#include "ui/views/test/button_test_api.h"
#include "ui/views/widget/any_widget_observer.h"
namespace {
// Helper function to generate test names for IntentChipButton tests.
std::string GenerateIntentChipTestName(
const testing::TestParamInfo<
std::tuple<apps::test::LinkCapturingFeatureVersion, bool>>&
param_info) {
std::string test_name;
test_name.append(apps::test::ToString(
std::get<apps::test::LinkCapturingFeatureVersion>(param_info.param)));
test_name.append("_");
if (std::get<bool>(param_info.param)) {
test_name.append("page_action_on");
} else {
test_name.append("page_action_off");
}
return test_name;
}
} // namespace
#if BUILDFLAG(IS_MAC)
#include "chrome/browser/apps/link_capturing/mac_intent_picker_helpers.h"
#endif // BUILDFLAG(IS_MAC)
// This test only runs on Windows, Mac and Linux platforms.
// Because some tests here rely on browser activation, an
// interactive_ui_test is preferred over a browser test.
class DefaultLinkCapturingInteractiveUiTest
: public web_app::WebAppNavigationBrowserTest,
public testing::WithParamInterface<
std::tuple<apps::test::LinkCapturingFeatureVersion, bool>> {
public:
DefaultLinkCapturingInteractiveUiTest() {
std::vector<base::test::FeatureRefAndParams> features_to_enable =
apps::test::GetFeaturesToEnableLinkCapturingUX(
std::get<apps::test::LinkCapturingFeatureVersion>(GetParam()));
if (IsMigrationEnabled()) {
features_to_enable.push_back(
{::features::kPageActionsMigration,
{{::features::kPageActionsMigrationIntentPicker.name, "true"}}});
}
feature_list_.InitWithFeaturesAndParameters(features_to_enable, {});
}
void SetUpOnMainThread() override {
host_resolver()->AddRule("*", "127.0.0.1");
ASSERT_TRUE(embedded_test_server()->Start());
}
size_t GetItemContainerSize(IntentPickerBubbleView* bubble) {
return bubble->GetViewByID(IntentPickerBubbleView::ViewId::kItemContainer)
->children()
.size();
}
GURL GetOuterUrl() {
return embedded_test_server()->GetURL("/web_apps/nesting/index.html");
}
GURL GetInnerNestedUrl() {
return embedded_test_server()->GetURL(
"/web_apps/nesting/nested/index.html");
}
GURL GetNestedPageUrl() {
return embedded_test_server()->GetURL(
"/web_apps/nesting/nested/page1.html");
}
// Returns [outer app_id, inner app_id]
std::tuple<webapps::AppId, webapps::AppId> InstallOuterAppAndInnerApp() {
// The inner app must be installed first so that it is installable.
webapps::AppId inner_app_id =
web_app::InstallWebAppFromPageAndCloseAppBrowser(browser(),
GetInnerNestedUrl());
webapps::AppId outer_app_id =
web_app::InstallWebAppFromPageAndCloseAppBrowser(browser(),
GetOuterUrl());
return {outer_app_id, inner_app_id};
}
bool IsMigrationEnabled() const { return std::get<bool>(GetParam()); }
private:
base::test::ScopedFeatureList feature_list_;
};
IN_PROC_BROWSER_TEST_P(DefaultLinkCapturingInteractiveUiTest,
BubbleAcceptCorrectActions) {
const auto [outer_app_id, inner_app_id] = InstallOuterAppAndInnerApp();
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), GetNestedPageUrl()));
EXPECT_TRUE(web_app::ClickIntentPickerAndWaitForBubble(browser()));
base::UserActionTester user_action_tester;
// The app list is currently not deterministically ordered, so find the
// correct item and select that.
const auto& app_infos =
web_app::intent_picker_bubble()->app_info_for_testing(); // IN-TEST
auto it = std::ranges::find(app_infos, outer_app_id,
&apps::IntentPickerAppInfo::launch_name);
ASSERT_NE(it, app_infos.end());
size_t index = it - app_infos.begin();
ui_test_utils::BrowserChangeObserver browser_added_waiter(
nullptr, ui_test_utils::BrowserChangeObserver::ChangeType::kAdded);
views::test::ButtonTestApi test_api(
web_app::GetIntentPickerButtonAtIndex(index));
test_api.NotifyClick(ui::MouseEvent(
ui::EventType::kMousePressed, gfx::Point(), gfx::Point(),
base::TimeTicks(), ui::EF_LEFT_MOUSE_BUTTON, ui::EF_LEFT_MOUSE_BUTTON));
web_app::intent_picker_bubble()->AcceptDialog();
EXPECT_EQ(
1, user_action_tester.GetActionCount("IntentPickerViewAcceptLaunchApp"));
Browser* app_browser = browser_added_waiter.Wait();
ASSERT_TRUE(app_browser);
EXPECT_TRUE(web_app::AppBrowserController::IsWebApp(app_browser));
EXPECT_TRUE(
web_app::AppBrowserController::IsForWebApp(app_browser, outer_app_id));
}
IN_PROC_BROWSER_TEST_P(DefaultLinkCapturingInteractiveUiTest, BubbleCancel) {
const auto [outer_app_id, inner_app_id] = InstallOuterAppAndInnerApp();
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), GetNestedPageUrl()));
base::UserActionTester user_action_tester;
EXPECT_TRUE(web_app::ClickIntentPickerAndWaitForBubble(browser()));
web_app::intent_picker_bubble()->CancelDialog();
EXPECT_EQ(1, user_action_tester.GetActionCount(
"IntentPickerViewClosedStayInChrome"));
// Verify no new browsers have opened.
EXPECT_EQ(1u, chrome::GetTotalBrowserCount());
}
IN_PROC_BROWSER_TEST_P(DefaultLinkCapturingInteractiveUiTest, BubbleIgnored) {
const auto [outer_app_id, inner_app_id] = InstallOuterAppAndInnerApp();
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), GetNestedPageUrl()));
base::UserActionTester user_action_tester;
EXPECT_TRUE(web_app::ClickIntentPickerAndWaitForBubble(browser()));
// Opening a new tab should ignore the current intent picker view.
chrome::NewTab(browser());
EXPECT_EQ(1, user_action_tester.GetActionCount("IntentPickerViewIgnored"));
// Verify no new browsers have opened.
EXPECT_EQ(1u, chrome::GetTotalBrowserCount());
}
#if BUILDFLAG(IS_MAC)
// Test that if there is a Universal Link for a site, it shows the picker
// with the app icon.
IN_PROC_BROWSER_TEST_P(DefaultLinkCapturingInteractiveUiTest,
ShowUniversalLinkAppInIntentChip) {
const GURL url1(embedded_test_server()->GetURL("/title1.html"));
const GURL url2(embedded_test_server()->GetURL("/title2.html"));
const char* kFinderAppPath = "/System/Library/CoreServices/Finder.app";
// Start with a page with no corresponding native app.
apps::OverrideMacAppForUrlForTesting(true, "");
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), url1));
// Verify that no icon was shown.
EXPECT_TRUE(web_app::AwaitIntentPickerTabHelperIconUpdateComplete(
browser()->tab_strip_model()->GetActiveWebContents()));
ASSERT_FALSE(web_app::GetIntentPickerButton(browser())->GetVisible());
// Load a different page while simulating it having a native app.
apps::OverrideMacAppForUrlForTesting(true, kFinderAppPath);
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), url2));
// Verify app icon shows up in the intent picker.
EXPECT_TRUE(web_app::AwaitIntentPickerTabHelperIconUpdateComplete(
browser()->tab_strip_model()->GetActiveWebContents()));
views::Button* intent_picker_icon = web_app::GetIntentPickerButton(browser());
ASSERT_NE(intent_picker_icon, nullptr);
content::WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
ASSERT_NE(web_contents, nullptr);
IntentPickerTabHelper* tab_helper =
IntentPickerTabHelper::FromWebContents(web_contents);
ui::ImageModel app_icon = tab_helper->app_icon();
SkColor final_color = app_icon.GetImage().AsBitmap().getColor(8, 8);
EXPECT_TRUE(
web_app::AreColorsEqual(SK_ColorRED, final_color, /*threshold=*/50));
}
#endif // BUILDFLAG(IS_MAC)
INSTANTIATE_TEST_SUITE_P(
All,
DefaultLinkCapturingInteractiveUiTest,
testing::Combine(
testing::Values(apps::test::LinkCapturingFeatureVersion::kV2DefaultOff,
apps::test::LinkCapturingFeatureVersion::kV2DefaultOn),
testing::Bool()),
GenerateIntentChipTestName);
|
