1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
|
// Copyright 2019 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/memory/raw_ptr.h"
#include "base/strings/utf_string_conversions.h"
#include "base/test/metrics/user_action_tester.h"
#include "build/build_config.h"
#include "chrome/browser/ui/toolbar/test_toolbar_action_view_controller.h"
#include "chrome/browser/ui/views/extensions/extensions_menu_button.h"
#include "chrome/browser/ui/views/extensions/extensions_menu_item_view.h"
#include "chrome/browser/ui/views/extensions/extensions_toolbar_unittest.h"
#include "chrome/browser/ui/views/hover_button_controller.h"
#include "chrome/browser/ui/views/native_widget_factory.h"
#include "extensions/common/extension_features.h"
#include "ui/views/controls/styled_label.h"
class ExtensionMenuItemViewTest : public ExtensionsToolbarUnitTest,
public testing::WithParamInterface<bool> {
public:
ExtensionMenuItemViewTest()
: initial_extension_name_(u"Initial Extension Name"),
initial_tooltip_(u"Initial tooltip") {
feature_list_.InitWithFeatureState(
extensions_features::kExtensionsMenuAccessControl, GetParam());
}
ExtensionMenuItemViewTest(const ExtensionMenuItemViewTest&) = delete;
ExtensionMenuItemViewTest& operator=(const ExtensionMenuItemViewTest&) =
delete;
~ExtensionMenuItemViewTest() override = default;
protected:
ExtensionsMenuButton* primary_button() { return primary_button_; }
HoverButton* pin_button() { return pin_button_; }
HoverButton* context_menu_button() { return context_menu_button_; }
// ExtensionsToolbarUnitTest:
void SetUp() override;
void TearDown() override;
const std::u16string initial_extension_name_;
const std::u16string initial_tooltip_;
std::unique_ptr<views::Widget> widget_;
raw_ptr<ExtensionsMenuButton, DanglingUntriaged> primary_button_ = nullptr;
raw_ptr<HoverButton, DanglingUntriaged> pin_button_ = nullptr;
raw_ptr<HoverButton, DanglingUntriaged> context_menu_button_ = nullptr;
raw_ptr<TestToolbarActionViewController, DanglingUntriaged> controller_ =
nullptr;
private:
base::test::ScopedFeatureList feature_list_;
};
void ExtensionMenuItemViewTest::SetUp() {
ExtensionsToolbarUnitTest::SetUp();
widget_ = std::make_unique<views::Widget>();
views::Widget::InitParams init_params(
views::Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET,
views::Widget::InitParams::TYPE_POPUP);
#if !BUILDFLAG(IS_CHROMEOS) && !BUILDFLAG(IS_MAC)
// This was copied from BookmarkBarViewTest:
// On Chrome OS, this always creates a NativeWidgetAura, but it should
// create a DesktopNativeWidgetAura for Mash. We can get by without manually
// creating it because AshTestViewsDelegate and MusClient will do the right
// thing automatically.
init_params.native_widget =
CreateNativeWidget(NativeWidgetType::DESKTOP_NATIVE_WIDGET_AURA,
&init_params, widget_.get());
#endif
widget_->Init(std::move(init_params));
auto controller = std::make_unique<TestToolbarActionViewController>("hello");
controller_ = controller.get();
controller_->SetActionName(initial_extension_name_);
controller_->SetTooltip(initial_tooltip_);
std::unique_ptr<ExtensionMenuItemView> menu_item;
if (GetParam()) {
menu_item = std::make_unique<ExtensionMenuItemView>(
browser(), /*is_enterprise=*/false, std::move(controller),
/*site_access_toggle_callback*/ base::DoNothing(),
/*site_permissions_button_callback=*/base::RepeatingClosure());
} else {
menu_item = std::make_unique<ExtensionMenuItemView>(
browser(), std::move(controller), /*allow_pinning=*/true);
}
primary_button_ = menu_item->primary_action_button_for_testing();
pin_button_ = menu_item->pin_button_for_testing();
context_menu_button_ = menu_item->context_menu_button_for_testing();
widget_->SetContentsView(std::move(menu_item));
}
void ExtensionMenuItemViewTest::TearDown() {
// All windows need to be closed before tear down.
widget_.reset();
ExtensionsToolbarUnitTest::TearDown();
}
INSTANTIATE_TEST_SUITE_P(,
ExtensionMenuItemViewTest,
testing::Bool(),
[](const testing::TestParamInfo<bool>& info) {
return info.param ? "FeatureEnabled"
: "FeatureDisabled";
});
TEST_P(ExtensionMenuItemViewTest, UpdatesToDisplayCorrectActionTitle) {
EXPECT_EQ(primary_button()->label_text_for_testing(),
initial_extension_name_);
std::u16string extension_name = u"Extension Name";
controller_->SetActionName(extension_name);
EXPECT_EQ(primary_button()->label_text_for_testing(), extension_name);
}
TEST_P(ExtensionMenuItemViewTest, UpdatesToDisplayTooltip) {
EXPECT_EQ(primary_button()->GetRenderedTooltipText(gfx::Point()),
initial_tooltip_);
std::u16string tooltip = u"New Tooltip";
controller_->SetTooltip(tooltip);
EXPECT_EQ(primary_button()->GetRenderedTooltipText(gfx::Point()), tooltip);
}
TEST_P(ExtensionMenuItemViewTest, ButtonMatchesEnabledStateOfExtension) {
EXPECT_TRUE(primary_button()->GetEnabled());
controller_->SetEnabled(false);
EXPECT_FALSE(primary_button()->GetEnabled());
controller_->SetEnabled(true);
EXPECT_TRUE(primary_button()->GetEnabled());
}
TEST_P(ExtensionMenuItemViewTest, NotifyClickExecutesAction) {
base::UserActionTester user_action_tester;
constexpr char kActivatedUserAction[] =
"Extensions.Toolbar.ExtensionActivatedFromMenu";
EXPECT_EQ(0, controller_->execute_action_count());
EXPECT_EQ(0, user_action_tester.GetActionCount(kActivatedUserAction));
primary_button()->SetBounds(0, 0, 100, 100);
ClickButton(primary_button());
EXPECT_EQ(1, controller_->execute_action_count());
EXPECT_EQ(1, user_action_tester.GetActionCount(kActivatedUserAction));
}
TEST_P(ExtensionMenuItemViewTest, PinButtonUserAction) {
if (GetParam()) {
// kExtensionsMenuAccessControl feature doesn't have a pin button.
EXPECT_EQ(pin_button(), nullptr);
return;
}
base::UserActionTester user_action_tester;
constexpr char kPinButtonUserAction[] = "Extensions.Toolbar.PinButtonPressed";
EXPECT_EQ(0, user_action_tester.GetActionCount(kPinButtonUserAction));
ClickButton(pin_button());
EXPECT_EQ(1, user_action_tester.GetActionCount(kPinButtonUserAction));
}
TEST_P(ExtensionMenuItemViewTest, ContextMenuButtonUserAction) {
base::UserActionTester user_action_tester;
constexpr char kContextMenuButtonUserAction[] =
"Extensions.Toolbar.MoreActionsButtonPressedFromMenu";
EXPECT_EQ(0, user_action_tester.GetActionCount(kContextMenuButtonUserAction));
ClickButton(context_menu_button());
EXPECT_EQ(1, user_action_tester.GetActionCount(kContextMenuButtonUserAction));
}
|
