1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453
|
// Copyright 2019 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ui/views/extensions/extensions_menu_view.h"
#include <algorithm>
#include <memory>
#include <string>
#include <vector>
#include "base/command_line.h"
#include "base/containers/to_vector.h"
#include "base/files/file_path.h"
#include "base/memory/raw_ptr.h"
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"
#include "base/test/metrics/user_action_tester.h"
#include "build/build_config.h"
#include "chrome/browser/extensions/chrome_test_extension_loader.h"
#include "chrome/browser/extensions/extension_action_test_util.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/load_error_reporter.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/toolbar/toolbar_action_view_controller.h"
#include "chrome/browser/ui/views/extensions/extensions_menu_button.h"
#include "chrome/browser/ui/views/extensions/extensions_menu_item_view.h"
#include "chrome/browser/ui/views/extensions/extensions_toolbar_button.h"
#include "chrome/browser/ui/views/extensions/extensions_toolbar_container.h"
#include "chrome/browser/ui/views/extensions/extensions_toolbar_unittest.h"
#include "chrome/browser/ui/views/frame/browser_view.h"
#include "chrome/browser/ui/views/toolbar/toolbar_view.h"
#include "content/public/test/test_utils.h"
#include "extensions/browser/test_extension_registry_observer.h"
#include "extensions/common/extension.h"
#include "extensions/test/test_extension_dir.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "ui/events/event.h"
#include "ui/views/controls/button/image_button.h"
#include "ui/views/layout/animating_layout_manager_test_util.h"
#include "ui/views/test/ax_event_counter.h"
#include "ui/views/view_utils.h"
#include "ui/views/widget/widget.h"
namespace {
// Manages a Browser instance created by BrowserWithTestWindowTest beyond the
// default instance it creates in SetUp.
class AdditionalBrowser {
public:
explicit AdditionalBrowser(std::unique_ptr<Browser> browser)
: browser_(std::move(browser)),
browser_view_(BrowserView::GetBrowserViewForBrowser(browser_.get())) {}
~AdditionalBrowser() {
// Tear down |browser_|, similar to TestWithBrowserView::TearDown.
browser_.release();
browser_view_->GetWidget()->CloseNow();
}
ExtensionsToolbarContainer* extensions_container() {
return browser_view_->toolbar()->extensions_container();
}
private:
std::unique_ptr<Browser> browser_;
raw_ptr<BrowserView, DanglingUntriaged> browser_view_;
};
} // namespace
class ExtensionsMenuViewUnitTest : public ExtensionsToolbarUnitTest {
public:
ExtensionsMenuViewUnitTest()
: allow_extension_menu_instances_(
ExtensionsMenuView::AllowInstancesForTesting()) {}
ExtensionsMenuViewUnitTest(const ExtensionsMenuViewUnitTest&) = delete;
ExtensionsMenuViewUnitTest& operator=(const ExtensionsMenuViewUnitTest&) =
delete;
~ExtensionsMenuViewUnitTest() override = default;
// ExtensionsToolbarUnitTest:
void SetUp() override;
scoped_refptr<const extensions::Extension> InstallExtensionAndLayout(
const std::string& name);
ExtensionsMenuView* extensions_menu() {
return ExtensionsMenuView::GetExtensionsMenuViewForTesting();
}
// Asserts there is exactly 1 menu item and then returns it.
ExtensionMenuItemView* GetOnlyMenuItem();
void ClickPinButton(ExtensionMenuItemView* menu_item) const;
void ClickContextMenuButton(ExtensionMenuItemView* menu_item) const;
std::vector<ToolbarActionView*> GetPinnedExtensionViews();
ExtensionMenuItemView* GetExtensionMenuItemView(const std::string& name);
// Returns a list of the names of the currently pinned extensions, in order
// from left to right.
std::vector<std::string> GetPinnedExtensionNames();
// Since this is a unittest (and doesn't have as much "real" rendering),
// the ExtensionsMenuView sometimes needs a nudge to re-layout the views.
void LayoutMenuIfNecessary();
private:
base::AutoReset<bool> allow_extension_menu_instances_;
};
void ExtensionsMenuViewUnitTest::SetUp() {
ExtensionsToolbarUnitTest::SetUp();
ExtensionsMenuView::ShowBubble(extensions_container()->GetExtensionsButton(),
browser(), extensions_container());
}
scoped_refptr<const extensions::Extension>
ExtensionsMenuViewUnitTest::InstallExtensionAndLayout(const std::string& name) {
scoped_refptr<const extensions::Extension> extension = InstallExtension(name);
LayoutMenuIfNecessary();
return extension;
}
ExtensionMenuItemView* ExtensionsMenuViewUnitTest::GetOnlyMenuItem() {
base::flat_set<raw_ptr<ExtensionMenuItemView, CtnExperimental>> menu_items =
extensions_menu()->extensions_menu_items_for_testing();
if (menu_items.size() != 1u) {
ADD_FAILURE() << "Not exactly one item; size is: " << menu_items.size();
return nullptr;
}
return *menu_items.begin();
}
void ExtensionsMenuViewUnitTest::ClickPinButton(
ExtensionMenuItemView* menu_item) const {
ClickButton(menu_item->pin_button_for_testing());
}
void ExtensionsMenuViewUnitTest::ClickContextMenuButton(
ExtensionMenuItemView* menu_item) const {
ClickButton(menu_item->context_menu_button_for_testing());
}
std::vector<ToolbarActionView*>
ExtensionsMenuViewUnitTest::GetPinnedExtensionViews() {
std::vector<ToolbarActionView*> result;
for (views::View* child : extensions_container()->children()) {
// Ensure we don't downcast the ExtensionsToolbarButton.
if (views::IsViewClass<ToolbarActionView>(child)) {
ToolbarActionView* const action = static_cast<ToolbarActionView*>(child);
#if BUILDFLAG(IS_MAC)
// TODO(crbug.com/40670141): Use IsActionVisibleOnToolbar() because it
// queries the underlying model and not GetVisible(), as that relies on an
// animation running, which is not reliable in unit tests on Mac.
const bool is_visible = extensions_container()->IsActionVisibleOnToolbar(
action->view_controller()->GetId());
#else
const bool is_visible = action->GetVisible();
#endif
if (is_visible) {
result.push_back(action);
}
}
}
return result;
}
ExtensionMenuItemView* ExtensionsMenuViewUnitTest::GetExtensionMenuItemView(
const std::string& name) {
base::flat_set<raw_ptr<ExtensionMenuItemView, CtnExperimental>> menu_items =
extensions_menu()->extensions_menu_items_for_testing();
auto iter =
std::ranges::find(menu_items, name, [](ExtensionMenuItemView* item) {
return base::UTF16ToUTF8(item->view_controller()->GetActionName());
});
return iter == menu_items.end() ? nullptr : *iter;
}
std::vector<std::string> ExtensionsMenuViewUnitTest::GetPinnedExtensionNames() {
return base::ToVector(GetPinnedExtensionViews(), [](ToolbarActionView* view) {
return base::UTF16ToUTF8(view->view_controller()->GetActionName());
});
}
void ExtensionsMenuViewUnitTest::LayoutMenuIfNecessary() {
extensions_menu()->GetWidget()->LayoutRootViewIfNecessary();
}
TEST_F(ExtensionsMenuViewUnitTest, ExtensionsAreShownInTheMenu) {
// To start, there should be no extensions in the menu.
EXPECT_EQ(0u, extensions_menu()->extensions_menu_items_for_testing().size());
// Add an extension, and verify that it's added to the menu.
constexpr char kExtensionName[] = "Test 1";
InstallExtensionAndLayout(kExtensionName);
{
base::flat_set<raw_ptr<ExtensionMenuItemView, CtnExperimental>> menu_items =
extensions_menu()->extensions_menu_items_for_testing();
ASSERT_EQ(1u, menu_items.size());
EXPECT_EQ(kExtensionName,
base::UTF16ToUTF8((*menu_items.begin())
->primary_action_button_for_testing()
->label_text_for_testing()));
}
}
TEST_F(ExtensionsMenuViewUnitTest, ExtensionsAreSortedInTheMenu) {
constexpr char kExtensionZName[] = "Z Extension";
InstallExtension(kExtensionZName);
constexpr char kExtensionAName[] = "A Extension";
InstallExtension(kExtensionAName);
constexpr char kExtensionBName[] = "b Extension";
InstallExtension(kExtensionBName);
constexpr char kExtensionCName[] = "C Extension";
InstallExtensionAndLayout(kExtensionCName);
std::vector<ExtensionMenuItemView*> menu_items =
ExtensionsMenuView::GetSortedItemsForSectionForTesting(
extensions::SitePermissionsHelper::SiteInteraction::kNone);
ASSERT_EQ(4u, menu_items.size());
std::vector<std::string> item_names;
for (auto* menu_item : menu_items) {
item_names.push_back(
base::UTF16ToUTF8(menu_item->primary_action_button_for_testing()
->label_text_for_testing()));
}
// Basic std::sort would do A,C,Z,b however we want A,b,C,Z
EXPECT_THAT(item_names,
testing::ElementsAre(kExtensionAName, kExtensionBName,
kExtensionCName, kExtensionZName));
}
TEST_F(ExtensionsMenuViewUnitTest, PinnedExtensionAppearsInToolbar) {
constexpr char kName[] = "Test Name";
const std::string& extension_id = InstallExtensionAndLayout(kName)->id();
ExtensionMenuItemView* menu_item = GetOnlyMenuItem();
ASSERT_TRUE(menu_item);
EXPECT_FALSE(extensions_container()->IsActionVisibleOnToolbar(extension_id));
EXPECT_THAT(GetPinnedExtensionNames(), testing::IsEmpty());
ClickPinButton(menu_item);
WaitForAnimation();
EXPECT_TRUE(extensions_container()->IsActionVisibleOnToolbar(extension_id));
EXPECT_THAT(GetPinnedExtensionNames(), testing::ElementsAre(kName));
ClickPinButton(menu_item); // Unpin.
WaitForAnimation();
EXPECT_FALSE(extensions_container()->IsActionVisibleOnToolbar(extension_id));
EXPECT_THAT(GetPinnedExtensionNames(), testing::IsEmpty());
}
TEST_F(ExtensionsMenuViewUnitTest, PinnedExtensionAppearsInAnotherWindow) {
const std::string& extension_id =
InstallExtensionAndLayout("Test Name")->id();
AdditionalBrowser browser2(
CreateBrowser(browser()->profile(), browser()->type(),
/* hosted_app */ false, /* browser_window */ nullptr));
ExtensionMenuItemView* menu_item = GetOnlyMenuItem();
ASSERT_TRUE(menu_item);
ClickPinButton(menu_item);
// Window that was already open gets the pinned extension.
EXPECT_TRUE(
browser2.extensions_container()->IsActionVisibleOnToolbar(extension_id));
AdditionalBrowser browser3(
CreateBrowser(browser()->profile(), browser()->type(),
/* hosted_app */ false, /* browser_window */ nullptr));
// Brand-new window also gets the pinned extension.
EXPECT_TRUE(
browser3.extensions_container()->IsActionVisibleOnToolbar(extension_id));
}
TEST_F(ExtensionsMenuViewUnitTest, PinnedExtensionRemovedWhenDisabled) {
constexpr char kName[] = "Test Name";
const extensions::ExtensionId id = InstallExtensionAndLayout(kName)->id();
{
ExtensionMenuItemView* menu_item = GetOnlyMenuItem();
ASSERT_TRUE(menu_item);
ClickPinButton(menu_item);
}
DisableExtension(id);
WaitForAnimation();
ASSERT_EQ(0u, extensions_menu()->extensions_menu_items_for_testing().size());
EXPECT_THAT(GetPinnedExtensionNames(), testing::IsEmpty());
EnableExtension(id);
WaitForAnimation();
ASSERT_EQ(1u, extensions_menu()->extensions_menu_items_for_testing().size());
EXPECT_THAT(GetPinnedExtensionNames(), testing::ElementsAre(kName));
}
TEST_F(ExtensionsMenuViewUnitTest, PinnedExtensionLayout) {
for (int i = 0; i < 3; i++) {
InstallExtensionAndLayout(base::StringPrintf("Test %d", i));
}
for (ExtensionMenuItemView* menu_item :
extensions_menu()->extensions_menu_items_for_testing()) {
ClickPinButton(menu_item);
}
WaitForAnimation();
std::vector<ToolbarActionView*> action_views = GetPinnedExtensionViews();
ASSERT_EQ(3u, action_views.size());
ExtensionsToolbarButton* menu_button =
extensions_container()->GetExtensionsButton();
// All views should be lined up horizontally with the menu button.
EXPECT_EQ(action_views[0]->y(), action_views[1]->y());
EXPECT_EQ(action_views[1]->y(), action_views[2]->y());
EXPECT_EQ(action_views[2]->y(), menu_button->y());
// Views are ordered left-to-right (in LTR mode).
EXPECT_LE(action_views[0]->x() + action_views[0]->width(),
action_views[1]->x());
EXPECT_LE(action_views[1]->x() + action_views[1]->width(),
action_views[2]->x());
EXPECT_LE(action_views[2]->x() + action_views[2]->width(), menu_button->x());
}
// Tests that when an extension is reloaded it remains visible in the toolbar
// and extensions menu.
TEST_F(ExtensionsMenuViewUnitTest, ReloadExtension) {
// The extension must have a manifest to be reloaded.
extensions::TestExtensionDir extension_directory;
constexpr char kManifest[] = R"({
"name": "Test",
"version": "1",
"manifest_version": 2
})";
extension_directory.WriteManifest(kManifest);
extensions::ChromeTestExtensionLoader loader(profile());
scoped_refptr<const extensions::Extension> extension =
loader.LoadExtension(extension_directory.UnpackedPath());
// Force the menu to re-layout, since a new item was added.
LayoutMenuIfNecessary();
ASSERT_EQ(1u, extensions_menu()->extensions_menu_items_for_testing().size());
{
ExtensionMenuItemView* menu_item = GetOnlyMenuItem();
ClickPinButton(menu_item);
EXPECT_TRUE(
extensions_container()->IsActionVisibleOnToolbar(extension->id()));
// |menu_item| will not be valid after the extension reloads.
}
extensions::TestExtensionRegistryObserver registry_observer(
extensions::ExtensionRegistry::Get(profile()));
ReloadExtension(extension->id());
ASSERT_TRUE(registry_observer.WaitForExtensionLoaded());
LayoutMenuIfNecessary();
ASSERT_EQ(1u, extensions_menu()->extensions_menu_items_for_testing().size());
EXPECT_TRUE(
extensions_container()->IsActionVisibleOnToolbar(extension->id()));
}
// Tests that a when an extension is reloaded with manifest errors, and
// therefore fails to be loaded into Chrome, it's removed from the toolbar and
// extensions menu.
TEST_F(ExtensionsMenuViewUnitTest, ReloadExtensionFailed) {
extensions::TestExtensionDir extension_directory;
constexpr char kManifest[] = R"({
"name": "Test",
"version": "1",
"manifest_version": 2
})";
extension_directory.WriteManifest(kManifest);
extensions::ChromeTestExtensionLoader loader(profile());
scoped_refptr<const extensions::Extension> extension =
loader.LoadExtension(extension_directory.UnpackedPath());
LayoutMenuIfNecessary();
ExtensionMenuItemView* menu_item = GetOnlyMenuItem();
ASSERT_TRUE(menu_item);
ClickPinButton(menu_item);
// Replace the extension's valid manifest with one containing errors. In this
// case, the error is that both the 'browser_action' and 'page_action' keys
// are specified instead of only one.
constexpr char kManifestWithErrors[] = R"({
"name": "Test",
"version": "1",
"manifest_version": 2,
"page_action" : {},
"browser_action" : {}
})";
extension_directory.WriteManifest(kManifestWithErrors);
// Reload the extension. It should fail due to the manifest errors.
extension_registrar()->ReloadExtensionWithQuietFailure(extension->id());
base::RunLoop().RunUntilIdle();
// Since the extension is removed it's no longer visible on the toolbar or in
// the menu.
for (views::View* child : extensions_container()->children()) {
EXPECT_FALSE(views::IsViewClass<ToolbarActionView>(child));
}
EXPECT_EQ(0u, extensions_menu()->extensions_menu_items_for_testing().size());
}
TEST_F(ExtensionsMenuViewUnitTest, PinButtonUserActionWithAccessibility) {
base::UserActionTester user_action_tester;
InstallExtensionAndLayout("Test Extension");
ExtensionMenuItemView* menu_item = GetOnlyMenuItem();
ASSERT_NE(nullptr, menu_item);
views::test::AXEventCounter counter(views::AXUpdateNotifier::Get());
constexpr char kPinButtonUserAction[] = "Extensions.Toolbar.PinButtonPressed";
// Verify behavior before pin, after pin, and after unpin.
for (int i = 0; i < 3; i++) {
EXPECT_EQ(i, user_action_tester.GetActionCount(kPinButtonUserAction));
#if BUILDFLAG(IS_MAC)
// TODO(crbug.com/40670141): No Mac animations in unit tests cause errors.
#else
EXPECT_EQ(i, counter.GetCount(ax::mojom::Event::kAlert));
EXPECT_EQ(i, counter.GetCount(ax::mojom::Event::kTextChanged));
#endif
ClickPinButton(menu_item);
}
}
TEST_F(ExtensionsMenuViewUnitTest, WindowTitle) {
InstallExtensionAndLayout("Test Extension");
ExtensionsMenuView* const menu_view = extensions_menu();
EXPECT_FALSE(menu_view->GetWindowTitle().empty());
EXPECT_TRUE(menu_view->GetAccessibleWindowTitle().empty());
}
// TODO(crbug.com/40636292): When supported, add a test to verify the
// ExtensionsToolbarContainer shrinks when the window is too small to show all
// pinned extensions.
// TODO(crbug.com/40636292): When supported, add a test to verify an extension
// is shown when a bubble pops up and needs to draw attention to it.
|