1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314
|
// Copyright 2021 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ui/views/extensions/extensions_toolbar_container.h"
#include <algorithm>
#include <string>
#include "base/json/json_reader.h"
#include "base/strings/stringprintf.h"
#include "base/test/metrics/user_action_tester.h"
#include "chrome/browser/extensions/chrome_test_extension_loader.h"
#include "chrome/browser/extensions/extension_action_runner.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/extension_tab_util.h"
#include "chrome/browser/ui/toolbar/toolbar_action_view_controller.h"
#include "chrome/browser/ui/views/extensions/extensions_dialogs_utils.h"
#include "chrome/browser/ui/views/extensions/extensions_toolbar_button.h"
#include "chrome/browser/ui/views/extensions/extensions_toolbar_unittest.h"
#include "components/sync_preferences/testing_pref_service_syncable.h"
#include "extensions/browser/pref_names.h"
#include "extensions/browser/test_extension_registry_observer.h"
#include "extensions/common/extension_features.h"
#include "extensions/common/extension_id.h"
#include "extensions/test/permissions_manager_waiter.h"
#include "extensions/test/test_extension_dir.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "ui/base/dragdrop/drag_drop_types.h"
#include "ui/base/dragdrop/mojom/drag_drop_types.mojom.h"
#include "ui/views/accessibility/view_accessibility.h"
namespace {
using SitePermissionsHelper = extensions::SitePermissionsHelper;
using PermissionsManager = extensions::PermissionsManager;
// TODO(crbug.com/40916158): Same as permission's ChipController. Pull out to a
// shared location.
base::TimeDelta kConfirmationDisplayDuration = base::Seconds(4);
// A scoper that manages a Browser instance created by BrowserWithTestWindowTest
// beyond the default instance it creates in SetUp.
class AdditionalBrowser {
public:
explicit AdditionalBrowser(std::unique_ptr<Browser> browser)
: browser_(std::move(browser)),
browser_view_(BrowserView::GetBrowserViewForBrowser(browser_.get())) {}
~AdditionalBrowser() {
// Tear down `browser_`, similar to TestWithBrowserView::TearDown.
browser_.release();
browser_view_->GetWidget()->CloseNow();
}
ExtensionsToolbarContainer* extensions_container() {
return browser_view_->toolbar()->extensions_container();
}
private:
std::unique_ptr<Browser> browser_;
raw_ptr<BrowserView, DanglingUntriaged> browser_view_;
};
} // namespace
class ExtensionsToolbarContainerUnitTest : public ExtensionsToolbarUnitTest {
public:
ExtensionsToolbarContainerUnitTest();
~ExtensionsToolbarContainerUnitTest() override = default;
ExtensionsToolbarContainerUnitTest(
const ExtensionsToolbarContainerUnitTest&) = delete;
ExtensionsToolbarContainerUnitTest& operator=(
const ExtensionsToolbarContainerUnitTest&) = delete;
// Navigates to `url`.
void NavigateAndCommit(const GURL& URL);
// Returns the view of the given `extension_id` if the extension is currently
// pinned.
ToolbarActionView* GetPinnedExtensionView(
const extensions::ExtensionId& extension_id);
// Returns whether the request access button is visible or not.
bool IsRequestAccessButtonVisible();
// ExtensionsToolbarUnitTest:
void SetUp() override;
private:
base::test::ScopedFeatureList scoped_feature_list_;
raw_ptr<content::WebContentsTester, DanglingUntriaged> web_contents_tester_;
};
ExtensionsToolbarContainerUnitTest::ExtensionsToolbarContainerUnitTest()
: ExtensionsToolbarUnitTest(
base::test::TaskEnvironment::TimeSource::MOCK_TIME) {
scoped_feature_list_.InitAndEnableFeature(
extensions_features::kExtensionsMenuAccessControl);
}
void ExtensionsToolbarContainerUnitTest::NavigateAndCommit(const GURL& url) {
web_contents_tester_->NavigateAndCommit(url);
WaitForAnimation();
}
ToolbarActionView* ExtensionsToolbarContainerUnitTest::GetPinnedExtensionView(
const extensions::ExtensionId& extension_id) {
std::vector<ToolbarActionView*> actions = GetPinnedExtensionViews();
auto it =
std::ranges::find(actions, extension_id, [](ToolbarActionView* action) {
return action->view_controller()->GetId();
});
if (it == actions.end()) {
return nullptr;
}
return *it;
}
bool ExtensionsToolbarContainerUnitTest::IsRequestAccessButtonVisible() {
return request_access_button()->GetVisible();
}
void ExtensionsToolbarContainerUnitTest::SetUp() {
ExtensionsToolbarUnitTest::SetUp();
web_contents_tester_ = AddWebContentsAndGetTester();
}
TEST_F(ExtensionsToolbarContainerUnitTest, ReorderPinnedExtensions) {
constexpr char kExtensionAName[] = "A Extension";
auto extensionA = InstallExtension(kExtensionAName);
constexpr char kExtensionBName[] = "B Extension";
auto extensionB = InstallExtension(kExtensionBName);
constexpr char kExtensionCName[] = "C Extension";
auto extensionC = InstallExtension(kExtensionCName);
auto* toolbar_model = ToolbarActionsModel::Get(profile());
ASSERT_TRUE(toolbar_model);
toolbar_model->SetActionVisibility(extensionA->id(), true);
toolbar_model->SetActionVisibility(extensionB->id(), true);
toolbar_model->SetActionVisibility(extensionC->id(), true);
WaitForAnimation();
// Verify the order is A, B, C.
EXPECT_THAT(
GetPinnedExtensionNames(),
testing::ElementsAre(kExtensionAName, kExtensionBName, kExtensionCName));
// Simulate dragging extension C to the first slot.
ToolbarActionView* drag_view = GetPinnedExtensionView(extensionC->id());
EXPECT_TRUE(extensions_container()->CanStartDragForView(
drag_view, gfx::Point(), gfx::Point()));
ui::OSExchangeData drag_data;
extensions_container()->WriteDragDataForView(drag_view, gfx::Point(),
&drag_data);
gfx::PointF drop_point(GetPinnedExtensionView(extensionA->id())->origin());
ui::DropTargetEvent drop_event(drag_data, drop_point, drop_point,
ui::DragDropTypes::DRAG_MOVE);
extensions_container()->OnDragUpdated(drop_event);
auto drop_cb = extensions_container()->GetDropCallback(drop_event);
ui::mojom::DragOperation output_drag_op = ui::mojom::DragOperation::kNone;
std::move(drop_cb).Run(drop_event, output_drag_op,
/*drag_image_layer_owner=*/nullptr);
WaitForAnimation();
// Verify the new order is C, A, B.
EXPECT_THAT(
GetPinnedExtensionNames(),
testing::ElementsAre(kExtensionCName, kExtensionAName, kExtensionBName));
}
TEST_F(ExtensionsToolbarContainerUnitTest, ForcePinnedExtensionsCannotReorder) {
constexpr char kExtensionAName[] = "A Extension";
auto extensionA = InstallExtension(kExtensionAName);
constexpr char kExtensionBName[] = "B Extension";
auto extensionB = InstallExtension(kExtensionBName);
constexpr char kExtensionCName[] = "C Extension";
auto extensionC = InstallExtension(kExtensionCName);
auto* toolbar_model = ToolbarActionsModel::Get(profile());
ASSERT_TRUE(toolbar_model);
toolbar_model->SetActionVisibility(extensionA->id(), true);
toolbar_model->SetActionVisibility(extensionB->id(), true);
toolbar_model->SetActionVisibility(extensionC->id(), true);
WaitForAnimation();
// Make Extension C force-pinned, as if it was controlled by the
// ExtensionSettings policy.
std::string json = base::StringPrintf(
R"({
"%s": {
"toolbar_pin": "force_pinned"
}
})",
extensionC->id().c_str());
std::optional<base::Value> settings = base::JSONReader::Read(json);
ASSERT_TRUE(settings.has_value());
profile()->GetTestingPrefService()->SetManagedPref(
extensions::pref_names::kExtensionManagement,
base::Value::ToUniquePtrValue(std::move(settings.value())));
// Verify the order is A, B, C.
EXPECT_THAT(
GetPinnedExtensionNames(),
testing::ElementsAre(kExtensionAName, kExtensionBName, kExtensionCName));
EXPECT_TRUE(toolbar_model->IsActionForcePinned(extensionC->id()));
// Force-pinned extension should not be draggable.
ToolbarActionView* drag_view = GetPinnedExtensionView(extensionC->id());
EXPECT_FALSE(extensions_container()->CanStartDragForView(
drag_view, gfx::Point(), gfx::Point()));
}
// Tests that when an extension is reloaded it remains visible in the toolbar.
TEST_F(ExtensionsToolbarContainerUnitTest, ReloadExtensionKeepsPinnedState) {
// The extension must have a manifest to be reloaded.
extensions::TestExtensionDir extension_directory;
constexpr char kManifest[] = R"({
"name": "Test Extension",
"version": "1",
"manifest_version": 3
})";
extension_directory.WriteManifest(kManifest);
extensions::ChromeTestExtensionLoader loader(profile());
scoped_refptr<const extensions::Extension> extension =
loader.LoadExtension(extension_directory.UnpackedPath());
// By default, extension on installation is unpinned.
EXPECT_FALSE(
extensions_container()->IsActionVisibleOnToolbar(extension->id()));
// Pin extension and verify it is visible on the toolbar.
auto* toolbar_model = ToolbarActionsModel::Get(profile());
ASSERT_TRUE(toolbar_model);
toolbar_model->SetActionVisibility(extension->id(), true);
EXPECT_TRUE(
extensions_container()->IsActionVisibleOnToolbar(extension->id()));
// Reload the extension.
extensions::TestExtensionRegistryObserver registry_observer(
extensions::ExtensionRegistry::Get(profile()));
ReloadExtension(extension->id());
ASSERT_TRUE(registry_observer.WaitForExtensionLoaded());
WaitForAnimation();
// Verify the extension is visible on the toolbar.
EXPECT_TRUE(
extensions_container()->IsActionVisibleOnToolbar(extension->id()));
}
// Tests that a when an extension is reloaded with manifest errors, and
// therefore fails to be loaded into Chrome, it's removed from the toolbar.
TEST_F(ExtensionsToolbarContainerUnitTest, ReloadExtensionFailed) {
extensions::TestExtensionDir extension_directory;
constexpr char kManifest[] = R"({
"name": "Test Extension",
"version": "1",
"manifest_version": 3
})";
extension_directory.WriteManifest(kManifest);
extensions::ChromeTestExtensionLoader loader(profile());
scoped_refptr<const extensions::Extension> extension =
loader.LoadExtension(extension_directory.UnpackedPath());
// By default, extension on installation is unpinned.
EXPECT_FALSE(
extensions_container()->IsActionVisibleOnToolbar(extension->id()));
// Pin extension and verify it is visible on the toolbar.
auto* toolbar_model = ToolbarActionsModel::Get(profile());
ASSERT_TRUE(toolbar_model);
toolbar_model->SetActionVisibility(extension->id(), true);
EXPECT_TRUE(
extensions_container()->IsActionVisibleOnToolbar(extension->id()));
// Replace the extension's valid manifest with one containing errors. In this
// case, 'version' keys is missing.
constexpr char kManifestWithErrors[] = R"({
"name": "Test",
"manifest_version": 3,
})";
extension_directory.WriteManifest(kManifestWithErrors);
// Reload the extension. It should fail due to the manifest errors.
extension_registrar()->ReloadExtensionWithQuietFailure(extension->id());
base::RunLoop().RunUntilIdle();
WaitForAnimation();
// Verify the extension is no longer visible on the toolbar.
EXPECT_FALSE(
extensions_container()->IsActionVisibleOnToolbar(extension->id()));
}
TEST_F(ExtensionsToolbarContainerUnitTest,
PinnedExtensionAppearsInAnotherWindow) {
const std::string& extension_id = InstallExtension("Extension")->id();
AdditionalBrowser browser2(
CreateBrowser(browser()->profile(), browser()->type(),
/* hosted_app */ false, /* browser_window */ nullptr));
// Verify extension is unpinned in both windows.
EXPECT_FALSE(extensions_container()->IsActionVisibleOnToolbar(extension_id));
EXPECT_FALSE(
browser2.extensions_container()->IsActionVisibleOnToolbar(extension_id));
// Pin extension in one window.
auto* toolbar_model = ToolbarActionsModel::Get(profile());
ASSERT_TRUE(toolbar_model);
toolbar_model->SetActionVisibility(extension_id, true);
// Both windows open get the pinned extension.
EXPECT_TRUE(extensions_container()->IsActionVisibleOnToolbar(extension_id));
EXPECT_TRUE(
browser2.extensions_container()->IsActionVisibleOnToolbar(extension_id));
AdditionalBrowser browser3(
CreateBrowser(browser()->profile(), browser()->type(),
/* hosted_app */ false, /* browser_window */ nullptr));
// Brand-new window also gets the pinned extension.
EXPECT_TRUE(
browser3.extensions_container()->IsActionVisibleOnToolbar(extension_id));
}
TEST_F(ExtensionsToolbarContainerUnitTest,
PinnedExtensionsReorderOnPrefChange) {
constexpr char kExtensionAName[] = "A Extension";
auto extensionA = InstallExtension(kExtensionAName);
constexpr char kExtensionBName[] = "B Extension";
auto extensionB = InstallExtension(kExtensionBName);
constexpr char kExtensionCName[] = "C Extension";
auto extensionC = InstallExtension(kExtensionCName);
auto* toolbar_model = ToolbarActionsModel::Get(profile());
ASSERT_TRUE(toolbar_model);
toolbar_model->SetActionVisibility(extensionA->id(), true);
toolbar_model->SetActionVisibility(extensionB->id(), true);
toolbar_model->SetActionVisibility(extensionC->id(), true);
WaitForAnimation();
// Verify the order is A, B, C.
EXPECT_THAT(
GetPinnedExtensionNames(),
testing::ElementsAre(kExtensionAName, kExtensionBName, kExtensionCName));
// Set the order using prefs.
extensions::ExtensionPrefs::Get(profile())->SetPinnedExtensions(
{extensionB->id(), extensionC->id(), extensionA->id()});
WaitForAnimation();
// Verify the new order is B, C, A.
EXPECT_THAT(
GetPinnedExtensionNames(),
testing::ElementsAre(kExtensionBName, kExtensionCName, kExtensionAName));
}
TEST_F(ExtensionsToolbarContainerUnitTest, RunDropCallback) {
constexpr char kExtensionAName[] = "A Extension";
auto extensionA = InstallExtension(kExtensionAName);
constexpr char kExtensionBName[] = "B Extension";
auto extensionB = InstallExtension(kExtensionBName);
constexpr char kExtensionCName[] = "C Extension";
auto extensionC = InstallExtension(kExtensionCName);
auto* toolbar_model = ToolbarActionsModel::Get(profile());
ASSERT_TRUE(toolbar_model);
toolbar_model->SetActionVisibility(extensionA->id(), true);
toolbar_model->SetActionVisibility(extensionB->id(), true);
toolbar_model->SetActionVisibility(extensionC->id(), true);
WaitForAnimation();
EXPECT_THAT(
GetPinnedExtensionNames(),
testing::ElementsAre(kExtensionAName, kExtensionBName, kExtensionCName));
// Simulate dragging extension C to the first slot.
ToolbarActionView* drag_view = GetPinnedExtensionView(extensionC->id());
EXPECT_TRUE(extensions_container()->CanStartDragForView(
drag_view, gfx::Point(), gfx::Point()));
ui::OSExchangeData drag_data;
extensions_container()->WriteDragDataForView(drag_view, gfx::Point(),
&drag_data);
gfx::PointF drop_point(GetPinnedExtensionView(extensionA->id())->origin());
ui::DropTargetEvent drop_event(drag_data, drop_point, drop_point,
ui::DragDropTypes::DRAG_MOVE);
extensions_container()->OnDragUpdated(drop_event);
auto cb = extensions_container()->GetDropCallback(drop_event);
ui::mojom::DragOperation output_drag_op = ui::mojom::DragOperation::kNone;
std::move(cb).Run(drop_event, output_drag_op,
/*drag_image_layer_owner=*/nullptr);
WaitForAnimation();
EXPECT_THAT(
GetPinnedExtensionNames(),
testing::ElementsAre(kExtensionCName, kExtensionAName, kExtensionBName));
EXPECT_EQ(output_drag_op, ui::mojom::DragOperation::kMove);
}
TEST_F(ExtensionsToolbarContainerUnitTest, ResetDropCallback) {
constexpr char kExtensionAName[] = "A Extension";
auto extensionA = InstallExtension(kExtensionAName);
constexpr char kExtensionBName[] = "B Extension";
auto extensionB = InstallExtension(kExtensionBName);
constexpr char kExtensionCName[] = "C Extension";
auto extensionC = InstallExtension(kExtensionCName);
auto* toolbar_model = ToolbarActionsModel::Get(profile());
ASSERT_TRUE(toolbar_model);
toolbar_model->SetActionVisibility(extensionA->id(), true);
toolbar_model->SetActionVisibility(extensionB->id(), true);
toolbar_model->SetActionVisibility(extensionC->id(), true);
WaitForAnimation();
EXPECT_THAT(
GetPinnedExtensionNames(),
testing::ElementsAre(kExtensionAName, kExtensionBName, kExtensionCName));
// Simulate dragging "C Extension" to the first slot.
ToolbarActionView* drag_view = GetPinnedExtensionView(extensionC->id());
EXPECT_TRUE(extensions_container()->CanStartDragForView(
drag_view, gfx::Point(), gfx::Point()));
ui::OSExchangeData drag_data;
extensions_container()->WriteDragDataForView(drag_view, gfx::Point(),
&drag_data);
gfx::PointF drop_point(GetPinnedExtensionView(extensionA->id())->origin());
ui::DropTargetEvent drop_event(drag_data, drop_point, drop_point,
ui::DragDropTypes::DRAG_MOVE);
extensions_container()->OnDragUpdated(drop_event);
auto cb = extensions_container()->GetDropCallback(drop_event);
WaitForAnimation();
EXPECT_THAT(
GetPinnedExtensionNames(),
testing::ElementsAre(kExtensionCName, kExtensionAName, kExtensionBName));
// If the drop callback is reset (and never invoked), the drag should be
// aborted, and items should be back in their original order.
cb.Reset();
WaitForAnimation();
EXPECT_THAT(
GetPinnedExtensionNames(),
testing::ElementsAre(kExtensionAName, kExtensionBName, kExtensionCName));
}
TEST_F(ExtensionsToolbarContainerUnitTest,
InvalidateDropCallbackOnActionAdded) {
constexpr char kExtensionAName[] = "A Extension";
auto extensionA = InstallExtension(kExtensionAName);
constexpr char kExtensionBName[] = "B Extension";
auto extensionB = InstallExtension(kExtensionBName);
auto* toolbar_model = ToolbarActionsModel::Get(profile());
ASSERT_TRUE(toolbar_model);
toolbar_model->SetActionVisibility(extensionA->id(), true);
toolbar_model->SetActionVisibility(extensionB->id(), true);
WaitForAnimation();
EXPECT_THAT(GetPinnedExtensionNames(),
testing::ElementsAre(kExtensionAName, kExtensionBName));
// Simulate dragging extension B to the first slot.
ToolbarActionView* drag_view = GetPinnedExtensionView(extensionB->id());
EXPECT_TRUE(extensions_container()->CanStartDragForView(
drag_view, gfx::Point(), gfx::Point()));
ui::OSExchangeData drag_data;
extensions_container()->WriteDragDataForView(drag_view, gfx::Point(),
&drag_data);
gfx::PointF drop_point(GetPinnedExtensionView(extensionA->id())->origin());
ui::DropTargetEvent drop_event(drag_data, drop_point, drop_point,
ui::DragDropTypes::DRAG_MOVE);
extensions_container()->OnDragUpdated(drop_event);
auto cb = extensions_container()->GetDropCallback(drop_event);
WaitForAnimation();
EXPECT_THAT(GetPinnedExtensionNames(),
testing::ElementsAre(kExtensionBName, kExtensionAName));
constexpr char kExtensionCName[] = "C Extension";
auto extensionC = InstallExtension(kExtensionCName);
toolbar_model->SetActionVisibility(extensionC->id(), true);
WaitForAnimation();
// The drop callback should be invalidated, and items should be back in their
// original order.
ui::mojom::DragOperation output_drag_op = ui::mojom::DragOperation::kNone;
std::move(cb).Run(drop_event, output_drag_op,
/*drag_image_layer_owner=*/nullptr);
WaitForAnimation();
EXPECT_THAT(
GetPinnedExtensionNames(),
testing::ElementsAre(kExtensionAName, kExtensionBName, kExtensionCName));
}
// Tests reordering pinned actions with MovePinnedActionsBy().
TEST_F(ExtensionsToolbarContainerUnitTest, TestMovePinnedActionBy) {
constexpr char kExtensionAName[] = "A Extension";
auto extensionA = InstallExtension(kExtensionAName);
constexpr char kExtensionBName[] = "B Extension";
auto extensionB = InstallExtension(kExtensionBName);
constexpr char kExtensionCName[] = "C Extension";
auto extensionC = InstallExtension(kExtensionCName);
auto* toolbar_model = ToolbarActionsModel::Get(profile());
ASSERT_TRUE(toolbar_model);
toolbar_model->SetActionVisibility(extensionA->id(), true);
toolbar_model->SetActionVisibility(extensionB->id(), true);
toolbar_model->SetActionVisibility(extensionC->id(), true);
WaitForAnimation();
EXPECT_THAT(
GetPinnedExtensionNames(),
testing::ElementsAre(kExtensionAName, kExtensionBName, kExtensionCName));
// Simulate moving "A" by -1. Nothing should change.
extensions_container()->MovePinnedActionBy(extensionA->id(), -1);
EXPECT_THAT(
GetPinnedExtensionNames(),
testing::ElementsAre(kExtensionAName, kExtensionBName, kExtensionCName));
// Simulate moving "C" by 1. Nothing should change.
extensions_container()->MovePinnedActionBy(extensionC->id(), 1);
EXPECT_THAT(
GetPinnedExtensionNames(),
testing::ElementsAre(kExtensionAName, kExtensionBName, kExtensionCName));
// Now, move A by 1. The order should be B, A, C.
extensions_container()->MovePinnedActionBy(extensionA->id(), 1);
EXPECT_THAT(
GetPinnedExtensionNames(),
testing::ElementsAre(kExtensionBName, kExtensionAName, kExtensionCName));
// Move A by 1 more. The order should be B, C, A.
extensions_container()->MovePinnedActionBy(extensionA->id(), 1);
EXPECT_THAT(
GetPinnedExtensionNames(),
testing::ElementsAre(kExtensionBName, kExtensionCName, kExtensionAName));
// Move A back by one. Now, B, A, C.
extensions_container()->MovePinnedActionBy(extensionA->id(), -1);
EXPECT_THAT(
GetPinnedExtensionNames(),
testing::ElementsAre(kExtensionBName, kExtensionAName, kExtensionCName));
// And back once more. Back to A, B, C.
extensions_container()->MovePinnedActionBy(extensionA->id(), -1);
EXPECT_THAT(
GetPinnedExtensionNames(),
testing::ElementsAre(kExtensionAName, kExtensionBName, kExtensionCName));
}
// ToolbarActionsModel::MovePinnedAction crashes if pinned extensions changes
// while the drop callback isn't invalidated. This test makes sure this doesn't
// happen anymore. https://crbug.com/1268239.
TEST_F(ExtensionsToolbarContainerUnitTest, InvalidateDropCallbackOnPrefChange) {
constexpr char kExtensionAName[] = "A Extension";
auto extensionA = InstallExtension(kExtensionAName);
constexpr char kExtensionBName[] = "B Extension";
auto extensionB = InstallExtension(kExtensionBName);
auto* toolbar_model = ToolbarActionsModel::Get(profile());
ASSERT_TRUE(toolbar_model);
toolbar_model->SetActionVisibility(extensionA->id(), true);
toolbar_model->SetActionVisibility(extensionB->id(), true);
WaitForAnimation();
EXPECT_THAT(GetPinnedExtensionNames(),
testing::ElementsAre(kExtensionAName, kExtensionBName));
// Simulate dragging extension B to the first slot.
ToolbarActionView* drag_view = GetPinnedExtensionView(extensionB->id());
EXPECT_TRUE(extensions_container()->CanStartDragForView(
drag_view, gfx::Point(), gfx::Point()));
ui::OSExchangeData drag_data;
extensions_container()->WriteDragDataForView(drag_view, gfx::Point(),
&drag_data);
gfx::PointF drop_point(GetPinnedExtensionView(extensionA->id())->origin());
ui::DropTargetEvent drop_event(drag_data, drop_point, drop_point,
ui::DragDropTypes::DRAG_MOVE);
extensions_container()->OnDragUpdated(drop_event);
auto cb = extensions_container()->GetDropCallback(drop_event);
WaitForAnimation();
EXPECT_THAT(GetPinnedExtensionNames(),
testing::ElementsAre(kExtensionBName, kExtensionAName));
extensions::ExtensionPrefs::Get(profile())->SetPinnedExtensions({});
WaitForAnimation();
// The drop callback should be invalidated, and items should be back in their
// original order.
ui::mojom::DragOperation output_drag_op = ui::mojom::DragOperation::kNone;
std::move(cb).Run(drop_event, output_drag_op,
/*drag_image_layer_owner=*/nullptr);
WaitForAnimation();
EXPECT_THAT(GetPinnedExtensionNames(), testing::ElementsAre());
}
// Test that the extension button state changes after site permissions updates.
TEST_F(ExtensionsToolbarContainerUnitTest,
ExtensionsButton_SitePermissionsUpdates) {
// Install an extension that requests host permissions.
auto extension =
InstallExtensionWithHostPermissions("Extension", {"<all_urls>"});
const GURL url("http://www.url.com");
auto url_origin = url::Origin::Create(url);
NavigateAndCommit(url);
auto* manager = extensions::PermissionsManager::Get(profile());
{
// Extensions button has "all extensions blocked" icon type when it's
// an user restricted site.
extensions::PermissionsManagerWaiter manager_waiter(manager);
manager->AddUserRestrictedSite(url_origin);
manager_waiter.WaitForUserPermissionsSettingsChange();
WaitForAnimation();
EXPECT_EQ(extensions_button()->state(),
ExtensionsToolbarButton::State::kAllExtensionsBlocked);
}
{
// Extensions button has "any extension has access" icon type when it's not
// an user restricted site and 1+ extensions have
// site access granted. Note that by default extensions have granted access.
extensions::PermissionsManagerWaiter manager_waiter(manager);
manager->RemoveUserRestrictedSite(url_origin);
manager_waiter.WaitForUserPermissionsSettingsChange();
WaitForAnimation();
EXPECT_EQ(extensions_button()->state(),
ExtensionsToolbarButton::State::kAnyExtensionHasAccess);
}
{
// Extension button has "default" icon type when it's not an user restricted
// site and no extensions have site access granted.
// To achieve this, we withhold host permissions in the only extension
// installed.
WithholdHostPermissions(extension.get());
WaitForAnimation();
EXPECT_EQ(extensions_button()->state(),
ExtensionsToolbarButton::State::kDefault);
}
}
// Test that the extension button state takes into account chrome restricted
// sites.
TEST_F(ExtensionsToolbarContainerUnitTest,
ExtensionsButton_ChromeRestrictedSite) {
InstallExtensionWithHostPermissions("Extension", {"<all_urls>"});
const GURL restricted_url("chrome://extensions");
NavigateAndCommit(restricted_url);
// Extensions button has "all extensions blocked" icon type for chrome
// restricted sites.
EXPECT_EQ(extensions_button()->state(),
ExtensionsToolbarButton::State::kAllExtensionsBlocked);
}
// Tests that extensions appear in the request access button iff they have a
// site access request.
TEST_F(ExtensionsToolbarContainerUnitTest, RequestAccessButton_Extensions) {
auto extension_A =
InstallExtensionWithPermissions("Extension A", {"activeTab"});
auto extension_B =
InstallExtensionWithHostPermissions("Extension B", {"*://www.b.com/*"});
auto extension_C =
InstallExtensionWithHostPermissions("Extension C", {"<all_urls>"});
WithholdHostPermissions(extension_B.get());
WithholdHostPermissions(extension_C.get());
// Navigate to a site only explicitly requested by extension C. Verify
// request access button is not visible, since no extension has added a
// request.
NavigateAndCommit(GURL("http://www.other.com"));
EXPECT_FALSE(IsRequestAccessButtonVisible());
// Add a site access request for extension A and verify it's not visible on
// the request access button since extensions with only activeTab can't add a
// request.
AddHostAccessRequest(*extension_A,
browser()->tab_strip_model()->GetActiveWebContents());
EXPECT_FALSE(IsRequestAccessButtonVisible());
// Add a site access request for extension B and verify it's not visible on
// the request access button since extension didn't request access for the
// current site.
AddHostAccessRequest(*extension_B,
browser()->tab_strip_model()->GetActiveWebContents());
EXPECT_FALSE(IsRequestAccessButtonVisible());
// Add a site access request for extension C and verify it's visible on the
// request access button.
AddHostAccessRequest(*extension_C,
browser()->tab_strip_model()->GetActiveWebContents());
EXPECT_TRUE(IsRequestAccessButtonVisible());
EXPECT_THAT(request_access_button()->GetExtensionIdsForTesting(),
testing::ElementsAre(extension_C->id()));
// Navigate to a site only explicitly requested by extension B and C. Verify
// request access button is not visible, since requests are reset on
// cross-origin navigations.
NavigateAndCommit(GURL("http://www.b.com"));
EXPECT_FALSE(IsRequestAccessButtonVisible());
// Add a site access request for extension B and verify it's visible on
// the request access button.
AddHostAccessRequest(*extension_B,
browser()->tab_strip_model()->GetActiveWebContents());
EXPECT_TRUE(IsRequestAccessButtonVisible());
EXPECT_THAT(request_access_button()->GetExtensionIdsForTesting(),
testing::ElementsAre(extension_B->id()));
// Add a site access request for extension C and verify it's visible on the
// request access button.
AddHostAccessRequest(*extension_C,
browser()->tab_strip_model()->GetActiveWebContents());
EXPECT_TRUE(IsRequestAccessButtonVisible());
EXPECT_THAT(request_access_button()->GetExtensionIdsForTesting(),
testing::ElementsAre(extension_B->id(), extension_C->id()));
// Remove the site access request for extension B and verify only extension
// C is visible on the request access button.
RemoveHostAccessRequest(*extension_B,
browser()->tab_strip_model()->GetActiveWebContents());
EXPECT_TRUE(IsRequestAccessButtonVisible());
EXPECT_THAT(request_access_button()->GetExtensionIdsForTesting(),
testing::ElementsAre(extension_C->id()));
// Remove the site access request for extension C and verify request access
// button is not visible.
RemoveHostAccessRequest(*extension_C,
browser()->tab_strip_model()->GetActiveWebContents());
EXPECT_FALSE(IsRequestAccessButtonVisible());
}
TEST_F(ExtensionsToolbarContainerUnitTest, RequestAccessButton_TooltipText) {
auto extension_A = InstallExtensionWithHostPermissions(
"Extension A", {"*://www.example.com/*"});
auto extension_B =
InstallExtensionWithHostPermissions("Extension B", {"<all_urls>"});
WithholdHostPermissions(extension_A.get());
WithholdHostPermissions(extension_B.get());
// Navigate to a site and verify request access button is not visible, since
// no extension has added a request.
NavigateAndCommit(GURL("http://www.example.com"));
auto* web_contents = browser()->tab_strip_model()->GetActiveWebContents();
EXPECT_FALSE(IsRequestAccessButtonVisible());
// Add site access requests for both extensions and verify they are visible
// on the request access button.
AddHostAccessRequest(*extension_A, web_contents);
AddHostAccessRequest(*extension_B, web_contents);
EXPECT_TRUE(IsRequestAccessButtonVisible());
EXPECT_THAT(request_access_button()->GetExtensionIdsForTesting(),
testing::ElementsAre(extension_A->id(), extension_B->id()));
std::u16string current_site = GetCurrentHost(web_contents);
std::u16string expected_tooltip =
l10n_util::GetStringFUTF16(
IDS_EXTENSIONS_REQUEST_ACCESS_BUTTON_TOOLTIP_MULTIPLE_EXTENSIONS,
current_site) +
u"\n" + u"Extension A\n" + u"Extension B";
EXPECT_EQ(request_access_button()->GetRenderedTooltipText(gfx::Point()),
expected_tooltip);
RemoveHostAccessRequest(*extension_B,
browser()->tab_strip_model()->GetActiveWebContents());
expected_tooltip =
l10n_util::GetStringFUTF16(
IDS_EXTENSIONS_REQUEST_ACCESS_BUTTON_TOOLTIP_MULTIPLE_EXTENSIONS,
current_site) +
u"\n" + u"Extension A";
EXPECT_EQ(request_access_button()->GetRenderedTooltipText(gfx::Point()),
expected_tooltip);
}
TEST_F(ExtensionsToolbarContainerUnitTest,
RequestAccessButton_TooltipTextAccessibility) {
auto extension_A = InstallExtensionWithHostPermissions(
"Extension A", {"*://www.example.com/*"});
auto extension_B =
InstallExtensionWithHostPermissions("Extension B", {"<all_urls>"});
WithholdHostPermissions(extension_A.get());
WithholdHostPermissions(extension_B.get());
// Navigate to a site and verify request access button is not visible, since
// no extension has added a request.
NavigateAndCommit(GURL("http://www.example.com"));
auto* web_contents = browser()->tab_strip_model()->GetActiveWebContents();
EXPECT_FALSE(IsRequestAccessButtonVisible());
// Add site access requests for both extensions and verify they are visible
// on the request access button.
AddHostAccessRequest(*extension_A, web_contents);
AddHostAccessRequest(*extension_B, web_contents);
EXPECT_TRUE(IsRequestAccessButtonVisible());
EXPECT_THAT(request_access_button()->GetExtensionIdsForTesting(),
testing::ElementsAre(extension_A->id(), extension_B->id()));
ui::AXNodeData data;
request_access_button()->GetViewAccessibility().GetAccessibleNodeData(&data);
EXPECT_NE(data.GetString16Attribute(ax::mojom::StringAttribute::kName),
request_access_button()->GetRenderedTooltipText(gfx::Point()));
EXPECT_EQ(data.GetString16Attribute(ax::mojom::StringAttribute::kDescription),
request_access_button()->GetRenderedTooltipText(gfx::Point()));
RemoveHostAccessRequest(*extension_B,
browser()->tab_strip_model()->GetActiveWebContents());
data = ui::AXNodeData();
request_access_button()->GetViewAccessibility().GetAccessibleNodeData(&data);
EXPECT_NE(data.GetString16Attribute(ax::mojom::StringAttribute::kName),
request_access_button()->GetRenderedTooltipText(gfx::Point()));
EXPECT_EQ(data.GetString16Attribute(ax::mojom::StringAttribute::kDescription),
request_access_button()->GetRenderedTooltipText(gfx::Point()));
}
// Tests that an extension appears in the request access button iff it has a
// site access request that matches the given pattern filter.
TEST_F(ExtensionsToolbarContainerUnitTest,
RequestAccessButton_RequestWithPattern) {
auto extension =
InstallExtensionWithHostPermissions("Extension", {"<all_urls>"});
WithholdHostPermissions(extension.get());
// Navigate to a site and verify request access button is not visible, since
// no extension has added a request.
NavigateAndCommit(GURL("http://www.example.com"));
EXPECT_FALSE(IsRequestAccessButtonVisible());
// Add a site access request with filter that does not match the current web
// contents. Verify request access button is hidden.
URLPattern filter(extensions::Extension::kValidHostPermissionSchemes,
"http://www.other.com/");
AddHostAccessRequest(
*extension, browser()->tab_strip_model()->GetActiveWebContents(), filter);
EXPECT_FALSE(IsRequestAccessButtonVisible());
// Add a site access request with filter that matches the current web
// contents. Verify extension is visible on the request access button.
filter = URLPattern(extensions::Extension::kValidHostPermissionSchemes,
"http://www.example.com/");
AddHostAccessRequest(
*extension, browser()->tab_strip_model()->GetActiveWebContents(), filter);
EXPECT_TRUE(IsRequestAccessButtonVisible());
EXPECT_THAT(request_access_button()->GetExtensionIdsForTesting(),
testing::ElementsAre(extension->id()));
// Add a site access request with filter that does not match the current web
// contents. Verify request access button is hidden (previous request was
// removed).
filter = URLPattern(extensions::Extension::kValidHostPermissionSchemes,
"http://www.other.com/");
AddHostAccessRequest(
*extension, browser()->tab_strip_model()->GetActiveWebContents(), filter);
EXPECT_FALSE(IsRequestAccessButtonVisible());
}
// Tests that an extension's site access request is removed when the extension
// is granted site access.
TEST_F(ExtensionsToolbarContainerUnitTest,
RequestAccessButton_ExtensionGrantedSiteAccess) {
auto extension_A = InstallExtensionWithHostPermissions(
"Extension A", {"*://www.example.com/*"});
auto extension_B =
InstallExtensionWithHostPermissions("Extension B", {"<all_urls>"});
WithholdHostPermissions(extension_A.get());
WithholdHostPermissions(extension_B.get());
// Navigate to a site and verify request access button is not visible, since
// no extension has added a request.
NavigateAndCommit(GURL("http://www.example.com"));
auto* web_contents = browser()->tab_strip_model()->GetActiveWebContents();
EXPECT_FALSE(IsRequestAccessButtonVisible());
// Add site access requests for both extensions and verify they are visible
// on the request access button.
AddHostAccessRequest(*extension_A, web_contents);
AddHostAccessRequest(*extension_B, web_contents);
EXPECT_TRUE(IsRequestAccessButtonVisible());
EXPECT_THAT(request_access_button()->GetExtensionIdsForTesting(),
testing::ElementsAre(extension_A->id(), extension_B->id()));
// Grant site access to extension B and verify request access button only has
// extension A, since extension B's request was removed once the extension
// gained access to the site.
UpdateUserSiteAccess(*extension_B, web_contents,
PermissionsManager::UserSiteAccess::kOnSite);
EXPECT_TRUE(IsRequestAccessButtonVisible());
EXPECT_THAT(request_access_button()->GetExtensionIdsForTesting(),
testing::ElementsAre(extension_A->id()));
}
// Tests that requests are reset on cross-origin navigations.
TEST_F(ExtensionsToolbarContainerUnitTest,
RequestAccessButtonVisibility_NavigationBetweenPages) {
auto extension =
InstallExtensionWithHostPermissions("Extension", {"<all_urls>"});
WithholdHostPermissions(extension.get());
NavigateAndCommit(GURL("http://www.a.com"));
AddHostAccessRequest(*extension,
browser()->tab_strip_model()->GetActiveWebContents());
EXPECT_TRUE(IsRequestAccessButtonVisible());
EXPECT_THAT(request_access_button()->GetExtensionIdsForTesting(),
testing::ElementsAre(extension->id()));
// Navigate to a same-origin site and verify request access button has
// extension.
NavigateAndCommit(GURL("http://www.a.com/path"));
EXPECT_TRUE(IsRequestAccessButtonVisible());
EXPECT_THAT(request_access_button()->GetExtensionIdsForTesting(),
testing::ElementsAre(extension->id()));
// Navigate to a cross-origin site and verify request access button is hidden.
NavigateAndCommit(GURL("http://www.b.com"));
EXPECT_FALSE(IsRequestAccessButtonVisible());
// Navigate to the original site and verify request access button is hidden,
// since requests are reset on cross-origin navigations.
NavigateAndCommit(GURL("http://www.a.com"));
EXPECT_FALSE(IsRequestAccessButtonVisible());
}
// Tests that the request access button is visible for matched patterns on
// same-origin navigations.
TEST_F(ExtensionsToolbarContainerUnitTest,
RequestAccessButton_NavigationBetweenPages_RequestWithPattern) {
auto extension =
InstallExtensionWithHostPermissions("Extension", {"<all_urls>"});
WithholdHostPermissions(extension.get());
// Navigate to a site and verify request access button is hidden, since
// no extension has added a request.
NavigateAndCommit(GURL("http://www.example.com"));
EXPECT_FALSE(IsRequestAccessButtonVisible());
// Add site access request for extension with a filter that doesn't match the
// current web contents. Verify request access button is hidden.
URLPattern filter(extensions::Extension::kValidHostPermissionSchemes,
"*://*/path");
AddHostAccessRequest(
*extension, browser()->tab_strip_model()->GetActiveWebContents(), filter);
EXPECT_FALSE(IsRequestAccessButtonVisible());
// Navigate to a same-origin site that matches the filter. Verify extension is
// visible on the request access button.
NavigateAndCommit(GURL("http://www.example.com/path"));
EXPECT_TRUE(IsRequestAccessButtonVisible());
EXPECT_THAT(request_access_button()->GetExtensionIdsForTesting(),
testing::ElementsAre(extension->id()));
// Add site access request for extension with a filter that doesn't have the
// same origin as the current web contents. Verify request access button is
// hidden.
filter = URLPattern(extensions::Extension::kValidHostPermissionSchemes,
"http://www.other.com/path");
AddHostAccessRequest(
*extension, browser()->tab_strip_model()->GetActiveWebContents(), filter);
EXPECT_FALSE(IsRequestAccessButtonVisible());
// Navigate to a cross-origin site that matches the filters. Since it's a
// cross-origin navigation, requests are reset. Therefore, verify request
// access button is hidden.
NavigateAndCommit(GURL("http://www.other.com/path"));
EXPECT_FALSE(IsRequestAccessButtonVisible());
}
// Test that request access button is visible based on the user site setting
// selected.
TEST_F(ExtensionsToolbarContainerUnitTest,
RequestAccessButton_UserSiteSetting) {
const GURL url("http://www.url.com");
auto url_origin = url::Origin::Create(url);
// Install an extension and withhold permissions so request access button can
// be visible.
auto extension =
InstallExtensionWithHostPermissions("Extension", {"<all_urls>"});
WithholdHostPermissions(extension.get());
// Navigate to url and add a site request for the extension.
NavigateAndCommit(url);
AddHostAccessRequest(*extension,
browser()->tab_strip_model()->GetActiveWebContents());
// A site has "customize by extensions" site setting by default,
ASSERT_EQ(GetUserSiteSetting(url),
PermissionsManager::UserSiteSetting::kCustomizeByExtension);
EXPECT_TRUE(IsRequestAccessButtonVisible());
auto* manager = PermissionsManager::Get(profile());
{
// Request access button is not visible in restricted sites.
extensions::PermissionsManagerWaiter manager_waiter(manager);
manager->AddUserRestrictedSite(url_origin);
manager_waiter.WaitForUserPermissionsSettingsChange();
WaitForAnimation();
EXPECT_FALSE(IsRequestAccessButtonVisible());
}
{
// Request acesss button is visible if site is not restricted,
// and at least one extension has a site access request.
extensions::PermissionsManagerWaiter manager_waiter(manager);
manager->RemoveUserRestrictedSite(url_origin);
manager_waiter.WaitForUserPermissionsSettingsChange();
WaitForAnimation();
EXPECT_TRUE(IsRequestAccessButtonVisible());
}
}
// Tests that an extension with a site access request but not allowed to show
// requests in the toolbar is not shown in the request access button.
TEST_F(ExtensionsToolbarContainerUnitTest,
RequestAccessButton_ExtensionsNotAllowedInButton) {
// Add two extensions that request access to all urls, and withhold their
// site access.
auto extension_a =
InstallExtensionWithHostPermissions("Extension A", {"<all_urls>"});
auto extension_b =
InstallExtensionWithHostPermissions("Extension B", {"<all_urls>"});
WithholdHostPermissions(extension_a.get());
WithholdHostPermissions(extension_b.get());
// By default, both extensions are allowed to show requests in requests access
// button. However, request access button is not visible because we haven't
// navigated to a site yet (and extensions haven't added any site access
// requests).
SitePermissionsHelper permissions_helper(browser()->profile());
EXPECT_TRUE(
permissions_helper.ShowAccessRequestsInToolbar(extension_a->id()));
EXPECT_TRUE(
permissions_helper.ShowAccessRequestsInToolbar(extension_b->id()));
EXPECT_FALSE(IsRequestAccessButtonVisible());
// Navigate to an url that both extensions want access to, and add site access
// requests for both.
const GURL url("http://www.example.com");
NavigateAndCommit(url);
auto* web_contents = browser()->tab_strip_model()->GetActiveWebContents();
AddHostAccessRequest(*extension_a, web_contents);
AddHostAccessRequest(*extension_b, web_contents);
// Verify request access button has both extensions.
EXPECT_TRUE(IsRequestAccessButtonVisible());
EXPECT_EQ(
request_access_button()->GetText(),
l10n_util::GetStringFUTF16Int(IDS_EXTENSIONS_REQUEST_ACCESS_BUTTON, 2));
// Disallow extension A in the request access button. Verify only extension A
// is visible in the button.
permissions_helper.SetShowAccessRequestsInToolbar(extension_a->id(), false);
EXPECT_TRUE(IsRequestAccessButtonVisible());
EXPECT_EQ(
request_access_button()->GetText(),
l10n_util::GetStringFUTF16Int(IDS_EXTENSIONS_REQUEST_ACCESS_BUTTON, 1));
// Disallow extension B in the request access button. Verify button is not
// visible anymore.
permissions_helper.SetShowAccessRequestsInToolbar(extension_b->id(), false);
EXPECT_FALSE(IsRequestAccessButtonVisible());
}
// Test that an extension's request which is dismissed is not visible in the
// request access button.
TEST_F(ExtensionsToolbarContainerUnitTest,
RequestAccessButton_RequestDismissed) {
// Add two extensions that request access to all urls, and withhold their
// site access.
auto extension_a =
InstallExtensionWithHostPermissions("Extension A", {"<all_urls>"});
auto extension_b =
InstallExtensionWithHostPermissions("Extension B", {"<all_urls>"});
WithholdHostPermissions(extension_a.get());
WithholdHostPermissions(extension_b.get());
// By default, both extensions are allowed to show requests in requests access
// button. However, request access button is not visible because we haven't
// navigated to a site yet (and extensions haven't added any site access
// requests).
SitePermissionsHelper permissions_helper(browser()->profile());
EXPECT_TRUE(
permissions_helper.ShowAccessRequestsInToolbar(extension_a->id()));
EXPECT_TRUE(
permissions_helper.ShowAccessRequestsInToolbar(extension_b->id()));
EXPECT_FALSE(IsRequestAccessButtonVisible());
// Navigate to an url that both extensions want access to, and add site access
// requests for both.
const GURL url("http://www.example.com");
NavigateAndCommit(url);
auto* web_contents = browser()->tab_strip_model()->GetActiveWebContents();
AddHostAccessRequest(*extension_a, web_contents);
AddHostAccessRequest(*extension_b, web_contents);
// Verify request access button has both extensions.
EXPECT_TRUE(IsRequestAccessButtonVisible());
EXPECT_EQ(
request_access_button()->GetText(),
l10n_util::GetStringFUTF16Int(IDS_EXTENSIONS_REQUEST_ACCESS_BUTTON, 2));
int tab_id = extensions::ExtensionTabUtil::GetTabId(web_contents);
auto* permissions_manager = extensions::PermissionsManager::Get(profile());
// Dismiss extension A's requests. Verify only extension B is visible in the
// button.
permissions_manager->UserDismissedHostAccessRequest(web_contents, tab_id,
extension_a->id());
EXPECT_TRUE(IsRequestAccessButtonVisible());
EXPECT_EQ(
request_access_button()->GetText(),
l10n_util::GetStringFUTF16Int(IDS_EXTENSIONS_REQUEST_ACCESS_BUTTON, 1));
// Dismiss extension B's requests. Verify button is not visible anymore.
permissions_manager->UserDismissedHostAccessRequest(web_contents, tab_id,
extension_b->id());
EXPECT_FALSE(IsRequestAccessButtonVisible());
}
TEST_F(ExtensionsToolbarContainerUnitTest,
RequestAccessButton_OnPressedExecuteAction) {
auto extension =
InstallExtensionWithHostPermissions("Extension", {"<all_urls>"});
WithholdHostPermissions(extension.get());
// Navigate to url and add a site access request for extension.
const GURL url("http://www.example.com");
NavigateAndCommit(url);
AddHostAccessRequest(*extension,
browser()->tab_strip_model()->GetActiveWebContents());
LayoutContainerIfNecessary();
constexpr char kActivatedUserAction[] =
"Extensions.Toolbar.ExtensionsActivatedFromRequestAccessButton";
base::UserActionTester user_action_tester;
auto* permissions = PermissionsManager::Get(profile());
// Request access button is visible because the extension is requesting
// access.
ASSERT_TRUE(request_access_button()->GetVisible());
EXPECT_EQ(user_action_tester.GetActionCount(kActivatedUserAction), 0);
EXPECT_EQ(permissions->GetUserSiteAccess(*extension, url),
PermissionsManager::UserSiteAccess::kOnClick);
// Extension menu button has default state since extensions are not blocked,
// and there is no extension with access to the site.
EXPECT_EQ(extensions_button()->state(),
ExtensionsToolbarButton::State::kDefault);
extensions::PermissionsManagerWaiter waiter(
PermissionsManager::Get(profile()));
ClickButton(request_access_button());
waiter.WaitForExtensionPermissionsUpdate();
WaitForAnimation();
LayoutContainerIfNecessary();
// Verify extension was executed and extensions menu button has "any
// extension has access" state. Extension's site access should be "on site",
// since clicking the button grants always access to that site.
EXPECT_EQ(user_action_tester.GetActionCount(kActivatedUserAction), 1);
EXPECT_EQ(extensions_button()->state(),
ExtensionsToolbarButton::State::kAnyExtensionHasAccess);
EXPECT_EQ(permissions->GetUserSiteAccess(*extension, url),
PermissionsManager::UserSiteAccess::kOnSite);
// Verify confirmation message appears on the request access button.
EXPECT_TRUE(request_access_button()->GetVisible());
EXPECT_EQ(request_access_button()->GetText(),
l10n_util::GetStringUTF16(
IDS_EXTENSIONS_REQUEST_ACCESS_BUTTON_DISMISSED_TEXT));
// Force the confirmation to be collapsed.
task_environment()->AdvanceClock(kConfirmationDisplayDuration);
base::RunLoop().RunUntilIdle();
WaitForAnimation();
// Verify the request access button is hidden.
ASSERT_FALSE(request_access_button()->GetVisible());
}
// Tests that if an update comes in between the request access button is clicked
// and the confirmation is collapsed, the button is updated afterwards with the
// correct information.
TEST_F(ExtensionsToolbarContainerUnitTest,
RequestAccessButton_UpdateInBetweenClickAndConfirmationCollapse) {
auto extension_A =
InstallExtensionWithHostPermissions("Extension A", {"<all_urls>"});
auto extension_B =
InstallExtensionWithHostPermissions("Extension B", {"<all_urls>"});
auto extension_C =
InstallExtensionWithHostPermissions("Extension C", {"<all_urls>"});
WithholdHostPermissions(extension_A.get());
WithholdHostPermissions(extension_B.get());
WithholdHostPermissions(extension_C.get());
const GURL url("http://www.example.com");
NavigateAndCommit(url);
LayoutContainerIfNecessary();
// Add site access requests for extension A and B.
auto* web_contents = browser()->tab_strip_model()->GetActiveWebContents();
AddHostAccessRequest(*extension_A, web_contents);
AddHostAccessRequest(*extension_B, web_contents);
LayoutContainerIfNecessary();
// Request access button is visible because extension A and B have site access
// requests.
EXPECT_TRUE(request_access_button()->GetVisible());
EXPECT_THAT(request_access_button()->GetExtensionIdsForTesting(),
testing::ElementsAre(extension_A->id(), extension_B->id()));
ClickButton(request_access_button());
WaitForAnimation();
LayoutContainerIfNecessary();
// Verify confirmation message appears on the request access button after
// clicking on it
EXPECT_TRUE(request_access_button()->GetVisible());
EXPECT_EQ(request_access_button()->GetText(),
l10n_util::GetStringUTF16(
IDS_EXTENSIONS_REQUEST_ACCESS_BUTTON_DISMISSED_TEXT));
// Add a site access request for extension C before the confirmation is
// collapsed.
AddHostAccessRequest(*extension_C, web_contents);
// Confirmation is still showing since collapse time hasn't elapsed.
EXPECT_TRUE(request_access_button()->GetVisible());
EXPECT_EQ(request_access_button()->GetText(),
l10n_util::GetStringUTF16(
IDS_EXTENSIONS_REQUEST_ACCESS_BUTTON_DISMISSED_TEXT));
// Force the confirmation to be collapsed.
task_environment()->AdvanceClock(kConfirmationDisplayDuration);
base::RunLoop().RunUntilIdle();
// Verify the request access button is visible since extension C is now
// requesting access.
EXPECT_TRUE(request_access_button()->GetVisible());
EXPECT_THAT(request_access_button()->GetExtensionIdsForTesting(),
testing::ElementsAre(extension_C->id()));
}
class ExtensionsToolbarContainerWithPermittedSitesUnitTest
: public ExtensionsToolbarContainerUnitTest {
public:
ExtensionsToolbarContainerWithPermittedSitesUnitTest() {
std::vector<base::test::FeatureRef> enabled_features = {
extensions_features::kExtensionsMenuAccessControl,
extensions_features::kExtensionsMenuAccessControlWithPermittedSites};
std::vector<base::test::FeatureRef> disabled_features;
feature_list_.InitWithFeatures(enabled_features, disabled_features);
}
ExtensionsToolbarContainerWithPermittedSitesUnitTest(
const ExtensionsToolbarContainerWithPermittedSitesUnitTest&) = delete;
const ExtensionsToolbarContainerWithPermittedSitesUnitTest& operator=(
const ExtensionsToolbarContainerWithPermittedSitesUnitTest&) = delete;
~ExtensionsToolbarContainerWithPermittedSitesUnitTest() override = default;
private:
base::test::ScopedFeatureList feature_list_;
};
// Test that request access button is visible based on the user site setting
// selected.
TEST_F(ExtensionsToolbarContainerWithPermittedSitesUnitTest,
RequestAccessButtonVisibilityOnPermittedSites) {
const GURL url("http://www.url.com");
auto url_origin = url::Origin::Create(url);
// Install an extension and withhold permissions so request access button can
// be visible.
auto extension =
InstallExtensionWithHostPermissions("Extension", {"<all_urls>"});
WithholdHostPermissions(extension.get());
// Navigate to a site and add a site access request for the extension.
NavigateAndCommit(url);
auto* web_contents = browser()->tab_strip_model()->GetActiveWebContents();
AddHostAccessRequest(*extension, web_contents);
// A site has "customize by extensions" site setting by default,
ASSERT_EQ(GetUserSiteSetting(url),
PermissionsManager::UserSiteSetting::kCustomizeByExtension);
EXPECT_TRUE(IsRequestAccessButtonVisible());
// Request access button is not visible in permitted sites.
auto* manager = PermissionsManager::Get(profile());
extensions::PermissionsManagerWaiter waiter(manager);
manager->AddUserPermittedSite(url_origin);
waiter.WaitForUserPermissionsSettingsChange();
WaitForAnimation();
// Request access button visibility is the same for other site settings, which
// is already tested, regardless of whether permitted sites are supported or
// not.
}
|