1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
|
// Copyright 2016 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ui/views/frame/browser_non_client_frame_view.h"
#include "base/functional/bind.h"
#include "base/memory/raw_ptr.h"
#include "build/build_config.h"
#include "chrome/browser/themes/theme_properties.h"
#include "chrome/browser/themes/theme_service.h"
#include "chrome/browser/themes/theme_service_factory.h"
#include "chrome/browser/ui/layout_constants.h"
#include "chrome/browser/ui/views/frame/browser_view.h"
#include "chrome/browser/ui/views/frame/tab_strip_region_view.h"
#include "chrome/browser/ui/views/frame/test_with_browser_view.h"
#include "chrome/browser/ui/views/tabs/tab_strip.h"
#include "ui/base/ui_base_switches.h"
#include "ui/views/test/widget_test.h"
#include "url/gurl.h"
class BrowserNonClientFrameViewTest : public TestWithBrowserView {
public:
explicit BrowserNonClientFrameViewTest(Browser::Type type)
: TestWithBrowserView(type) {}
BrowserNonClientFrameViewTest(const BrowserNonClientFrameViewTest&) = delete;
BrowserNonClientFrameViewTest& operator=(
const BrowserNonClientFrameViewTest&) = delete;
// TestWithBrowserView override:
void SetUp() override {
TestWithBrowserView::SetUp();
views::Widget* widget = browser_view()->GetWidget();
frame_view_ = static_cast<BrowserNonClientFrameView*>(
widget->non_client_view()->frame_view());
}
protected:
// Owned by the browser view.
raw_ptr<BrowserNonClientFrameView, DanglingUntriaged> frame_view_ = nullptr;
};
class BrowserNonClientFrameViewPopupTest
: public BrowserNonClientFrameViewTest {
public:
BrowserNonClientFrameViewPopupTest()
: BrowserNonClientFrameViewTest(Browser::TYPE_POPUP) {}
};
// TODO(crbug.com/41478509): Flaky on Linux TSAN and ASAN.
#if (BUILDFLAG(IS_LINUX) || BUILDFLAG(IS_CHROMEOS)) && \
(defined(ADDRESS_SANITIZER) || defined(THREAD_SANITIZER))
#define MAYBE_HitTestPopupTopChrome DISABLED_HitTestPopupTopChrome
#else
#define MAYBE_HitTestPopupTopChrome HitTestPopupTopChrome
#endif
TEST_F(BrowserNonClientFrameViewPopupTest, MAYBE_HitTestPopupTopChrome) {
constexpr gfx::Rect kLeftOfFrame(-1, 4, 1, 1);
EXPECT_FALSE(frame_view_->HitTestRect(kLeftOfFrame));
constexpr gfx::Rect kAboveFrame(4, -1, 1, 1);
EXPECT_FALSE(frame_view_->HitTestRect(kAboveFrame));
const int top_inset = frame_view_->GetTopInset(false);
const gfx::Rect in_browser_view(4, top_inset, 1, 1);
EXPECT_TRUE(frame_view_->HitTestRect(in_browser_view));
}
class BrowserNonClientFrameViewTabbedTest
: public BrowserNonClientFrameViewTest {
public:
BrowserNonClientFrameViewTabbedTest()
: BrowserNonClientFrameViewTest(Browser::TYPE_NORMAL) {}
};
// TODO(crbug.com/40101869): Flaky on Linux TSAN.
#if (BUILDFLAG(IS_LINUX) || BUILDFLAG(IS_CHROMEOS)) && defined(THREAD_SANITIZER)
#define MAYBE_HitTestTabstrip DISABLED_HitTestTabstrip
#else
#define MAYBE_HitTestTabstrip HitTestTabstrip
#endif
TEST_F(BrowserNonClientFrameViewTabbedTest, MAYBE_HitTestTabstrip) {
// Add a tab because the browser starts out without any tabs at all.
AddTab(browser(), GURL("about:blank"));
const gfx::Rect frame_bounds = frame_view_->bounds();
gfx::RectF tabstrip_bounds_in_frame_coords(
frame_view_->browser_view()->tabstrip()->GetLocalBounds());
views::View::ConvertRectToTarget(frame_view_->browser_view()->tabstrip(),
frame_view_,
&tabstrip_bounds_in_frame_coords);
const gfx::Rect tabstrip_bounds =
gfx::ToEnclosingRect(tabstrip_bounds_in_frame_coords);
EXPECT_FALSE(tabstrip_bounds.IsEmpty());
// Completely outside the frame's bounds.
EXPECT_FALSE(frame_view_->HitTestRect(
gfx::Rect(frame_bounds.x() - 1, frame_bounds.y() + 1, 1, 1)));
EXPECT_FALSE(frame_view_->HitTestRect(
gfx::Rect(frame_bounds.x() + 1, frame_bounds.y() - 1, 1, 1)));
// Hits client portions of the tabstrip (near the bottom left corner of the
// first tab).
EXPECT_TRUE(frame_view_->HitTestRect(gfx::Rect(
tabstrip_bounds.x() + 10, tabstrip_bounds.bottom() - 10, 1, 1)));
EXPECT_TRUE(frame_view_->browser_view()->HitTestRect(gfx::Rect(
tabstrip_bounds.x() + 10, tabstrip_bounds.bottom() - 10, 1, 1)));
// Tabs extend to the top of the tabstrip everywhere in this test context on
// ChromeOS, so there is no non-client area in the tab strip to test for.
// TODO (tbergquist): Investigate whether we can key off this condition in an
// OS-agnostic way.
#if !BUILDFLAG(IS_CHROMEOS)
// Hits non-client portions of the tab strip (the top left corner of the
// first tab).
EXPECT_TRUE(frame_view_->HitTestRect(
gfx::Rect(tabstrip_bounds.x(), tabstrip_bounds.y(), 1, 1)));
#endif
// Hits tab strip and the browser-client area.
EXPECT_TRUE(frame_view_->HitTestRect(
gfx::Rect(tabstrip_bounds.x() + 1,
tabstrip_bounds.bottom() -
GetLayoutConstant(TABSTRIP_TOOLBAR_OVERLAP) - 1,
100, 100)));
}
|
